[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

NoQ added a comment. In https://reviews.llvm.org/D41406#970985, @xazax.hun wrote: > Do you have a plan for the new false negatives when `c++-allocator-inlining` > is on? Should the user mark allocation functions with attributes? Not immediately - the immediate plan is to simply believe that we

[PATCH] D41799: [analyzer] PtrArithChecker: Update to use check::NewAllocator

NoQ planned changes to this revision. NoQ added a comment. https://reviews.llvm.org/D41250#971888 reverts the change in how casts work, and the checker doesn't really need the casted value, because it only tracks the pointer. This still leaves us with the problem of `PostStmt` being called twi

[PATCH] D41796: [analyzer] Fix extent modeling for casted operator new values.

NoQ abandoned this revision. NoQ added a comment. > is not quite intended (but not addressed yet) https://reviews.llvm.org/D41250#971888 addresses the issue. > However, if the operator is inlined It isn't. Because if it is inlined, `MallocChecker` bails out immediately and doesn't try to model

[PATCH] D41795: [analyzer] Inline destructors for non-array deletes.

NoQ abandoned this revision. NoQ added a comment. > because the new behavior of operator new is to return an ElementRegion > surrounding the void pointer The new behavior was reverted in https://reviews.llvm.org/D41250#971888 so this patch is no longer useful. Repository: rC Clang https://

[PATCH] D41800: [analyzer] Use a custom program point for the check::NewAllocator callback.

NoQ added inline comments. Comment at: include/clang/Analysis/ProgramPoint.h:592 + friend class ProgramPoint; + PostAllocatorCall() {} + static bool isKind(const ProgramPoint &Location) { xazax.hun wrote: > Maybe `= default` is getting more canonical within LL

[PATCH] D41800: [analyzer] Use a custom program point for the check::NewAllocator callback.

NoQ updated this revision to Diff 129215. NoQ marked an inline comment as done. NoQ added a comment. Fix the comment. https://reviews.llvm.org/D41800 Files: include/clang/Analysis/ProgramPoint.h lib/StaticAnalyzer/Core/CheckerManager.cpp lib/StaticAnalyzer/Core/CoreEngine.cpp lib/Static

[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

NoQ updated this revision to Diff 129214. NoQ marked 6 inline comments as done. NoQ added a comment. Address review comments. Stick to the callback approach for now. https://reviews.llvm.org/D41406 Files: include/clang/StaticAnalyzer/Core/Checker.h include/clang/StaticAnalyzer/Core/CheckerM

[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

NoQ added inline comments. Comment at: include/clang/StaticAnalyzer/Core/CheckerManager.h:311 + ExprEngine &Eng, + bool wasInlined = false); + dcoughlin wrote: > Does 'wasInlined' really need to ha

[PATCH] D41266: [analyzer] With c++-allocator-inlining, fix memory space for operator new pointers.

NoQ updated this revision to Diff 129213. NoQ added a comment. Rebase. Address the comment. In https://reviews.llvm.org/D41266#959763, @NoQ wrote: > Remove the redundant cast that is done in `c++-allocator-inlining` mode when > modeling array new. After rebase it started causing two identical e

[PATCH] D41266: [analyzer] With c++-allocator-inlining, fix memory space for operator new pointers.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:477 +bool ExprEngine::isStandardGlobalOperatorNewFunction(const CXXNewExpr *CNE) { + const FunctionDecl *FD = CNE->getOperatorNew(); + if (FD && !isa(FD) && !FD->isVariadic()) { dc

[PATCH] D41250: [analyzer] Model implied cast around operator new().

NoQ updated this revision to Diff 129212. NoQ added a comment. In https://reviews.llvm.org/D41250#959755, @NoQ wrote: > > I also noticed that `evalCast` from `void *` to `T *` is uncomfortable to > > use because sometimes it transforms `&SymRegion{$x}` into `&element{T, > > 0S32b, SymRegion{$x}

[PATCH] D40939: [analyzer] NFC: Avoid element regions of void type.

NoQ updated this revision to Diff 129211. NoQ added a comment. Rebase. https://reviews.llvm.org/D40939 Files: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp Index: lib/StaticAnalyzer/Core/S

[PATCH] D40560: [analyzer] Get construction into `operator new` running in simple cases.

NoQ updated this revision to Diff 129210. NoQ added a comment. That thing didn't immediately work, because there are a lot of other places where we need to put the value, not just the Store, before entering the constructor - such as our constructor call events for checker callbacks. It'd be har

Re: r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

On 9 January 2018 at 18:46, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Eric, > > On Mon, Jan 8, 2018 at 9:31 PM, Eric Fiselier wrote: > > I haven't done a ton of investigation yet, but I suspect this commit is > > responsible for breaking my LLVM module selfhost

Re: r321855 - Reapply r321781: [Modules] Allow modules specified by -fmodule-map-file to shadow implicitly found ones

Hi Eric, On Mon, Jan 8, 2018 at 9:31 PM, Eric Fiselier wrote: > I haven't done a ton of investigation yet, but I suspect this commit is > responsible for breaking my LLVM module selfhost build, which uses libc++ as > the STL, and builds LLD (No bots appear to test this configuration). > > The err

r322155 - Revert "[Driver] Update default sanitizer blacklist location"

Author: phosek Date: Tue Jan 9 18:24:09 2018 New Revision: 322155 URL: http://llvm.org/viewvc/llvm-project?rev=322155&view=rev Log: Revert "[Driver] Update default sanitizer blacklist location" This reverts commit r322154 because it broke sanitizer bots. Added: cfe/trunk/test/Driver/Inputs/

[PATCH] D41546: [clang-tidy] Adding Fuchsia checker for statically constructed objects

juliehockett updated this revision to Diff 129208. juliehockett marked 5 inline comments as done. juliehockett added a comment. Updating matcher to catch dynamically initialized constructors and fixing comments. https://reviews.llvm.org/D41546 Files: clang-tidy/fuchsia/CMakeLists.txt clang

r322154 - [Driver] Update default sanitizer blacklist location

Author: phosek Date: Tue Jan 9 18:12:24 2018 New Revision: 322154 URL: http://llvm.org/viewvc/llvm-project?rev=322154&view=rev Log: [Driver] Update default sanitizer blacklist location This is related to moving the sanitizer blacklists to share/ subdirectory. Differential Revision: https://revi

[PATCH] D41706: [Driver] Update default sanitizer blacklist location

This revision was automatically updated to reflect the committed changes. Closed by commit rC322154: [Driver] Update default sanitizer blacklist location (authored by phosek, committed by ). Repository: rC Clang https://reviews.llvm.org/D41706 Files: lib/Driver/SanitizerArgs.cpp test/Driv

Re: r310427 - Sema: disable implicit conversion from _Complex to real types in C++.

On 8 August 2017 at 16:18, Tim Northover via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: tnorthover > Date: Tue Aug 8 16:18:05 2017 > New Revision: 310427 > > URL: http://llvm.org/viewvc/llvm-project?rev=310427&view=rev > Log: > Sema: disable implicit conversion from _Complex to re

[PATCH] D41790: [analyzer] [NFC] minor FindLastStoreBRVisitor refactoring

This revision was automatically updated to reflect the committed changes. Closed by commit rC322150: [analyzer] [NFC] minor FindLastStoreBRVisitor refactoring (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D41751: [analyzer] [NFC] Minor refactoring of trackNullOrUndefValue

This revision was automatically updated to reflect the committed changes. Closed by commit rC322151: [analyzer] [NFC] Minor refactoring of trackNullOrUndefValue (authored by george.karpenkov, committed by ). Repository: rC Clang https://reviews.llvm.org/D41751 Files: lib/StaticAnalyzer/Core

r322151 - [analyzer] [NFC] Minor refactoring of trackNullOrUndefValue

Author: george.karpenkov Date: Tue Jan 9 17:30:32 2018 New Revision: 322151 URL: http://llvm.org/viewvc/llvm-project?rev=322151&view=rev Log: [analyzer] [NFC] Minor refactoring of trackNullOrUndefValue Simple refactoring attempt: factor out some code, remove some repetition, use auto where appro

r322150 - [analyzer] [NFC] minor FindLastStoreBRVisitor refactoring

Author: george.karpenkov Date: Tue Jan 9 17:30:31 2018 New Revision: 322150 URL: http://llvm.org/viewvc/llvm-project?rev=322150&view=rev Log: [analyzer] [NFC] minor FindLastStoreBRVisitor refactoring Differential Revision: https://reviews.llvm.org/D41790 Modified: cfe/trunk/lib/StaticAnalyz

[PATCH] D41749: [analyzer] suppress nullability inference from a macro when result is used in another macro

This revision was automatically updated to reflect the committed changes. Closed by commit rC322149: [analyzer] suppress nullability inference from a macro when result is used in… (authored by george.karpenkov, committed by ). Changed prior to commit: https://reviews.llvm.org/D41749?vs=128688&i

r322149 - [analyzer] suppress nullability inference from a macro when result is used in another macro

Author: george.karpenkov Date: Tue Jan 9 17:22:14 2018 New Revision: 322149 URL: http://llvm.org/viewvc/llvm-project?rev=322149&view=rev Log: [analyzer] suppress nullability inference from a macro when result is used in another macro The current code used to not suppress the report, if the dere

[PATCH] D40677: [libcxx] Make std::basic_istream::get 0-terminate input array in case of error.

vsapsai added a comment. Ping. https://reviews.llvm.org/D40677 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r322147 - [cmake] Delete redundant install command for clang-refactor.

Author: dhinton Date: Tue Jan 9 17:00:28 2018 New Revision: 322147 URL: http://llvm.org/viewvc/llvm-project?rev=322147&view=rev Log: [cmake] Delete redundant install command for clang-refactor. Summary: Install targets for clang tools are controlled by CLANG_BUILD_TOOLS, and when OFF, cmake issu

[PATCH] D41807: [cmake] Delete redundant install command for clang-refactor.

This revision was automatically updated to reflect the committed changes. Closed by commit rC322147: [cmake] Delete redundant install command for clang-refactor. (authored by dhinton, committed by ). Changed prior to commit: https://reviews.llvm.org/D41807?vs=128864&id=129192#toc Repository:

[PATCH] D41213: [libcxx] [test] Improve MSVC portability.

STL_MSFT closed this revision. STL_MSFT added a comment. Thanks, I've checked this in as-is. I would support an LWG issue to change the Standardese here. https://reviews.llvm.org/D41213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[libcxx] r322144 - [libcxx] [test] Improve MSVC portability.

Author: stl_msft Date: Tue Jan 9 16:39:46 2018 New Revision: 322144 URL: http://llvm.org/viewvc/llvm-project?rev=322144&view=rev Log: [libcxx] [test] Improve MSVC portability. test/support/msvc_stdlib_force_include.hpp When testing MSVC's STL with C1XX, simulate a couple more compiler feature-te

[PATCH] D41889: [libcxxabi][demangler] Clean up and llvm-ify the type parser

erik.pilkington created this revision. erik.pilkington added reviewers: EricWF, mclow.lists, dexonsmith. As of https://reviews.llvm.org/D41885, every parse_* function now either returns a single Node* or fails. I'm using this new rule to clean up the parsing for the demangler, and also update it

r322136 - Reland "Emit Function IDs table for Control Flow Guard"

Author: amccarth Date: Tue Jan 9 15:49:30 2018 New Revision: 322136 URL: http://llvm.org/viewvc/llvm-project?rev=322136&view=rev Log: Reland "Emit Function IDs table for Control Flow Guard" Adds option /guard:cf to clang-cl and -cfguard to cc1 to emit function IDs of functions that have their ad

[PATCH] D41887: [libcxxabi][demangler] Clean up and llvm-ify the expression parser

erik.pilkington created this revision. erik.pilkington added reviewers: EricWF, mclow.lists, dexonsmith. As of https://reviews.llvm.org/D41885, every parse_* function now either returns a single Node* or fails. I'm using this new rule to clean up the parsing for the demangler, and also update it

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

erik.pilkington added inline comments. Comment at: src/cxa_demangle.cpp:130 - // Offset of position in buffer, used for building stream_string_view. - typedef unsigned StreamPosition; - This caching API is being removed because it is no longer valid: if a node

[PATCH] D41885: [libcxxabi][demangler] Improve handling of variadic templates

erik.pilkington created this revision. erik.pilkington added reviewers: EricWF, mclow.lists, dexonsmith. This patch fixes some longstanding bugs in the demangler to do with it's handling of variadic templates. Currently the demangler handles variadic templates by expanding them into the Names s

[PATCH] D41807: [cmake] Delete redundant install command for clang-refactor.

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D41807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

NoQ added a comment. But still, i guess, it is also easier for checker authors to discover a checker callback (it's right there in the `CheckerDocumentation`, which is short enough to read fully) than to discover a `CallEvent` sub-class (which was so hard that i never discovered it until like n

[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

NoQ added a comment. > Like, make a new `CallEvent` sub-class called, say, `CXXNewAllocatorCall` Oh, we already have it (`CXXAllocatorCall`). https://reviews.llvm.org/D41406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D41213: [libcxx] [test] Improve MSVC portability.

mclow.lists added a comment. Investigating the assignability of `not_fn`. All the rest of this looks fine. https://reviews.llvm.org/D41213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

r322126 - Wire up GCOV to the new pass manager

Author: dblaikie Date: Tue Jan 9 14:03:47 2018 New Revision: 322126 URL: http://llvm.org/viewvc/llvm-project?rev=322126&view=rev Log: Wire up GCOV to the new pass manager GCOV in the old pass manager also strips debug info (if debug info is disabled/only produced for profiling anyway) after the

[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

NoQ added a comment. > which would re-evaluate the cast and return the casted object Rather not. Because i'm changing my mind again about avoiding the redundant cast in `&element{T, HeapSymRegion{conj}}` - this time by not calling `evalCast` after a conservatively evaluated operator new call (t

[PATCH] D41867: [Frontend] Remove unused FileMgr in pp arg parse

modocache added a comment. Great, thanks for the review, @v.g.vassilev! Repository: rC Clang https://reviews.llvm.org/D41867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r322118 - [Frontend] Remove unused FileMgr in pp arg parse

Author: modocache Date: Tue Jan 9 13:26:47 2018 New Revision: 322118 URL: http://llvm.org/viewvc/llvm-project?rev=322118&view=rev Log: [Frontend] Remove unused FileMgr in pp arg parse Summary: A FIXME added 8 years ago (2010) in https://reviews.llvm.org/rL118203 mentioned that a FileManager shou

[PATCH] D41867: [Frontend] Remove unused FileMgr in pp arg parse

This revision was automatically updated to reflect the committed changes. Closed by commit rC322118: [Frontend] Remove unused FileMgr in pp arg parse (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D41867?vs=129089&id=129152#toc Repository: rC Clang

[PATCH] D41213: [libcxx] [test] Improve MSVC portability.

mclow.lists added a comment. > According to 15.8.2 [class.copy.assign]/2 and /4, this makes call_wrapper > non-assignable. Then I think we've got a LWG issue, because that's not what I remember the intent to have been. https://reviews.llvm.org/D41213 ___

[PATCH] D41881: [analyzer] Flag bcmp, bcopy and bzero as obsolete

trixirt created this revision. trixirt added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, a.sidorin, szepet, xazax.hun. bcmp, bcopy and bzero are obsolete functions. Flag them as such so users will not use them. Repository: rC Clang https://reviews.llvm.org/D41881 Files: i

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

oren_ben_simhon created this revision. oren_ben_simhon added reviewers: erichkeane, craig.topper, AndreiGrischenko, aaboud. Herald added subscribers: llvm-commits, javed.absar. The patch adds nocf_check target independent attribute for disabling checks that were enabled by cf-protection flag. Th

[PATCH] D41516: emmintrin.h documentation fixes and updates

efriedma added inline comments. Comment at: cfe/trunk/lib/Headers/emmintrin.h:4683 /// -/// This intrinsic has no corresponding instruction. +/// This intrinsic corresponds to the MOVDQ2Q instruction. /// kromanova wrote: > efriedma wrote: > > kromanova wrote

Re: r322112 - [OPENMP] Fix directive kind on stand-alone target data directives, NFC.

Why is this NFC and doesn't change a test? Am 2018-01-09 20:59, schrieb Alexey Bataev via cfe-commits: Author: abataev Date: Tue Jan 9 11:59:25 2018 New Revision: 322112 URL: http://llvm.org/viewvc/llvm-project?rev=322112&view=rev Log: [OPENMP] Fix directive kind on stand-alone target data dir

[clang-tools-extra] r322116 - Try to fix build failure caused by r322097

Author: ioeric Date: Tue Jan 9 12:26:49 2018 New Revision: 322116 URL: http://llvm.org/viewvc/llvm-project?rev=322116&view=rev Log: Try to fix build failure caused by r322097 Avoid mapping during output when Detail is nullptr; otherwise, an empty "Detail" field will be populated in YAML output.

[PATCH] D41867: [Frontend] Remove unused FileMgr in pp arg parse

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D41867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D41213: [libcxx] [test] Improve MSVC portability.

STL_MSFT added a comment. Ping? (And happy Patch Tuesday!) https://reviews.llvm.org/D41213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37650: [continued] Add a way to get the CXCursor that corresponds to a completion result

svenbrauch added a comment. I know it breaks ABI compatiblity, I just don't know whether it needs to be kept (e.g. for clang-6.0). The alternative requires sorting by a separate index list which is a bit ugly (and slower). If you feel like working on it in the next few days that would of course

r322112 - [OPENMP] Fix directive kind on stand-alone target data directives, NFC.

Author: abataev Date: Tue Jan 9 11:59:25 2018 New Revision: 322112 URL: http://llvm.org/viewvc/llvm-project?rev=322112&view=rev Log: [OPENMP] Fix directive kind on stand-alone target data directives, NFC. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp Modified: cfe/trunk/lib/CodeGen/CG

[PATCH] D41754: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek updated this revision to Diff 129140. Repository: rCXXA libc++abi https://reviews.llvm.org/D41754 Files: src/CMakeLists.txt Index: src/CMakeLists.txt === --- src/CMakeLists.txt +++ src/CMakeLists.txt @@ -180,10 +180,11

[PATCH] D41755: [CMake] Collect target names in the global LLVM_RUNTIMES property

phosek updated this revision to Diff 129138. Repository: rCXX libc++ https://reviews.llvm.org/D41755 Files: lib/CMakeLists.txt Index: lib/CMakeLists.txt === --- lib/CMakeLists.txt +++ lib/CMakeLists.txt @@ -356,10 +356,11 @@

[PATCH] D41841: [OpenMP] Fix handling of clause on wrong directive

This revision was automatically updated to reflect the committed changes. Closed by commit rL322107: [OpenMP] Fix handling of clause on wrong directive, by Joel. E. Denny (authored by ABataev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r322107 - [OpenMP] Fix handling of clause on wrong directive, by Joel. E. Denny

Author: abataev Date: Tue Jan 9 11:21:04 2018 New Revision: 322107 URL: http://llvm.org/viewvc/llvm-project?rev=322107&view=rev Log: [OpenMP] Fix handling of clause on wrong directive, by Joel. E. Denny Summary: First, this patch fixes an assert failure when, for example, "omp for" has num_teams

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

mclow.lists added inline comments. Comment at: src/experimental/filesystem/operations.cpp:699 auto count = remove_all_impl(p, mec); if (mec) { +if (mec != errc::no_such_file_or_directory) { I don't think that this is quite right, either. In the

[PATCH] D41841: [OpenMP] Fix handling of clause on wrong directive

ABataev added a comment. In https://reviews.llvm.org/D41841#971375, @jdenny wrote: > Alexey: Thanks for accepting. I do not have commit privileges. Would > you please commit for me? Sure https://reviews.llvm.org/D41841 ___ cfe-commits mailing li

[PATCH] D41841: [OpenMP] Fix handling of clause on wrong directive

jdenny added a comment. Alexey: Thanks for accepting. I do not have commit privileges. Would you please commit for me? https://reviews.llvm.org/D41841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

mclow.lists added inline comments. Comment at: src/experimental/filesystem/operations.cpp:666 if (::remove(p.c_str()) == -1) { -set_or_throw(ec, "remove", p); +if (ec != nullptr && *ec != errc::no_such_file_or_directory) +set_or_throw(ec, "remove"

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

vsapsai updated this revision to Diff 129125. vsapsai added a comment. - Don't parse exponent past the end of token, add same test+fix for hexadecimal numbers. https://reviews.llvm.org/D41834 Files: clang/lib/Lex/LiteralSupport.cpp clang/test/Lexer/cxx1y_digit_separators.cpp Index: clang

[PATCH] D41841: [OpenMP] Fix handling of clause on wrong directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D41841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

rjmccall added inline comments. Comment at: include/clang/Basic/Attr.td:239 + bit IncludeC = includeC; +} aaron.ballman wrote: > rjmccall wrote: > > aaron.ballman wrote: > > > rjmccall wrote: > > > > I have no objection to allowing ObjC attributes to be spelle

[PATCH] D41830: [libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if the file doesn't exist

TyanNN updated this revision to Diff 129115. TyanNN retitled this revision from "[libc++] Fix PR#35780 - make std::experimental::filesystem::remove return false if the file doesn't exist" to "[libc++] Fix PR#35780 - make std::experimental::filesystem::remove and remove_all return false or 0 if t

[PATCH] D41823: [clangd] Add more filters for collected symbols.

ioeric updated this revision to Diff 129112. ioeric added a comment. - Rebase on origin/master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41823 Files: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp clangd/index/FileIndex.cpp clangd/index/SymbolCollector.cpp

[clang-tools-extra] r322097 - [clangd] Add more symbol information for code completion.

Author: ioeric Date: Tue Jan 9 09:32:00 2018 New Revision: 322097 URL: http://llvm.org/viewvc/llvm-project?rev=322097&view=rev Log: [clangd] Add more symbol information for code completion. Reviewers: hokein, sammccall Reviewed By: sammccall Subscribers: klimek, ilya-biryukov, cfe-commits Dif

[PATCH] D41345: [clangd] Add more symbol information for code completion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE322097: [clangd] Add more symbol information for code completion. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D41345?vs=129106&id=129110#toc Repository: r

[PATCH] D41345: [clangd] Add more symbol information for code completion.

ioeric updated this revision to Diff 129106. ioeric marked an inline comment as done. ioeric added a comment. - Addrress review comment. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41345 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/CodeComplete.cpp clangd/

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb updated this revision to Diff 129103. bsdjhb added a comment. - Rebase after N64 -> newabi commit. https://reviews.llvm.org/D39074 Files: include/__libunwind_config.h src/AddressSpace.hpp src/DwarfInstructions.hpp src/UnwindRegistersRestore.S src/UnwindRegistersSave.S src/lib

[PATCH] D41668: [clangd] Add static index for the global code completion.

sammccall accepted this revision. sammccall added a comment. Ilya's suggestion to have a single index on the CodeCompleteOptions that encapsulates the merging seems reasonable to me, but not urgent. So let's get this in as-is and we can make that change whenever. Comment at: c

[PATCH] D41345: [clangd] Add more symbol information for code completion.

sammccall accepted this revision. sammccall added inline comments. Comment at: clangd/index/SymbolYAML.cpp:78 +assert(io.getContext()); +Detail = static_cast(io.getContext()) + ->Allocate(); this removes the Detail object if it

[PATCH] D41842: [libunwind][MIPS]: Rename Registers_mips_n64 to Registers_mips_newabi.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322093: [libunwind][MIPS]: Rename Registers_mips_n64 to Registers_mips_newabi. (authored by jhb, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

[libunwind] r322093 - [libunwind][MIPS]: Rename Registers_mips_n64 to Registers_mips_newabi.

Author: jhb Date: Tue Jan 9 09:07:18 2018 New Revision: 322093 URL: http://llvm.org/viewvc/llvm-project?rev=322093&view=rev Log: [libunwind][MIPS]: Rename Registers_mips_n64 to Registers_mips_newabi. This is in preparation for adding support for N32 unwinding which reuses the newabi register cla

[PATCH] D41406: [analyzer] Add a new checker callback, check::NewAllocator.

NoQ added a comment. In https://reviews.llvm.org/D41406#970985, @xazax.hun wrote: > Also, I was wondering if it would make sense to only have the PostCall > callback return the casted memory region in these specific cases instead of > introducing a new callback. Yep, i actually think it's a v

[PATCH] D41797: [analyzer] Suppress escape of this-pointer during construction.

a.sidorin added a comment. Hi Artem, I think that global suppression is fine. If one really wants to check such escapes, he can implement a separate callback for this. Repository: rC Clang https://reviews.llvm.org/D41797 ___ cfe-commits mailing

[PATCH] D38694: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rC322091: [ASTImporter] Support importing CXXUnresolvedConstructExpr and… (authored by a.sidorin, committed by ). Changed prior to commit: https://reviews.llvm.org/D38694?vs=127283&id=129095#toc Reposito

r322091 - [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr

Author: a.sidorin Date: Tue Jan 9 08:40:40 2018 New Revision: 322091 URL: http://llvm.org/viewvc/llvm-project?rev=322091&view=rev Log: [ASTImporter] Support importing CXXUnresolvedConstructExpr and UnresolvedLookupExpr * Note: This solution is based on https://github.com/haoNoQ/clang/blob/su

[PATCH] D41326: [clang-tidy] Added diagnostics about incorrect usage of NOLINT comment

alexfh added a comment. A high-level comment: NOLINT category parsing and warning on incorrect NOLINT categories makes it more difficult for code to comply both with clang-tidy and cpplint (https://github.com/cpplint/cpplint), since: 1. the category names in these tools are different, 2. cpplin

[PATCH] D41655: [clang-tidy] New check bugprone-unused-return-value

khuttun updated this revision to Diff 129090. khuttun added a comment. The checker is now disabled inside GNU statement expressions https://reviews.llvm.org/D41655 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.txt clang-tidy/bugprone/UnusedReturnValueChe

[PATCH] D41867: [Frontend] Remove unused FileMgr in pp arg parse

modocache created this revision. modocache added a reviewer: v.g.vassilev. A FIXME added 8 years ago (2010) in https://reviews.llvm.org/rL118203 mentioned that a FileManager should not need to be used when parsing preprocessor arguments. In fact, its only use was removed 6 years ago (2012), in htt

[PATCH] D41553: Support parsing double square-bracket attributes in ObjC

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:239 + bit IncludeC = includeC; +} rjmccall wrote: > aaron.ballman wrote: > > rjmccall wrote: > > > I have no objection to allowing ObjC attributes to be spelled in > > > [[clang::obj

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon marked an inline comment as done. oren_ben_simhon added inline comments. Comment at: test/CodeGen/x86-cf-protection.c:1 +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s --check-prefix=

r322017 - [index] Return when DC is null in handleReference

Author: maskray Date: Mon Jan 8 10:57:38 2018 New Revision: 322017 URL: http://llvm.org/viewvc/llvm-project?rev=322017&view=rev Log: [index] Return when DC is null in handleReference Summary: DC may sometimes be NULL and getContainerInfo(DC, Container) will dereference a null pointer. Default

Re: Re: r322018 - [OPENMP] Current status of OpenMP support.

This is is the status of OpenMP support in 6.0. There is nothing new since branching. - Best regards, Alexey Bataev 08.01.2018 14:09, Jonas Hahnfeld via cfe-commits пишет: > Can we backport this page to release_60? I think the documented > support is also valid for 6.0 or did I miss r

[PATCH] D41730: [clangd] Use ToolExecutor to write the global-symbol-builder tool.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322084: [clangd] Use ToolExecutor to write the global-symbol-builder tool. (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D41

[clang-tools-extra] r322084 - [clangd] Use ToolExecutor to write the global-symbol-builder tool.

Author: ioeric Date: Tue Jan 9 07:21:45 2018 New Revision: 322084 URL: http://llvm.org/viewvc/llvm-project?rev=322084&view=rev Log: [clangd] Use ToolExecutor to write the global-symbol-builder tool. Summary: This enables more execution modes like standalone and Mapreduce-style execution. See al

[PATCH] D41668: [clangd] Add static index for the global code completion.

hokein updated this revision to Diff 129081. hokein marked 4 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41668 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp

[PATCH] D41823: [clangd] Add more filters for collected symbols.

ioeric added a comment. Thanks for the reviews! Comment at: clangd/index/FileIndex.cpp:22 llvm::ArrayRef Decls) { - auto Collector = std::make_shared(); + auto CollectorOpts = SymbolCollector::Options(); + CollectorOpts.IndexMainFiles =

[PATCH] D41823: [clangd] Add more filters for collected symbols.

ioeric updated this revision to Diff 129078. ioeric marked 4 inline comments as done. ioeric added a comment. - Addressed comments. - Merged with origin/master - Merge with diff base. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41823 Files: clangd/global-symbol-builder/Glo

[PATCH] D40478: Added control flow architecture protection Flag

alexfh added inline comments. Comment at: test/CodeGen/x86-cf-protection.c:1 +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s --check-prefix=RETURN +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm

r322082 - Explicitly specify output file.

Author: alexfh Date: Tue Jan 9 07:05:13 2018 New Revision: 322082 URL: http://llvm.org/viewvc/llvm-project?rev=322082&view=rev Log: Explicitly specify output file. Otherwise the test fails when LLVM sources are on a read-only partition. Modified: cfe/trunk/test/CodeGen/x86-cf-protection.c

[PATCH] D40478: Added control flow architecture protection Flag

oren_ben_simhon added inline comments. Comment at: test/CodeGen/x86-cf-protection.c:1 +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s --check-prefix=RETURN +// RUN: not %clang_cc1 -fsyntax-only -S -e

[PATCH] D41345: [clangd] Add more symbol information for code completion.

ioeric added inline comments. Comment at: clangd/index/Index.h:122 + + llvm::Optional Detail; + sammccall wrote: > ioeric wrote: > > sammccall wrote: > > > ioeric wrote: > > > > sammccall wrote: > > > > > I think you probably want a raw pointer rather than optio

[PATCH] D41345: [clangd] Add more symbol information for code completion.

ioeric updated this revision to Diff 129075. ioeric added a comment. - Merge branch 'master' of http://llvm.org/git/clang-tools-extra into symbol Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41345 Files: clangd/ClangdUnit.cpp clangd/ClangdUnit.h clangd/CodeComplete.cpp

[PATCH] D41797: [analyzer] Suppress escape of this-pointer during construction.

xazax.hun added a comment. I am fine with suppressing the escape globally. I did see some code in the wild where the constructors registered the objects with a (global) map. But I think it is still easier to annotate code that does something unconventional than the other way around. Repository

[clang-tools-extra] r322080 - [clangd] Fix a bug in asynchronous code completion

Author: ibiryukov Date: Tue Jan 9 06:39:27 2018 New Revision: 322080 URL: http://llvm.org/viewvc/llvm-project?rev=322080&view=rev Log: [clangd] Fix a bug in asynchronous code completion A StringRef that goes out of scope was copied and used in a handler running on a separate thread. We didn't ca

[PATCH] D40478: Added control flow architecture protection Flag

alexfh added inline comments. Comment at: test/CodeGen/x86-cf-protection.c:1 +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm -triple i386-unknown-unknown -fcf-protection=return %s 2>&1 | FileCheck %s --check-prefix=RETURN +// RUN: not %clang_cc1 -fsyntax-only -S -emit-llvm

  1   2   >