xgsa added a comment.
@aaron.ballman, sorry for my insistence, but it seems all the comments are
fixed and the patch is ready for commit or am I missing something? Could you
please commit it on my behalf, as I don't have rights to do that?
https://reviews.llvm.org/D40671
___
On 12/13/2017 02:09 AM, Evgenii Stepanov via cfe-commits wrote:
Hi,
this does not compile for me because of a tag mismatch:
clang-tools-extra/clangd/index/Index.h:52:10: error: class
'DenseMapInfo' was previously declared as a struct
[-Werror,-Wmismatched-tags]
friend class llvm::DenseMapIn
MTC added inline comments.
Comment at: include/clang/Analysis/ProgramPoint.h:619
/// CallExitBegin and CallExitEnd. The following operations occur between the
-/// two program points:
+/// two preogram points:
/// - CallExitBegin
A minor typo, it should be 'pro
mclow.lists added a comment.
> Thanks, I've checked this in without the changes to TODO.TXT
Thanks - that works for me.
https://reviews.llvm.org/D40991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
rjmccall added a comment.
We do try to avoid relying on optimizer behavior in our tests. I don't know
why you need that here.
Repository:
rC Clang
https://reviews.llvm.org/D41050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
lichray added a comment.
I'm not confident enough about the effects of this patch with only one test;
the last patch also passes the test. I hope I can understand the effects
better.
https://reviews.llvm.org/D40284
___
cfe-commits mailing list
cf
lichray added a comment.
I beg you to resubmit this patch relative to "libcxx"; I had to `arc export`
this patch and `patch -p1 < your.diff` manually rather than just `arc patch
D41148`.
Comment at: libcxx/include/experimental/simd:1069
+std::is_same<_Abi, sim
szepet created this revision.
szepet added reviewers: dcoughlin, NoQ, zaks.anna, xazax.hun, a.sidorin.
Herald added subscribers: dkrupp, baloghadamsoftware, whisperity.
Based on the CFGLoopEntrance element, it is possible to have a CFG driven
LocationContext update which contains loop information
szepet created this revision.
szepet added reviewers: dcoughlin, zaks.anna, NoQ, rsmith.
Herald added subscribers: dkrupp, a.sidorin, baloghadamsoftware, whisperity.
Adding LoopEntrance as a new CFGElement to the CFG.
This element is added as the last element of the CFGBlock just before the loop
vsk updated this revision to Diff 12.
vsk added a comment.
- Make sure the result can be stored into the result ptr.
https://reviews.llvm.org/D41149
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/builtins-overflow.c
Index: test/CodeGen/builtins-overflow.c
===
vsk abandoned this revision.
vsk added a comment.
Abandoned in favor of a proper fix: https://reviews.llvm.org/D41149
https://reviews.llvm.org/D38861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
vsk created this revision.
vsk added reviewers: efriedma, rjmccall, dtzWill.
This patch introduces a specialized way to lower overflow-checked
multiplications with mixed-sign operands. This fixes link failures and
ICEs on code like this:
void mul(int64_t a, uint64_t b) {
int64_t res;
__
lodato added a comment.
Oh, and I meant to start with: I'm so sorry for the extremely long delay. I was
swamped with work before then I forgot about this. Please know that I
appreciate your effort here and that I didn't mean to blow you off.
Best regards, Mark
Repository:
rL LLVM
https://r
lodato added a comment.
I think the simplest solution to those problems is to require `--diff`. An
alternative is to write the changes directly to the index without touching the
working directory, but that would require some flag because the behavior is
unintuitive, and the implementation would
lodato created this revision.
lodato added reviewers: djasper, klimek, Alexander-Shukaev.
This new mode, which requires --diff, operates very similarly to the two
mode, except that the stage is formatted instead of the second commit.
The main intent of this feature is to use in pre-commit hooks
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
The patch includes all declarations, and also implements the following features:
- ABI.
- narrowing-conversion related SFIANE, including simd<> ctors and
(sta
juliehockett updated this revision to Diff 126657.
juliehockett added a comment.
Updating formatting
https://reviews.llvm.org/D41102
Files:
tools/CMakeLists.txt
tools/clang-doc/CMakeLists.txt
tools/clang-doc/ClangDoc.cpp
tools/clang-doc/ClangDoc.h
tools/clang-doc/ClangDocReporter.cpp
lodato created this revision.
lodato added reviewers: djasper, klimek, Alexander-Shukaev.
The only user-visible change is rewriting of the --help message to make the
different modes more clear.
Internally, this is a significant refactoring to make the source and
destination of the diff to be mo
Hi,
this does not compile for me because of a tag mismatch:
clang-tools-extra/clangd/index/Index.h:52:10: error: class
'DenseMapInfo' was previously declared as a struct
[-Werror,-Wmismatched-tags]
friend class llvm::DenseMapInfo;
On Tue, Dec 12, 2017 at 7:42 AM, Haojian Wu via cfe-commits
wro
STL_MSFT accepted this revision.
STL_MSFT added a comment.
This revision is now accepted and ready to land.
Thanks, I've checked this in without the changes to TODO.TXT. Please let me
know if you still want them, otherwise I consider this to be complete.
https://reviews.llvm.org/D40991
_
Author: stl_msft
Date: Tue Dec 12 16:51:27 2017
New Revision: 320535
URL: http://llvm.org/viewvc/llvm-project?rev=320535&view=rev
Log:
[libcxx] [test] Fix MSVC warnings, null pointer deref.
test/std/algorithms/alg.modifying.operations/alg.generate/generate_n.pass.cpp
Silence MSVC warning C4244. T
Author: stl_msft
Date: Tue Dec 12 16:51:31 2017
New Revision: 320536
URL: http://llvm.org/viewvc/llvm-project?rev=320536&view=rev
Log:
[libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.
benchmarks/util_smartptr.bench.cpp
Change CRLF to LF.
test/std/localization/locale.categories/cate
K-ballo added a comment.
Thanks @lichray
Repository:
rL LLVM
https://reviews.llvm.org/D38831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
juliehockett updated this revision to Diff 126645.
juliehockett marked 15 inline comments as done.
juliehockett added a comment.
Fixed comments and updated YAML output to use a StringMap.
https://reviews.llvm.org/D41102
Files:
tools/CMakeLists.txt
tools/clang-doc/CMakeLists.txt
tools/cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320533: [Coverage] Always emit unused coverage mappings in
the same order. (authored by efriedma, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41140?vs=126640&id=126644#toc
Reposi
Author: efriedma
Date: Tue Dec 12 16:14:17 2017
New Revision: 320533
URL: http://llvm.org/viewvc/llvm-project?rev=320533&view=rev
Log:
[Coverage] Always emit unused coverage mappings in the same order.
Non-determinism is confusing at best.
Differential Revision: https://reviews.llvm.org/D41140
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
Thanks, lgtm!
Repository:
rC Clang
https://reviews.llvm.org/D41140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
colden marked an inline comment as done.
colden added inline comments.
Comment at: llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp:8439
+
+llvm::Type *Int128Ty = llvm::IntegerType::get(getLLVMContext(), 128);
+llvm::Type *Int128PtrTy = Int128Ty->getPointerTo();
---
colden updated this revision to Diff 126641.
colden added a comment.
llvm::IntegerType::get(getLLVMContext(), 128) -> Builder.getInt128Ty()
https://reviews.llvm.org/D41032
Files:
llvm/tools/clang/include/clang/Basic/BuiltinsX86_64.def
llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp
llvm/tools/
efriedma created this revision.
efriedma added a reviewer: vsk.
efriedma added a project: clang.
Non-determinism is confusing at best.
Repository:
rC Clang
https://reviews.llvm.org/D41140
Files:
lib/CodeGen/CodeGenModule.cpp
lib/CodeGen/CodeGenModule.h
Index: lib/CodeGen/CodeGenModule.
majnemer added inline comments.
Comment at: llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp:8439
+
+llvm::Type *Int128Ty = llvm::IntegerType::get(getLLVMContext(), 128);
+llvm::Type *Int128PtrTy = Int128Ty->getPointerTo();
Builder.getInt128Ty()
https://revie
jtbandes added a comment.
Bump :)
https://reviews.llvm.org/D40284
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jtbandes added a comment.
Bump :)
https://reviews.llvm.org/D39937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane added a comment.
Herald added a subscriber: mgrang.
Ping! Anyone have time to take a look for me?
https://reviews.llvm.org/D40819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
colden updated this revision to Diff 126634.
colden retitled this revision from "[CodeGen] Implement
_InterlockedCompareExchange128 intrinsic" to "[CodeGen][X86] Implement
_InterlockedCompareExchange128 intrinsic".
colden added a comment.
Moved implementation to X86_64 specific code, as accordin
danzimm updated this revision to Diff 126633.
danzimm added a comment.
Remove unnecessary change of braces
Repository:
rC Clang
https://reviews.llvm.org/D41050
Files:
lib/CodeGen/CGClass.cpp
test/CodeGenObjCXX/arc-forwarded-lambda-call.mm
Index: test/CodeGenObjCXX/arc-forwarded-lambda-
danzimm added a comment.
@rjmccall aha, right - thanks for explaining that to me (sorry for the bad
logic I had earlier).
It turns out this was also broken for a lambda that was auto-converted to a
function pointer who returned an ObjC object. I changed the test case to
reflect the more genera
danzimm updated this revision to Diff 126628.
danzimm added a comment.
Call objc_retainAutoreleasedReturnValue after invoking a wrapped lambda
Repository:
rC Clang
https://reviews.llvm.org/D41050
Files:
lib/CodeGen/CGBlocks.cpp
lib/CodeGen/CGClass.cpp
test/CodeGenObjCXX/arc-forwarded-l
alekseyshl added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:684
if (AddExportDynamic)
-CmdArgs.push_back("-export-dynamic");
+CmdArgs.push_back("--export-dynamic");
If it does not exist on Solaris, why change it then? For the c
bsdjhb updated this revision to Diff 126620.
bsdjhb added a comment.
- Rebase after O32/N64 commit.
https://reviews.llvm.org/D39074
Files:
include/__libunwind_config.h
src/AddressSpace.hpp
src/DwarfInstructions.hpp
src/Registers.hpp
src/UnwindCursor.hpp
src/UnwindRegistersRestore.S
Author: jhb
Date: Tue Dec 12 13:43:36 2017
New Revision: 320528
URL: http://llvm.org/viewvc/llvm-project?rev=320528&view=rev
Log:
[libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.
This supports the soft-float ABI only and has been tested with both clang
and gcc on FreeBSD.
R
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320528: [libunwind][MIPS]: Add support for unwinding in O32
and N64 processes. (authored by jhb, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D38110
Files:
libunwind/trunk/include/__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320527: [OpenMP] Add function attribute for triggering data
sharing. (authored by gbercea, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41123?vs=126594&id=126618#toc
Repository:
lodato added a comment.
Yeah, I was incorrect. The feature worked fine. I don't know what I was
thinking.
https://reviews.llvm.org/D41129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
lodato added a comment.
Actually the old code might have been working fine. Please hold off on
reviewing.
https://reviews.llvm.org/D41129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
aaron.ballman added a comment.
In https://reviews.llvm.org/D40854#950640, @JonasToth wrote:
> > The "enforcement" listed on the C++ Core Guidelines is very unhelpful, so
> > it might be worth bringing it up as an issue on their bug tracker. ES.100
> > basically says "you know what we mean, wink
lodato created this revision.
lodato added reviewers: djasper, klimek.
This makes the code a bit easier to understand. Also add a docstring to `run()`.
Note: This means that we read the entire index into memory when calling `git
update-index`, whereas previously we would send the data line-by-li
lodato created this revision.
lodato added reviewers: djasper, klimek.
This feature had never worked at all because the code incorrectly used
<`commit2>` for both the "old" and "new", so the diff was always empty! Now we
correctly use `` where we should and it works fine.
https://reviews.llvm.
Author: rwols
Date: Tue Dec 12 12:25:06 2017
New Revision: 320524
URL: http://llvm.org/viewvc/llvm-project?rev=320524&view=rev
Log:
[clangd] (Attempt to) read clang-format file for document formatting
Summary:
Takes into account the clang-format file of the project, if any.
Reverts to LLVM if not
george.karpenkov added inline comments.
Comment at: tools/scan-build-py/libscanbuild/report.py:257
def read_bugs(output_dir, html):
+# type: (str, bool) -> Generator[Dict[str, Any], None, None]
""" Generate a unique sequence of bugs from given output directory.
aaron.ballman added inline comments.
Comment at: lib/Sema/Sema.cpp:1677-1684
+Sema::DefaultArgRAII::DefaultArgRAII(Sema &S)
+: Actions(S), PrevParent(S.getParentOfDefaultArg()) {
+ S.setParentOfDefaultArg(S.CurContext);
+}
+
+Sema::DefaultArgRAII::~DefaultArgRAII() {
+ Acti
rjmccall added a comment.
Hmm. The OVE-ing of the RHS of a property assignment is just there to make the
original source structure clearer. Maybe the right solution here is to set a
flag in the OVE that says that it's a unique semantic reference to its source
expression, and then change IRGen
rjmccall added a comment.
This looks good to me.
https://reviews.llvm.org/D36915
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320524: [clangd] (Attempt to) read clang-format file for
document formatting (authored by rwols, committed by ).
Herald added a subscriber: klimek.
Changed prior to commit:
https://reviews.llvm.org/D410
rjmccall added a comment.
In https://reviews.llvm.org/D41050#952720, @danzimm wrote:
> Or do we need to abide by those semantics strictly here? Could you expand on
> why that is, if that's the case?
The autoreleased-return-value optimization cannot be understood purely in terms
of its impact
On Tue, Dec 12, 2017 at 1:45 PM, David Blaikie wrote:
> On Mon, Dec 11, 2017 at 5:38 PM John McCall wrote:
>
>> On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie
>> wrote:
>>
>>> On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator <
>>> revi...@reviews.llvm.org> wrote:
>>>
rjmccall ad
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320521: [OpenMP] Diagnose function name on the link clause
(authored by kli, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D40968?vs=126217&id=126600#toc
Repository:
rL LLVM
http
Author: kli
Date: Tue Dec 12 12:08:12 2017
New Revision: 320521
URL: http://llvm.org/viewvc/llvm-project?rev=320521&view=rev
Log:
[OpenMP] Diagnose function name on the link clause
This patch is to add diagnose when a function name is
specified on the link clause. According to the OpenMP
spec, o
nathawes planned changes to this revision.
nathawes added a comment.
Thanks for taking another look @ioeric – I'll work through your comments and
update.
https://reviews.llvm.org/D39050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
danzimm added a comment.
Or do we need to abide by those semantics strictly here? Could you expand on
why that is, if that's the case?
Repository:
rC Clang
https://reviews.llvm.org/D41050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
danzimm added a comment.
@rjmccall ah right, good point -- I think it's ok to elide that
objc_retainAutoreleasedReturnValue/objc_autoreleaseReturnValue pair in this
case though, since all of this is generated within clang itself (and thus we
can make the guarentee that the object will properly
rwols accepted this revision.
rwols added a comment.
This revision is now accepted and ready to land.
LGTM, you can go ahead and land this, I'll drop
https://reviews.llvm.org/D40860. I'm happy we got to the bottom of this :)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41118
Author: dhinton
Date: Tue Dec 12 11:47:40 2017
New Revision: 320519
URL: http://llvm.org/viewvc/llvm-project?rev=320519&view=rev
Log:
[cmake] Follow-up to rL320494.
EXISTS requires full paths.
Modified:
cfe/trunk/test/CMakeLists.txt
Modified: cfe/trunk/test/CMakeLists.txt
URL:
http://llvm.
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D41123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
gtbercea updated this revision to Diff 126594.
gtbercea added a comment.
Fix test.
Repository:
rL LLVM
https://reviews.llvm.org/D41123
Files:
lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
test/OpenMP/nvptx_data_sharing.cpp
Index: test/OpenMP/nvptx_data_sharing.cpp
==
rjmccall added a comment.
Alternative #1 is actually the right option — only it shouldn't be an
objc_retain, it should be an objc_retainAutoreleasedReturnValue.
Repository:
rC Clang
https://reviews.llvm.org/D41050
___
cfe-commits mailing list
cf
ABataev added inline comments.
Comment at: test/OpenMP/nvptx_data_sharing.cpp:25-43
+// CK1: define internal void @__omp_offloading_{{.*}}test_ds{{.*}}worker() #0
// CK1: [[SHAREDARGS:%.+]] = alloca i8**
// CK1: call i1 @__kmpc_kernel_parallel(i8** %work_fn, i8*** [[SHAREDARGS]
gtbercea created this revision.
gtbercea added reviewers: hfinkel, Hahnfeld, ABataev, carlo.bertolli, caomhin.
Herald added a subscriber: jholewinski.
The backend should only emit data sharing code for the cases where it is needed.
A new function attribute is used by Clang to enable data sharing o
lichray added a comment.
That commit message generated from `arc` wasn't all that friendly :/
Thanks for the patch, and @K-ballo you should ask Chris for a commit bit :)
Repository:
rL LLVM
https://reviews.llvm.org/D38831
___
cfe-commits mailing
On Mon, Dec 11, 2017 at 5:38 PM John McCall wrote:
> On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie wrote:
>
>> On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator <
>> revi...@reviews.llvm.org> wrote:
>>
>>> rjmccall added a comment.
>>>
>>> In https://reviews.llvm.org/D41039#951648, @a
arphaman updated this revision to Diff 126581.
arphaman added a comment.
Herald added a subscriber: javed.absar.
- Change error message.
- Take sub arch into account.
https://reviews.llvm.org/D41087
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPMacroExpansion.cpp
test/Preprocessor/is_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320509: [libcxx] P0604, invoke_result and is_invocable
(authored by lichray, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D38831?vs=126545&id=126580#toc
Repository:
rL LLVM
http
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: lib/Lex/PPMacroExpansion.cpp:1923
+ Tok, *this, diag::err_feature_check_malformed);
+ return II ? getTargetInfo().getTriple().getArchName().equals_lower(
+
Author: lichray
Date: Tue Dec 12 10:42:04 2017
New Revision: 320509
URL: http://llvm.org/viewvc/llvm-project?rev=320509&view=rev
Log:
[libcxx] P0604, invoke_result and is_invocable
Summary:
Introduce a new form of `result_of` without function type encoding.
Rename and split `is_callable/is_nothr
This revision was automatically updated to reflect the committed changes.
Closed by commit rC320506: Add --cuda-path to mock a CUDA Toolkit installation
to avoid (authored by kli, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D40996
Files:
test/Driver/unknown-std.cpp
Index
Author: kli
Date: Tue Dec 12 10:33:39 2017
New Revision: 320506
URL: http://llvm.org/viewvc/llvm-project?rev=320506&view=rev
Log:
Add --cuda-path to mock a CUDA Toolkit installation to avoid
unexpected error messages for incompatibility between the
default SM level and the support in the installed
tstellar added a comment.
Ping.
https://reviews.llvm.org/D34848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sammccall added a comment.
https://reviews.llvm.org/D41118 adds real (non-empty) ranges for diagnostics.
I've copied all the changes you've made here with some slight tweaks, as they
were required for that too.
If you like it as-is, probably easiest to land that instead.
But I'm also happy for y
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320500: workaround PR 28385 in __find_exactly_one_checked
(authored by CaseyCarter, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41048?vs=126559&id=126564#toc
Repository:
rL LLV
Author: caseycarter
Date: Tue Dec 12 09:22:24 2017
New Revision: 320500
URL: http://llvm.org/viewvc/llvm-project?rev=320500&view=rev
Log:
workaround PR 28385 in __find_exactly_one_checked
Fixes #35578.
Differential Revision: D41048
Modified:
libcxx/trunk/include/tuple
Modified: libcxx/trun
sammccall created this revision.
sammccall added reviewers: rwols, hokein.
Herald added subscribers: cfe-commits, ilya-biryukov, klimek.
- when the diagnostic has an explicit range, we prefer that
- if the diagnostic has a fixit, its RemoveRange is our next choice
- otherwise we try to expand the
CaseyCarter added a comment.
This new-and-improved workaround - thanks to @lichray - is unintrusive enough
that I can't imagine it being unnacceptable to anyone. I'm going to go ahead
and check this in.
https://reviews.llvm.org/D41048
___
cfe-comm
CaseyCarter updated this revision to Diff 126559.
CaseyCarter added a comment.
Better/simpler workaround from Zhihao.
https://reviews.llvm.org/D41048
Files:
include/tuple
Index: include/tuple
===
--- include/tuple
+++ include/t
malaperle added inline comments.
Comment at: clangd/Symbol.h:37
+// The class presents a C++ symbol, e.g. class, function.
+struct Symbol {
+ // The symbol identifier, using USR.
sammccall wrote:
> malaperle wrote:
> > malaperle wrote:
> > > sammccall wrote:
> >
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320494: [debuginfo-tests] Add support for moving
debuginfo-tests from clang/test to… (authored by dhinton, committed by ).
Author: dhinton
Date: Tue Dec 12 08:48:35 2017
New Revision: 320494
URL: http://llvm.org/viewvc/llvm-project?rev=320494&view=rev
Log:
[debuginfo-tests] Add support for moving debuginfo-tests from clang/test to
llvm/projects or monorepo.
Summary:
The new version of debuginfo-tests will have it's
xazax.hun updated this revision to Diff 126543.
xazax.hun added a comment.
- Further improvements to python script part.
https://reviews.llvm.org/D30691
Files:
include/clang/AST/ASTContext.h
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
include/clang/StaticAnalyzer/Core/PathSensitiv
Thanks Zachary.
Maybe, we can approach the issue through another, hopefully less controversial
angle. Clang currently has a limited number of tests verifying that it
correctly handles all types of line endings. IMHO, Zhen's solution (dos2unix &
unix2dos conversions) provides an handy mechanism
aaron.ballman added a comment.
In https://reviews.llvm.org/D41056#951507, @khuttun wrote:
> P0600R1 seems to suggest quite conservative approach (and rightly so, IMO) in
> taking `[[nodiscard]]` in use in std lib. For example it proposes *not* to
> use it with `unique_ptr::release`. I think the
ioeric added inline comments.
Comment at: clangd/index/Index.h:52
+private:
+ friend class llvm::DenseMapInfo;
+
warning: class 'DenseMapInfo' was previously declared as a struct
[-Wmismatched-tags]
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.o
Fixed in 320493. Thanks for catching that.
From: Richard Smith [mailto:rich...@metafoo.co.uk]
Sent: Tuesday, December 12, 2017 8:07 AM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r320489 - Fix ICE when __has_unqiue_object_representations called
with invalid decl
On 12 Dec 2017 16:02, "Erich
Author: erichkeane
Date: Tue Dec 12 08:22:31 2017
New Revision: 320493
URL: http://llvm.org/viewvc/llvm-project?rev=320493&view=rev
Log:
Revert a part of 320489 that was submitted unintentionally.
Modified:
cfe/trunk/lib/Sema/SemaExprCXX.cpp
Modified: cfe/trunk/lib/Sema/SemaExprCXX.cpp
URL:
Gah, no it wasn’t. I’ll revert that now.
From: Richard Smith [mailto:rich...@metafoo.co.uk]
Sent: Tuesday, December 12, 2017 8:07 AM
To: Keane, Erich
Cc: cfe-commits
Subject: Re: r320489 - Fix ICE when __has_unqiue_object_representations called
with invalid decl
On 12 Dec 2017 16:02, "Erich K
ilya-biryukov updated this revision to Diff 126554.
ilya-biryukov added a comment.
- Also check that return type of Callable is correct.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
On 12 Dec 2017 16:02, "Erich Keane via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
Author: erichkeane
Date: Tue Dec 12 08:02:06 2017
New Revision: 320489
URL: http://llvm.org/viewvc/llvm-project?rev=320489&view=rev
Log:
Fix ICE when __has_unqiue_object_representations called with invalid de
ilya-biryukov added inline comments.
Comment at: clangd/Function.h:44
+/// A sfinae-check that Callable can be called with Args...
+class = decltype(std::declval()(std::declval()...),
+ void())>
We need this che
ilya-biryukov added a comment.
This is now ready for review.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erichkeane
Date: Tue Dec 12 08:02:06 2017
New Revision: 320489
URL: http://llvm.org/viewvc/llvm-project?rev=320489&view=rev
Log:
Fix ICE when __has_unqiue_object_representations called with invalid decl
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
cfe/trunk/lib/Sema/SemaExprCXX.cpp
ilya-biryukov updated this revision to Diff 126551.
ilya-biryukov added a comment.
- Make Context the first parameter everywhere.
- Add a SFINAE check to UniqueFunction's constructor to avoid creating it from
non-callable objects.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D
Author: hokein
Date: Tue Dec 12 07:42:10 2017
New Revision: 320486
URL: http://llvm.org/viewvc/llvm-project?rev=320486&view=rev
Log:
[clangd] Introduce a "Symbol" class.
Summary:
* The "Symbol" class represents a C++ symbol in the codebase, containing all the
information of a C++ symbol needed
1 - 100 of 140 matches
Mail list logo
