[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-11 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In https://reviews.llvm.org/D40486#945193, @ilya-biryukov wrote: > I'll update the implementation and place the `Context` as the first parameter > everywhere instead. > Could you take a look at other changes in the patch while I'm at it? Just pinging this - there's

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

2017-12-11 Thread Alexey Knyshev via Phabricator via cfe-commits
alexey.knyshev added a comment. In https://reviews.llvm.org/D40715#951665, @dcoughlin wrote: > Thanks for looking into this! > > This checker is in the 'core' package, which means (when moved out of alpha) > it will be enabled by default. > > - Do you think that this checker should be enabled by

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

2017-12-11 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added inline comments. Comment at: lib/Lex/PPMacroExpansion.cpp:1923 + Tok, *this, diag::err_feature_check_malformed); + return II ? getTargetInfo().getTriple().getArchName().equals_lower( + II->getName()) H

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

2017-12-11 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray accepted this revision. lichray added a comment. This revision is now accepted and ready to land. Reproduced with lit -sv --param=cxx_under_test="$HOME/bin/clang++" test/std/utilities/tuple/ lit: [...] note: Using available_features: ['libc++', 'verify-support', 'clang-6', 'modules-s

[PATCH] D40743: Make rehash(0) work with ubsan's unsigned-integer-overflow.

2017-12-11 Thread Dan Albert via Phabricator via cfe-commits
danalbert added inline comments. Comment at: include/__hash_table:2141 __n = 2; else if (__n & (__n - 1)) __n = __next_prime(__n); With `rehash(0)` this is `0 & (0 - 1)`, which triggers unsigned-integer-overflow. Repository: rCXX libc+

[PATCH] D40925: Add option -fkeep-static-consts

2017-12-11 Thread Elizabeth Andrews via Phabricator via cfe-commits
eandrews added a comment. *ping* https://reviews.llvm.org/D40925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r320455 - [analyzer] StackAddrEscape: For now, disable the new async escape checks.

2017-12-11 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Mon Dec 11 18:59:09 2017 New Revision: 320455 URL: http://llvm.org/viewvc/llvm-project?rev=320455&view=rev Log: [analyzer] StackAddrEscape: For now, disable the new async escape checks. The new check introduced in r318705 is useful, but suffers from a particular class of f

[PATCH] D41042: [analyzer] StackAddrEscape: Delay turning on by default a little bit?

2017-12-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320455: [analyzer] StackAddrEscape: For now, disable the new async escape checks. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D41042?vs=126390&id=126496#toc Repository:

r320451 - [analyzer] In getSVal() API, disable auto-detection of void type as char type.

2017-12-11 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Mon Dec 11 18:27:55 2017 New Revision: 320451 URL: http://llvm.org/viewvc/llvm-project?rev=320451&view=rev Log: [analyzer] In getSVal() API, disable auto-detection of void type as char type. This is a follow-up from r314910. When a checker developer attempts to dereference

[PATCH] D38801: [analyzer] In getSVal() API, disable auto-detection of void type as char type.

2017-12-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320451: [analyzer] In getSVal() API, disable auto-detection of void type as char type. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D38801?vs=12&id=126493#toc Reposito

[PATCH] D41103: [CMake] Allow passing extra CMake arguments to custom libc++

2017-12-11 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. Herald added subscribers: Sanitizers, llvm-commits, mgorny. Herald added a reviewer: EricWF. This can be used to customize the libc++ build. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D41103 Files: cmake/Modules/AddCompilerRT.cmake Index: cma

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

2017-12-11 Thread John McCall via cfe-commits
On Mon, Dec 11, 2017 at 6:19 PM, David Blaikie wrote: > On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator < > revi...@reviews.llvm.org> wrote: > >> rjmccall added a comment. >> >> In https://reviews.llvm.org/D41039#951648, @ahatanak wrote: >> >> > I had a discussion with Duncan today an

[PATCH] D41102: Setup clang-doc frontend framework

2017-12-11 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added a project: clang. Herald added a subscriber: mgorny. Setting up a basic frontend framework for a clang-doc tool. It creates a frontend action for traversing the AST to extract comments and declarations, with a flag to only extract documentat

[PATCH] D40637: [CMake] Support runtimes and monorepo layouts when looking for libc++

2017-12-11 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320446: [CMake] Support runtimes and monorepo layouts when looking for libcxx (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40637?vs=124876&id=126482#toc Repository: rL LLV

[PATCH] D40818: [libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit

2017-12-11 Thread Petr Hosek via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320445: [libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D40818?vs=125457&id=126481#toc Repository: rL LLV

[libcxxabi] r320445 - [libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit

2017-12-11 Thread Petr Hosek via cfe-commits
Author: phosek Date: Mon Dec 11 17:20:37 2017 New Revision: 320445 URL: http://llvm.org/viewvc/llvm-project?rev=320445&view=rev Log: [libcxxabi] Pass LIBCXXABI_SYSROOT and LIBCXXABI_GCC_TOOLCHAIN to lit These are expected to be set by the shared lit scripts used from libc++. Differential Revisio

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

2017-12-11 Thread David Blaikie via cfe-commits
On Mon, Dec 11, 2017 at 3:16 PM John McCall via Phabricator < revi...@reviews.llvm.org> wrote: > rjmccall added a comment. > > In https://reviews.llvm.org/D41039#951648, @ahatanak wrote: > > > I had a discussion with Duncan today and he pointed out that perhaps we > shouldn't allow users to annota

[PATCH] D41039: Add support for attribute "trivial_abi"

2017-12-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In https://reviews.llvm.org/D41039#951648, @ahatanak wrote: > I had a discussion with Duncan today and he pointed out that perhaps we > shouldn't allow users to annotate a struct with "trivial_abi" if one of its > subobjects is non-trivial and is not annotated with "tr

[PATCH] D40956: [AMDGPU] Switch to the new addr space mapping by default for clang

2017-12-11 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D40956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

2017-12-11 Thread William Enright via Phabricator via cfe-commits
Nebiroth updated this revision to Diff 126449. Nebiroth added a comment. Removed some more empty lines Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39571 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h clangd/ClangdServer.cpp clangd/ClangdServer.h clangd/

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

2017-12-11 Thread William Enright via Phabricator via cfe-commits
Nebiroth updated this revision to Diff 126447. Nebiroth added a comment. Herald added a subscriber: klimek. Merged with latest llvm + clang Minor code cleanup Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39571 Files: clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h c

[PATCH] D39050: Add index-while-building support to Clang

2017-12-11 Thread Eric Liu via Phabricator via cfe-commits
ioeric added a comment. Thanks a lot for the changes! Some more comments inlined. Please mark addressed comments as done so that reviewers could know what to look :) Thanks! Comment at: include/clang/Frontend/CompilerInstance.h:187 + typedef std::function( + const Front

Re: [PATCH] D41039: Add support for attribute "trivial_abi"

2017-12-11 Thread David Blaikie via cfe-commits
My bet would be: warn and ignore it, but probably Richard's & John might have stronger thoughts/justifications/etc. On Mon, Dec 11, 2017 at 1:38 PM Akira Hatanaka via Phabricator < revi...@reviews.llvm.org> wrote: > ahatanak added a comment. > > I had a discussion with Duncan today and he pointed

[PATCH] D41044: Implementation of -fextend-lifetimes and -fextend-this-ptr to aid with debugging of optimized code

2017-12-11 Thread Paul Robinson via Phabricator via cfe-commits
probinson added a comment. I should note we've had at least one request to make this specifiable per-function, which would mean defining an attribute to control the emission of the fake-use intrinsics. Doing the feature that way would be consistent with 'optnone'. https://reviews.llvm.org/D4

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

2017-12-11 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. Thanks for looking into this! This checker is in the 'core' package, which means (when moved out of alpha) it will be enabled by default. - Do you think that this checker should be enabled by default for all users of the analyzer? - If users do actually want to use l

[PATCH] D41080: Don't trigger -Wuser-defined-literals for system headers

2017-12-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM (wait for a day or so for @rsmith to respond in case he disagrees). Repository: rC Clang https://reviews.llvm.org/D41080 __

[PATCH] D41039: Add support for attribute "trivial_abi"

2017-12-11 Thread Akira Hatanaka via Phabricator via cfe-commits
ahatanak added a comment. I had a discussion with Duncan today and he pointed out that perhaps we shouldn't allow users to annotate a struct with "trivial_abi" if one of its subobjects is non-trivial and is not annotated with "trivial_abi" since that gives users too much power. Should we error

Re: r319875 - Fix a bunch of wrong "tautological unsigned enum compare" diagnostics in C++.

2017-12-11 Thread Galina Kistanova via cfe-commits
Hans, Thank you for fixing the test! Thanks Galina On Mon, Dec 11, 2017 at 10:59 AM, Hans Wennborg wrote: > I've committed a fix to pacify the test in r320405. > > On Wed, Dec 6, 2017 at 12:27 PM, Galina Kistanova via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hello Richard, >>

[PATCH] D41080: Don't trigger -Wuser-defined-literals for system headers

2017-12-11 Thread Dimitry Andric via Phabricator via cfe-commits
dim updated this revision to Diff 126436. dim added a comment. Add a test case. Repository: rC Clang https://reviews.llvm.org/D41080 Files: lib/Sema/SemaDeclCXX.cpp test/SemaCXX/no-warn-user-defined-literals-in-system-headers.cpp test/SemaCXX/no-warn-user-defined-literals-in-system-hea

RE: [PATCH] D41081: Fix clang Lexer Windows line-ending bug

2017-12-11 Thread Zhen Cao via cfe-commits
Thank you very much, Zachary :) From: Zachary Turner [mailto:ztur...@google.com] Sent: Monday, December 11, 2017 4:21 PM To: Zhen Cao Cc: Benoit Belley ; reviews+d41081+public+5a71b504a12c1...@reviews.llvm.org; r...@google.com; cfe-commits@lists.llvm.org Subject: Re: [PATCH] D41081: Fix clang L

Re: [PATCH] D41081: Fix clang Lexer Windows line-ending bug

2017-12-11 Thread Zachary Turner via cfe-commits
I'll let rnk@ weigh in (he's on vacation today though). I don't feel comfortable lgtm'ing any change where "don't use core.autocrlf=true" is an alternative solution, but if other people want to disagree with me and lgtm this, then that suggests I'm in the minority, which is fine. :) On Mon, Dec

[PATCH] D36952: [libclang] Add support for checking abstractness of records

2017-12-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

RE: [PATCH] D41081: Fix clang Lexer Windows line-ending bug

2017-12-11 Thread Zhen Cao via cfe-commits
I think adding two lit substitutions is not a significant issue since dos2unix and unix2dos are common Unix utilities. This solution also has the advantage of testing both styles of line-endings with only one test case, which I think actually reduces complexity and maintenance burden. From: Zac

[PATCH] D40230: Add -mprefer-vector-width driver option and attribute during CodeGen.

2017-12-11 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320419: [Driver][CodeGen] Add -mprefer-vector-width driver option and attribute during… (authored by ctopper). Changed prior to commit: https://reviews.llvm.org/D40230?vs=123709&id=126434#toc Repositor

r320419 - [Driver][CodeGen] Add -mprefer-vector-width driver option and attribute during CodeGen.

2017-12-11 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon Dec 11 13:09:19 2017 New Revision: 320419 URL: http://llvm.org/viewvc/llvm-project?rev=320419&view=rev Log: [Driver][CodeGen] Add -mprefer-vector-width driver option and attribute during CodeGen. This adds a new command line option -mprefer-vector-width to specify a pr

r320418 - [Docs] Regenerate command line documentation.

2017-12-11 Thread Craig Topper via cfe-commits
Author: ctopper Date: Mon Dec 11 13:09:16 2017 New Revision: 320418 URL: http://llvm.org/viewvc/llvm-project?rev=320418&view=rev Log: [Docs] Regenerate command line documentation. Modified: cfe/trunk/docs/ClangCommandLineReference.rst Modified: cfe/trunk/docs/ClangCommandLineReference.rst UR

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

2017-12-11 Thread William Enright via Phabricator via cfe-commits
Nebiroth updated this revision to Diff 126430. Nebiroth added a comment. Removed unique_ptr parameter in PrecompiledPreamble::Build Added method createPPCallbacks() in PreambleCallback to be overriden Repository: rC Clang https://reviews.llvm.org/D39375 Files: include/clang/Frontend/Precom

[PATCH] D38639: [clangd] #include statements support for Open definition

2017-12-11 Thread William Enright via Phabricator via cfe-commits
Nebiroth updated this revision to Diff 126429. Nebiroth added a comment. Creating unique_ptr for wrapper class now uses overriden method createPPCallbacks() from PrecompiledPreamble class Moved wrapper class to inline inside createPPCallbacks() Wrapper class now uses CppFilePreambleCallback

[PATCH] D41087: [Preprocessor] Implement __is_target_{arch|vendor|os|environment} function-like builtin macros

2017-12-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. This patch implements the `__is_target_arch`, `__is_target_vendor`, `__is_target_os`, and `__is_target_environment` Clang preprocessor extensions that were proposed by @compnerd in Bob's cfe-dev post: http://lists.llvm.org/pipermail/cfe-dev/2017-November/056166.h

Re: [PATCH] D41081: Fix clang Lexer Windows line-ending bug

2017-12-11 Thread Zachary Turner via cfe-commits
See my other response. Maybe we don’t even need a substitution at all? On Mon, Dec 11, 2017 at 12:24 PM Benoit Belley via Phabricator < revi...@reviews.llvm.org> wrote: > belleyb added inline comments. > > > > Comment at: test/lit.cfg.py:52-57 > +if platform.system() in ['Windows'

[PATCH] D41081: Fix clang Lexer Windows line-ending bug

2017-12-11 Thread Benoit Belley via Phabricator via cfe-commits
belleyb added inline comments. Comment at: test/lit.cfg.py:52-57 +if platform.system() in ['Windows']: +config.substitutions.append(('dos2unix', 'sed -b "s/\r$//"')) +config.substitutions.append(('unix2dos', 'sed -b "s/\r*$/\r/"')) +else: +config.substitutions.append(

[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

2017-12-11 Thread Kalle Huttunen via Phabricator via cfe-commits
khuttun added a comment. In https://reviews.llvm.org/D41056#951145, @aaron.ballman wrote: > In https://reviews.llvm.org/D41056#951083, @alexfh wrote: > > > In https://reviews.llvm.org/D41056#950605, @khuttun wrote: > > > > > In https://reviews.llvm.org/D41056#950570, @Eugene.Zelenko wrote: > > >

[PATCH] D41044: Implementation of -fextend-lifetimes and -fextend-this-ptr to aid with debugging of optimized code

2017-12-11 Thread Vedant Kumar via Phabricator via cfe-commits
vsk added a project: debug-info. vsk added a comment. Thanks for your patches @wolfgangp! I agree with Eli that we should evaluate enabling this automatically with -Og. I'll test this out on a few internal projects and report back. https://reviews.llvm.org/D41044 ___

r320411 - PR35586: Relax two asserts that are overly restrictive

2017-12-11 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Dec 11 11:44:28 2017 New Revision: 320411 URL: http://llvm.org/viewvc/llvm-project?rev=320411&view=rev Log: PR35586: Relax two asserts that are overly restrictive The two asserts are too aggressive. In C++ mode, an enum is NOT considered an integral type, but an enu

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

2017-12-11 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter marked 2 inline comments as done. CaseyCarter added a comment. This unconditional workaround addresses Marshall's concerns about the naked version test. https://reviews.llvm.org/D41048 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D41073: Wasm: add support in libcxx

2017-12-11 Thread Dan Gohman via Phabricator via cfe-commits
sunfish accepted this revision. sunfish added a comment. This revision is now accepted and ready to land. Yes, wasm has its own object format, so this change makes sense. Repository: rCXX libc++ https://reviews.llvm.org/D41073 ___ cfe-commits mai

r320410 - [Hexagon] Remove unsupported vlut intrinsics

2017-12-11 Thread Krzysztof Parzyszek via cfe-commits
Author: kparzysz Date: Mon Dec 11 11:29:56 2017 New Revision: 320410 URL: http://llvm.org/viewvc/llvm-project?rev=320410&view=rev Log: [Hexagon] Remove unsupported vlut intrinsics Modified: cfe/trunk/test/CodeGen/builtins-hexagon.c Modified: cfe/trunk/test/CodeGen/builtins-hexagon.c URL: ht

[PATCH] D41080: Don't trigger -Wuser-defined-literals for system headers

2017-12-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. This is missing a test case. Repository: rC Clang https://reviews.llvm.org/D41080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

2017-12-11 Thread Zhihao Yuan via Phabricator via cfe-commits
lichray added a comment. LGTM as-is with the changes to the TODO file... https://reviews.llvm.org/D40991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

2017-12-11 Thread Stephan T. Lavavej via Phabricator via cfe-commits
STL_MSFT added a comment. Would you like me to drop the changes to TODO.TXT? https://reviews.llvm.org/D40991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41064: Suppress -Wuser-defined-literals for and

2017-12-11 Thread Dimitry Andric via Phabricator via cfe-commits
dim abandoned this revision. dim added a comment. Abandoned in favor of https://reviews.llvm.org/D41080. Repository: rCXX libc++ https://reviews.llvm.org/D41064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D41080: Don't trigger -Wuser-defined-literals for system headers

2017-12-11 Thread Dimitry Andric via Phabricator via cfe-commits
dim created this revision. In https://reviews.llvm.org/D41064, I proposed adding `#pragma clang diagnostic ignored "-Wuser-defined-literals"` to some of libc++'s headers, since these warnings are now triggered by clang's new `-std=gnu++14` default: $ cat test.cpp #include $ clang -std=

[PATCH] D39363: [clang-tidy] Correctly classify constant arrays and constant strings as constants when checking identifiers naming

2017-12-11 Thread Alexander Kornienko via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320406: [clang-tidy] Correctly classify constant arrays and constant strings as… (authored by alexfh). Repository: rL LLVM https://reviews.llvm.org/D39363 Files: clang-tools-extra/trunk/clang-tidy/r

[clang-tools-extra] r320406 - [clang-tidy] Correctly classify constant arrays and constant strings as constants when checking identifiers naming

2017-12-11 Thread Alexander Kornienko via cfe-commits
Author: alexfh Date: Mon Dec 11 11:02:26 2017 New Revision: 320406 URL: http://llvm.org/viewvc/llvm-project?rev=320406&view=rev Log: [clang-tidy] Correctly classify constant arrays and constant strings as constants when checking identifiers naming Summary: They are not locally const qualified so

[PATCH] D41048: [libcxx] workaround PR 28385 in __find_exactly_one_checked

2017-12-11 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 126406. CaseyCarter added a comment. Make the workaround unconditional. https://reviews.llvm.org/D41048 Files: include/tuple Index: include/tuple === --- include/tuple +++ include/tuple

Re: r319875 - Fix a bunch of wrong "tautological unsigned enum compare" diagnostics in C++.

2017-12-11 Thread Hans Wennborg via cfe-commits
I've committed a fix to pacify the test in r320405. On Wed, Dec 6, 2017 at 12:27 PM, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit broke the tests on the builder: > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64- > expensive-checks-w

r320405 - Fix warn-enum-compare.cpp on Windows

2017-12-11 Thread Hans Wennborg via cfe-commits
Author: hans Date: Mon Dec 11 10:58:18 2017 New Revision: 320405 URL: http://llvm.org/viewvc/llvm-project?rev=320405&view=rev Log: Fix warn-enum-compare.cpp on Windows It's been failing since r319875. Modified: cfe/trunk/test/SemaCXX/warn-enum-compare.cpp Modified: cfe/trunk/test/SemaCXX/wa

[PATCH] D39963: [RISCV] Add initial RISC-V target and driver support

2017-12-11 Thread Alex Bradbury via Phabricator via cfe-commits
asb updated this revision to Diff 126404. asb marked 3 inline comments as done. asb retitled this revision from "[RISCV][RFC] Add initial RISC-V target and driver support" to "[RISCV] Add initial RISC-V target and driver support". asb edited the summary of this revision. asb added a comment. Heral

[PATCH] D41077: [analyser] different.CallArgsOrder checker implementation

2017-12-11 Thread Alexey Knyshev via Phabricator via cfe-commits
alexey.knyshev created this revision. alexey.knyshev added a project: clang. Herald added a subscriber: mgorny. CallArgsOrderChecker which looks for accidental swap or skip of arguments in function, methods, constructors and operators calls Repository: rC Clang https://reviews.llvm.org/D4107

[PATCH] D40707: [libcxx] Fix basic_stringbuf constructor

2017-12-11 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. This looks good to me; with a couple of nits. Comment at: test/std/input.output/string.streams/stringbuf/stringbuf.cons/default.pass.cpp:26 +{ +assert(this->eback() == 0); +assert(this->gptr() == 0); Not zero, p

[PATCH] D41076: [driver][darwin] Set the 'simulator' environment when it's specified in '-target'

2017-12-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. This patch ensures that '-target' can be used to set the 'simulator' environment component in the target triple. Repository: rC Clang https://reviews.llvm.org/D41076 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/darwin-version.c Index: test/Driver

[PATCH] D41075: [driver][darwin] Infer the 'simuluator

2017-12-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D41075 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/darwin-version.c Index: test/Driver/darwin-version.c ==

[PATCH] D41075: [driver][darwin] Infer the 'simuluator

2017-12-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman abandoned this revision. arphaman added a comment. Accidental 'return', will reopen Repository: rC Clang https://reviews.llvm.org/D41075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

r320401 - P0620 follow-up: deducing `auto` from braced-init-list in new expr

2017-12-11 Thread Zhihao Yuan via cfe-commits
Author: lichray Date: Mon Dec 11 10:29:54 2017 New Revision: 320401 URL: http://llvm.org/viewvc/llvm-project?rev=320401&view=rev Log: P0620 follow-up: deducing `auto` from braced-init-list in new expr Summary: This is a side-effect brought in by p0620r0, which allows other placeholder types (der

[PATCH] D39451: P0620 follow-up: deducing `auto` from braced-init-list in new expr

2017-12-11 Thread Zhihao Yuan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC320401: P0620 follow-up: deducing `auto` from braced-init-list in new expr (authored by lichray). Changed prior to commit: https://reviews.llvm.org/D39451?vs=126092&id=126400#toc Repository: rC Clang

[PATCH] D40743: Make rehash(0) work with ubsan's unsigned-integer-overflow.

2017-12-11 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. Dan - I think I need a bit more context here. How does UBSan get triggered? Repository: rCXX libc++ https://reviews.llvm.org/D40743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D40991: [libcxx] [test] Fix line endings, avoid unnecessary non-ASCII.

2017-12-11 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists added a comment. Except for the stuff in TODO.txt these look good to me. We need to do some work on that file - it's pretty out of date. https://reviews.llvm.org/D40991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

r320398 - Revert 320391: Certain targets are failing, pulling back to diagnose.

2017-12-11 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Dec 11 10:14:51 2017 New Revision: 320398 URL: http://llvm.org/viewvc/llvm-project?rev=320398&view=rev Log: Revert 320391: Certain targets are failing, pulling back to diagnose. Removed: cfe/trunk/test/Driver/Inputs/stdc-predef/ cfe/trunk/test/Driver/stdc-pred

[PATCH] D41074: [ClangFormat] ObjCSpaceBeforeProtocolList should be true in the google style

2017-12-11 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton created this revision. Herald added a subscriber: cfe-commits. The Google style guide is neutral on whether there should be a space before the protocol list in an Objective-C @interface or @implementation. The majority of Objective-C code in both Apple's public header files and Google

[PATCH] D41064: Suppress -Wuser-defined-literals for and

2017-12-11 Thread Dimitry Andric via Phabricator via cfe-commits
dim updated this revision to Diff 126397. dim added a comment. Updated to also include and . I think all cases are covered now. Repository: rCXX libc++ https://reviews.llvm.org/D41064 Files: include/chrono include/complex include/string include/string_view Index: include/string_v

[PATCH] D41073: Wasm: add support in libcxx

2017-12-11 Thread Nicholas Wilson via Phabricator via cfe-commits
ncw created this revision. Herald added subscribers: cfe-commits, aheejin, jfb. Herald added a reviewer: EricWF. It turns out that this is the only change required in libcxx for it to compile with the new `wasm32-unknown-unknown-wasm` target recently added to Clang. I haven't done much testing o

[PATCH] D41064: Suppress -Wuser-defined-literals for and

2017-12-11 Thread Marshall Clow via Phabricator via cfe-commits
mclow.lists requested changes to this revision. mclow.lists added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D41064#950946, @aaron.ballman wrote: > I think that it would be more appropriate to fix this in Clang rather than > libc++. For instance, we don

[PATCH] D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs

2017-12-11 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added inline comments. Comment at: lib/Sema/SemaLambda.cpp:1491 else diag << From.getVariable(); diag << From.isNonODRUsed(); dim wrote: > Just for sanity's sake, I would still put an assert here, that > `getVariable()` does not return

[PATCH] D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs

2017-12-11 Thread Malcolm Parsons via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320396: [Sema] Fix crash in unused-lambda-capture warning for VLAs (authored by malcolm.parsons). Repository: rL LLVM https://reviews.llvm.org/D41016 Files: cfe/trunk/include/clang/Sema/ScopeInfo.h

r320396 - [Sema] Fix crash in unused-lambda-capture warning for VLAs

2017-12-11 Thread Malcolm Parsons via cfe-commits
Author: malcolm.parsons Date: Mon Dec 11 10:00:36 2017 New Revision: 320396 URL: http://llvm.org/viewvc/llvm-project?rev=320396&view=rev Log: [Sema] Fix crash in unused-lambda-capture warning for VLAs Summary: Clang was crashing when diagnosing an unused-lambda-capture for a VLA because From.getV

[PATCH] D41016: [Sema] Fix crash in unused-lambda-capture warning for VLAs

2017-12-11 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons updated this revision to Diff 126394. malcolm.parsons marked an inline comment as done. malcolm.parsons added a comment. Add assert. Repository: rC Clang https://reviews.llvm.org/D41016 Files: include/clang/Sema/ScopeInfo.h lib/Sema/SemaLambda.cpp test/SemaCXX/warn-unus

[PATCH] D41042: [analyzer] StackAddrEscape: Delay turning on by default a little bit?

2017-12-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 126390. NoQ added a comment. Add a FIXME test. https://reviews.llvm.org/D41042 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp test/Analysis/stack-capture-leak-arc.mm test/Analysis/stack-ca

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

2017-12-11 Thread Strahinja Petrovic via Phabricator via cfe-commits
spetrovic added a comment. ping https://reviews.llvm.org/D39053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40998: [driver][darwin] Take the OS version specified in "-target" as the target OS instead of inferring it from SDK / environment

2017-12-11 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman updated this revision to Diff 126388. arphaman marked an inline comment as done. arphaman added a comment. Don't warn about the redundant environment variable Repository: rC Clang https://reviews.llvm.org/D40998 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/darwin-version.

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-11 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. \o/ Comment at: clangd/index/Index.cpp:34 + +SymbolSlab::const_iterator SymbolSlab::find(const SymbolID& SymID) const { + return Symbols.find(SymID);

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

2017-12-11 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL320391: For Linux/gnu compatibility, preinclude if the file is available (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D34158?vs=123613&id=126386#toc Repository: rL LLV

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

2017-12-11 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC320391: For Linux/gnu compatibility, preinclude if the file is available (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D34158?vs=123613&id=126387#toc Repository: rC Cla

[PATCH] D41042: [analyzer] StackAddrEscape: Delay turning on by default a little bit?

2017-12-11 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Yeah, we usually try to avoid omissions of modeling in on-by-default checkers because the user may accidentally run into projects in which the unmodeled idiom is common, and then he'd get false positives all over the place. In my case it was just two new positives, both fal

r320391 - For Linux/gnu compatibility, preinclude if the file is available

2017-12-11 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Mon Dec 11 09:36:42 2017 New Revision: 320391 URL: http://llvm.org/viewvc/llvm-project?rev=320391&view=rev Log: For Linux/gnu compatibility, preinclude if the file is available As reported in llvm bugzilla 32377. Here’s a patch to add preinclude of stdc-predef.h. The gc

Re: r320297 - Fix MSVC 'not all control paths return a value' warning

2017-12-11 Thread Alex L via cfe-commits
Thanks! On 10 December 2017 at 03:05, Simon Pilgrim via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rksimon > Date: Sun Dec 10 03:05:14 2017 > New Revision: 320297 > > URL: http://llvm.org/viewvc/llvm-project?rev=320297&view=rev > Log: > Fix MSVC 'not all control paths return a val

Re: [PATCH] D40746: Correctly handle line table entries without filenames during AST serialization

2017-12-11 Thread Hans Wennborg via cfe-commits
+Tom I expect it's too late since 5.0.1 is virtually out the door already. On Mon, Dec 11, 2017 at 2:35 AM, Ivan Donchevskii via Phabricator < revi...@reviews.llvm.org> wrote: > yvvan added a comment. > > Can we still have it in 5.0? > > > Repository: > rL LLVM > > https://reviews.llvm.org/D40

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

2017-12-11 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. Thanks, this looks like exactly the right amount of magic to me :-) Comment at: clangd/Context.h:91 + /// functions that require a context when no explicit context is available. + static const Context &empty(); + --

[PATCH] D40548: [clangd] Symbol index interfaces and index-based code completion.

2017-12-11 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: clangd/ClangdIndex.h:1 +//===--- ClangdIndex.h - Symbol indexes for clangd.---*- C++-*-===// +// sammccall wrote: > nit: `Clangd` prefix doesn't do much. > I'd suggest `Index.h` for the interface (including S

[PATCH] D40548: [clangd] Symbol index interfaces and index-based code completion.

2017-12-11 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 126379. ioeric marked 8 inline comments as done. ioeric added a comment. - Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40548 Files: clangd/CMakeLists.txt clangd/ClangdIndex.cpp clangd/ClangdIndex.h clangd/

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: clangd/ClangdServer.cpp:36 - ~FulfillPromiseGuard() { Promise.set_value(); } + ~FulfillContextPromiseGuard() { Promise.set_value(std::move(Ctx)); } sammccall wrote: > Yikes, I can see how we got here, but we

[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

2017-12-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D41056#951083, @alexfh wrote: > In https://reviews.llvm.org/D41056#950605, @khuttun wrote: > > > In https://reviews.llvm.org/D41056#950570, @Eugene.Zelenko wrote: > > > > > May be //bugprone// is better module then //misc//? > > > > > > M

[PATCH] D40897: [clangd] Introduce a "Symbol" class.

2017-12-11 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 126378. hokein marked 5 inline comments as done. hokein added a comment. Address comments on SymbolID. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40897 Files: clangd/CMakeLists.txt clangd/index/CMakeLists.txt clangd/index/Index.cpp

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

2017-12-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clangd/Context.h:65 + Context *Parent; + TypedValueMap Data; +}; klimek wrote: > sammccall wrote: > > ilya-biryukov wrote: > > > sammccall wrote: > > > > ilya-biryu

[PATCH] D40488: [clangd] Implemented tracing using Context

2017-12-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 126376. ilya-biryukov added a comment. - Use derive(key, value) instead of derive().add(key, value). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40488 Files: clangd/ClangdUnit.cpp clangd/JSONRPCDispatcher.cpp clangd/Trace.cpp

[PATCH] D40486: [clangd] Implemented logging using Context

2017-12-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 126375. ilya-biryukov added a comment. - Use derive(key, val) instead of derive().add(key, val). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40486 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.

[PATCH] D40485: [clangd] Introduced a Context that stores implicit data

2017-12-11 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 126373. ilya-biryukov added a comment. - Removed ContextBuilder and TypedValueMap. - Updated the docs. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D40485 Files: clangd/CMakeLists.txt clangd/Context.cpp clangd/Context.h unitt

[PATCH] D38425: [clangd] Document highlights for clangd

2017-12-11 Thread William Enright via Phabricator via cfe-commits
Nebiroth added a comment. @ilya-biryukov Need someone to land this. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D38425: [clangd] Document highlights for clangd

2017-12-11 Thread William Enright via Phabricator via cfe-commits
Nebiroth updated this revision to Diff 126371. Nebiroth marked 3 inline comments as done. Nebiroth added a comment. Herald added a subscriber: mgrang. Merged with latest llvm/clang Minor code cleanup Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38425 Files: clangd/ClangdLSP

[PATCH] D41056: [clang-tidy] New check misc-uniqueptr-release-unused-retval

2017-12-11 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D41056#950605, @khuttun wrote: > In https://reviews.llvm.org/D41056#950570, @Eugene.Zelenko wrote: > > > May be //bugprone// is better module then //misc//? > > > Maybe. I can move it if all the reviewers think that it would be better > suited

[PATCH] D40860: [clangd] Fix diagnostic positions

2017-12-11 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry for the delay getting this reviewed. LG, thanks for fixing this! Just style nits. Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:124 +/// Convert a clang::So

  1   2   >