r316826 - Basic: improve coverage for Darwin targets and fix ABI

Author: compnerd Date: Fri Oct 27 23:00:43 2017 New Revision: 316826 URL: http://llvm.org/viewvc/llvm-project?rev=316826&view=rev Log: Basic: improve coverage for Darwin targets and fix ABI The existing coverage for the Darwin targets wasn't enough to catch all the variations. Improve the covera

[PATCH] D39382: [libunwind] Restore arch specific lastDwarfRegNum in builds without _LIBUNWIND_IS_NATIVE_ONLY

mstorsjo added a comment. In https://reviews.llvm.org/D39382#909918, @compnerd wrote: > This is fine, although, how does the cross-unwinding work without the remote > address space support? No idea - I also was under the impression that it wasn't actually useful but mostly theoretical/planned

[PATCH] D38596: Implement attribute target multiversioning

erichkeane added a comment. Hi Richard, thanks for the review! I'll make another attempt with this based on your feedback, though if you could clarify your suggestion, it would be greatly appreciated. In https://reviews.llvm.org/D38596#909957, @rsmith wrote: > I'm not entirely happy with the

[PATCH] D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases

szepet updated this revision to Diff 120726. szepet added a comment. Just removed some accidentally left changes from the patch. https://reviews.llvm.org/D39398 Files: include/clang/Analysis/CFG.h lib/Analysis/CFG.cpp test/Analysis/loopexit-cfg-output.cpp Index: test/Analysis/loopexit-cf

[PATCH] D39398: [CFG][Analyzer] Add LoopExit element to the CFG in more cases

szepet created this revision. Herald added subscribers: baloghadamsoftware, whisperity. This patch adds a LoopExit element to the CFG whenever a loop is exited by a ReturnStmt, GotoStmt or IndirectGotoStmt. The LoopExit element is consumed by the Static Analyzer in order to simulate the loops mo

r316820 - Never try to instantiate a deduction guide's "definition". Fixes bogus warning when there inevitably isn't one.

Author: rsmith Date: Fri Oct 27 18:15:00 2017 New Revision: 316820 URL: http://llvm.org/viewvc/llvm-project?rev=316820&view=rev Log: Never try to instantiate a deduction guide's "definition". Fixes bogus warning when there inevitably isn't one. Modified: cfe/trunk/lib/Sema/SemaTemplateInstan

[PATCH] D39396: Fix for PR33930. Short-circuit metadata mapping when cloning a varargs thunk.

wolfgangp created this revision. The problem in PRR33930 comes about because clang is cloning a function (to generate varargs thunks) before all the Metadata nodes are resolved. The value mapper, which is used by the cloner to deal with Medatdata no

[PATCH] D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang

yamaguchi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1171 + StringRef TargetFlag = PassedFlags; + for (; TargetFlag.find(':') != StringRef::npos;) { +StringRef CurFlag; v.g.vassilev wrote: > Why not a `while` loop? I didn't have special

[PATCH] D38596: Implement attribute target multiversioning

rsmith added a comment. I'm not entirely happy with the AST representation you're using here. Allowing multiple declarations of the same entity to have (semantically distinct) bodies breaks our AST invariants, and will cause things like our PCH / modules support to fail. This can probably be ma

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

This revision was automatically updated to reflect the committed changes. Closed by commit rL316807: [MS] Allow access to ambiguous, inaccessible direct bases (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D39389?vs=120694&id=120713#toc Repository: rL LLVM https://revi

[PATCH] D39382: [libunwind] Restore arch specific lastDwarfRegNum in builds without _LIBUNWIND_IS_NATIVE_ONLY

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This is fine, although, how does the cross-unwinding work without the remote address space support? https://reviews.llvm.org/D39382 ___ cfe-

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. I guess... fine. LGTM, assuming we have test coverage for all the different cases. Repository: rL LLVM https://reviews.llvm.org/D39321 __

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd added a comment. Well, without matching that ABI, I think that centralizing the logic isn't any cleaner, since we determine the ABI later. With this, we also match the ABI as GNU defines it, and we can move the logic to the same location. `intptr_t` on Darwin && !WatchOS has the one

[PATCH] D39149: [libc++] Prevent tautological comparisons

smeenai added a comment. Ping. Like I said, not a huge fan of this change, but also not a huge fan of running into clang diagnostics (especially since we build with `-Werror` downstream). https://reviews.llvm.org/D39149 ___ cfe-commits mailing lis

r316810 - ARM: centralise SizeType, PtrDiffType, and IntPtrType

Author: compnerd Date: Fri Oct 27 16:04:27 2017 New Revision: 316810 URL: http://llvm.org/viewvc/llvm-project?rev=316810&view=rev Log: ARM: centralise SizeType, PtrDiffType, and IntPtrType Centralise the definitions of these compiler vended types to aid inspection to ensure that they are defined

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd closed this revision. compnerd added a comment. SVN r316810 Repository: rL LLVM https://reviews.llvm.org/D39321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd added a comment. Yeah, we have coverage for the various environments in `test/Preprocessor/init.c`. The one case that I didn't find was the APCS-GNU case, which I added a test for additional coverage. Repository: rL LLVM https://reviews.llvm.org/D39321 _

r316808 - [Analyzer] [Tests] Fixing typo from the previous commit.

Author: george.karpenkov Date: Fri Oct 27 15:52:36 2017 New Revision: 316808 URL: http://llvm.org/viewvc/llvm-project?rev=316808&view=rev Log: [Analyzer] [Tests] Fixing typo from the previous commit. Can not open a non-existent file with r+. Modified: cfe/trunk/utils/analyzer/SATestBuild.py

r316807 - [MS] Allow access to ambiguous, inaccessible direct bases

Author: rnk Date: Fri Oct 27 15:48:41 2017 New Revision: 316807 URL: http://llvm.org/viewvc/llvm-project?rev=316807&view=rev Log: [MS] Allow access to ambiguous, inaccessible direct bases Summary: Clang typically warns that in the following class hierarchy, 'A' is inaccessible because there is no

r316806 - [Analyzer] [Tests] Dump the output of scan-build to stdout on failure.

Author: george.karpenkov Date: Fri Oct 27 15:39:54 2017 New Revision: 316806 URL: http://llvm.org/viewvc/llvm-project?rev=316806&view=rev Log: [Analyzer] [Tests] Dump the output of scan-build to stdout on failure. Eliminates extra lookup step during debugging. Modified: cfe/trunk/utils/analy

[PATCH] D39308: [libcxx] Keep track of heap allocated regex states

timshen updated this revision to Diff 120711. timshen added a comment. Remove the uses of variadic template and auto. I'm not sure of how to implement this without a ABI change (the addition of __storage_). https://reviews.llvm.org/D39308 Files: libcxx/include/regex Index: libcxx/include/r

[PATCH] D38320: [clang] Fix serializers for `TypeTemplateParmDecl` + related types

arphaman added a comment. Hi, Thanks for your patch! Could you please post a patch with full context (git diff -U9)? Comment at: lib/Serialization/ASTWriterDecl.cpp:1541 - bool OwnsDefaultArg = D->hasDefaultArgument() && -!D->defaultArgumentWasI

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yuck, LGTM :) https://reviews.llvm.org/D39389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

smeenai added a comment. When you say "latest Windows SDK headers", do you mean SDK version 10.0.16299.15? https://reviews.llvm.org/D39389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringAction { +public: arphaman wrote: > ioeric wrote: > > ioeric wrote: > > > arphaman wrote: > > > > hokein wrote:

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

efriedma added a comment. Are you sure the change to APCS is right? I mean, it looks like it's right if I compare to gcc with -mabi=gnu-apcs, but I'm not sure what, exactly, we're trying to be compatible with, so I'd prefer not to touch it, especially not in a patch with a bunch of changes whi

[PATCH] D39389: [MS] Allow access to ambiguous, inaccessible direct bases

rnk created this revision. Clang typically warns that in the following class hierarchy, 'A' is inaccessible because there is no series of casts that the user can write to access it unambiguously: struct A { }; struct B : A { }; struct C : A, B { }; MSVC allows the user to convert from C* t

[PATCH] D39057: [clangd][WIP] Integrate the refactoring actions into clangd

arphaman added a comment. In https://reviews.llvm.org/D39057#907820, @sammccall wrote: > In https://reviews.llvm.org/D39057#906297, @ilya-biryukov wrote: > > > There's another patch (https://reviews.llvm.org/D39276) that tries to add > > `workspace/executeCommand` for a slightly different use-ca

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringAction { +public: ioeric wrote: > ioeric wrote: > > arphaman wrote: > > > hokein wrote: > > > > sammccall wro

r316793 - Sanitizers.h: Modularize/Fix ODR violations by making inline functions non-static

Author: dblaikie Date: Fri Oct 27 13:40:45 2017 New Revision: 316793 URL: http://llvm.org/viewvc/llvm-project?rev=316793&view=rev Log: Sanitizers.h: Modularize/Fix ODR violations by making inline functions non-static Modified: cfe/trunk/include/clang/Basic/Sanitizers.h Modified: cfe/trunk/i

r316792 - CharInfo.h: Modularize/fix ODR violations by making inline functions in header not static

Author: dblaikie Date: Fri Oct 27 13:40:45 2017 New Revision: 316792 URL: http://llvm.org/viewvc/llvm-project?rev=316792&view=rev Log: CharInfo.h: Modularize/fix ODR violations by making inline functions in header not static Modified: cfe/trunk/include/clang/Basic/CharInfo.h Modified: cfe/t

r316791 - ASTContext.h: Modularize/fix ODR violations by removing 'static' from inline functions in headers

Author: dblaikie Date: Fri Oct 27 13:40:44 2017 New Revision: 316791 URL: http://llvm.org/viewvc/llvm-project?rev=316791&view=rev Log: ASTContext.h: Modularize/fix ODR violations by removing 'static' from inline functions in headers Modified: cfe/trunk/include/clang/AST/ASTContext.h Modifie

r316794 - StaticAnalyzer: Modularize/fix ODR violations making functions inline but non-static in headers

Author: dblaikie Date: Fri Oct 27 13:40:46 2017 New Revision: 316794 URL: http://llvm.org/viewvc/llvm-project?rev=316794&view=rev Log: StaticAnalyzer: Modularize/fix ODR violations making functions inline but non-static in headers Also move these out of the llvm namespace & rely on ADL as is app

[PATCH] D39365: [libunwind] Change unw_word_t to always have the same size as the pointer size

mstorsjo added a comment. In https://reviews.llvm.org/D39365#909706, @rnk wrote: > Doesn't this change the ABI considerably? I suspect Apple cares about that. It does change the ABI of the lower level unw_* API yes, but it shouldn't be visible outside via the higher level APIs. > Is remotely

[PATCH] D39365: [libunwind] Change unw_word_t to always have the same size as the pointer size

rnk added a comment. Doesn't this change the ABI considerably? I suspect Apple cares about that. Is remotely unwinding a 64-bit thread from a 32-bit process a concern? That's the main use case that forcing 64-bit words seems to enable. https://reviews.llvm.org/D39365 ___

[PATCH] D39382: [libunwind] Restore arch specific lastDwarfRegNum in builds without _LIBUNWIND_IS_NATIVE_ONLY

mstorsjo created this revision. This restores the previous behaviour of the Registers_* classes after SVN r316745. https://reviews.llvm.org/D39382 Files: include/__libunwind_config.h src/Registers.hpp Index: src/Registers.hpp ===

Re: [libunwind] r316745 - Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER

On Fri, 27 Oct 2017, John Baldwin wrote: On 10/27/17 8:59 AM, Martin Storsjo via cfe-commits wrote: Author: mstorsjo Date: Fri Oct 27 00:59:01 2017 New Revision: 316745 URL: http://llvm.org/viewvc/llvm-project?rev=316745&view=rev Log: Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

kosarev updated this revision to Diff 120675. kosarev added a comment. Reworked to distinct may-alias accesses from ordinary ones with an explicit 'kind' field. https://reviews.llvm.org/D39008 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CGObjCRuntime.cpp lib/CodeGen/CGOpenMPRuntime.cpp l

[PATCH] D39342: [Bash-autocompletion] Pass all flags in shell command-line to Clang

v.g.vassilev added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1171 + StringRef TargetFlag = PassedFlags; + for (; TargetFlag.find(':') != StringRef::npos;) { +StringRef CurFlag; Why not a `while` loop? https://reviews.llvm.org/D39342

[PATCH] D24933: Enable configuration files in clang

sepavloff marked 3 inline comments as done. sepavloff added inline comments. Comment at: lib/Driver/Driver.cpp:739 + // like: i386-clang.cfg -> x86_64-clang.cfg. + if (ArchPrefixLen < CfgFileName.size()) +FixedConfigFile += CfgFileName.substr(ArchPrefixLen); ---

r316784 - Replace a few usages of llvm::join with range-version[NFC]

Author: erichkeane Date: Fri Oct 27 11:45:06 2017 New Revision: 316784 URL: http://llvm.org/viewvc/llvm-project?rev=316784&view=rev Log: Replace a few usages of llvm::join with range-version[NFC] I noticed a few usages of llvm::join that were using begin/end rather than just the range version. T

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringAction { +public: ioeric wrote: > arphaman wrote: > > hokein wrote: > > > sammccall wrote: > > > > As discussed

[PATCH] D39376: [PowerPC] Add implementation for -msave-toc-indirect option - clang portion

hfinkel added a comment. Please upload diffs with full context. Comment at: include/clang/Driver/Options.td:1907 def mvsx : Flag<["-"], "mvsx">, Group; +def msave_toc_indirect : Flag<["-"], "msave-toc-indirect">, Group; def mno_vsx : Flag<["-"], "mno-vsx">, Group; --

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

ioeric added inline comments. Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringAction { +public: arphaman wrote: > hokein wrote: > > sammccall wrote: > > > As discussed offline, it's not cle

[PATCH] D39357: Filter out invalid 'target' items from being passed to LLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rL316783: Filter out invalid 'target' items from being passed to LLVM (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D39357?vs=120659&id=120664#toc Repository: rL LLVM htt

[PATCH] D39357: Filter out invalid 'target' items from being passed to LLVM

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D39357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

r316783 - Filter out invalid 'target' items from being passed to LLVM

Author: erichkeane Date: Fri Oct 27 11:32:23 2017 New Revision: 316783 URL: http://llvm.org/viewvc/llvm-project?rev=316783&view=rev Log: Filter out invalid 'target' items from being passed to LLVM Craig noticed that CodeGen wasn't properly ignoring the values sent to the target attribute. This pa

[PATCH] D39378: Remove x86,x86_32/64 from isValidFeatureName

This revision was automatically updated to reflect the committed changes. Closed by commit rL316781: Remove x86,x86_32/64 from isValidFeatureName (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D39378?vs=120661&id=120663#toc Repository: rL LLVM https://reviews.ll

r316781 - Remove x86,x86_32/64 from isValidFeatureName

Author: erichkeane Date: Fri Oct 27 11:29:02 2017 New Revision: 316781 URL: http://llvm.org/viewvc/llvm-project?rev=316781&view=rev Log: Remove x86,x86_32/64 from isValidFeatureName These are not valid values for this, and are pretty non-sensical, since LLVM doesn't understand them. Differential

[PATCH] D39269: [Analyzer] [Tests] Do not discard output from CmpRuns.py when running integration tests

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. What kind of output will this start displaying? (I believe currently the script does print the summary of the objects that are added or deleted.) https://reviews.llvm.org/D39269 ___

[PATCH] D39378: Remove x86,x86_32/64 from isValidFeatureName

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D39378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D38844: [analyzer] Make issue hash related tests more concise

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:68 // (globals should not be invalidated, etc), hence the use of evalCall. - FnCheck Handler = llvm::StringSwitch(C.getCalleeName(CE)) -.Case("clang_analyzer_eval", &ExprIns

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

This revision was automatically updated to reflect the committed changes. arphaman marked 3 inline comments as done. Closed by commit rL316780: [refactor] Describe refactorings in the operation classes (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D38985?vs=120466&id

[PATCH] D39378: Remove x86,x86_32/64 from isValidFeatureName

erichkeane created this revision. These are not valid values for this, and are pretty non-sensical, since LLVM doesn't understand them. https://reviews.llvm.org/D39378 Files: lib/Basic/Targets/X86.cpp Index: lib/Basic/Targets/X86.cpp =

[PATCH] D38728: [analyzer] Use the signature of the primary template for issue hash calculation

zaks.anna accepted this revision. zaks.anna added a comment. LGTM! https://reviews.llvm.org/D38728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r316780 - [refactor] Describe refactorings in the operation classes

Author: arphaman Date: Fri Oct 27 11:19:11 2017 New Revision: 316780 URL: http://llvm.org/viewvc/llvm-project?rev=316780&view=rev Log: [refactor] Describe refactorings in the operation classes This commit changes the way that the refactoring operation classes are structured: - Users have to call

[PATCH] D39357: Filter out invalid 'target' items from being passed to LLVM

erichkeane updated this revision to Diff 120659. erichkeane added a comment. Switched to llvm::remove_if(RANGE, lambda) instead of std::remove_if with begin/end per Craig's suggestion. https://reviews.llvm.org/D39357 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets/X86.cpp lib/C

[PATCH] D38844: [analyzer] Make issue hash related tests more concise

zaks.anna added a comment. Please, change the commit description to be more comprehensive. Comment at: lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:68 // (globals should not be invalidated, etc), hence the use of evalCall. - FnCheck Handler = llvm::StringSwitch(C.g

[PATCH] D37341: [Sema] Fix an assert-on-invalid by avoiding function template specialisation deduction for invalid functions with fabricated template arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL316778: [Sema] Fix an assert-on-invalid by avoiding function template specialisation (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D37341?vs=119967&id=120658#toc Repository:

[PATCH] D39357: Filter out invalid 'target' items from being passed to LLVM

craig.topper added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:4586 +ParsedAttr.Features.erase( +remove_if(ParsedAttr.Features.begin(), ParsedAttr.Features.end(), +[&](const std::string &Feat) { Use llvm::remove_if which takes a

r316778 - [Sema] Fix an assert-on-invalid by avoiding function template specialisation

Author: arphaman Date: Fri Oct 27 11:13:31 2017 New Revision: 316778 URL: http://llvm.org/viewvc/llvm-project?rev=316778&view=rev Log: [Sema] Fix an assert-on-invalid by avoiding function template specialisation deduction for invalid functions The fabricated template parameters cause an assertion

[PATCH] D39354: [WebAssembly] Add crt1.o when calling lld

This revision was automatically updated to reflect the committed changes. Closed by commit rL316777: [WebAssembly] Add crt1.o with calling lld (authored by sbc). Repository: rL LLVM https://reviews.llvm.org/D39354 Files: cfe/trunk/lib/Driver/ToolChain.cpp cfe/trunk/lib/Driver/ToolChains/W

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

kosarev updated this revision to Diff 120654. kosarev added a comment. - Fixed the type of the reference lvalue in loadToBegin(). John, can you please review the fix? Thanks. https://reviews.llvm.org/D39177 Files: lib/CodeGen/CGBlocks.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CGOpenMPRuntim

r316777 - [WebAssembly] Add crt1.o with calling lld

Author: sbc Date: Fri Oct 27 11:10:19 2017 New Revision: 316777 URL: http://llvm.org/viewvc/llvm-project?rev=316777&view=rev Log: [WebAssembly] Add crt1.o with calling lld Also, for OS unknown targets like wasm, don't include 'unknown' in the library path. This is a fix for rL316719. Differentia

[PATCH] D39177: [CodeGen] Generate TBAA info for reference loads

kosarev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1041 +else + BaseLV = CGF.EmitLoadOfReferenceLValue(BaseLV); BaseTy = BaseTy->getPointeeType(); Oh-oh, it looks I do something not functionally equivalent here. Sorry, will

[PATCH] D37437: [analyzer] Fix some checker's output plist not containing the checker name

zaks.anna added a comment. Just to be clear, since this leads to regression to the checker API, I am asking to look into other ways of solving this problem. For example, is there a way to ensure that the checker names are set at construction? https://reviews.llvm.org/D37437

[PATCH] D38674: [analyzer] MisusedMovedObjectChecker: More precise warning message

zaks.anna added a comment. Please, commit. https://reviews.llvm.org/D38674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39332: [clang-refactor] Introduce "local-qualified-rename" action.

arphaman added a comment. I've committed https://reviews.llvm.org/D38985, so you'd have to rebase unfortunately. Things are still somewhat unstable :) Comment at: lib/Tooling/Refactoring/Rename/RenamingAction.cpp:154 + +class LocalQualifiedRename final : public RefactoringActi

[PATCH] D38596: Implement attribute target multiversioning

erichkeane updated this revision to Diff 120620. erichkeane added a comment. Fixes for Aaron's comments. https://reviews.llvm.org/D38596 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/TargetInfo.h include/clan

[PATCH] D38596: Implement attribute target multiversioning

aaron.ballman added a comment. I think the attribute and sema parts look good, but I leave the codegen bits to someone with more experience in that area. https://reviews.llvm.org/D38596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D38596: Implement attribute target multiversioning

erichkeane updated this revision to Diff 120636. erichkeane added a comment. Fix comment in Attr.td that @aaron.ballman brought up on IRC. https://reviews.llvm.org/D38596 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td include/clang

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

This revision was automatically updated to reflect the committed changes. Closed by commit rL316773: New lldb python module for managing diagnostic breakpoints (authored by dhinton). Repository: rL LLVM https://reviews.llvm.org/D36347 Files: cfe/trunk/utils/clangdiag.py Index: cfe/trunk/ut

[PATCH] D37470: [analyzer] Handle ObjC messages conservatively in CallDescription

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. Thanks Gabor. Looks great to me! https://reviews.llvm.org/D37470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[clang-tools-extra] r316774 - [clangd] Don't crash on extremely large JSON messages.

Author: d0k Date: Fri Oct 27 10:06:41 2017 New Revision: 316774 URL: http://llvm.org/viewvc/llvm-project?rev=316774&view=rev Log: [clangd] Don't crash on extremely large JSON messages. Found by clangd-fuzzer. Added: clang-tools-extra/trunk/test/clangd/too_large.test Modified: clang-tools

r316773 - New lldb python module for managing diagnostic breakpoints

Author: dhinton Date: Fri Oct 27 10:02:33 2017 New Revision: 316773 URL: http://llvm.org/viewvc/llvm-project?rev=316773&view=rev Log: New lldb python module for managing diagnostic breakpoints Summary: Can be used to set breakpoints for either the diagnostics actually emitted for the current comp

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

arphaman added inline comments. Comment at: lib/Tooling/Refactoring/RefactoringActions.cpp:28 + +// FIXME: Remove the Actions alltogether. +class ExtractRefactoring final : public RefactoringAction { ioeric wrote: > Maybe I'm missing the context here... Why do we

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120629. hintonda added a comment. - Remove whitespace. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++ utils/clangdiag.py @@ -0,0 +

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

compnerd added inline comments. Comment at: include/__libunwind_config.h:69 +# define _LIBUNWIND_CURSOR_SIZE 47 +# define _LIBUNWIND_HIGHEST_DWARF_REGISTER 65 # else Can we sink the two cases into the `__mips__` case? Something like: #if defined(__mips__

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7 PM Pacific time. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

malaperle added a comment. Can you revert the formatting changes in places you haven’t touched (mainly astunit.cpp)? I think you should be able to do that with git checkout -p HEAD~1 https://reviews.llvm.org/D39375 ___ cfe-commits mailing list cfe-

[clang-tools-extra] r316770 - [clangd] Harden clangd a bit against garbage input.

Author: d0k Date: Fri Oct 27 09:33:15 2017 New Revision: 316770 URL: http://llvm.org/viewvc/llvm-project?rev=316770&view=rev Log: [clangd] Harden clangd a bit against garbage input. There can be nullptrs here if the YAML fails to parse. Found by clangd-fuzzer! Modified: clang-tools-extra/tru

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120628. hintonda added a comment. - Add support for individual DiagID's, and print out number of breakpoints added. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py

Re: [libunwind] r316745 - Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER

On 10/27/17 8:59 AM, Martin Storsjo via cfe-commits wrote: > Author: mstorsjo > Date: Fri Oct 27 00:59:01 2017 > New Revision: 316745 > > URL: http://llvm.org/viewvc/llvm-project?rev=316745&view=rev > Log: > Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER > > This avoids

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

bsdjhb updated this revision to Diff 120624. bsdjhb added a comment. - Rebase after MAX_REGISTER change. https://reviews.llvm.org/D39074 Files: include/__libunwind_config.h src/AddressSpace.hpp src/DwarfInstructions.hpp src/Registers.hpp src/UnwindCursor.hpp src/UnwindRegistersResto

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a reviewer: bruno. MontyKutyi added a comment. Ping. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

bsdjhb updated this revision to Diff 120623. bsdjhb added a comment. - Rebase for recent change to MAX_REGISTER meaning. https://reviews.llvm.org/D38110 Files: include/__libunwind_config.h include/libunwind.h src/Registers.hpp src/UnwindCursor.hpp src/UnwindRegistersRestore.S src/Un

[PATCH] D39376: [PowerPC] Add implementation for -msave-toc-indirect option - clang portion

syzaara created this revision. Add clang option -msave-toc-indirect for PowerPC. https://reviews.llvm.org/D39376 Files: include/clang/Driver/Options.td test/Driver/ppc-features.cpp Index: test/Driver/ppc-features.cpp === ---

[PATCH] D38596: Implement attribute target multiversioning

erichkeane marked 2 inline comments as done. erichkeane added inline comments. Comment at: include/clang/Basic/Attr.td:1917 + MVK_All, // All Decls of this function have a 'target' attribute. None differ + // in contents, so this is the 'hint' case. + MVK_Mu

[PATCH] D39375: [clang] Add PPCallbacks list to preprocessor when building a preacompiled preamble.

Nebiroth created this revision. Revision https://reviews.llvm.org/D38639 needs this commit in order to properly make open definition calls on include statements work. Since this modifies clang and not clangd, I decided to include it in a different patch. https://reviews.llvm.org/D39375 Files:

[PATCH] D37554: [libclang] Allow crash recovery with LIBCLANG_NOTHREADS

nik added reviewers: ddunbar, krememek. nik added a comment. ...added some more reviewers that I've found with git blame. Ping to the new ones :) https://reviews.llvm.org/D37554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D39372: Make DiagnosticIDs::getAllDiagnostics static.

leanil created this revision. It doesn't depend on instance specific data, so this would make it easier to use, for example here : https://reviews.llvm.org/D39372 Files: include/clang/Basic/DiagnosticIDs.h lib/Basic/DiagnosticIDs.cpp Index: lib/Basic/Diag

[PATCH] D38171: Implement clang-tidy check aliases.

leanil added a comment. In https://reviews.llvm.org/D38171#901427, @xazax.hun wrote: > One problem to think about when we add all clang-diagnostic as "first or > second" class citizen, `checkes=*` might now enable all the warnings which > make no sense and might be surprising to the users. What

[PATCH] D39374: CodeGen: Fix insertion position of addrspace cast for alloca

yaxunl created this revision. For non-zero alloca addr space, alloca is usually casted to default addr space immediately. For non-vla, alloca is inserted at AllocaInsertPt, therefore the addr space cast should also be insterted at AllocaInsertPt. However, for vla, alloca is inserted at the curren

[clang-tools-extra] r316767 - [clang-tidy] Fix bug 34845, offending standard bitmask types

Author: jonastoth Date: Fri Oct 27 07:44:08 2017 New Revision: 316767 URL: http://llvm.org/viewvc/llvm-project?rev=316767&view=rev Log: [clang-tidy] Fix bug 34845, offending standard bitmask types Summary: The C++ standard allows implementations to choose the underlying type for bitmask types (e.

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

aaron.ballman added inline comments. Comment at: clang-tidy/bugprone/MisplacedOperatorInStrlenInAllocCheck.cpp:64-65 +Alloc = Result.Nodes.getNodeAs("Alloc"); + assert(Alloc && "Matched node bound by `Alloc` shoud be either `CallExpr`" + " or `CXXNewExpr`"); + --

[PATCH] D38171: Implement clang-tidy check aliases.

leanil updated this revision to Diff 120597. leanil added a comment. > Make clang-diagnostic-* checks first-class citizens and take full control of > all diagnostics, i.e. disable all Clang diagnostics by default, and enable > the ones that correspond to the enabled clang-diagnostic checks. (As

[PATCH] D39121: [clang-tidy] Misplaced Operator in Strlen in Alloc

aaron.ballman added a comment. My only remaining concern is with the diagnostic message/fixit interaction itself. Let's see if @alexfh has any suggestions there, or we think of an improvement ourselves. https://reviews.llvm.org/D39121 ___ cfe-comm

[PATCH] D37470: [analyzer] Handle ObjC messages conservatively in CallDescription

xazax.hun updated this revision to Diff 120598. xazax.hun added a comment. - Added a separate test case as per Devin's suggestion https://reviews.llvm.org/D37470 Files: lib/StaticAnalyzer/Core/CallEvent.cpp test/Analysis/block-in-critical-section.m Index: test/Analysis/block-in-critical-s

[PATCH] D37470: [analyzer] Handle ObjC messages conservatively in CallDescription

xazax.hun added a comment. In https://reviews.llvm.org/D37470#906717, @dcoughlin wrote: > I think it would be better to add a new > "test/Analysis/block-in-critical-section.m" file rather than enabling a > random alpha checker in a file that tests the analyzer core. My reasoning was that the

[PATCH] D39367: [clang-tidy] Add support for operator new[] in check bugprone-misplaced-operator-in-strlen-in-alloc

baloghadamsoftware updated this revision to Diff 120595. baloghadamsoftware added a comment. Herald added a subscriber: mgorny. Backsticks changed to single quotes, new tests added. https://reviews.llvm.org/D39367 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLi

  1   2   >