[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

2017-09-26 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added inline comments. Comment at: tools/clang/lib/Driver/ToolChain.cpp:394 +llvm::SmallString<8> LinkerName; +if(Triple.isOSDarwin()) + LinkerName.append("ld64."); Space between `if` and `(` Repository: rL LLVM https://reviews.llvm.org

[PATCH] D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true.

2017-09-26 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Looks good! I must have gotten confused with my test suggestion. Do you have commit access, or should I commit this for you? https://reviews.llvm.org/D37904 ___

r314268 - Add test forgotten in r314262.

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 20:23:02 2017 New Revision: 314268 URL: http://llvm.org/viewvc/llvm-project?rev=314268&view=rev Log: Add test forgotten in r314262. Added: cfe/trunk/test/CodeGenCXX/extern-section-attribute.cpp (with props) Added: cfe/trunk/test/CodeGenCXX/extern-section

r314267 - Fix capitalization of a bunch of parameters in SemaDeclAttr [NFC]

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 20:20:13 2017 New Revision: 314267 URL: http://llvm.org/viewvc/llvm-project?rev=314267&view=rev Log: Fix capitalization of a bunch of parameters in SemaDeclAttr [NFC] Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp Modified: cfe/trunk/lib/Sema/SemaDeclAttr.c

[PATCH] D38040: [OpenMP] Add an additional test for D34888

2017-09-26 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 116747. gtbercea added a comment. Fix test. https://reviews.llvm.org/D38040 Files: test/OpenMP/openmp_offload_codegen.cpp Index: test/OpenMP/openmp_offload_codegen.cpp === --- /dev/null ++

r314264 - [clang-format] Adjust space around &/&& of structured bindings

2017-09-26 Thread Chih-Hung Hsieh via cfe-commits
Author: chh Date: Tue Sep 26 17:58:45 2017 New Revision: 314264 URL: http://llvm.org/viewvc/llvm-project?rev=314264&view=rev Log: [clang-format] Adjust space around &/&& of structured bindings Keep space before or after the &/&& tokens, but not both. For example, auto [x,y] = a; auto &[xr, yr

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

2017-09-26 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314264: [clang-format] Adjust space around &/&& of structured bindings (authored by chh). Changed prior to commit: https://reviews.llvm.org/D35743?vs=116201&id=116744#toc Repository: rL LLVM https:/

[PATCH] D38040: [OpenMP] Add an additional test for D34888

2017-09-26 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea reopened this revision. gtbercea added a comment. This revision is now accepted and ready to land. Open https://reviews.llvm.org/D38040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true.

2017-09-26 Thread Krasimir Georgiev via cfe-commits
I'm currently at cppcon with limited bandwidth for reviews. I believe that the literal test that I mentioned put inside the namespace fixer test suite fails before your changes, could you please double check? On Tue, 26 Sep 2017, 15:30 Marek Kurdej via Phabricator, < revi...@reviews.llvm.org> wrot

[PATCH] D37695: [clang-format] Break non-trailing comments, try 2

2017-09-26 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 116742. krasimir added a comment. - Change bool from Paren to Line and generalize it https://reviews.llvm.org/D37695 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp lib/Format/ContinuationIndente

[PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2017-09-26 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. Does this have to be exposed through the driver or could this be a cc1 option only? Comment at: include/clang/Basic/LangOptions.def:144 BENIGN_LANGOPT(EmitAllDecls , 1, 0, "emitting all declarations") +BENIGN_LANGOPT(EmitFwdTemplateChildren, 1, 0

[PATCH] D37023: [analyzer] Fix bugreporter::getDerefExpr() again.

2017-09-26 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. LGTM! Thanks Artem. https://reviews.llvm.org/D37023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: r314235 - Allow IUnknown/IInterface types to come from extern C++

2017-09-26 Thread Keane, Erich via cfe-commits
BTW: The guy who told me about this issue ALSO discovered a different issue that that I didn't solve due to his reproducer not contining the whole testcase. I've got a patch to fix all of it in his hands right now, so I'll submit this fix with it together. -Erich -Original Message- Fr

[PATCH] D36487: Emit section information for extern variables.

2017-09-26 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314262: Emit section information for extern variables. (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D36487?vs=116581&id=116739#toc Repository: rL LLVM https://reviews

r314262 - Emit section information for extern variables.

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 16:42:34 2017 New Revision: 314262 URL: http://llvm.org/viewvc/llvm-project?rev=314262&view=rev Log: Emit section information for extern variables. Currently, if _attribute_((section())) is used for extern variables, section information is not emitted in gene

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

2017-09-26 Thread Wei Mi via Phabricator via cfe-commits
wmi added a comment. In https://reviews.llvm.org/D36562#880808, @hfinkel wrote: > You seem to be only changing the behavior for the "separatable" fields, but I > suspect you want to change the behavior for the others too. The bitfield > would be decomposed into shards, separated by the naturall

[libclc] r314261 - Add missing HAVE_LLVM define to fix build with latest llvm

2017-09-26 Thread Jan Vesely via cfe-commits
Author: jvesely Date: Tue Sep 26 16:15:54 2017 New Revision: 314261 URL: http://llvm.org/viewvc/llvm-project?rev=314261&view=rev Log: Add missing HAVE_LLVM define to fix build with latest llvm Broken since r314111 V2: pointed out by Jan Vesely - Use format() instead of % formating Patch-by:

[libcxx] r314259 - [libcxx] [test] Fix unused local typedef warnings.

2017-09-26 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Tue Sep 26 16:08:43 2017 New Revision: 314259 URL: http://llvm.org/viewvc/llvm-project?rev=314259&view=rev Log: [libcxx] [test] Fix unused local typedef warnings. Modified: libcxx/trunk/test/std/strings/basic.string/string.ops/string_find.last.not.of/string_view_size.p

[libcxx] r314258 - [libcxx] [test] Strip trailing whitespace.

2017-09-26 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Tue Sep 26 16:08:41 2017 New Revision: 314258 URL: http://llvm.org/viewvc/llvm-project?rev=314258&view=rev Log: [libcxx] [test] Strip trailing whitespace. Modified: libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_insert/string_view.pass.cpp Modified

[libcxx] r314257 - [libcxx] [test] Silence warning C4324 for MSVC.

2017-09-26 Thread Stephan T. Lavavej via cfe-commits
Author: stl_msft Date: Tue Sep 26 16:08:39 2017 New Revision: 314257 URL: http://llvm.org/viewvc/llvm-project?rev=314257&view=rev Log: [libcxx] [test] Silence warning C4324 for MSVC. This warning "structure was padded due to alignment specifier" says that the compiler is going to do exactly what

[PATCH] D36487: Emit section information for extern variables.

2017-09-26 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D36487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D38203: [Sema] Corrected the warn-on-throw-from-noexcept behavior to include nothrow

2017-09-26 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314229: [Sema] Corrected the warn-on-throw-from-noexcept behavior to include nothrow (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D38203?vs=116426&id=116729#toc Repositor

[PATCH] D38243: [clang-format] Add ext/ to google include categories

2017-09-26 Thread Krasimir Georgiev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314211: [clang-format] Add ext/ to google include categories (authored by krasimir). Repository: rL LLVM https://reviews.llvm.org/D38243 Files: cfe/trunk/lib/Format/Format.cpp Index: cfe/trunk/lib

[PATCH] D36737: [analyzer] Store design discussions in docs/analyzer for future use.

2017-09-26 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314218: [analyzer] Keep track of design discusions as part of analyzer documentation. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D36737?vs=116520&id=116724#toc Repositor

[PATCH] D38168: [mips] Accept but ignore -m(no-)branch-likely

2017-09-26 Thread Simon Dardis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314213: [mips] Accept but ignore -m(no-)branch-likely (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D38168 Files: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/test/Dri

[PATCH] D38074: Fix TBAA information for reference accesses

2017-09-26 Thread Ivan A. Kosarev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL314209: Fix TBAA information for reference accesses (authored by kosarev). Changed prior to commit: https://reviews.llvm.org/D38074?vs=116326&id=116721#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D37891: Driver: hoist the `wchar_t` handling to the driver

2017-09-26 Thread Matthias Braun via Phabricator via cfe-commits
MatzeB added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:477 Context.getTypeSizeInChars(Context.getWideCharType()).getQuantity(); - assert((LangOpts.ShortWChar || - llvm::TargetLibraryInfoImpl::getTargetWCharSize(Target.getTriple()) == ---

[PATCH] D14358: DWARF's forward decl of a template should have template parameters.

2017-09-26 Thread Paul Robinson via Phabricator via cfe-commits
probinson updated this revision to Diff 116711. probinson added a comment. Add a command-line flag to control emitting the template parameter children. Default to on for SCE debugger tuning. I am not super excited about my choice of option name or the help text; alternate suggestions welcome. I

[PATCH] D38209: [Sema] Correct nothrow inherited by noexcept

2017-09-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In https://reviews.llvm.org/D38209#880559, @aaron.ballman wrote: > In https://reviews.llvm.org/D38209#880553, @STL_MSFT wrote: > > > > do you think `__declspec(nothrow)` calling the terminate handler in Clang > > > is a bug? > > > > It's certainly a behavior differenc

[PATCH] D29479: Driver: Do not warn about unused -pthread when linking on darwin

2017-09-26 Thread Matthias Braun via Phabricator via cfe-commits
MatzeB closed this revision. MatzeB added a comment. This was accepted on the mailinglist and committed in r294065 Repository: rL LLVM https://reviews.llvm.org/D29479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

2017-09-26 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: lib/Sema/SemaType.cpp:6974 + if (state.getSema().getLangOpts().OpenCL && !hasOpenCLAddressSpace && + type.getAddressSpace() == LangAS::Default && Anastasia wrote: > I am no

[PATCH] D38202: Add Documentation to attribute-nothrow. Additionally, limit to functions.

2017-09-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 116705. erichkeane added a comment. Added declspec, fixed does cannot. https://reviews.llvm.org/D38202 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td test/Misc/pragma-attribute-supported-attributes-list.test Index: test/Misc/p

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

2017-09-26 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 116704. yaxunl marked 5 inline comments as done. yaxunl added a comment. Rebase to ToT and clean up logic. https://reviews.llvm.org/D35082 Files: include/clang/AST/ASTContext.h include/clang/AST/Type.h include/clang/Basic/AddressSpaces.h lib/AST/ASTC

[PATCH] D38202: Add Documentation to attribute-nothrow. Additionally, limit to functions.

2017-09-26 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2692 + let Content = [{ +Clang supports the GNU style ``__attribute__((nothrow))`` attribute as an +equivilent of `noexcept` on function declarations. This

[PATCH] D38291: clang-format/java: Unbreak genenrics formatting after r299952.

2017-09-26 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/rL299952 merged '>>>' tokens into a single JavaRightLogicalShift token. This broke formatting of generics nested more than two deep, e.g. `Foo>>` because the '>>>' now weren't three '>' for parseAngle().

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

2017-09-26 Thread Martell Malone via Phabricator via cfe-commits
martell added a comment. I have a patch that does a bunch of updates for testing lld correctly in clang and this was a part of it but I didn't want the patch to get too involved so I separated this out. I have seen this issue raised on various forums such as stackoverflow here and figured I wou

[PATCH] D37436: Initial implementation of C attributes (WG14 N2137)

2017-09-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D37436#871117, @aaron.ballman wrote: > Updated based on review feedback. > > - Rename CAttributes to DoubleSquareBracketAttributes > - Added Objective-C test cases to demonstrate no regressed behavior (based on > a use-case pointed out d

[PATCH] D29660: [OpenMP] Add flag for overwriting default PTX version for OpenMP targets

2017-09-26 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea reopened this revision. gtbercea added a comment. This revision is now accepted and ready to land. Open Repository: rL LLVM https://reviews.llvm.org/D29660 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D38171: Implement clang-tidy check aliases.

2017-09-26 Thread András Leitereg via Phabricator via cfe-commits
leanil added a comment. In https://reviews.llvm.org/D38171#880021, @xazax.hun wrote: > In https://reviews.llvm.org/D38171#878808, @alexfh wrote: > > > András, that's definitely an interesting idea. However, it might be > > interesting to explore a more principled approach: > > > > 1. Make `clang

[PATCH] D38290: Add a ld64.lld alias for the MACHO LLD target

2017-09-26 Thread Martell Malone via Phabricator via cfe-commits
martell created this revision. Herald added a subscriber: mgorny. Currently when we do `-fuse-ld=lld` for apple targets this invokes the gnu frontend because of the `ld.lld` alias This creates a new alias for ld64 as `ld64.lld` to avoid this. Repository: rL LLVM https://reviews.llvm.org/D382

[PATCH] D38171: Implement clang-tidy check aliases.

2017-09-26 Thread András Leitereg via Phabricator via cfe-commits
leanil updated this revision to Diff 116694. leanil added a comment. Add more tests and minor fixes. https://reviews.llvm.org/D38171 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h clang-tidy/ClangTidyModule.h clang-t

[PATCH] D38191: [NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.

2017-09-26 Thread Artem Belevich via Phabricator via cfe-commits
tra closed this revision. tra added a comment. Landed with fix in r314223. https://reviews.llvm.org/D38191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38208: Add support for remembering origins to ExternalASTMerger

2017-09-26 Thread Sean Callanan via Phabricator via cfe-commits
spyffe updated this revision to Diff 116680. spyffe added a comment. Updates and small refactors requested by Bruno. Repository: rL LLVM https://reviews.llvm.org/D38208 Files: include/clang/AST/ExternalASTMerger.h lib/AST/ExternalASTMerger.cpp lib/Sema/SemaType.cpp test/Import/extern

[PATCH] D37023: [analyzer] Fix bugreporter::getDerefExpr() again.

2017-09-26 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 116673. NoQ added a comment. Add no-crash test cases from https://bugs.llvm.org/show_bug.cgi?id=34373 and https://bugs.llvm.org/show_bug.cgi?id=34731 . https://reviews.llvm.org/D37023 Files: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp test/Analysis/nul

[PATCH] D38191: [NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.

2017-09-26 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 116674. tra added a comment. Added missing return. Tests pass now. https://reviews.llvm.org/D38191 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Headers/__clang_cuda_intrinsics.h clang/test/CodeGen/builtins

[PATCH] D38040: [OpenMP] Add an additional test for D34888

2017-09-26 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 116671. gtbercea added a comment. Add nocudalib flag. https://reviews.llvm.org/D38040 Files: test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp === --- test/OpenM

[PATCH] D38040: [OpenMP] Add an additional test for D34888

2017-09-26 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea reopened this revision. gtbercea added a comment. This revision is now accepted and ready to land. Open https://reviews.llvm.org/D38040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D38040: [OpenMP] Add an additional test for D34888

2017-09-26 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D38226: [XRay][Driver] Do not link in XRay runtime in shared libs

2017-09-26 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris closed this revision. dberris added a comment. Already landed; manually closing. https://reviews.llvm.org/D38226 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38040: [OpenMP] Add an additional test for D34888

2017-09-26 Thread Gheorghe-Teodor Bercea via Phabricator via cfe-commits
gtbercea updated this revision to Diff 116664. gtbercea added a comment. Fix test. https://reviews.llvm.org/D38040 Files: test/OpenMP/target_map_codegen.cpp Index: test/OpenMP/target_map_codegen.cpp === --- test/OpenMP/target_m

[PATCH] D38179: [clang-tidy] Handle unions in modernize-use-equals-default check

2017-09-26 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons added inline comments. Comment at: clang-tidy/modernize/UseEqualsDefaultCheck.cpp:117 + const CXXMethodDecl *Operator) { + const auto *Record = Operator->getParent(); + aaron.ballman wrote: > Please don

[PATCH] D37695: [clang-format] Break non-trailing comments, try 2

2017-09-26 Thread Daniel Jasper via Phabricator via cfe-commits
djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.h:270 + // \c breakProtrudingToken. + bool LastBlockCommentWasBroken : 1; + We should be *very* careful when adding stuff to ParenState as every extra bit of data and every extra compar

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

2017-09-26 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware updated this revision to Diff 116662. baloghadamsoftware added a comment. If both sides have concrete integers, they must be in range [min/4..max/4], if only one, it must be in range [min/2..max/2]. https://reviews.llvm.org/D35109 Files: lib/StaticAnalyzer/Core/SimpleSValB

[PATCH] D38243: [clang-format] Add ext/ to google include categories

2017-09-26 Thread Daniel Jasper via Phabricator via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. https://reviews.llvm.org/D38243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D38277: [compiler-rt}[CMake] Fix configuration on PowerPC with sanitizers

2017-09-26 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld created this revision. Herald added subscribers: mgorny, dberris, nemanjai. TEST_BIG_ENDIAN() performs compile tests that will fail with -nodefaultlibs when building under LLVM_USE_SANITIZER. https://reviews.llvm.org/D38277 Files: cmake/base-config-ix.cmake Index: cmake/base-config

[PATCH] D35743: [clang-format] Adjust space around &/&& of structured bindings

2017-09-26 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Thanks for the changes. LGTM. https://reviews.llvm.org/D35743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D38250: [libunwind] Implement the Get/SetTopOfFunctionStack functions via a __thread TLS variable

2017-09-26 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In https://reviews.llvm.org/D38250#880871, @compnerd wrote: > I have a complete implementation for this which is known to work on Windows > at least. Patches for libunwind, or standalone? In any case, please do share if you think it's relevant. > The only thing that

[PATCH] D37904: [clang-format] Fix FixNamespaceComments when BraceWrapping AfterNamespace is true.

2017-09-26 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added a comment. Any thoughts on this? https://reviews.llvm.org/D37904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38247: [libunwind] Correct data types in the _Unwind_FunctionContext struct

2017-09-26 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo closed this revision. mstorsjo added a comment. Committed in SVN r314196. https://reviews.llvm.org/D38247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38249: [libunwind] Skip building unused parts when targeting SJLJ

2017-09-26 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo closed this revision. mstorsjo marked an inline comment as done. mstorsjo added a comment. Committed in SVN r314197. https://reviews.llvm.org/D38249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D37681: [refactor] Simplify the interface and remove some template magic

2017-09-26 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. @klimek Have you got a chance to take a look? Repository: rL LLVM https://reviews.llvm.org/D37681 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D37976: [docs][refactor] add refactoring engine design documentation

2017-09-26 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lgtm. Thanks for the documentation! Now we just need to try to keep it up-to-date ;) Comment at: docs/RefactoringEngine.rst:33 +operations (rules). These rules are grouped u

[PATCH] D38250: [libunwind] Implement the Get/SetTopOfFunctionStack functions via a __thread TLS variable

2017-09-26 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. I have a complete implementation for this which is known to work on Windows at least. The only thing that `__thread` requires is a working linker (which does not include binutil

[PATCH] D38249: [libunwind] Skip building unused parts when targeting SJLJ

2017-09-26 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: src/libunwind.cpp:27 +#ifndef __USING_SJLJ_EXCEPTIONS__ #include "AddressSpace.hpp" I would prefer that you used: #if !defined(__

[PATCH] D38191: [NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.

2017-09-26 Thread Artem Belevich via Phabricator via cfe-commits
tra reopened this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: llvm/trunk/lib/Target/NVPTX/NVPTXISelDAGToDAG.cpp:716 case Intrinsic::nvvm_texsurf_handle_internal: SelectTexSurfHandle(N); + case Intrinsic::nvvm_match_al

[PATCH] D38270: [clang] Add getUnsignedPointerDiffType method

2017-09-26 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap updated this revision to Diff 116635. alexshap added a comment. fix typo Repository: rL LLVM https://reviews.llvm.org/D38270 Files: include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/ASTContext.cpp Index: lib/AST/ASTContext.cpp ==

[PATCH] D38226: [XRay][Driver] Do not link in XRay runtime in shared libs

2017-09-26 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris updated this revision to Diff 116637. dberris added a comment. Herald added a subscriber: srhines. - fixup: use supported target list in test from clang implementation https://reviews.llvm.org/D38226 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/XRay/lit.local.cfg test/Driver/X

[PATCH] D38270: [clang] Add getUnsignedPointerDiffType method

2017-09-26 Thread Alexander Shaposhnikov via Phabricator via cfe-commits
alexshap created this revision. C11 standard refers to the unsigned counterpart of the type ptrdiff_t in the paragraph 7.19.6 where it defines the format specifier %tu. In Clang (in PrintfFormatString.cpp, lines 508-510) there is a FIXME for this case, in particular, right now Clang doesn't diag

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

2017-09-26 Thread Hal Finkel via Phabricator via cfe-commits
hfinkel added a comment. You seem to be only changing the behavior for the "separatable" fields, but I suspect you want to change the behavior for the others too. The bitfield would be decomposed into shards, separated by the naturally-sized-and-aligned fields. Each access only loads its shard.

[PATCH] D38226: [XRay][Driver] Do not link in XRay runtime in shared libs

2017-09-26 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris updated this revision to Diff 116631. dberris added a comment. - fixup: limit tests to run on supported platforms and oses https://reviews.llvm.org/D38226 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/XRay/lit.local.cfg test/Driver/XRay/xray-shared-noxray.cpp Index: test/Driv

r314246 - Fix uninitialized member found by msan build bot.

2017-09-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 26 14:33:43 2017 New Revision: 314246 URL: http://llvm.org/viewvc/llvm-project?rev=314246&view=rev Log: Fix uninitialized member found by msan build bot. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL: http://llvm

r314241 - Sema: rename SemaBuiltinVAStart to SemaBuiltinVAStartMicrosoft

2017-09-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 26 13:12:04 2017 New Revision: 314241 URL: http://llvm.org/viewvc/llvm-project?rev=314241&view=rev Log: Sema: rename SemaBuiltinVAStart to SemaBuiltinVAStartMicrosoft This function is used to perform semantic analysis on Microsoft style `__va_start`. Rename it to m

RE: r314235 - Allow IUnknown/IInterface types to come from extern C++

2017-09-26 Thread Keane, Erich via cfe-commits
Ah! Sorry, I didn't realize that isExternCXXContext actually searched the entire search-set! Followup patch coming Thanks for the heads up! -Original Message- From: Friedman, Eli [mailto:efrie...@codeaurora.org] Sent: Tuesday, September 26, 2017 12:06 PM To: Keane, Erich ; cfe-commits@

r314236 - Basic: support Preserve{Most,All} CC on Windows

2017-09-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 26 12:26:01 2017 New Revision: 314236 URL: http://llvm.org/viewvc/llvm-project?rev=314236&view=rev Log: Basic: support Preserve{Most,All} CC on Windows Add support for the `preserve_mostcc` and `preserve_allcc` on Windows x86_64 and AArch64. This is used by Swift.

Re: r314235 - Allow IUnknown/IInterface types to come from extern C++

2017-09-26 Thread Friedman, Eli via cfe-commits
On 9/26/2017 11:55 AM, Erich Keane via cfe-commits wrote: Author: erichkeane Date: Tue Sep 26 11:55:16 2017 New Revision: 314235 URL: http://llvm.org/viewvc/llvm-project?rev=314235&view=rev Log: Allow IUnknown/IInterface types to come from extern C++ It was brought up in response to my last imp

r314235 - Allow IUnknown/IInterface types to come from extern C++

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 11:55:16 2017 New Revision: 314235 URL: http://llvm.org/viewvc/llvm-project?rev=314235&view=rev Log: Allow IUnknown/IInterface types to come from extern C++ It was brought up in response to my last implementation for this struct-as-interface features that at l

Re: r314226 - Sema: Windows/ARM __va_start is not const correct

2017-09-26 Thread Saleem Abdulrasool via cfe-commits
On Tue, Sep 26, 2017 at 11:10 AM, David Majnemer wrote: > Shouldn't you only loosen the check for things targeting the Windows SDK? > GNU platforms shouldn't need this. > That code path only actually happens for MS mode. `__va_start` is marked as `ALL_MS_LANGUAGES`. I suppoes that it would be

r314232 - Delete trailing whitespace.

2017-09-26 Thread Nico Weber via cfe-commits
Author: nico Date: Tue Sep 26 11:38:56 2017 New Revision: 314232 URL: http://llvm.org/viewvc/llvm-project?rev=314232&view=rev Log: Delete trailing whitespace. Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp Modified: cfe/trunk/lib/Lex/PPMacroExpansion.cpp URL: http://llvm.org/viewvc/llvm-p

r314231 - Resolve a defect in C++17 copy omission.

2017-09-26 Thread Richard Smith via cfe-commits
Author: rsmith Date: Tue Sep 26 11:37:55 2017 New Revision: 314231 URL: http://llvm.org/viewvc/llvm-project?rev=314231&view=rev Log: Resolve a defect in C++17 copy omission. When selecting constructors for initializing an object of type T from a single expression of class type U, also consider co

r314229 - [Sema] Corrected the warn-on-throw-from-noexcept behavior to include nothrow

2017-09-26 Thread Erich Keane via cfe-commits
Author: erichkeane Date: Tue Sep 26 11:20:39 2017 New Revision: 314229 URL: http://llvm.org/viewvc/llvm-project?rev=314229&view=rev Log: [Sema] Corrected the warn-on-throw-from-noexcept behavior to include nothrow Discovered that 'nothrow' (which is supposed to be an alias for noexcept) was not w

Re: r314226 - Sema: Windows/ARM __va_start is not const correct

2017-09-26 Thread David Majnemer via cfe-commits
Shouldn't you only loosen the check for things targeting the Windows SDK? GNU platforms shouldn't need this. On Tue, Sep 26, 2017 at 10:44 AM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Tue Sep 26 10:44:10 2017 > New Revision: 314226 > > URL

r314226 - Sema: Windows/ARM __va_start is not const correct

2017-09-26 Thread Saleem Abdulrasool via cfe-commits
Author: compnerd Date: Tue Sep 26 10:44:10 2017 New Revision: 314226 URL: http://llvm.org/viewvc/llvm-project?rev=314226&view=rev Log: Sema: Windows/ARM __va_start is not const correct The `__va_start` intrinsic for Windows ARM does not account for const correctness when performing a check. All

r314223 - [NVPTX] added match.{any, all}.sync instructions, intrinsics & builtins.

2017-09-26 Thread Artem Belevich via cfe-commits
Author: tra Date: Tue Sep 26 10:07:23 2017 New Revision: 314223 URL: http://llvm.org/viewvc/llvm-project?rev=314223&view=rev Log: [NVPTX] added match.{any,all}.sync instructions, intrinsics & builtins. Differential Revision: https://reviews.llvm.org/D38191 Modified: cfe/trunk/include/clang/B

r314220 - [OPENMP] Fix handling of implicit mapping of array sections.

2017-09-26 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Sep 26 09:19:04 2017 New Revision: 314220 URL: http://llvm.org/viewvc/llvm-project?rev=314220&view=rev Log: [OPENMP] Fix handling of implicit mapping of array sections. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp cfe/trunk/test/OpenMP/target_map_messages.cpp Mod

Re: r309386 - Recommit r308327 3rd time: Add a warning for missing

2017-09-26 Thread Nico Weber via cfe-commits
Another bit of feedback: The Microsoft SDK has pragma adjustment headers that are used like so: #include // Define structs with alignment 1 here #include This warning fires on that. I haven't seen these headers in active use recently, but I remember seeing them quite a bit maybe 10 years ago. (

r314218 - [analyzer] Keep track of design discusions as part of analyzer documentation.

2017-09-26 Thread Artem Dergachev via cfe-commits
Author: dergachev Date: Tue Sep 26 08:49:53 2017 New Revision: 314218 URL: http://llvm.org/viewvc/llvm-project?rev=314218&view=rev Log: [analyzer] Keep track of design discusions as part of analyzer documentation. Create a directory to store discussions on potentially useful features that are not

r314213 - [mips] Accept but ignore -m(no-)branch-likely

2017-09-26 Thread Simon Dardis via cfe-commits
Author: sdardis Date: Tue Sep 26 08:01:21 2017 New Revision: 314213 URL: http://llvm.org/viewvc/llvm-project?rev=314213&view=rev Log: [mips] Accept but ignore -m(no-)branch-likely -mbranch-likely and -mno-branch-likely are used in some build systems for some MIPS targets. Accept these options but

r314211 - [clang-format] Add ext/ to google include categories

2017-09-26 Thread Krasimir Georgiev via cfe-commits
Author: krasimir Date: Tue Sep 26 07:58:29 2017 New Revision: 314211 URL: http://llvm.org/viewvc/llvm-project?rev=314211&view=rev Log: [clang-format] Add ext/ to google include categories Summary: This adds an ext/ header include category for google style. Reviewers: djasper Reviewed By: djaspe

r314209 - Fix TBAA information for reference accesses

2017-09-26 Thread Ivan A. Kosarev via cfe-commits
Author: kosarev Date: Tue Sep 26 07:22:48 2017 New Revision: 314209 URL: http://llvm.org/viewvc/llvm-project?rev=314209&view=rev Log: Fix TBAA information for reference accesses This patch fixes clang to decorate reference accesses as pointers and not as "omnipotent chars". Differential Revision

r314205 - [OPENMP] Generate implicit map|firstprivate clauses for target-based

2017-09-26 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Tue Sep 26 06:47:31 2017 New Revision: 314205 URL: http://llvm.org/viewvc/llvm-project?rev=314205&view=rev Log: [OPENMP] Generate implicit map|firstprivate clauses for target-based directives. If the variable is used in the target-based region but is not found in any private

[libunwind] r314197 - Skip building unused parts when targeting SJLJ

2017-09-26 Thread Martin Storsjo via cfe-commits
Author: mstorsjo Date: Tue Sep 26 01:07:26 2017 New Revision: 314197 URL: http://llvm.org/viewvc/llvm-project?rev=314197&view=rev Log: Skip building unused parts when targeting SJLJ When SJLJ exceptions are used, those functions aren't used. This fixes build failures on ARM with SJLJ enabled (e.

[libunwind] r314196 - Correct data types in the _Unwind_FunctionContext struct

2017-09-26 Thread Martin Storsjo via cfe-commits
Author: mstorsjo Date: Tue Sep 26 01:07:17 2017 New Revision: 314196 URL: http://llvm.org/viewvc/llvm-project?rev=314196&view=rev Log: Correct data types in the _Unwind_FunctionContext struct This makes it match the definition used within llvm and in libgcc, we previously got the wrong layout in