Re: ps4-buildslave1a down 08.23.2017

ps4-buildslave1a is back. On 08/23/2017 08:49 AM, Victor Leschuk wrote: > Hello all, ps4-buildslave1a is currently down. We are detecting the > cause and will fix it ASAP. I will inform when it is accessible again. > > Sorry for the inconvenience. > -- Best Regards, Victor Leschuk | Software E

ps4-buildslave1a down 08.23.2017

Hello all, ps4-buildslave1a is currently down. We are detecting the cause and will fix it ASAP. I will inform when it is accessible again. Sorry for the inconvenience. -- Best Regards, Victor Leschuk | Software Engineer |Access Softek ___ cfe-commits

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

I believe that it is merely a compile-time issue (warning), it doesn't prevent the use of compiler-rt on ARM as a libgcc replacement. I need to understand why my attempt to remove the `struct` modifier failed on one of the buildbots. On Tue, Aug 22, 2017 at 2:45 PM, Evgenii Stepanov wrote: > No

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

compnerd accepted this revision. compnerd added a comment. Would be nice to split up the PPC fixes into its own commit. https://reviews.llvm.org/D36555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

mgorny added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:223 + cpu_model.c + divxc3.c + fixxfdi.c saugustine wrote: > mgorny wrote: > > This and the following files have only: > > > > ``` > > #if !_ARCH_PPC > > ``` > > > > so I suppo

[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprComplex.cpp:163 +else + CGF.EmitLValue(ME->getBase()); +return *Constant; rjmccall wrote: > There's an EmitIgnoredExpr you could use. > > Also, I think it would be fine to add

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:03 PM, Xinliang David Li wrote: > > > On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator > wrote: >> >> chandlerc added a comment. >> >> I'm really not a fan of the degree of complexity and subtlety that this >> introduces into the frontend, all to allow p

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

majnemer added a comment. In https://reviews.llvm.org/D37042#849726, @majnemer wrote: > I'd expect this to be more limited. > > Something like, "if we have a BinaryOperator of + between a CStyleCastExpr of > NullToPointer and 'X', emit inttoptr(X)" Although maybe that is too strict... I guess

[PATCH] D36876: [IRGen] Evaluate constant static variables referenced through member expressions

rjmccall added inline comments. Comment at: lib/CodeGen/CGExprComplex.cpp:163 +else + CGF.EmitLValue(ME->getBase()); +return *Constant; There's an EmitIgnoredExpr you could use. Also, I think it would be fine to add a generic tryEmitMemb

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

majnemer added a comment. I'd expect this to be more limited. Something like, "if we have a BinaryOperator of + between a CStyleCastExpr of NullToPointer and 'X', emit inttoptr(X)" https://reviews.llvm.org/D37042 ___ cfe-commits mailing list cfe-c

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

rjmccall added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11846 // an address space. if (T.getAddressSpace() != 0) { // OpenCL allows function arguments declared to be an array of a type yaxunl wrote: > Anastasia wrote: > > yaxunl wrote: > > >

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:46 PM, Chandler Carruth wrote: > > > On Tue, Aug 22, 2017 at 7:18 PM Xinliang David Li via llvm-commits < > llvm-comm...@lists.llvm.org> wrote: > >> On Tue, Aug 22, 2017 at 7:10 PM, Chandler Carruth via llvm-commits < >> llvm-comm...@lists.llvm.org> wrote: >> >>> On Tue,

[PATCH] D36678: [OpenCL] Do not use vararg in emitted functions for enqueue_kernel

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:116 + // B32: store i32 4, i32* %[[TMP3]], align 4 + // B32: call i32 @__enqueue_kernel_vaargs(%opencl.queue_t{{.*}}* [[DEF_Q]], i32 [[FLAGS]], %st

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11846 // an address space. if (T.getAddressSpace() != 0) { // OpenCL allows function arguments declared to be an array of a type Anastasia wrote: >

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl updated this revision to Diff 112288. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added subscribers: nhaehnle, jholewinski. Add a flag to indicate whether address space qualifier is implicit and only print explicit address space in diagnostics. https://revi

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo

minseong.kim added a comment. I will test your patch with repo. Thanks for your time and efforts, @hintonda. https://reviews.llvm.org/D35533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:18 PM Xinliang David Li via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > On Tue, Aug 22, 2017 at 7:10 PM, Chandler Carruth via llvm-commits < > llvm-comm...@lists.llvm.org> wrote: > >> On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits < >> cfe-comm

r311519 - [ODRHash] Diagnose differing template parameters.

Author: rtrieu Date: Tue Aug 22 19:43:59 2017 New Revision: 311519 URL: http://llvm.org/viewvc/llvm-project?rev=311519&view=rev Log: [ODRHash] Diagnose differing template parameters. Modified: cfe/trunk/include/clang/Basic/DiagnosticSerializationKinds.td cfe/trunk/lib/AST/ODRHash.cpp

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On 08/22/2017 09:18 PM, Xinliang David Li via llvm-commits wrote: On Tue, Aug 22, 2017 at 7:10 PM, Chandler Carruth via llvm-commits mailto:llvm-comm...@lists.llvm.org>> wrote: On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits mailto:cfe-commits@lists.llvm.org>>

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:10 PM, Chandler Carruth via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator < >> revi...@re

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 7:03 PM Xinliang David Li via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator < > revi...@reviews.llvm.org> wrote: > >> chandlerc added a comment. >> >> I'm really not a fan of the degree of complexity and

Re: [PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

On Tue, Aug 22, 2017 at 6:37 PM, Chandler Carruth via Phabricator < revi...@reviews.llvm.org> wrote: > chandlerc added a comment. > > I'm really not a fan of the degree of complexity and subtlety that this > introduces into the frontend, all to allow particular backend optimizations. > > I feel li

Re: [libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

Ah I see. I think r309474 should fix our problem. Thanks for your quick response. > On Aug 22, 2017, at 6:28 PM, Shoaib Meenai wrote: > > The point of the extern template was to prevent that operator from being > defined in any other object files. The extern template wasn't taking effect > be

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

chandlerc added a comment. I'm really not a fan of the degree of complexity and subtlety that this introduces into the frontend, all to allow particular backend optimizations. I feel like this is Clang working around a fundamental deficiency in LLVM and we should instead find a way to fix this

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

wmi updated this revision to Diff 112271. wmi added a comment. Try another idea suggested by David. All the bitfields in a single run are still wrapped inside of a large integer according to CGBitFieldInfo. For the bitfields with legal integer types and aligned, change their access manner when

Re: [libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

The point of the extern template was to prevent that operator from being defined in any other object files. The extern template wasn't taking effect because of its placement in the file, but I fixed that in r309474. Does your issue get resolved with that second change in place? From: on behalf

[PATCH] D36914: Implement CFG construction for __try / __except / __leave.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good! Comment at: test/Sema/warn-unreachable-ms.c:42 + } +} rnk wrote: > Can we add a test to exercise that this builds the right CFG? > ``` > __try { > _

[PATCH] D36915: [Sema] Diagnose local variables and parameters captured by lambda and block expressions in a default argument

faisalv added a comment. I don't think this approach is entirely correct for at least the following reasons: 1. in the lambda case the machinery that diagnoses capture failures should be the machinery erroring on the lambda (when the parameter is odr-used) 2. in the unevaluated case, once you d

Re: [libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

This change makes it impossible to change the visibility of operator+ with -fvisibility=hidden, which is not desirable on Darwin. For example: $ cat test.cpp #include using namespace std; string foo1(string s) { return "abc" + s; } $ clang++ test.cpp -fvisibility=hidden -c; nm -m -a test.o

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF marked an inline comment as done. EricWF added a comment. In https://reviews.llvm.org/D37035#849574, @rsmith wrote: > I don't like the model of conditionally rebuilding the default initializer / > default argument if it contains one of these builtins; it seems more > heavy-handed than ne

r311516 - Update Clang fuzzers to use libFuzzer bundled with the toolchain.

Author: george.karpenkov Date: Tue Aug 22 17:42:22 2017 New Revision: 311516 URL: http://llvm.org/viewvc/llvm-project?rev=311516&view=rev Log: Update Clang fuzzers to use libFuzzer bundled with the toolchain. Differential Revision: https://reviews.llvm.org/D37043 Modified: cfe/trunk/tools/cl

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor added a comment. I'm not sure why the svn attributes got attached to the file I added. I'll remove them before committing. https://reviews.llvm.org/D37042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

rsmith added a comment. I don't like the model of conditionally rebuilding the default initializer / default argument if it contains one of these builtins; it seems more heavy-handed than necessary. I'm also not convinced that we need to store the computed value in the AST. As an alternative,

[PATCH] D37042: Teach clang to tolerate the 'p = nullptr + n' idiom used by glibc

andrew.w.kaylor created this revision. This patch adds a hack to clang's emitPointerArithmetic() function to get it to emit an inttoptr instruction rather than a GEP with a null base pointer when the 'p = nullptr + n' idiom is used to convert a pointer-sized integer to a pointer. This idiom is

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF updated this revision to Diff 112268. EricWF marked 4 inline comments as done. EricWF added a comment. - Address inline comments. - Fix calls to class call operators. https://reviews.llvm.org/D37035 Files: docs/LanguageExtensions.rst include/clang/AST/Decl.h include/clang/AST/Expr.

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

aprantl added a comment. Performance-wise the change is fine because it does the same amount of work, but I would prefer someone to audit the code to make sure that we aren't uniquing a node while we still want to make changes to it. Unfortunately testcases for these issues will involve impossi

r311514 - Remove LLVMFuzzer from list of bundled libraries for Fuchsia

Author: george.karpenkov Date: Tue Aug 22 17:09:33 2017 New Revision: 311514 URL: http://llvm.org/viewvc/llvm-project?rev=311514&view=rev Log: Remove LLVMFuzzer from list of bundled libraries for Fuchsia As of now, libFuzzer is located in compiler-rt and is bundled with Clang's toolchain by defau

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

rsmith added inline comments. Comment at: test/SemaCXX/source_location.cpp:10-35 +struct source_location { +private: + unsigned int __m_line = 0; + unsigned int __m_col = 0; + const char *__m_file = nullptr; + const char *__m_func = nullptr; +public: This see

[PATCH] D36914: Implement CFG construction for __try / __except / __leave.

thakis updated this revision to Diff 112261. thakis added a comment. add test from rnk https://reviews.llvm.org/D36914 Files: lib/Analysis/CFG.cpp test/Sema/warn-unreachable-ms.c Index: test/Sema/warn-unreachable-ms.c === ---

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

majnemer added inline comments. Comment at: include/clang/AST/Expr.h:3816 +/// __builtin_LINE(), __builtin_COLUMN(), __builtin_FUNCTION(), or +/// __BUILTIN_FILE() +class SourceLocExpr final : public Expr { __BUILTIN_FILE -> __builtin_FILE Comm

Re: [PATCH] D36914: Implement CFG construction for __try / __except / __leave.

On Tue, Aug 22, 2017 at 5:56 PM, Reid Kleckner via Phabricator via cfe-commits wrote: > rnk added a comment. > > Looks functionally correct > > > > > Comment at: test/Sema/warn-unreachable-ms.c:42 > + } > +} > > Can we add a test to exercise that this builds the

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson added a comment. I mentioned this in the PR but I should have restated it here, sorry... Wolfgang authored this patch. He is away for a month so I volunteered to post this, in case it was okay for resolving the PR as the crash is present in the 5.0 branch. I do know Wolfgang was not r

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

aprantl added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:157 + if (DebugInfo) +DebugInfo->replaceTemporaryNodes(); + Have you looked at what it would take to only finalize the nodes reachable via the function? Otherwise — have you audited that t

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

hfinkel added inline comments. Comment at: include/clang/AST/Expr.h:3814 +/// BuiltinSourceLocExpr - Represents a function call to one of +/// __builtin_LINE(), __builtin_COLUMN(), __builtin_FUNCTION(), or BuiltinSourceLocExpr -> SourceLocExpr ===

[PATCH] D37038: Replace temp MD nodes with unique/distinct before cloning

probinson created this revision. Make sure all temporary MD nodes have been replaced with uniqued or distinct nodes before we clone a function. Fixes PR33930. https://reviews.llvm.org/D37038 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebugInfo.h lib/CodeGen/CGVTables.cpp test/Co

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

EricWF created this revision. This patch implements the source location builtins `__builtin_LINE(), `__builtin_FUNCTION()`, `__builtin_FILE()` and `__builtin_COLUMN()`. These builtins are needed to implement [`std::experimental::source_location`](https://rawgit.com/cplusplus/fundamentals-ts/v2/

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

weimingz added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:483 +set(powerpc64le_SOURCES ${powerpc64_SOURCES}) + set(wasm32_SOURCES ${GENERIC_SOURCES}) why these files were not used before? should the change be in a separate patch? or up

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

weimingz added reviewers: rengolin, compnerd. weimingz added a comment. LGTM. Adding Renato and Saleem to approve. https://reviews.llvm.org/D36555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine updated this revision to Diff 112244. saugustine added a comment. Remove two files inadvertantly included in last patch. https://reviews.llvm.org/D36555 Files: compiler-rt/lib/builtins/CMakeLists.txt Index: compiler-rt/lib/builtins/CMakeLists.txt ==

[PATCH] D36336: [X86] Add support for __builtin_cpu_init

craig.topper added a comment. Ping https://reviews.llvm.org/D36336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r311397 - [Driver][Darwin] Do not pass -munwind-table if -fno-excpetions is

Okay, r311505. On Tue, Aug 22, 2017 at 12:02 PM, Akira Hatanaka wrote: > Hans, can this be merged to 5.0 too? This is a follow-up to r310006. > > Thanks. > >> On Aug 21, 2017, at 3:46 PM, Akira Hatanaka via cfe-commits >> wrote: >> >> Author: ahatanak >> Date: Mon Aug 21 15:46:46 2017 >> New Re

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine added a reviewer: weimingz. saugustine added inline comments. Comment at: compiler-rt/lib/builtins/CMakeLists.txt:223 + cpu_model.c + divxc3.c + fixxfdi.c mgorny wrote: > This and the following files have only: > > ``` > #if !_ARCH_PPC > ``` > > s

[PATCH] D36555: Move x86-specific sources to x86-specific source lists.

saugustine updated this revision to Diff 112242. saugustine added a comment. Thanks for the various comments. Please take another look. https://reviews.llvm.org/D36555 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/cmake/builtin-config-ix.cmake compiler-rt/lib/builtins

[PATCH] D36764: The following functions and tests work fine for powerpc64, so enable them.

saugustine added a comment. OK. I understand how these should work now. As they are 80-bit specific, I am going to abandon this change and add them to my other patch which moves 80-bit specific floats and tests to x86-specific lists. https://reviews.llvm.org/D36764

Re: r311487 - Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""""

Great. Thanks! -- adrian > On Aug 22, 2017, at 3:11 PM, Dan Albert wrote: > > r311488 was submitted moments later and should fix this (one of the other > buildbots caught this really quickly). > > On Tue, Aug 22, 2017 at 3:09 PM, Adrian Prantl > wrote: > > > On Aug

Re: r311487 - Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""""

r311488 was submitted moments later and should fix this (one of the other buildbots caught this really quickly). On Tue, Aug 22, 2017 at 3:09 PM, Adrian Prantl wrote: > > > On Aug 22, 2017, at 2:05 PM, Dan Albert via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > > Author: danalbert >

Re: r311487 - Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""""

> On Aug 22, 2017, at 2:05 PM, Dan Albert via cfe-commits > wrote: > > Author: danalbert > Date: Tue Aug 22 14:05:01 2017 > New Revision: 311487 > > URL: http://llvm.org/viewvc/llvm-project?rev=311487&view=rev > Log: > Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for > non-Li

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:387 +// hash. This causes second-level indents onward to have an extra space +// after the tabs. We set the state to column 0 to avoid this misalignment. +if (Style.UseTab != FormatStyle::

Re: r311391 - [Driver] Recognize DevDiv internal builds of MSVC, with a different directory structure.

Merged to 5.0 in r311500. On Mon, Aug 21, 2017 at 3:19 PM, Stephan T. Lavavej via cfe-commits wrote: > Author: stl_msft > Date: Mon Aug 21 15:19:33 2017 > New Revision: 311391 > > URL: http://llvm.org/viewvc/llvm-project?rev=311391&view=rev > Log: > [Driver] Recognize DevDiv internal builds of MS

[PATCH] D36914: Implement CFG construction for __try / __except / __leave.

rnk added a comment. Looks functionally correct Comment at: test/Sema/warn-unreachable-ms.c:42 + } +} Can we add a test to exercise that this builds the right CFG? ``` __try { __try { f(); } __except(1) { __leave; // should exit outer try } __l

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

No. I don't have a easy way of reproducing this. On Tue, Aug 22, 2017 at 11:10 AM, Hans Wennborg wrote: > Is there a bug filed? Since this was merged to 5.0.0, I'd like to know > if we broke something and if that is something that needs to be fixed. > > On Tue, Aug 22, 2017 at 10:46 AM, Evgenii S

Re: [PATCH] D36914: Implement CFG construction for __try / __except / __leave.

rnk: ping :-) On Mon, Aug 21, 2017 at 1:43 PM, Nico Weber via Phabricator via cfe-commits wrote: > thakis added inline comments. > > > > Comment at: lib/Analysis/CFG.cpp:448 > +BuildOpts(buildOpts), switchExclusivelyCovered(false), > +switchCond(nullptr), cachedE

r311488 - Degeneralize more tests.

Author: danalbert Date: Tue Aug 22 14:16:22 2017 New Revision: 311488 URL: http://llvm.org/viewvc/llvm-project?rev=311488&view=rev Log: Degeneralize more tests. As before, not every platform supports LTO. Make sure the platform we're targeting is one that supports it (regardless of the *host* pla

[PATCH] D37024: [libcxx] [test] Cleanup nullopt_t tests

CaseyCarter updated this revision to Diff 112224. CaseyCarter added a comment. Don't unnecessarily fully qualify `std::nullopt`. https://reviews.llvm.org/D37024 Files: test/std/utilities/optional/optional.nullopt/not_brace_initializable.fail.cpp test/std/utilities/optional/optional.nullopt/

[PATCH] D37024: [libcxx] [test] Cleanup nullopt_t tests

STL_MSFT added a comment. Otherwise, looks cromulent to me. Comment at: test/std/utilities/optional/optional.nullopt/nullopt_t.pass.cpp:38 -static_assert(test(nullopt) == 3, ""); +static_assert(std::is_same_v); +static_assert(test()); You're sayin

[PATCH] D37025: [analyzer] Support more pointer arithmetic in bugreporter::getDerefExpr().

NoQ added inline comments. Comment at: test/Analysis/nullptr.cpp:54 void zoo1() { - char **p = 0; + char **p = 0; // expected-note{{'p' initialized to a null pointer value}} delete *(p + 0); // expected-warning{{Dereference of null pointer}} This note has b

[PATCH] D37025: [analyzer] Support more pointer arithmetic in bugreporter::getDerefExpr().

NoQ created this revision. Herald added a subscriber: eraman. This patch adds support for a few more pointer arithmetic cases. For instance, when `p` is a null pointer, it would be possible to track that expressions like `*(++p) = 5` and `*(p + 2) = 5` are null pointer dereferences that are base

r311487 - Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""""

Author: danalbert Date: Tue Aug 22 14:05:01 2017 New Revision: 311487 URL: http://llvm.org/viewvc/llvm-project?rev=311487&view=rev Log: Revert "Revert "Revert "Revert "Fix LLVMgold plugin name/path for non-Linux. With tests fixed for Windows style paths now that they are going through path ca

[PATCH] D37024: [libcxx] [test] Cleanup nullopt_t tests

CaseyCarter created this revision. - Update specification text from N4387 - Delete `not_brace_initializable.fail.cpp`: it's redundant with `nullopt_t.fail.cpp` - `is_empty` implies `is_class` - `is_literal` is deprecated; directly verify that we can create a `nullopt_t` in a `constexpr` conte

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

lebedev.ri added a comment. Please add the following test: (and make sure that it does the right thing :)) bool f_with_preproc_condition() { auto test = 42; assert(test == 42); return test; } I.e. if `-DNDEBUG` is present, variable is not needed, but if `-DNDEBUG` is *NOT* prese

[PATCH] D37023: [analyzer] Fix bugreporter::getDerefExpr() again.

NoQ created this revision. This patch continues work that was started in https://reviews.llvm.org/D32291. Our `bugreporter::getDerefExpr()` API tries to find out what has been dereferenced. For example, if we have an lvalue expression `x->y.z` which causes a null dereference when dereferenced,

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `readability-useless-intermediate-var + `_ check Please place new checks in alphabetica

[PATCH] D36492: [time-report] Add preprocessor timer

MatzeB added inline comments. Comment at: lib/Lex/Preprocessor.cpp:746 void Preprocessor::Lex(Token &Result) { + llvm::TimeRegion(PPOpts->getTimer()); + modocache wrote: > erik.pilkington wrote: > > Doesn't this just start a timer and immediately end the timer?

[PATCH] D36951: [OpenCL][5.0.0 Release] Release notes for OpenCL in Clang

Anastasia closed this revision. Anastasia added a comment. Committed to release_50@311485 https://reviews.llvm.org/D36951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36503: [libcxx] [test] Update for C++17 feature removals.

STL_MSFT added a comment. It's been two weeks - if there are no objections, I'd like to commit this soon. Thanks! https://reviews.llvm.org/D36503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: r311397 - [Driver][Darwin] Do not pass -munwind-table if -fno-excpetions is

Hans, can this be merged to 5.0 too? This is a follow-up to r310006. Thanks. > On Aug 21, 2017, at 3:46 PM, Akira Hatanaka via cfe-commits > wrote: > > Author: ahatanak > Date: Mon Aug 21 15:46:46 2017 > New Revision: 311397 > > URL: http://llvm.org/viewvc/llvm-project?rev=311397&view=rev > L

[PATCH] D35385: [Driver] Darwin: Link in the profile runtime archive first

ributzka accepted this revision. ributzka added a comment. This revision is now accepted and ready to land. Nice cleanup with the RuntimeLinkOptions enum. LGTM https://reviews.llvm.org/D35385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D35955: clang-format: Add preprocessor directive indentation

krasimir added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:383 + State.Line->Type == LT_ImportStatement) && + Current.Previous->is(tok::hash) && State.FirstIndent > 0) { +Spaces += State.FirstIndent; You can replace `Current.Pr

[PATCH] D35271: Fix printing policy for AST context loaded from file

vsk added a comment. Thanks for adding the test! This is looking good. Comment at: unittests/Frontend/ASTUnitTest.cpp:32 +llvm::SmallString<256> Dir; +ASSERT_FALSE(llvm::sys::fs::createUniqueDirectory("astunit-test", Dir)); +TestDir = Dir.str(); If

[PATCH] D36678: [OpenCL] Do not use vararg in emitted functions for enqueue_kernel

Anastasia added inline comments. Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:116 + // B32: store i32 4, i32* %[[TMP3]], align 4 + // B32: call i32 @__enqueue_kernel_vaargs(%opencl.queue_t{{.*}}* [[DEF_Q]], i32 [[FLAGS]], %struct.ndrange_t* [[NDR]]{{(.[0-9]+)?}},

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

Is there a bug filed? Since this was merged to 5.0.0, I'd like to know if we broke something and if that is something that needs to be fixed. On Tue, Aug 22, 2017 at 10:46 AM, Evgenii Stepanov wrote: > As I understand, using compiler-rt as libgcc replacement on ARM is > currently broken because o

[PATCH] D36853: [Parser] Correct initalizer typos before lambda capture type is deduced.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311480: [Parser] Correct initalizer typos before lambda capture type is deduced. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D36853?vs=111716&id=112201#toc Repository: rL

r311480 - [Parser] Correct initalizer typos before lambda capture type is deduced.

Author: vsapsai Date: Tue Aug 22 10:55:19 2017 New Revision: 311480 URL: http://llvm.org/viewvc/llvm-project?rev=311480&view=rev Log: [Parser] Correct initalizer typos before lambda capture type is deduced. This is the same assertion as in https://reviews.llvm.org/D25206 that is triggered when Re

r311479 - [OPENMP] Fix for PR34014: OpenMP 4.5: Target construct in static method

Author: abataev Date: Tue Aug 22 10:54:52 2017 New Revision: 311479 URL: http://llvm.org/viewvc/llvm-project?rev=311479&view=rev Log: [OPENMP] Fix for PR34014: OpenMP 4.5: Target construct in static method of class fails to map class static variable. If the global variable is captured and it has

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

As I understand, using compiler-rt as libgcc replacement on ARM is currently broken because of this change, but I have not looked since my last message. On Mon, Aug 21, 2017 at 4:56 PM, Hans Wennborg wrote: > Is there something we need for 5.0.0 here? > > On Sat, Aug 12, 2017 at 9:58 PM, Saleem A

[PATCH] D36989: [clang-diff] Refactor stop-after command-line flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL311476: [clang-diff] Refactor stop-after command-line flag (authored by jgravelle). Repository: rL LLVM https://reviews.llvm.org/D36989 Files: cfe/trunk/test/Tooling/clang-diff-topdown.cpp cfe/tru

r311476 - [clang-diff] Refactor stop-after command-line flag

Author: jgravelle Date: Tue Aug 22 10:42:44 2017 New Revision: 311476 URL: http://llvm.org/viewvc/llvm-project?rev=311476&view=rev Log: [clang-diff] Refactor stop-after command-line flag Summary: Rename stop-after to stop-diff-after. When building LLVM with -DLLVM_BUILD_LLVM_DYLIB=ON, stop-after

[PATCH] D36969: [Basic] Add a DiagnosticError llvm::ErrorInfo subclass

vsk added a comment. Nice! I'd like to get your thoughts on two candidate ergonomic changes: Comment at: unittests/Basic/DiagnosticTest.cpp:81 + llvm::Expected> Value = + llvm::make_error(PartialDiagnosticAt( + SourceLocation(), PartialDiagnostic(diag::err_cannot

r311474 - Test commit access.

Author: vsapsai Date: Tue Aug 22 10:39:25 2017 New Revision: 311474 URL: http://llvm.org/viewvc/llvm-project?rev=311474&view=rev Log: Test commit access. Modified: cfe/trunk/include/clang/Analysis/CloneDetection.h Modified: cfe/trunk/include/clang/Analysis/CloneDetection.h URL: http://llvm.

[PATCH] D35955: clang-format: Add preprocessor directive indentation

djasper added a comment. Krasimir: Can you actually give this a round of review? I will also try to do so tomorrow. https://reviews.llvm.org/D35955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D34275: [analyzer] Re-implemente current virtual calls checker in a path-sensitive way

wangxindsb updated this revision to Diff 112196. wangxindsb added a comment. - Highlight pure virtual even in non-pure-only mode; - Add change to the header. https://reviews.llvm.org/D34275 Files: lib/StaticAnalyzer/Checkers/VirtualCallChecker.cpp test/Analysis/virtualcall.cpp test/Analys

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman updated this revision to Diff 112195. arphaman marked 7 inline comments as done. arphaman added a comment. - Split the header - Remove DiagnosticOr in favour of Expected that will use a DiagnosticError that was proposed in the other patch. - Address the other review comments Repository

[PATCH] D36075: [refactor] Initial support for refactoring action rules

arphaman added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringOperationController.h:19 + +/// Encapsulates all of the possible state that an individual refactoring +/// operation might have. Controls the process of initiation of refactoring ---

[PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

alexanderkyte added a comment. This change is causing mono's native interop with C code compiled from clang to break. After some investigation, we're tracked bitcode differences between tests that fail versus not. When we upgrade the compiler to Xcode 8.3, we see that code generated to call fun

[PATCH] D36989: [clang-diff] Refactor stop-after command-line flag

johannes added a comment. In https://reviews.llvm.org/D36989#848835, @jgravelle-google wrote: > If you have more stop-after options it'd probably be simpler to leave it as > one field. I'll just rename it to "stop-diff-after" to avoid the name > collision. Ok, you can go ahead. Or, if I shoul

[PATCH] D36989: [clang-diff] Refactor stop-after command-line flag

jgravelle-google updated this revision to Diff 112193. jgravelle-google added a comment. - Undo refactor, just change name https://reviews.llvm.org/D36989 Files: test/Tooling/clang-diff-topdown.cpp tools/clang-diff/ClangDiff.cpp Index: tools/clang-diff/ClangDiff.cpp ==

[PATCH] D36989: [clang-diff] Refactor stop-after command-line flag

jgravelle-google added a comment. If you have more stop-after options it'd probably be simpler to leave it as one field. I'll just rename it to "stop-diff-after" to avoid the name collision. https://reviews.llvm.org/D36989 ___ cfe-commits mailing l

[PATCH] D36848: [CodeGen] Use reentrant methods to time IR gen

modocache updated this revision to Diff 112187. modocache retitled this revision from "[CodeGen] Use RefCntTimer to time IR generation" to "[CodeGen] Use reentrant methods to time IR gen". modocache edited the summary of this revision. modocache added a comment. Use `startReentrantTimer` and `sto

[PATCH] D37014: [clang-tidy] Add a checker to remove useless intermediate variables before return statements with comparisons

JonasToth added a comment. Hi :) I added my thoughts for the check. Many variables in your code could be `const`, i didn't mention all cases. Comment at: clang-tidy/readability/UselessIntermediateVarCheck.cpp:24 + + auto directDeclRefExprLHS1 = +// We match a direct decl

Re: r311443 - [ObjC] Check written attributes only when synthesizing ambiguous property

Merged in r311464. Thanks! On Tue, Aug 22, 2017 at 3:42 AM, Alex L wrote: > Hi Hans, > > Can you please merge this into LLVM 5? It fixes a rather serious Objective-C > bug that I introduced just a couple of weeks before the branch. > > Cheers, > Alex > > > On 22 August 2017 at 11:38, Alex Lorenz

  1   2   >