On Tue, Aug 22, 2017 at 5:56 PM, Reid Kleckner via Phabricator via
cfe-commits <cfe-commits@lists.llvm.org> wrote:
> rnk added a comment.
>
> Looks functionally correct
>
>
>
> ================
> Comment at: test/Sema/warn-unreachable-ms.c:42
> + }
> +}
> ----------------
> Can we add a test to exercise that this builds the right CFG?
> ```
> __try {
> __try {
> f();
> } __except(1) {
> __leave; // should exit outer try
> }
> __leave;
> f(); // expected-warning{{never be executed}}
> } __except(1) {
> }
> ```
>
Sure. Did you intentionally put two __leaves in there, or do you only want
the one in the inner __except?
>
>
> https://reviews.llvm.org/D36914
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits@lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
