[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

djasper added a comment. I don't want to move forward with this patch. But adding Manuel as another reviewer to sanity-check. Comment at: include/clang/Format/Format.h:167 +/// \endcode +OAS_StrictAlign, + }; The name is not intuitive. I don't think t

[PATCH] D34395: clang-format: add options to merge empty record body

djasper added a comment. Do you know of a style guide that would actually want to handle class, structs and unions differently? In most of Clang, they are handled as "records" and fundamentally, they are so alike that I'd hope that people always want the same behavior for all of them. https:/

[PATCH] D34238: clang-format: Do not binpack initialization lists

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Thank you! https://reviews.llvm.org/D34238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D34607: [Bash-autocompletion] Check clang version in Bash

teemperor accepted this revision. teemperor added a comment. Works as intended, good job! https://reviews.llvm.org/D34607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r306270 - Testcase missed from r306075.

Author: rsmith Date: Sun Jun 25 21:41:22 2017 New Revision: 306270 URL: http://llvm.org/viewvc/llvm-project?rev=306270&view=rev Log: Testcase missed from r306075. Added: cfe/trunk/test/Modules/interface-visibility.m Added: cfe/trunk/test/Modules/interface-visibility.m URL: http://llvm.org/v

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

majnemer added inline comments. Comment at: lib/AST/MicrosoftMangle.cpp:993-994 + Out << "YAX"; + // struct __block_literal * + Out << "PA"; + mangleArtificalTagType(TTK_Struct, compnerd wrote: > majnemer wrote: > > Shouldn't we also mangle an

[libcxx] r306269 - Updated for the Toronto meeting

Author: marshall Date: Sun Jun 25 21:25:15 2017 New Revision: 306269 URL: http://llvm.org/viewvc/llvm-project?rev=306269&view=rev Log: Updated for the Toronto meeting Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org/viewv

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd updated this revision to Diff 103887. compnerd added a comment. Some more comments, add test case. Repository: rL LLVM https://reviews.llvm.org/D34523 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/msabi-blocks.cpp Index: test/CodeGenCXX/msabi-blocks.cpp ===

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd added a comment. I can add the nested/nested classes. What were other nested concepts you thinking of? Comment at: lib/AST/MicrosoftMangle.cpp:980-981 + unsigned Discriminator = BD->getBlockManglingNumber(); + if (!Discriminator) +Discriminator = Co

r306266 - clang-format - Also reference the list of style option of clang-format in Libformat

Author: sylvestre Date: Sun Jun 25 20:19:05 2017 New Revision: 306266 URL: http://llvm.org/viewvc/llvm-project?rev=306266&view=rev Log: clang-format - Also reference the list of style option of clang-format in Libformat Modified: cfe/trunk/docs/LibFormat.rst Modified: cfe/trunk/docs/LibForm

[clang-tools-extra] r306263 - Remove the script dump_check_docs.py. It was a one-shot migration script.

Author: sylvestre Date: Sun Jun 25 19:56:57 2017 New Revision: 306263 URL: http://llvm.org/viewvc/llvm-project?rev=306263&view=rev Log: Remove the script dump_check_docs.py. It was a one-shot migration script. Sign off from Alexander Kornienko by email Removed: clang-tools-extra/trunk/docs/

r306261 - Fix a typo

Author: sylvestre Date: Sun Jun 25 19:45:08 2017 New Revision: 306261 URL: http://llvm.org/viewvc/llvm-project?rev=306261&view=rev Log: Fix a typo Modified: cfe/trunk/docs/MemorySanitizer.rst Modified: cfe/trunk/docs/MemorySanitizer.rst URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/doc

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc updated this revision to Diff 103885. chandlerc marked an inline comment as done. chandlerc added a comment. Update based on review comments. https://reviews.llvm.org/D33932 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp Index:

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc requested review of this revision. chandlerc added a comment. Tried to address the test comment -- let me know if something else was intended. https://reviews.llvm.org/D33932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D34607: [Bash-autocompletion] Check clang version in Bash

ruiu accepted this revision. ruiu added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D34607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

ahatanak updated this revision to Diff 103883. ahatanak added a comment. Fix line number and remove #else. https://reviews.llvm.org/D34556 Files: include/__config include/new test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_deployment.fail.cpp Index: test/

[PATCH] D34607: [Bash-autocompletion] Check clang version in Bash

yamaguchi updated this revision to Diff 103884. yamaguchi added a comment. Update patch. https://reviews.llvm.org/D34607 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh === --- clang/utils/bash-a

[PATCH] D34607: [Bash-autocompletion] Check clang version in Bash

ruiu added inline comments. Comment at: clang/utils/bash-autocomplete.sh:28 + flags=$( clang --autocomplete="$arg" 2>/dev/null ) + # Check if --autocomplete is supported in user's clang version. + if [[ "$?" != 0 ]]; then It is probably a bit better if you men

[PATCH] D34607: [Bash-autocompletion] Check clang version in Bash

yamaguchi created this revision. Add check if user's clang version supports --autocomplete or not. If not, we just autocomplete files. https://reviews.llvm.org/D34607 Files: clang/utils/bash-autocomplete.sh Index: clang/utils/bash-autocomplete.sh

[PATCH] D32411: [libcxx] Provide #include_next alternative for MSVC

bcraig added a comment. ping https://reviews.llvm.org/D32411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34574: [Sema] Disable c++17 aligned new and delete operators if not implemented in the deployment target's c++ standard library

ahatanak added a comment. I suppose it's possible to define a new driver option that can be used to tell clang to annotate the implicit declarations with an availability attribute, which will enable the link time error to be caught at compile time. Alternatively, it's also possible to put the a

r306258 - [bash-autocompletion] Delete space after flags which has '=' prefix

Author: yamaguchi Date: Sun Jun 25 17:35:36 2017 New Revision: 306258 URL: http://llvm.org/viewvc/llvm-project?rev=306258&view=rev Log: [bash-autocompletion] Delete space after flags which has '=' prefix Summary: This is patch for bash completion for clang project. We don't need space when comple

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

majnemer added a comment. We need tests that show that it does the right thing in blocks defined in classes in classes and other nested concepts. Comment at: lib/AST/MicrosoftMangle.cpp:980-981 + unsigned Discriminator = BD->getBlockManglingNumber(); + if (!Discrimin

[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

ahatanak added inline comments. Comment at: test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_deployment.fail.cpp:12-16 +// test availability of new/delete operators introduced in c++17. + +#ifdef __APPLE__ +#undef _LIBCPP_DISABLE_AVAILABILITY +#endif

[PATCH] D34556: [libcxx] Annotate c++17 aligned new/delete operators with availability attribute

ahatanak updated this revision to Diff 103880. ahatanak marked an inline comment as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D34556 Files: include/__config include/new test/std/language.support/support.dynamic/new.delete/new.delete.placement/new_d

[PATCH] D34523: AST: mangle BlockDecls under MS ABI

compnerd updated this revision to Diff 103879. compnerd marked 2 inline comments as done. compnerd added a comment. Use `mangleSourceName` Repository: rL LLVM https://reviews.llvm.org/D34523 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/msabi-blocks.cpp Index: test/CodeGenCXX/msabi

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

Ah, I see now then. I have a symlink from the root of my source directory pointing to the compile_commands.json in my build directory. I have this so that the vim YouCompleteMe plugin (& any other clang tools) can find it, as they usually should, for using tools with the llvm/clang project... So

Re: [clang-tools-extra] r303735 - Modify test so that it looks for patterns in stderr as well

2017-06-25 0:52 GMT+07:00 David Blaikie : > > > On Sat, Jun 24, 2017 at 10:08 AM Serge Pavlov wrote: > >> With CMAKE_EXPORT_COMPILE_COMMANDS the file compile_commands.json is >> created in the directory >> /tools/clang/tools/extra/test/clang-tidy/Output, >> >> > > I'd be really surprised if this

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc updated this revision to Diff 103871. mibintc added a comment. Here's a modified revision which checks if stdc-predef.h exists before adding a -include option to that file. this is only for Linux using gcc 4.8 and higher. Several tests needed to be fixed because of this change - i fix

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc abandoned this revision. mibintc added a comment. I want to submit a modified patch Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D34158: to support gcc 4.8 (and newer) compatibility on Linux, preinclude

mibintc planned changes to this revision. mibintc added a comment. I'm submitting another revision which checks for the existence of stdc-predef.h before inserting the -include option. Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-

[PATCH] D34606: [libcxx] Link MinGW libs for shared build

mati865 created this revision. Herald added a subscriber: mgorny. Another small step for libc++ with MinGW-w64. Repository: rL LLVM https://reviews.llvm.org/D34606 Files: lib/CMakeLists.txt Index: lib/CMakeLists.txt === ---

r306239 - Add support for Ananas platform

Author: ed Date: Sun Jun 25 01:29:09 2017 New Revision: 306239 URL: http://llvm.org/viewvc/llvm-project?rev=306239&view=rev Log: Add support for Ananas platform Ananas is a home-brew operating system, mainly for amd64 machines. After using GCC for quite some time, it has switched to clang and nev