This revision was automatically updated to reflect the committed changes.
Closed by commit rL305774: [analyzer] Teach CloneDetection about Qt Meta-Object
Compiler to filter auto… (authored by xiangzhai).
Changed prior to commit:
https://reviews.llvm.org/D34353?vs=103063&id=103162#toc
Repositor
Author: xiangzhai
Date: Tue Jun 20 01:44:46 2017
New Revision: 305774
URL: http://llvm.org/viewvc/llvm-project?rev=305774&view=rev
Log:
[analyzer] Teach CloneDetection about Qt Meta-Object Compiler to filter auto
generated files
Reviewers: v.g.vassilev, teemperor
Reviewed By: teemperor
Differe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305773: [analyzer] Check NULL pointer dereference issue for
memset function (authored by xiangzhai).
Changed prior to commit:
https://reviews.llvm.org/D31868?vs=101847&id=103161#toc
Repository:
rL LL
Author: xiangzhai
Date: Tue Jun 20 01:41:06 2017
New Revision: 305773
URL: http://llvm.org/viewvc/llvm-project?rev=305773&view=rev
Log:
[analyzer] Check NULL pointer dereference issue for memset function
Reviewers: dcoughlin, zaks.anna, NoQ, danielmarjamaki
Reviewed By: NoQ, danielmarjamaki
Dif
yvvan added a comment.
In https://reviews.llvm.org/D34279#784089, @hans wrote:
> I have 19.00.24210, so slightly earlier I suppose, but I believe we use
> Update 3 on our Chromium buildbots, and they seem happy.
>
> Can you paste the full error message? The part I see in your screenshot
> doesn
Author: ahatanak
Date: Tue Jun 20 01:18:46 2017
New Revision: 305772
URL: http://llvm.org/viewvc/llvm-project?rev=305772&view=rev
Log:
Add a subgroup of c++1z-compat to enable and disable the warning about
c++17's non-throwing exception specification in function signature.
rdar://problem/32628743
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305772: Add a subgroup of c++1z-compat to enable and disable
the warning about (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D34251?vs=102725&id=103159#toc
Repository:
rL
johannes updated this revision to Diff 103151.
https://reviews.llvm.org/D34329
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
lib/Tooling/ASTDiff/CMakeLists.txt
lib/Tooling/CMakeLists.txt
tools/CMakeLists.txt
tools/clang-diff/CMakeLists.txt
tools/clan
johannes added a comment.
In https://reviews.llvm.org/D34329#784090, @arphaman wrote:
> Generally we shouldn't have untested code in trunk, so I think that we need
> to find a way to test this before committing. We can start off by testing the
> output of the diff tool. Since there will be a lo
johannes updated this revision to Diff 103147.
johannes added a comment.
- style fixes
- do not compare nodes from system headers
https://reviews.llvm.org/D34329
Files:
include/clang/Tooling/ASTDiff/ASTDiff.h
lib/Tooling/ASTDiff/ASTDiff.cpp
lib/Tooling/ASTDiff/CMakeLists.txt
lib/Tooling
hintonda created this revision.
Reset ScopeSpec when parsing class, struct, etc.. Fixes PR32953.
https://reviews.llvm.org/D34383
Files:
lib/Parse/ParseDecl.cpp
test/SemaTemplate/instantiate-complete.cpp
Index: test/SemaTemplate/instantiate-complete.cpp
===
hintonda added a comment.
ping...
https://reviews.llvm.org/D16971
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Fri, Jun 16, 2017 at 5:08 PM, Duncan P. N. Exon Smith
wrote:
>
> On Jun 16, 2017, at 11:02, Reid Kleckner wrote:
>
> We should fix it.
>
>
> Agreed.
>
> We just need a new character code in the builtin function prototype
> encoding. Currently there is no encoding for a portable int32_t that
>
Author: rsmith
Date: Mon Jun 19 20:31:53 2017
New Revision: 305764
URL: http://llvm.org/viewvc/llvm-project?rev=305764&view=rev
Log:
Turn off "disable free" mode when preprocessing imported module files in
-frewrite-imports mode.
This could end up accumulating a very large amount of intermediate
On 19 June 2017 at 16:25, Duncan P. N. Exon Smith via Phabricator via
cfe-commits wrote:
> dexonsmith added a comment.
>
> > We use the `-Wc++NN-compat-` prefix on all the other subwarnings of
> `-Wc++NN-compat` warnings
>
> Interesting; I thought I saw a counter-example recently, and took that a
dexonsmith added a comment.
> We use the `-Wc++NN-compat-` prefix on all the other subwarnings of
> `-Wc++NN-compat` warnings
Interesting; I thought I saw a counter-example recently, and took that as the
rule (although I can't for the life of me remember what it was).
`-Wc++NN-compat-mangling
rsmith accepted this revision.
rsmith added a comment.
We use the `-Wc++NN-compat-` prefix on all the other subwarnings of
`-Wc++NN-compat` warnings (examples: `-Wc++98-compat-bind-to-temporary-copy`,
`-Wc++11-compat-reserved-user-defined-literal`, ...). I'd prefer to include the
`-compat` in t
Author: rsmith
Date: Mon Jun 19 18:09:36 2017
New Revision: 305758
URL: http://llvm.org/viewvc/llvm-project?rev=305758&view=rev
Log:
Support non-identifier module names when preprocessing modules.
Modified:
cfe/trunk/include/clang/Basic/Module.h
cfe/trunk/lib/Basic/Module.cpp
cfe/trun
I don't think we're quite done yet: we still seem to be missing
serialization / deserialization support for coroutines.
On 27 May 2017 at 15:54, Gor Nishanov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: gornishanov
> Date: Sat May 27 17:54:52 2017
> New Revision: 304081
>
> URL:
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
I think `-Wc++1z-mangling` is best. IMO, with C++1z in the name, it's already
clear that this is about compatibility. I also don't think we need to get as
specific as `-Wc++1z-compat
rsmith added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:870-872
+auto *Ty =
+dyn_cast(R.getLookupName().getCXXNameType());
+if (Ty && Ty->isUndeducedType())
This is not sufficient to catch cases such as `operator auto*`, and one day
the
erichkeane created this revision.
As the bug report says,
struct A
{
template operator T();
};
void foo()
{
A().operator auto();
}
causes: "undeduced type in IR-generation
UNREACHABLE executed at llvm/tools/clang/lib/CodeGen/CodeGenFunction.cpp:208!"
The problem is that in this case, "T
Author: vedantk
Date: Mon Jun 19 16:26:04 2017
New Revision: 305745
URL: http://llvm.org/viewvc/llvm-project?rev=305745&view=rev
Log:
[docs] Coverage: Improve the wording a bit
Modified:
cfe/trunk/docs/SourceBasedCodeCoverage.rst
Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst
URL:
htt
Author: vedantk
Date: Mon Jun 19 16:22:05 2017
New Revision: 305743
URL: http://llvm.org/viewvc/llvm-project?rev=305743&view=rev
Log:
[docs] Coverage: document issue with the BFD linker
Modified:
cfe/trunk/docs/SourceBasedCodeCoverage.rst
Modified: cfe/trunk/docs/SourceBasedCodeCoverage.rst
yaxunl created this revision.
The byval function argument is in alloca address space in LLVM IR. However,
during Clang codegen for C++, the address space of indirect function argument
should match its address space in the source code, even for byval argument.
This is because destructor of the byva
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D34353
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
mgorny created this revision.
Provide two new CMake cache variables -- CLANG_DEFAULT_STD_C
and CLANG_DEFAULT_STD_CXX -- that can be used to override the default
C/ObjC and C++/ObjC++ standards appropriately. They can be set to one of
the identifiers from LangStandards.def, or left unset (the defau
saugustine added a subscriber: klimek.
saugustine added a comment.
In https://reviews.llvm.org/D34304#783675, @klimek wrote:
> I think a better way might be to generally leave dependency options alone,
> add a default argument adapter to filter out all deps related flags, and
> allow users to a
Author: aaronballman
Date: Mon Jun 19 15:08:20 2017
New Revision: 305738
URL: http://llvm.org/viewvc/llvm-project?rev=305738&view=rev
Log:
Typo fix: appropo -> apropos. NFC.
Modified:
cfe/trunk/docs/Block-ABI-Apple.rst
Modified: cfe/trunk/docs/Block-ABI-Apple.rst
URL:
http://llvm.org/viewvc
alexshap updated this revision to Diff 103093.
alexshap added a comment.
update, rerun the tests
Repository:
rL LLVM
https://reviews.llvm.org/D34268
Files:
include/clang/Edit/EditedSource.h
lib/Edit/EditedSource.cpp
test/FixIt/fixit-format-darwin.m
Index: test/FixIt/fixit-format-darwi
alexshap planned changes to this revision.
alexshap marked an inline comment as done.
alexshap added a comment.
probably we don't need to keep the entire expansion stack in MacroArgUse (i was
doing that because it was easier to understand what's going on).
I will update this diff soon.
Reposito
alexshap marked 3 inline comments as done.
alexshap added inline comments.
Comment at: lib/Edit/EditedSource.cpp:80
+ return ArgUse.Identifier == U.Identifier &&
+ std::tie(ArgUse.ExpansionStack, ArgUse.Use) !=
+ std::tie(U.ExpansionSt
alexshap updated this revision to Diff 103090.
alexshap added a comment.
Address code review comments
Repository:
rL LLVM
https://reviews.llvm.org/D34268
Files:
include/clang/Edit/EditedSource.h
lib/Edit/EditedSource.cpp
test/FixIt/fixit-format-darwin.m
Index: test/FixIt/fixit-format-
ed added a comment.
Final call: do any of you have any more feedback on this change? If not, I will
go ahead and commit this change one of these days (together with
https://reviews.llvm.org/D32937).
Thanks,
Ed
https://reviews.llvm.org/D32936
___
manojgupta added a comment.
Thanks for the quick review.
https://reviews.llvm.org/D34357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: manojgupta
Date: Mon Jun 19 13:45:03 2017
New Revision: 305728
URL: http://llvm.org/viewvc/llvm-project?rev=305728&view=rev
Log:
[Clang] Handle interaction of -pg and no_instrument_function attribute.
Summary:
Disable generation of counting-function attribute if no_instrument_function
att
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
manojgupta created this revision.
Disable generation of counting-function attribute if no_instrument_function
attribute is present in function.
Interaction between -pg and no_instrument_function is the desired behavior
and matches gcc as well.
This is required for fixing a crash in Linux kernel wh
Ah, nevermind - I hadn't sync'd this change! Sorry for the noise.
Thanks for the feature!
On Mon, Jun 19, 2017 at 11:18 AM David Blaikie wrote:
> On Mon, Jun 19, 2017 at 12:30 AM Daniel Jasper via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: djasper
>> Date: Mon Jun 19 02:30:
thegameg added a comment.
In https://reviews.llvm.org/D26953#783497, @jtbandes wrote:
> Hm, I probably should've searched first — but I just re-implemented this in
> https://reviews.llvm.org/D34330. Actually, I think my implementation solves
> the `AllowShortIfStatementsOnASingleLine` issue yo
On Mon, Jun 19, 2017 at 12:30 AM Daniel Jasper via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: djasper
> Date: Mon Jun 19 02:30:04 2017
> New Revision: 305665
>
> URL: http://llvm.org/viewvc/llvm-project?rev=305665&view=rev
> Log:
> clang-format: Add capability to format the diff on
NoQ added a comment.
I'm sorry, i'd try to get back to this and unblock your progress as soon as
possible.
One thing i notice is that you manipulate symbolic expressions manually,
however many of the things that you need, eg stuff in your `compose()` method,
seem to be already available in `SV
arphaman added inline comments.
Comment at: include/clang/Edit/EditedSource.h:50
+// Location of argument use inside the top-level macro
+SourceLocation Use;
+
I think a name like `UseLoc` is more appropriate.
Comment at: lib/Edit/Edite
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Thanks, this was very useful, please commit!
Repository:
rL LLVM
https://reviews.llvm.org/D31868
___
cfe-commits mailing list
cfe-commits@lists.llvm
This revision was automatically updated to reflect the committed changes.
arphaman marked an inline comment as done.
Closed by commit rL305719: [Parser][ObjC] Use an artificial EOF token while
parsing lexed ObjC methods (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D
Author: arphaman
Date: Mon Jun 19 12:53:21 2017
New Revision: 305719
URL: http://llvm.org/viewvc/llvm-project?rev=305719&view=rev
Log:
[Parser][ObjC] Use an artificial EOF token while parsing lexed ObjC methods
This change avoid a crash that occurred when skipping to EOF while parsing an
ObjC int
yaxunl added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:1041
+default:
+ return LangAS::Default;
+}
Anastasia wrote:
> bader wrote:
> > yaxunl wrote:
> > > bader wrote:
> > > > yaxunl wrote:
> > > > > I think the default (including
baloghadamsoftware added a comment.
Any progress in the review?
https://reviews.llvm.org/D32642
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dkrupp added a comment.
Thanks.
> It would be best to just add the scan-build-py support to the tree,
> especially, since the new scrips are not tested.
OK. We will update this patch with the scan-build-py changes and remove the
ctu-build.py and ctu-analyze.py scripts.
> I am curious which op
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:7031
+Introduced) &&
+!S.Diags.isIgnored(diag::warn_unguarded_availability_new, Loc);
+diag = NewWarning ? diag::warn_partial_availability_new
erik.pilkington wrote:
> S
Hi
I am working on some Clang source-to-source transformation. I am doing
it from Clang source code: clang/tools/extra. What I do is that I am
adding a printf("Hello World\n"); at the beginning of the main method.
It works perfectly, I run my tool as bin/add-code ../../test/hello.c
and it turn
a.sidorin accepted this revision.
a.sidorin added a comment.
Ok, I hope this will work. Anyway, we can always revert this patch in case of
any problems.
https://reviews.llvm.org/D34277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Small comment in the test can be addressed in commit!
Comment at: test/SemaOpenCL/storageclass.cl:52
+kernel void invalidScope() {
+ if (true) {
+local int l
bader added inline comments.
Comment at: test/CodeGenOpenCL/spir_version.cl:13
kernel void foo() {}
+kernel void bar() {}
Anastasia wrote:
> Would the original code produce duplicate version metadata here or is it just
> for overloaded functions? Would it mak
ahatanak added a comment.
Thanks, LGTM.
Comment at: lib/Parse/ParseObjc.cpp:3636
+ Eof.setEofData(MCDecl);
+ Eof.setLocation(Tok.getLocation());
+ LM.Toks.push_back(Eof);
You can use OrigLoc instead of calling Tok.getLocation().
Repository:
rL LLVM
http
Anastasia added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:1041
+default:
+ return LangAS::Default;
+}
bader wrote:
> yaxunl wrote:
> > bader wrote:
> > > yaxunl wrote:
> > > > I think the default (including even_t, clk_event_t, qu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305711: CodeGen: Cast temporary variable to proper address
space (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D33706?vs=101227&id=103070#toc
Repository:
rL LLVM
https://re
Anastasia added inline comments.
Comment at: test/CodeGenOpenCL/spir_version.cl:13
kernel void foo() {}
+kernel void bar() {}
Would the original code produce duplicate version metadata here or is it just
for overloaded functions? Would it make sense to add `C
Author: yaxunl
Date: Mon Jun 19 12:03:41 2017
New Revision: 305711
URL: http://llvm.org/viewvc/llvm-project?rev=305711&view=rev
Log:
CodeGen: Cast temporary variable to proper address space
In C++ all variables are in default address space. Previously change has been
made to cast automatic variab
ruiu added inline comments.
Comment at: clang/include/clang/Driver/Options.td:496
def cl_std_EQ : Joined<["-"], "cl-std=">, Group,
Flags<[CC1Option]>,
- HelpText<"OpenCL language standard to compile for.">;
+ HelpText<"OpenCL language standard to compile for.">,
Values<"cl,C
xazax.hun added a comment.
While I have no objections, I am wondering whether this is the good way to
spend the performance budget. In particular, there are patches to generate more
symbolic expressions, that could also degrade the performance (but fix some
fixmes along the way).
https://revi
yawanng updated this revision to Diff 103068.
yawanng marked 3 inline comments as done.
https://reviews.llvm.org/D33304
Files:
clang-tidy/CMakeLists.txt
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/FileOpenFlagCheck.cpp
clang-tidy/android
akyrtzi updated this revision to Diff 103067.
akyrtzi added a comment.
Update doc-comment for `Preprocessor::EvaluateDirectiveExpression`
https://reviews.llvm.org/D34263
Files:
include/clang/Lex/Preprocessor.h
include/clang/Lex/PreprocessorOptions.h
lib/Lex/PPDirectives.cpp
lib/Lex/PPEx
akyrtzi updated this revision to Diff 103066.
akyrtzi added a comment.
Provide doc-comments for `struct DirectiveEvalResult`.
https://reviews.llvm.org/D34263
Files:
include/clang/Lex/Preprocessor.h
include/clang/Lex/PreprocessorOptions.h
lib/Lex/PPDirectives.cpp
lib/Lex/PPExpressions.cp
kulpreet added a comment.
In https://reviews.llvm.org/D34266#783156, @zaks.anna wrote:
> Thanks! Do you have commit access?
No problem! I don’t have commit access. In the past, Devin has commited on my
behalf.
Repository:
rL LLVM
https://reviews.llvm.org/D34266
akyrtzi added a comment.
In https://reviews.llvm.org/D34263#783770, @voskresensky.vladimir wrote:
> What I find problematic in this patch is PPOpts->SingleFileParseMode checks.
> Let's suppose we implement what I mentioned above => how is it going to
> co-exist nicely? I think code will be less
erik.pilkington added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:7031
+Introduced) &&
+!S.Diags.isIgnored(diag::warn_unguarded_availability_new, Loc);
+diag = NewWarning ? diag::warn_partial_availability_new
Sorry to keep this
xiangzhai created this revision.
Herald added a subscriber: xazax.hun.
Hi LLVM developers,
As Raphael suggested in https://reviews.llvm.org/D31320 I renamed
`AutoGeneratedCloneConstraint` to `FilenamePatternConstraint`, please review
it, thanks a lot!
Regards,
Leslie Zhai
Repository:
rL LL
akyrtzi added a comment.
In https://reviews.llvm.org/D34263#783694, @klimek wrote:
> how many patches for single file mode are coming down the road, though? I'm
> somewhat concerned about the overall complexity it'll add to clang.
There is no other patch for using this preprocessor option. Any
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
https://reviews.llvm.org/D34342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Typz updated this revision to Diff 103057.
Typz added a comment.
Fix indentation
https://reviews.llvm.org/D34238
Files:
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTest.cpp
unittests/Format/FormatTestJava.cpp
Index: unittests/Format/FormatTestJava.cpp
bader added inline comments.
Comment at: test/CodeGenOpenCL/sampler.cl:62
+
+ const sampler_t const_smp = CLK_ADDRESS_CLAMP_TO_EDGE |
CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR;
+ // CHECK: [[CONST_SAMP:%[0-9]+]] = call %opencl.sampler_t addrspace(2)*
@__translate_sampler
Typz updated this revision to Diff 103056.
Typz added a comment.
Fix case where the content fits on a line, by wrapping after each comma, like
this:
static int types[] = {
0,
1,
2,
};
https://reviews.llvm.org/D34238
Files:
lib/Format/C
ilya-biryukov added inline comments.
Comment at: include/clang/Frontend/PrecompiledPreamble.h:42-43
+/// destructors.
+/// An assertion will fire if two PCHTempFiles are created with the same name,
+/// so it's not intended to be used outside preamble-handling.
+class TempPCHFile
djasper added a comment.
For the test introduced in https://reviews.llvm.org/rL262291, either of the
changes causes a TT_SelectorName to become a TT_Unknown. So lets figure out how
to make this a difference in observable formatting behavior instead of removing
these checks.
https://reviews.ll
ilya-biryukov updated this revision to Diff 103053.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
- Added default initializers to PreambleFileHash.
- Update file comments to address klimek's questions.
https://reviews.llvm.org/D34287
Files:
include/clang/Front
hans added a comment.
I have 19.00.24210, so slightly earlier I suppose, but I believe we use Update
3 on our Chromium buildbots, and they seem happy.
Can you paste the full error message? The part I see in your screenshot doesn't
really make sense. Why should converting 1 to unsigned int be a
arphaman added a comment.
Generally we shouldn't have untested code in trunk, so I think that we need to
find a way to test this before committing. We can start off by testing the
output of the diff tool. Since there will be a lot of changes in the future,
you don't have to have everything cove
arphaman added inline comments.
Comment at: lib/Tooling/ASTDiff/ASTDiff.cpp:277
+Mappings::~Mappings() {
+ delete[] SrcToDst;
+ delete[] DstToSrc;
Please use `std::unique_ptr` for `SrcToDst` and `DstToSrc` as well
and remove the destructor.
https://reviews.l
arphaman added a comment.
Congratulations of the first GSoC patch! I have some below comments:
- Patches should be submitted using the full context (`git diff -U`). This
makes it easier for reviewers to understand the change. This patch mainly adds
new code, so this won't make much differen
krasimir created this revision.
Herald added a subscriber: klimek.
While trying to understand TT_SelectorName, I found 2 redundant checks.
Removing them doesn't cause any tests to fail.
https://reviews.llvm.org/D34351
Files:
lib/Format/TokenAnnotator.cpp
Index: lib/Format/TokenAnnotator.cpp
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/sampler.cl:62
+
+ const sampler_t const_smp = CLK_ADDRESS_CLAMP_TO_EDGE |
CLK_NORMALIZED_COORDS_TRUE | CLK_FILTER_LINEAR;
+ // CHECK: [[CONST_SAMP:%[0-9]+]] = call %opencl.sampler_t addrspace(2)*
@__translate_sample
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305696: clang-format: Fix C99 designated initializers corner
cases (authored by Typz).
Changed prior to commit:
https://reviews.llvm.org/D33491?vs=103018&id=103041#toc
Repository:
rL LLVM
https://re
Author: typz
Date: Mon Jun 19 09:41:21 2017
New Revision: 305696
URL: http://llvm.org/viewvc/llvm-project?rev=305696&view=rev
Log:
clang-format: Fix C99 designated initializers corner cases
Summary:
This fixes the missing space before the designated initializer when
`Cpp11BracedListStyle=false`
mharoush added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D33278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added inline comments.
Comment at: src/experimental/filesystem/operations.cpp:27
+// We can use the presence of UTIME_OMIT to detect platforms that do not
+// provide utimensat, with some exceptions on OS X.
+#if !defined(UTIME_OMIT) ||
ruiu accepted this revision.
ruiu added a comment.
LGTM
https://reviews.llvm.org/D33383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
krasimir added inline comments.
Comment at: lib/Format/UsingDeclarationsSorter.cpp:66
+ }
+ return HasIdentifier && Tok && Tok->isOneOf(tok::semi, tok::comma);
+}
Typz wrote:
> could also be followed by an assignment, in case of type alias:
>
> using foo = b
krasimir updated this revision to Diff 103032.
krasimir added a comment.
- Update test case
https://reviews.llvm.org/D33823
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/UsingDeclarationsSorter.cpp
lib/Format/UsingDeclarationsSorter.h
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D33491
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
krasimir updated this revision to Diff 103031.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Address review comments
https://reviews.llvm.org/D33823
Files:
include/clang/Format/Format.h
lib/Format/CMakeLists.txt
lib/Format/Format.cpp
lib/Format/UsingDeclarations
Author: christof
Date: Mon Jun 19 07:41:22 2017
New Revision: 305688
URL: http://llvm.org/viewvc/llvm-project?rev=305688&view=rev
Log:
Revert "[NFC] Refactor DiagnosticRenderer to use FullSourceLoc"
This reverts commit 305684.
This patch breaks extra/tools/clang-tidy
Modified:
cfe/trunk/incl
Author: arphaman
Date: Mon Jun 19 07:13:59 2017
New Revision: 305685
URL: http://llvm.org/viewvc/llvm-project?rev=305685&view=rev
Log:
Move the test from r305678 to a separte file with 'REQUIRES: system-darwin'
Otherwise it will fail on non-macOS systems.
Added:
cfe/trunk/test/Driver/darwin-
Author: christof
Date: Mon Jun 19 07:05:58 2017
New Revision: 305684
URL: http://llvm.org/viewvc/llvm-project?rev=305684&view=rev
Log:
[NFC] Refactor DiagnosticRenderer to use FullSourceLoc
Move the DiagnosticRenderer and its dependents to using FullSourceLocs
instead of a SourceLocation and Sour
christof added a comment.
I'll go ahead and commit this on the grounds that it was already approved and
the changes I made were the last nit-picks of @rnk
https://reviews.llvm.org/D31709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
Typz added inline comments.
Comment at: unittests/Format/FormatTest.cpp:1526
+ verifyFormat("const struct A a = {[0] = 1, [1] = 2};");
+ verifyFormat("const struct A a = {[1] = a,\n"
+ "[2] = b,\n"
djasper wrote
Typz updated this revision to Diff 103018.
Typz marked 2 inline comments as done.
Typz edited the summary of this revision.
Typz added a comment.
Fix review comments
https://reviews.llvm.org/D33491
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
lib/Format/TokenAnnotat
yvvan updated this revision to Diff 103016.
yvvan added a comment.
Do not evaluate numbers.
Check for != "=" is needed not to mess with invalid default arguments or their
types (without it I get "const Bar& bar = =" when Bar is not defined)
https://reviews.llvm.org/D33644
Files:
lib/Sema/Sem
arphaman updated this revision to Diff 103013.
arphaman marked an inline comment as done.
arphaman added a comment.
Remove the old checks and consume EOF unconditionally.
Repository:
rL LLVM
https://reviews.llvm.org/D34185
Files:
lib/Parse/ParseObjc.cpp
test/Parser/objc-at-implementation
arphaman marked an inline comment as done.
arphaman added inline comments.
Comment at: lib/Parse/ParseObjc.cpp:220
CheckNestedObjCContexts(AtLoc);
+ if (isEofOrEom())
+return nullptr;
ahatanak wrote:
> Do you need this check here (and below)?
Not anymore.
1 - 100 of 135 matches
Mail list logo
