EricWF updated this revision to Diff 102492.
EricWF added a comment.
- Improve test by using regular expressions and [[Name]] where possible.
https://reviews.llvm.org/D34194
Files:
lib/AST/ExprClassification.cpp
lib/CodeGen/CGCoroutine.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunct
dberris updated this revision to Diff 102491.
dberris added a comment.
- fixup: use bool arg in checkFunctionOrMethodParameterIndex
https://reviews.llvm.org/D34052
Files:
lib/Sema/SemaDeclAttr.cpp
test/Sema/xray-log-args-class.cpp
Index: test/Sema/xray-log-args-class.cpp
=
EricWF updated this revision to Diff 102487.
EricWF added a comment.
- Improve tests
https://reviews.llvm.org/D34194
Files:
lib/AST/ExprClassification.cpp
lib/CodeGen/CGCoroutine.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGenCoroutines/coro-await.cpp
Index: tes
EricWF updated this revision to Diff 102486.
EricWF added a comment.
- Remove unneeded assertion.
https://reviews.llvm.org/D34194
Files:
lib/AST/ExprClassification.cpp
lib/CodeGen/CGCoroutine.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
test/CodeGenCoroutines/coro-await.cp
EricWF updated this revision to Diff 102485.
EricWF edited the summary of this revision.
EricWF added a comment.
- Fix assertion for co_yield.
https://reviews.llvm.org/D34194
Files:
lib/AST/ExprClassification.cpp
lib/CodeGen/CGCoroutine.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunc
EricWF created this revision.
The title says it all.
However I can't figure out how to test `int& x = co_yield 42;` since that
expression doesn't seem to want to parse.
https://reviews.llvm.org/D34194
Files:
lib/CodeGen/CGCoroutine.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.
Author: mpark
Date: Wed Jun 14 00:51:18 2017
New Revision: 305370
URL: http://llvm.org/viewvc/llvm-project?rev=305370&view=rev
Log:
Add an `__is_inplace_index` metafunction.
Summary: This is used to constrain `variant`'s converting constructor correctly.
Reviewers: EricWF, mclow.lists
Reviewed
Author: marshall
Date: Tue Jun 13 23:48:45 2017
New Revision: 305365
URL: http://llvm.org/viewvc/llvm-project?rev=305365&view=rev
Log:
Implement the non-parallel versions of reduce and transform_reduce for C++17
Added:
libcxx/trunk/test/std/numerics/numeric.ops/reduce/
libcxx/trunk/test/s
Author: ericwf
Date: Tue Jun 13 22:24:55 2017
New Revision: 305363
URL: http://llvm.org/viewvc/llvm-project?rev=305363&view=rev
Log:
[coroutines] Fix co_await for range statement
Summary:
Currently we build the co_await expressions on the wrong implicit statements of
the implicit ranged for; Spe
EricWF updated this revision to Diff 102472.
EricWF added a comment.
- Remove changes to how `CoroutineSuspendExpr`s `ExprValueType` is calculated.
They were incorrect. However this means that Clang still fails to compile
`co_await` and `co_yield` expressions where `await_resume` returns an lval
Author: rtrieu
Date: Tue Jun 13 22:19:58 2017
New Revision: 305362
URL: http://llvm.org/viewvc/llvm-project?rev=305362&view=rev
Log:
[ODRHash] Remove debugging code from r305361
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
Modified: cfe/trunk/lib/AST/ODRHash.cpp
URL:
http://llvm.org/viewvc/llvm-
Author: rtrieu
Date: Tue Jun 13 22:17:26 2017
New Revision: 305361
URL: http://llvm.org/viewvc/llvm-project?rev=305361&view=rev
Log:
[ODRHash] Hash Template and TemplateExpansion in TemplateArgument.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cf
On Mon, Jun 12, 2017 at 2:01 PM, Erik Schwiebert via cfe-commits
wrote:
> SGTM too. Regarding Duncan's last question -- I can't think of any such
> customer. :) If you all think the right thing for clang to do is to infer
> LLP64 behavior on LP64 (Darwin) + ms_extensions, then that is fine with
Author: rtrieu
Date: Tue Jun 13 20:28:00 2017
New Revision: 305360
URL: http://llvm.org/viewvc/llvm-project?rev=305360&view=rev
Log:
[ODRHash] Hash Expr for TemplateArgument::Expression
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/lib/AS
Author: tstellar
Date: Tue Jun 13 20:04:54 2017
New Revision: 305353
URL: http://llvm.org/viewvc/llvm-project?rev=305353&view=rev
Log:
Creating release candidate rc3 from release_401 branch
Added:
libcxxabi/tags/RELEASE_401/rc3/ (props changed)
- copied from r305352, libcxxabi/branche
Author: tstellar
Date: Tue Jun 13 20:04:51 2017
New Revision: 305352
URL: http://llvm.org/viewvc/llvm-project?rev=305352&view=rev
Log:
Creating release candidate rc3 from release_401 branch
Added:
libcxx/tags/RELEASE_401/rc3/ (props changed)
- copied from r305351, libcxx/branches/rele
Author: tstellar
Date: Tue Jun 13 20:05:11 2017
New Revision: 305359
URL: http://llvm.org/viewvc/llvm-project?rev=305359&view=rev
Log:
Creating release candidate rc3 from release_401 branch
Added:
libunwind/tags/RELEASE_401/rc3/ (props changed)
- copied from r305358, libunwind/branche
mehdi_amini added a comment.
In https://reviews.llvm.org/D33976#776486, @mehdi_amini wrote:
> In https://reviews.llvm.org/D33976#775918, @alexshap wrote:
>
> > @mehdi_amini , thanks, i see, regarding the "opposite issue" - probably an
> > example / test case would be helpful, that looks like a s
erichkeane updated this revision to Diff 102458.
erichkeane added a comment.
Added unit test to validate that this still works throughout the range of
arguments, and asserts as soon as you get to the end as requested.
https://reviews.llvm.org/D32046
Files:
include/clang/Lex/MacroArgs.h
lib
arphaman created this revision.
This patch fixes a Clang crash that happens when an Objective-C source code
contains an `@interface`/`@implementation` declaration that follows
unterminated `@implementation` declaration that contains a method with a
message send that doesn't have the ']'. The cr
dexonsmith added a comment.
You mention that the lock-free `deque` gives a speedup. I agree that should be
left for a follow-up, but what kind of speedup did it give?
Have you measured whether the parallel algorithm gives a speedup, compared to a
non-parallel algorithm?
https://reviews.llvm.
teemperor created this revision.
Herald added a subscriber: xazax.hun.
This patch aims at optimizing the CloneChecker for larger programs. Before
this patch we took around 102 seconds to analyze sqlite3 with a complexity
value of 50. After this patch we now take 2.1 seconds to analyze sqlite3.
pcc added a comment.
In https://reviews.llvm.org/D34156#779661, @tobiasvk wrote:
> In https://reviews.llvm.org/D34156#779270, @pcc wrote:
>
> > Have you considered writing the regular LTO summaries unconditionally if
> > `-flto` was specified? That was how I imagined that the interface would
>
tobiasvk added a comment.
In https://reviews.llvm.org/D34156#779270, @pcc wrote:
> Have you considered writing the regular LTO summaries unconditionally if
> `-flto` was specified? That was how I imagined that the interface would look.
Absolutely, if people are OK with that. I would have enabl
hintonda created this revision.
Handle -ast-dump-all when passed as the only option.
https://reviews.llvm.org/D34179
Files:
lib/Frontend/ASTConsumers.cpp
test/Coverage/ast-printing.c
test/Coverage/ast-printing.cpp
Index: test/Coverage/ast-printing.cpp
===
Author: rtrieu
Date: Tue Jun 13 17:21:18 2017
New Revision: 305328
URL: http://llvm.org/viewvc/llvm-project?rev=305328&view=rev
Log:
[ODRHash] Add TemplateArgument kind to hash.
Modified:
cfe/trunk/lib/AST/ODRHash.cpp
cfe/trunk/test/Modules/odr_hash.cpp
Modified: cfe/trunk/lib/AST/ODRHas
vsk added a comment.
In https://reviews.llvm.org/D34121#779347, @dtzWill wrote:
> Don't mean to block this, but just FYI I won't be able to look into this
> carefully until later this week (sorry!).
>
> Kicked off a rebuild using these patches just now, though! O:)
No problem, thanks for takin
arphaman created this revision.
This patch improves the driver by making sure that it picks the system version
for the deployment target when the version of the macOS SDK is newer than the
system version.
Repository:
rL LLVM
https://reviews.llvm.org/D34175
Files:
lib/Driver/ToolChains/Da
aaron.ballman added a reviewer: rsmith.
aaron.ballman added a comment.
Adding Richard to the review for some wider perspective than just mine on the
overall design.
Comment at: lib/Sema/AnalysisBasedWarnings.cpp:296
+
+ if (ThrowType->isReferenceType())
+ThrowType = Throw
yaxunl added a comment.
Can you add missing types to test/CodeGenOpenCL/opencl_types.cl ?
Comment at: include/clang/Basic/TargetInfo.h:1034
+ virtual LangAS::ID getOpenCLTypeAddrSpace(BuiltinType::Kind K) const {
+switch (K) {
+#define IMAGE_TYPE(ImgType, Id, SingletonId,
Ah, I find that the test passes if I remove the compile_commands.json file
from my build directory (I have Ninja configured to generate a
compile_commands.json file).
Looks like what happens is it finds the compilation database and fails hard
when the database doesn't contain a compile command for
arphaman created this revision.
This is a follow up to r302797 which added support for dependent completions
after '.' and '->'. This patch handles the '::' operator.
Repository:
rL LLVM
https://reviews.llvm.org/D34173
Files:
lib/Sema/SemaCodeComplete.cpp
test/CodeCompletion/member-acce
Author: davidxl
Date: Tue Jun 13 16:14:07 2017
New Revision: 305325
URL: http://llvm.org/viewvc/llvm-project?rev=305325&view=rev
Log:
Preserve cold attribute for function decls
Differential Revision: http://reviews.llvm.org/D34133
Modified:
cfe/trunk/lib/CodeGen/CGCall.cpp
cfe/trunk/te
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305325: Preserve cold attribute for function decls (authored
by davidxl).
Changed prior to commit:
https://reviews.llvm.org/D34133?vs=102358&id=102409#toc
Repository:
rL LLVM
https://reviews.llvm.or
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D34133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
bcraig created this revision.
format.py and config.py were routinely reaching into the innards of
compiler.py, then setting variables in a very gcc / clang-centric way. Now,
all the compiler specific code has been moved to compiler.py. These makes it
possible to (in theory) build with MSVC in
kuang_he added a comment.
Can we have this patch reviewed?
https://reviews.llvm.org/D33833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtzWill added a comment.
Don't mean to block this, but just FYI I won't be able to look into this
carefully until later this week (sorry!).
Kicked off a rebuild using these patches just now, though! O:)
https://reviews.llvm.org/D34121
___
cfe-comm
fedor.sergeev added a comment.
> docs are rather clear that this functionality is Linux-only
Oh, well, gcc implementation is rather generic, it relies on gcc's config.gcc
to detect glibc and then it adds a hook that unconditionally provides
stdc-predef.h (TARGET_C_PREINCLUDE).
Currently config.
EricWF added inline comments.
Comment at: include/clang/AST/ExprCXX.h:4136
+ : Expr(SC, Resume->getType(),
+ (Resume->getType()->isLValueReferenceType() ? VK_LValue :
+ Resume->getType()->isRValueReferenceType() ? VK_XValue :
@rsmith
fedor.sergeev added inline comments.
Comment at: lib/Driver/ToolChains/Gnu.h:219-220
+void AddGnuIncludeArgs(const llvm::opt::ArgList &DriverArgs,
+ llvm::opt::ArgStringList &CC1Args) const;
+
To me this does not belong to GCC-Insta
Thanks I'll fix that.
-Original Message-
From: Fedor Sergeev via Phabricator [mailto:revi...@reviews.llvm.org]
Sent: Tuesday, June 13, 2017 3:30 PM
To: Blower, Melanie ; zhangsheng...@huawei.com;
olivier...@gmail.com; kalinichev.s...@gmail.com; kf...@kde.org;
m...@milianw.de; cfe-commi
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Could you please add the benchmark under `libcxx/benchmarks`.
Could you also make sure that the existing tests (under `test/std`) for number
parsing have sufficient test coverages for t
fedor.sergeev added a comment.
There is no /usr/include/stdc-predef.h on Solaris and I see no sense in adding
this -include for anything except Linux
(as docs are rather clear that this functionality is Linux-only).
Checked gcc on Solaris11/12 both SPARC and X86 - none are doing stdc-predef.h
i
mibintc updated this revision to Diff 102382.
mibintc added a comment.
forgot to add the new lit test
https://reviews.llvm.org/D34158
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains/Gnu.cpp
lib/Driver/ToolChains/Gnu.h
lib/Driver/ToolChains/Linux.
pcc added a comment.
Have you considered writing the regular LTO summaries unconditionally if
`-flto` was specified? That was how I imagined that the interface would look.
Also, how were you planning to expose the reference graph to the linker? I
gather from your message that you are teaching y
mibintc created this revision.
mibintc created this object with visibility "All Users".
Herald added subscribers: fedor.sergeev, arichardson, Anastasia, sdardis,
klimek.
As reported in llvm bugzilla 32377.
Here’s a patch to add preinclude of stdc-predef.h for gcc >= 4.8
The gcc documentation say
yaxunl updated this revision to Diff 102374.
yaxunl marked 11 inline comments as done.
yaxunl edited the summary of this revision.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D28691
Files:
docs/LanguageExtensions.rst
include/clang/AST/Expr.h
include/clang/
Author: kongyi
Date: Tue Jun 13 13:38:31 2017
New Revision: 305315
URL: http://llvm.org/viewvc/llvm-project?rev=305315&view=rev
Log:
Fix spurious Wunused-lambda-capture warning
Summary:
Clang emits unused-lambda-capture warning for captures in generic lambdas even
though they are actually used.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305315: Fix spurious Wunused-lambda-capture warning
(authored by kongyi).
Changed prior to commit:
https://reviews.llvm.org/D33526?vs=102099&id=102371#toc
Repository:
rL LLVM
https://reviews.llvm.or
tobiasvk created this revision.
Herald added subscribers: eraman, inglorion.
With https://reviews.llvm.org/D33921, we gained the ability to have module
summaries in regular
LTO modules without triggering ThinLTO compilation. There is however,
currently, no way to trigger the emission of a module
Author: fhahn
Date: Tue Jun 13 13:06:15 2017
New Revision: 305312
URL: http://llvm.org/viewvc/llvm-project?rev=305312&view=rev
Log:
Align definition of DW_OP_plus with DWARF spec [2/3]
Summary:
This patch is part of 3 patches that together form a single patch, but must be
introduced in stages in
lebedev.ri added a comment.
In https://reviews.llvm.org/D32942#778729, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D32942#777001, @lebedev.ri wrote:
>
> > Which makes sense, since in AST, they are nested:
>
>
> They're not nested in the formatting, so I don't think it makes sense.
As
erichkeane added a comment.
Sure, I'll work on that, thanks!
https://reviews.llvm.org/D32046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
Can you somehow test this change? Maybe a unittest for
`getStringifiedArgument`that ensures that the assertion is triggered after the
number of macro arguments is reached?
https://reviews.llvm.org/D32046
___
cfe-commits m
davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D34082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
erichkeane added a comment.
Anyone have a chance to look at this? I'll note that this is in no way MSVC
specific, this is a code-health issue.
https://reviews.llvm.org/D32046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
v.g.vassilev added a comment.
Waiting on resolution to: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79162
Repository:
rL LLVM
https://reviews.llvm.org/D33467
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
yawanng added inline comments.
Comment at: docs/clang-tidy/checks/android-file-open-flag.rst:6
+
+A common source of security bugs has been code that opens file without using
+the ``O_CLOEXEC`` flag. Without that flag, an opened sensitive file would
alexfh wrote
davidxl updated this revision to Diff 102358.
davidxl added a comment.
Herald added a subscriber: javed.absar.
Add a test case.
https://reviews.llvm.org/D34133
Files:
lib/CodeGen/CGCall.cpp
test/CodeGen/attributes.c
Index: test/CodeGen/attributes.c
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D32428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
ilya-biryukov created this revision.
https://reviews.llvm.org/D34151
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
unittests/clangd/ClangdTests.cpp
Index: unittests/clangd/ClangdTests.cpp
===
--- unittests/clangd/Clangd
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D33977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Typz updated this revision to Diff 102346.
Typz added a comment.
- make "compacted" namespaces always add at most one level of indentation
- compact only namespaces which both start and end on consecutive lines
https://reviews.llvm.org/D32480
Files:
include/clang/Format/Format.h
lib/Format/
Author: ibiryukov
Date: Tue Jun 13 11:02:27 2017
New Revision: 305299
URL: http://llvm.org/viewvc/llvm-project?rev=305299&view=rev
Log:
[clangd] A comment for ClangdServer's constructor. NFC.
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.h
Modified: clang-tools-extra/trunk/clangd/Cla
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305298: [clangd] Store references instead of unique_ptrs in
ClangdServer. (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D34148?vs=102333&id=102344#toc
Repository:
rL LLVM
Author: ibiryukov
Date: Tue Jun 13 10:59:43 2017
New Revision: 305298
URL: http://llvm.org/viewvc/llvm-project?rev=305298&view=rev
Log:
[clangd] Store references instead of unique_ptrs in ClangdServer.
Summary:
ClangdServer owned objects passed to it in constructor for no good reason.
Lots of stu
Author: gbercea
Date: Tue Jun 13 10:35:27 2017
New Revision: 305294
URL: http://llvm.org/viewvc/llvm-project?rev=305294&view=rev
Log:
Add comma to comment.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL:
http://llvm.org/viewvc/llv
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
But, of course, that can be done in a separate commit.
https://reviews.llvm.org/D34148
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
krasimir added inline comments.
Comment at: clangd/ClangdLSPServer.h:75
+ LSPDiagnosticsConsumer DiagConsumer;
+ RealFileSystemProvider FSProvider;
+
This approach is still inflexible. I'd make ClangdLSPServer : public
DiagnosticsConsumer and pass references t
Author: krasimir
Date: Tue Jun 13 09:58:55 2017
New Revision: 305293
URL: http://llvm.org/viewvc/llvm-project?rev=305293&view=rev
Log:
[clang-format] Document the StartOfTokenColumn parameter, NFC
Modified:
cfe/trunk/lib/Format/WhitespaceManager.h
Modified: cfe/trunk/lib/Format/WhitespaceMan
ilya-biryukov created this revision.
ClangdServer was owning objects passed to it in constructor for no good reason.
Lots of stuff was moved from the heap to the stack thanks to this change.
https://reviews.llvm.org/D34148
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/
I cannot reproduce such fail, so I can only guess how changes made in
https://reviews.llvm.org/rL303756 and https://reviews.llvm.org/rL303741
could cause such problem. Behavior of `Driver::BuildCompilation` is changed
so that it returns null pointer if errors occur during driver argument
parse. It
Author: marshall
Date: Tue Jun 13 09:34:58 2017
New Revision: 305292
URL: http://llvm.org/viewvc/llvm-project?rev=305292&view=rev
Log:
Fix bug 33389 - __is_transparent check requires too much
Modified:
libcxx/trunk/include/__functional_base
libcxx/trunk/test/std/containers/associative/map
MartinO accepted this revision.
MartinO added a comment.
This revision is now accepted and ready to land.
`Looks good. Previously I had also got a check for 'defined(__NEWLIB_MINOR__)'
but I realise that was not necessary`
https://reviews.llvm.org/D32146
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This was committed as r305136
https://reviews.llvm.org/D34038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
mclow.lists added a comment.
This change looks fine to me - but I don't have the different newlib versions
to test against.
Once everyone else is happy with the version detection, then I'm good with this.
https://reviews.llvm.org/D32146
___
cfe-co
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305291: [clangd] Allow to override contents of the file
during completion. (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D34146?vs=102328&id=102331#toc
Repository:
rL LLV
Author: ibiryukov
Date: Tue Jun 13 09:15:56 2017
New Revision: 305291
URL: http://llvm.org/viewvc/llvm-project?rev=305291&view=rev
Log:
[clangd] Allow to override contents of the file during completion.
Summary:
This is a reapplied r305280 with a fix to the crash found by build bots
(StringRef to
ilya-biryukov added inline comments.
Comment at: clangd/ClangdServer.cpp:190
+ llvm::Optional OverridenContents) {
+ std::string DraftStorage;
+ if (!OverridenContents) {
This is the relevant line that changed from the previous review.
ilya-biryukov created this revision.
This is a reapplied r305280 with a fix to the crash found by build bots
(StringRef to an out-of-scope local std::string).
https://reviews.llvm.org/D34146
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
unittests/clangd/ClangdTests.cpp
Index: unit
Hi,
I reverted r305287, since the bots were red for a very long time. More
bots with the same error:
http://lab.llvm.org:8011/builders/clang-cmake-armv7-a15-full/builds/7727
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/5503
http://lab.llvm.org:8011/builders/clang-hexagon-elf
Author: rovka
Date: Tue Jun 13 07:50:06 2017
New Revision: 305287
URL: http://llvm.org/viewvc/llvm-project?rev=305287&view=rev
Log:
Revert "Revert r301742 which made ExprConstant checking apply to all
full-exprs."
This reverts commit r305239 because it broke the buildbots (the
diag-flags.cpp tes
bader updated this revision to Diff 102319.
bader added a comment.
Update one more test missed in the first version of the patch.
Actually it looks like a bug in Parser.
Clang interprets following statement as variable declaration.
extern pipe write_only int get_pipe();
So the type of the pip
Prazek added inline comments.
Comment at: include/clang/Basic/Attr.td:2421
-def SelectAny : InheritableAttr, TargetSpecificAttr {
+def SelectAny : InheritableAttr, TargetSpecificAttr {
let Spellings = [Declspec<"selectany">, GCC<"selectany">];
rnk wrote:
> d
malcolm.parsons accepted this revision.
malcolm.parsons added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D33526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
kongyi added a comment.
For normal captures, variables are safe to eliminate if they are non-ODR used
or totally unused. However for init captures, non-ODR usage still depends on
the capture; they are only safe to eliminate if totally unused.
Repository:
rL LLVM
https://reviews.llvm.org/D33
Author: ibiryukov
Date: Tue Jun 13 05:01:11 2017
New Revision: 305283
URL: http://llvm.org/viewvc/llvm-project?rev=305283&view=rev
Log:
Revert "[clangd] Allow to override contents of the file during completion."
This caused buildbots failures, reverting until we'll find out what's
wrong.
Modifie
Serge_Preis added a reviewer: rsmith.
Serge_Preis added a comment.
Would you please take a look into proposed minor changes to avoid mangler
assertion in some template cases.
https://reviews.llvm.org/D32428
___
cfe-commits mailing list
cfe-commits@
Serge_Preis added a reviewer: arphaman.
Serge_Preis added a comment.
Hello,
would you please review my small fix for incorrect source positions for certain
entities. The changes were submitted more than a month ago and I understand you
all are busy people, but I hope this review won't take long
malcolm.parsons added a comment.
I don't understand why init captures have this problem.
The variable is defined within the context of the lambda, but it's not within
the context of the templated method.
Are you working around a bug somewhere else?
Repository:
rL LLVM
https://reviews.llvm.or
malcolm.parsons added a comment.
In https://reviews.llvm.org/D32942#777001, @lebedev.ri wrote:
> Which makes sense, since in AST, they are nested:
They're not nested in the formatting, so I don't think it makes sense.
Repository:
rL LLVM
https://reviews.llvm.org/D32942
_
Author: ibiryukov
Date: Tue Jun 13 03:32:27 2017
New Revision: 305280
URL: http://llvm.org/viewvc/llvm-project?rev=305280&view=rev
Log:
[clangd] Allow to override contents of the file during completion.
Reviewers: krasimir
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Differential Rev
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305280: [clangd] Allow to override contents of the file
during completion. (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D34107?vs=102300&id=102301#toc
Repository:
rL LLV
ilya-biryukov added inline comments.
Comment at: unittests/clangd/ClangdTests.cpp:452
+ StringRef(OverridenSourceContents))
+.Value;
+EXPECT_TRUE(ContainsItem(CodeCompletionResultsOverriden, "cbc"));
krasimir wrote:
> Is t
ilya-biryukov updated this revision to Diff 102300.
ilya-biryukov marked 2 inline comments as done.
ilya-biryukov added a comment.
Fixed formatting, added a space (see krasimir's comment)
https://reviews.llvm.org/D34107
Files:
clangd/ClangdServer.cpp
clangd/ClangdServer.h
unittests/clangd
This revision was automatically updated to reflect the committed changes.
Closed by commit rL305279: [clangd] Use 'std::string' for VFSTag instead of
'int' (authored by ibiryukov).
Changed prior to commit:
https://reviews.llvm.org/D34106?vs=102189&id=102298#toc
Repository:
rL LLVM
https://r
Author: ibiryukov
Date: Tue Jun 13 03:24:48 2017
New Revision: 305279
URL: http://llvm.org/viewvc/llvm-project?rev=305279&view=rev
Log:
[clangd] Use 'std::string' for VFSTag instead of 'int'
Reviewers: krasimir
Reviewed By: krasimir
Subscribers: klimek, cfe-commits
Tags: #clang-tools-extra
Di
Author: ismail
Date: Tue Jun 13 03:16:44 2017
New Revision: 305278
URL: http://llvm.org/viewvc/llvm-project?rev=305278&view=rev
Log:
Set a default value for LIBCXXABI_LIBDIR_SUFFIX, fixes installing into lib64
after r304374
Modified:
libcxxabi/trunk/CMakeLists.txt
Modified: libcxxabi/trunk/
hard to say if it's more readable without seeing it - if you could attach a
patch, if it's easy enough/you worked it up before, might be worth
comparing/contrasting
On Tue, Jun 13, 2017 at 12:28 AM Dean Michael Berris via Phabricator <
revi...@reviews.llvm.org> wrote:
> dberris added a comment.
1 - 100 of 104 matches
Mail list logo
