Author: pcc
Date: Wed May 31 22:48:12 2017
New Revision: 304385
URL: http://llvm.org/viewvc/llvm-project?rev=304385&view=rev
Log:
docs: Document LLD's cache dir argument.
Modified:
cfe/trunk/docs/ThinLTO.rst
Modified: cfe/trunk/docs/ThinLTO.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/t
Author: ericwf
Date: Wed May 31 21:31:01 2017
New Revision: 304384
URL: http://llvm.org/viewvc/llvm-project?rev=304384&view=rev
Log:
Fix name used in -verify diagnostic to match trunk
Modified:
libcxx/trunk/test/libcxx/utilities/tuple/tuple.tuple/diagnose_reference_binding.fail.cpp
Modified
Author: ericwf
Date: Wed May 31 21:29:37 2017
New Revision: 304383
URL: http://llvm.org/viewvc/llvm-project?rev=304383&view=rev
Log:
Fix more unreserved names
Modified:
libcxx/trunk/include/limits
libcxx/trunk/include/memory
libcxx/trunk/include/stdexcept
libcxx/trunk/include/stri
Author: ericwf
Date: Wed May 31 21:14:21 2017
New Revision: 304382
URL: http://llvm.org/viewvc/llvm-project?rev=304382&view=rev
Log:
Rename unreserved names in tuple
Modified:
libcxx/trunk/include/tuple
Modified: libcxx/trunk/include/tuple
URL:
http://llvm.org/viewvc/llvm-project/libcxx/tru
GorNishanov closed this revision.
GorNishanov added a comment.
Tested checked in. Thank you for looking into this, Reid!
r304380 = 1c0d15a4bf10876bb233e921907e114d52bee82e
https://reviews.llvm.org/D33733
___
cfe-commits mailing list
cfe-commits@lis
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304380: CGCleanup: (NFC) add another test for r304335 -
Don't try to spill static… (authored by GorNishanov).
Changed prior to commit:
https://reviews.llvm.org/D33750?vs=100951&id=100955#toc
Repository
jgorbe added inline comments.
Comment at: lib/Driver/Driver.cpp:2600-2603
+ // When saving temps, add extra actions to write unoptimized and
optimized
+ // IR besides the normal bitcode outputs if possible. This is not
possible
+ // for multi-arch builds because
Author: gornishanov
Date: Wed May 31 20:15:25 2017
New Revision: 304380
URL: http://llvm.org/viewvc/llvm-project?rev=304380&view=rev
Log:
CGCleanup: (NFC) add another test for r304335 - Don't try to spill static
allocas
Summary:
Coroutine related test that used to trigger broken IR prior to r304
jgorbe updated this revision to Diff 100954.
jgorbe added a comment.
Clarify that we only skip saving IR for multiarch Mach-O universal builds, not
other multi-arch builds like CUDA.
https://reviews.llvm.org/D33108
Files:
include/clang/Driver/Driver.h
lib/Driver/Driver.cpp
test/Driver/cu
rjmccall added inline comments.
Comment at: test/CodeGenCXX/strict-vtable-pointers.cpp:263
+
+struct VirtualInVBase : virtual Empty, HoldingVirtuals {
+};
"virtual" applies to an individual base, not to all following bases. You need
"virtual HoldingVirtuals" he
Author: ericwf
Date: Wed May 31 20:00:59 2017
New Revision: 304377
URL: http://llvm.org/viewvc/llvm-project?rev=304377&view=rev
Log:
Upgrade Clang version used by appveyor
Modified:
libcxx/trunk/appveyor-reqs-install.cmd
Modified: libcxx/trunk/appveyor-reqs-install.cmd
URL:
http://llvm.org/
EricWF added inline comments.
Comment at: include/__hash_table:139
{
-return size_t(1) << (std::numeric_limits::digits - __clz(__n-1));
+return (__n > 1) ? (size_t(1) << (std::numeric_limits::digits -
__clz(__n-1))) : __n;
}
Shouldn't this return `__n
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Looks great, thanks!
https://reviews.llvm.org/D33437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
rjmccall requested changes to this revision.
rjmccall added a comment.
This revision now requires changes to proceed.
Please split this up into two patches:
- one for your target-specific changes to the global address space and so on
- one for the generic fix to CreateTempAlloca etc.
=
GorNishanov created this revision.
Coroutine related test that used to trigger broken IR prior to r304335.
https://reviews.llvm.org/D33750
Files:
test/CodeGenCoroutines/coro-await-domination.cpp
Index: test/CodeGenCoroutines/coro-await-domination.cpp
I'm assuming libc++ should move to this trait instead?
/Eric
On Wed, May 31, 2017 at 6:28 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Wed May 31 19:28:16 2017
> New Revision: 304376
>
> URL: http://llvm.org/viewvc/llvm-project?rev=304376&view=r
Go for it
On May 31, 2017 20:07, "Eric Fiselier via Phabricator" <
revi...@reviews.llvm.org> wrote:
> EricWF added a comment.
>
> @loladiro The patch doesn't apply correctly to the test. Do you mind if I
> hijack this and fix it?
>
>
> Repository:
> rL LLVM
>
> https://reviews.llvm.org/D24371
>
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. @loladiro Would you like to commit this?
https://reviews.llvm.org/D24371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
EricWF updated this revision to Diff 100949.
EricWF added a comment.
- Fix patch so it applies cleanly.
https://reviews.llvm.org/D24371
Files:
lib/Sema/SemaDecl.cpp
test/SemaCXX/attr-require-constant-initialization.cpp
Index: test/SemaCXX/attr-require-constant-initialization.cpp
==
Author: rsmith
Date: Wed May 31 19:28:16 2017
New Revision: 304376
URL: http://llvm.org/viewvc/llvm-project?rev=304376&view=rev
Log:
PR33232: implement support for MSVC's __is_trivially_destructible trait.
Unlike the GCC-compatible __has_trivial_destructor trait, this one computes the
right answe
tra added inline comments.
Comment at: lib/Driver/Driver.cpp:2600-2603
+ // When saving temps, add extra actions to write unoptimized and
optimized
+ // IR besides the normal bitcode outputs if possible. This is not
possible
+ // for multi-arch builds because in
Author: martell
Date: Wed May 31 19:09:20 2017
New Revision: 304374
URL: http://llvm.org/viewvc/llvm-project?rev=304374&view=rev
Log:
[libcxxabi] Rework CMakeLists.txt into modules
Refactor cmake to remove dependence on LLVM's cmake modules.
This improves handling of cmake checks when cross compi
EricWF added a comment.
@loladiro The patch doesn't apply correctly to the test. Do you mind if I
hijack this and fix it?
Repository:
rL LLVM
https://reviews.llvm.org/D24371
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
GorNishanov abandoned this revision.
GorNishanov added a comment.
Abandoning... Reid fixed the problem with "r304335 - Don't try to spill static
allocas when emitting expr cleanups with branches"
Thank you Reid for looking into it!
https://reviews.llvm.org/D33663
___
krytarowski added a comment.
What software in particular, besides compilers?
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed May 31 18:41:11 2017
New Revision: 304373
URL: http://llvm.org/viewvc/llvm-project?rev=304373&view=rev
Log:
[coroutines] Fix checking for prvalue-ness of `await_suspend` return type
Summary:
@rsmith Does this correctly address the issues mentioned in
https://reviews.llvm
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D33636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Author: ericwf
Date: Wed May 31 18:27:25 2017
New Revision: 304372
URL: http://llvm.org/viewvc/llvm-project?rev=304372&view=rev
Log:
Define -DNOMINMAX when running the tests on Windows
Modified:
libcxx/trunk/utils/libcxx/test/config.py
Modified: libcxx/trunk/utils/libcxx/test/config.py
URL:
EricWF abandoned this revision.
EricWF added a comment.
In https://reviews.llvm.org/D33741#769421, @CaseyCarter wrote:
> In https://reviews.llvm.org/D33741#769381, @EricWF wrote:
>
> > In https://reviews.llvm.org/D33741#769371, @STL_MSFT wrote:
> >
> > > I haven't seen min/max test failures, prob
CaseyCarter added a comment.
In https://reviews.llvm.org/D33741#769381, @EricWF wrote:
> In https://reviews.llvm.org/D33741#769371, @STL_MSFT wrote:
>
> > I haven't seen min/max test failures, probably because our CRT/STL headers
> > never drag in Windows.h.
>
>
> Ah, that makes sense. Libc++ cu
yawanng updated this revision to Diff 100934.
yawanng edited the summary of this revision.
https://reviews.llvm.org/D33304
Files:
clang-tidy/CMakeLists.txt
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMakeLists.txt
clang-tidy/android/FileOpenFlagCheck.cpp
clang-tidy/andr
EricWF added a comment.
In https://reviews.llvm.org/D33741#769371, @STL_MSFT wrote:
> I haven't seen min/max test failures, probably because our CRT/STL headers
> never drag in Windows.h.
Ah, that makes sense. Libc++ currently does although the plan is to fix that
eventually. :-S
> I have no
STL_MSFT added a comment.
I haven't seen min/max test failures, probably because our CRT/STL headers
never drag in Windows.h.
I have no objection to undeffing min/max although I wouldn't do this myself (it
creates order dependencies which I think are totally evil).
https://reviews.llvm.org/D3
EricWF created this revision.
After changing libc++ to push/pop the min/max macros on Windows we have a bunch
of new test failures, caused by tests using min/max. I would like to use
test_macros.h to undefine it.
Would this work for you? How have you been dealing with these failures?
https:/
joerg added a comment.
sysroot is already handled in NetBSD.cpp line 118 or so.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joerg added a comment.
Such knowledge is necessary anyway. There is enough software that wants to use
the linker directly.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
yawanng updated this revision to Diff 100928.
yawanng added a comment.
Split the commit to three ones that each of them contains one. This is the
first part.
https://reviews.llvm.org/D33304
Files:
clang-tidy/CMakeLists.txt
clang-tidy/android/AndroidTidyModule.cpp
clang-tidy/android/CMake
chapuni added a comment.
I don't think this would be ready to land.
https://reviews.llvm.org/D32595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Ah. I see what you're saying. I was thinking of the mismatch in a different
way, but your solution makes sense. LGTM.
https://reviews.llvm.org/D32595
krytarowski added a comment.
Regardless of LLD, `--sysroot` is still needed I think.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: ericwf
Date: Wed May 31 17:20:42 2017
New Revision: 304364
URL: http://llvm.org/viewvc/llvm-project?rev=304364&view=rev
Log:
Fix silly mistakes in recent changes made to coroutine test
Modified:
libcxx/trunk/test/std/experimental/language.support/support.coroutines/end.to.end/fullexp
atanasyan added a comment.
In https://reviews.llvm.org/D33726#769301, @joerg wrote:
> I'm against it. I consider this a strong bug on the LLD side and the behavior
> of clang correct.
Do you suggest to add knowledge about various OS (linux/*bsd) and arch
(x86,arm,mips,...) specific paths to t
Author: ericwf
Date: Wed May 31 17:14:05 2017
New Revision: 304360
URL: http://llvm.org/viewvc/llvm-project?rev=304360&view=rev
Log:
Fix Libc++ build with MinGW64
Summary: This patch corrects the build errors I encountered when building on
MinGW64.
Reviewers: mati865, rnk, compnerd, smeenai, bc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304360: Fix Libc++ build with MinGW64 (authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D33082?vs=100358&id=100926#toc
Repository:
rL LLVM
https://reviews.llvm.org/D33082
Files
joerg added a comment.
I'm against it. I consider this a strong bug on the LLD side and the behavior
of clang correct.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
EricWF closed this revision.
EricWF added a comment.
Committed as r304359.
Repository:
rL LLVM
https://reviews.llvm.org/D33178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed May 31 17:11:42 2017
New Revision: 304359
URL: http://llvm.org/viewvc/llvm-project?rev=304359&view=rev
Log:
Remove requirement for libunwind sources. Patch by Shiz.
As per r241993, libunwind_ext.h is not used anymore, and thus only the public
libunwind includes are neede
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304357: [Libc++] Use #pragma push_macro/pop_macro to better
handle min/max on Windows (authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D33080?vs=100361&id=100925#toc
Repository:
Author: ericwf
Date: Wed May 31 17:07:49 2017
New Revision: 304357
URL: http://llvm.org/viewvc/llvm-project?rev=304357&view=rev
Log:
[Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows
Summary:
This patch improves how libc++ handles min/max macros within the headers.
Pr
vsk added a comment.
Thanks for the review! I've rebased the patch and plan on checking it in
tomorrow. At the moment I'm getting some additional test coverage (running
check-libcxx and testing more backends).
https://reviews.llvm.org/D33305
___
c
EricWF accepted this revision.
EricWF added a comment.
LGTM.
https://reviews.llvm.org/D33080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Wed May 31 16:39:54 2017
New Revision: 304352
URL: http://llvm.org/viewvc/llvm-project?rev=304352&view=rev
Log:
Guard against more macros in tchar.h
Modified:
libcxx/trunk/test/support/nasty_macros.hpp
Modified: libcxx/trunk/test/support/nasty_macros.hpp
URL:
http://llv
Author: ericwf
Date: Wed May 31 16:34:43 2017
New Revision: 304351
URL: http://llvm.org/viewvc/llvm-project?rev=304351&view=rev
Log:
Transform the libc++ coroutine shell tests into normal .pass.cpp tests.
The shell test versions didn't get all of the flags normal tests
do, specifically warning fl
Author: ericwf
Date: Wed May 31 16:20:18 2017
New Revision: 304348
URL: http://llvm.org/viewvc/llvm-project?rev=304348&view=rev
Log:
Remove uses of _UI because Windows is evil and tchar.h #define's it
Modified:
libcxx/trunk/include/algorithm
libcxx/trunk/include/random
libcxx/trunk/te
rsmith added a comment.
My feeling is that there's not much value in adding an LLVM intrinsic for
something that can be expressed directly in a handful of IR instructions; those
instructions seem like the way to express this that would allow the most
optimization potential, and the backend shou
Author: rsmith
Date: Wed May 31 15:56:55 2017
New Revision: 304346
URL: http://llvm.org/viewvc/llvm-project?rev=304346&view=rev
Log:
[modules] When compiling a preprocessed module map, look for headers relative
to the original module map.
Also use the path and name of the original module map when
rnk added a comment.
Darn, I think Richard is right, the signed div/mod doesn't do the right thing
for negative values. Honestly I need to rig up a test case for this, and then
I'll come back to it.
What do you folks think is best:
- Add an LLVM intrinsic for this and use it
- Use inline assem
ahatanak created this revision.
Currently, clang prints the same warning message "this function declaration is
not a prototype" for non-prototype declarations of blocks and normal functions.
This commit makes changes needed to print a more accurate warning "this block
declaration is not a proto
Author: rnk
Date: Wed May 31 15:42:43 2017
New Revision: 304345
URL: http://llvm.org/viewvc/llvm-project?rev=304345&view=rev
Log:
[clang-cl] Expose -nostdinc and -nobuiltininc
These are already wired up to work in the MSVC toolchain header search
code. However, they were unreachable from clang-cl
echristo added inline comments.
Comment at: include/clang/Basic/Attr.td:1790-1794
+// target features respectively.
+if (Feature.compare("arm") == 0)
+ Ret.first.push_back("-thumb-mode");
+else if (Feature.compare("thumb") == 0)
+ Ret.fir
Author: rnk
Date: Wed May 31 15:07:36 2017
New Revision: 304337
URL: http://llvm.org/viewvc/llvm-project?rev=304337&view=rev
Log:
Fix cl-diagnostics.c test by hardcoding the version of MSVC to mimic
Modified:
cfe/trunk/test/Driver/cl-diagnostics.c
Modified: cfe/trunk/test/Driver/cl-diagnosti
Author: rnk
Date: Wed May 31 15:02:27 2017
New Revision: 304336
URL: http://llvm.org/viewvc/llvm-project?rev=304336&view=rev
Log:
Add test case for r304316 which implemented clang-cl /diagnostics:*
Added:
cfe/trunk/test/Driver/cl-diagnostics.c
Added: cfe/trunk/test/Driver/cl-diagnostics.c
UR
Author: rnk
Date: Wed May 31 14:59:41 2017
New Revision: 304335
URL: http://llvm.org/viewvc/llvm-project?rev=304335&view=rev
Log:
Don't try to spill static allocas when emitting expr cleanups with branches
Credit goes to Gor Nishanov for putting together the fix in
https://reviews.llvm.org/D33733
rnk accepted this revision.
rnk added inline comments.
This revision is now accepted and ready to land.
Comment at: test/CodeGenCoroutines/coro-await-domination.cpp:33
+ int x = 42;
+ x = co_await A{};
+}
rnk wrote:
> It looks like this is the expression in que
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:83
+
+ Finds copy constructors where the ctor don't call the constructor of the
base class.
+
I think will be good idea to replace ctor with constructor. Or re-phrase
sentence to avoid rep
tstellar added a comment.
In https://reviews.llvm.org/D32595#769044, @beanz wrote:
> Is this really something we should be supporting? Building and testing clang
> with potentially out-of-sync lit or gtest seems undesirable to me.
This is actually what this patch is trying to avoid. For exam
rsmith added a comment.
In https://reviews.llvm.org/D33398#769152, @rnk wrote:
> Isn't there a space in the mangling for vendor extensions? Can we use that
> here?
We are using that here: that's what `mangleVendorQualifier` does.
Comment at: lib/AST/ItaniumMangle.cpp:2210
+
Author: ericwf
Date: Wed May 31 14:36:59 2017
New Revision: 304331
URL: http://llvm.org/viewvc/llvm-project?rev=304331&view=rev
Log:
[coroutines] Fix assertion during -Wuninitialized analysis
Summary: @rsmith Is there a better place to put this test?
Reviewers: GorNishanov, rsmith
Reviewed By:
rnk added a comment.
This was filed as https://bugs.llvm.org/show_bug.cgi?id=33178
Isn't there a space in the mangling for vendor extensions? Can we use that here?
https://reviews.llvm.org/D33398
___
cfe-commits mailing list
cfe-commits@lists.llvm.
JonasToth added a comment.
In https://reviews.llvm.org/D31370#768684, @baloghadamsoftware wrote:
> The matcher in https://reviews.llvm.org/D33537 could be reused here as well.
> Maybe I should make it common, but it is more complex than any of the common
> matchers.
yes, the matcher seems int
mgorny added a comment.
(note that I don't mind removing the llvm-config bit for it; but we need the
cache variable to stay)
https://reviews.llvm.org/D32595
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
mgorny added a comment.
This is going to break Gentoo. We're relying on the ability to specify
LLVM_MAIN_SRC_DIR to provide unpacked LLVM sources with gtest. Without that, I
don't see how we can use tests.
https://reviews.llvm.org/D32595
___
cfe-c
rnk added inline comments.
Comment at: test/CodeGenCoroutines/coro-await-domination.cpp:33
+ int x = 42;
+ x = co_await A{};
+}
It looks like this is the expression in question. This expression should have
aggregate evaluation kind, not scalar. We don't need t
Author: ctopper
Date: Wed May 31 14:01:22 2017
New Revision: 304326
URL: http://llvm.org/viewvc/llvm-project?rev=304326&view=rev
Log:
[TableGen] Clang changes to support Record::getValueAsString and
getValueAsListOfStrings returning StringRef instead of std::string
This is the clang version of D
This revision was automatically updated to reflect the committed changes.
Closed by commit rL304326: [TableGen] Clang changes to support
Record::getValueAsString and… (authored by ctopper).
Changed prior to commit:
https://reviews.llvm.org/D33711?vs=100826&id=100906#toc
Repository:
rL LLVM
Author: davide
Date: Wed May 31 13:51:36 2017
New Revision: 304322
URL: http://llvm.org/viewvc/llvm-project?rev=304322&view=rev
Log:
[CodeGen] Surround assertion with parens and format.
This should placate GCC7 with -Werror.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/tr
ABataev created this revision.
If the first parameter of the function is the ImplicitParamDecl codegen
automatically marks it as an implicit argument with `this` or `self`
pointer. To fix this problem Implicit ThisOrSelfAttr is added. This
attribute is used to mark real `this` or `self` pointers o
yaxunl updated this revision to Diff 100899.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Remove redundant code.
https://reviews.llvm.org/D33706
Files:
lib/Basic/Targets.cpp
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGDecl.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFun
krytarowski added a comment.
This works for me!
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov created this revision.
This is a follow up for the https://reviews.llvm.org/rL297084 which made sure
that dominance is preserved during expression cleanup emission.
We ran into a case where dominance fixup code was inserting the store in the
middle of allocas.
%x = alloca i32, ali
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1107
assert(T.getAddressSpace() == LangAS::Default);
if (getASTAllocaAddressSpace() != LangAS::Default) {
auto *Addr = getTargetHooks().performAddrSpaceCast(
-
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
This all looks great. I'm really excited to have such a complete toolchain
build example in-tree. Thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D32817
__
GorNishanov added inline comments.
Comment at: lib/CodeGen/CGCleanup.cpp:458
InsertBefore = Invoke->getNormalDest()->getFirstInsertionPt();
+else if (isa(Inst))
+ InsertBefore = std::next(AllocaInsertPt->getIterator());
rnk wrote:
> This doesn't s
szdominik updated this revision to Diff 100892.
szdominik added a comment.
Update with fixed docs.
https://reviews.llvm.org/D33722
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/UndelegatedCopyOfBaseClassesCheck.cpp
clang-tidy/misc/UndelegatedCo
beanz added a comment.
Is this really something we should be supporting? Building and testing clang
with potentially out-of-sync lit or gtest seems undesirable to me.
It is worth noting that we do have mods to gtest, so supporting any standard
distribution of it seems like a not great idea. The
sepavloff created this revision.
Bitwise complement applied to vector of floats described with
attribute `ext_vector_type` is not diagnosed as error. Attempt to
compile such construct causes assertion violation in Instruction.cpp.
With this change the complement is treated similar to the case of
v
efriedma added reviewers: t.p.northover, efriedma.
efriedma added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:569
+ if (Triple.getEnvironment() == llvm::Triple::EABI) {
+switch (Triple.getArch()) {
Specifically checking for "llvm::Triple::
GorNishanov updated this revision to Diff 100889.
GorNishanov added a comment.
Make sure that we use AllocaInsertPt for only static allocas in the entry block
https://reviews.llvm.org/D33663
Files:
lib/CodeGen/CGCleanup.cpp
test/CodeGenCoroutines/coro-await-domination.cpp
Index: test/Code
Anastasia added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1107
assert(T.getAddressSpace() == LangAS::Default);
if (getASTAllocaAddressSpace() != LangAS::Default) {
auto *Addr = getTargetHooks().performAddrSpaceCast(
Is this code still needed
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D32604
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
alexfh added a comment.
In https://reviews.llvm.org/D33304#768961, @yawanng wrote:
> In https://reviews.llvm.org/D33304#768731, @alexfh wrote:
>
> > It's awesome to see another two checks, and it seems to justify adding a
> > separate module, but I'd prefer the other two checks to be sent for re
rnk added inline comments.
Comment at: lib/CodeGen/CGCleanup.cpp:458
InsertBefore = Invoke->getNormalDest()->getFirstInsertionPt();
+else if (isa(Inst))
+ InsertBefore = std::next(AllocaInsertPt->getIterator());
This doesn't seem right, `Inst` cou
Author: rnk
Date: Wed May 31 12:37:49 2017
New Revision: 304316
URL: http://llvm.org/viewvc/llvm-project?rev=304316&view=rev
Log:
[clang-cl] Implement /diagnostic: flag
This flag has three possible values: caret, column, and classic.
"caret" corresponds to clang's default mode, "column" removes
yawanng added a comment.
In https://reviews.llvm.org/D33304#768731, @alexfh wrote:
> It's awesome to see another two checks, and it seems to justify adding a
> separate module, but I'd prefer the other two checks to be sent for review as
> separate patches to make the review easier and faster.
zaks.anna accepted this revision.
zaks.anna added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/StaticAnalyzer/Core/BugReporter.cpp:1674
const Decl *D = CalleeLC->getDecl();
-addEdgeToPath(PD.getActivePath(), PrevLoc,
-
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
Comment at: docs/clang-tidy/checks/misc-undelegated-copy-of-base-classes.rst:29
+
+The checker suggests a FixItHint in every scenario including multiple
+missing initial
MatzeB accepted this revision.
MatzeB added a comment.
I assume you have checked that the tablegen output doesn't change. Apart from
that I'm all for more StringRef and SmallStrings or even Twines where possible.
So LGTM.
https://reviews.llvm.org/D33711
_
krytarowski added inline comments.
Comment at: lib/Driver/ToolChains/NetBSD.cpp:324
: Generic_ELF(D, Triple, Args) {
if (getDriver().UseStdLib) {
// When targeting a 32-bit platform, try the special directory used on
What's the rationale for this con
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D33698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
krytarowski added a comment.
Looks great! I'm going to test it.
Repository:
rL LLVM
https://reviews.llvm.org/D33726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 134 matches
Mail list logo
