Author: ericwf
Date: Fri May 5 00:19:21 2017
New Revision: 302213
URL: http://llvm.org/viewvc/llvm-project?rev=302213&view=rev
Log:
Document XFAIL's with the relevent bug number
Modified:
libcxx/trunk/test/std/numerics/rand/rand.device/ctor.pass.cpp
libcxx/trunk/test/std/numerics/rand/ra
bcraig added a comment.
I'm still working on this.
Things I've learned: A clang install is bundled with re-implementations of
several of these headers. The default #include_next behavior ends up pulling
in lots of those.
I have been able to get things working with a VC include path and a UCRT
erik.pilkington created this revision.
This patch adds Objective-C interfaces support for the type trait `is_base_of`,
so that `__is_base_of(NSString, NSMutableString)` is true.
rdar://24308607
Thanks for taking a look!
Erik
https://reviews.llvm.org/D32891
Files:
lib/Sema/SemaExprCXX.cpp
eugenis added inline comments.
Comment at: include/clang/Driver/Options.td:830
HelpText<"Disable use-after-scope
detection in AddressSanitizer">;
+def fsanitize_address_globals_live_support : Flag<["-"],
"fsanitize-address-globals-liv
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
Generally makes sense. A question about the name. Feel free to land with a name
that you and other sanitizer folks are happy with.
Comment at: include/clang/Driver/Opt
eugenis updated this revision to Diff 97901.
Repository:
rL LLVM
https://reviews.llvm.org/D32886
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/BackendUtil.cpp
lib/Driver/SanitizerArgs.cpp
lib/Fronte
eugenis created this revision.
This feature is subtly broken when the linker is gold 2.26 or
earlier. See the following bug for details:
https://sourceware.org/bugzilla/show_bug.cgi?id=19002
Since the decision needs to be made at compilation time, we can not
test the linker version. The flag i
Author: jroelofs
Date: Thu May 4 19:18:27 2017
New Revision: 302207
URL: http://llvm.org/viewvc/llvm-project?rev=302207&view=rev
Log:
Document that Multilib flags must be actual flags
This is because -print-multi-lib depends on them being flags for correctness.
Fixes a case of this in the arm-a
On May 4, 2017 4:55 PM, "Nico Weber via Phabricator" <
revi...@reviews.llvm.org> wrote:
thakis created this revision.
Herald added a subscriber: javed.absar.
https://reviews.llvm.org/D32879
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaDeclAttr.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302195: Fix whitespace before token-paste of an argument.
(authored by jyknight).
Changed prior to commit:
https://reviews.llvm.org/D30427?vs=89918&id=97881#toc
Repository:
rL LLVM
https://reviews.l
Author: jyknight
Date: Thu May 4 16:31:17 2017
New Revision: 302195
URL: http://llvm.org/viewvc/llvm-project?rev=302195&view=rev
Log:
Fix whitespace before token-paste of an argument.
The whitespace should come from the argument name in the macro
expansion, rather than from the token passed to t
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D32879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
thakis created this revision.
Herald added a subscriber: javed.absar.
https://reviews.llvm.org/D32879
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaDeclAttr.cpp
test/Parser/MicrosoftExtensions.cpp
test/Parser/ms-square-bracket-attributes.mm
Author: malaperle
Date: Thu May 4 14:57:53 2017
New Revision: 302191
URL: http://llvm.org/viewvc/llvm-project?rev=302191&view=rev
Log:
[clangd] Add documentation page
Summary:
Add a simple documentation page for Clangd.
This will be useful for interested users and contributors to get basic
info
Author: nico
Date: Thu May 4 14:54:50 2017
New Revision: 302190
URL: http://llvm.org/viewvc/llvm-project?rev=302190&view=rev
Log:
Turn on -Wmicrosoft-enum-forward-reference by default.
clang-cl already errs or warns on everything that cl
warns on in /permissive- mode, except for enum foward
decl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302188: Fix bugs checking va_start in lambdas and erroneous
contexts (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D32761?vs=97503&id=97868#toc
Repository:
rL LLVM
https://rev
Author: rnk
Date: Thu May 4 14:51:05 2017
New Revision: 302188
URL: http://llvm.org/viewvc/llvm-project?rev=302188&view=rev
Log:
Fix bugs checking va_start in lambdas and erroneous contexts
Summary:
First, getCurFunction looks through blocks and lambdas, which is wrong.
Inside a lambda, va_start
Author: nico
Date: Thu May 4 14:36:26 2017
New Revision: 302187
URL: http://llvm.org/viewvc/llvm-project?rev=302187&view=rev
Log:
Turn -Wmicrosoft-enum-value off by default.
The warning is currently way too noisy to be useful. The plan is
to make it warn when an MS enum that's negative is compar
AndreiGrischenko updated this revision to Diff 97866.
AndreiGrischenko added a comment.
Thanks Craig for the good advice. You are right I can check llc with MCU triple
using option -use-ctors. Please see updated patch.
https://reviews.llvm.org/D32543
Files:
llvm/lib/Target/X86/X86TargetMachi
Author: compnerd
Date: Thu May 4 14:18:21 2017
New Revision: 302184
URL: http://llvm.org/viewvc/llvm-project?rev=302184&view=rev
Log:
Driver: only inject libstdc++ paths when needed on CrossWindows
When building with libc++ don't bother with injecting the libstdc++
search paths into the linker s
Author: ericwf
Date: Thu May 4 14:13:28 2017
New Revision: 302182
URL: http://llvm.org/viewvc/llvm-project?rev=302182&view=rev
Log:
Fix test failure with GCC 4.9
Modified:
libcxx/trunk/test/support/test.workarounds/c1xx_broken_is_trivially_copyable.pass.cpp
Modified:
libcxx/trunk/test/sup
Author: ericwf
Date: Thu May 4 14:04:50 2017
New Revision: 302181
URL: http://llvm.org/viewvc/llvm-project?rev=302181&view=rev
Log:
Change Appveyor to download Clang from llvm.org instead of my private server
Modified:
libcxx/trunk/appveyor.yml
libcxx/trunk/install-appveyor-reqs.cmd
Mod
JonasToth added a comment.
this check is somewhat duplicated to a check currently in review, which seemed
to be abondened?
https://reviews.llvm.org/D19201
I will read that one first and try to coordinate with the author.
Repository:
rL LLVM
https://reviews.llvm.org/D31370
__
sbarzowski updated this revision to Diff 97859.
sbarzowski added a comment.
Herald added a subscriber: xazax.hun.
Fixed false positive issues
https://reviews.llvm.org/D19201
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/ThrowWithNoexceptCheck.cpp
Author: rnk
Date: Thu May 4 13:19:52 2017
New Revision: 302179
URL: http://llvm.org/viewvc/llvm-project?rev=302179&view=rev
Log:
[ms-inline-asm] Use the frontend size only for ambiguous instructions
This avoids problems on code like this:
char buf[16];
__asm {
movups xmm0, [buf]
mov
Author: pcc
Date: Thu May 4 13:03:25 2017
New Revision: 302176
URL: http://llvm.org/viewvc/llvm-project?rev=302176&view=rev
Log:
Re-apply r302108, "IR: Use pointers instead of GUIDs to represent edges in the
module summary. NFCI."
with a fix for the clang backend.
Modified:
cfe/trunk/lib/Co
Hahnfeld added a comment.
One minor drive-by comment. I think there is still one outstanding from
Justin...
Comment at: lib/Driver/ToolChains/Cuda.cpp:368
+ assert(!GpuArch.empty() && "Must have an explicit GPU arch.");
+ std::string LibDeviceFile;
You can
Author: marshall
Date: Thu May 4 11:36:39 2017
New Revision: 302168
URL: http://llvm.org/viewvc/llvm-project?rev=302168&view=rev
Log:
Use lgamma_r instead of lgamma in binomial_distribution, because freakin' POSIX
took a perfectly fine call and made it not thread safe.
Modified:
libcxx/tru
EricWF added a comment.
> libc++ committed to ABI stability for optional, a new feature of C++17,
> before the standard shipped?
Libc++ doesn't commit to anything, the vendors such as Apple and FreeBSD do. I
don't think either of them
have shipped a release with std::optional yet, but I need to
erik.pilkington added a comment.
Hi Alex, thanks for working on this! This looks right, but I have a couple of
comments.
Thanks,
Erik
Comment at: lib/Sema/SemaDeclAttr.cpp:7151
+Visitor.Scope = Scope;
+Visitor.TraverseStmt(const_cast(Scope));
+return Visitor.LastMa
Author: alexfh
Date: Thu May 4 11:06:08 2017
New Revision: 302164
URL: http://llvm.org/viewvc/llvm-project?rev=302164&view=rev
Log:
[clang-tidy] fix readability-implicit-bool-cast false positive with xor
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302162: [test] Name the local variable in the C1XX
implementation of DoNotOptmize (authored by CaseyCarter).
Changed prior to commit:
https://reviews.llvm.org/D32510?vs=96648&id=97837#toc
Repository:
Author: caseycarter
Date: Thu May 4 10:54:09 2017
New Revision: 302162
URL: http://llvm.org/viewvc/llvm-project?rev=302162&view=rev
Log:
[test] Name the local variable in the C1XX implementation of DoNotOptmize
Differential Revision: https://reviews.llvm.org/D32510
Modified:
libcxx/trunk/te
CaseyCarter added a comment.
In https://reviews.llvm.org/D32385#745771, @EricWF wrote:
> So Itanium ABI has this quirk where trivial types are passed using different
> conventions than non-trivial types. This means changing the triviality of
> `std::optional` for any instantiation is potentiall
CaseyCarter updated this revision to Diff 97834.
CaseyCarter added a comment.
The constexpr variant tests were enabled separate commit
(https://reviews.llvm.org/rL302158). This differential now contains only the
fine-grained SMF triviality extension test.
https://reviews.llvm.org/D32671
Files
Author: alexfh
Date: Thu May 4 10:34:31 2017
New Revision: 302161
URL: http://llvm.org/viewvc/llvm-project?rev=302161&view=rev
Log:
[clang-tidy] fix readability-implicit-bool-cast false alarm on |=, &=
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
cla
Author: alexfh
Date: Thu May 4 10:34:23 2017
New Revision: 302160
URL: http://llvm.org/viewvc/llvm-project?rev=302160&view=rev
Log:
[clang-tidy] Code cleanup, (almost) NFC (*).
(*) Printed types of member pointers don't use elaborated type specifiers
(`int struct S::*` -> `int S::*`).
Modified:
Author: alexfh
Date: Thu May 4 10:34:06 2017
New Revision: 302159
URL: http://llvm.org/viewvc/llvm-project?rev=302159&view=rev
Log:
[Tooling] add a createReplacement overload for StringRef
Modified:
cfe/trunk/include/clang/Tooling/FixIt.h
Modified: cfe/trunk/include/clang/Tooling/FixIt.h
UR
Author: caseycarter
Date: Thu May 4 10:32:54 2017
New Revision: 302158
URL: http://llvm.org/viewvc/llvm-project?rev=302158&view=rev
Log:
[test] variant: enable constexpr construction tests on MSVC STL
* Add a new macro _MSVC_STL_VER to detect when the MSVC STL is being tested
* Workaround C1XX _
craig.topper added a comment.
It looksl ike UseInitArray is connected to -use-ctors command line option to
llc so we should be able to test this without a frontend test.
https://reviews.llvm.org/D32543
___
cfe-commits mailing list
cfe-commits@lists
craig.topper added a comment.
Should we add a test to test/CodeGen/X86/constructor.ll that test appears to
have been modified when NAcl was added to the line you changed.
https://reviews.llvm.org/D32543
___
cfe-commits mailing list
cfe-commits@li
Author: mprobst
Date: Thu May 4 10:04:04 2017
New Revision: 302156
URL: http://llvm.org/viewvc/llvm-project?rev=302156&view=rev
Log:
clang-format: [JS] exponentiation operator
Summary: While its precedence should be higher than multiplicative, LLVM does
not have a level for that, so for the tim
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302156: clang-format: [JS] exponentiation operator (authored
by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D32864?vs=97829&id=97830#toc
Repository:
rL LLVM
https://reviews.llvm.org/
djasper accepted this revision.
djasper added a comment.
Thanks
https://reviews.llvm.org/D32864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mprobst updated this revision to Diff 97829.
mprobst added a comment.
- support **=
https://reviews.llvm.org/D32864
Files:
lib/Format/FormatToken.h
lib/Format/FormatTokenLexer.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
yaxunl added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:8301
+def err_opencl_sampler_qualifier : Error<
+ "global sampler requires a const qualifier">;
def err_opencl_cast_non_zero_to_event_t : Error<
global sampler requires a const
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: unittests/Format/FormatTestJS.cpp:1791
+TEST_F(FormatTestJS, Exponentiation) {
+ verifyFormat("squared = x ** 2;");
+}
Also make this hand
mprobst created this revision.
Herald added a subscriber: klimek.
While its precedence should be higher than multiplicative, LLVM does not have a
level for that, so for the time being just treat it as multiplicative.
https://reviews.llvm.org/D32864
Files:
lib/Format/FormatToken.h
lib/Forma
On 4 May 2017 at 12:52, Alex L wrote:
>
>
> On 4 May 2017 at 12:43, Alex L wrote:
>
>>
>>
>> On 3 May 2017 at 22:23, Richard Smith wrote:
>>
>>> On 3 May 2017 at 07:29, Alex L wrote:
>>>
Hi Richard,
This commit has caused an infinite loop in one of our internal libclang
bas
Author: arphaman
Date: Thu May 4 08:56:51 2017
New Revision: 302151
URL: http://llvm.org/viewvc/llvm-project?rev=302151&view=rev
Log:
DiagnosticsEngine should clear DelayedDiagID before reporting the
delayed diagnostic
This fix avoids an infinite recursion that was uncovered in one of our intern
baloghadamsoftware created this revision.
Extension of the mismatched iterator checker for constructors taking range of
first..last (first and last must be iterators of the same container) and also
for comparisons of iterators of different containers (one does not compare
iterators of different
Author: sylvestre
Date: Thu May 4 07:46:38 2017
New Revision: 302143
URL: http://llvm.org/viewvc/llvm-project?rev=302143&view=rev
Log:
Add support of the next Ubuntu (Ubuntu 17.10 - Artful Aardvark)
Modified:
cfe/trunk/include/clang/Driver/Distro.h
cfe/trunk/lib/Driver/Distro.cpp
Modif
baloghadamsoftware created this revision.
If a container is moved by its move assignment operator, according to the
standard all their iterators except the past-end iterators remain valid but
refer to the new container. This patch introduces support for this case in the
iterator checkers.
htt
Author: ioeric
Date: Thu May 4 07:05:40 2017
New Revision: 302141
URL: http://llvm.org/viewvc/llvm-project?rev=302141&view=rev
Log:
Revert "IR: Use pointers instead of GUIDs to represent edges in the module
summary. NFCI."
This reverts commit r302108.
Modified:
cfe/trunk/lib/CodeGen/Backen
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:478-479
+auto &SymMgr = C.getSymbolManager();
+EndSym = SymMgr.conjureSymbol(CE, C.getLocationContext(),
+ C.getASTContext().LongTy, C.blockCount());
+
On 4 May 2017 at 12:43, Alex L wrote:
>
>
> On 3 May 2017 at 22:23, Richard Smith wrote:
>
>> On 3 May 2017 at 07:29, Alex L wrote:
>>
>>> Hi Richard,
>>>
>>> This commit has caused an infinite loop in one of our internal libclang
>>> based tooling tests. It keeps repeating the following frames
On 3 May 2017 at 22:23, Richard Smith wrote:
> On 3 May 2017 at 07:29, Alex L wrote:
>
>> Hi Richard,
>>
>> This commit has caused an infinite loop in one of our internal libclang
>> based tooling tests. It keeps repeating the following frames:
>>
>> frame #33528: 0x000109db2edf libclang
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/IteratorChecker.cpp:211-214
+std::pair
+createDifference(SymbolManager &SymMgr, SymbolRef Sym1, SymbolRef Sym2);
+const llvm::APSInt *getDifference(ProgramStateRef State, SymbolRef Sym1,
+
Author: arphaman
Date: Thu May 4 05:42:06 2017
New Revision: 302136
URL: http://llvm.org/viewvc/llvm-project?rev=302136&view=rev
Log:
[Index] The relation between the declarations in template
specializations that 'override' declarations in the base template should use
the 'specializationOf' relat
svenvh created this revision.
Patch by Simon Perretta.
https://reviews.llvm.org/D32856
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/sampler_t.cl
Index: test/SemaOpenCL/sampler_t.cl
===
NoQ added a comment.
I see the checker going towards what we call "metadata symbols", which seems
logical.
I still feel the checker deserves a lot more comments around the code. In
particular, i'd definitely love to see a human-readable explanation of what
kinds of iterators are supported (fro
EricWF added inline comments.
Comment at: test/std/strings/basic.string/string.cons/T_size_size.pass.cpp:39
assert(pos <= sv.size());
-unsigned rlen = std::min(sv.size() - pos, n);
+unsigned rlen = std::min(static_cast(sv.size()) - pos, n);
asser
BillyONeal added inline comments.
Comment at: test/std/strings/basic.string/string.cons/T_size_size.pass.cpp:39
assert(pos <= sv.size());
-unsigned rlen = std::min(sv.size() - pos, n);
+unsigned rlen = std::min(static_cast(sv.size()) - pos, n);
a
BillyONeal added inline comments.
Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:146
+auto res = std::gcd(static_cast(1234), INT32_MIN);
+static_assert(std::is_same>::value, "");
assert(res == 2);
EricWF wrote:
> `
Author: sam_parker
Date: Thu May 4 03:37:59 2017
New Revision: 302131
URL: http://llvm.org/viewvc/llvm-project?rev=302131&view=rev
Log:
[ARM] ACLE Chapter 9 intrinsics
Implemented the remaining integer data processing intrinsics from
the ARM ACLE v2.1 spec, such as parallel arithemtic and DSP st
xazax.hun updated this revision to Diff 97790.
xazax.hun added a comment.
- Fixed include order.
https://reviews.llvm.org/D32743
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/PostfixOperatorCheck.cpp
clang-tidy/cert/PostfixOperatorCheck.h
doc
xazax.hun updated this revision to Diff 97789.
xazax.hun marked 21 inline comments as done.
xazax.hun added a comment.
- Fixes according to the review comments.
https://reviews.llvm.org/D32743
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/Postfix
EricWF added a comment.
So Itanium ABI has this quirk where trivial types are passed using different
conventions than non-trivial types. This means changing the triviality of
`std::optional` for any instantiation is potentially ABI breaking. I'll need to
do more investigation to find out how th
EricWF added inline comments.
Comment at: test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp:146
+auto res = std::gcd(static_cast(1234), INT32_MIN);
+static_assert(std::is_same>::value, "");
assert(res == 2);
`std::common_type` he
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Could you add a separate test that performs direct-list-init of fixed enums
from integers, and XFAIL it accordingly? Testing it found a bug, so I don't
want to complete eliminate that test co
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Oops. Thanks for the fix.
https://reviews.llvm.org/D32510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
EricWF added a comment.
Could you commit all the changes *except* the trivial extensions tests, and
then update this to contain only that?
https://reviews.llvm.org/D32671
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing inline comments.
Comment at: test/std/strings/basic.string/string.cons/T_size_size.pass.cpp:39
assert(pos <= sv.size());
-unsigned rlen
EricWF added a comment.
LGTM minus inline comments.
https://reviews.llvm.org/D32727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at:
test/std/iterators/stream.iterators/istream.iterator/types.pass.cpp:42
#include
int main()
Needs `#include "test_macros.h"`
=
Author: ericwf
Date: Thu May 4 02:45:09 2017
New Revision: 302129
URL: http://llvm.org/viewvc/llvm-project?rev=302129&view=rev
Log:
Fix incorrect usage of __libcpp_mutex_trylock. Patch from Andrey Khalyavin
Modified:
libcxx/trunk/src/memory.cpp
Modified: libcxx/trunk/src/memory.cpp
URL:
ht
Author: ericwf
Date: Thu May 4 02:40:23 2017
New Revision: 302128
URL: http://llvm.org/viewvc/llvm-project?rev=302128&view=rev
Log:
Update Appveyor bot link to point to new llvm-mirror Appveyor account
Modified:
libcxx/trunk/docs/index.rst
Modified: libcxx/trunk/docs/index.rst
URL:
http://
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302125: [OpenCL] Add intel_reqd_sub_group_size attribute
support (authored by pxl).
Changed prior to commit:
https://reviews.llvm.org/D30805?vs=97772&id=97786#toc
Repository:
rL LLVM
https://reviews
Author: pxl
Date: Thu May 4 02:31:20 2017
New Revision: 302125
URL: http://llvm.org/viewvc/llvm-project?rev=302125&view=rev
Log:
[OpenCL] Add intel_reqd_sub_group_size attribute support
Summary:
Add intel_reqd_sub_group_size attribute support as intel extension
cl_intel_required_subgroup_size
79 matches
Mail list logo
