Hahnfeld added a comment. One minor drive-by comment. I think there is still one outstanding from Justin...
================ Comment at: lib/Driver/ToolChains/Cuda.cpp:368 + assert(!GpuArch.empty() && "Must have an explicit GPU arch."); + std::string LibDeviceFile; ---------------- You can move the declaration down to the initialization Repository: rL LLVM https://reviews.llvm.org/D29647 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits