Author: rsmith
Date: Tue Feb 21 01:22:31 2017
New Revision: 295698
URL: http://llvm.org/viewvc/llvm-project?rev=295698&view=rev
Log:
When deducing an array bound from the length of an initializer list, don't
assume the bound has a non-dependent integral type.
Modified:
cfe/trunk/lib/Sema/Sema
Author: rsmith
Date: Tue Feb 21 00:30:38 2017
New Revision: 295696
URL: http://llvm.org/viewvc/llvm-project?rev=295696&view=rev
Log:
PR32010: Fix template argument depth mixup when forming implicit constructor
template deduction guides for class template argument deduction.
Ensure that we have a
daphnediane added a comment.
Rebuilt with the latest patch and got one compile error. See line comment
worked okay after fixing it.
Comment at: lib/Format/WhitespaceManager.cpp:215
+
+if (i != Start) {
+ if (Changes[i].nestingAndIndentLevel() >
These
ahatanak added a comment.
In https://reviews.llvm.org/D30174#681843, @arphaman wrote:
> Yes, we do. Primarily for the following reason: even if some target may
> return a struct in a register, another target isn't guaranteed to do the same
> thing. It's better to always warn about this rather t
arphaman created this revision.
This patch adds support for a new `-iframeworkwithsysroot` compiler option
which allows the user to specify a framework path that can be prefixed with the
sysroot.
This option is similar to the `-iwithsysroot` option that exists to supplement
`-isystem`.
Repos
vsk updated this revision to Diff 89151.
vsk retitled this revision from "[profiling] Don't skip non-base constructors
if there is a virtual base (fixes PR31992)" to "[profiling] PR31992: Don't skip
interesting non-base constructors".
vsk edited the summary of this revision.
vsk added a comment.
Author: rsmith
Date: Mon Feb 20 20:04:03 2017
New Revision: 295689
URL: http://llvm.org/viewvc/llvm-project?rev=295689&view=rev
Log:
Add template parameter depth and index to -ast-dump output.
Modified:
cfe/trunk/lib/AST/ASTDumper.cpp
cfe/trunk/test/Misc/ast-dump-decl.cpp
cfe/trunk/te
Author: rsmith
Date: Mon Feb 20 19:17:38 2017
New Revision: 295686
URL: http://llvm.org/viewvc/llvm-project?rev=295686&view=rev
Log:
Factor out function to determine whether we're performing a template
instantiation.
In preparation for converting the template stack to a more general context
stack
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D29819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
compnerd closed this revision.
compnerd added a comment.
SVN r295683
https://reviews.llvm.org/D29967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: compnerd
Date: Mon Feb 20 17:45:49 2017
New Revision: 295683
URL: http://llvm.org/viewvc/llvm-project?rev=295683&view=rev
Log:
Sema: use PropertyDecl for property selector
Using the constructed name for the class properties with dot syntax may
yield an inappropriate selector (i.e. if it i
arphaman added a comment.
In https://reviews.llvm.org/D30174#681801, @ahatanak wrote:
> Do we still issue a warning even when the struct can be returned in a
> register? For example, x86 can return a small struct (for example, a struct
> with one int field) in a single register, in which case i
Hans, could you pull this (and r294954) into release_40, please?
This is a regression from previous releases that clang standalone build
cannot be configured on msbuild.
On Sun, Feb 19, 2017 at 12:29 PM NAKAMURA Takumi via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: chapuni
> Date
ahatanak added inline comments.
Comment at: include/clang/AST/ASTContext.h:1910
+if (T.getQualifiers().hasUnaligned())
+ TI.Align = 8;
+return TI;
Is it better to call TargetInfo::getCharWidth() instead of assigning a
hardcoded number here?
==
ahatanak added a comment.
Do we still issue a warning even when the struct can be returned in a register?
For example, x86 can return a small struct (for example, a struct with one int
field) in a single register, in which case it's fine to pass it to
performSelector via @selector.
If we shoul
> On 2017-Feb-20, at 13:11, Alex Lorenz via Phabricator
> wrote:
>
> arphaman added inline comments.
>
>
>
> Comment at: lib/CodeGen/CodeGenFunction.h:2479
>
> + llvm::Value *EmitObjCIsOSVersionAtLeast(ArrayRef Args);
> +
>
> I think it's better to treat th
arphaman added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.h:2479
+ llvm::Value *EmitObjCIsOSVersionAtLeast(ArrayRef Args);
+
I think it's better to treat this as a builtin in its own right, without
including the ObjC part in the names. This func
hiraditya added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MismatchedIteratorChecker.cpp:375
+ "MismatchedIterator");
+auto *N = C.generateNonFatalErrorNode(State, &Tag);
+if (!N) {
This can be rewritten
arphaman created this revision.
The `performSelector` family of methods from Foundation use `objc_msgSend` to
dispatch the selector invocations to objects. However, method calls to methods
that return record types might have to use the `objc_msgSend_stret` as the
return value won't find into th
Author: arphaman
Date: Mon Feb 20 11:55:15 2017
New Revision: 295674
URL: http://llvm.org/viewvc/llvm-project?rev=295674&view=rev
Log:
[Sema][ObjC] perform-selector ARC check should see @selector in parens
Modified:
cfe/trunk/lib/Sema/SemaExprObjC.cpp
cfe/trunk/test/SemaObjC/arc-peformsel
redm123 added inline comments.
Comment at: test/Misc/diag-template-diffing.cpp:27
// CHECK-ELIDE-NOTREE: no matching function for call to 'f'
-// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from
'vector' to 'vector' for 1st argument
+// CHECK-ELIDE-NO
sepavloff created this revision.
Current implementation of `FunctionDecl::isDefined` does not take into
account declarations that do not have a body, but it can be instantiated
from a templated definition. This behavior creates problems when
processing friend functions defined in class templates.
baloghadamsoftware marked 2 inline comments as done.
baloghadamsoftware added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MismatchedIteratorChecker.cpp:311
+
+void MismatchedIteratorChecker::checkPostStmt(const DeclStmt *DS,
+
baloghadamsoftware updated this revision to Diff 89123.
baloghadamsoftware added a comment.
Updated according to the comments.
https://reviews.llvm.org/D29419
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
lib/StaticAnalyzer/Checkers/Mi
sanwou01 abandoned this revision.
sanwou01 added a comment.
Please see https://reviews.llvm.org/D30167 for an attempt to test this from llc.
https://reviews.llvm.org/D29770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
rogfer01 created this revision.
See related proposal in
http://lists.llvm.org/pipermail/cfe-dev/2017-February/052739.html
This patch honors the unaligned type qualifier (currently available through he
keyword __unaligned and -fms-extensions) in CodeGen. In the current form the
patch affects de
Author: djasper
Date: Mon Feb 20 08:51:16 2017
New Revision: 295663
URL: http://llvm.org/viewvc/llvm-project?rev=295663&view=rev
Log:
clang-format: [JS] Improve line-wrapping behavior of template strings.
Specifically, similar to other blocks, clang-format now wraps both
after "${" and before the
NoQ added a comment.
Yeah, i think this is now as easy as i expected it to be :)
Still, the new API is in need of better documentation, because the notion of
default binding is already confusing, and the new use-case we now have for this
API is even more confusing. I don't instantly see a good
redm123 added inline comments.
Comment at: test/Misc/diag-template-diffing.cpp:27
// CHECK-ELIDE-NOTREE: no matching function for call to 'f'
-// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from
'vector' to 'vector' for 1st argument
+// CHECK-ELIDE-NO
Hahnfeld updated this revision to Diff 89110.
Hahnfeld added a comment.
rebase
https://reviews.llvm.org/D30087
Files:
lib/Driver/Tools.cpp
test/Driver/fopenmp.c
Index: test/Driver/fopenmp.c
===
--- test/Driver/fopenmp.c
+++ te
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/ValistChecker.cpp:178
+VaListModelledAsArray = Cast->getCastKind() == CK_ArrayToPointerDecay;
+ const MemRegion *Reg = SV.getAsRegion();
+ if (const auto *DeclReg = Reg->getAs()) {
I suspect
Author: djasper
Date: Mon Feb 20 06:43:48 2017
New Revision: 295659
URL: http://llvm.org/viewvc/llvm-project?rev=295659&view=rev
Log:
clang-format: Prevent weird line-wraps in complex lambda introducers
Before:
a.(
[a
Author: djasper
Date: Mon Feb 20 06:43:41 2017
New Revision: 295658
URL: http://llvm.org/viewvc/llvm-project?rev=295658&view=rev
Log:
clang-format: [JS/TS] Improve detection for array subscripts in types.
Before:
var someValue = (v as [
]).someFunction(
Hahnfeld updated this revision to Diff 89106.
Hahnfeld marked 3 inline comments as done.
Hahnfeld edited the summary of this revision.
Hahnfeld added a comment.
Address review comment's and apply new naming style to checkNestingOfRegions
https://reviews.llvm.org/D30135
Files:
lib/Sema/SemaOpe
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:1968-1973
+ if (CancelRegion != OMPD_parallel && CancelRegion != OMPD_for &&
+ CancelRegion != OMPD_sections && CancelRegion != OMPD_taskgroup) {
+SemaRef.Diag(StartLoc, diag::err_omp_wrong_cancel_region
Author: a.sidorin
Date: Mon Feb 20 05:57:12 2017
New Revision: 295654
URL: http://llvm.org/viewvc/llvm-project?rev=295654&view=rev
Log:
[ASTImporter] Support default argument initialization of ParmVarDecls
Patch by Peter Szecsi!
Differential Revision: https://reviews.llvm.org/D29612
Modified:
Hahnfeld added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:1968-1973
+ if (CancelRegion != OMPD_parallel && CancelRegion != OMPD_for &&
+ CancelRegion != OMPD_sections && CancelRegion != OMPD_taskgroup) {
+SemaRef.Diag(StartLoc, diag::err_omp_wrong_cancel_regio
With --use-c=gcc and --use-analyzer=clang when run "scan-build" it will use
include<...> of clang , but we need include<...> of gcc. How can I define the
default include path of gcc when I run "scan-build --use-c=gcc
--use-analyzer=clang make" ?___
cfe
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:1959
+static bool CheckCancelRegion(Sema &SemaRef, OpenMPDirectiveKind CurrentRegion,
+ OpenMPDirectiveKind CancelRegion,
Hahnfeld wrote:
> ABataev wrote:
> > Should
Hahnfeld added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:1959
+static bool CheckCancelRegion(Sema &SemaRef, OpenMPDirectiveKind CurrentRegion,
+ OpenMPDirectiveKind CancelRegion,
ABataev wrote:
> Should be `checkCancelReg
ABataev added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:1959
+static bool CheckCancelRegion(Sema &SemaRef, OpenMPDirectiveKind CurrentRegion,
+ OpenMPDirectiveKind CancelRegion,
Should be `checkCancelRegion`
===
Perfect! Thanks!
Anastasia
-Original Message-
From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans
Wennborg
Sent: 16 February 2017 17:22
To: Anastasia Stulova
Cc: cfe-commits@lists.llvm.org
Subject: Re: D29829: [OpenCL][Doc] Description for adding OpenCL vendor
ex
Hahnfeld updated this revision to Diff 89099.
Hahnfeld edited the summary of this revision.
Hahnfeld added a comment.
new static function `CheckCancelRegion`
https://reviews.llvm.org/D30135
Files:
lib/Sema/SemaOpenMP.cpp
test/OpenMP/cancel_messages.cpp
test/OpenMP/cancellation_point_messa
Author: sanwou01
Date: Mon Feb 20 04:37:01 2017
New Revision: 295647
URL: http://llvm.org/viewvc/llvm-project?rev=295647&view=rev
Log:
[ARM] Add regression tests for Cortex-M23 and Cortex-M33
Reviewers: rengolin, t.p.northover
Reviewed By: t.p.northover
Subscribers: aemerson, llvm-commits
Diff
madsravn added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:81
+ Stream << "shuffle(";
+ FirstArgument->printPretty(Stream, nullptr, Ctx.getPrintingPolicy());
+ Stream << ", ";
xazax.hun wrote:
> madsravn wrote:
> > xazax.hun
xazax.hun added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:81
+ Stream << "shuffle(";
+ FirstArgument->printPretty(Stream, nullptr, Ctx.getPrintingPolicy());
+ Stream << ", ";
madsravn wrote:
> xazax.hun wrote:
> > madsravn
madsravn added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:81
+ Stream << "shuffle(";
+ FirstArgument->printPretty(Stream, nullptr, Ctx.getPrintingPolicy());
+ Stream << ", ";
xazax.hun wrote:
> madsravn wrote:
> > xazax.hun
sylvestre.ledru updated this revision to Diff 89094.
sylvestre.ledru added a comment.
Sorry, I tried to rename the file but this is too confusing for Phabricator it
seems...
https://reviews.llvm.org/D30111
Files:
unittests/Format/check-coding-style-mozilla.cpp
Index: unittests/Format/check-
sylvestre.ledru added inline comments.
Comment at: test/Format/check-coding-style-mozilla.cpp:48
+,
+public Y
+{
krasimir wrote:
> sylvestre.ledru wrote:
> > krasimir wrote:
> > > This does not check precisely what the comment says
sylvestre.ledru updated this revision to Diff 89093.
sylvestre.ledru marked 3 inline comments as done.
https://reviews.llvm.org/D30111
Files:
unittests/Format/CheckCodingStyleMozilla.cpp
Index: unittests/Format/CheckCodingStyleMozilla.cpp
===
xazax.hun added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:30
+" The old user defined 'RandomFunction' is not usable for 'shuffle'. You "
+"need to "
+"make additional changes if you want a specific random function.";
-
krasimir added inline comments.
Comment at: test/Format/check-coding-style-mozilla.cpp:10
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+if (true) {
sylvestre.ledru wrote:
> krasimir wrote:
> > What is tested here? Brace styles?
> Yes, do you
madsravn added inline comments.
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:30
+" The old user defined 'RandomFunction' is not usable for 'shuffle'. You "
+"need to "
+"make additional changes if you want a specific random function.";
--
ABataev added a comment.
I see. I think it is better to check the `CancelRegion` just before call of
`CheckNestingOfRegions()` function. You need to extract checks for
`CancelRegion` from `ActOnOpenMPCancellationPointDirective()` and
`ActOnOpenMPCancelDirective()` functions into a standalone fu
klimek added inline comments.
Comment at: test/Format/check-coding-style-mozilla.cpp:7-9
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.
krasimir added a comment.
In https://reviews.llvm.org/D29943#678618, @sylvestre.ledru wrote:
> Maybe this could be added to the release notes?
Sounds good! Could you please point me to the release docs? I don't seem to
find a clang-format--specific section online.
Repository:
rL LLVM
http
xazax.hun added a comment.
Nice check! Thank you for working on this!
Comment at: clang-tidy/modernize/ReplaceRandomShuffleCheck.cpp:30
+" The old user defined 'RandomFunction' is not usable for 'shuffle'. You "
+"need to "
+"make additional changes if you want a sp
Hahnfeld added a comment.
In https://reviews.llvm.org/D30135#681354, @ABataev wrote:
> Not sure that this is better because at first, we need to be sure that this
> nesting is allowed. Why do we need to perform some additional analysis if
> nesting is not allowed at all?
`CheckNestingOfRegion
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295644: [analyzer] Do not duplicate call graph nodes for
functions that have definition… (authored by a.sidorin).
Changed prior to commit:
https://reviews.llvm.org/D29643?vs=87388&id=89089#toc
Reposito
Author: a.sidorin
Date: Mon Feb 20 03:16:48 2017
New Revision: 295644
URL: http://llvm.org/viewvc/llvm-project?rev=295644&view=rev
Log:
[analyzer] Do not duplicate call graph nodes for functions that have definition
and forward declaration
Patch by Ivan Sidorenko!
Differential Revision: https:/
a.sidorin added a comment.
Anna, I will commit. Thank you!
https://reviews.llvm.org/D29643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Not sure that this is better because at first, we need to be sure that this
nesting is allowed. Why do we need to perform some additional analysis if
nesting is not allowed at all?
https://reviews.llvm.org/D30135
___
cfe-c
teemperor updated this revision to Diff 89084.
teemperor added a comment.
- Removed all the deprecated `\brief`s
I couldn't find any actual regression in the code now, so from my side it's ok
to merge it.
https://reviews.llvm.org/D23418
Files:
include/clang/Analysis/CloneDetection.h
lib/A
63 matches
Mail list logo
