ahatanak added inline comments.
================ Comment at: include/clang/AST/ASTContext.h:1910 + if (T.getQualifiers().hasUnaligned()) + TI.Align = 8; + return TI; ---------------- Is it better to call TargetInfo::getCharWidth() instead of assigning a hardcoded number here? ================ Comment at: lib/AST/ExprConstant.cpp:5678 + return CharUnits::One(); + else + return Info.Ctx.toCharUnitsFromBits( ---------------- You can remove an else after return. https://reviews.llvm.org/D30166 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
