This revision was automatically updated to reflect the committed changes.
Closed by commit rL295541: Process attributes 'ifunc' and 'alias' when checking
for redefinition (authored by sepavloff).
Changed prior to commit:
https://reviews.llvm.org/D30032?vs=88700&id=89017#toc
Repository:
rL LL
Author: sepavloff
Date: Sat Feb 18 00:04:15 2017
New Revision: 295541
URL: http://llvm.org/viewvc/llvm-project?rev=295541&view=rev
Log:
Process attributes 'ifunc' and 'alias' when checking for redefinition
These attributes effectively turn a non-defining declaration into a
definition, so the case
Author: phosek
Date: Fri Feb 17 22:37:59 2017
New Revision: 295540
URL: http://llvm.org/viewvc/llvm-project?rev=295540&view=rev
Log:
[CMake][libcxxabi] Update the libc++ test module path
The libcxx/test/libcxx Python package has been moved into
libcxx/utils/libcxx in r294651, but libcxxabi's CMak
arphaman added inline comments.
Comment at: lib/CodeGen/CodeGenPGO.cpp:631
+ ((isa(D) && GD.getCtorType() != Ctor_Base &&
+!cast(D)->getParent()->getNumVBases()) ||
(isa(D) && GD.getDtorType() != Dtor_Base))) {
I think it would be more approp
vsk created this revision.
We don't assign profile counters to non-base constructors. That results
in a loss coverage for constructors in classes with virtual bases, which
are complete constructors.
Make an exception for non-base constructors in classes with virtual
bases.
I checked that we get
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D30082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: dylanmckay
Date: Fri Feb 17 20:42:36 2017
New Revision: 295536
URL: http://llvm.org/viewvc/llvm-project?rev=295536&view=rev
Log:
[AVR] Move definition of IsIntegratedAssemblerDefault
Modified:
cfe/trunk/lib/Driver/ToolChains.cpp
cfe/trunk/lib/Driver/ToolChains.h
Modified: cfe/tru
dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.
LGTM
Actually, now that you mention this, I don't think there was a good reason to
do it this way.
Thanks @timshen!
https://reviews.llvm.org/D30118
Author: rtrieu
Date: Fri Feb 17 20:09:28 2017
New Revision: 295533
URL: http://llvm.org/viewvc/llvm-project?rev=295533&view=rev
Log:
Part of adding an improved ODR checker.
Reserve a spot for ODR hash in CXXRecordDecl and in its modules storage.
Default the hash value to 0 for all classes.
Diffe
Author: vedantk
Date: Fri Feb 17 20:02:55 2017
New Revision: 295532
URL: http://llvm.org/viewvc/llvm-project?rev=295532&view=rev
Log:
[profiling] Make a test more explicit. NFC.
The cxx-structors.cpp test checks that some instrumentation doesn't
appear, but it should be more explicit about which
On 22 July 2016 at 21:05, Faisal Vali via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: faisalv
> Date: Fri Jul 22 23:05:19 2016
> New Revision: 276514
>
> URL: http://llvm.org/viewvc/llvm-project?rev=276514&view=rev
> Log:
> [cxx1z-constexpr-lambda] Make a lambda's closure type eligi
Author: vedantk
Date: Fri Feb 17 19:50:11 2017
New Revision: 295527
URL: http://llvm.org/viewvc/llvm-project?rev=295527&view=rev
Log:
Reuse a local variable. NFC.
Modified:
cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
URL:
http://llvm.org/viewvc/llvm-p
Author: vedantk
Date: Fri Feb 17 19:50:14 2017
New Revision: 295528
URL: http://llvm.org/viewvc/llvm-project?rev=295528&view=rev
Log:
[profiling] Tighten test cases which refer to "profn" vars. NFC.
The frontend can't see "__profn" profile name variables after IRGen
because llvm throws these away
rtrieu added a comment.
This patch will be landing in small chunks to hopefully avoid the large reverts.
Repository:
rL LLVM
https://reviews.llvm.org/D21675
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
zaks.anna added a comment.
Has this been cherry-picked into the clang 4.0 release branch? If not, we
should definitely do that!
Repository:
rL LLVM
https://reviews.llvm.org/D29303
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you for catching this!
Do you have commit access or should I commit on your behalf?
https://reviews.llvm.org/D29643
___
Author: rsmith
Date: Fri Feb 17 19:14:43 2017
New Revision: 295524
URL: http://llvm.org/viewvc/llvm-project?rev=295524&view=rev
Log:
Cleanup: use range-based for rather than separate calls to begin and end.
Modified:
cfe/trunk/lib/Driver/Driver.cpp
cfe/trunk/tools/driver/cc1as_main.cpp
M
What's strange is that I copied this pattern from
clang-tidy-run-with-database.cpp, and I'm not sure why it would work there
and not here..
On Fri, Feb 17, 2017 at 8:16 PM, Ehsan Akhgari
wrote:
> Hi Douglas,
>
> Sorry about this. It seems to me that the reason for this test failure is
> the sla
Hi Douglas,
Sorry about this. It seems to me that the reason for this test failure is
the slashes that appear in the -path argument in the log:
"-path"
"C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.obj\tools\clang\tools\extra\test\clang-tidy\Output/compilation-databas
Author: rsmith
Date: Fri Feb 17 19:01:48 2017
New Revision: 295521
URL: http://llvm.org/viewvc/llvm-project?rev=295521&view=rev
Log:
Handle deduction guides better in -ast-print.
Modified:
cfe/trunk/lib/AST/DeclPrinter.cpp
cfe/trunk/test/Misc/ast-dump-templates.cpp
Modified: cfe/trunk/li
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:885
+return;
+ State = MallocMemAux(C, CE, CE->getArg(0), UndefinedVal(), State);
+ State = ProcessZeroAllocation(C, CE, 0, State);
I am not sure this is
Author: rsmith
Date: Fri Feb 17 18:32:02 2017
New Revision: 295517
URL: http://llvm.org/viewvc/llvm-project?rev=295517&view=rev
Log:
[modules] Load the ModuleOffsetMap from the module header lazily.
If we never need to map any ID within the module to its global ID, we don't
need the module offset
herzka added a comment.
@compnerd, yes please. I don't have commit access. Thanks for the review!
https://reviews.llvm.org/D29967
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added inline comments.
Comment at: test/Misc/diag-template-diffing.cpp:27
// CHECK-ELIDE-NOTREE: no matching function for call to 'f'
-// CHECK-ELIDE-NOTREE: candidate function not viable: no known conversion from
'vector' to 'vector' for 1st argument
+// CHECK-ELIDE-N
mati865 added a comment.
Commit it please when you aren't busy.
Thanks in advance.
https://reviews.llvm.org/D29772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D29772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vedantk
Date: Fri Feb 17 17:22:55 2017
New Revision: 295514
URL: http://llvm.org/viewvc/llvm-project?rev=295514&view=rev
Log:
[ubsan] Pass a set of checks to skip to EmitTypeCheck() (NFC)
CodeGenFunction::EmitTypeCheck accepts a bool flag which controls
whether or not null checks are emit
Author: vedantk
Date: Fri Feb 17 17:22:59 2017
New Revision: 295515
URL: http://llvm.org/viewvc/llvm-project?rev=295515&view=rev
Log:
Retry^2: [ubsan] Reduce null checking of C++ object pointers (PR27581)
This patch teaches ubsan to insert exactly one null check for the 'this'
pointer per method/
Author: compnerd
Date: Fri Feb 17 17:08:44 2017
New Revision: 295510
URL: http://llvm.org/viewvc/llvm-project?rev=295510&view=rev
Log:
math: fix typo in macro
MAJOR was misspelt as NAJOR. Fix the spelling.
Modified:
libcxx/trunk/include/cmath
libcxx/trunk/include/math.h
Modified: libcx
Author: compnerd
Date: Fri Feb 17 17:08:46 2017
New Revision: 295511
URL: http://llvm.org/viewvc/llvm-project?rev=295511&view=rev
Log:
test: prevent incorrect quoting of paths
The path would previously get an extra leading space as the arguments
would be parsed when generating the final command t
Author: compnerd
Date: Fri Feb 17 17:08:42 2017
New Revision: 295509
URL: http://llvm.org/viewvc/llvm-project?rev=295509&view=rev
Log:
cmath: Use c99 math on a new enough msvcrt
MSVCRT 14+ supports the C99 math routines that we need. Use them
accordingly.
Modified:
libcxx/trunk/include/cmat
pirama added a reviewer: rnk.
pirama added a subscriber: rnk.
pirama added a comment.
@rnk: This patch was to address discussion in
http://lists.llvm.org/pipermail/openmp-dev/2017-February/001659.html but now
also addresses
http://lists.llvm.org/pipermail/cfe-dev/2017-January/052512.html. Can
pirama added inline comments.
Comment at: test/Driver/arch-specific-libdir-rpath.c:18
+//
+// CHECK-ARCHDIR:
-L{{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux{{.*}} "-rpath"
{{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux
+// CHECK-NO-ARCHDIR-NOT: -L{{.*}}Inputs/res
mgorny accepted this revision.
mgorny added a comment.
LGTM modulo the test match split. But please wait for someone who has been
longer here to confirm.
Comment at: test/Driver/arch-specific-libdir-rpath.c:18
+//
+// CHECK-ARCHDIR:
-L{{.*}}/Inputs/resource_dir_with_arch_subd
timshen created this revision.
Herald added a subscriber: nemanjai.
I'm not sure why they were in different files, but it's kind of harder to
maintain. I create this patch partially for initiate a discussion.
https://reviews.llvm.org/D30118
Files:
clang/test/CodeGen/xray-attributes-supported
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295484: [Test] Make Lit tests C++11 compatible - misc
(authored by lcharles).
Changed prior to commit:
https://reviews.llvm.org/D24812?vs=88617&id=88961#toc
Repository:
rL LLVM
https://reviews.llvm.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295482: [clang-tidy] Add -path option to clang-tidy-diff.py
(authored by ehsan).
Changed prior to commit:
https://reviews.llvm.org/D29806?vs=88879&id=88959#toc
Repository:
rL LLVM
https://reviews.ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295480: [CMake] Add Fuchsia toolchain CMake cache files
(authored by phosek).
Changed prior to commit:
https://reviews.llvm.org/D26654?vs=88770&id=88958#toc
Repository:
rL LLVM
https://reviews.llvm.
EricWF updated this revision to Diff 88943.
EricWF marked 2 inline comments as done.
EricWF added a comment.
Address @rsmith's review comments.
https://reviews.llvm.org/D30082
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGenCXX/debug-info-template-deduction-guide.cpp
Index: test/CodeGenCXX
mati865 added a reviewer: rnk.
mati865 added a comment.
https://reviews.llvm.org/D29952 depends on this.
https://reviews.llvm.org/D29772
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision r295497
Repository:
rL LLVM
https://reviews.llvm.org/D29922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
hiraditya added a comment.
Adding const could help compiler, I do not have any specific performance
numbers yet. So if this is too much trouble then we don't have to merge this.
https://reviews.llvm.org/D30035
___
cfe-commits mailing list
cfe-commi
krasimir added inline comments.
Comment at: test/Format/check-coding-style-mozilla.cpp:10
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+
+if (true) {
What is tested here? Brace styles?
Comment at: test/Format/check-coding-sty
pirama added a comment.
I believe I've addressed all open issues, but this patch has changed a lot
since Dan marked it accepted. @Hahnfeld or @mgorny: Can one of you give a
LGTM if you are satisfied?
https://reviews.llvm.org/D30015
___
cfe-commi
zaks.anna added a comment.
> In this checker, I give warnings for values which are both tainted and were
> also not checked by the programmer. So unlike GenericTaintChecker, I do
> implement the boundedness check here for certain, interesting constructs
> (which is controlled by the critical op
sylvestre.ledru created this revision.
To avoid potential regressions and checking most of the coding style aspects at
once
https://reviews.llvm.org/D30111
Files:
test/Format/check-coding-style-mozilla.cpp
Index: test/Format/check-coding-style-mozilla.cpp
===
Author: rksimon
Date: Fri Feb 17 15:31:31 2017
New Revision: 295498
URL: http://llvm.org/viewvc/llvm-project?rev=295498&view=rev
Log:
Fix windows buildbots that don't have full shell support
Modified:
clang-tools-extra/trunk/test/clang-tidy/clang-tidy-diff.cpp
Modified: clang-tools-extra/tru
Author: cbertol
Date: Fri Feb 17 15:29:13 2017
New Revision: 295497
URL: http://llvm.org/viewvc/llvm-project?rev=295497&view=rev
Log:
[OpenMP] Prepare Sema for initial implementation for pragma 'distribute
parallel for'
https://reviews.llvm.org/D29922
This patch adds two fields for use in the i
Author: vedantk
Date: Fri Feb 17 14:59:40 2017
New Revision: 295494
URL: http://llvm.org/viewvc/llvm-project?rev=295494&view=rev
Log:
Revert "Retry: [ubsan] Reduce null checking of C++ object pointers (PR27581)"
This reverts commit r295401. It breaks the ubsan self-host. It inserts
object size ch
Hi Ehsan,
Your commit has caused the PS4 Windows bot to go red. Can you take a look?
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5661
$ "FileCheck" "-check-prefix=CHECK"
"C:\Buildbot\Slave\llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast\llvm.src\to
Author: lcharles
Date: Fri Feb 17 13:36:19 2017
New Revision: 295484
URL: http://llvm.org/viewvc/llvm-project?rev=295484&view=rev
Log:
[Test] Make Lit tests C++11 compatible - misc
Updated 5 tests.
Differential Revision: https://reviews.llvm.org/D24812
Modified:
cfe/trunk/test/CodeGenCXX/ma
Author: rsmith
Date: Fri Feb 17 14:05:37 2017
New Revision: 295491
URL: http://llvm.org/viewvc/llvm-project?rev=295491&view=rev
Log:
Add an explicit derived class of FunctionDecl to model deduction guides rather
than just treating them as FunctionDecls with a funny name.
No functionality change i
W dniu 16.02.2017, czw o godzinie 08∶17 +, użytkownik NAKAMURA
Takumi napisał:
> Michał,
>
> It'd make sense to use file(TO_CMAKE_PATH). I forgot it.
> I think get_file_component() satisfies in this case. Do you think to use
> file(TO_CMAKE_PATH) anyways?
> I'll wait for you as an opinion befo
Author: ehsan
Date: Fri Feb 17 13:31:43 2017
New Revision: 295482
URL: http://llvm.org/viewvc/llvm-project?rev=295482&view=rev
Log:
[clang-tidy] Add -path option to clang-tidy-diff.py
Summary:
This flag allows specifying a custom path for the compilation
database. Unfortunately we can't use the
Author: phosek
Date: Fri Feb 17 13:28:54 2017
New Revision: 295480
URL: http://llvm.org/viewvc/llvm-project?rev=295480&view=rev
Log:
[CMake] Add Fuchsia toolchain CMake cache files
These cache files can be used to build Fuchsia toolchain. They also
demonstrate the use of multi-target builtins bui
marsupial created this revision.
This is mostly affecting usage of the JIT...
When using DynamicLibrary::getPermanentLibrary(0,0) to get a list of the loaded
libs, on Windows this is currently stored in a set which makes iteration
unordered / undefined. Additionally there is a problem as newer W
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Hi Hans, Alexey,
can we merge this commit and r295474 for the 4.0 release or is it
already too late for that? I will totally understand that and can apply
these commits locally prior to installing.
However, I think that these changes are quite focussed and bear minimal
possibility of introducing r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295474: [OpenMP] Fix cancellation point in task with no
cancel (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D30091?vs=88878&id=88922#toc
Repository:
rL LLVM
https://revi
Author: hahnfeld
Date: Fri Feb 17 12:32:51 2017
New Revision: 295473
URL: http://llvm.org/viewvc/llvm-project?rev=295473&view=rev
Log:
[OpenMP] Remove barriers at cancel and cancellation point
This resolves a deadlock with the cancel directive when there is no explicit
cancellation point. In that
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295473: [OpenMP] Remove barriers at cancel and cancellation
point (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D30088?vs=88872&id=88921#toc
Repository:
rL LLVM
https://r
Author: hahnfeld
Date: Fri Feb 17 12:32:58 2017
New Revision: 295474
URL: http://llvm.org/viewvc/llvm-project?rev=295474&view=rev
Log:
[OpenMP] Fix cancellation point in task with no cancel
With tasks, the cancel may happen in another task. This has a different
region info which means that we can
Hahnfeld added inline comments.
Comment at: lib/Driver/Tools.cpp:8683
if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs))
-addOpenMPRuntime(CmdArgs, getToolChain(), Args);
+addOpenMPRuntime(CmdArgs, getToolChain(), Args, JA);
pirama
aaron.ballman added a comment.
In https://reviews.llvm.org/D29692#676559, @AlexanderLanin wrote:
> Thanks for the feedback. As I'm new to this I cannot say whether checking
> only the file in question fits better with clang-tidy’s policy or not.
> Also, I’m not sure about ODR. Of course, it’s a
Author: arphaman
Date: Fri Feb 17 12:11:08 2017
New Revision: 295471
URL: http://llvm.org/viewvc/llvm-project?rev=295471&view=rev
Log:
[Docs] 'Limitations' should be a subsection
The 'Limitations' section in thedocumentation for
readability-misleading-indentation should be a subsection, as otherw
pirama added inline comments.
Comment at: lib/Driver/Tools.cpp:8683
if (!Args.hasArg(options::OPT_nostdlib, options::OPT_nodefaultlibs))
-addOpenMPRuntime(CmdArgs, getToolChain(), Args);
+addOpenMPRuntime(CmdArgs, getToolChain(), Args, JA);
`addOpenM
a.sidorin added a comment.
Hello Zoltan. Sorry, I'm a bit busy now. Here are my thoughts about the design.
1. I think we should not add new warnings to GenericTaintChecker. Instead, it
is better to move warnings out of it. After that it will become just a plugin
used by other checkers. Such sp
rsmith added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2478
break;
+case Type::DeducedTemplateSpecialization: {
+ QualType DT = cast(T)->getDeducedType();
EricWF wrote:
> I'll put this in alphabetical order before committing.
Reuse
Author: bogner
Date: Fri Feb 17 11:34:49 2017
New Revision: 295466
URL: http://llvm.org/viewvc/llvm-project?rev=295466&view=rev
Log:
Rename DiagnosticInfoWithDebugLoc to WithLocation to match LLVM
Updates for llvm r295465.
Modified:
cfe/trunk/lib/CodeGen/CodeGenAction.cpp
Modified: cfe/trun
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
Ah, I had missed the `-verify` option on the test. Yes, that makes sense.
Ternary may have flowed the conditional code better. Do you need someone to
commit this on your behalf?
https
pirama added inline comments.
Comment at: test/Driver/arch-specific-libdir-rpath.c:18
+//
+// CHECK-ARCHDIR:
-L{{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux{{.*}} "-rpath"
{{.*}}/Inputs/resource_dir_with_arch_subdir/lib/linux
+// CHECK-NO-ARCHDIR-NOT: -L{{.*}}Inputs/res
gerazo added a comment.
Hi, did you have time to check my changes?
https://reviews.llvm.org/D27753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amaiorano added a comment.
Hello again. Just wondering if anyone could take a look at this? I updated the
patch a week ago :) Thanks!
https://reviews.llvm.org/D29221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D30032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
a.sidorin added a comment.
This patch lacks tests. If you add at least minimal test case (I'm not familiar
with ObjC and its front-end, unfortunately), I will no have any concerns. Also
adding Sean.
https://reviews.llvm.org/D6550
___
cfe-commits m
xazax.hun added a comment.
In https://reviews.llvm.org/D6549#662955, @a.sidorin wrote:
> This should be fixed in r269693.
Indeed, I commandeer than abandon this revision so it is closed.
https://reviews.llvm.org/D6549
___
cfe-commits mailing list
xazax.hun added a comment.
In https://reviews.llvm.org/D6550#663002, @a.sidorin wrote:
> Hi Gabor. One of the bugs fixed in this patch is still present in master,
> other two are already fixed.
Thanks for checking that! Do you think it is ok for me to commit the missing
part?
https://review
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D30091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ehsan updated this revision to Diff 88879.
ehsan added a comment.
Addressed the review comments.
https://reviews.llvm.org/D29806
Files:
clang-tidy/tool/clang-tidy-diff.py
test/clang-tidy/clang-tidy-diff.cpp
Index: test/clang-tidy/clang-tidy-diff.cpp
===
Hahnfeld created this revision.
With tasks, the cancel may happen in another task. This has a different
region info which means that we can't find it here.
https://reviews.llvm.org/D30091
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/cancellation_point_codegen.cpp
Index: test/OpenMP/
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D30088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
erikjv updated this revision to Diff 88874.
erikjv retitled this revision from "Normalize all filenames before searching
FileManager caches" to "FileManager: mark virtual file entries as valid
entries".
erikjv edited the summary of this revision.
https://reviews.llvm.org/D27810
Files:
lib/Bas
EricWF added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:2478
break;
+case Type::DeducedTemplateSpecialization: {
+ QualType DT = cast(T)->getDeducedType();
I'll put this in alphabetical order before committing.
https://reviews.llv
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D30002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh added a comment.
In https://reviews.llvm.org/D29806#673489, @ehsan wrote:
> In https://reviews.llvm.org/D29806#673329, @alexfh wrote:
>
> > What's your use case? Can it be addressed by just forwarding the -p flag to
> > clang-tidy?
>
>
> I just need to pass the full path to the compilatio
Hahnfeld created this revision.
This resolves a deadlock with the cancel directive when there is no explicit
cancellation point. In that case, the implicit barrier acts as cancellation
point. After removing the barrier after cancel, the now unmatched barrier for
the explicit cancellation point has
Hahnfeld created this revision.
Herald added a subscriber: emaste.
This enables libomptarget for Darwin, FreeBSD and NetBSD, NFCI otherwise.
While at it, extend test for FreeBSD and check for -lrt iff on Linux.
https://reviews.llvm.org/D30087
Files:
lib/Driver/Tools.cpp
test/Driver/fopenmp.
Author: djasper
Date: Fri Feb 17 04:44:07 2017
New Revision: 295437
URL: http://llvm.org/viewvc/llvm-project?rev=295437&view=rev
Log:
clang-format: Don't remove existing spaces between identifier and ::.
This can lead to bad behavior with macros that are used to annotate
functions (e.g. ALWAYS_IN
mgorny added inline comments.
Comment at: lib/Driver/Tools.cpp:3267
+ if (llvm::sys::fs::is_directory(CandidateLibPath))
+CmdArgs.push_back(Args.MakeArgString("-L" + CandidateLibPath));
+
pirama wrote:
> mgorny wrote:
> > Don't you also need rpath for it? Or
pirama updated this revision to Diff 88865.
pirama marked an inline comment as done.
pirama added a comment.
Add arch name to -rpath test.
https://reviews.llvm.org/D30015
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
test/Driver/Inputs/resource_di
pirama updated this revision to Diff 88864.
pirama added a comment.
Fix typo.
https://reviews.llvm.org/D30015
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
test/Driver/Inputs/resource_dir_with_arch_subdir/lib/linux/aarch64/.keep
test/Driver/Inpu
Author: xazax
Date: Fri Feb 17 02:52:51 2017
New Revision: 295435
URL: http://llvm.org/viewvc/llvm-project?rev=295435&view=rev
Log:
[clang-tidy] Add cert-dcl58-cpp (do not modify the 'std' namespace) check.
Differential Revision: https://reviews.llvm.org/D23421
Added:
clang-tools-extra/trunk
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295435: [clang-tidy] Add cert-dcl58-cpp (do not modify the
'std' namespace) check. (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D23421?vs=88541&id=88863#toc
Repository:
rL L
Author: ericwf
Date: Fri Feb 17 02:37:03 2017
New Revision: 295434
URL: http://llvm.org/viewvc/llvm-project?rev=295434&view=rev
Log:
Update all bug URL's to point to https://bugs.llvm.org/...
Modified:
libcxx/trunk/docs/index.rst
libcxx/trunk/include/memory
libcxx/trunk/test/std/cont
Author: ismail
Date: Fri Feb 17 02:26:54 2017
New Revision: 295433
URL: http://llvm.org/viewvc/llvm-project?rev=295433&view=rev
Log:
Update Bugzilla URLs in docs
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
95 matches
Mail list logo
