Author: marshall
Date: Wed Feb 8 01:40:59 2017
New Revision: 294417
URL: http://llvm.org/viewvc/llvm-project?rev=294417&view=rev
Log:
Temporarily disable the LCM/GCD tests under UBSAN.
Modified:
libcxx/trunk/test/std/numerics/numeric.ops/numeric.ops.gcd/gcd.pass.cpp
libcxx/trunk/test/std
Author: ctopper
Date: Wed Feb 8 01:36:58 2017
New Revision: 294416
URL: http://llvm.org/viewvc/llvm-project?rev=294416&view=rev
Log:
[X86] Add -mclwb/-mno-clwb command line arguments and __CLWB__ define to match
gcc.
In the future, we should also add a clwb intrinsic to the backend, a frontend
Author: ctopper
Date: Wed Feb 8 01:13:19 2017
New Revision: 294413
URL: http://llvm.org/viewvc/llvm-project?rev=294413&view=rev
Log:
[X86] Add -mmovbe/-mno-movbe command line options to match gcc.
Modified:
cfe/trunk/include/clang/Driver/Options.td
cfe/trunk/test/Driver/x86-target-featur
Author: ctopper
Date: Wed Feb 8 01:13:22 2017
New Revision: 294414
URL: http://llvm.org/viewvc/llvm-project?rev=294414&view=rev
Log:
[X86] Remove 'umip' feature flag.
This feature flag indicates that the processor has support for removing certain
instructions from user mode software. But the fe
Author: ctopper
Date: Wed Feb 8 00:48:58 2017
New Revision: 294411
URL: http://llvm.org/viewvc/llvm-project?rev=294411&view=rev
Log:
[X86] Add -mclflushopt/-mno-clflushopt command line support and __CLFLUSHOPT__
define to match gcc.
Modified:
cfe/trunk/docs/ClangCommandLineReference.rst
Author: ctopper
Date: Tue Feb 7 23:44:30 2017
New Revision: 294404
URL: http://llvm.org/viewvc/llvm-project?rev=294404&view=rev
Log:
Use LLVM_FALLTHROUGH instead of FALLTHROUGH comments.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.or
Author: ctopper
Date: Tue Feb 7 23:44:28 2017
New Revision: 294403
URL: http://llvm.org/viewvc/llvm-project?rev=294403&view=rev
Log:
[X86] Remove PCOMMIT feature support since Intel has deprecated this
instruction with no plans to release products with it.
Intel's documentation for the deprecat
pelikan created this revision.
Functions with the "xray_log_args" attribute will tell LLVM to emit a special
XRay sled for compiler-rt to copy any call arguments to your logging handler.
https://reviews.llvm.org/D29704
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
lib
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294402: [AVR] Add support for the 'interrupt' and 'naked'
attributes (authored by dylanmckay).
Changed prior to commit:
https://reviews.llvm.org/D28451?vs=87365&id=87588#toc
Repository:
rL LLVM
http
Author: dylanmckay
Date: Tue Feb 7 23:09:26 2017
New Revision: 294402
URL: http://llvm.org/viewvc/llvm-project?rev=294402&view=rev
Log:
[AVR] Add support for the 'interrupt' and 'naked' attributes
Summary:
This teaches clang how to parse and lower the 'interrupt' and 'naked'
attributes.
This al
Nice!
On Tue, Feb 7, 2017 at 7:30 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Tue Feb 7 21:30:13 2017
> New Revision: 294401
>
> URL: http://llvm.org/viewvc/llvm-project?rev=294401&view=rev
> Log:
> Sema: add warning for c++ member varia
Author: compnerd
Date: Tue Feb 7 21:30:13 2017
New Revision: 294401
URL: http://llvm.org/viewvc/llvm-project?rev=294401&view=rev
Log:
Sema: add warning for c++ member variable shadowing
Add a warning for shadowed variables across records. Referencing a
shadow'ed variable may not give the desire
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
This check is also should be included into cppcoreguidelines module. Or may be
moved there?
Comment at: clang-tidy/modernize/UseConstInsteadOfDefineCheck.cpp:41
+/// ot
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. @joerg has raised some legitimate concerns about the Windows
implementation. However that shouldn't hold this cleanup up, since the
implementation is preexisting.
Com
Hello clang developers,
I discovered a bug that affects Objective-C programs compiled with clang on
Linux. The current code was not emitting Objective-C class name metadata,
which made it impossible for programs to do runtime type introspection. I
opened a bug report that describes the proble
On 2/7/17 7:30 PM, Saleem Abdulrasool wrote:
On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs
mailto:jonat...@codesourcery.com>> wrote:
On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
Don't use the cast for the check, use isa. Although, since
you use t
jbangert added a comment.
Thank you for the feedback, addressed and reformatted using llvm style.
Comment at: clang-query/QueryReplace.h:35-36
+
+ /// \brief Replacement text. %"identifier" will be substituted by the text of
+ /// an identifier.
+ std::string ToTemplate;
---
jbangert updated this revision to Diff 87580.
jbangert marked 7 inline comments as done.
jbangert added a comment.
Response to initial code review.
https://reviews.llvm.org/D29622
Files:
clang-query/CMakeLists.txt
clang-query/QueryReplace.cpp
clang-query/QueryReplace.h
clang-query/repla
On Tue, Feb 7, 2017 at 1:09 PM, Jonathan Roelofs
wrote:
>
>
> On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
>
>> Don't use the cast for the check, use isa. Although, since you use the
>> value later, it is probably better to write this as:
>>
>> if (const auto *RD = cast(CurC
jbangert updated this revision to Diff 87579.
jbangert added a comment.
- use iter
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallbacksTest.cpp
Index: unittests/Tooling/RefactoringC
jbangert marked 5 inline comments as done.
jbangert added a comment.
Thank you for the initial feedback!
Comment at: include/clang/Tooling/RefactoringCallbacks.h:61
+MatchFinder.addMatcher(Matcher, Callback);
+Callbacks.emplace_back(Callback);
+ }
sben
jbangert marked 2 inline comments as done.
jbangert added a comment.
(marking other comments as done).
https://reviews.llvm.org/D29621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ehsan added a comment.
This is equivalent to https://reviews.llvm.org/D28334 for clang-tidy-diff.py.
https://reviews.llvm.org/D29699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ehsan created this revision.
Herald added a subscriber: JDevlieghere.
These flags allow specifying extra arguments to the tool's command
line which don't appear in the compilation database.
https://reviews.llvm.org/D29699
Files:
clang-tidy/tool/clang-tidy-diff.py
Index: clang-tidy/tool/clan
jbangert updated this revision to Diff 87575.
jbangert added a comment.
- change to push_back
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCallbacksTest.cpp
Index: unittests/Tooling/R
jbangert updated this revision to Diff 87574.
jbangert added a comment.
Address code feedback & Reformat with clang-format --style llvm.
https://reviews.llvm.org/D29621
Files:
include/clang/Tooling/RefactoringCallbacks.h
lib/Tooling/RefactoringCallbacks.cpp
unittests/Tooling/RefactoringCa
Author: rsmith
Date: Tue Feb 7 19:27:29 2017
New Revision: 294397
URL: http://llvm.org/viewvc/llvm-project?rev=294397&view=rev
Log:
Diagnose an attempt to give a deduction-guide a function body.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/Sema/SemaDeclCXX
Author: rsmith
Date: Tue Feb 7 19:16:55 2017
New Revision: 294396
URL: http://llvm.org/viewvc/llvm-project?rev=294396&view=rev
Log:
Fix constructor declarator detection for the case when the name is followed by
an attribute-specifier-seq. (Also fixes the same problem for deduction-guides.)
Modif
jlebar added inline comments.
Comment at: lib/Driver/ToolChains.cpp:4902
+ DeviceOffloadingKind == Action::OFK_Cuda) &&
+ "The offloading kind is not OpenMP or CUDA.");
Not sure this assertion message helps us much beyond what's already in the
Author: rsmith
Date: Tue Feb 7 18:35:25 2017
New Revision: 294395
URL: http://llvm.org/viewvc/llvm-project?rev=294395&view=rev
Log:
P0091R3: Improved syntactic checking of deduction-guides.
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
cfe/trunk/lib/AST/DeclarationName.c
Author: ericwf
Date: Tue Feb 7 18:14:13 2017
New Revision: 294393
URL: http://llvm.org/viewvc/llvm-project?rev=294393&view=rev
Log:
Add missing include in
Modified:
libcxx/trunk/include/numeric
Modified: libcxx/trunk/include/numeric
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/in
AlexanderLanin created this revision.
Herald added subscribers: JDevlieghere, mgorny.
Suggestion for a new check that will warn on #defines that should rather be
constant values. Const variables should be preferred as #define does not obey
type checking and scope rules.
Please feel free to cri
Author: ericwf
Date: Tue Feb 7 18:10:10 2017
New Revision: 294391
URL: http://llvm.org/viewvc/llvm-project?rev=294391&view=rev
Log:
Prevent UBSAN from generating unsigned overflow diagnostics in the hashing
internals
Added:
libcxx/trunk/test/libcxx/utilities/function.objects/unord.hash/
alexfh added a comment.
Adding a mechanism to supply suppression lists would be useful as long as it's
flexible and extensible enough and doesn't significantly affect performance
(especially, when not in use). In particular, it shouldn't be bound to a
specific format or a specific way to store
Ping?
On Mon, Feb 6, 2017 at 2:15 PM, Hans Wennborg wrote:
> The diff here is huge compared to the Apple one (r294139).
>
> Did the file format change and this file was previously not updated?
>
> This makes it hard to merge the change. Can you advise on how to
> generate this file or how to do t
tigerleapgorge created this revision.
I am continuing to make Lit tests C++11 compatible.
This patch contains 3 tests, previously in review
https://reviews.llvm.org/D21626.
First two tests involve printf format attributes.
The third test involve thread safety attribute.
Here are the descriptions
ddcc added a comment.
I added support for a callback field in lit's configuration (see
https://reviews.llvm.org/D29684), which is used to execute each testcase for
each supported constraint solver backends at runtime. I believe this resolves
all remaining issues, except for the remaining two te
rsmith added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:2702
DS.SetRangeStart(Tok.getLocation());
-DS.SetRangeEnd(SourceLocation());
+DS.SetRangeEnd(Tok.getLocation());
}
This doesn't look right: this is a source range containing exactly
v.g.vassilev closed this revision.
v.g.vassilev added a comment.
Landed in r294359.
Repository:
rL LLVM
https://reviews.llvm.org/D29676
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: bruno
Date: Tue Feb 7 15:55:02 2017
New Revision: 294362
URL: http://llvm.org/viewvc/llvm-project?rev=294362&view=rev
Log:
[ASTReader] Improve ReadASTBlock error message when module not available
Point to the PCM file that could not be found.
rdar://problem/30381981
Modified:
cfe/t
Author: bruno
Date: Tue Feb 7 15:54:57 2017
New Revision: 294361
URL: http://llvm.org/viewvc/llvm-project?rev=294361&view=rev
Log:
[PCH] Fix a regression when PCH is used with -fmodules
Following up on r291465 after a regression in r276159. When we use
-fmodule-name=X while building a PCH, modul
Hi Jonas,
I fixed the filesystem test failures in r294360. You should be able to
re-enable
LIBCXX_ENABLE_ASSERTIONS.
/Eric
On Mon, Feb 6, 2017 at 3:25 AM, Eric Fiselier wrote:
> I should have made it more clear that this change actually caused 100's of
> assertions to be turned on. And good ne
rsmith added inline comments.
Comment at: include/clang/Lex/Preprocessor.h:310
+
+const Stack &getStack() const {
+ assert(ConditionalStack);
Return an `ArrayRef` rather than exposing the type of the storage (which is an
implementation detail), here and
Author: ericwf
Date: Tue Feb 7 15:51:58 2017
New Revision: 294360
URL: http://llvm.org/viewvc/llvm-project?rev=294360&view=rev
Log:
Fix bugs in filesystem detected by _LIBCPP_ASSERT.
Recently I turned on libc++'s debug mode assertions when
CMake is configured with -DLIBCXX_ENABLE_ASSERTIONS=ON.
Author: vvassilev
Date: Tue Feb 7 15:49:41 2017
New Revision: 294359
URL: http://llvm.org/viewvc/llvm-project?rev=294359&view=rev
Log:
Enable -dump-deserialized-decls and -error-on-deserialized-decl for modules.
Modified:
cfe/trunk/lib/Frontend/FrontendAction.cpp
Modified: cfe/trunk/lib/Fro
Author: djasper
Date: Tue Feb 7 15:38:16 2017
New Revision: 294358
URL: http://llvm.org/viewvc/llvm-project?rev=294358&view=rev
Log:
clang-format: Fix bad variable declaration detection.
Before:
LongType
variable(nullptr, [](A *a) {});
After:
LongType
kcc accepted this revision.
kcc added a comment.
This revision is now accepted and ready to land.
LGTM,
but please manually verify that the test runs if strace *is* available.
Repository:
rL LLVM
https://reviews.llvm.org/D29628
___
cfe-commits m
Author: ericwf
Date: Tue Feb 7 15:21:17 2017
New Revision: 294355
URL: http://llvm.org/viewvc/llvm-project?rev=294355&view=rev
Log:
fix python3 syntax error
Modified:
libcxx/trunk/test/support/filesystem_dynamic_test_helper.py
Modified: libcxx/trunk/test/support/filesystem_dynamic_test_help
Author: ericwf
Date: Tue Feb 7 15:20:31 2017
New Revision: 294353
URL: http://llvm.org/viewvc/llvm-project?rev=294353&view=rev
Log:
Fix test failures when using modules.
Modified:
libcxx/trunk/test/libcxx/debug/containers/db_associative_container_tests.pass.cpp
libcxx/trunk/test/libcxx
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExcep
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294350: Use copy.deepcopy instead of doing it manually.
(authored by danalbert).
Changed prior to commit:
https://reviews.llvm.org/D29209?vs=85999&id=87507#toc
Repository:
rL LLVM
https://reviews.ll
Author: danalbert
Date: Tue Feb 7 15:04:19 2017
New Revision: 294350
URL: http://llvm.org/viewvc/llvm-project?rev=294350&view=rev
Log:
Use copy.deepcopy instead of doing it manually.
Reviewers: EricWF
Reviewed By: EricWF
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org
Prazek added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExceptRan
On 1/24/17 8:10 PM, Saleem Abdulrasool via cfe-commits wrote:
Don't use the cast for the check, use isa. Although, since you use the
value later, it is probably better to write this as:
if (const auto *RD = cast(CurContext))
CheckShadowInheritedVariabless(Loc, Name.getAsString(), RD
Great, thanks!
On 7 February 2017 at 10:54, James Sun wrote:
> Hi Richard, Saleem
>
>
>
> I cleaned up the patch by removing some unrelated unit tests. Also Saleem
> can help me with the commit.
>
>
>
> Thanks!
>
>
>
> James
>
>
>
> *From: *James Sun
> *Date: *Saturday, February 4, 2017 at 11:3
v.g.vassilev created this revision.
Enable the useful -dump-deserialized-decls and -error-on-deserialized-decl
flags for modules builds, too.
Repository:
rL LLVM
https://reviews.llvm.org/D29676
Files:
lib/Frontend/FrontendAction.cpp
Index: lib/Frontend/FrontendAction.cpp
==
nkakuev added a comment.
Thanks for the response, Alex!
The problem I tried to address in this patch was that notes in source files
were "unsuppressing" warnings from third-party headers (this is what we were
discussing in https://reviews.llvm.org/D26418#590417). But at this point, I no
longe
sbarzowski added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExcep
lethalantidote updated this revision to Diff 87484.
lethalantidote marked an inline comment as done.
lethalantidote added a comment.
- Addresses alexfh's comments.
https://reviews.llvm.org/D28973
Files:
clang-tools-extra/clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tools-extra/test/cl
On Tue, Feb 7, 2017 at 11:01 AM Amjad Aboud via Phabricator <
revi...@reviews.llvm.org> wrote:
> aaboud added a comment.
>
> In https://reviews.llvm.org/D16135#669416, @aprantl wrote:
>
> > In https://reviews.llvm.org/D16135#669045, @aaboud wrote:
> >
> > > Addressed Adrian last comments.
> > > A
Author: compnerd
Date: Tue Feb 7 13:00:06 2017
New Revision: 294332
URL: http://llvm.org/viewvc/llvm-project?rev=294332&view=rev
Log:
Revert "Basic: match GCC behaviour for SuS macro"
This reverts commit SVN r294148. Seems that it was mistaken, and GCC
does still define `__unix` and `unix` when
ABataev added a comment.
The patch is too big and quite hard to review? Could you split it into several
smaller parts?
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4280-4282
+ // We don't need debug information in this function as nothing here refers to
+ // user source code.
aaboud added a comment.
In https://reviews.llvm.org/D16135#669416, @aprantl wrote:
> In https://reviews.llvm.org/D16135#669045, @aaboud wrote:
>
> > Addressed Adrian last comments.
> > Added a LIT tests that covers all the macro kinds:
> >
> > 1. built-in (define)
> > 2. command-line (define, in
Hi Richard, Saleem
I cleaned up the patch by removing some unrelated unit tests. Also Saleem can
help me with the commit.
Thanks!
James
From: James Sun
Date: Saturday, February 4, 2017 at 11:35 PM
To: Richard Smith
Cc: Saleem Abdulrasool , "cfe-commits@lists.llvm.org"
, Aaron Ballman
Subje
Author: marshall
Date: Tue Feb 7 12:41:25 2017
New Revision: 294328
URL: http://llvm.org/viewvc/llvm-project?rev=294328&view=rev
Log:
Stop using random_shuffle in the libc++ test suite. It's going to be removed in
c++17. Use shuffle() instead. No change to libc++, just the tests.
Modified:
bmharper added a comment.
Thanks for all the code review work! I'm impressed by the quality standard
maintained here.
https://reviews.llvm.org/D21279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
bmharper updated this revision to Diff 87478.
bmharper added a comment.
small comment tweak
https://reviews.llvm.org/D21279
Files:
lib/Format/WhitespaceManager.cpp
lib/Format/WhitespaceManager.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
==
amaiorano added a comment.
In https://reviews.llvm.org/D29221#668867, @klimek wrote:
> +hans
>
> +1 to "format only current document but save all" not making much sense :)
Yes, I've been using this version for a little while now, and it's not useful
to have the current document version. I'll r
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
I'm fine with this.
Repository:
rL LLVM
https://reviews.llvm.org/D29644
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
gtbercea created this revision.
This flag "--fopenmp-ptx=" enables the overwriting of the default PTX version
used for GPU offloaded OpenMP target regions: "+ptx42".
Repository:
rL LLVM
https://reviews.llvm.org/D29660
Files:
include/clang/Driver/Options.td
lib/Driver/ToolChains.cpp
te
ehsan created this revision.
Herald added a subscriber: JDevlieghere.
This new flag instructs clang-tidy to not output anything
except for errors and warnings. This makes it easier to
script clang-tidy to run as part of external build systems.
https://reviews.llvm.org/D29661
Files:
clang-tid
aprantl added a comment.
In https://reviews.llvm.org/D16135#669045, @aaboud wrote:
> Addressed Adrian last comments.
> Added a LIT tests that covers all the macro kinds:
>
> 1. built-in (define)
> 2. command-line (define, include, undef)
> 3. main source (define, include, undef) Checked the abov
a.sidorin added a comment.
Hi Artem,
Thank you for adding me, I missed this patch. I have few comments below. If you
(and Vlad) can wait for two or three days, I will re-check the place I'm
worrying about and post the results.
Comment at: lib/StaticAnalyzer/Checkers/GenericT
gtbercea updated this revision to Diff 87463.
gtbercea added a comment.
Additional test added to check "-c" is passed in appropriately.
Repository:
rL LLVM
https://reviews.llvm.org/D29659
Files:
include/clang/Driver/Options.td
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL294315: clang-format: [JS] correcly format object literal
methods. (authored by mprobst).
Changed prior to commit:
https://reviews.llvm.org/D29656?vs=87456&id=87462#toc
Repository:
rL LLVM
https://r
falho added a comment.
Unfortunately I wont have time to work on this check anymore... thank you for
understanding!
Repository:
rL LLVM
https://reviews.llvm.org/D23421
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
gtbercea created this revision.
Previously we have added the "-c" flag which gets passed to PTXAS by default to
generate relocatable OpenMP target code by default. This set of flags exposes
control over this behaviour.
Repository:
rL LLVM
https://reviews.llvm.org/D29659
Files:
include/cl
Author: mprobst
Date: Tue Feb 7 10:33:13 2017
New Revision: 294315
URL: http://llvm.org/viewvc/llvm-project?rev=294315&view=rev
Log:
clang-format: [JS] correcly format object literal methods.
Summary:
In JavaScript, object literals can contain methods:
var x = {
a() { return 1; },
};
sanwou01 updated this revision to Diff 87461.
sanwou01 added a comment.
Update the tests. Note that the diagnostics for backend errors are missing the
"instantiated into assembly here" messages. This is unfortunate but expected:
the origin information is no longer available at this stage.
http
mprobst created this revision.
Herald added a subscriber: klimek.
In JavaScript, object literals can contain methods:
var x = {
a() { return 1; },
};
Previously, clang-format always parsed nested {} inside a braced list as
further braced lists. Special case this logic for JavaScript to t
djasper accepted this revision.
djasper added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Format/UnwrappedLineParser.cpp:1306
+// Could be a method inside of a braced list `{a() { return 1; }}`.
+if (tryToParseBracedList()) {
Unfortunatelly I wont have time now to work on this check... Thank you for
understanding!
On Mon, Feb 6, 2017 at 3:44 PM, Gábor Horváth via Phabricator <
revi...@reviews.llvm.org> wrote:
> xazax.hun added a comment.
>
> Benedek, do you have time to address the review comments or do you want me
>
mlemay-intel updated this revision to Diff 87453.
mlemay-intel added a comment.
Removed the portions that are specific to 32-bit segmentation. I plan to
resubmit those later as a separate patch.
https://reviews.llvm.org/D17092
Files:
include/clang/Driver/Options.td
Index: include/clang/Dr
Anastasia closed this revision.
Anastasia added a comment.
Committed in r294313
https://reviews.llvm.org/D29038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Tue Feb 7 10:10:17 2017
New Revision: 294314
URL: http://llvm.org/viewvc/llvm-project?rev=294314&view=rev
Log:
[clangd] Strip file:// from the URI when calling formatting.
It confuses FileManager on windows.
Modified:
clang-tools-extra/trunk/clangd/ProtocolHandlers.cpp
Mo
jhenderson added a comment.
Ping!
https://reviews.llvm.org/D29027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stulova
Date: Tue Feb 7 10:09:41 2017
New Revision: 294313
URL: http://llvm.org/viewvc/llvm-project?rev=294313&view=rev
Log:
[OpenCL] Accept logical NOT for pointer types in CL1.1
Fix for bug 30217 - incorrect error given for logical
NOT operation with a pointer type: corrected sema chec
GGanesh updated this revision to Diff 87437.
GGanesh added a comment.
Updated the builtins test for "__builtin_ia32_clzero"
Repository:
rL LLVM
https://reviews.llvm.org/D29386
Files:
include/clang/Basic/BuiltinsX86.def
include/clang/Driver/Options.td
lib/Basic/Targets.cpp
lib/Headers
sbenza added inline comments.
Comment at: include/clang/Tooling/RefactoringCallbacks.h:61
+MatchFinder.addMatcher(Matcher, Callback);
+Callbacks.emplace_back(Callback);
+ }
Why emplace_back instead of push_back?
Comment at: lib/Tooling
Author: marshall
Date: Tue Feb 7 09:34:20 2017
New Revision: 294311
URL: http://llvm.org/viewvc/llvm-project?rev=294311&view=rev
Log:
Mark LWG2784 as ready
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pro
The test depends on named labels. It failed with -Asserts.
On Wed, Feb 8, 2017 at 12:45 AM Anastasia Stulova
wrote:
> I don't understand why we need this extra step in testing now? Did
> anything fail?
>
> Thanks,
> Anastasia
>
> -Original Message-
> From: cfe-commits [mailto:cfe-commits
IvanSidorenko created this revision.
Fix in call graph construction: don't build call graph node for callee function
twice for functions with forward declarations.
Maybe the same fix should be done and for VisitObjCMethodDecl. Unfortunately, I
have not enough expertise in ObjC, so I did not tou
Author: d0k
Date: Tue Feb 7 09:37:17 2017
New Revision: 294312
URL: http://llvm.org/viewvc/llvm-project?rev=294312&view=rev
Log:
[clangd] Ignore comments in clangd input, so we can write tests without sed.
Another attempt on making this work on windows.
Modified:
clang-tools-extra/trunk/cla
I don't understand why we need this extra step in testing now? Did anything
fail?
Thanks,
Anastasia
-Original Message-
From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf Of
NAKAMURA Takumi via cfe-commits
Sent: 01 November 2016 20:08
To: cfe-commits@lists.llvm.org
S
sbenza added inline comments.
Comment at: clang-query/QueryReplace.h:35-36
+
+ /// \brief Replacement text. %"identifier" will be substituted by the text of
+ /// an identifier.
+ std::string ToTemplate;
klimek wrote:
> This doesn't seem to come up in the test
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:2207-2208
+const FormatToken *NextTok) {
+ // Decides which comment tokens should be added to the current line and which
+ // should be added as comment
klimek added inline comments.
Comment at: lib/Format/UnwrappedLineParser.h:121-123
+ // Comments specifies the sequence of comment tokens to analyze. They get
+ // either pushed to the current line or added to the comments before the next
+ // token.
Given thi
krasimir updated this revision to Diff 87424.
krasimir added a comment.
- Moved method summary from the implementation to the declaration.
https://reviews.llvm.org/D29626
Files:
lib/Format/UnwrappedLineParser.cpp
lib/Format/UnwrappedLineParser.h
unittests/Format/FormatTest.cpp
Index: uni
RKSimon added a comment.
Still missing a test in llvm\tools\clang\test\CodeGen\builtins-x86.c
Repository:
rL LLVM
https://reviews.llvm.org/D29386
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: d0k
Date: Tue Feb 7 08:35:09 2017
New Revision: 294309
URL: http://llvm.org/viewvc/llvm-project?rev=294309&view=rev
Log:
[clangd] Fix subtle use after return.
I didn't find this because my main development machine still happens to
use libstdc++ with the broken C++11 ABI, which has a glob
1 - 100 of 143 matches
Mail list logo
