ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
smeenai added a comment.
Ping.
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
Ping.
https://reviews.llvm.org/D29157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hfinkel added inline comments.
Comment at: include/clang/Driver/Driver.h:219
+ /// This number may be smaller that \c NumConfigOptions if some options
+ /// requires separate arguments.
+ unsigned NumConfigArgs;
requires -> require
Comment a
Seems reasonable to me.
I wonder, should this do something in the case where -nostdlib has been passed,
so we're not linking against libc by default? Or should it error/warning/etc.?
One comment inline below.
> On 2017-Feb-02, at 16:56, Matthias Braun via Phabricator
> wrote:
>
> MatzeB cre
probinson added a reviewer: rjmccall.
probinson added a comment.
+rjmccall as CodeGen owner.
https://reviews.llvm.org/D24812
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tigerleapgorge created this revision.
I am continuing to make Lit tests C++11 compatible.
This patch is a subset of the previous https://reviews.llvm.org/D20710
This patch contains 4 tests, the changes are nearly identical.
C++11 introduced constexpr, hence the change in diagnostics.
C++11 added
tigerleapgorge updated this revision to Diff 86923.
tigerleapgorge added a comment.
Revise again,
https://reviews.llvm.org/D28425 fixed 7 tests.
r290229 fixed 1 test.
Down to 8 tests.
https://reviews.llvm.org/D24812
Files:
test/CodeGenCXX/linetable-cleanup.cpp
test/CodeGenCXX/lpad-linetab
MatzeB created this revision.
Herald added a subscriber: mcrosier.
While there is nothing to do at link time to get pthreads support on
darwin, specifying -pthread is fine and should not produce a warning
about unused arguments.
Repository:
rL LLVM
https://reviews.llvm.org/D29479
Files:
li
MatzeB abandoned this revision.
MatzeB added a comment.
Abandoning in favor of https://reviews.llvm.org/D29479 because phabricator...
Repository:
rL LLVM
https://reviews.llvm.org/D29476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
I think you need to close this phabricator revision and create a new one to get
your initial comments and the patch onto cfe-commits.
> On 2017-Feb-02, at 16:18, Matthias Braun via Phabricator
> wrote:
>
> MatzeB added a subscriber: cfe-commits.
> MatzeB added a comment.
>
> Add cfe-commits.
ahatanak updated this revision to Diff 86918.
ahatanak added a comment.
Rebase
https://reviews.llvm.org/D25556
Files:
include/clang/Sema/Sema.h
lib/Sema/Sema.cpp
lib/Sema/SemaExpr.cpp
test/SemaObjCXX/blocks.mm
Index: test/SemaObjCXX/blocks.mm
==
rnk added a comment.
Doesn't your fix mean that the tests will fail on a Windows machine that
doesn't have VS because LLVM was built with mingw? Usually in these situations
we provide some way to provide a fake toolchain.
https://reviews.llvm.org/D28365
_
mehdi_amini added a comment.
> My concern with that approach is that we'd just end up playing whack-a-bug.
> It's possible that this fix puts us in a similar situation, but I'm honestly
> at a loss for a better approach. ¯\_(ツ)_/¯ (...And I'd kinda prefer to play
> whack-a-bug with "clang cou
MatzeB added a subscriber: cfe-commits.
MatzeB added a comment.
Add cfe-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D29476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
hamzasood updated this revision to Diff 86900.
hamzasood added a comment.
In https://reviews.llvm.org/D28365#665183, @rnk wrote:
> I had to revert this because it doesn't pass tests on Linux. Can you look
> into that and resubmit after fixing those test failures?
Really sorry about that, I stu
weimingz added a comment.
ping ?
https://reviews.llvm.org/D28526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
I had to revert this because it doesn't pass tests on Linux. Can you look into
that and resubmit after fixing those test failures?
Repository:
rL LLVM
https://reviews.llvm.org/D28365
___
cfe-commits mailing list
cfe-commits@
george.burgess.iv created this revision.
We're currently using a special EvaluationMode to determine whether
we're OK with invalid base expressions during objectsize evaluation.
Using it to figure out how we handle UB/etc. is fine, but I think it's
too far-reaching to use for checking whether we'r
Thanks, James! I think I have only one more substantive comment:
+ (Field->getAccess() == AS_public || Field->getAccess() ==
AS_protected)) {
Have you considered also taking into account the access of the inheritance
path? Eg, a public member of a private base class of a public base clas
r293927 should appease bots.
On Thu, Feb 2, 2017 at 7:59 PM Eric Liu wrote:
This is breaking build bots, and I am trying to fix it. Feel free to revert
the change if this blocks you.
On Thu, Feb 2, 2017 at 6:51 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
Author: ioeric
Dat
Author: ioeric
Date: Thu Feb 2 13:46:12 2017
New Revision: 293927
URL: http://llvm.org/viewvc/llvm-project?rev=293927&view=rev
Log:
[change-namespace] trying to fix build bot failure caused by r293909.
Modified:
clang-tools-extra/trunk/change-namespace/ChangeNamespace.cpp
Modified: clang-to
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293926: Avoid implementation defined behavior in a test.
(authored by danalbert).
Changed prior to commit:
https://reviews.llvm.org/D29197?vs=85961&id=86866#toc
Repository:
rL LLVM
https://reviews.l
Author: danalbert
Date: Thu Feb 2 13:44:11 2017
New Revision: 293926
URL: http://llvm.org/viewvc/llvm-project?rev=293926&view=rev
Log:
Avoid implementation defined behavior in a test.
Summary:
num_put::put uses %p for pointer types, but the exact format of %p is
implementation defined behavior f
Author: rnk
Date: Thu Feb 2 13:36:22 2017
New Revision: 293924
URL: http://llvm.org/viewvc/llvm-project?rev=293924&view=rev
Log:
Revert "[Driver] Updated for Visual Studio 2017"
This reverts commit r293923. It causes test failures on Linux that need
time to debug.
Modified:
cfe/trunk/includ
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293923: [Driver] Updated for Visual Studio 2017 (authored by
rnk).
Changed prior to commit:
https://reviews.llvm.org/D28365?vs=86502&id=86865#toc
Repository:
rL LLVM
https://reviews.llvm.org/D28365
Author: rnk
Date: Thu Feb 2 13:29:46 2017
New Revision: 293923
URL: http://llvm.org/viewvc/llvm-project?rev=293923&view=rev
Log:
[Driver] Updated for Visual Studio 2017
Summary:
The patch updates the MSVC ToolChain for the changes made in Visual
Studio 2017[1].
Other notable changes:
- Path h
joerg added a comment.
Yes, the project is interested on reducing the number of false positives. The
example you gave is *not* a FP, but exactly the kind of situation the warning
is supposed to trigger on.
Repository:
rL LLVM
https://reviews.llvm.org/D20561
__
This is breaking build bots, and I am trying to fix it. Feel free to revert
the change if this blocks you.
On Thu, Feb 2, 2017 at 6:51 PM Eric Liu via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: ioeric
> Date: Thu Feb 2 11:40:38 2017
> New Revision: 293909
>
> URL: http://llvm.org
mati865 added a comment.
I don't know about Linux but on Windows this code was causing issue:
#include
int main() { char buf[PATH_MAX]; }
Include order:
- Before patch: Clang limits.h (lib\\clang\\3.9.1\\include) -> GCC limits.h
(lib\\gcc\\x86_64-w64-mingw32\\6.3.0\\include-fixed) here wh
hamzasood added a comment.
In https://reviews.llvm.org/D28365#664892, @rnk wrote:
> This is ready to land. Do you need someone to commit this?
I think so, yeah.
https://reviews.llvm.org/D28365
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
mati865 created this revision.
mati865 added a project: clang-c.
Header guards in GCC limits.h were stopping Clang from going up one more level
to the system limits.h
https://reviews.llvm.org/D29464
Files:
lib/Driver/MinGWToolChain.cpp
Index: lib/Driver/MinGWToolChain.cpp
=
This revision was automatically updated to reflect the committed changes.
wristow marked an inline comment as done.
Closed by commit rL293911: Prevent ICE in dllexport class with _Atomic data
member (authored by wristow).
Changed prior to commit:
https://reviews.llvm.org/D29208?vs=86767&id=8684
Author: wristow
Date: Thu Feb 2 11:53:34 2017
New Revision: 293911
URL: http://llvm.org/viewvc/llvm-project?rev=293911&view=rev
Log:
Prevent ICE in dllexport class with _Atomic data member
Guard against a null pointer dereference that caused Clang to crash
when processing a class containing an _
rnk added a comment.
This is ready to land. Do you need someone to commit this?
https://reviews.llvm.org/D28365
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293909: [change-namespace] fix unscoped enum constant
references. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D29460?vs=86835&id=86843#toc
Repository:
rL LLVM
https://rev
Author: ioeric
Date: Thu Feb 2 11:40:38 2017
New Revision: 293909
URL: http://llvm.org/viewvc/llvm-project?rev=293909&view=rev
Log:
[change-namespace] fix unscoped enum constant references.
Reviewers: bkramer
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/D29460
Modi
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29460
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ioeric created this revision.
https://reviews.llvm.org/D29460
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/change-namespace/ChangeNamespaceTests.cpp
===
--- uni
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
If you're still considering to submit this patch, could you rebase it (or maybe
re-generate instead?) and split into easier to digest parts?
A couple of things I noticed:
1. `v.push
Author: akirtzidis
Date: Thu Feb 2 10:13:10 2017
New Revision: 293904
URL: http://llvm.org/viewvc/llvm-project?rev=293904&view=rev
Log:
[index] Provide a more general index::generateUSRForMacro() that doesn't depend
on having a PreprocessingRecord.
Modified:
cfe/trunk/include/clang/Index/US
royger added a comment.
Ping?
It's not clear to me whether upstream is going to do something about this or
not. I would like to know in case I need to start passing
"-Waddress-of-packed-member" around.
Repository:
rL LLVM
https://reviews.llvm.org/D20561
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293898: [clang-format] Don't reflow across comment pragmas.
(authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29450?vs=86814&id=86816#toc
Repository:
rL LLVM
https://reviews
Author: krasimir
Date: Thu Feb 2 09:32:19 2017
New Revision: 293898
URL: http://llvm.org/viewvc/llvm-project?rev=293898&view=rev
Log:
[clang-format] Don't reflow across comment pragmas.
Summary:
The comment reflower wasn't taking comment pragmas as reflow stoppers. This
patch fixes that.
sourc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293897: [change-namespace] check using shadow decl correctly
when shortening namespace… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D29447?vs=86795&id=86815#toc
Repository:
Author: ioeric
Date: Thu Feb 2 09:29:54 2017
New Revision: 293897
URL: http://llvm.org/viewvc/llvm-project?rev=293897&view=rev
Log:
[change-namespace] check using shadow decl correctly when shortening namespace
specifiers.
Summary:
This fixes mismatch between template decls and template special
krasimir updated this revision to Diff 86814.
krasimir added a comment.
- Merge branch 'master' into arcpatch-D29450_1
https://reviews.llvm.org/D29450
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
lib/Format/UnwrappedLineParser.cpp
krasimir updated this revision to Diff 86813.
krasimir edited the summary of this revision.
krasimir added a comment.
- Add a break in line comment sections by pragmas
https://reviews.llvm.org/D29450
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationI
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D29447
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Makes sense.
https://reviews.llvm.org/D29450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
krasimir added a comment.
Ideally, we may try doing both: break a line comment section token steam and
keep this too. What do you think?
https://reviews.llvm.org/D29450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: krasimir
Date: Thu Feb 2 08:36:50 2017
New Revision: 293891
URL: http://llvm.org/viewvc/llvm-project?rev=293891&view=rev
Log:
[clang-format] Fix breaking of comment sections in unwrapped lines containing
newlines.
Summary:
The breaking of line comment sections was misaligning the case w
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293891: [clang-format] Fix breaking of comment sections in
unwrapped lines containing… (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29444?vs=86790&id=86802#toc
Repository:
krasimir added a comment.
That sounds reasonable. However it won't work with comment pragmas in newlines
in block comments.
The root issue that I was looking at was a taze directive inside a block
comment in a random typescript file, like:
/* random stuff
* long long long long
* taze
djasper added a comment.
I am bit unsure about the design here. Could we instead match against the
CommentPragmas and then not even create a BreakableToken (or reflow) if that
matches?
I guess that would make us unable to reflow if only part of the comment is a
pragma, but that seems ok (for n
krasimir accepted this revision.
krasimir added a comment.
This revision is now accepted and ready to land.
looks good!
https://reviews.llvm.org/D29451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
bkramer created this revision.
Herald added a subscriber: mgorny.
clangd is a language server protocol implementation based on clang. It's
supposed to provide editor integration while not suffering from the
confined ABI of libclang.
This implementation is limited to the bare minimum functionality
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Nice :)
https://reviews.llvm.org/D29444
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
ioeric created this revision.
This fixes mismatch between template decls and template specialization decls.
Also added a few more test cases.
https://reviews.llvm.org/D29447
Files:
change-namespace/ChangeNamespace.cpp
unittests/change-namespace/ChangeNamespaceTests.cpp
Index: unittests/ch
Author: asiri
Date: Thu Feb 2 05:56:26 2017
New Revision: 293881
URL: http://llvm.org/viewvc/llvm-project?rev=293881&view=rev
Log:
Extend XFAIL to c++98.
NFC.
Modified:
libcxx/trunk/test/std/diagnostics/syserr/syserr.errcode/syserr.errcode.observers/bool.fail.cpp
Modified:
libcxx/trunk/t
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293878: [clang-format] Don't reflow lines starting with
TODO, FIXME or XXX. (authored by krasimir).
Changed prior to commit:
https://reviews.llvm.org/D29396?vs=86643&id=86781#toc
Repository:
rL LLVM
Author: krasimir
Date: Thu Feb 2 04:52:08 2017
New Revision: 293878
URL: http://llvm.org/viewvc/llvm-project?rev=293878&view=rev
Log:
[clang-format] Don't reflow lines starting with TODO, FIXME or XXX.
Summary: These lines commonly carry a special meaning.
Reviewers: djasper
Reviewed By: djasp
Author: asiri
Date: Thu Feb 2 04:35:18 2017
New Revision: 293877
URL: http://llvm.org/viewvc/llvm-project?rev=293877&view=rev
Log:
Improve docs: Add missing #pragma push directive.
NFC.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
http://llvm.org/
Thanks!
On 1 February 2017 at 18:57, Hans Wennborg wrote:
> OK. Merged in r293797.
>
> Thanks,
> Hans
>
> On Wed, Feb 1, 2017 at 9:50 AM, Alex L wrote:
> > Hi Hans,
> >
> > Would it be possible to merge this for 4.0?
> >
> > Cheers,
> > Alex
> >
> > On 1 February 2017 at 17:37, Alex Lorenz via
Author: djasper
Date: Thu Feb 2 02:30:21 2017
New Revision: 293875
URL: http://llvm.org/viewvc/llvm-project?rev=293875&view=rev
Log:
clang-format: Do not use two-argument/operand special case with no alignment
Without alignment, there is no clean separation between the arguments, even if
there a
This revision was automatically updated to reflect the committed changes.
Closed by commit rL293874: [analyzer] Fix an assertion fail in
CStringSyntaxChecker. (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D29384?vs=86599&id=86773#toc
Repository:
rL LLVM
https://revi
Author: xazax
Date: Thu Feb 2 02:20:54 2017
New Revision: 293874
URL: http://llvm.org/viewvc/llvm-project?rev=293874&view=rev
Log:
[analyzer] Fix an assertion fail in CStringSyntaxChecker.
Differential Revision: https://reviews.llvm.org/D29384
Modified:
cfe/trunk/lib/StaticAnalyzer/Checker
vsk added a comment.
In https://reviews.llvm.org/D29437#664379, @regehr wrote:
> Does this check need to be sensitive to the dialect of C/C++ that the user
> asked for? I know that it used to be the case that the standard could be read
> either way for this case, but as you observe it is now un
Hi Richard
Thanks for the feedback! Hopefully addressed!
Thanks
James
From: on behalf of Richard Smith
Date: Wednesday, February 1, 2017 at 3:50 PM
To: James Sun
Cc: Saleem Abdulrasool , "cfe-commits@lists.llvm.org"
, Aaron Ballman
Subject: Re: Add warning for c++ member variable shadowi
Author: gbiv
Date: Thu Feb 2 01:53:55 2017
New Revision: 293871
URL: http://llvm.org/viewvc/llvm-project?rev=293871&view=rev
Log:
Fix typo. NFC
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
Modified: cfe/trunk/lib/AST/ExprConstant.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/A
70 matches
Mail list logo
