halyavin added inline comments.
Comment at: include/__threading_support:474
+
system_clock::time_point(duration_cast(duration));
+ auto timeout_ms = duration_cast(abstime - system_clock::now());
+
Since negative timeouts can't be avoided, we must make sure
Author: dylanmckay
Date: Thu Jan 5 01:17:46 2017
New Revision: 291090
URL: http://llvm.org/viewvc/llvm-project?rev=291090&view=rev
Log:
[AVR] Revert the functional part of r291083
As Senthil points out, this is unnecessary as we already have these
registers in AddlRegNames.
Modified:
cfe/tr
I see, that's a good idea.
I'll revert r291083 and we can go forward with this patch.
On Thu, Jan 5, 2017 at 8:05 PM, Senthil Kumar Selvaraj via Phabricator <
revi...@reviews.llvm.org> wrote:
> saaadhu added a comment.
>
> If you've added X, Y, Z and SP to GCCRegNames, you don't need AddlRegName
Hahnfeld added a subscriber: cfe-commits.
Hahnfeld added a comment.
Otherwise SGTM
Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252
+ // \brief Flags associated the device global.
+ int32_t Flags;
+
Is that intentionally not in the `protected` sectio
saaadhu added a comment.
If you've added X, Y, Z and SP to GCCRegNames, you don't need AddlRegNames
array at all,
The reason I had them in AddlRegNames was to tell Clang that they alias regs in
GCCRegNames. I followed X86TargetInfo's example - it has "ax" in GCCRegNames,
and "al", "ah", "eax"
EricWF added inline comments.
Comment at: include/memory:1962
+#if _LIBCPP_STD_VER <= 14 || defined(_LIBCPP_NO_REMOVE_AUTOPTR)
template
I would love to have a semi-consistent naming scheme for macros which re-enable
removed C++17 features. Maybe `_LIBCPP_ENA
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
I'm resigning as a reviewer. I suggested an alternative fix and explained why
this fix wasn't correct in a comment above.
Please re-add me as a reviewer if you disagree with my analysis.
https://revi
dylanmckay created this revision.
dylanmckay added a reviewer: jroelofs.
dylanmckay added subscribers: cfe-commits, saaadhu.
Previously the method would simply return false, causing every single
inline assembly constraint to trigger a compile error.
This adds inline assembly constraint support fo
Author: ericwf
Date: Thu Jan 5 00:06:18 2017
New Revision: 291087
URL: http://llvm.org/viewvc/llvm-project?rev=291087&view=rev
Log:
[libcxx] Fix PR31402: map::__find_equal_key has undefined behavior.
Summary:
This patch fixes llvm.org/PR31402 by replacing `map::__find_equal_key` with
`__tree::
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D28131#632516, @vsk wrote:
> LGTM. I'm not sure what to do for a test. Have you tried checking the IR for
> the affected object fil
EricWF added inline comments.
Comment at: include/typeinfo:75
+#elif defined(_WIN32)
+#define _LIBCPP_HAS_WINDOWS_TYPEINFO
+#else
compnerd wrote:
> rnk wrote:
> > Is _WIN32 the right condition? It seems like this is intended to match the
> > MS ABI RTTI structur
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
This LGTM. I'm sure we can flush out any bugs once we get the tests running.
Repository:
rL LLVM
https://reviews.llvm.org/D28220
___
cfe-comm
dylanmckay created this revision.
dylanmckay added a reviewer: saaadhu.
dylanmckay added a subscriber: cfe-commits.
These do not match up with the register numbers defined in LLVM's
AVRRegisterInfo.td
Adding Senthil as a reviewer as he originally implemented this.
https://reviews.llvm.org/D2834
Author: dylanmckay
Date: Wed Jan 4 23:31:12 2017
New Revision: 291083
URL: http://llvm.org/viewvc/llvm-project?rev=291083&view=rev
Log:
[AVR] Support r26 through r31 in inline assembly
These are synonyms for the X,Y, and Z registers.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291082: Add AVR target and toolchain to Clang (authored by
dylanmckay).
Changed prior to commit:
https://reviews.llvm.org/D27123?vs=80721&id=83191#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
Author: dylanmckay
Date: Wed Jan 4 23:20:27 2017
New Revision: 291082
URL: http://llvm.org/viewvc/llvm-project?rev=291082&view=rev
Log:
Add AVR target and toolchain to Clang
Summary:
Authored by Senthil Kumar Selvaraj
This patch adds barebones support in Clang for the (experimental) AVR target.
Author: ericwf
Date: Wed Jan 4 23:18:37 2017
New Revision: 291081
URL: http://llvm.org/viewvc/llvm-project?rev=291081&view=rev
Log:
Fix test suite configuration when no lit.site.cfg is available
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libcxx/test/config
dylanmckay added a comment.
Signed off by Jonathan Roelofs via cfe-commits
https://reviews.llvm.org/D27123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rsmith
Date: Wed Jan 4 22:16:30 2017
New Revision: 291075
URL: http://llvm.org/viewvc/llvm-project?rev=291075&view=rev
Log:
Per [temp.deduct.call], do not deduce an array bound of 0 from an empty
initializer list.
Modified:
cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp
cfe/trunk/
george.burgess.iv added a comment.
Do we have a page that details when we should/shouldn't use `auto`? I was under
the impression that it was preferred only in cases where the type's spelled out
(e.g. `cast`, ...). (To be clear, I'm happy to use it in loops, too; I'd
just like to know if we hav
george.burgess.iv updated this revision to Diff 83188.
george.burgess.iv marked 18 inline comments as done.
george.burgess.iv added a comment.
Addressed all feedback + made `diagnose_if` late-parsed.
https://reviews.llvm.org/D27424
Files:
include/clang/AST/Expr.h
include/clang/Basic/Attr.td
Author: rsmith
Date: Wed Jan 4 22:08:31 2017
New Revision: 291074
URL: http://llvm.org/viewvc/llvm-project?rev=291074&view=rev
Log:
Factor out more common logic in template argument deduction from function call
arguments.
No functionality change intended.
Modified:
cfe/trunk/lib/Sema/SemaT
Author: ericwf
Date: Wed Jan 4 21:57:40 2017
New Revision: 291072
URL: http://llvm.org/viewvc/llvm-project?rev=291072&view=rev
Log:
Get test-suite configuring on Windows with clang-cl
This patch gets the test suite "working" on Windows, although
none of the tests pass.
In order to reuse the exi
compnerd updated this revision to Diff 83182.
compnerd marked an inline comment as done.
compnerd added a comment.
Fix `__libcpp_condvar_timedwait` parameter usage (absolute vs relative time)
Repository:
rL LLVM
https://reviews.llvm.org/D28220
Files:
include/__config
include/__threading_
compnerd marked an inline comment as done.
compnerd added inline comments.
Comment at: include/__threading_support:458
+ __libcpp_mutex_reference&& __m,
+ timespec* __ts)
+{
halyavin wrote:
> In posix, p
compnerd updated this revision to Diff 83178.
compnerd added a comment.
Address a number of review comments.
Repository:
rL LLVM
https://reviews.llvm.org/D28220
Files:
include/__config
include/__threading_support
Index: include/__threading_support
===
compnerd marked 6 inline comments as done.
compnerd added inline comments.
Comment at: include/__threading_support:527
+static inline _LIBCPP_ALWAYS_INLINE unsigned int WINAPI
+__libcpp_thread_trampoline(void *__data)
+{
rnk wrote:
> halyavin wrote:
> > Trampolin
compnerd updated the summary for this revision.
compnerd updated this revision to Diff 83174.
Repository:
rL LLVM
https://reviews.llvm.org/D28220
Files:
include/__config
include/__threading_support
Index: include/__threading_support
ahatanak added a comment.
I found another problem with the current patch: it can generate IR that doesn't
pass asan's use-after-scope check. For example, IRGen generates the following
IR for function move_lifetime_start in lifetime2.c when this patch is applied:
entry:
%i = alloca i32, al
smeenai added a comment.
Adding cfe-commits as a subscriber after diff creation won't send the email out
AFAIK. You'll have to re-upload the patch.
Repository:
rL LLVM
https://reviews.llvm.org/D28338
___
cfe-commits mailing list
cfe-commits@list
compnerd abandoned this revision.
compnerd added a comment.
Superceded by https://reviews.llvm.org/D28338
Repository:
rL LLVM
https://reviews.llvm.org/D28226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
rsmith added a comment.
Sorry I missed this =( Thanks for the fix!
https://reviews.llvm.org/D26893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
This is a potentially significant pessimization. Can you turn this into a
range iterator of some sort?
https://reviews.llvm.org/D28310
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
Author: rsmith
Date: Wed Jan 4 20:55:10 2017
New Revision: 291065
URL: http://llvm.org/viewvc/llvm-project?rev=291065&view=rev
Log:
PR31540: install libc++abi headers into include/c++/v1 in build area.
This allows an in-build-area clang binary to find .
Modified:
libcxx/trunk/cmake/Modules/
erik.pilkington abandoned this revision.
erik.pilkington added a comment.
@rsmith fixed this in r291064.
https://reviews.llvm.org/D26893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
Author: rsmith
Date: Wed Jan 4 20:31:32 2017
New Revision: 291064
URL: http://llvm.org/viewvc/llvm-project?rev=291064&view=rev
Log:
Fix assertion failure on deduction failure due to too short template argument
list.
We were previously incorrectly using TDK_TooFewArguments to report a template
a
Author: ericwf
Date: Wed Jan 4 19:34:14 2017
New Revision: 291060
URL: http://llvm.org/viewvc/llvm-project?rev=291060&view=rev
Log:
Fix XPASS buildbot failure related to structured bindings
The test was previously set to XFAIL if __cpp_structured_bindings
wasn't defined. However there are Clang
Author: ericwf
Date: Wed Jan 4 19:28:40 2017
New Revision: 291059
URL: http://llvm.org/viewvc/llvm-project?rev=291059&view=rev
Log:
Fix PR26961 - Add default constructor to std::pointer_safety struct.
In ABI v1 libc++ implements std::pointer_safety as a class type instead
of an enumeration. Howe
Author: gbiv
Date: Wed Jan 4 19:21:21 2017
New Revision: 291058
URL: http://llvm.org/viewvc/llvm-project?rev=291058&view=rev
Log:
[Sema] Mark undefined ctors as deleted. NFC.
Looks like these functions exist just to prevent bad implicit
conversions. Rather than waiting for the linker to complain
jlebar marked an inline comment as done.
jlebar added inline comments.
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:76
+
+// For inscrutible reasons, the CUDA headers define these functions for us on
+// Windows.
tra wrote:
> inscrut__a__ble?
Thanks. :)
Author: ericwf
Date: Wed Jan 4 19:15:42 2017
New Revision: 291046
URL: http://llvm.org/viewvc/llvm-project?rev=291046&view=rev
Log:
Fix std::pointer_safety type in ABI v2
In the C++ standard `std::pointer_safety` is defined
as a C++11 strongly typed enum. However libc++ currently defines
it as a
jlebar marked an inline comment as done.
jlebar added a comment.
Thank you for the reviews!
Comment at: clang/lib/Driver/ToolChains.cpp:1819
Args.getLastArgValue(options::OPT_cuda_path_EQ));
- else {
+ else if (HostTriple.isOSLinux() || HostTriple.isMacOSX()) {
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291045: [MS] Instantiate default args during instantiation
of exported default ctors (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D28274?vs=83059&id=83170#toc
Repository:
rL L
Author: rnk
Date: Wed Jan 4 19:08:22 2017
New Revision: 291045
URL: http://llvm.org/viewvc/llvm-project?rev=291045&view=rev
Log:
[MS] Instantiate default args during instantiation of exported default ctors
Summary:
Replace some old code that probably pre-dated the change to delay
emission of dll
Hello everyone,
Below are some buildbot numbers for the last week of 12/25/2016 -
12/31/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
Hello everyone,
Below are some buildbot numbers for the last week of 12/18/2016 -
12/24/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Headers/__clang_cuda_cmath.h:76
+
+// For inscrutible reasons, the CUDA headers define these functions for us on
+// Windows.
inscrut__a_
howard.hinnant added inline comments.
Comment at: src/chrono.cpp:218
+#error "Never use CLOCK_MONOTONIC for steady_clock::now on Apple platforms"
+#endif
+
Nice, thanks!
https://reviews.llvm.org/D27429
___
cfe-comm
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/ToolChains.cpp:1819
Args.getLastArgValue(options::OPT_cuda_path_EQ));
- else {
+ else if (HostTriple.isOSLinux() || HostTriple.isMacOSX(
timshen added a comment.
In https://reviews.llvm.org/D27872#636149, @echristo wrote:
> I'm pretty sure I've never seen return widely used in
> the code base versus my suggestion. That said, if you've looked and it's
> roughly 50/50 then I care a lot less (and we can bike shed in some separate
ehsan created this revision.
ehsan added reviewers: bkramer, alexfh, klimek.
ehsan added a subscriber: cfe-commits.
Herald added a subscriber: JDevlieghere.
These flags allow specifying extra arguments to the tool's command
line which don't appear in the compilation database.
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291041: Correct Vectorcall Register passing and HVA Behavior
(authored by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D27529?vs=83116&id=83164#toc
Repository:
rL LLVM
https://revi
Author: erichkeane
Date: Wed Jan 4 18:20:51 2017
New Revision: 291041
URL: http://llvm.org/viewvc/llvm-project?rev=291041&view=rev
Log:
Correct Vectorcall Register passing and HVA Behavior
Front end component (back end changes are D27392). The vectorcall
calling convention was broken subtly in
bruno updated this revision to Diff 83158.
bruno added a comment.
Thanks for the reviews. @howard.hinnant thanks for the great explanation &
examples.
Attached a new version of the patch, addressing all suggestions. The logic
became a bit simpler after Saleem's r290804, which already moved the
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
https://reviews.llvm.org/D27529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D28317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D28318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna updated this revision to Diff 83160.
zaks.anna added a comment.
Addressed all comments
https://reviews.llvm.org/D28330
Files:
lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp
test/Analysis/keychainAPI.m
Index: test/Analysis/keychainAPI.m
===
Author: ericwf
Date: Wed Jan 4 18:04:37 2017
New Revision: 291039
URL: http://llvm.org/viewvc/llvm-project?rev=291039&view=rev
Log:
Fix Sphinx build error caused by bad indentation
Modified:
libcxx/trunk/docs/DesignDocs/VisibilityMacros.rst
Modified: libcxx/trunk/docs/DesignDocs/VisibilityM
Author: chandlerc
Date: Wed Jan 4 17:57:25 2017
New Revision: 291036
URL: http://llvm.org/viewvc/llvm-project?rev=291036&view=rev
Log:
[gtest] The way EXPECT_TEST now works after upgrading gtest triggers an
ODR use. These traits don't have a definition as they're intended to be
used strictly at c
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks good to me, aside from minor quibbles about capitalization and variable
naming.
Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:502
+
EricWF closed this revision.
EricWF added a comment.
Committed in r291035.
https://reviews.llvm.org/D28174
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting since there were no objections.
https://reviews.llvm.org/D28174
___
cfe-commits mailing list
cfe-commi
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:527
+ if (ReturnSymbol)
+for (AllocatedDataTy::iterator I = ASet.begin(), E = ASet.end();
+ I != E; ++I) {
alexshap wrote:
>
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MacOSKeychainAPIChecker.cpp:527
+ if (ReturnSymbol)
+for (AllocatedDataTy::iterator I = ASet.begin(), E = ASet.end();
+ I != E; ++I) {
nit: auto I = ...
benlangmuir added a comment.
Can we test the already-validated diagnostics?
Comment at: include/clang/Basic/FileManager.h:176
+ /// Manage memory buffers associated with pcm files.
+ std::unique_ptr BufferMgr;
+
Why is this inside the FileManager? It isn't us
Author: rsmith
Date: Wed Jan 4 17:45:01 2017
New Revision: 291034
URL: http://llvm.org/viewvc/llvm-project?rev=291034&view=rev
Log:
Only instantiate members of nested classes in local classes once, rather than
once per enclosing class.
Modified:
cfe/trunk/lib/Sema/SemaTemplateInstantiateDec
Author: ericwf
Date: Wed Jan 4 17:35:51 2017
New Revision: 291032
URL: http://llvm.org/viewvc/llvm-project?rev=291032&view=rev
Log:
Fix private inheritance in C++03 tuple_size
Modified:
libcxx/trunk/include/__tuple
Modified: libcxx/trunk/include/__tuple
URL:
http://llvm.org/viewvc/llvm-pro
Author: ericwf
Date: Wed Jan 4 17:30:06 2017
New Revision: 291031
URL: http://llvm.org/viewvc/llvm-project?rev=291031&view=rev
Log:
Fix verify test on 32 bit systems
Modified:
libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.helper/tuple_size_incomplete.fail.cpp
Modified:
libcxx/tr
echristo added a comment.
In https://reviews.llvm.org/D27872#636147, @timshen wrote:
> In https://reviews.llvm.org/D27872#636130, @echristo wrote:
>
> > Looks pretty weird. Typically I'd suggest just:
> >
> > if (foo) {
> >
> > Foo();
> > return;
> >
> > }
> >
> > since that will keep cogniti
Author: rsmith
Date: Wed Jan 4 17:14:16 2017
New Revision: 291030
URL: http://llvm.org/viewvc/llvm-project?rev=291030&view=rev
Log:
Bail out if we try to build a DeclRefExpr naming an invalid declaration.
Most code paths would already bail out in this case, but certain paths,
particularly overlo
timshen added a comment.
In https://reviews.llvm.org/D27872#636130, @echristo wrote:
> Looks pretty weird. Typically I'd suggest just:
>
> if (foo) {
>
> Foo();
> return;
>
> }
>
> since that will keep cognitive overhead to a minimum.
>
> -eric
>
> > Other functions are not controversial.
I
echristo added a comment.
In https://reviews.llvm.org/D27872#628212, @timshen wrote:
> I changed type style to early return.
>
> For constructors and destructors, I use:
>
> if (...) {
> // statement;
> return;
> }
>
>
> For normal functions that returns void, I chose:
>
> if (..
Author: marshall
Date: Wed Jan 4 17:03:24 2017
New Revision: 291028
URL: http://llvm.org/viewvc/llvm-project?rev=291028&view=rev
Log:
Implement P0505: 'Wording for GB 50'
Modified:
libcxx/trunk/include/chrono
libcxx/trunk/test/std/utilities/time/time.duration/time.duration.arithmetic/op
jlebar added a comment.
Thank you for the review!
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
aaron.ballman wrote:
> jlebar wrote:
> > aaron.ballman wrote:
> > > jlebar wro
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
After getting some realtime clarifications in IRC, I now understand better why
this is needed. This patch LGTM! The documentation points I raised are still
valid, but are by no m
zaks.anna created this revision.
zaks.anna added a reviewer: dcoughlin.
zaks.anna added subscribers: cfe-commits, dergachev.a.
The checker has several false positives that this patch addresses:
1. Do not check if the return status has been compared to error (or no error)
at the time when leaks
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting and Closing. This was committed in r290878.
https://reviews.llvm.org/D28229
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
Author: ericwf
Date: Wed Jan 4 16:43:08 2017
New Revision: 291021
URL: http://llvm.org/viewvc/llvm-project?rev=291021&view=rev
Log:
Use C++11 static_assert in variant tests. Patch from Michael Park
Modified:
libcxx/trunk/test/libcxx/utilities/variant/variant.variant/variant.ctor/copy.pass.c
Author: gbiv
Date: Wed Jan 4 16:43:01 2017
New Revision: 291020
URL: http://llvm.org/viewvc/llvm-project?rev=291020&view=rev
Log:
[Parse] Don't ignore attributes after a late-parsed attr.
Without this, we drop everything after the first late-parsed attribute
in a single __attribute__. (Where "dr
djasper added inline comments.
Comment at: lib/Basic/Diagnostic.cpp:179
+
+ // 2nd most frequent case: L is before the first diag state change.
+ FullSourceLoc FirstStateChangePos = DiagStatePoints[1].Loc;
rsmith wrote:
> djasper wrote:
> > rsmith wrote:
> > >
Author: ericwf
Date: Wed Jan 4 16:38:46 2017
New Revision: 291019
URL: http://llvm.org/viewvc/llvm-project?rev=291019&view=rev
Log:
[libcxx] Re-implement LWG 2770 again: Fix tuple_size to work with structured
bindings
Summary:
This patch attempts to re-implement a fix for LWG 2770, but not the
EricWF updated this revision to Diff 83145.
EricWF added a comment.
Updating with final changes.
https://reviews.llvm.org/D28222
Files:
include/__tuple
test/libcxx/test/config.py
test/std/utilities/tuple/tuple.tuple/tuple.helper/tuple_size.pass.cpp
test/std/utilities/tuple/tuple.tuple/
Author: dblaikie
Date: Wed Jan 4 16:36:43 2017
New Revision: 291018
URL: http://llvm.org/viewvc/llvm-project?rev=291018&view=rev
Log:
Fix for LLVM Bitcode API change (to use std::shared_ptr)
Modified:
cfe/trunk/lib/Frontend/SerializedDiagnosticPrinter.cpp
cfe/trunk/lib/Frontend/TestModul
Author: dblaikie
Date: Wed Jan 4 16:36:39 2017
New Revision: 291017
URL: http://llvm.org/viewvc/llvm-project?rev=291017&view=rev
Log:
Remove use of intrusive ref count ownership acquisition
The one use of CheckerManager (AnalysisConsumer, calling
createCheckerManager) keeps a strong reference to
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM minus the `config.py` changes, but those were discussed offline.
Also I prefer to write new `.fail.cpp` tests using clang verify. It allows fail
tests to contain more than one test case,
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
jlebar wrote:
> aaron.ballman wrote:
> > jlebar wrote:
> > > aaron.ballman wrote:
> > > > For
echristo added a comment.
LGTM.
Thanks!
-eric
https://reviews.llvm.org/D28037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen updated this revision to Diff 83140.
timshen added a comment.
Update comments, and move llvm changes to another patch.
https://reviews.llvm.org/D28037
Files:
clang/lib/Headers/altivec.h
clang/test/CodeGen/builtins-ppc-altivec.c
Index: clang/test/CodeGen/builtins-ppc-altivec.c
=
rsmith added inline comments.
Comment at: lib/Basic/Diagnostic.cpp:179
+
+ // 2nd most frequent case: L is before the first diag state change.
+ FullSourceLoc FirstStateChangePos = DiagStatePoints[1].Loc;
djasper wrote:
> rsmith wrote:
> > It's surprising to me
jlebar added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
aaron.ballman wrote:
> jlebar wrote:
> > aaron.ballman wrote:
> > > For my own edification, do you h
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
jlebar wrote:
> aaron.ballman wrote:
> > For my own edification, do you have a link to some d
malcolm.parsons added subscribers: cfe-commits, malcolm.parsons.
malcolm.parsons added a comment.
A mailing list cannot review.
https://reviews.llvm.org/D28315
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: rsmith
Date: Wed Jan 4 16:03:59 2017
New Revision: 291014
URL: http://llvm.org/viewvc/llvm-project?rev=291014&view=rev
Log:
Fix failure to treat overloaded function in braced-init-list as a non-deduced
context.
Previously, if an overloaded function in a braced-init-list was encountered
compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.
This seems much better organized I think, and easier to follow. Thanks for the
docs on the various options!
https://reviews.llvm.org/D28316
___
jlebar added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
aaron.ballman wrote:
> For my own edification, do you have a link to some documentation of what CUDA
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:604
+// CUDA attributes are spelled __attribute__((attr)) or __declspec(__attr__).
+
For my own edification, do you have a link to
jlebar created this revision.
jlebar added subscribers: llvm-commits, cfe-commits.
https://reviews.llvm.org/D28326
Files:
llvm/docs/CompileCudaWithLLVM.rst
Index: llvm/docs/CompileCudaWithLLVM.rst
===
--- llvm/docs/CompileCudaWit
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
MSVC seems to use "__in" and "__out" for its own purposes, so we have to
pick different names in this macro.
https://reviews.llvm.org/D28325
Files:
clang/lib/Headers/__clang_cuda_intrinsics.h
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
https://reviews.llvm.org/D28324
Files:
clang/lib/Headers/__clang_cuda_cmath.h
Index: clang/lib/Headers/__clang_cuda_cmath.h
===
-
1 - 100 of 218 matches
Mail list logo
