Hahnfeld added a comment.
ping
https://reviews.llvm.org/D25669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
ping
https://reviews.llvm.org/D26244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: clang-move/ClangMove.h:90
+
+// When moving all declarations in old header, all code in old.h/cc will be
+// moved.
Is this the right place for this comment? Seems a bit unexpected.
Comment at: unittest
Thanks!
~Craig
On Wed, Nov 23, 2016 at 3:38 AM, Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rksimon
> Date: Wed Nov 23 05:38:52 2016
> New Revision: 287755
>
> URL: http://llvm.org/viewvc/llvm-project?rev=287755&view=rev
> Log:
> [X86][AVX512VL] Add missing _mm25
Author: dyung
Date: Wed Nov 23 19:53:38 2016
New Revision: 287851
URL: http://llvm.org/viewvc/llvm-project?rev=287851&view=rev
Log:
Make these tests work more reliably with Release builds.
Differential Revision: https://reviews.llvm.org/D26827
Modified:
cfe/trunk/test/OpenMP/for_simd_codegen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287851: Make these tests work more reliably with Release
builds. (authored by dyung).
Changed prior to commit:
https://reviews.llvm.org/D26827?vs=78449&id=79181#toc
Repository:
rL LLVM
https://revie
Author: joerg
Date: Wed Nov 23 19:24:38 2016
New Revision: 287847
URL: http://llvm.org/viewvc/llvm-project?rev=287847&view=rev
Log:
Spelling.
Modified:
cfe/trunk/include/clang/Tooling/JSONCompilationDatabase.h
Modified: cfe/trunk/include/clang/Tooling/JSONCompilationDatabase.h
URL:
http://l
Hello everyone,
Below are some buildbot numbers for the last week of 11/13/2016 -
11/19/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status fro
hiraditya created this revision.
hiraditya added reviewers: mclow.lists, EricWF.
hiraditya added subscribers: sebpop, cfe-commits.
Improving string::find such that it ultimately gets converted to calls to
memchr and memcmp. This is an intermediate patch to see if there is an interest
in this opti
vangyzen added inline comments.
Comment at:
test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:65
+{
+expected = *std::localeconv()->thousands_sep;
+(void) std::setlocale(LC_NUMERIC, "C");
STL_MSFT added a comment.
As yet another alternative, I could keep the ios_base::openmode tests in
ifstream.cons, but use ios_base::binary instead of ios_base::out.
https://reviews.llvm.org/D26814
___
cfe-commits mailing list
cfe-commits@lists.llvm
fhahn created this revision.
fhahn added a reviewer: rafael.
fhahn added a subscriber: cfe-commits.
Herald added a subscriber: dschuff.
This patch adds a check and an error message to gnutools::Linker::ConstructJob
in case the architecture is not supported. For most other operating systems,
the
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287829.
https://reviews.llvm.org/D27027
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287828.
https://reviews.llvm.org/D27026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287827.
https://reviews.llvm.org/D27020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287826.
https://reviews.llvm.org/D27019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287825.
https://reviews.llvm.org/D27018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287824.
https://reviews.llvm.org/D27016
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287823.
https://reviews.llvm.org/D27015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287822.
https://reviews.llvm.org/D27014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT closed this revision.
STL_MSFT added a comment.
Thanks, r287820.
https://reviews.llvm.org/D27013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: stl_msft
Date: Wed Nov 23 16:03:28 2016
New Revision: 287829
URL: http://llvm.org/viewvc/llvm-project?rev=287829&view=rev
Log:
[libcxx] [test] D27027: Strip trailing whitespace.
Modified:
libcxx/trunk/test/std/algorithms/alg.sorting/alg.clamp/clamp.comp.pass.cpp
libcxx/trunk/test/
Author: stl_msft
Date: Wed Nov 23 16:02:59 2016
New Revision: 287828
URL: http://llvm.org/viewvc/llvm-project?rev=287828&view=rev
Log:
[libcxx] [test] D27026: Fix copy-paste silliness; ULL can't ever be 32-bit.
Modified:
libcxx/trunk/test/std/localization/locale.categories/category.numeric/l
Author: stl_msft
Date: Wed Nov 23 16:02:53 2016
New Revision: 287827
URL: http://llvm.org/viewvc/llvm-project?rev=287827&view=rev
Log:
[libcxx] [test] D27020: Fix MSVC warning C4245 "conversion from 'X' to 'Y',
signed/unsigned mismatch", part 7/12.
When initializing unsigned integers to their ma
Author: stl_msft
Date: Wed Nov 23 16:02:44 2016
New Revision: 287826
URL: http://llvm.org/viewvc/llvm-project?rev=287826&view=rev
Log:
[libcxx] [test] D27019: Fix MSVC warning C4245 "conversion from 'X' to 'Y',
signed/unsigned mismatch", part 6/12.
Add static_cast when initializing unsigned inte
Author: stl_msft
Date: Wed Nov 23 16:02:16 2016
New Revision: 287823
URL: http://llvm.org/viewvc/llvm-project?rev=287823&view=rev
Log:
[libcxx] [test] D27015: Fix MSVC warning C4018 "signed/unsigned mismatch", part
3/12.
Change unsigned to int in parameters.
Modified:
libcxx/trunk/test/std
Author: stl_msft
Date: Wed Nov 23 16:02:35 2016
New Revision: 287825
URL: http://llvm.org/viewvc/llvm-project?rev=287825&view=rev
Log:
[libcxx] [test] D27018: Fix MSVC warning C4018 "signed/unsigned mismatch", part
5/12.
Various changes:
test/std/algorithms/alg.sorting/alg.binary.search/binary.
Author: stl_msft
Date: Wed Nov 23 16:02:27 2016
New Revision: 287824
URL: http://llvm.org/viewvc/llvm-project?rev=287824&view=rev
Log:
[libcxx] [test] D27016: Fix MSVC warning C4018 "signed/unsigned mismatch", part
4/12.
Change "int j;" indices to "std::size_t j;".
Also, include when it wasn't
Author: stl_msft
Date: Wed Nov 23 16:01:58 2016
New Revision: 287822
URL: http://llvm.org/viewvc/llvm-project?rev=287822&view=rev
Log:
[libcxx] [test] D27014: Fix MSVC warning C4018 "signed/unsigned mismatch", part
2/12.
Add static_cast when comparing int to std::size_t.
Also, include when it
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Looks good for trunk and 3.9 branch.
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
JDevlieghere abandoned this revision.
JDevlieghere added a comment.
I'm abandoning this revision because I think this check is getting overly
complex. There's still the problem of supporting arguments that can have side
effects, and then there's also the unaddressed issue of code possibly using
erik.pilkington added a comment.
Ping!
https://reviews.llvm.org/D24639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
I'm ok with these changes but please check that tests are still working on
Windows
https://reviews.llvm.org/D26827
___
cfe-commits mailing lis
Author: amehsan
Date: Wed Nov 23 12:55:17 2016
New Revision: 287796
URL: http://llvm.org/viewvc/llvm-project?rev=287796&view=rev
Log:
[PPC] revert r287795
A test that passed locally is failing on one of the build bots.
Modified:
cfe/trunk/lib/Headers/altivec.h
cfe/trunk/test/CodeGen/buil
Author: amehsan
Date: Wed Nov 23 12:36:29 2016
New Revision: 287795
URL: http://llvm.org/viewvc/llvm-project?rev=287795&view=rev
Log:
[PPC] support for arithmetic builtins in the FE
(commit again after fixing the buildbot failures)
This adds various overloads of the following builtins to altivec.
On Wed, Nov 23, 2016 at 9:06 AM, Nico Weber wrote:
> Cool, thanks! Should we also have a test for using a default arg with a
> pch? Now that ASTContext doesn't have this table any more, it'll work, but
> maybe it's good to have a regression test for the issue in the PR?
>
Sure, r287793.
Author: rnk
Date: Wed Nov 23 12:33:54 2016
New Revision: 287793
URL: http://llvm.org/viewvc/llvm-project?rev=287793&view=rev
Log:
Add dllexport default ctor closure PCH regression test for PR31121
Follow up to r287774
Added:
cfe/trunk/test/PCH/dllexport-default-arg-closure.cpp
Added: cfe/tr
hokein updated this revision to Diff 79120.
hokein added a comment.
Code style.
https://reviews.llvm.org/D27059
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cp
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
- Add -dump_dels option to dump all declarations from old header. It will allow
clang-move used as a frontend to get declarations from header. Further more,
this will make debugging stuff easie
ioeric created this revision.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Do not submit!
https://reviews.llvm.org/D27058
Files:
include/clang/Tooling/Refactoring/EditList.h
lib/Tooling/Refactoring/EditList.cpp
unittests/Tooli
Author: arphaman
Date: Wed Nov 23 10:57:03 2016
New Revision: 287776
URL: http://llvm.org/viewvc/llvm-project?rev=287776&view=rev
Log:
[Sema][Atomics] Treat expected pointer in compare exchange atomics as _Nonnull
This commit teaches clang that is has to emit a warning when NULL is passed
as the
rnk added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:861
// friendship or any other means).
Context.addCopyConstructorForExceptionObject(Subobject, CD);
rsmith wrote:
> It would seem a lot more reasonable to actually form an expression
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287776: [Sema][Atomics] Treat expected pointer in compare
exchange atomics as _Nonnull (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26978?vs=78884&id=79107#toc
Repository:
Cool, thanks! Should we also have a test for using a default arg with a
pch? Now that ASTContext doesn't have this table any more, it'll work, but
maybe it's good to have a regression test for the issue in the PR?
On Wed, Nov 23, 2016 at 11:51 AM, Reid Kleckner via cfe-commits <
cfe-commits@lists.
Author: amehsan
Date: Wed Nov 23 10:56:03 2016
New Revision: 287775
URL: http://llvm.org/viewvc/llvm-project?rev=287775&view=rev
Log:
[PPC] Reverting r287772
Due to buildbot failure, I revert. Will recommit after investigation.
Modified:
cfe/trunk/lib/Headers/altivec.h
cfe/trunk/test/Cod
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287774: Remove C++ default arg side table for MS ABI ctor
closures (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D27007?vs=78965&id=79105#toc
Repository:
rL LLVM
https://revie
Author: rnk
Date: Wed Nov 23 10:51:30 2016
New Revision: 287774
URL: http://llvm.org/viewvc/llvm-project?rev=287774&view=rev
Log:
Remove C++ default arg side table for MS ABI ctor closures
Summary:
We don't need a side table in ASTContext to hold CXXDefaultArgExprs. The
important part of building
ioeric created this revision.
ioeric added a reviewer: klimek.
ioeric added subscribers: djasper, cfe-commits.
Herald added a subscriber: mgorny.
An edit list is used to create and group a set of source edits, e.g.
replacements or header insertions. Edits in an EditList should be related,
e.g. rep
Author: amehsan
Date: Wed Nov 23 10:32:05 2016
New Revision: 287772
URL: http://llvm.org/viewvc/llvm-project?rev=287772&view=rev
Log:
[PPC] support for arithmetic builtins in the FE
This adds various overloads of the following builtins to altivec.h:
vec_neg
vec_nabs
vec_adde
vec_
arphaman created this revision.
arphaman added reviewers: manmanren, akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch provides class property code completion results. It supports
explicit and implicit class properties, but the
Author: arphaman
Date: Wed Nov 23 10:28:34 2016
New Revision: 287771
URL: http://llvm.org/viewvc/llvm-project?rev=287771&view=rev
Log:
[CodeCompletion] Fix incorrect Objective-C block parameter formatting
This commit fixes an incorrectly formatted Objective-C block parameter
placeholder in a code
smeenai added a comment.
In https://reviews.llvm.org/D26934#603997, @EricWF wrote:
> There are two usages of `_LIBCPP_DISABLE_DLL_IMPORT_EXPORT` in
> `CMakeLists.txt` and `__config_site.in` that need to be changed as well.
Oops, will fix.
> Also what about users of the existing name
> `_LIBC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287768: [libc++] Remove unneeded visibility pragmas
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26940?vs=78792&id=79090#toc
Repository:
rL LLVM
https://reviews.llvm.org
Author: smeenai
Date: Wed Nov 23 10:11:15 2016
New Revision: 287768
URL: http://llvm.org/viewvc/llvm-project?rev=287768&view=rev
Log:
[libc++] Remove unneeded visibility pragmas
The function definitions being guarded by the pragma were all static, so
they wouldn't be exported anyway. In any case,
jroelofs added a comment.
In https://reviews.llvm.org/D27005#603979, @EricWF wrote:
> In https://reviews.llvm.org/D27005#603692, @jroelofs wrote:
>
> > Should probably add a testcase in lit/tests that exercises the new CUSTOM
> > parser stuff, so people working on LIT don't have to build/test li
joey created this revision.
joey added reviewers: yaron.keren, bader.
joey added a subscriber: cfe-commits.
joey set the repository for this revision to rL LLVM.
Herald added a subscriber: yaxunl.
This patch to keep the pipe access qualifier inside PipeType itself looks
cleaner overall than my pr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287763: [ASTImporter] Added ability to import AtomicType
nodes (authored by xazax).
Changed prior to commit:
https://reviews.llvm.org/D26328?vs=76976&id=79080#toc
Repository:
rL LLVM
https://reviews
Author: xazax
Date: Wed Nov 23 09:24:23 2016
New Revision: 287763
URL: http://llvm.org/viewvc/llvm-project?rev=287763&view=rev
Log:
[ASTImporter] Added ability to import AtomicType nodes
Patch by: Kareem Khazem
Differential Revision: https://reviews.llvm.org/D26328
Modified:
cfe/trunk/lib/A
khazem added a comment.
Thanks, Gábor! Please do commit this (it's currently Thanksgiving week in the
US).
https://reviews.llvm.org/D26328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
vangyzen added a comment.
In https://reviews.llvm.org/D26979#604013, @EricWF wrote:
> Nope. Feel free to commit after adding the requested assertions.
I would gladly commit it, but I don't have commit access. I'm quite new here.
Comment at:
test/std/localization/locale.cat
xazax.hun added a comment.
What is the status of this patch? Is there a consensus?
https://reviews.llvm.org/D18860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Yaron,
I have changed how I implemented this, will open a review soon.
Thanks,
Joey
On 21 November 2016 at 14:42, Yaron Keren wrote:
> Hi Joey,
>
> In order for ReadPipeType and WritePipeType to work with LLVM type system
> (isa, dyn_cast), you need to modify the existing TypeClass::Pipe ki
xazax.hun added a comment.
LGTM!
https://reviews.llvm.org/D26835
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
FlameTop created this revision.
FlameTop added reviewers: zaks.anna, dcoughlin.
FlameTop added a subscriber: cfe-commits.
ExprEngine::VisitLvalArraySubscriptExpr contains an assert to ensure it is
passed either a GLvalue or a small number of C exemptions. This change adds
vector types to the ass
xazax.hun added a comment.
LGTM!
https://reviews.llvm.org/D26837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
In general I really like this change. See some of my comments inline.
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1279
/// associated element type, index, and super region.
const ElementRegion *getElementRegion(QualT
xazax.hun added a comment.
Can he commit this? In case he is too busy, I can also commit this for you.
https://reviews.llvm.org/D26328
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Wed Nov 23 07:14:19 2016
New Revision: 287759
URL: http://llvm.org/viewvc/llvm-project?rev=287759&view=rev
Log:
[clang-rename] Add test case for r287758.
Added:
clang-tools-extra/trunk/test/clang-rename/InvalidOffset.cpp
Added: clang-tools-extra/trunk/test/clang-rename/Inva
Author: d0k
Date: Wed Nov 23 07:10:07 2016
New Revision: 287758
URL: http://llvm.org/viewvc/llvm-project?rev=287758&view=rev
Log:
[clang-rename] Fix non-functional offset check.
Adding something to a SourceLocation will only produce an invalid
SourceLocation in edge cases (overflow or adding 0 to
a.sidorin updated this revision to Diff 79054.
a.sidorin added a comment.
Add a simple test for import of complex `NestedNameSpecifierLoc`s.
https://reviews.llvm.org/D26753
Files:
include/clang/AST/TemplateBase.h
lib/AST/ASTImporter.cpp
test/ASTMerge/class-template-partial-spec/Inputs/cl
Author: rksimon
Date: Wed Nov 23 05:38:52 2016
New Revision: 287755
URL: http://llvm.org/viewvc/llvm-project?rev=287755&view=rev
Log:
[X86][AVX512VL] Add missing _mm256_maskz_alignr_epi64 shufflevector check
Missed in rL287733
Modified:
cfe/trunk/test/CodeGen/avx512vl-builtins.c
Modified: c
Author: d0k
Date: Wed Nov 23 05:20:27 2016
New Revision: 287754
URL: http://llvm.org/viewvc/llvm-project?rev=287754&view=rev
Log:
[CodeGen] Simplify code. No functionality change intended.
Modified:
cfe/trunk/lib/CodeGen/CodeGenModule.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp
URL
arphaman created this revision.
arphaman added reviewers: manmanren, akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that clang provides NS_DESIGNATED_INITIALIZER code
completion result for an initializer method with
a.sidorin requested changes to this revision.
a.sidorin added a reviewer: a.sidorin.
a.sidorin added a comment.
This revision now requires changes to proceed.
Hi Kareem! I'll be happy to see this changes in upstream. Please see my
comments inline.
Comment at: lib/AST/ASTImport
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287752: [clang-move] Add some options allowing to add
old/new.h to new/old.h… (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26966?vs=79046&id=79047#toc
Repository:
rL LLVM
Author: hokein
Date: Wed Nov 23 04:04:19 2016
New Revision: 287752
URL: http://llvm.org/viewvc/llvm-project?rev=287752&view=rev
Log:
[clang-move] Add some options allowing to add old/new.h to new/old.h
respectively.
Summary:
* --new_depend_on_old: new header will include old header
* --old_depen
hokein updated this revision to Diff 79046.
hokein marked an inline comment as done.
hokein added a comment.
Fix code indentation.
https://reviews.llvm.org/D26966
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTests
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg.
Comment at: unittests/clang-move/ClangMoveTests.cpp:424
+ const char TestHeader[] = "class A {};\n"
+ "class B {};\n";
+ const char Test
EricWF added a comment.
In https://reviews.llvm.org/D26979#603110, @vangyzen wrote:
> @EricWF, would you like to see anything more from me? I could set up an LLVM
> development environment on my Mac if you want me to run the unit tests on Mac.
Nope. Feel free to commit after adding the reques
EricWF added inline comments.
Comment at: include/__string:213
-static inline int compare(const char_type* __s1, const char_type* __s2,
size_t __n) _NOEXCEPT
-{return __n == 0 ? 0 : memcmp(__s1, __s2, __n);}
-static inline size_t length(const char_type* __s) _
EricWF added a comment.
Could you please generate this patch with more context? (ie with -U999 or
similar).
Comment at: include/__config:925
+#if !__has_builtin(__builtin_memcpy)
+#define _LIBCPP_HAS_NO_BUILTIN_MEMCPY
What about GCC? Surely it implements som
EricWF added a comment.
There are two usages of `_LIBCPP_DISABLE_DLL_IMPORT_EXPORT` in `CMakeLists.txt`
and `__config_site.in` that need to be changed as well.
Also what about users of the existing name
`_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS`? Should we #error to inform them of
the change or
a.sidorin requested changes to this revision.
a.sidorin added a subscriber: aaron.ballman.
a.sidorin added a comment.
This revision now requires changes to proceed.
Hello Kareem,
Thank you for working on it! You can find my comments below.
Comment at: include/clang/ASTMatchers/
myatsina accepted this revision.
myatsina added a comment.
This revision is now accepted and ready to land.
LGTM
Please emphasize in you commit message that this the test case for the llvm
commit (and even better if you add the commit number of the llvm commit),
Repository:
rL LLVM
https://
EricWF added a comment.
In https://reviews.llvm.org/D27005#603692, @jroelofs wrote:
> Should probably add a testcase in lit/tests that exercises the new CUSTOM
> parser stuff, so people working on LIT don't have to build/test libc++ in
> order to know whether they've broken its testsuite.
I p
hokein updated this revision to Diff 79043.
hokein marked 8 inline comments as done.
hokein added a comment.
Update comments.
https://reviews.llvm.org/D26966
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTests.cpp
Author: ericwf
Date: Wed Nov 23 03:16:12 2016
New Revision: 287749
URL: http://llvm.org/viewvc/llvm-project?rev=287749&view=rev
Log:
Fix __hash_table::max_size() on 32 bit systems
Modified:
libcxx/trunk/include/__hash_table
libcxx/trunk/test/support/test_allocator.h
Modified: libcxx/trun
87 matches
Mail list logo
