vangyzen added inline comments.
================
Comment at:
test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:65
+ {
+ expected = *std::localeconv()->thousands_sep;
+ (void) std::setlocale(LC_NUMERIC, "C");
----------------
vangyzen wrote:
> EricWF wrote:
> > We should probably assert that `thousands_sep` isn't a multibyte character.
> I don't quite follow. C defines it as `char*`. Are you concerned about an
> implementation defining it as `wchar_t*`?
Oh, I understand now. Sorry. I've never really done much with locales, so I'm
not so fluent with them...especially early on a holiday morning. :)
https://reviews.llvm.org/D26979
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits