Author: mehdi_amini
Date: Wed Nov 16 01:07:28 2016
New Revision: 287085
URL: http://llvm.org/viewvc/llvm-project?rev=287085&view=rev
Log:
Improve handling of __FUNCTION__ and other predefined expression for
Objective-C Blocks
Instead of always displaying the mangled name, try to do better
and ge
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM. Always nice to see more builtins go away.
Repository:
rL LLVM
https://reviews.llvm.org/D26686
___
cfe-commits mailing list
c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287084: [Driver] Infer the correct option to ld64 for
-fembed-bitcode (authored by steven_wu).
Changed prior to commit:
https://reviews.llvm.org/D26690?vs=78111&id=78140#toc
Repository:
rL LLVM
http
Author: steven_wu
Date: Wed Nov 16 00:06:44 2016
New Revision: 287084
URL: http://llvm.org/viewvc/llvm-project?rev=287084&view=rev
Log:
[Driver] Infer the correct option to ld64 for -fembed-bitcode
Summary:
-fembed-bitcode infers -bitcode_bundle to ld64 but it is not correctly
passed when using L
mehdi_amini added a comment.
Ping @rsmith !
https://reviews.llvm.org/D26376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM!
I feel the code is cleaner like that at uses of these API :)
https://reviews.llvm.org/D26690
___
cfe-commits mailing list
cfe-co
Author: ericwf
Date: Tue Nov 15 22:45:32 2016
New Revision: 287080
URL: http://llvm.org/viewvc/llvm-project?rev=287080&view=rev
Log:
Fix non-reserved name usage
Modified:
libcxx/trunk/include/limits
Modified: libcxx/trunk/include/limits
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trunk/
.. but the follow up will be in a separate CL, as I have not even started
to work on it yet.
On Tue, Nov 15, 2016 at 6:31 PM, Ivan Krasin wrote:
> Okay, I will keep it as a separate file then. It's very likely that I will
> soon send a follow up, as there's another very similar case known to not
Okay, I will keep it as a separate file then. It's very likely that I will
soon send a follow up, as there's another very similar case known to not
work properly (based on the experience with UBSan Vptr bot in Chromium)
On Tue, Nov 15, 2016 at 6:27 PM, Richard Smith
wrote:
> On Tue, Nov 15, 2016
On Tue, Nov 15, 2016 at 6:20 PM, Ivan Krasin wrote:
> Thank you, Richard.
>
> Shall I merge the newly introduced test/CodeGenCXX/ubsan-vtable-checks.cpp
> into catch-undef-behavior.cpp or it's more clear when it's standalone?
>
Up to you. catch-undef-behavior.cpp is getting unwieldy, so a separa
smeenai added a comment.
In https://reviews.llvm.org/D26657#596759, @hans wrote:
> > On MSVC, if an implicit instantiation already exists and an explicit
> > instantiation definition with a DLL attribute is created, the DLL
> > attribute still takes effect. Make clang match this behavior.
>
> T
Thank you, Richard.
Shall I merge the newly introduced test/CodeGenCXX/ubsan-vtable-checks.cpp
into catch-undef-behavior.cpp or it's more clear when it's standalone?
On Tue, Nov 15, 2016 at 5:51 PM, Richard Smith
wrote:
> On Fri, Nov 11, 2016 at 3:02 PM, Ivan Krasin via cfe-commits <
> cfe-comm
On Fri, Nov 11, 2016 at 3:02 PM, Ivan Krasin via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> krasin added a comment.
>
> Small correction: all UBSan type checks tests live in compiler-rt.
Actually, most of the UBSan tests live
in test/CodeGenCXX/catch-undef-behavior.cpp in Clang; the comp
Thank you!
The bot recovered after r287066.
vedant
> On Nov 15, 2016, at 5:09 PM, Richard Smith wrote:
>
> On Tue, Nov 15, 2016 at 3:39 PM, Vedant Kumar wrote:
> Hi Richard,
>
> Our internal ASan bot started failing after this and r286678:
>
> ASAN:DEADLYSIGNAL
> ===
steven_wu updated this revision to Diff 78111.
steven_wu added a comment.
Rename the functions to clarify the intention.
embedBitcodeEnabled means if any flag in -fembed-bitcode family is used so the
corresponding linker flag should be inferred. embedBitcodeInObject means if
the bitcode should be
I've reverted them both to fix bots: https://reviews.llvm.org/D26720
On Tue, Nov 15, 2016 at 3:40 PM Vitaly Buka wrote:
> With this patch it's "after-scope" instead of return but still there:
> http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/650/steps/check-clang%20asan/logs
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287069: Revert "[OPENMP] Fixed codegen for 'omp cancel'
construct." (authored by vitalybuka).
Changed prior to commit:
https://reviews.llvm.org/D26720?vs=78107&id=78109#toc
Repository:
rL LLVM
https
Author: vitalybuka
Date: Tue Nov 15 19:01:22 2016
New Revision: 287069
URL: http://llvm.org/viewvc/llvm-project?rev=287069&view=rev
Log:
Revert "[OPENMP] Fixed codegen for 'omp cancel' construct."
Summary:
r286944 introduced bugs detected by ASAN as use-after-return.
r287025 have not fixed them c
vitalybuka created this revision.
vitalybuka added a reviewer: ABataev.
vitalybuka added a subscriber: cfe-commits.
r286944 introduced bugs detected by ASAN as use-after-return.
r287025 have not fixed them completely.
This reverts commit r286944 and r287025.
https://reviews.llvm.org/D26720
Fil
On Tue, Nov 15, 2016 at 3:39 PM, Vedant Kumar wrote:
> Hi Richard,
>
> Our internal ASan bot started failing after this and r286678:
>
> ASAN:DEADLYSIGNAL
> =
> ==95464==ERROR: AddressSanitizer: stack-overflow on address 0x7fff56c68b
Author: rsmith
Date: Tue Nov 15 18:57:23 2016
New Revision: 287066
URL: http://llvm.org/viewvc/llvm-project?rev=287066&view=rev
Log:
Outline evaluation of calls to builtins to avoid inflating stack usage for the
common case of a call to a non-builtin, particularly for unoptimized ASan
builds (wher
krasin marked 2 inline comments as done.
krasin added inline comments.
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1820-1833
+ ASTContext &Context = getContext();
+ SourceLocation CallLoc = CE ? CE->getLocStart() : SourceLocation();
+ CGF.EmitTypeCheck(CodeGenFunction::TCK_Mem
krasin updated this revision to Diff 78104.
krasin added a comment.
Address comments.
https://reviews.llvm.org/D26559
Files:
lib/CodeGen/CGExprCXX.cpp
test/CodeGenCXX/ubsan-vtable-checks.cpp
Index: test/CodeGenCXX/ubsan-vtable-checks.cpp
hans added a comment.
> On MSVC, if an implicit instantiation already exists and an explicit
> instantiation definition with a DLL attribute is created, the DLL
> attribute still takes effect. Make clang match this behavior.
This is scary territory, and behaviour I think might be hard for us to
Author: dcoughlin
Date: Tue Nov 15 18:47:56 2016
New Revision: 287063
URL: http://llvm.org/viewvc/llvm-project?rev=287063&view=rev
Log:
[www] Update analyzer website for release of checker-279
Modified:
cfe/trunk/www/analyzer/index.html
cfe/trunk/www/analyzer/latest_checker.html.incl
On Tue, Nov 15, 2016 at 2:55 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Tue, Nov 15, 2016 at 5:44 PM, Hal Finkel wrote:
> > - Original Message -
> >> From: "Aaron Ballman"
> >> To: "Hal Finkel"
> >> Cc: "cfe-commits" , "Joshua Hurwitz" <
> hurwi...@googl
mehdi_amini added a comment.
Patch still LGTM!
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
phosek updated this revision to Diff 78096.
phosek added a comment.
I've removed the error message and moved it to https://reviews.llvm.org/D26715.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
Files:
CMakeLists.txt
Index: CMakeLists.txt
Author: rsmith
Date: Tue Nov 15 18:03:24 2016
New Revision: 287057
URL: http://llvm.org/viewvc/llvm-project?rev=287057&view=rev
Log:
PR23281: Fix implementation of DR1891 to implement the intent: that is, a
lambda-expression does not have a move-assignment operator.
Modified:
cfe/trunk/includ
With this patch it's "after-scope" instead of return but still there:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/650/steps/check-clang%20asan/logs/stdio
On Tue, Nov 15, 2016 at 1:07 PM Alexey Bataev via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: abataev
>
Hi Richard,
Our internal ASan bot started failing after this and r286678:
ASAN:DEADLYSIGNAL
=
==95464==ERROR: AddressSanitizer: stack-overflow on address 0x7fff56c68b40 (pc
0x000110c582a2 bp 0x7fff56c69970 sp 0x7fff56c68b40 T0)
manmanren added a comment.
Cheers,
Manman
Comment at: include/clang/Basic/DiagnosticParseKinds.td:442
+/// Objective-C++ parser diagnostics
+def err_expected_objcxx_keyword : Error<
+ "expected %0; %1 is a keyword in Objective-C++">;
This name is a little misl
On Tue, Nov 15, 2016 at 5:44 PM, Hal Finkel wrote:
> - Original Message -
>> From: "Aaron Ballman"
>> To: "Hal Finkel"
>> Cc: "cfe-commits" , "Joshua Hurwitz"
>>
>> Sent: Tuesday, November 15, 2016 4:42:05 PM
>> Subject: Re: [PATCH] Warning for main returning a bool.
>>
>> On Tue, Nov
mehdi_amini added inline comments.
Comment at: lib/Driver/Tools.cpp:8326
- if (C.getDriver().embedBitcodeEnabled() ||
- C.getDriver().embedBitcodeMarkerOnly()) {
-// Check if the toolchain supports bitcode build flow.
steven_wu wrote:
> mehdi_amini wrot
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26435#595282, @dtarditi wrote:
> What platform/OS did you build on?
I build release with asserts on 64 bit Linux. My host compiler is gcc.
https://reviews.llvm.org/D26435
___
cfe-commi
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
This is a generalization of `_LIBCPP_NEW_DELETE_VIS`; the new macro name
captures the semantics better, and also allows us to get rid of the
`_WIN32` check in `include/ne
- Original Message -
> From: "Aaron Ballman"
> To: "Hal Finkel"
> Cc: "cfe-commits" , "Joshua Hurwitz"
>
> Sent: Tuesday, November 15, 2016 4:42:05 PM
> Subject: Re: [PATCH] Warning for main returning a bool.
>
> On Tue, Nov 15, 2016 at 5:22 PM, Hal Finkel wrote:
> > - Original Me
pcc added inline comments.
Comment at: lib/CodeGen/CGExprCXX.cpp:1928-1933
+SourceLocation CallLoc;
+if (E)
+ CallLoc = E->getExprLoc();
+EmitTypeCheck(CodeGenFunction::TCK_MemberCall,
+ CallLoc, Ptr.getPointer(),
+ DeleteTy);
--
On Tue, Nov 15, 2016 at 5:22 PM, Hal Finkel wrote:
> - Original Message -
>> From: "Aaron Ballman via cfe-commits"
>> To: "Joshua Hurwitz"
>> Cc: "cfe-commits"
>> Sent: Tuesday, November 15, 2016 12:17:28 PM
>> Subject: Re: [PATCH] Warning for main returning a bool.
>>
>> On Fri, Oct 14
Author: dergachev
Date: Tue Nov 15 16:22:57 2016
New Revision: 287045
URL: http://llvm.org/viewvc/llvm-project?rev=287045&view=rev
Log:
[analyzer] NumberObjectConversion: Workaround for a linker error with modules.
A combination of C++ modules, variadic functions with more than one argument,
and
mehdi_amini added a comment.
Already reverted
Repository:
rL LLVM
https://reviews.llvm.org/D26522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mehdi_amini
Date: Tue Nov 15 16:19:50 2016
New Revision: 287043
URL: http://llvm.org/viewvc/llvm-project?rev=287043&view=rev
Log:
Revert "Improve handling of __FUNCTION__ and other predefined expression for
Objective-C Blocks"
This reverts commit r287039, tests are broken.
Removed:
vitalybuka added a comment.
This is probably caused by this patch
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/649/steps/check-clang%20msan/logs/stdio
Repository:
rL LLVM
https://reviews.llvm.org/D26522
___
cfe-commits mai
- Original Message -
> From: "Aaron Ballman via cfe-commits"
> To: "Joshua Hurwitz"
> Cc: "cfe-commits"
> Sent: Tuesday, November 15, 2016 12:17:28 PM
> Subject: Re: [PATCH] Warning for main returning a bool.
>
> On Fri, Oct 14, 2016 at 1:17 PM, Joshua Hurwitz via cfe-commits
> wrote:
zaks.anna added inline comments.
Comment at: include/clang/StaticAnalyzer/Core/Checker.h:325
+ const CallEvent *Call,
+ const LocationContext *LCtx) {
+return ((const CHECKER *) checker)->checkRegionChanges(state, invalidated,
---
Author: jlebar
Date: Tue Nov 15 16:03:29 2016
New Revision: 287041
URL: http://llvm.org/viewvc/llvm-project?rev=287041&view=rev
Log:
[libcxx] Mark xonstexpr-fns.pass.cpp as XFAIL: gcc.
This fails with gcc because __builtin_isnan and friends, which
libcpp_isnan and friends call, are not themselves
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287039: Improve handling of __FUNCTION__ and other
predefined expression for Objective… (authored by mehdi_amini).
Changed prior to commit:
https://reviews.llvm.org/D26522?vs=77682&id=78073#toc
Reposit
Author: mehdi_amini
Date: Tue Nov 15 15:47:11 2016
New Revision: 287039
URL: http://llvm.org/viewvc/llvm-project?rev=287039&view=rev
Log:
Improve handling of __FUNCTION__ and other predefined expression for
Objective-C Blocks
Instead of always displaying the mangled name, try to do better
and ge
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#596254, @aaron.ballman wrote:
> (This part of the check is one half modernization, one half performance, and
> one half correctness, depending on which lens you view the code through.)
The performance part should be handled by
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287037: [AArch64] Add driver tests for Qualcomm's Falkor
CPU. (authored by mcrosier).
Changed prior to commit:
https://reviews.llvm.org/D26674?vs=78002&id=78070#toc
Repository:
rL LLVM
https://revie
Author: mcrosier
Date: Tue Nov 15 15:34:31 2016
New Revision: 287037
URL: http://llvm.org/viewvc/llvm-project?rev=287037&view=rev
Log:
[AArch64] Add driver tests for Qualcomm's Falkor CPU.
Differential Revision: https://reviews.llvm.org/D26674
Modified:
cfe/trunk/test/Driver/aarch64-cpus.c
steven_wu added inline comments.
Comment at: lib/Driver/Tools.cpp:8326
- if (C.getDriver().embedBitcodeEnabled() ||
- C.getDriver().embedBitcodeMarkerOnly()) {
-// Check if the toolchain supports bitcode build flow.
mehdi_amini wrote:
> Why aren't these
mehdi_amini added inline comments.
Comment at: lib/Driver/Tools.cpp:8326
- if (C.getDriver().embedBitcodeEnabled() ||
- C.getDriver().embedBitcodeMarkerOnly()) {
-// Check if the toolchain supports bitcode build flow.
Why aren't these tests returning tr
vitalybuka created this revision.
vitalybuka added a reviewer: ABataev.
vitalybuka added a subscriber: cfe-commits.
It introduced stack-use-after-return detected by ASAN.
Here:
'''
auto &&CodeGen = [ELoc](CodeGenFunction &CGF) {
CGF.CGM.getOpenMPRuntime().emitForStaticFinish(CGF, ELoc);
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
The basic constraint solver was dropped in https://reviews.llvm.org/rL162384,
leaving the range constraint solver as the default and only constraint solver.
Explicitly specifying it is u
beanz added a comment.
Failing on `-DLLVM_ENABLE_LLD=ON` and `-DLLVM_ENABLE_LTO=ON` in LLVM seems fine
to me.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: abataev
Date: Tue Nov 15 14:57:18 2016
New Revision: 287025
URL: http://llvm.org/viewvc/llvm-project?rev=287025&view=rev
Log:
[OPENMP] Fix stack use after delete, NFC.
Fixed possible use of stack variable after deletion.
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe
Author: akirtzidis
Date: Tue Nov 15 14:51:46 2016
New Revision: 287024
URL: http://llvm.org/viewvc/llvm-project?rev=287024&view=rev
Log:
[libclang] Generalize clang_getNumTemplateArguments and
clang_getTemplateArgumentAsType to other kind of specializations.
Patch by Emilio Cobos Álvarez!
https:
krasin added a comment.
Friendly ping.
https://reviews.llvm.org/D26559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added a subscriber: cfe-commits.
Split out formatting and style changes from https://reviews.llvm.org/D26061
https://reviews.llvm.org/D26691
Files:
lib/StaticAnalyzer/Core/RangeConstraintManager.cpp
lib/StaticAnaly
smeenai added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7669
+// Fix a TSK_ExplicitInstantiationDeclaration or a
TSK_ImplicitInstantiation
+// followed by a TSK_ExplicitInstantiationDefinition
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
aaron.ballman added a comment.
I think this meets my needs for the cert-oop11-cpp check as it appears to be
preserving the original behavior. If a user has the `UseCERTSemantics` option
set in one of their scripts, that appears to be silently accepted and discarded
currently, so I don't think t
Author: ericwf
Date: Tue Nov 15 14:21:30 2016
New Revision: 287020
URL: http://llvm.org/viewvc/llvm-project?rev=287020&view=rev
Log:
Add .clang-format to libc++
Adding a Clang Format file to libc++ and which style it should use has been
discussed a couple of times. This patch finally adds a .clan
phosek added a comment.
In https://reviews.llvm.org/D26649#596209, @mehdi_amini wrote:
> @beanz : don't you think that it should be handled at the top level and not
> in the bootstrap logic?
> Right now we don't error when invoking cmake with `-DLLVM_ENABLE_LLD=ON`
> and `-DLLVM_ENABLE_LTO=ON
steven_wu created this revision.
steven_wu added a reviewer: mehdi_amini.
steven_wu added a subscriber: cfe-commits.
-fembed-bitcode infers -bitcode_bundle to ld64 but it is not correctly
passed when using LTO. LTO is a special case of -fembed-bitcode which
it doesn't require embed the bitcode in
rsmith added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
aaron.ballman wrote:
> mclow.lists wrote:
> > aaron.ballman wrote:
> > > malcolm.parsons wrote:
> > > >
ddcc updated this revision to Diff 78049.
ddcc added a comment.
Rebase on recent changes
https://reviews.llvm.org/D26061
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
include/clang/StaticAnalyzer/Core/PathSensitive/SimpleConstraintManager.h
lib/StaticAnalyzer/
mehdi_amini added a comment.
@beanz : don't you think that it should be handled at the top level and not in
the bootstrap logic?
Right now we don't error when invoking cmake with `-DLLVM_ENABLE_LLD=ON` and
`-DLLVM_ENABLE_LTO=ON` on Darwin.
Repository:
rL LLVM
https://reviews.llvm.org/D2664
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D26464
___
cfe-commits mailing list
cfe-co
phosek updated this revision to Diff 78045.
phosek added a comment.
Added error message for Darwin, does this look good to you?
Repository:
rL LLVM
https://reviews.llvm.org/D26649
Files:
CMakeLists.txt
Index: CMakeLists.txt
beanz accepted this revision.
beanz added a comment.
Yep. Can we maybe add an error to that effect? I really don't want the build
system ignoring invalid configurations.
Otherwise LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287012: [CUDA] Mark __libcpp_{isnan,isinf,isfinite} as
constexpr. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25403?vs=77271&id=78041#toc
Repository:
rL LLVM
https://rev
Author: jlebar
Date: Tue Nov 15 13:15:57 2016
New Revision: 287012
URL: http://llvm.org/viewvc/llvm-project?rev=287012&view=rev
Log:
[CUDA] Mark __libcpp_{isnan,isinf,isfinite} as constexpr.
Summary:
This makes these functions available on host and device, which is
necessary to compile for the d
jlebar marked 6 inline comments as done.
jlebar added a comment.
Capturing an IRC conversation:
> **EricWF** jlebar: Did you test this patch with older Clangs w/o constexpr
> builtins?
> **jlebar** EricWF, Do you mean, did I test the test, or did I test that the
> non-test change does what I n
benlangmuir added a comment.
I'm inclined to suggest we break that behaviour with modules and treat a user
module the same no matter where it was imported. @rsmith, what do you think?
https://reviews.llvm.org/D25916
___
cfe-commits mailing list
c
aaron.ballman added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
mclow.lists wrote:
> aaron.ballman wrote:
> > malcolm.parsons wrote:
> > > aaron.ballman wrote:
>
mclow.lists added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:768
.Cases("il", "i", "if", true)
+ .Case("sv", true)
.Default(false);
aaron.ballman wrote:
> malcolm.parsons wrote:
> > aaron.ballman wrote:
> > > mclow.lists wrote:
> >
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: test/clang-tidy/modernize-use-default.cpp:142
+// CHECK-MESSAGES: :[[@LINE-2]]:1: warning: use '= default'
+// CHECK-FIXES: TempODef::~TempODe
Author: rampitec
Date: Tue Nov 15 12:58:03 2016
New Revision: 287006
URL: http://llvm.org/viewvc/llvm-project?rev=287006&view=rev
Log:
[AMDGPU] Add wave barrier builtin
The wave barrier represents the discardable barrier. Its main purpose is to
carry convergent attribute, thus preventing illegal
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:89
+diag(FuncInst->getLocStart(), Messag
Author: ioeric
Date: Tue Nov 15 13:05:40 2016
New Revision: 287008
URL: http://llvm.org/viewvc/llvm-project?rev=287008&view=rev
Log:
Add comments on how to print error retuned by tooling::Replacements::add().
Modified:
cfe/trunk/include/clang/Tooling/Core/Replacement.h
Modified: cfe/trunk/in
RKSimon created this revision.
RKSimon added reviewers: craig.topper, igorb, delena.
RKSimon added a subscriber: cfe-commits.
RKSimon set the repository for this revision to rL LLVM.
Both the (V)CVTDQ2PD (i32 to f64) and (V)CVTDQ2PD (u32 to f64) conversion
instructions are lossless and can be saf
Author: d0k
Date: Tue Nov 15 12:56:39 2016
New Revision: 287005
URL: http://llvm.org/viewvc/llvm-project?rev=287005&view=rev
Log:
[Modules] Replace arrays with init lists.
Thi way the compiler can pick the optimal storage duration. It's also
more readable. No functional change intended.
Modified
EricWF added inline comments.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17
+// true constexpr-ness.
+
+#include
jlebar wrote:
> EricWF wrote:
> > Does GCC offer these as contexpr? If not this needs a `// XFAIL: gcc`
> Looks like the r
EricWF added inline comments.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:22
+
+#ifndef _LIBCPP_VERSION
+#error _LIBCPP_VERSION not defined
jlebar wrote:
> EricWF wrote:
> > You don't need this `_LIBCPP_VERSION` check here.
> Hm, there a
Author: vedantk
Date: Tue Nov 15 12:48:36 2016
New Revision: 287004
URL: http://llvm.org/viewvc/llvm-project?rev=287004&view=rev
Log:
Revert "P0503R0, adopted in Issaquah, rewords some requirements on nullptr_t
and istream_iterator. No code changes were needed, but I updated a few tests.
Also r
compnerd added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7669
+// Fix a TSK_ExplicitInstantiationDeclaration or a
TSK_ImplicitInstantiation
+// followed by a TSK_ExplicitInstantiationDefinition
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
---
Author: dcoughlin
Date: Tue Nov 15 12:40:46 2016
New Revision: 287001
URL: http://llvm.org/viewvc/llvm-project?rev=287001&view=rev
Log:
[analyzer] Add check for when block is called with too few arguments.
The CallAndMessageChecker has an existing check for when a function pointer
is called with
jlebar added a comment.
Thanks for the review.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17
+// true constexpr-ness.
+
+#include
EricWF wrote:
> Does GCC offer these as contexpr? If not this needs a `// XFAIL: gcc`
Looks like the re
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/modernize-use-default.cpp:142
+// CHECK-MESSAGES: :[[@LINE-2]]:1: warning: use '= default'
+// CHECK-FIXES: TempODef::~TempODef() = default;
+
aaron.ballman wrote:
> Would it be better if the `= d
Author: rksimon
Date: Tue Nov 15 12:28:07 2016
New Revision: 286996
URL: http://llvm.org/viewvc/llvm-project?rev=286996&view=rev
Log:
Fixed spelling in comments. NFCI.
Modified:
cfe/trunk/include/clang/AST/DeclObjC.h
cfe/trunk/include/clang/Basic/TargetInfo.h
cfe/trunk/lib/Sema/SemaEx
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5348
S.Diag(LiteralLoc, diag::warn_unknown_sanitizer_ignored) <<
SanitizerName;
-else if (isGlobalVar(D) && SanitizerName != "address")
+else if (isGlobalVar(D) && SanitizerName != "address
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
Patch LGTM right now, let's just wait for @beanz in case he objects.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
___
cfe-com
EricWF accepted this revision.
EricWF added inline comments.
This revision is now accepted and ready to land.
Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17
+// true constexpr-ness.
+
+#include
Does GCC offer these as contexpr? If not t
mehdi_amini added a comment.
In https://reviews.llvm.org/D26649#596024, @beanz wrote:
> On Darwin you don't want to set `DARWIN_LTO_LIBRARY` on the next stage if
> you're intending the next stage to use lld because that sets flags that
> aren't supported by lld.
Right, but that's a separate i
beanz added a comment.
On Darwin you don't want to set `DARWIN_LTO_LIBRARY` on the next stage if
you're intending the next stage to use lld because that sets flags that aren't
supported by lld.
Repository:
rL LLVM
https://reviews.llvm.org/D26649
__
Author: syzaara
Date: Tue Nov 15 12:04:13 2016
New Revision: 286994
URL: http://llvm.org/viewvc/llvm-project?rev=286994&view=rev
Log:
vector load store with length (left justified) clang portion
Modified:
cfe/trunk/include/clang/Basic/BuiltinsPPC.def
cfe/trunk/lib/CodeGen/CGBuiltin.cpp
On Fri, Oct 14, 2016 at 1:17 PM, Joshua Hurwitz via cfe-commits
wrote:
> See attached.
>
> Returning a bool from main is a special case of return type mismatch. The
> common convention when returning a bool is that 'true' (== 1) indicates
> success and 'false' (== 0) failure. But since main expect
beanz accepted this revision.
beanz added a comment.
LGTM! Thanks for doing this Sean!
Repository:
rL LLVM
https://reviews.llvm.org/D26571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
1 - 100 of 173 matches
Mail list logo
