EricWF accepted this revision. EricWF added inline comments. This revision is now accepted and ready to land.
================ Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:17 +// true constexpr-ness. + +#include <cmath> ---------------- Does GCC offer these as contexpr? If not this needs a `// XFAIL: gcc` ================ Comment at: libcxx/test/libcxx/numerics/c.math/constexpr-fns.pass.cpp:22 + +#ifndef _LIBCPP_VERSION +#error _LIBCPP_VERSION not defined ---------------- You don't need this `_LIBCPP_VERSION` check here. https://reviews.llvm.org/D25403 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
