Author: djasper
Date: Tue Nov 1 01:23:14 2016
New Revision: 285673
URL: http://llvm.org/viewvc/llvm-project?rev=285673&view=rev
Log:
clang-format: Fix incorrect pointer detection.
Before:
void f() { f(float{1}, a *a); }
After:
void f() { f(float{1}, a * a); }
Modified:
cfe/trunk/lib/Fo
Author: djasper
Date: Tue Nov 1 01:22:54 2016
New Revision: 285669
URL: http://llvm.org/viewvc/llvm-project?rev=285669&view=rev
Log:
clang-format: [JS] Fix space when for is used as regular identifier.
Before:
x.for () = 1;
After:
x.for() = 1;
Modified:
cfe/trunk/lib/Format/TokenAnnota
Author: djasper
Date: Tue Nov 1 01:23:19 2016
New Revision: 285674
URL: http://llvm.org/viewvc/llvm-project?rev=285674&view=rev
Log:
clang-format: Fix bug in function reference qualifier detection.
Before:
template
void F(T) &&
= delete;
After:
template
void F(T) && = delete
Author: djasper
Date: Tue Nov 1 01:22:59 2016
New Revision: 285670
URL: http://llvm.org/viewvc/llvm-project?rev=285670&view=rev
Log:
clang-format: [JS] Fix formatting of generator functions.
Before:
var x = {
a: function*
() {
//
}
}
After:
var x = {
a: f
Author: djasper
Date: Tue Nov 1 01:23:05 2016
New Revision: 285671
URL: http://llvm.org/viewvc/llvm-project?rev=285671&view=rev
Log:
clang-format: Fix incorrect binary operator detection.
Before:
int x = f(* + [] {});
After:
int x = f(*+[] {});
Modified:
cfe/trunk/lib/Format/TokenAnnot
Author: djasper
Date: Tue Nov 1 01:23:10 2016
New Revision: 285672
URL: http://llvm.org/viewvc/llvm-project?rev=285672&view=rev
Log:
clang-format: [JS] Fix incorrect space when "as" is used as identifier.
Before:
a.as ();
After:
a.as();
Modified:
cfe/trunk/lib/Format/TokenAnnot
Author: ctopper
Date: Tue Nov 1 00:47:56 2016
New Revision: 285667
URL: http://llvm.org/viewvc/llvm-project?rev=285667&view=rev
Log:
[AVX-512] Remove masked vector insert builtins and replace with native
shufflevectors and selects.
Unfortunately, the backend currently doesn't fold masks into th
ahatanak updated this revision to Diff 76521.
ahatanak added a comment.
Thanks, that fixed the failing regression tests.
https://reviews.llvm.org/D26166
Files:
lib/Sema/SemaTemplateInstantiate.cpp
test/SemaCXX/instantiate-template-fatal-error.cpp
Index: test/SemaCXX/instantiate-template-f
sepavloff updated this revision to Diff 76520.
sepavloff added a comment.
Do not use getFriendObjectKind(), friend kind sometimes is set too late.
https://reviews.llvm.org/D26065
Files:
lib/Sema/SemaDeclCXX.cpp
test/CXX/dcl.dcl/dcl.spec/dcl.fct.spec/p4.cpp
Index: test/CXX/dcl.dcl/dcl.spec
> On Oct 31, 2016, at 4:49 PM, Richard Smith wrote:
>
> On Mon, Oct 31, 2016 at 3:12 PM, Argyrios Kyrtzidis via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: akirtzidis
> Date: Mon Oct 31 17:12:12 2016
> New Revision: 285647
>
> URL: http://llvm.org/viewvc/llvm-project?rev
Author: akirtzidis
Date: Mon Oct 31 23:29:39 2016
New Revision: 285666
URL: http://llvm.org/viewvc/llvm-project?rev=285666&view=rev
Log:
[index] Avoid using a RecursiveASTVisitor for SyntacticFormIndexer and iterate
the DesignatedInitExprs of the InitListExpr directly.
This is more efficient, as
rsmith added a comment.
In https://reviews.llvm.org/D26166#584285, @ahatanak wrote:
> It seems to me that the root of the problem is that the template
> instantiation S2 is left in an incomplete state and VarDecl s2 in the
> AST, which is of type S2, is marked invalid. As I mentioned in my
> p
rsmith created this revision.
rsmith added a reviewer: EricWF.
rsmith added a subscriber: cfe-commits.
rsmith set the repository for this revision to rL LLVM.
This implements the following proposal from cxx-abi-dev:
http://sourcerytools.com/pipermail/cxx-abi-dev/2016-October/002988.html
... wh
Author: rsmith
Date: Mon Oct 31 20:34:46 2016
New Revision: 285664
URL: http://llvm.org/viewvc/llvm-project?rev=285664&view=rev
Log:
Implement ABI proposal for throwing noexcept function pointers, per discussion
on cxx-abi-dev (thread starting 2016-10-11). This is currently hidden behind a
cc1-onl
Author: rsmith
Date: Mon Oct 31 20:31:23 2016
New Revision: 285663
URL: http://llvm.org/viewvc/llvm-project?rev=285663&view=rev
Log:
p0012: Teach resolving address of overloaded function with dependent exception
specification to resolve the exception specification as part of the type check,
in C++
ahatanak updated this revision to Diff 76513.
ahatanak added a comment.
I think the non-uncompilable error you mentioned is the one on line 7 of the
test case and the uncompilable error is the one on line 15. Is that correct?
The modified test case has only one error (on line 7, which is promote
Author: pcc
Date: Mon Oct 31 20:18:57 2016
New Revision: 285660
URL: http://llvm.org/viewvc/llvm-project?rev=285660&view=rev
Log:
Bitcode: Simplify BitstreamWriter::EnterBlockInfoBlock() interface.
No block info block should need to define local abbreviations, so we can
always use a code width of
Hi Galina,
Thanks for letting me know. Can you tell me which compiler (kind and version) is used in the buildbot slave? Looks like that compiler is not doing what it should, so I need to be able to test a workaround.
We have
virtual void ConstructJob(Compilation &C, const JobAction &JA,
mclow.lists added a comment.
This all looks ok to me - all mechanical changes.
I wonder if there's a better way to refactor these - there's all that
duplicated code.
Does this look any better to you?
Replace:
try
{
s.replace(pos1, n1, str, pos2);
LIBCPP_ASSERT(s.__invariants());
Hi Samuel,
Looks like this revision introduced warning to one of our builders:
http://lab.llvm.org:8011/builders/clang-3stage-ubuntu/builds/67/steps/build-stage3-clang/logs/warnings%20%28830%29
Please have a look at this?
Thanks
Galina
On Thu, Oct 27, 2016 at 11:14 AM, Samuel Antao via cfe-com
rsmith added a comment.
It looks like the bug is that if we hit an uncompilable error after hitting a
non-uncompilable fatal error (promoted from a warning), we fail to notice that
we've hit an uncompileable error. Our AST should be complete if
`hasUncompilableErrorOccurred()` is not set, and i
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, aaron.ballman, hokein, etienneb.
Eugene.Zelenko added subscribers: cfe-commits, Prazek.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Unfortunately, misc-redundant-expression didn't detect problem in ow
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285657: [ReachableCode] Skip over ExprWithCleanups in
isConfigurationValue (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D24010?vs=75644&id=76508#toc
Repository:
rL LLVM
h
Author: timshen
Date: Mon Oct 31 19:19:04 2016
New Revision: 285657
URL: http://llvm.org/viewvc/llvm-project?rev=285657&view=rev
Log:
[ReachableCode] Skip over ExprWithCleanups in isConfigurationValue
Summary: Fixes pr29152.
Reviewers: rsmith, pirama, krememek
Subscribers: cfe-commits
Differen
mgorny created this revision.
mgorny added reviewers: rafael, beanz, chandlerc.
mgorny added a subscriber: cfe-commits.
Herald added subscribers: mehdi_amini, srhines, danalbert, tberghammer.
Add a fallback to using plain '-plugin LLVMgold.so' when the plugin does
not exist at the standard path. T
On Mon, Oct 31, 2016 at 3:12 PM, Argyrios Kyrtzidis via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: akirtzidis
> Date: Mon Oct 31 17:12:12 2016
> New Revision: 285647
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285647&view=rev
> Log:
> [index] Fix repeated visitation of the sam
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285655: [modules] Mark deleted functions as implicitly
inline to allow merging (authored by EricWF).
Changed prior to commit:
https://reviews.llvm.org/D26143?vs=76501&id=76502#toc
https://reviews.llvm
Author: ericwf
Date: Mon Oct 31 18:07:15 2016
New Revision: 285655
URL: http://llvm.org/viewvc/llvm-project?rev=285655&view=rev
Log:
[modules] Mark deleted functions as implicitly inline to allow merging
Summary: When merging definitions with ModulesLocalVisibility enabled it's
important to mak
EricWF updated this revision to Diff 76501.
https://reviews.llvm.org/D26143
Files:
lib/Sema/SemaDeclCXX.cpp
test/Modules/Inputs/merge-decl-context/a.h
Index: test/Modules/Inputs/merge-decl-context/a.h
===
--- test/Modules/Input
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285653: [clang-tidy] Update cert-err58-cpp to match its new
generalised form. (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D25925?vs=76318&id=76494#toc
Repository:
Author: malcolm.parsons
Date: Mon Oct 31 17:47:04 2016
New Revision: 285653
URL: http://llvm.org/viewvc/llvm-project?rev=285653&view=rev
Log:
[clang-tidy] Update cert-err58-cpp to match its new generalised form.
Summary:
Aaron modified cert-err58-cpp to include all exceptions thrown before main()
malcolm.parsons updated this revision to Diff 76493.
malcolm.parsons added a comment.
Fix comment.
Rename variable.
Use global.
https://reviews.llvm.org/D26138
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseEqualsDeleteCheck
srhines added a comment.
Ping. Other developers (Firefox) are now starting to hit this issue.
https://reviews.llvm.org/D24010
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
eugenis closed this revision.
eugenis added a comment.
thanks!
r285650
Repository:
rL LLVM
https://reviews.llvm.org/D26164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added a comment.
In https://reviews.llvm.org/D25624#583883, @sebpop wrote:
> In https://reviews.llvm.org/D25624#583163, @mehdi_amini wrote:
>
> > I'd like to understand why only the destructor?
>
>
> We have committed a patch to inline the constructor of std::string.
> Do you think w
mehdi_amini added a comment.
In https://reviews.llvm.org/D25624#584095, @hiraditya wrote:
> In https://reviews.llvm.org/D25624#583167, @mehdi_amini wrote:
>
> > I talked with Eric on IRC, he mentioned some benchmarks were ran. I'd like
> > to understand what was the baseline?
> > Here we add *b
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:29
+cxxMethodDecl(
+anyOf(isCopyAssignmentOperator(), isMoveAssignmentOperator())),
+cxxDestructorDecl()));
aaron.ballman wrot
hiraditya added a comment.
In https://reviews.llvm.org/D25624#583167, @mehdi_amini wrote:
> I talked with Eric on IRC, he mentioned some benchmarks were ran. I'd like to
> understand what was the baseline?
> Here we add *both* the inline keyword and the always_inline attribute. I'd
> like to k
Author: eugenis
Date: Mon Oct 31 17:28:10 2016
New Revision: 285650
URL: http://llvm.org/viewvc/llvm-project?rev=285650&view=rev
Log:
[cfi] Fix missing !type annotation.
CFI (only in the cross-dso mode) fails to set !type annotations when
a function is used before it is defined.
Added:
cfe/t
Author: akirtzidis
Date: Mon Oct 31 17:12:12 2016
New Revision: 285647
URL: http://llvm.org/viewvc/llvm-project?rev=285647&view=rev
Log:
[index] Fix repeated visitation of the same InitListExpr for indexing.
It was visited multiple times unnecessarily.
rdar://28985038
Added:
cfe/trunk/test/
Author: eugenezelenko
Date: Mon Oct 31 17:05:45 2016
New Revision: 285645
URL: http://llvm.org/viewvc/llvm-project?rev=285645&view=rev
Log:
[Release notes] Highlight reset() as language/library artifact.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285644: [ASTMatcher] Add CXXNewExpr support to
hasDeclaration (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26032?vs=76316&id=76490#toc
Repository:
rL LLVM
https:
Author: malcolm.parsons
Date: Mon Oct 31 17:04:07 2016
New Revision: 285644
URL: http://llvm.org/viewvc/llvm-project?rev=285644&view=rev
Log:
[ASTMatcher] Add CXXNewExpr support to hasDeclaration
Reviewers: sbenza, lukasza, aaron.ballman, klimek
Subscribers: lukasza, sbenza, cfe-commits
Differe
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
eugenis updated this revision to Diff 76489.
Repository:
rL LLVM
https://reviews.llvm.org/D26164
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/cfi-icall-cross-dso2.c
Index: test/CodeGen/cfi-icall-cross-dso2.c
===
--- /de
Author: rjmccall
Date: Mon Oct 31 16:56:26 2016
New Revision: 285643
URL: http://llvm.org/viewvc/llvm-project?rev=285643&view=rev
Log:
A compound literal within a global lambda or block is still within
the body of a function for the purposes of computing its storage
duration and deciding whether i
dcoughlin added a comment.
Thanks for the patch!
Would it be possible to split this up into several patches? I think it is
important to separate the interface layering changes from the formatting
changes, renaming changes, and minor optimization changes. This will make the
patches easier to re
twoh added a comment.
In https://reviews.llvm.org/D25225#584012, @hfinkel wrote:
> In https://reviews.llvm.org/D25225#584010, @twoh wrote:
>
> > Is there a particular reason why "opt_record_file" is defined in
> > CC1Options.td, not Options.td? If -opt-record-file= is provided
> > by the comman
ahatanak created this revision.
ahatanak added reviewers: rsmith, majnemer.
ahatanak added a subscriber: cfe-commits.
This patch makes AnalysisBasedWarnings::IssueWarnings return without issuing
warnings based on CFG analysis when a fatal error has occurred. This is needed
to avoid a crash that
pcc added inline comments.
Comment at: lib/CodeGen/CodeGenModule.cpp:934
+ if (CodeGenOpts.SanitizeCfiCrossDso)
+CreateFunctionTypeMetadata(dyn_cast(D), F);
}
It looks like we can get here with declarations that are not of type
`FunctionDecl` (mostly via `
hfinkel added a comment.
In https://reviews.llvm.org/D25225#584010, @twoh wrote:
> Is there a particular reason why "opt_record_file" is defined in
> CC1Options.td, not Options.td? If -opt-record-file= is provided by
> the command line, line 829-831 in CompilerInvocation.cpp won't handle it
>
twoh added a comment.
Is there a particular reason why "opt_record_file" is defined in CC1Options.td,
not Options.td? If -opt-record-file= is provided by the command line,
line 829-831 in CompilerInvocation.cpp won't handle it because opt_record_file
is not a CodeGenArg.
Repository:
rL LLVM
On Mon, Oct 31, 2016 at 2:01 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Oct 31, 2016 at 01:25:19PM -0700, Richard Smith wrote:
> > We could alternatively control the language features based only on the
> > selected language mode, and only use version dete
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285640: [analyzer] Allow undefined values in
performTrivialCopy. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D25727?vs=74994&id=76482#toc
Repository:
rL LLVM
https://r
Author: dergachev
Date: Mon Oct 31 16:11:20 2016
New Revision: 285640
URL: http://llvm.org/viewvc/llvm-project?rev=285640&view=rev
Log:
[analyzer] Allow undefined values in performTrivialCopy.
Reading from a garbage pointer should be modeled as garbage,
and performTrivialCopy should be able to de
eugenis created this revision.
eugenis added a reviewer: pcc.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
CFI (only in the cross-dso mode) fails to set !type annotations when
a function is used before it is defined.
Repository:
rL LLVM
htt
branko created this revision.
branko added a reviewer: djasper.
branko added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Actual regression was introduced in r272668. This revision fixes JS script, but
also regress Cpp case. It manifests with spaces added when template is followe
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseEqualsDeleteCheck.cpp:29
+cxxMethodDecl(
+anyOf(isCopyAssignmentOperator(), isMoveAssignmentOperator())),
+cxxDestructorDecl()));
How about a conversi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285637: [analyzer] MacOSXAPIChecker: Improve warnings for
__block vars in dispatch_once. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D26159?vs=76453&id=76478#toc
Reposito
Author: dergachev
Date: Mon Oct 31 16:04:54 2016
New Revision: 285637
URL: http://llvm.org/viewvc/llvm-project?rev=285637&view=rev
Log:
[analyzer] MacOSXAPIChecker: Improve warnings for __block vars in dispatch_once.
The checker already warns for __block-storage variables being used as a
dispatch
Author: kledzik
Date: Mon Oct 31 16:04:17 2016
New Revision: 285636
URL: http://llvm.org/viewvc/llvm-project?rev=285636&view=rev
Log:
fix _dyld_find_unwind_sections() for pre-10.7. Patch by Jeremy Sequoia
Modified:
libunwind/trunk/src/AddressSpace.hpp
Modified: libunwind/trunk/src/AddressSp
Eugene.Zelenko added a comment.
It'll be good idea to rename //modernize-use-default// in similar fashion,
since both checks are closely relate and in both cases keywords are ambiguous.
https://reviews.llvm.org/D26138
___
cfe-commits mailing list
c
klimek accepted this revision.
klimek added a comment.
Yep, makes sense. Open issues are all about types :)
https://reviews.llvm.org/D26032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
On Mon, Oct 31, 2016 at 01:25:19PM -0700, Richard Smith wrote:
> We could alternatively control the language features based only on the
> selected language mode, and only use version detection to power a warning
> for the (currently fairly common, but becoming less so) case where the
> selected run
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Assuming @klimek agrees with the design, this LGTM. If you don't hear from
Manuel by next Wed, I think you're okay to commit (we can always roll it back
post-commit if needed).
NoQ added a comment.
> FIXME: The analyzer sets stack memory space for __block variables when they
> are referenced outside the block (eg. test_block_var_from_outside_block()
> line 108). Will try to fix in a separate patch; i'm not relying on the memory
> space in this patch.
That's actually
Author: rsmith
Date: Mon Oct 31 15:25:52 2016
New Revision: 285631
URL: http://llvm.org/viewvc/llvm-project?rev=285631&view=rev
Log:
Add comment explaining this mysterious macro name.
Modified:
cfe/trunk/lib/Frontend/InitPreprocessor.cpp
Modified: cfe/trunk/lib/Frontend/InitPreprocessor.cpp
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM.
We should probably be warning any time the address of a block variable is taken
since the address is not stable -- but that's a job for a different checker or
possibly even Sema.
On Mon, Oct 31, 2016 at 11:21 AM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Mon, Oct 31, 2016 at 10:45:05AM -0700, Richard Smith via cfe-commits
> wrote:
> > On Sun, Oct 30, 2016 at 12:32 PM, Joerg Sonnenberger
> wrote:
> >
> > > On Sun, Oct 30, 2016 at 12:54:28
rnk added a comment.
Added some people who might have opinions on the command line interface. Sorry,
I don't have a lot of time for this right now.
https://reviews.llvm.org/D24933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
sebpop added a comment.
In https://reviews.llvm.org/D25624#583163, @mehdi_amini wrote:
> I'd like to understand why only the destructor?
We have committed a patch to inline the constructor of std::string.
Do you think we should inline some other functions?
In https://reviews.llvm.org/D25624#58
kubabrecka added a comment.
Just a question: TSan intercepts on the dylib functions, namely
`__release_shared`, to track the atomic accesses. Can you make sure this
doesn't break? There's a few testcases for this in compiler-rt.
https://reviews.llvm.org/D24991
___
sebpop added a comment.
Ping: Eric, Marshall, could you please approve or comment on this patch?
Thanks!
https://reviews.llvm.org/D24991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
> On Oct 31, 2016, at 12:09 PM, Victor Leschuk via cfe-commits
> wrote:
>
> Author: vleschuk
> Date: Mon Oct 31 14:09:47 2016
> New Revision: 285625
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285625&view=rev
> Log:
> DebugInfo: support for DW_TAG_atomic_type
>
> Mark C11 _Atomic variabl
hxy9243 accepted this revision.
hxy9243 added a comment.
This revision is now accepted and ready to land.
Looks good to me.
Notice that the performance gain can only be observed when compiled with the
updated C++ header files.
https://reviews.llvm.org/D24991
_
aaron.ballman added inline comments.
Comment at: clang-tidy/cppcoreguidelines/Suppression.h:59
+ anyOf(hasAncestor(attributedStmt(hasSuppressAttr(Rules))),
+ hasAncestor(decl(hasAttrs(), hasSuppressAttr(Rules)
+ .matches(Node, Finder, Builde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285625: DebugInfo: support for DW_TAG_atomic_type (authored
by vleschuk).
Changed prior to commit:
https://reviews.llvm.org/D26145?vs=76441&id=76458#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Author: vleschuk
Date: Mon Oct 31 14:09:47 2016
New Revision: 285625
URL: http://llvm.org/viewvc/llvm-project?rev=285625&view=rev
Log:
DebugInfo: support for DW_TAG_atomic_type
Mark C11 _Atomic variables with DW_TAG_atomic_type tag.
Differential Revision: https://reviews.llvm.org/D26145
Added:
zaks.anna added a comment.
Thanks for the review! I'll submit the updated patches soon.
https://reviews.llvm.org/D25857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: nemanjai
Date: Mon Oct 31 14:02:54 2016
New Revision: 285623
URL: http://llvm.org/viewvc/llvm-project?rev=285623&view=rev
Log:
NFC - Reorder test case names in a PPC test case
A few recent commits have messed up the order of some tests
in a PPC test case. This just reorders them in a sens
On Mon, Oct 31, 2016 at 2:55 PM, Malcolm Parsons
wrote:
> malcolm.parsons added inline comments.
>
>
>
> Comment at: clang-tidy/modernize/UseAutoCheck.cpp:404
> +[](const Expr *Expr) { return Expr->getType(); },
> +"use auto when initializing with n
malcolm.parsons added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:404
+[](const Expr *Expr) { return Expr->getType(); },
+"use auto when initializing with new to avoid "
+"duplicating the type name");
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
The checker already warns for `__block`-storage variables being used as a
`dispatch_once()` predicate, however it refers to them as local which is not
quite accurate, so we fix that.
Also
Author: mzuckerm
Date: Mon Oct 31 13:40:17 2016
New Revision: 285617
URL: http://llvm.org/viewvc/llvm-project?rev=285617&view=rev
Log:
Fixing problem with CodeGen/avx512-kconstraints-att_inline_asm.c
Modified:
cfe/trunk/test/CodeGen/avx512-kconstraints-att_inline_asm.c
Modified: cfe/trunk
On 31 October 2016 at 17:23, Michael Zuckerman via cfe-commits
wrote:
> Author: mzuckerm
> Date: Mon Oct 31 12:23:52 2016
> New Revision: 285604
>
> URL: http://llvm.org/viewvc/llvm-project?rev=285604&view=rev
> Log:
> [x86][inline-asm][AVX512][clang][PART-1] Introducing "k" and "Yk" constraints
aaron.ballman added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:404
+[](const Expr *Expr) { return Expr->getType(); },
+"use auto when initializing with new to avoid "
+"duplicating the type name");
--
yaxunl added a comment.
LGTM. Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D26157
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: majnemer
Date: Mon Oct 31 13:23:02 2016
New Revision: 285612
URL: http://llvm.org/viewvc/llvm-project?rev=285612&view=rev
Log:
Add a warning flag for warn_alloca_align_alignof
Modified:
cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td
Modified: cfe/trunk/include/clang/Basic/Diagn
Author: rsmith
Date: Mon Oct 31 13:18:29 2016
New Revision: 285610
URL: http://llvm.org/viewvc/llvm-project?rev=285610&view=rev
Log:
When diagnosing that a defaulted function is ill-formed because it would be
implicitly deleted and overrides a non-deleted function, explain why the
function is dele
Anastasia added a comment.
It looks good generally. My only concern here if anyone could use this MD
expecting target AS values which correspond to those put in the IR itself. On
the other hand clGetKernelArgInfo is supposed to be used for obtaining the
information about the original source whi
On Mon, Oct 31, 2016 at 10:45:05AM -0700, Richard Smith via cfe-commits wrote:
> On Sun, Oct 30, 2016 at 12:32 PM, Joerg Sonnenberger wrote:
>
> > On Sun, Oct 30, 2016 at 12:54:28PM -0600, Eric Fiselier wrote:
> > > Richard requested this change. Take a look at
> > > https://reviews.llvm.org/D260
Added in r285609.
On Mon, Oct 31, 2016 at 9:21 AM, Hal Finkel wrote:
> Hi David,
>
> On Reid's patch for this (D25581), Richard said, "This takes the alignment
> in bits? That's so ridiculously dumb that I would feel bad about accepting
> this patch unless it comes with a warning for people writ
Author: majnemer
Date: Mon Oct 31 13:07:57 2016
New Revision: 285609
URL: http://llvm.org/viewvc/llvm-project?rev=285609&view=rev
Log:
[Sema] Warn when alignof is used with __builtin_alloca_with_align
The second argument to __builtin_alloca_with_align is supposed to be in
bits, not bytes. Using
yaxunl added inline comments.
Comment at: test/CodeGenOpenCL/convergent.cl:54
+// CHECK: tail call spir_func void @f()
+// CHECK-NOT: call spir_func void @non_convfun()
+// CHECK-NOT: call spir_func void @g()
Anastasia wrote:
> Did you mean to check @convfun() he
aprantl added a comment.
One more inline comment.
Comment at: test/CodeGen/debug-info-atomic.c:4
+// CHECK: !DIGlobalVariable(name: "i"{{.*}}type: !5, isLocal: false,
isDefinition: true)
+// CHECK: !5 = !DIDerivedType(tag: DW_TAG_const_type, baseType: !6)
+// CHECK: !6 = !DIDe
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaDeclCXX.cpp:13875-13876
+ // A deleted function is implicitly inline.
+ // NOTE: Modules cannot correctly merge deleted functions unless they
On Sun, Oct 30, 2016 at 12:32 PM, Joerg Sonnenberger wrote:
> On Sun, Oct 30, 2016 at 12:54:28PM -0600, Eric Fiselier wrote:
> > Richard requested this change. Take a look at
> > https://reviews.llvm.org/D26044 for more rational.
>
> I don't see much rational and in fact, I disagree with some of
malcolm.parsons added a comment.
In https://reviews.llvm.org/D25316#583651, @aaron.ballman wrote:
> Does this check properly work in the presence of macros? Those are sometimes
> more common in casting operations, so a few explicit tests would be good
> (those tests could be follow-on work if i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285605: [analyzer] MacOSXAPIChecker: Disallow
dispatch_once_t in ivars and heap. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D25909?vs=75998&id=76446#toc
Repository:
rL
Author: dergachev
Date: Mon Oct 31 12:27:26 2016
New Revision: 285605
URL: http://llvm.org/viewvc/llvm-project?rev=285605&view=rev
Log:
[analyzer] MacOSXAPIChecker: Disallow dispatch_once_t in ivars and heap.
Unlike global/static variables, calloc etc. functions that allocate ObjC
objects behave
1 - 100 of 199 matches
Mail list logo
