Author: djasper Date: Tue Nov 1 01:22:54 2016 New Revision: 285669 URL: http://llvm.org/viewvc/llvm-project?rev=285669&view=rev Log: clang-format: [JS] Fix space when for is used as regular identifier.
Before: x.for () = 1; After: x.for() = 1; Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp cfe/trunk/unittests/Format/FormatTestJS.cpp Modified: cfe/trunk/lib/Format/TokenAnnotator.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/TokenAnnotator.cpp?rev=285669&r1=285668&r2=285669&view=diff ============================================================================== --- cfe/trunk/lib/Format/TokenAnnotator.cpp (original) +++ cfe/trunk/lib/Format/TokenAnnotator.cpp Tue Nov 1 01:22:54 2016 @@ -2159,6 +2159,9 @@ bool TokenAnnotator::spaceRequiredBefore Keywords.kw_of, tok::kw_const) && (!Left.Previous || !Left.Previous->is(tok::period))) return true; + if (Left.is(tok::kw_for) && Left.Previous && + Left.Previous->is(tok::period) && Right.is(tok::l_paren)) + return false; if (Left.is(Keywords.kw_as) && Right.isOneOf(tok::l_square, tok::l_brace, tok::l_paren)) return true; Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTestJS.cpp?rev=285669&r1=285668&r2=285669&view=diff ============================================================================== --- cfe/trunk/unittests/Format/FormatTestJS.cpp (original) +++ cfe/trunk/unittests/Format/FormatTestJS.cpp Tue Nov 1 01:22:54 2016 @@ -135,6 +135,7 @@ TEST_F(FormatTestJS, ReservedWords) { verifyFormat("x.in() = 1;"); verifyFormat("x.let() = 1;"); verifyFormat("x.var() = 1;"); + verifyFormat("x.for() = 1;"); verifyFormat("x = {\n" " a: 12,\n" " interface: 1,\n" _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits