dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:462
+ case CK_ReinterpretMemberPointer: {
+const Expr *UOExpr = CastE->getSubExpr()->IgnoreParenCasts();
+assert(isa(UOExpr) &&
dcoughlin wrote:
> dcoughlin
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:462
+ case CK_ReinterpretMemberPointer: {
+const Expr *UOExpr = CastE->getSubExpr()->IgnoreParenCasts();
+assert(isa(UOExpr) &&
dcoughlin wrote:
> I don't th
On 15 October 2016 at 13:08, Eric Fiselier via cfe-commits
wrote:
> Are these tests still broken for you?
They're still breaking multiple Green Dragon bots (e.g. the basic
"make check" at
http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA/)[1].
What do you need to help fix the issue?
C
On Fri, Oct 14, 2016 at 09:47:17PM -0400, Brad Smith via cfe-commits wrote:
> On Fri, Oct 14, 2016 at 05:59:54PM -, Ed Maste via cfe-commits wrote:
> > Author: emaste
> > Date: Fri Oct 14 12:59:53 2016
> > New Revision: 284256
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=284256&view=re
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngineC.cpp:462
+ case CK_ReinterpretMemberPointer: {
+const Expr *UOExpr = CastE->getSubExpr()->IgnoreParenCasts();
+assert(isa(UOExpr) &&
I don't think pattern matchin
Author: rsmith
Date: Tue Oct 18 19:14:23 2016
New Revision: 284556
URL: http://llvm.org/viewvc/llvm-project?rev=284556&view=rev
Log:
Resolve exception specifications when selecting an overloaded operator.
Modified:
cfe/trunk/lib/Sema/SemaOverload.cpp
cfe/trunk/test/SemaCXX/constant-expres
Author: jlebar
Date: Tue Oct 18 19:06:49 2016
New Revision: 284553
URL: http://llvm.org/viewvc/llvm-project?rev=284553&view=rev
Log:
[CUDA] Rework tests now that we emit deferred diagnostics during sema.
Test-only change.
Summary:
Previously we had to split out a lot of our tests into a test th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284553: [CUDA] Rework tests now that we emit deferred
diagnostics during sema. Test… (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D25755?vs=75085&id=75099#toc
Repository:
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D25755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
On Mon, Oct 17, 2016 at 3:31 PM, Manman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> > On Oct 17, 2016, at 2:11 PM, Bruno Cardoso Lopes via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >
> > Hi,
> >
> > On Fri, Oct 14, 2016 at 3:09 PM, Richard Smith
> wrote:
> >> On Fri, Oct 14
On Tue, Oct 18, 2016 at 4:30 PM, Bruno Cardoso Lopes <
bruno.card...@gmail.com> wrote:
> Hi Richard,
>
> Turns out that the redefinition error was caused because libc++
> modulemap lacked a module for its "string.h", and therefore it would
> be textually included in more than one module, yielding
Author: rsmith
Date: Tue Oct 18 18:39:12 2016
New Revision: 284549
URL: http://llvm.org/viewvc/llvm-project?rev=284549&view=rev
Log:
DR1330: instantiate exception-specifications when "needed". We previously did
not instantiate exception specifications of functions if they were only used in
unevalu
zaks.anna added a comment.
Looks like you've also added handling of Xor, Or , Div, and Rem. Should there
be tests for those?
Repository:
rL LLVM
https://reviews.llvm.org/D25596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
Hi Richard,
Turns out that the redefinition error was caused because libc++
modulemap lacked a module for its "string.h", and therefore it would
be textually included in more than one module, yielding the error.
With the attached patch for libc++ modulemap (extracted from parts of
a modulemap you
jlebar updated this revision to Diff 75085.
jlebar added a comment.
Remove line that should be added in a different patch.
https://reviews.llvm.org/D25755
Files:
clang/test/PCH/pragma-cuda-force-host-device.cu
clang/test/Parser/cuda-force-host-device-templates.cu
clang/test/SemaCUDA/devic
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
Previously we had to split out a lot of our tests into a test that
checked only immediate errors and a test that checked only deferred
errors. This was because, if you emitted any immediate errors,
aprantl added a comment.
This patch is conflating two set of changes:
(1) NFC: rename all occurrences of unsigned for alignment purposes in the
frontend with uint32_t
(2) shrink all debug-info-related alignment variables from uint64_t ->
unint32_t.
I think this patch should only be doing the ch
jlebar added a comment.
In https://reviews.llvm.org/D25403#573666, @mclow.lists wrote:
> Yesterday and today is the first time in a while that clang has been
> seriously broken for more than an hour or so.
> I'm not inclined to worry about it yet.
Oh, awesome. That sounds good to me.
The qu
mclow.lists added a comment.
In https://reviews.llvm.org/D25403#573104, @jlebar wrote:
> Likewise, should I update the documentation to indicate that check-cxx may
> fail with a clang built from tip of tree, due to c++17 support being
> experimental? Or do you all want to change the target so
vleschuk added a comment.
Can anyone take a look at this please? =)
https://reviews.llvm.org/D25621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added a comment.
I like this; I would like to see no mentions of `_WIN32` outside of
`<__config>`.
That being said, we usually write things in the negative in libc++.
So the flag would be `_LIBCPP_HAS_NO_OFF_T_FUNCTIONS`, and the tests would be
`#ifdef _LIBCPP_HAS_NO_OFF_T_FUNCTIONS
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D25093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
manmanren added a comment.
Thanks a lot for the pointers!
I will definitely try them. What I proposed here is something similar to what
llvm does that dumps logging messages, it should be complementary to your
debugging aids.
Manman
In https://reviews.llvm.org/D22638#572753, @v.g.vassilev wro
Author: rsmith
Date: Tue Oct 18 15:27:16 2016
New Revision: 284530
URL: http://llvm.org/viewvc/llvm-project?rev=284530&view=rev
Log:
Add missing warning for use of C++1z init-statements in C++14 and before.
Added:
cfe/trunk/test/SemaCXX/warn-c++1z-extensions.cpp
Modified:
cfe/trunk/includ
hokein created this revision.
hokein added a reviewer: aaron.ballman.
hokein added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
The matcher for matching "class with default constructor" still match
some classes without default constructor, which trigger an assert at
Line 307. Th
Author: rsmith
Date: Tue Oct 18 15:13:25 2016
New Revision: 284528
URL: http://llvm.org/viewvc/llvm-project?rev=284528&view=rev
Log:
[c++1z] Fix corner case where we could create a function type whose canonical
type is not actually canonical.
Modified:
cfe/trunk/include/clang/AST/ASTContext.
Author: rsmith
Date: Tue Oct 18 14:29:18 2016
New Revision: 284519
URL: http://llvm.org/viewvc/llvm-project?rev=284519&view=rev
Log:
When two function types have equivalent (but distinct) noexcept specifications,
create separate type sugar nodes. This is necessary so that substitution into
the e
Author: mgrang
Date: Tue Oct 18 14:22:20 2016
New Revision: 284517
URL: http://llvm.org/viewvc/llvm-project?rev=284517&view=rev
Log:
Fix clang tests
Summary:
Add REQUIRES for target specific tests.
Patch by Azharuddin Mohammed.
Reviewers: apazos, weimingz, rsmith, ddunbar, spop, mgrang
Subscri
This revision was automatically updated to reflect the committed changes.
ahatanak marked 2 inline comments as done.
Closed by commit rL284516: [CodeGen][ObjC] Do not call objc_storeStrong when
initializing a (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D25547?vs=74
Author: ahatanak
Date: Tue Oct 18 14:05:41 2016
New Revision: 284516
URL: http://llvm.org/viewvc/llvm-project?rev=284516&view=rev
Log:
[CodeGen][ObjC] Do not call objc_storeStrong when initializing a
constexpr variable.
When compiling a constexpr NSString initialized with an objective-c
string li
zaks.anna added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/NumberObjectConversionChecker.cpp:72
assert(Conv);
- const Expr *Osboolean = Result.Nodes.getNodeAs("osboolean");
- const Expr *Nsnumber = Result.Nodes.getNodeAs("nsnumber");
- bool IsObjC = (bool)Nsnu
Author: vedantk
Date: Tue Oct 18 13:19:02 2016
New Revision: 284510
URL: http://llvm.org/viewvc/llvm-project?rev=284510&view=rev
Log:
Drop a redundant ".get()" call (NFC)
Pointed out by Malcolm Parsons.
Modified:
cfe/trunk/lib/Basic/SourceManager.cpp
Modified: cfe/trunk/lib/Basic/SourceMana
smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Create this define in __config and use it elsewhere, instead of checking
the operating system/library defines in other files. The aim is to
reduce the usage of _WIN32 outside __con
v.g.vassilev updated this revision to Diff 75050.
v.g.vassilev marked an inline comment as done.
v.g.vassilev added a comment.
Remove assert.
https://reviews.llvm.org/D25678
Files:
lib/Sema/SemaDecl.cpp
test/Modules/Inputs/merge-var-template-def/a.h
test/Modules/Inputs/merge-var-template-
On Tue, Oct 18, 2016 at 9:31 AM, Nico Weber wrote:
> Did you find real-world code triggering this, or did you happen to see the
> implementation of the warning? I'm not sure if omitting just the note or
> the whole warning is more useful in practice. Intuitively I'd say that
> people "never" will
rsmith added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10129
+!Var->isThisDeclarationADemotedDefinition()) {
+ assert(Var->isThisDeclarationADemotedDefinition() &&
getLangOpts().Modules
+ && "Demoting decls is only in the contest of modules!");
kromanenkov updated this revision to Diff 75020.
kromanenkov added a comment.
Null pointer-to-member dereference is now modeled as UndefinedVal. Fixing this
also releases us from loading from nonloc SVal.
I delete an assertion suppression in ExprEngine::performTrivialCopy because I
can't reprodu
insysion added a comment.
Is this issue dead? I'm looking to use the tool for a Whitesmiths formatted
project and would be happy to finish off the work.
https://reviews.llvm.org/D6833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284496: [cmake] Update lit search to match the one in LLVM
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D23745?vs=73192&id=75027#toc
Repository:
rL LLVM
https://reviews.ll
Author: mgorny
Date: Tue Oct 18 12:07:30 2016
New Revision: 284496
URL: http://llvm.org/viewvc/llvm-project?rev=284496&view=rev
Log:
[cmake] Update lit search to match the one in LLVM
Update the lit search logic to support all names supported in LLVM
(since r283029). The search order (i.e. PATHS
Yes. I filed rdar://problem/28812809 to report that
problem in the SDK. I also filed rdar://problem/28825862
to remind us to restore the more strict checking
after we release a version of the tvOS SDK with a fix.
Thanks, Erik!
> On Oct 18, 2016, at 9:46 AM, Erik Pilkington
> wrote:
>
>
>
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Gotcha. LGTM!
https://reviews.llvm.org/D23745
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
mgorny added a comment.
Thanks for the review. Committed the prototype fix first, and followed it by
the C++ conversion.
Repository:
rL LLVM
https://reviews.llvm.org/D25431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
jlebar added a comment.
Thank you, Marshall.
In https://reviews.llvm.org/D25403#572998, @mclow.lists wrote:
> My build setup is similar to yours (on Mac OS X):
>
> cd $LLVM_BUILD ; rm -rf libcxx ; mkdir libcxx ; cd libcxx
> CXX=$LLVM_BIN/clang++ cmake -DLLVM_PATH=$LLVM/llvm
> -DLIBCXX_CXX_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284493: [solaris] Fix iswxdigit_l() support function
prototype (authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D25431?vs=74996&id=75024#toc
Repository:
rL LLVM
https://review
Author: mgorny
Date: Tue Oct 18 11:54:54 2016
New Revision: 284493
URL: http://llvm.org/viewvc/llvm-project?rev=284493&view=rev
Log:
[solaris] Fix iswxdigit_l() support function prototype
Fix the iswxdigit_l() function prototype to take wint_t parameter
instead of incorrect wchar_t.
Differential
Author: mgorny
Date: Tue Oct 18 11:54:59 2016
New Revision: 284494
URL: http://llvm.org/viewvc/llvm-project?rev=284494&view=rev
Log:
[solaris] Convert the support library to C++ to fix -std=c++11 build
Convert the Solaris xlocale.c compatibility library from plain C to C++
in order to fix the bui
On second thought, I think the header *is* ill-formed here. If we allowed this
behaviour, this would provide a way to circumvent an availability diagnostic.
For example, now the following compiles cleanly, where we really should emit a
diagnostic somewhere!
typedef int unavail_int __attribute_
Did you find real-world code triggering this, or did you happen to see the
implementation of the warning? I'm not sure if omitting just the note or
the whole warning is more useful in practice. Intuitively I'd say that
people "never" will compare the result of memcpy, so I'd guess that it
doesn't m
rSerge added a comment.
@dberris , below is the list of features supported by `REQUIRES` and
`REQUIRES-ANY` for me:
set(['system-windows', 'nozlib', u'amdgpu-registered-target',
'case-insensitive-filesystem', u'msp430-registered-target',
u'sparc-registered-target', 'libgcc', 'staticanalyzer'
malcolm.parsons added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
aaron.ballman wrote:
> malcolm.parsons wrote:
> > aaron.ballman wrote:
> > > Since this doub
joerg accepted this revision.
joerg added a reviewer: joerg.
joerg added a comment.
This revision is now accepted and ready to land.
Commit the prototype fix separately, please.
https://reviews.llvm.org/D25431
___
cfe-commits mailing list
cfe-commit
joerg added a comment.
I agree that leaving out the really complicated parts is acceptable for now.
Can you mark the comment as TODO?
https://reviews.llvm.org/D23657
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Hi Bob,
I think the code in the header is fine here, so I reverted in r284486. Here’s a
reduced version:
typedef int unavail_int __attribute__((availability(tvos, unavailable)));
__attribute__((availability(tvos, unavailable)))
@interface A
extern unavail_int foo;
@end
The problem is that ‘foo’
mclow.lists added a comment.
> error: undefined reference to '__gxx_personality_v0'
means that you're not linking to an ABI library.
That symbol comes out of libc++abi, but you can also get that from libsupc.
My build setup is similar to yours (on Mac OS X):
cd $LLVM_BUILD ; rm -rf libcxx ;
Author: epilk
Date: Tue Oct 18 10:26:43 2016
New Revision: 284486
URL: http://llvm.org/viewvc/llvm-project?rev=284486&view=rev
Log:
Revert r284265 "[Sema] Refactor context checking for availability diagnostics"
This has a bug in it, pointed out by Bob Wilson!
Modified:
cfe/trunk/include/clan
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
`CFNumberRef`, much like `NSNumber*`, can also be accidentally mistaken for a
numeric value, so it is worth it to support this type in our new
`NumberObjectConversion` checker.
https://re
rogfer01 updated this revision to Diff 75007.
rogfer01 added a comment.
Ignore cases where the innermost base expression is too complicated for the
scope of this patch.
https://reviews.llvm.org/D23657
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaChecking.cpp
test/Sema/address-packed.c
mharoush updated this revision to Diff 75005.
mharoush added a comment.
Added default case, minor ws style.
Repository:
rL LLVM
https://reviews.llvm.org/D25062
Files:
lib/Target/X86/X86ISelLowering.cpp
Index: lib/Target/X86/X86ISelLowering.cpp
=
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
This seems correct. Loading from a garbage pointer should be modeled as
garbage, and/or caught by a checker. `performTrivialCopy` is a high-level
thingy that should be able to deal with any `SVal` i
erikjv added a comment.
Yes, the patch was not committed, because there were errors in it. So, I fixed
it and put up a new version, but I have no idea how to reset the state.
Still waiting for rsmith to review...
https://reviews.llvm.org/D15994
__
mgorny added a comment.
Gentle ping.
https://reviews.llvm.org/D25093
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
Gentle ping.
https://reviews.llvm.org/D24869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
theraven added a comment.
Looks like a much better change to me.
https://reviews.llvm.org/D25431
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 74996.
mgorny added a comment.
Ok, here's a minimal change necessary to fix the build. I'm not touching
anything else not to break it ;-).
https://reviews.llvm.org/D25431
Files:
lib/CMakeLists.txt
src/suppor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284477: alpha.core.UnreachableCode - don't warn about
unreachable code inside macro (authored by danielmarjamaki).
Changed prior to commit:
https://reviews.llvm.org/D25606?vs=74849&id=74990#toc
Reposit
Author: danielmarjamaki
Date: Tue Oct 18 08:16:53 2016
New Revision: 284477
URL: http://llvm.org/viewvc/llvm-project?rev=284477&view=rev
Log:
alpha.core.UnreachableCode - don't warn about unreachable code inside macro
In macros, 'do {...} while (0)' is often used. Don't warn about the condition 0
Author: rksimon
Date: Tue Oct 18 08:15:31 2016
New Revision: 284476
URL: http://llvm.org/viewvc/llvm-project?rev=284476&view=rev
Log:
Fix signed/unsigned comparison warnings
Modified:
clang-tools-extra/trunk/unittests/clang-tidy/NamespaceAliaserTest.cpp
clang-tools-extra/trunk/unittests/c
aaron.ballman added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
malcolm.parsons wrote:
> aaron.ballman wrote:
> > Since this doubles the size of the type loc
mharoush updated this revision to Diff 74986.
mharoush added a comment.
Herald added a subscriber: mehdi_amini.
fixed Reids comments
Repository:
rL LLVM
https://reviews.llvm.org/D25062
Files:
lib/Target/X86/X86ISelLowering.cpp
Index: lib/Target/X86/X86ISelLowering.cpp
coby created this revision.
coby added a reviewer: m_zuckerman.
coby added a subscriber: cfe-commits.
coby set the repository for this revision to rL LLVM.
In respect to https://reviews.llvm.org/D25004 (reverted)
Repository:
rL LLVM
https://reviews.llvm.org/D25717
Files:
lib/Basic/Targets.
Author: ddcc
Date: Mon Oct 17 20:15:19 2016
New Revision: 284445
URL: http://llvm.org/viewvc/llvm-project?rev=284445&view=rev
Log:
[analyzer] Update alpha and potential checker documentation, esp. alpha.valist
Summary:
Move alpha.valist from potential to alpha since it was implemented in D15227
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284445: [analyzer] Update alpha and potential checker
documentation, esp. alpha.valist (authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D25663?vs=74807&id=74941#toc
Repository:
r
malcolm.parsons added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-one-name-per-declaration.cpp:8
+ {
+int x = 42, y = 43;
+// CHECK-MESSAGES: :[[@LINE-1]]:5: warning: Do not declare multiple names
per declaration [cppcoreguidelines-one-name-per-declar
On 18 October 2016 at 12:08, Eric Liu wrote:
> clang-apply-replacements has some legacy code and needs some refactoring
> in order to take advantage of the cleanup feature (because of the new
> tooling::Replacements implementation). I had a plan to refactor it but
> thought it was a low priority
v.g.vassilev added a comment.
Also, creduce (I've specialized it a bit for modules) helps reducing the
modules complexity
(https://github.com/vgvassilev/creduce/blob/master/USAGE.md#reducing-clang-c-modules-bugs).
After reduction, the debugger is much more useful.
https://reviews.llvm.org/D22
v.g.vassilev added a comment.
I am not sure whether that's useful for debugging out-of-date issues but this
is what I use and it is helpful.
Some debugging aids (suggested by Richard Smith):
-fdiagnostics-show-note-include-stack will tell you which module a note comes
from
#pragma clang __
omtcyfz added a comment.
Opened an [[ https://github.com/isocpp/CppCoreGuidelines/issues/770 | issue
]]in CppCoreGuidelines Github repo.
https://reviews.llvm.org/D25024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
vkalintiris added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:1633-1637
+ if (!m)
+return SemaBuiltinConstantArgRange(TheCall, i, l, u);
+
+return SemaBuiltinConstantArgRange(TheCall, i, l, u) ||
+ SemaBuiltinConstantArgMultiple(TheCall, i, m);
-
vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.
LGTM. See inline comments for a few small changes.
The only issue I've found with test/CodeGen/builtins-mips-msa-error.c is that
GCC checks strictly the signedness of the arguments p
Author: dergachev
Date: Tue Oct 18 06:06:28 2016
New Revision: 284473
URL: http://llvm.org/viewvc/llvm-project?rev=284473&view=rev
Log:
[analyzer] Add NumberObjectConversion checker.
When dealing with objects that represent numbers, such as Objective-C NSNumber,
the language provides little prote
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284473: [analyzer] Add NumberObjectConversion checker.
(authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D22968?vs=74969&id=74979#toc
Repository:
rL LLVM
https://reviews.llv
clang-apply-replacements has some legacy code and needs some refactoring in
order to take advantage of the cleanup feature (because of the new
tooling::Replacements implementation). I had a plan to refactor it but
thought it was a low priority since most refactoring tools are using
replacements app
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284472: [CodeCompletion] Add a block property setter
completion result (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25520?vs=74528&id=74977#toc
Repository:
rL LLVM
http
Author: arphaman
Date: Tue Oct 18 05:55:01 2016
New Revision: 284472
URL: http://llvm.org/viewvc/llvm-project?rev=284472&view=rev
Log:
[CodeCompletion] Add a block property setter completion result
This commit changes code completion results for Objective-C block properties:
clang now suggests an
malcolm.parsons updated this revision to Diff 74975.
malcolm.parsons added a comment.
Add unit tests for long double.
https://reviews.llvm.org/D25363
Files:
include/clang/AST/TypeLoc.h
include/clang/Sema/DeclSpec.h
lib/Sema/DeclSpec.cpp
lib/Sema/SemaType.cpp
unittests/AST/SourceLocati
arphaman added a comment.
In https://reviews.llvm.org/D25520#569389, @akyrtzi wrote:
> > What do you think of the following possible priority heuristic
>
> SGTM.
>
> Changes LGTM. I'd also recommend that as a follow-up patch it would be great
> to extend the setter completion to variables as w
malcolm.parsons added inline comments.
Comment at: unittests/AST/SourceLocationTest.cpp:228
+}
+
TEST(CXXConstructorDecl, NoRetFunTypeLocRange) {
aaron.ballman wrote:
> Can you also add a test that the range is correct for something like `long
> double` and `l
Author: arphaman
Date: Tue Oct 18 05:38:58 2016
New Revision: 284468
URL: http://llvm.org/viewvc/llvm-project?rev=284468&view=rev
Log:
[CodeCompletion][NFC] Extract a function that formats block placeholders.
This commit extracts a new function named `formatBlockPlaceholder` from
the function `Fo
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284467: [CodeCompletion][NFC] Extract a function that looks
for block decl type locs. (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25519?vs=74520&id=74972#toc
Repository:
Author: arphaman
Date: Tue Oct 18 05:35:27 2016
New Revision: 284467
URL: http://llvm.org/viewvc/llvm-project?rev=284467&view=rev
Log:
[CodeCompletion][NFC] Extract a function that looks for block decl type locs.
This commit extracts a new function named `findTypeLocationForBlockDecl` from
the fu
NoQ updated this revision to Diff 74969.
NoQ added a comment.
- Support conversion though function calls.
- Move "if (x == 0)" to pedantic for now (too loud).
https://reviews.llvm.org/D22968
Files:
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/StaticAnalyzer/Checkers/CMakeLists.txt
malcolm.parsons added inline comments.
Comment at: include/clang/AST/TypeLoc.h:513
struct BuiltinLocInfo {
- SourceLocation BuiltinLoc;
+ SourceRange BuiltinRange;
};
aaron.ballman wrote:
> Since this doubles the size of the type loc for builtin types, do you
arphaman created this revision.
arphaman added a reviewer: rsmith.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch fixes an assertion failure crash that happens when a constant record
reference member is initialized using an empty ini
Author: ikudrin
Date: Tue Oct 18 04:42:03 2016
New Revision: 284464
URL: http://llvm.org/viewvc/llvm-project?rev=284464&view=rev
Log:
[libclang] Add missing cursor kinds to python bindings.
Differential Revision: https://reviews.llvm.org/D25673
Modified:
cfe/trunk/bindings/python/clang/cinde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284464: [libclang] Add missing cursor kinds to python
bindings. (authored by ikudrin).
Changed prior to commit:
https://reviews.llvm.org/D25673?vs=74834&id=74960#toc
Repository:
rL LLVM
https://revi
malcolm.parsons added a comment.
Does clang-apply-replacements need a similar change?
Repository:
rL LLVM
https://reviews.llvm.org/D24572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284463: [libclang] Fix a failure in a test for python
bindings on CursorKind. (authored by ikudrin).
Changed prior to commit:
https://reviews.llvm.org/D25470?vs=74237&id=74959#toc
Repository:
rL LLVM
Author: ikudrin
Date: Tue Oct 18 04:30:33 2016
New Revision: 284463
URL: http://llvm.org/viewvc/llvm-project?rev=284463&view=rev
Log:
[libclang] Fix a failure in a test for python bindings on
CursorKind.OVERLOAD_CANDIDATE.
The test fails because the value does not lay in any existing group.
Dif
NoQ added a subscriber: a.sidorin.
NoQ added a comment.
Wow, you managed to check something that could be checked without going through
a hell of modeling dozens of STL methods, and probably even without stepping on
poor C++ temporary object modeling in the analyzer, which sounds great.
These c
1 - 100 of 108 matches
Mail list logo
