malcolm.parsons added inline comments.

================
Comment at: include/clang/AST/TypeLoc.h:513
 struct BuiltinLocInfo {
-  SourceLocation BuiltinLoc;
+  SourceRange BuiltinRange;
 };
----------------
aaron.ballman wrote:
> Since this doubles the size of the type loc for builtin types, do you happen 
> to have any data on what practical impact this has on RAM usage, say for 
> bootstrapping LLVM (or compiling any large source base, really)? Hopefully 
> it's not a lot, but it would be nice to know if it's a .1%, 1%, 10%, etc 
> increase in usage (or does the change get lost in the noise).
I don't have any data.
I'm not sure how to collect that data.


https://reviews.llvm.org/D25363



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to