r283657 - Un-tabify source files, NFC.

Author: yrnkrn Date: Sat Oct 8 01:45:10 2016 New Revision: 283657 URL: http://llvm.org/viewvc/llvm-project?rev=283657&view=rev Log: Un-tabify source files, NFC. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/AST/NestedNameSpecifier.cpp

[PATCH] D25389: Fix std::pair on FreeBSD

EricWF created this revision. EricWF added reviewers: emaste, dim, theraven, rsmith. EricWF added a subscriber: cfe-commits. FreeBSD ships an old ABI for std::pair which requires that it have non-trivial copy/move constructors. Currently the non-trivial copy/move is achieved by providing explici

r283645 - Use StringRef in Command::printArg() instead of raw pointer (NFC)

Author: mehdi_amini Date: Fri Oct 7 20:38:43 2016 New Revision: 283645 URL: http://llvm.org/viewvc/llvm-project?rev=283645&view=rev Log: Use StringRef in Command::printArg() instead of raw pointer (NFC) Modified: cfe/trunk/include/clang/Driver/Job.h cfe/trunk/lib/Driver/Job.cpp Modified

[libcxx] r283644 - Remove all _LIBCPP_VERSION tests from under test/std

Author: ericwf Date: Fri Oct 7 20:32:56 2016 New Revision: 283644 URL: http://llvm.org/viewvc/llvm-project?rev=283644&view=rev Log: Remove all _LIBCPP_VERSION tests from under test/std Added: libcxx/trunk/test/libcxx/depr/depr.c.headers/ciso646.pass.cpp libcxx/trunk/test/libcxx/depr/depr

[libcxx] r283643 - Purge all usages of _LIBCPP_STD_VER under test/std/algorithm

Author: ericwf Date: Fri Oct 7 20:25:23 2016 New Revision: 283643 URL: http://llvm.org/viewvc/llvm-project?rev=283643&view=rev Log: Purge all usages of _LIBCPP_STD_VER under test/std/algorithm Modified: libcxx/trunk/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp libcxx/tr

[PATCH] D25387: When optimizing for size, enable loop rerolling by default.

hfinkel created this revision. hfinkel added a reviewer: jmolloy. hfinkel added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. We have a loop-rerolling optimization which can be enabled by using -freroll-loops. While sometimes loops are hand-unrolled for performance reasons, whe

r283637 - [CUDA] Do a better job at detecting wrong-side calls.

Author: jlebar Date: Fri Oct 7 20:07:11 2016 New Revision: 283637 URL: http://llvm.org/viewvc/llvm-project?rev=283637&view=rev Log: [CUDA] Do a better job at detecting wrong-side calls. Summary: Move CheckCUDACall from ActOnCallExpr and BuildDeclRefExpr to DiagnoseUseOfDecl. This lets us catch

[PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added a comment. I have a couple of minor comments, but patch looks good to me. Comment at: lib/Sema/SemaStmtAsm.cpp:141 +// Extracting the register name from the Expression value, +// if there is no register name to extract, returns "" Please remove

[libcxx] r283633 - Add missing include in test

Author: ericwf Date: Fri Oct 7 19:59:16 2016 New Revision: 283633 URL: http://llvm.org/viewvc/llvm-project?rev=283633&view=rev Log: Add missing include in test Modified: libcxx/trunk/test/std/utilities/tuple/tuple.tuple/tuple.assign/copy.pass.cpp Modified: libcxx/trunk/test/std/utilities/

[libcxx] r283632 - Add missing include in test_allocator.h

Author: ericwf Date: Fri Oct 7 19:57:56 2016 New Revision: 283632 URL: http://llvm.org/viewvc/llvm-project?rev=283632&view=rev Log: Add missing include in test_allocator.h Modified: libcxx/trunk/test/support/test_allocator.h Modified: libcxx/trunk/test/support/test_allocator.h URL: http://

[libcxx] r283631 - [libc++] Fix stack_allocator

Author: ericwf Date: Fri Oct 7 19:56:22 2016 New Revision: 283631 URL: http://llvm.org/viewvc/llvm-project?rev=283631&view=rev Log: [libc++] Fix stack_allocator Summary: To quote STL the problems with stack allocator are" >"stack_allocator is seriously nonconformant to N4582 17.6.3.5 >[allocat

[PATCH] D25154: [libc++] Fix stack_allocator

EricWF updated this revision to Diff 74006. EricWF added a comment. Rewrite the patch entirely. Instead of using an actual "stack buffer" I've transformed `stack_allocator` into `limited_allocator` which allows at most `N` elements to be allocated from it. This resolves the issues about stack u

[PATCH] D25361: [libcxx] Add the missing limits.h header

rsmith added a comment. I only skipped this one because it seemed pointless to me. I have no objection to providing it, and this change makes perfect sense if libc++ wants to guarantee that `<__config>` is included whenever any standard C++ header is included. https://reviews.llvm.org/D25361

[PATCH] D25361: [libcxx] Add the missing limits.h header

mclow.lists added a comment. This looks fine to me, but since @rsmith added all the other C headers, I'd like him to weigh in. https://reviews.llvm.org/D25361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D24371: Add diagnostics to require_constant_initialization

EricWF added a comment. @rsmith ping. Any more comments on this patch? Repository: rL LLVM https://reviews.llvm.org/D24371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25154: [libc++] Fix stack_allocator

STL_MSFT added a comment. F2472251: msvc_warnings.txt - The attached patch on top of your patch fixes two simple MSVC warnings - unreferenced formal parameter and class/struct mismatch. - Three tests are emitting stack consumption warnings (since MSVC /analyz

[PATCH] D25008: [cmake] Split linked libraries into private & public, for linker script

EricWF added inline comments. Comment at: lib/CMakeLists.txt:41 +else() + list(APPEND LIBCXX_LIBRARIES_PUBLIC "${LIBCXX_CXX_ABI_LIBRARY}") +endif() Please handle the special case for Apple here, where it manually re-exports the ABI lib. Comme

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

anemet added a comment. LGTM, thanks. I also like the option name but will let the the other reviewers official approve that part. https://reviews.llvm.org/D25225 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

hfinkel updated this revision to Diff 74001. hfinkel added a comment. Herald added a subscriber: mehdi_amini. Addressed review comments (DebugLoc is tested, and we enable hotness computation when saving the optimization record and also using PGO). https://reviews.llvm.org/D25225 Files: inclu

[PATCH] D14259: The maximum alignment of std::aligned_storage applies to all Windows compilers

mclow.lists closed this revision. mclow.lists added a comment. This duplicates @D25053, and I've landed this change as revision 283621. https://reviews.llvm.org/D14259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[libcxx] r283621 - Disable alignment support of 0x4000 for Win32. https://reviews.llvm.org/D25053

Author: marshall Date: Fri Oct 7 18:19:04 2016 New Revision: 283621 URL: http://llvm.org/viewvc/llvm-project?rev=283621&view=rev Log: Disable alignment support of 0x4000 for Win32. https://reviews.llvm.org/D25053 Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/include/type

[PATCH] D25053: [libc++] Correct alignment condition

mclow.lists closed this revision. mclow.lists added a comment. Committed as revision 283621 https://reviews.llvm.org/D25053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24975: [CUDA] Add #pragma clang force_cuda_host_device_{begin, end} pragmas.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Please add a test to test/PCH for the serialization code. Otherwise, LGTM. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:1032 + "force_cuda_host_device end

[PATCH] D25249: [libc++] Many any test fixes

EricWF added a comment. Addressed the issues about `in_place` SFINAE constraints in an inline comment. Comment at: test/libcxx/utilities/any/any.class/any.assign/value.pass.cpp:25 +// Test that any& operator=(ValueType&&) is *never* selected for: +// * std::in_place type. +

[libcxx] r283620 - Fix PR30642 - libc++ leaks always-visible symbols into programs

Author: ericwf Date: Fri Oct 7 18:07:59 2016 New Revision: 283620 URL: http://llvm.org/viewvc/llvm-project?rev=283620&view=rev Log: Fix PR30642 - libc++ leaks always-visible symbols into programs This was caused by r281673, specifically changing `_LIBCPP_EXTERN_TEMPLATE_TYPE_VIS` from `__attri

Re: r283537 - Revert "[analyzer] Try to re-apply r283092 "Extend bug reports with extra notes"

Yep, should be fixed already. I had to split the commit into senseless parts because microsoft compiler was crashing and it wasn't obvious (to anybody who tried to look into this) which part of the commit might have caused that. Now the complete commit has finally landed. Sorry for the trouble

[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

mclow.lists added a comment. Sigh. Make an expedient choice that you don't really agree with, and you get immediately reminded of it. I suggested on an earlier review (not this patch) that I really didn't want to see `_WIN32` in any files other than ``, that we should have a libc++-specific o

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

hfinkel added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:198 + +Ctx.setDiagnosticsOutputFile(new yaml::Output(OptRecordFile->os())); + } anemet wrote: > Sorry, one more thing: if PGO is available, I think we want to set > Ctx.setDiag

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

anemet added inline comments. Comment at: lib/CodeGen/CodeGenAction.cpp:198 + +Ctx.setDiagnosticsOutputFile(new yaml::Output(OptRecordFile->os())); + } Sorry, one more thing: if PGO is available, I think we want to set Ctx.setDiagnosticHotnessReques

Re: [libcxx] r281673 - [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

This caused https://llvm.org/bugs/show_bug.cgi?id=30642 On Thu, Sep 15, 2016 at 6:27 PM, Eric Fiselier via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ericwf > Date: Thu Sep 15 17:27:07 2016 > New Revision: 281673 > > URL: http://llvm.org/viewvc/llvm-project?rev=281673&view=rev > L

[PATCH] D25225: Add an option to save the backend-produced YAML optimization record to a file

anemet added inline comments. Comment at: test/CodeGen/opt-record.c:17-25 +// CHECK: --- !Missed +// CHECK: Pass:inline +// CHECK: Name:NoDefinition +// CHECK: Function:foo + +// CHECK: --- !Passed +// CHECK: Pass:loop-vectorize ---

[PATCH] D25248: [libcxx] [test] Fix shadow warnings.

EricWF closed this revision. EricWF added a comment. r283618. https://reviews.llvm.org/D25248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r283618 - Fix shadow warnings. Patch from s...@microsoft.com

Author: ericwf Date: Fri Oct 7 17:10:35 2016 New Revision: 283618 URL: http://llvm.org/viewvc/llvm-project?rev=283618&view=rev Log: Fix shadow warnings. Patch from s...@microsoft.com Modified: libcxx/trunk/test/std/utilities/utility/forward/move.pass.cpp Modified: libcxx/trunk/test/std/util

[PATCH] D25154: [libc++] Fix stack_allocator

EricWF added a comment. In https://reviews.llvm.org/D25154#564980, @STL_MSFT wrote: > Seems plausible to me. I haven't tested this against MSVC yet, but at most I > expect to have minor issues with space consumption (as we allocate helper > objects and sentinel nodes, so any exactly-sized buffe

[PATCH] D25154: [libc++] Fix stack_allocator

STL_MSFT accepted this revision. STL_MSFT added a comment. This revision is now accepted and ready to land. Seems plausible to me. I haven't tested this against MSVC yet, but at most I expect to have minor issues with space consumption (as we allocate helper objects and sentinel nodes, so any ex

[PATCH] D25154: [libc++] Fix stack_allocator

EricWF updated this revision to Diff 73995. EricWF added a comment. Address @STL_MSFT's comments. https://reviews.llvm.org/D25154 Files: test/std/containers/container.adaptors/priority.queue/priqueue.cons/ctor_comp.pass.cpp test/std/containers/container.adaptors/priority.queue/priqueue.co

r283615 - Fix MSVC build: requires namespace in front of StringRef (NFC)

Author: mehdi_amini Date: Fri Oct 7 17:02:59 2016 New Revision: 283615 URL: http://llvm.org/viewvc/llvm-project?rev=283615&view=rev Log: Fix MSVC build: requires namespace in front of StringRef (NFC) Modified: cfe/trunk/lib/Driver/Action.cpp Modified: cfe/trunk/lib/Driver/Action.cpp URL: h

[PATCH] D25154: [libc++] Fix stack_allocator

EricWF added a comment. > Why does test_stack_allocator.pass.cpp line 11 have a commented-out path? Typically tests name the header they test in a comment. > Why is > test/std/containers/sequences/deque/deque.cons/size_value_alloc.pass.cpp > 84-85 gaining totally empty braces? Mass-translatio

r283616 - Rename variable to not use C++ reserved name (leading underscore + capital) (NFC)

Author: mehdi_amini Date: Fri Oct 7 17:03:03 2016 New Revision: 283616 URL: http://llvm.org/viewvc/llvm-project?rev=283616&view=rev Log: Rename variable to not use C++ reserved name (leading underscore + capital) (NFC) Modified: cfe/trunk/lib/Driver/Action.cpp Modified: cfe/trunk/lib/Drive

[PATCH] D22221: Decide whether to enable plugin tests based on cmake variables

reames resigned from this revision. reames removed a reviewer: reames. reames added a comment. I know very little about our cmake infrastructure. Repository: rL LLVM https://reviews.llvm.org/D1 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D25001: [Module] Merge function prototype with a non-prototype function declaration

rsmith added a comment. I'm concerned that name lookup will find an inappropriate declaration after this merging. If we have two visible declarations of a function in the same scope, and one has a prototype but the other does not, the user should be able to rely on the prototype being used. `is

[PATCH] D25248: [libcxx] [test] Fix shadow warnings.

STL_MSFT added a comment. Thanks Marshall. Can either you or Eric commit this? https://reviews.llvm.org/D25248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

EricWF added a comment. Why do you want to build `libc++.so` with hidden visibility? What's wrong with the existing way we build `libc++.so`? https://reviews.llvm.org/D25208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

r283611 - Driver: use StringRef instead of raw pointer in lookupTypeForExtension() (NFC)

Author: mehdi_amini Date: Fri Oct 7 16:41:00 2016 New Revision: 283611 URL: http://llvm.org/viewvc/llvm-project?rev=283611&view=rev Log: Driver: use StringRef instead of raw pointer in lookupTypeForExtension() (NFC) Modified: cfe/trunk/include/clang/Driver/ToolChain.h cfe/trunk/include/c

[PATCH] D25249: [libc++] Many any test fixes

EricWF added a comment. @CaseyCarter Thank you for the patch. I fixed most of your issues in r283606 {as well as a bunch of libc++ bugs). I'm still deciding what to do about the `in_place` SFINAE tests, but I'll follow up on that shortly. As for this patch please update it if there are any fix

r283605 - Turn ArchName/BoundArch in Driver from raw pointer to StringRef (NFC)

Author: mehdi_amini Date: Fri Oct 7 16:27:26 2016 New Revision: 283605 URL: http://llvm.org/viewvc/llvm-project?rev=283605&view=rev Log: Turn ArchName/BoundArch in Driver from raw pointer to StringRef (NFC) Modified: cfe/trunk/include/clang/Driver/Action.h cfe/trunk/include/clang/Driver/

[libcxx] r283606 - Fix various issues in std::any and the related tests.

Author: ericwf Date: Fri Oct 7 16:27:45 2016 New Revision: 283606 URL: http://llvm.org/viewvc/llvm-project?rev=283606&view=rev Log: Fix various issues in std::any and the related tests. * Fix self-swap. Patch from Casey Carter. * Remove workarounds and tests for types with deleted move construc

r283601 - Visually align table def with respective enum. NFC

Author: dougk Date: Fri Oct 7 16:02:38 2016 New Revision: 283601 URL: http://llvm.org/viewvc/llvm-project?rev=283601&view=rev Log: Visually align table def with respective enum. NFC 'warn_attribute_wrong_decl_type' has to stay in sync with 'enum AttributeDeclKind' which is much easier when they

Re: r283537 - Revert "[analyzer] Try to re-apply r283092 "Extend bug reports with extra notes"

On 10/07/16 05:56, Artem Dergachev via cfe-commits wrote: > Author: dergachev > Date: Fri Oct 7 05:56:44 2016 > New Revision: 283537 > > URL: http://llvm.org/viewvc/llvm-project?rev=283537&view=rev One of these recent changes introduced a problem in sanitizer testing. /home/seurer/llvm/build/l

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

mgorny requested a review of this revision. mgorny added a comment. I have updated the patch to include a feature check for platforms rejecting `-rtlib=libgcc` and split the test appropriately. Could you re-review, please? https://reviews.llvm.org/D25338 _

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

mgorny removed rL LLVM as the repository for this revision. mgorny updated this revision to Diff 73979. This revision is now accepted and ready to land. https://reviews.llvm.org/D25338 Files: docs/CommandGuide/clang.rst include/clang/Driver/Options.td lib/Driver/Driver.cpp test/Driver/pri

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

mgorny planned changes to this revision. mgorny added a comment. Reverted, I need to update it to run libgcc part of the test only on platforms supporting that. Repository: rL LLVM https://reviews.llvm.org/D25338 ___ cfe-commits mailing list cfe

r283586 - Revert r283572 - [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

Author: mgorny Date: Fri Oct 7 15:04:00 2016 New Revision: 283586 URL: http://llvm.org/viewvc/llvm-project?rev=283586&view=rev Log: Revert r283572 - [Driver] Make -print-libgcc-file-name print compiler-rt lib when used Revert the -print-libgcc-file-name change as the new test fails on Darwin. I

[PATCH] D25369: [clang-move] Better support enclosing class.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:27 +AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass, + ast_matchers::internal::Matcher, InnerMatcher) { ioeric wrote: > I'm not sure if we really need to limit this to the `o

[PATCH] D25369: [clang-move] Better support enclosing class.

hokein updated this revision to Diff 73976. hokein marked 2 inline comments as done. hokein added a comment. support moving static member of nested class when moving its enclosing class. https://reviews.llvm.org/D25369 Files: clang-move/ClangMove.cpp test/clang-move/Inputs/multiple_class_te

RE: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

Ok, I dug into this deeper. ASTContext.cpp:2811 (getVariableArrayDecayedType) intentionaly sets size to nullptr in this case for the purpose of turning it into a [*] type. OpenMP.cpp:236 (CodeGenFunction::GenerateOpenMPCapturedStmtFunction) calls this to replace variably modified type with th

r283584 - [analyzer] Re-apply r283092, attempt no.4, chunk no.4 (last)

Author: dergachev Date: Fri Oct 7 14:25:10 2016 New Revision: 283584 URL: http://llvm.org/viewvc/llvm-project?rev=283584&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, chunk no.4 (last) The problem that caused the msvc crash has been indentified and fixed in the previous commit. This p

r283583 - Silence Warning. NFC.

Author: niravd Date: Fri Oct 7 14:11:33 2016 New Revision: 283583 URL: http://llvm.org/viewvc/llvm-project?rev=283583&view=rev Log: Silence Warning. NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/CoreEngine.cpp URL: http://llvm.o

[PATCH] D25153: preprocessor supports `-dI` flag

elsteveogrande added a comment. Hi @rsmith -- now this simply reports the `#include` line (or whatever token) without fiddly path escaping. So this is simplified and there's less room for error and such. https://reviews.llvm.org/D25153 ___ cfe-co

[PATCH] D25141: [libcxx] [test] Remove MSVC workarounds

EricWF closed this revision. EricWF added a comment. r283580. https://reviews.llvm.org/D25141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r283580 - Remove MSVC workarounds. Patch from s...@microsoft.com

Author: ericwf Date: Fri Oct 7 13:51:33 2016 New Revision: 283580 URL: http://llvm.org/viewvc/llvm-project?rev=283580&view=rev Log: Remove MSVC workarounds. Patch from s...@microsoft.com Modified: libcxx/trunk/test/support/test_allocator.h Modified: libcxx/trunk/test/support/test_allocator.

RE: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

Added Alexey to the list, he’s the OMP Maintainer, so hopefully he knows better ☺ From: David Blaikie [mailto:dblai...@gmail.com] Sent: Friday, October 7, 2016 11:51 AM To: reviews+d25373+public+d8ec2a4bb41b1...@reviews.llvm.org; Keane, Erich ; cfe-commits@lists.llvm.org; david.majne...@gmail.co

RE: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

I cannot personally right now, though I will dig into OpenMP implementation to see how intentional that is. The size is seemingly determined by the OMP code generation as far as I can tell. From: David Blaikie [mailto:dblai...@gmail.com] Sent: Friday, October 7, 2016 11:51 AM To: reviews+d25373

Re: [PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

Could you explain how/why there's a null size expr? I would've thought it must have /some/ size for code generation purposes... On Fri, Oct 7, 2016 at 11:33 AM Erich Keane wrote: > erichkeane created this revision. > erichkeane added reviewers: cfe-commits, dblaikie, majnemer, gbenyei. > erichke

[PATCH] D25373: Fix for Bug 30639: CGDebugInfo Null dereference with OpenMP array access

erichkeane created this revision. erichkeane added reviewers: cfe-commits, dblaikie, majnemer, gbenyei. erichkeane set the repository for this revision to rL LLVM. OpenMP creates a variable array type with a a null size-expr. The Debug generation failed to properly consider this case. This patc

Re: r283554 - [analyzer] Don't merge different return nodes in ExplodedGraph

Hi Daniel, This revision introduced warnings on one our of builders: http://lab.llvm.org:8011/builders/clang-3stage-ubuntu/builds/4719 The warnings: /home/buildbot/Buildbot/Slave1a/clang-3stage-ubuntu/llvm.src/tools/clang/lib/StaticAnalyzer/Core/CoreEngine.cpp:316:59: warning: suggest parenthese

[PATCH] D25244: [clang-tidy] Add a whitelist option in google-runtime-references.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small nit. Comment at: clang-tidy/google/NonConstReferences.cpp:71-75 + for (const auto &WhiteListType: WhiteListTypes) { +if (ReferencedType.g

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

mgorny added a comment. It seems that my test doesn't work on Darwin, and I should exclude the libgcc part there. Do you happen to have any suggestion how to do that? I'm going to wait for other buildbots to finish to see if I haven't broken any other platform, then revert it and look for a pro

[PATCH] D24669: {Sema] Gcc compatibility of vector shift.

bruno added a reviewer: bruno. bruno added inline comments. Comment at: llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td:2306 + "vector operands do not have the same elements sizes (%0 and %1)">, + InGroup>, DefaultError; def err_ext_vector_component_exceeds_length

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

This revision was automatically updated to reflect the committed changes. Closed by commit rL283572: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used (authored by mgorny). Changed prior to commit: https://reviews.llvm.org/D25338?vs=73887&id=73953#toc Repository: rL LLVM

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

This revision was automatically updated to reflect the committed changes. Closed by commit rL283554: [analyzer] Don't merge different return nodes in ExplodedGraph (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D25326?vs=73926&id=73947#toc Repository: rL LLV

Re: [PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

On 10/07/16 08:39, Daniel Marjamäki via cfe-commits wrote: danielmarjamaki removed rL LLVM as the repository for this revision. danielmarjamaki updated this revision to Diff 73926. danielmarjamaki added a comment. Refactoring. https://reviews.llvm.org/D25326 Files: include/clang/Analysis/Pr

r283574 - [analyzer] Re-apply r283092, attempt no.4, chunk no.3, fixup 1.

Author: dergachev Date: Fri Oct 7 12:24:06 2016 New Revision: 283574 URL: http://llvm.org/viewvc/llvm-project?rev=283574&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, chunk no.3, fixup 1. Remove the brace default initializer to see if this is what's causing the msvc crash. Modified:

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

a.sidorin added inline comments. Comment at: test/Analysis/unreachable-code-path.c:201 +static int inlineFunction(const int i) { + if (table[i] != 0) +return 1; I have a small question. Is it possible to simplify this sample with removing of table[] array?

r283573 - [analyzer] Re-apply r283092, attempt no.4, chunk no.3.

Author: dergachev Date: Fri Oct 7 12:12:05 2016 New Revision: 283573 URL: http://llvm.org/viewvc/llvm-project?rev=283573&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, chunk no.3. This is the primary suspect for causing the msvc crash, now that vector of smart pointers was proven to be

r283572 - [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

Author: mgorny Date: Fri Oct 7 12:08:06 2016 New Revision: 283572 URL: http://llvm.org/viewvc/llvm-project?rev=283572&view=rev Log: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used Make the -print-libgcc-file-name option print an appropriate compiler runtime library, that is

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

NoQ added inline comments. Comment at: test/Analysis/unreachable-code-path.c:201 +static int inlineFunction(const int i) { + if (table[i] != 0) +return 1; a.sidorin wrote: > I have a small question. Is it possible to simplify this sample with removing > of

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

mgorny added a comment. Thanks for the review. https://reviews.llvm.org/D25338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

dcoughlin added a comment. Can you also add a test that tests this more directly (i.e., with clang_analyzer_warnIfReached). I don't think it is good to have the only test for this core coverage issue to be in tests for an alpha checker. Adding the direct test would also make it easier to track

[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

b-sumner added a comment. clang does not recognize convergent as a valid attribute. There was an attempt to add this, see https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg22271.html but it hasn't had any result. Matt do you see "real uses" for this now? https://reviews.llvm.org/D2

[PATCH] D25338: [Driver] Make -print-libgcc-file-name print compiler-rt lib when used

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D25338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

zaks.anna accepted this revision. zaks.anna added a comment. Please, fix the style issues before committing. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h:266 +ExplodedNode *Pred, +const ReturnSt

[PATCH] D25321: Fix PR13910: Don't warn that __builtin_unreachable() is unreachable

aprantl accepted this revision. aprantl added a reviewer: aprantl. aprantl added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rL LLVM https://reviews.llvm.org/D25321 ___ cfe-commits mailing list cfe-commit

r283568 - [analyzer] Re-apply r283092, attempt no.4, chunk no.2.

Author: dergachev Date: Fri Oct 7 10:55:18 2016 New Revision: 283568 URL: http://llvm.org/viewvc/llvm-project?rev=283568&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, chunk no.2. Define the list of pieces in BugReport class. This is half of the changes in the BugReport class code, whi

r283566 - [analyzer] Re-apply r283092, attempt no.4, a small chunk.

Author: dergachev Date: Fri Oct 7 10:23:02 2016 New Revision: 283566 URL: http://llvm.org/viewvc/llvm-project?rev=283566&view=rev Log: [analyzer] Re-apply r283092, attempt no.4, a small chunk. Define PathDiagnosticNotePiece. The next commit would be able to address the BugReport class code that

r283564 - Update clang test to accomendate discriminator change in https://reviews.llvm.org/D25132

Author: dehao Date: Fri Oct 7 10:21:29 2016 New Revision: 283564 URL: http://llvm.org/viewvc/llvm-project?rev=283564&view=rev Log: Update clang test to accomendate discriminator change in https://reviews.llvm.org/D25132 Summary: https://reviews.llvm.org/D25132 added discriminator even add -g0.

[PATCH] D20428: Tracking exception specification source locations

sbarzowski added a comment. What's happening here? It's accepted, but not merged and the last activity is 3 months old while my change is waiting for it. Can I help somehow? https://reviews.llvm.org/D20428 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D25343: [OpenCL] Mark group functions as noduplicate in opencl-c.h

yaxunl added a comment. In https://reviews.llvm.org/D25343#564092, @arsenm wrote: > These should be convergent instead Unfortunately convergent is not supported as Clang attribute. There was patch to add it but the author withdrew it. Anastasia/Alexey, Do you think it is a good idea to add _

r283554 - [analyzer] Don't merge different return nodes in ExplodedGraph

Author: danielmarjamaki Date: Fri Oct 7 09:21:08 2016 New Revision: 283554 URL: http://llvm.org/viewvc/llvm-project?rev=283554&view=rev Log: [analyzer] Don't merge different return nodes in ExplodedGraph Returns when calling an inline function should not be merged in the ExplodedGraph unless th

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yay, this is great. Thanks for investigating all those loss of coverage issues! Comment at: lib/StaticAnalyzer/Core/CoreEngine.cpp:610 // Use the callee location context. - Cal

[PATCH] D25369: [clang-move] Better support enclosing class.

ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:27 +AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass, + ast_matchers::internal::Matcher, InnerMatcher) { I'm not sure if we really need to limit this to the `outer-most` class

Re: [clang-tools-extra] r283534 - Fix buildbot error.

On 7 October 2016 at 13:06, Renato Golin wrote: > On 7 October 2016 at 10:23, Haojian Wu via cfe-commits > wrote: >> Author: hokein >> Date: Fri Oct 7 04:23:28 2016 >> New Revision: 283534 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=283534&view=rev >> Log: >> Fix buildbot error. >> >> The

[clang-tools-extra] r283553 - Revert "[clang-move] Support moving multiple classes in one run."

Author: rengolin Date: Fri Oct 7 08:58:10 2016 New Revision: 283553 URL: http://llvm.org/viewvc/llvm-project?rev=283553&view=rev Log: Revert "[clang-move] Support moving multiple classes in one run." This reverts commit r283526 et al as it keeps randomly breaking bots, even after the commit has

[PATCH] D25244: [clang-tidy] Add a whitelist option in google-runtime-references.

hokein added a comment. friendly ping. Aaron, could you take a look on this patch? https://reviews.llvm.org/D25244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25369: [clang-move] Better support enclosing class.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. - When moving an outermost enclosing class, all its nested classes should also be moved together. - Add a test for not moving nested class. https://reviews.llvm.org/D25369 Files: clang-move

[PATCH] D25326: [StaticAnalyser] Don't merge different returns in ExplodedGraph

danielmarjamaki removed rL LLVM as the repository for this revision. danielmarjamaki updated this revision to Diff 73926. danielmarjamaki added a comment. Refactoring. https://reviews.llvm.org/D25326 Files: include/clang/Analysis/ProgramPoint.h include/clang/StaticAnalyzer/Core/PathSensitiv

r283549 - Wdocumentation fix

Author: rksimon Date: Fri Oct 7 08:25:41 2016 New Revision: 283549 URL: http://llvm.org/viewvc/llvm-project?rev=283549&view=rev Log: Wdocumentation fix Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL: http://llvm.org/viewvc/llvm-project/cfe/t

[clang-tools-extra] r283545 - [clang-move] Simplify lint tests

Author: hokein Date: Fri Oct 7 07:35:37 2016 New Revision: 283545 URL: http://llvm.org/viewvc/llvm-project?rev=283545&view=rev Log: [clang-move] Simplify lint tests No need to use compilation database. Removed: clang-tools-extra/trunk/test/clang-move/Inputs/database_template.json Modified:

r283543 - [ARM]: Add Cortex-R52 target

Author: javed.absar Date: Fri Oct 7 07:08:41 2016 New Revision: 283543 URL: http://llvm.org/viewvc/llvm-project?rev=283543&view=rev Log: [ARM]: Add Cortex-R52 target This patch adds Cortex-R52, the new ARM real-time processor. Cortex-R52 implements the ARMv8-R architecture. Modified: cfe/t

Re: [clang-tools-extra] r283534 - Fix buildbot error.

On 7 October 2016 at 10:23, Haojian Wu via cfe-commits wrote: > Author: hokein > Date: Fri Oct 7 04:23:28 2016 > New Revision: 283534 > > URL: http://llvm.org/viewvc/llvm-project?rev=283534&view=rev > Log: > Fix buildbot error. > > The error maybe caused by the mixed environment of the two lint t

  1   2   >