mclow.lists added a comment. Sigh. Make an expedient choice that you don't really agree with, and you get immediately reminded of it. I suggested on an earlier review (not this patch) that I really didn't want to see `_WIN32` in any files other than `<config>`, that we should have a libc++-specific one. I let that slide because we had a couple other instances of `_WIN32` in the source base.
About three days later, this pops up. :-( Not your fault, but it makes me sad. https://reviews.llvm.org/D25145 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits