dberris requested changes to this revision.
dberris added a comment.
This revision now requires changes to proceed.
Are we sure this will not fail on Windows? i.e. have you built/run the tests on
Windws ARM or X86_64?
> Tools.cpp:4787
> options::OPT_fnoxray_instrument, fals
Author: phosek
Date: Thu Oct 6 01:08:09 2016
New Revision: 283420
URL: http://llvm.org/viewvc/llvm-project?rev=283420&view=rev
Log:
[Driver] Add driver support for Fuchsia
Provide toolchain and tool support for Fuchsia operating system.
Fuchsia uses compiler-rt as the runtime library and libc++,
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
> add_new_check.py:58
> +f.write(b'//===--- ')
> +f.write((os.path.basename(filename)).encode())
> +f.write(b' - clang-tidy')
Too many parentheses.
> add_new_check
ahatanak added inline comments.
> TargetInfo.cpp:430
>if (AN == Name && ARN.RegNum < Names.size())
> -return Name;
> +if (ReturnCanonical)
> + return Names[ARN.RegNum];
Please use braces or a ternary operator here.
> ahatanak wrote in Targets.cpp:2718
> Can we s
Author: mehdi_amini
Date: Thu Oct 6 00:11:48 2016
New Revision: 283417
URL: http://llvm.org/viewvc/llvm-project?rev=283417&view=rev
Log:
Taking StringRef in Driver.h APIs instead of raw pointers (NFC)
Modified:
cfe/trunk/include/clang/Driver/Driver.h
cfe/trunk/lib/Driver/Driver.cpp
Modi
Author: mehdi_amini
Date: Wed Oct 5 23:26:16 2016
New Revision: 283416
URL: http://llvm.org/viewvc/llvm-project?rev=283416&view=rev
Log:
Use llvm::raw_string_ostream instead of std::stringstream (NFC)
As a side effect, this avoid having to call .data() on the StringRef.
Modified:
cfe/trunk/
elsteveogrande updated this revision to Diff 73720.
elsteveogrande marked an inline comment as done.
elsteveogrande added a comment.
Using `consume_front(sequence)`, cleaner escaping code.
https://reviews.llvm.org/D25153
Files:
include/clang/Driver/Options.td
include/clang/Frontend/Preproce
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
elsteveogrande marked an inline comment as done.
elsteveogrande added inline comments.
> majnemer wrote in PrintPreprocessedOutput.cpp:331-349
> I think this loop would be easier to understand like so:
>
> while (!Path.empty()) {
> if (Path.consume_front("\\")) {
> Buffer.push_back("
erichkeane updated this revision to Diff 73716.
erichkeane marked 6 inline comments as done.
erichkeane added a comment.
Updated tests to properly show mangling for C++ types. Required some fixes.
Note that the decorating of names doesn't match ICC in non-named functions due
to a bug in ICC, a
EricWF updated this revision to Diff 73715.
EricWF added a comment.
- Address @majnemer's comment about using `auto`.
https://reviews.llvm.org/D25292
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Index: test/SemaCXX/coroutines.cp
mshockwave added a comment.
> From this picture I don't see how the flattening itself can help us to avoid
> using global memory. Surely in both cases the captures content will have to
> be copied into the memory accessible for the enqueued kernel (which is a
> global memory in a general case,
majnemer added inline comments.
> SemaCoroutine.cpp:140
> + // or the function 'main' are declared as a coroutine.
> + CXXMethodDecl *MD = dyn_cast(FD);
> + if (MD && isa(MD))
`auto *`
https://reviews.llvm.org/D25292
___
cfe-commits mailing list
beanz added a comment.
This is actually not the right fix here. We should actually fix this in LLVM to
setup the rpath correctly on the targets during llvm_add_executable, then we
can remove this hack from LLVM instead of copying it to Clang. It might also
let us fix the RPATH goop in other too
On Wed, Oct 5, 2016 at 7:40 PM, Galina Kistanova via cfe-commits
wrote:
> Hello everyone,
>
> Below are some buildbot numbers for the last week of 9/25/2016 - 10/1/2016.
>
> Please see the same data in attached csv files:
Can we please fix the clang-tools-sphinx-docs builder or take it
offline en
Hello everyone,
Below are some buildbot numbers for the last week of 9/25/2016 - 10/1/2016.
Please see the same data in attached csv files:
The longest time each builder was red during the last week;
"Status change ratio" by active builder (percent of builds that changed the
builder status from
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
Previously the statement `co_return {42}` would be transformed into
`P.return_void()`, since the type of `{42}` is represented as `void` by Cl
Eugene.Zelenko added a comment.
This revision now requires review to proceed.
Looks like patch was not committed.
https://reviews.llvm.org/D390
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
EricWF updated this revision to Diff 73704.
EricWF added a comment.
Diagnose a coroutine `main` function in the same way as other invalid contexts.
https://reviews.llvm.org/D25292
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaCoroutine.cpp
test/SemaCXX/coroutines.cpp
Ind
Author: ericwf
Date: Wed Oct 5 17:55:10 2016
New Revision: 283408
URL: http://llvm.org/viewvc/llvm-project?rev=283408&view=rev
Log:
Fix strict-aliasing violation in typeinfo::hash_code()
Summary:
The current implementation of `hash_code()` for uniqued RTTI strings violates
strict aliasing by de
majnemer added inline comments.
> PrintPreprocessedOutput.cpp:331-349
> + const size_t N = Path.size();
> + size_t I = 0;
> + while (I < N) {
> +if (Path[I] == '\\' || Path[I] == '\"') {
> + // Have to escape backslashes or double-quotes.
> + // Send out backslash to escape the n
Author: rsmith
Date: Wed Oct 5 17:41:02 2016
New Revision: 283406
URL: http://llvm.org/viewvc/llvm-project?rev=283406&view=rev
Log:
PR22924, PR22845, some of CWG1464: When checking the initializer for an array
new expression, distinguish between the case of a constant and non-constant
initializer
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D24012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
hfinkel added a comment.
@rsmith @rjmccall - I chatted with @anemet about this on IRC, and he's happy
with it. Please look this over, in part to make sure you're happy with the
option name.
On the name, two of my thoughts behind using -fsave-optimization-record were:
1) I did not want to call
EricWF added a comment.
In https://reviews.llvm.org/D24562#562339, @rmaprath wrote:
> First batch of XFAIL fixes.
>
> I've changed some XFAILs to UNSUPPORTED where the test is all about exception
> handling. In other cases, I've used the test macro TEST_HAS_NO_EXCEPTIONS to
> conditionally excl
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL177633.
https://reviews.llvm.org/D545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
EricWF created this revision.
EricWF added reviewers: rsmith, GorNishanov.
EricWF added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
The title says it all. Additionally this patch refactors the diagnostic code
into a separate function.
https://reviews.llvm.org/D25292
File
rnk added inline comments.
> avx512-mask-op-inline_asm_specific.c:1
> +// RUN: %clang_cc1 %s -target-cpu skylake-avx512 -O0 -S -o - -Wall -Werror
> | FileCheck %s
> +// This test checks validity of inline assembly for avx512 supported
> constraint k and Yk along with the required
Please chec
rnk added a comment.
Looks good functionally with some surface level nits
> X86ISelLowering.cpp:31979
>break;
> }
>}
Let's check size 2 after size 1, it seems more logical, and is 1 is probably
the common case.
> X86ISelLowering.cpp:32025
>case 'Y':
> +// Impliment Y
majnemer added inline comments.
> agutowski wrote in CGBuiltin.cpp:2665
> Is this line needed? I took it from __builtin_fpclassify, but I don't know
> what could be its purpose (it's repeated below, where the "bitscan_end" block
> really starts).
It's needed for the call to CreatePHI to be in
rsmmr added a comment.
Well, last time I counted it was more like 100 contributors---Bro existed
before GitHub (and before git). The style-guide is lacking, yes ... what can I
say.
I don't really want to argue about importance of the project. We would like to
use clang-format here and elsewher
rsmith added a comment.
This looks like it's going in the right direction.
> Decl.cpp:2269-2272
> + // If we have hit a point where the user provided a specialization of
> + // this template, we're done looking.
> + if (VarTemplate->isMemberSpecialization())
> +break;
I
djasper added a comment.
It's not about whether or not we like the patch. It's whether adding these
options is a good trade-off for clang-format overall. If we find that actually
more people would find these styles desirable, we can reconsider.
I have left some comments anyway in case you want
rnk added a comment.
You should use git-clang-format or some equivalent to format your change.
> TargetInfo.h:597
> + StringRef getNormalizedGCCRegisterName(StringRef Name,
> +bool ReturnCanonical = false) const;
>
format
> TargetInfo.h:600
> + virtual StringRef getConstraintRegister(
vsk abandoned this revision.
vsk added a comment.
I no longer need this functionality.
https://reviews.llvm.org/D25047
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Eugene.Zelenko added a comment.
This revision now requires review to proceed.
Committed in https://reviews.llvm.org/rL184471 and
https://reviews.llvm.org/rL184472.
https://reviews.llvm.org/D834
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
djasper added a comment.
Sorry, but that's actually not enough, at least at first sight. With 37
contributors total, bro is still quite small and only 12 of them have more than
a handful of commits. And it doesn't have a real style guide. It has:
https://www.bro.org/development/contribute.html#
v.g.vassilev updated this revision to Diff 73688.
v.g.vassilev added a comment.
Address some comments and publish current progress.
https://reviews.llvm.org/D24508
Files:
include/clang/AST/Decl.h
lib/AST/Decl.cpp
lib/Sema/SemaTemplate.cpp
lib/Sema/SemaTemplateInstantiateDecl.cpp
lib/S
rsmmr added a comment.
Sure, I'm aiming to use clang-format on a couple of open-source code bases
using this style, with the main one being the Bro network security monitor, see
www.bro.org and github.com/bro/bro (note the stars and forks :-) Bro is also
featured on GitHub's list of security sh
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL187762.
https://reviews.llvm.org/D1067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL186727.
https://reviews.llvm.org/D1147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
agutowski added inline comments.
> CGBuiltin.cpp:2665
> +BasicBlock *End = createBasicBlock("bitscan_end", this->CurFn);
> +Builder.SetInsertPoint(End);
> +PHINode *Result = Builder.CreatePHI(ResultType, 2, "bitscan_result");
Is this line needed? I took it from __builtin_fpclassify,
Eugene.Zelenko closed this revision.
Eugene.Zelenko added a comment.
Committed in https://reviews.llvm.org/rL188409.
https://reviews.llvm.org/D1391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
agutowski updated this revision to Diff 73685.
agutowski added a comment.
make _BitScan intrinsics compatible with Intel specification when the mask is
zero
https://reviews.llvm.org/D25264
Files:
include/clang/Basic/BuiltinsARM.def
include/clang/Basic/BuiltinsX86.def
include/clang/Basic/
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
https://reviews.llvm.org/D25282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Committed revision 283363.
On Wed, Oct 5, 2016 at 9:18 PM, Nemanja Ivanovic
wrote:
> OK, will remove optimization and the selects and commit this now.
> Sorry about the delay.
>
> On Wed, Oct 5, 2016 at 9:16 PM, Sanjay Patel
> wrote:
>
>> You should not need to account for any nsw/nuw flags if
Author: nemanjai
Date: Wed Oct 5 14:11:36 2016
New Revision: 283363
URL: http://llvm.org/viewvc/llvm-project?rev=283363&view=rev
Log:
Removing optimization from the RUN lines and adjusting the checks
to not rely on optimization.
Modified:
cfe/trunk/test/CodeGen/builtins-ppc-p9vector.c
Modif
OK, will remove optimization and the selects and commit this now.
Sorry about the delay.
On Wed, Oct 5, 2016 at 9:16 PM, Sanjay Patel wrote:
> You should not need to account for any nsw/nuw flags if the clang test
> does not enable the optimizer.
> Ie, D24955 should not be running at -O0.
>
> On
You should not need to account for any nsw/nuw flags if the clang test does
not enable the optimizer.
Ie, D24955 should not be running at -O0.
On Wed, Oct 5, 2016 at 1:09 PM, Nemanja Ivanovic
wrote:
> OK, I get testing that I'm fine with if I remove the -O2 and the checks
> for 'select i1'.
>
>
OK, I get testing that I'm fine with if I remove the -O2 and the checks for
'select i1'.
Does that change suffice for the purposes of https://reviews.llvm.org/D24955
?
Namely, do I need to account for the possible addition of nsw/nuw flags to
the add instructions even without -O2?
On Wed, Oct 5,
Author: marshall
Date: Wed Oct 5 13:47:18 2016
New Revision: 283360
URL: http://llvm.org/viewvc/llvm-project?rev=283360&view=rev
Log:
Comment out failing test while I figure out who is at fault
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_empty.pass.cpp
Modi
Author: marshall
Date: Wed Oct 5 13:36:24 2016
New Revision: 283356
URL: http://llvm.org/viewvc/llvm-project?rev=283356&view=rev
Log:
Mark LWG#2679 as complete
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm
sepavloff added a comment.
IIUC, the problem is observed because `Sema::getTemplateInstantiationArgs` does
not handle the case of variable templates properly. Classes and functions are
declaration contexts and implementation of the aforementioned function (and
probably others) relies on this fa
spatel added a comment.
In https://reviews.llvm.org/D24397#562469, @bjope wrote:
> (I'm still hesitating about commiting https://reviews.llvm.org/D24955 in llvm
> since that would make these clang tests fail...)
You can't do that. Bots will send you fail mail all day as they choke on the
clan
majnemer added inline comments.
> agutowski wrote in CGBuiltin.cpp:2656-2684
> MSDN doesn't specify what should be put under the "Index" address when the
> argument is zero; as I checked, VS2015 with optimizations puts undefined
> value there, and I hope that's what I'm doing here.
Intel (http
rSerge updated this revision to Diff 73673.
https://reviews.llvm.org/D24799
Files:
lib/Driver/Tools.cpp
test/Driver/xray-instrument.c
Index: test/Driver/xray-instrument.c
===
--- test/Driver/xray-instrument.c
+++ test/Driver/xr
rSerge added a comment.
In https://reviews.llvm.org/D24799#561879, @dberris wrote:
> In https://reviews.llvm.org/D24799#561106, @rSerge wrote:
>
> > My mistake was that initially I only enumerated the unsupported targets
> > from llvm\include\llvm\ADT\Triple.h . Now I've added also the cases fro
bjope added a comment.
What is the progress about getting rid of these code generation checks?
(I'm still hesitating about commiting https://reviews.llvm.org/D24955 in llvm
since that would make these clang tests fail...)
Repository:
rL LLVM
https://reviews.llvm.org/D24397
__
DmitryPolukhin accepted this revision.
DmitryPolukhin added a comment.
This revision is now accepted and ready to land.
I think we need to fix this regression.
Repository:
rL LLVM
https://reviews.llvm.org/D24932
___
cfe-commits mailing list
cfe-c
agutowski added inline comments.
> rnk wrote in CodeGenFunction.h:2964
> Does this work on Linux? I thought you had to give it an explicit underlying
> type (enum class MSVCIntrin : unsigned;) to make that work.
Yes, it seems to work on Linux too. According to the cppreference.com, it
"declare
rnk added inline comments.
> CodeGenFunction.h:2964
> +private:
> + enum class MSVCIntrin;
> +
Does this work on Linux? I thought you had to give it an explicit underlying
type (enum class MSVCIntrin : unsigned;) to make that work.
https://reviews.llvm.org/D25264
__
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, thank you!
Repository:
rL LLVM
https://reviews.llvm.org/D25273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
agutowski updated this revision to Diff 73668.
agutowski added a comment.
change enum in MSVC namespace to enum class MSVCIntrin in CodeGenFunction;
cover all control paths
https://reviews.llvm.org/D25264
Files:
include/clang/Basic/BuiltinsARM.def
include/clang/Basic/BuiltinsX86.def
incl
Author: hokein
Date: Wed Oct 5 12:00:40 2016
New Revision: 283338
URL: http://llvm.org/viewvc/llvm-project?rev=283338&view=rev
Log:
[change-namespace] Pass Style to ChangeNamespaceTool.
Modified:
clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp
Modified: clang-tools-ex
rnk accepted this revision.
rnk added a reviewer: rnk.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm, thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D25273
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: marshall
Date: Wed Oct 5 12:02:43 2016
New Revision: 283341
URL: http://llvm.org/viewvc/llvm-project?rev=283341&view=rev
Log:
Mark LWG#2358 as done
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http://llvm.org/viewvc/llvm-pro
Author: marshall
Date: Wed Oct 5 12:01:16 2016
New Revision: 283339
URL: http://llvm.org/viewvc/llvm-project?rev=283339&view=rev
Log:
Make tests for is_empty better. No functional change.
Modified:
libcxx/trunk/test/std/utilities/meta/meta.unary/meta.unary.prop/is_empty.pass.cpp
Modified:
erik.pilkington created this revision.
erik.pilkington added a reviewer: manmanren.
erik.pilkington added a subscriber: cfe-commits.
Note: this patch depends on: https://reviews.llvm.org/D25283
This patch delays handling of `AR_NotYetIntroduced` diagnostics, so that the
following compiles with n
erik.pilkington created this revision.
erik.pilkington added a reviewer: manmanren.
erik.pilkington added a subscriber: cfe-commits.
This patch removes some redundant functions that implement checking
availability against context, and implements a new, more correct one:
`ShouldDiagnoseAvailabili
rmaprath updated this revision to Diff 73661.
rmaprath added a comment.
First batch of XFAIL fixes.
I've changed some XFAILs to UNSUPPORTED where the test is all about exception
handling. In other cases, I've used the test macro TEST_HAS_NO_EXCEPTIONS to
conditionally exclude those parts that t
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
cleanup the remaining empty namespace after moving out the
class defintitions.
https://reviews.llvm.org/D25282
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/Clan
agutowski added inline comments.
> majnemer wrote in CGBuiltin.cpp:2640-2647
> This should be in an anonymous namespace. Also, consider using an `enum
> class` instead of an `enum` nested inside a namespace.
I can see three options:
(1) put the existing code inside an anonymous namespace;
(2)
rnk added a comment.
Nice, probably ready to land with one revision.
> majnemer wrote in CGBuiltin.cpp:2640-2647
> This should be in an anonymous namespace. Also, consider using an `enum
> class` instead of an `enum` nested inside a namespace.
Let's also use a more specific name than MSVC, ma
Can you expand on how you plan to add the second set of reference outputs?
I plan to {either re-target or replace with normal files} the new symlinks in upcoming patches.
The patch proposal to which you referred in the above is just "stage 1" of a large clean-up.
We [Sebastian and I] have CMa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL28: [change-namespace] Fixed a bug in
getShortestQualifiedNameInNamespace. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25065?vs=73459&id=73653#toc
Repository:
rL LLVM
agutowski added inline comments.
> majnemer wrote in CGBuiltin.cpp:2656-2684
> Does this do the right thing if the arg is zero? I think it would if you
> gave the call to the intrinsic an operand of false instead of true.
MSDN doesn't specify what should be put under the "Index" address when t
Author: ioeric
Date: Wed Oct 5 10:52:39 2016
New Revision: 28
URL: http://llvm.org/viewvc/llvm-project?rev=28&view=rev
Log:
[change-namespace] Fixed a bug in getShortestQualifiedNameInNamespace.
Reviewers: hokein
Subscribers: cfe-commits
Differential Revision: https://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283332: Make DeletedLines local variables in
checkEmptyNamespace. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25162?vs=73641&id=73652#toc
Repository:
rL LLVM
https://rev
Author: ioeric
Date: Wed Oct 5 10:49:01 2016
New Revision: 283332
URL: http://llvm.org/viewvc/llvm-project?rev=283332&view=rev
Log:
Make DeletedLines local variables in checkEmptyNamespace.
Summary: Patch by Sam McCall!
Reviewers: djasper
Subscribers: klimek, cfe-commits
Differential Revision
Author: marshall
Date: Wed Oct 5 10:47:13 2016
New Revision: 283331
URL: http://llvm.org/viewvc/llvm-project?rev=283331&view=rev
Log:
Add another append test for basic_string
Modified:
libcxx/trunk/test/std/strings/basic.string/string.modifiers/string_append/T_size_size.pass.cpp
Modified:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283330: [clang-format] append newline after code when
inserting new headers at the end… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D21026?vs=73648&id=73651#toc
Repository:
Author: ioeric
Date: Wed Oct 5 10:42:19 2016
New Revision: 283330
URL: http://llvm.org/viewvc/llvm-project?rev=283330&view=rev
Log:
[clang-format] append newline after code when inserting new headers at the end
of the code which does not end with newline.
Summary:
append newline after code when
erichkeane marked 9 inline comments as done.
erichkeane added inline comments.
> oren_ben_simhon wrote in AttrDocs.td:1267
> You might want to use the following link instead because it is most updated:
> https://software.intel.com/en-us/node/693069
This has changed 2x since I started this proje
echristo added a comment.
In https://reviews.llvm.org/D24644#562286, @mehdi_amini wrote:
> What about function attributes? Hey that's the trend :)
> You could have a subset of the functions in their own sections but not all.
> With LTO it means that you can disable this for a single input file.
Author: marshall
Date: Wed Oct 5 10:21:11 2016
New Revision: 283325
URL: http://llvm.org/viewvc/llvm-project?rev=283325&view=rev
Log:
Mark LWG issues 2221, 2556 and 2589 as complete
Modified:
libcxx/trunk/www/upcoming_meeting.html
Modified: libcxx/trunk/www/upcoming_meeting.html
URL:
http:
mehdi_amini added a comment.
What about function attributes? Hey that's the trend :)
You could have a subset of the functions in their own sections but not all.
With LTO it means that you can disable this for a single input file.
https://reviews.llvm.org/D24644
__
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D25162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
echristo added a comment.
There are two things pushing and pulling here:
a) You want to be able to pass compiler code generation options at the time
we're actually doing the code generation,
b) "Traditionally" we don't pass CFLAGS to the linker.
I think I'd like to see us passing more options d
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D21026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ioeric updated this revision to Diff 73648.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Merged with origin/master.
- Update newline insertion according to the new Replacements implementation.
https://reviews.llvm.org/D21026
Files:
lib/Format/Format.cpp
unittests/Forma
ioeric added a comment.
Sorry for the delay
I've updated the patch to work with the new tooling::Replacements.
https://reviews.llvm.org/D21026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
vbyakovlcl added inline comments.
> ahatanak wrote in SemaExpr.cpp:8787
> Is it possible to use ASTContext::getTypeSize here?
You are right.
https://reviews.llvm.org/D24669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
vbyakovlcl updated this revision to Diff 73642.
https://reviews.llvm.org/D24669
Files:
llvm/tools/clang/include/clang/Basic/DiagnosticSemaKinds.td
llvm/tools/clang/lib/Sema/SemaExpr.cpp
llvm/tools/clang/test/CodeGen/vecshift.c
llvm/tools/clang/test/Sema/vecshift.c
Index: llvm/tools/clan
mclow.lists added a comment.
Adding a reference here: https://llvm.org/bugs/show_bug.cgi?id=30613
https://reviews.llvm.org/D24012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists added inline comments.
> cxa_personality.cpp:363
> + "Unexpected TTypeEncoding");
> (void)ttypeEncoding;
>
It's not clear to me how this accomplishes what you want.
You're looking for `00/10/90`, right? Why not just check for that?
Why are you anding with 0x0f ?
Be
ioeric updated this revision to Diff 73641.
ioeric added a comment.
- Added a test case.
https://reviews.llvm.org/D25162
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
==
ABataev added inline comments.
> Type.h:1381
> /// regparm and the calling convention.
> -unsigned ExtInfo : 9;
> +unsigned ExtInfo : 10;
>
Erich, do you really need this? You don't increase number of required bits
anymore, so this code must be restored
> Type.h:2909-2921
> +
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D25252
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
danielmarjamaki added inline comments.
> MisleadingIndentationCheck.cpp:20
> +
> +void MisleadingIndentationCheck::danglingElseCheck(
> +const MatchFinder::MatchResult &Result) {
There is no handling of tabs and spaces by danglingElseCheck as far as I see.
The "if" might for example be inde
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283314: [Clang][AVX512][BuiltIn]Adding missing intrinsics
move_{sd|ss} to clang (authored by mzuckerm).
Changed prior to commit:
https://reviews.llvm.org/D21021?vs=59720&id=73638#toc
Repository:
rL L
1 - 100 of 129 matches
Mail list logo
