OK, I get testing that I'm fine with if I remove the -O2 and the checks for 'select i1'.
Does that change suffice for the purposes of https://reviews.llvm.org/D24955 ? Namely, do I need to account for the possible addition of nsw/nuw flags to the add instructions even without -O2? On Wed, Oct 5, 2016 at 8:24 PM, Sanjay Patel <spa...@rotateright.com> wrote: > spatel added a comment. > > In https://reviews.llvm.org/D24397#562469, @bjope wrote: > > > (I'm still hesitating about commiting https://reviews.llvm.org/D24955 > in llvm since that would make these clang tests fail...) > > > You can't do that. Bots will send you fail mail all day as they choke on > the clang tests - speaking from experience. :) > We either need to fix or revert this commit in order to let > https://reviews.llvm.org/D24955 proceed. > > > Repository: > rL LLVM > > https://reviews.llvm.org/D24397 > > > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
