kevgs added a comment.
I have no commit rights.
https://reviews.llvm.org/D23329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kevgs updated this revision to Diff 67955.
kevgs added a comment.
clang-formatted + dead code removed
https://reviews.llvm.org/D23329
Files:
include/clang/AST/AttrIterator.h
Index: include/clang/AST/AttrIterator.h
===
--- includ
rnk added a comment.
Sorry for the delay, was trying to stay focused on debugging
Comment at: clang/include/clang/AST/Decl.h:1647
@@ +1646,3 @@
+ /// clears this list) needs to be a logically-const operation.
+ mutable std::unique_ptr> DeferredDiags;
+
Decl me
Eugene.Zelenko abandoned this revision.
Eugene.Zelenko added a comment.
Committed as fix for build failure after llvm/ADT/DenseMap.h in r278583.
Repository:
rL LLVM
https://reviews.llvm.org/D22555
___
cfe-commits mailing list
cfe-commits@lists.ll
Author: eugenezelenko
Date: Fri Aug 12 20:05:35 2016
New Revision: 278586
URL: http://llvm.org/viewvc/llvm-project?rev=278586&view=rev
Log:
Fix build broken after llvm/ADT/DenseMap.h replacement of climits with limits.
Modified:
cfe/trunk/lib/Basic/FileManager.cpp
Modified: cfe/trunk/lib/Bas
zturner created this revision.
zturner added a reviewer: alexfh.
zturner added a subscriber: cfe-commits.
In order to get this to work, the positional arguments must use
`--driver-mode=cl `, and NOT `clang-cl `. In the latter case,
clang-tidy has to try really hard to "guess" whether the first
CC hans.
> On Aug 12, 2016, at 5:50 PM, Duncan P. N. Exon Smith
> wrote:
>
> This seems like a good candidate to cherry-pick to 3.9.
>
>> On 2016-Aug-12, at 17:02, Mehdi Amini via cfe-commits
>> wrote:
>>
>> Author: mehdi_amini
>> Date: Fri Aug 12 19:02:33 2016
>> New Revision: 278
zturner updated this revision to Diff 67947.
zturner added a comment.
After much head banging I think I finally figured this out. I'm putting this
back to my original revision, unchanged. The problem is not the original
patch. The original patch is perfectly fine. The problem is the way i wa
This seems like a good candidate to cherry-pick to 3.9.
> On 2016-Aug-12, at 17:02, Mehdi Amini via cfe-commits
> wrote:
>
> Author: mehdi_amini
> Date: Fri Aug 12 19:02:33 2016
> New Revision: 278579
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278579&view=rev
> Log:
> Fix ASAN failures i
On Fri, Aug 12, 2016 at 5:26 PM, Mehdi Amini wrote:
> This fixes all the crashers on Darwin (clang+libc++), that I could
> reproduce with ASAN+libFuzzer.
> It does not mean that there is no leaks, or that you won’t find more
> crashes with libstdc++ for instance.
>
Yea... On linux I hit a leak r
This fixes all the crashers on Darwin (clang+libc++), that I could reproduce
with ASAN+libFuzzer.
It does not mean that there is no leaks, or that you won’t find more crashes
with libstdc++ for instance.
—
Mehdi
> On Aug 12, 2016, at 5:21 PM, Kostya Serebryany wrote:
>
> Sweet!
> Did you fi
Sweet!
Did you fix all of the known crashers?
On Fri, Aug 12, 2016 at 5:02 PM, Mehdi Amini via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: mehdi_amini
> Date: Fri Aug 12 19:02:33 2016
> New Revision: 278579
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278579&view=rev
> Log:
>
majnemer added a subscriber: majnemer.
majnemer accepted this revision.
majnemer added a reviewer: majnemer.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: include/clang/AST/AttrIterator.h:42
@@ -41,3 +41,3 @@
/// AttrVec - A vector
Author: mehdi_amini
Date: Fri Aug 12 19:02:33 2016
New Revision: 278579
URL: http://llvm.org/viewvc/llvm-project?rev=278579&view=rev
Log:
Fix ASAN failures in the demangler
These were found fuzzing with ASAN.
Modified:
libcxxabi/trunk/src/cxa_demangle.cpp
libcxxabi/trunk/test/test_demang
zturner created this revision.
zturner added reviewers: alexfh, djasper.
zturner added a subscriber: cfe-commits.
When you run the script from lit it starts in the right directory so it can
find `FileCheck` and `clang-tidy`, but when you manually run
`check-clang-tidy.py` from a command line it
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Use table to avoid tautology. List all existing checks groups. Use alphabetical
order.
Rece
zturner updated this revision to Diff 67915.
zturner added a comment.
Update with changes needed to make fixed compilation database work (which also
breaks many other tests)
https://reviews.llvm.org/D23455
Files:
include/clang/Tooling/CompilationDatabase.h
lib/Tooling/CommonOptionsParser.c
zturner added a comment.
This is starting to get fairly difficult, and I'm afraid it may require someone
more knowledgable about clang-format's internals than me. I wrote a test to
have it use a fixed compilation database, and I was able to make that test
pass, but it breaks many other tests.
yaxunl added a comment.
How about we decide if a type is ndrange_t type based on their canonical types.
If the canonical type of type X is the same as the canonical type of ndrange_t
type, then type X is treated as ndrange_t type. Is this reasonable?
Repository:
rL LLVM
https://reviews.llvm
yaxunl added a comment.
Actually we need to assume ndrange_t is a user defined typedef instead of
struct due to the way its used in the spec, e.g.
void f(ndrange_t x);
instead of
void f(struct ndrange_t x);
Then it may be a little bit tricky to decide whether a type is ndrange_t type.
An
amccarth created this revision.
amccarth added a reviewer: rnk.
amccarth added a subscriber: cfe-commits.
With -debug-info-kind=limited, we omit debug info for abstract classes that
live in other TUs. This reduces duplicate type information. When statically
linked, the type information comes t
Author: alexander_droste
Date: Fri Aug 12 14:30:31 2016
New Revision: 278553
URL: http://llvm.org/viewvc/llvm-project?rev=278553&view=rev
Log:
[clang-tidy] MPIBufferDerefCheck
...
This check verifies if a buffer passed to an MPI (Message Passing Interface)
function is sufficiently dereferenced. B
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278553: [clang-tidy] MPIBufferDerefCheck (authored by
Alexander_Droste).
Changed prior to commit:
https://reviews.llvm.org/D22729?vs=66971&id=67884#toc
Repository:
rL LLVM
https://reviews.llvm.org/
This revision was automatically updated to reflect the committed changes.
tra marked an inline comment as done.
Closed by commit rL278549: [CUDA] Place GPU binary into .nv_fatbin section and
align it by 8. (authored by tra).
Changed prior to commit:
https://reviews.llvm.org/D23429?vs=67851&id=6
Author: tra
Date: Fri Aug 12 13:44:01 2016
New Revision: 278549
URL: http://llvm.org/viewvc/llvm-project?rev=278549&view=rev
Log:
[CUDA] Place GPU binary into .nv_fatbin section and align it by 8.
This matches the way nvcc encapsulates GPU binaries into host object file.
Now cuobjdump can deal wi
hans added a comment.
In https://reviews.llvm.org/D23452#514110, @Anastasia wrote:
> Thanks! Is there a way to check the doc before committing? I am not sure how
> to make the html generated out of this.
I build the docs like this:
cmake -GNinja -DLLVM_ENABLE_SPHINX=ON -DLLVM_BUILD_DOCS=ON
Author: zturner
Date: Fri Aug 12 13:39:05 2016
New Revision: 278547
URL: http://llvm.org/viewvc/llvm-project?rev=278547&view=rev
Log:
Remove accidentally committed file.
Removed:
clang-tools-extra/trunk/test/clang-tidy/clang-cl-driver.cpp
Removed: clang-tools-extra/trunk/test/clang-tidy/clan
Author: zturner
Date: Fri Aug 12 13:38:26 2016
New Revision: 278546
URL: http://llvm.org/viewvc/llvm-project?rev=278546&view=rev
Log:
Analyze include order on a per-file basis.
The include order check would get notified of all include
directives in a depth-first manner. This created the
possibil
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278546: Analyze include order on a per-file basis. (authored
by zturner).
Changed prior to commit:
https://reviews.llvm.org/D23434?vs=6&id=67876#toc
Repository:
rL LLVM
https://reviews.llvm.org/
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D23322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
Anastasia added a comment.
Thanks! Is there a way to check the doc before committing? I am not sure how to
make the html generated out of this.
https://reviews.llvm.org/D23452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
rsmith added a comment.
Sorry about the redundant previous comment, the thread got forked by the change
of subject and I missed the updated patch.
Comment at: lib/Sema/SemaDecl.cpp:10484-10485
@@ -10478,1 +10483,4 @@
+ if (var->hasAttr() && !Init)
+ Diag(var->getLocation
dcoughlin added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:593
@@ -590,1 +592,3 @@
+ if (FunI == II_free || FunI == II_realloc ||
+ FunI == II_reallocf || FunI == II_kfree)
return true;
It looks like you are us
hiraditya added a comment.
In https://reviews.llvm.org/D22834#504425, @EricWF wrote:
> LGTM.
>
> However I would like to see a small benchmark that demonstrates the
> performance change. Please try and write the benchmark using Google Benchmark.
> Some helpful links:
>
> http://libcxx.llvm.org/
vsk added a comment.
In https://reviews.llvm.org/D21695#513723, @filcab wrote:
> In https://reviews.llvm.org/D21695#510788, @vsk wrote:
>
> > After reading through the discussion in https://reviews.llvm.org/D19668, I
> > don't think I understood the pros/cons of using a single ABI check (like
>
rsmith added a comment.
Attributes are specified in include/clang/Basic/Attr.td with a (hopefully)
fairly self-explanatory declarative syntax. You'll then need to add code to
lib/Sema/SemaDeclAttr.cpp to create a corresponding attribute object and attach
it to the declaration.
Two implementati
Author: bruno
Date: Fri Aug 12 13:18:24 2016
New Revision: 278543
URL: http://llvm.org/viewvc/llvm-project?rev=278543&view=rev
Log:
Reapply [VFS] Skip non existent files from the VFS tree
Reapply r278457 with test fixed to not abouse fs case sensitivity.
When the VFS uses a YAML file, the real f
I haven't read the patch, but if Alex is ok, so am I.. just wanted to make
sure that we don't spend much more time on this, as we are likely going to
remove most of the code..
On Aug 12, 2016 6:42 PM, "Zachary Turner" wrote:
> Ahh, I see. Just to be clear, is there an LGTM to get this path in?
Sounds good. Just to be clear, you plan to delete the code from
clang-tidy, then take the code from clang-format and move it to clang-tidy,
and have clang-format call clang-tidy (or otherwise share the code somehow
so they both use the same implementation)?
I may still try to implement cross-bloc
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278541: CodeGen: Replace ThinLTO backend implementation with
a client of LTO/Resolution. (authored by tejohnson).
Changed prior to commit:
https://reviews.llvm.org/D21545?vs=64043&id=67868#toc
Reposito
Author: tejohnson
Date: Fri Aug 12 13:12:08 2016
New Revision: 278541
URL: http://llvm.org/viewvc/llvm-project?rev=278541&view=rev
Log:
CodeGen: Replace ThinLTO backend implementation with a client of LTO/Resolution.
Summary:
This changes clang to use the llvm::lto::thinBackend function instead o
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm!
Please commit to https://llvm.org/svn/llvm-project/cfe/branches/release_39 or
let me know if you'd prefer me to do it.
Comment at: docs/ReleaseNotes.rst:206
@@ +205,3 @@
+
On Thu, Aug 11, 2016 at 8:50 PM, Saleem Abdulrasool
wrote:
> On Thu, Aug 11, 2016 at 9:58 AM, Saleem Abdulrasool via cfe-commits
> wrote:
>>
>> Author: compnerd
>> Date: Thu Aug 11 11:58:12 2016
>> New Revision: 278357
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=278357&view=rev
>> Log:
>>
Author: hans
Date: Fri Aug 12 12:59:24 2016
New Revision: 278538
URL: http://llvm.org/viewvc/llvm-project?rev=278538&view=rev
Log:
Merging r278357:
r278357 | compnerd | 2016-08-11 09:58:12 -0700 (Thu, 11 Aug 2016) | 6 lines
Author: zturner
Date: Fri Aug 12 12:47:52 2016
New Revision: 278535
URL: http://llvm.org/viewvc/llvm-project?rev=278535&view=rev
Log:
[Driver] Set the default driver mode based on the executable.
Currently, if --driver-mode is not passed at all, it will default
to GCC style driver. This is never
Author: alexander_droste
Date: Fri Aug 12 12:46:23 2016
New Revision: 278534
URL: http://llvm.org/viewvc/llvm-project?rev=278534&view=rev
Log:
Revert test commit
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/MPI-Checker/MPITypes.h
Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MPI-Checker
dcoughlin removed rL LLVM as the repository for this revision.
dcoughlin updated this revision to Diff 67862.
dcoughlin added a comment.
Merge the two patches into one diff.
https://reviews.llvm.org/D23375
Files:
lib/StaticAnalyzer/Checkers/MallocChecker.cpp
test/Analysis/kmalloc-linux.c
I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278535: [Driver] Set the default driver mode based on the
executable. (authored by zturner).
Changed prior to commit:
https://reviews.llvm.org/D23454?vs=67853&id=67861#toc
Repository:
rL LLVM
https:
zturner added a comment.
I mentioned offline that we could detect CRLF or LF and heuristically decide
whether it's a windows compilation database. That seems like a horrible hack,
so failing that, yes having CMake do it for us would be better.
https://reviews.llvm.org/D23455
__
dcoughlin commandeered this revision.
dcoughlin edited reviewers, added: andrewmw94; removed: dcoughlin.
dcoughlin added a comment.
Thanks for the patches! I've commandeered this revision to be able to update
the diff to merge the two patch files into one. You should commandeer it back
by using
Eugene.Zelenko added a comment.
Ping. I could not proceed until my question answered.
Repository:
rL LLVM
https://reviews.llvm.org/D23045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
rnk added a subscriber: rnk.
rnk added a comment.
We should convince cmake to emit "arguments" instead of "command" so that we
don't have this ambiguity.
https://reviews.llvm.org/D23455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
Author: alexander_droste
Date: Fri Aug 12 12:43:58 2016
New Revision: 278533
URL: http://llvm.org/viewvc/llvm-project?rev=278533&view=rev
Log:
Test commit - first LLVM repo commit
Modified:
cfe/trunk/lib/StaticAnalyzer/Checkers/MPI-Checker/MPITypes.h
Modified: cfe/trunk/lib/StaticAnalyzer/Ch
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D23454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zturner created this revision.
zturner added reviewers: alexfh, djasper.
zturner added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
When a compilation database is used on Windows, the command lines cannot be
parsed using the standard GNU style syntax. LLVM provides functions for
zturner created this revision.
zturner added a reviewer: rnk.
zturner added a subscriber: cfe-commits.
If `--driver-mode` is passed in one or more times, it will overwrite the
default by this patch. This patch only makes it so that if NO `--driver-mode`
is passed in, we try to do better than sa
zturner abandoned this revision.
zturner added a comment.
Once I split the JSONCompilationDatabase patch out, then the rest is strictly a
driver-only patch, and the other one is strictly a tooling patch. So I will
abandon this one and upload two new patches with a more targeted set of
reviewer
aaron.ballman marked an inline comment as done.
Comment at: include/clang/Frontend/LangStandards.def:94
@@ -93,1 +93,3 @@
+// C2X modes
+LANGSTANDARD(c2x, "c2x",
majnemer wrote:
> Should this be C2x instead of C2X?
Probably. :-D
https://reviews.llvm.org/D23453
tra marked an inline comment as done.
Comment at: lib/CodeGen/CGCUDANV.cpp:62-69
@@ -60,3 +61,10 @@
llvm::ConstantInt::get(SizeTy, 0)};
auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str());
+llvm::GlobalVariable *GV =
+ca
alexfh added a comment.
The changes in Driver LGTM (though I'd prefer someone who knows Driver to look).
Could you move lib/Tooling/JSONCompilationDatabase.cpp to a separate patch? It
seems like an orthogonal change.
As for a clang-cl-mode test for clang-tidy, clang-tidy-run-with-database.cpp i
tra updated this revision to Diff 67851.
tra added a comment.
Reverted argument type to std::string
https://reviews.llvm.org/D23429
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device-stub.cu
Index: test/CodeGenCUDA/device-stub.cu
===
alexshap added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217
@@ +216,3 @@
+// then large field indices to small field indices
+return std::make_tuple(Align, -Size,
+ Field ?
-static_cast(Field->getFie
majnemer added a subscriber: majnemer.
Comment at: include/clang/Frontend/LangStandards.def:94
@@ -93,1 +93,3 @@
+// C2X modes
+LANGSTANDARD(c2x, "c2x",
Should this be C2x instead of C2X?
https://reviews.llvm.org/D23453
_
zatrazz updated this revision to Diff 67850.
zatrazz added a comment.
I think patch should be safe now.
https://reviews.llvm.org/D23420
Files:
test/libcxx/test/target_info.py
Index: test/libcxx/test/target_info.py
===
--- test/l
Author: dexonsmith
Date: Fri Aug 12 11:46:25 2016
New Revision: 278525
URL: http://llvm.org/viewvc/llvm-project?rev=278525&view=rev
Log:
BugReporter: Use ilist_half_embedded_sentinel_traits, NFC
This avoids duplicated code with llvm/ADT/ilist.h. No functionality
change.
Modified:
cfe/trunk/
Prazek added a subscriber: Prazek.
Comment at: clang-tidy/readability/NonConstParameterCheck.cpp:95-98
@@ +94,6 @@
+const QualType T = VD->getType();
+if (T->isPointerType() && !T->getPointeeType().isConstQualified())
+ markCanNotBeConst(VD->getInit(), true);
+els
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, doug.gregor.
aaron.ballman added a subscriber: cfe-commits.
This patch adds support for a "c2x" language standard mode for the eventual new
C language standard, expected to come out in 202x. The spelling and
capitalizati
Ahh, I see. Just to be clear, is there an LGTM to get this path in? I
know alexfh@ lgtm'ed it, want to make sure you're ok with this too.
On Fri, Aug 12, 2016 at 9:40 AM Daniel Jasper wrote:
> The check's implementation will be replaced by a simple call to clang
> tidy. It will remain a check
The check's implementation will be replaced by a simple call to clang tidy.
It will remain a check in clang tidy to continue to cater to both use cases.
On Aug 12, 2016 6:19 PM, "Zachary Turner" wrote:
> That's actually the reason I think it makes more sense in clang tidy. It
> can be a configur
alexfh added a comment.
A few initial comments.
Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:492
@@ +491,3 @@
+ DeclRefs->clear();
+ for (CFGBlock::const_iterator I = Block->begin(), E = Block->end(); I != E;
+ ++I) {
Any reason to avoid range-based
majnemer added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:10388-10390
@@ -10387,2 +10387,5 @@
+ // Cache the result of checking for constant initialization.
+ Optional HasConstInit;
+
if (var->getTLSKind() == VarDecl::TLS_Static) {
You could use a l
Anastasia created this revision.
Anastasia added a reviewer: hans.
Anastasia added subscribers: yaxunl, bader, cfe-commits.
Release notes for OpenCL in Clang
https://reviews.llvm.org/D23452
Files:
docs/ReleaseNotes.rst
Index: docs/ReleaseNotes.rst
=
That's actually the reason I think it makes more sense in clang tidy. It
can be a configuration option, off by default, and since there is more
control over whether to apply fixits, and it doesn't apply fixits by
default, it would be easier to iterate on the experimental nature of it
without messin
alexfh added a comment.
In https://reviews.llvm.org/D23434#513839, @djasper wrote:
> I think we got confused. We once had tried to write an experimental separate
> check to comply with Google's style guide. If you want to fiddle around with
> that, contact me, I can send you pointers. But as I
one disadvantage to clang format is that you have less control over how and
whether to apply fixits. Reordering across blocks has a higher risk of
breaking code, and you can't tell clang format to only apply fixits which
don't break code, or to not apply any fixits but just warn.
Code duplication
djasper added a comment.
I think we got confused. We once had tried to write an experimental separate
check to comply with Google's style guide. If you want to fiddle around with
that, contact me, I can send you pointers. But as I mentioned we moved away
from that. And I think it makes more sen
You and daniel both imply that clang-tidy can sort across blocks. Am I
missing this somewhere?
My intention was to add an option for this in a followup patch because it
doesn't seem to be able to currently.
On Fri, Aug 12, 2016 at 8:21 AM Alexander Kornienko
wrote:
> alexfh accepted this revisio
zatrazz added a comment.
In https://reviews.llvm.org/D23420#513824, @jroelofs wrote:
> In https://reviews.llvm.org/D23420#513820, @zatrazz wrote:
>
> > Yes, although in pratice for shared libraries this is not an issue (at
> > least on Linux with current linker strategies). And I open for sugges
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
The patch LG.
In https://reviews.llvm.org/D23434#513533, @djasper wrote:
> I think we should entirely drop this implementation of the check and let it
> just check #includes with clang-format
jroelofs added a comment.
In https://reviews.llvm.org/D23420#513820, @zatrazz wrote:
> Yes, although in pratice for shared libraries this is not an issue (at least
> on Linux with current linker strategies). And I open for suggestion on how to
> proceed in this case since we have some other opt
zatrazz added a comment.
Yes, although in pratice for shared libraries this is not an issue (at least on
Linux with current linker strategies). And I open for suggestion on how to
proceed in this case since we have some other options:
1. Add the required soft-sp implementations when building fo
joey added a subscriber: joey.
Comment at: lib/CodeGen/CodeGenModule.cpp:101
@@ -100,3 +100,3 @@
DoubleTy = llvm::Type::getDoubleTy(LLVMContext);
PointerWidthInBits = C.getTargetInfo().getPointerWidth(0);
PointerAlignInBytes =
What if you create a new fun
jroelofs added a comment.
This breaks the ODR... the behavior under those circumstances is undefined.
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zatrazz added a comment.
Yes, but my understaning is the proposed link order will force libc++ to link
against _Unwind* symbols from libunwind (this is what I am observing also).
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-comm
yaxunl added a comment.
In https://reviews.llvm.org/D23322#513792, @Anastasia wrote:
> Do you think testing the declaration to be available without/with an error
> after the extension is enabled/disabled might be useful too?
I feel it is not so useful for a specific extension.
When the featur
jroelofs added a comment.
Doesn't libgcc_s contain bits of gcc's unwinder?
https://reviews.llvm.org/D23420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added a comment.
Do you think testing the declaration to be available without/with an error
after the extension is enabled/disabled might be useful too?
https://reviews.llvm.org/D23322
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
zatrazz created this revision.
zatrazz added reviewers: jroelofs, danalbert, EricWF.
zatrazz added subscribers: rmaprath, aemerson, rengolin, cfe-commits.
The expected 'filesystem::path::compare' result states that for different
only the sign of result integer contains the information about passed
zatrazz updated this revision to Diff 67835.
zatrazz added a comment.
What about this version? The only difference is for libunwind libgcc is still
included.
https://reviews.llvm.org/D23420
Files:
test/libcxx/test/target_info.py
Index: test/libcxx/test/target_info.py
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL278507: [ASTMatchers] Add templateTypeParmDecl() to
Registry.cpp (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D23448?vs=67831&id=67832#toc
Repository:
rL LLVM
https://rev
Author: mboehme
Date: Fri Aug 12 08:51:00 2016
New Revision: 278507
URL: http://llvm.org/viewvc/llvm-project?rev=278507&view=rev
Log:
[ASTMatchers] Add templateTypeParmDecl() to Registry.cpp
Summary:
This appears to have been forgotten when templateTypeParmDecl() was initially
added.
Reviewers:
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D23448
__
mboehme created this revision.
mboehme added a reviewer: alexfh.
mboehme added a subscriber: cfe-commits.
Herald added subscribers: samparker, rengolin, aemerson, klimek.
This appears to have been forgotten when templateTypeParmDecl() was initially
added.
https://reviews.llvm.org/D23448
Files:
mboehme updated this revision to Diff 67829.
mboehme marked 2 inline comments as done.
mboehme added a comment.
Fix typo in comment
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
c
mboehme added inline comments.
Comment at: test/clang-tidy/misc-move-forwarding-reference.cpp:50
@@ +49,3 @@
+// operator.
+template void f5(U &&SomeU) {
+ {
Sorry, that should have been "scope resolution operator". Comment changed.
What this is trying to test
EricWF added inline comments.
Comment at: include/clang/Basic/Attr.td:1384
@@ +1383,3 @@
+def RequireConstantInit : InheritableAttr {
+ let Spellings = [GCC<"require_constant_initialization">];
+ let Subjects = SubjectList<[Var]>;
aaron.ballman wrote:
> This sho
mboehme updated this revision to Diff 67830.
mboehme added a comment.
Restore spaces around scope resolution operator in test case
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingReferenceCheck.cpp
cl
mboehme updated this revision to Diff 67828.
mboehme added a comment.
Handle case where the forwarding reference is a parameter of a generic lambda.
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingRefer
bcraig added a comment.
LGTM. Thanks for the patch!
Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:217
@@ +216,3 @@
+// then large field indices to small field indices
+return std::make_tuple(Align, -Size,
+ Field ?
-st
EricWF updated this revision to Diff 67827.
EricWF marked 7 inline comments as done.
EricWF added a comment.
Address @aaron.ballman's review comments.
https://reviews.llvm.org/D23385
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds
1 - 100 of 126 matches
Mail list logo
