Re: r278471 - [Sema] Fix a crash on variadic enable_if functions.

r278479. Thank you! :) On Thu, Aug 11, 2016 at 10:08 PM, Richard Smith wrote: > Sure, looks safe enough to me. > > On 11 Aug 2016 9:23 p.m., "George Burgess IV" > wrote: > > Hi Richard, > > Would you mind if I merged this into the 3.9 branch? :) > > Thanks, > George > > On Thu, Aug 11, 2016 at

Re: r278471 - [Sema] Fix a crash on variadic enable_if functions.

Sure, looks safe enough to me. On 11 Aug 2016 9:23 p.m., "George Burgess IV" wrote: Hi Richard, Would you mind if I merged this into the 3.9 branch? :) Thanks, George On Thu, Aug 11, 2016 at 9:12 PM, George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gbiv > Date

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap updated this revision to Diff 67797. alexshap added a comment. Update the tests. Update the format again (do not include the type name because the diagnostics becomes too verbose and unreadable (i ran it against LLVM and clang - with type names the diagnostic messages are getting very l

r278472 - [Sema] Fix the wording of a comment. NFC.

Author: gbiv Date: Thu Aug 11 23:19:35 2016 New Revision: 278472 URL: http://llvm.org/viewvc/llvm-project?rev=278472&view=rev Log: [Sema] Fix the wording of a comment. NFC. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL: http://llvm.org/viewv

Re: r278471 - [Sema] Fix a crash on variadic enable_if functions.

Hi Richard, Would you mind if I merged this into the 3.9 branch? :) Thanks, George On Thu, Aug 11, 2016 at 9:12 PM, George Burgess IV via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: gbiv > Date: Thu Aug 11 23:12:31 2016 > New Revision: 278471 > > URL: http://llvm.org/viewvc/llvm-

r278471 - [Sema] Fix a crash on variadic enable_if functions.

Author: gbiv Date: Thu Aug 11 23:12:31 2016 New Revision: 278471 URL: http://llvm.org/viewvc/llvm-project?rev=278471&view=rev Log: [Sema] Fix a crash on variadic enable_if functions. Currently, when trying to evaluate an enable_if condition, we try to evaluate all arguments a user passes to a fun

Re: [libcxx] r278357 - test: relax the FS test a slight bit to be more reliable

On Thu, Aug 11, 2016 at 9:58 AM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Thu Aug 11 11:58:12 2016 > New Revision: 278357 > > URL: http://llvm.org/viewvc/llvm-project?rev=278357&view=rev > Log: > test: relax the FS test a slight bit to be m

Re: [PATCH] D22666: Frontend: Fix mcount inlining bug

compnerd added a comment. No, the inserted character is a literal SOH, not the string "\01". https://reviews.llvm.org/D22666 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF marked an inline comment as done. EricWF added a comment. In https://reviews.llvm.org/D23385#513443, @rsmith wrote: > Have you considered modelling this as an attribute on the declaration of the > variable instead of as a separate check? If so, why do you prefer this > approach? (If I we

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

rsmith added a comment. Have you considered modelling this as an attribute on the declaration of the variable instead of as a separate check? If so, why do you prefer this approach? (If I were to suggest this for standardization, an attribute is the approach I'd probably take.) ==

r278460 - P0217R3: serialization/deserialization support for c++17 decomposition declarations.

Author: rsmith Date: Thu Aug 11 21:21:25 2016 New Revision: 278460 URL: http://llvm.org/viewvc/llvm-project?rev=278460&view=rev Log: P0217R3: serialization/deserialization support for c++17 decomposition declarations. Added: cfe/trunk/test/PCH/cxx1z-decomposition.cpp Modified: cfe/trunk/

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

jroelofs added a comment. I don't think I have any more comments, but I'll let one of the other reviewers give the final go/no-go. Comment at: docs/LanguageExtensions.rst:1047 @@ +1046,3 @@ + Determines whether `expr` names + a object that will be initialized during + `const

r278459 - Revert "[VFS] Skip non existent files from the VFS tree"

Author: bruno Date: Thu Aug 11 21:17:26 2016 New Revision: 278459 URL: http://llvm.org/viewvc/llvm-project?rev=278459&view=rev Log: Revert "[VFS] Skip non existent files from the VFS tree" Breaking bots: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/27281/ This rever

r278458 - P0217R3: template instantiation support for decomposition declarations.

Author: rsmith Date: Thu Aug 11 20:55:21 2016 New Revision: 278458 URL: http://llvm.org/viewvc/llvm-project?rev=278458&view=rev Log: P0217R3: template instantiation support for decomposition declarations. Added: cfe/trunk/test/SemaTemplate/cxx1z-decomposition.cpp Modified: cfe/trunk/inclu

Re: [PATCH] D23422: [VFS] Add 'ignore-non-existent-contents' field to YAML

bruno accepted this revision. bruno added a reviewer: bruno. bruno added a comment. This revision is now accepted and ready to land. Applied your comments, and committed in r278456! Thanks https://reviews.llvm.org/D23422 ___ cfe-commits mailing lis

r278457 - [VFS] Skip non existent files from the VFS tree

Author: bruno Date: Thu Aug 11 20:51:04 2016 New Revision: 278457 URL: http://llvm.org/viewvc/llvm-project?rev=278457&view=rev Log: [VFS] Skip non existent files from the VFS tree When the VFS uses a YAML file, the real file path for a virtual file is described in the "external-contents" field. E

r278456 - [VFS] Add 'ignore-non-existent-contents' field to YAML files

Author: bruno Date: Thu Aug 11 20:50:53 2016 New Revision: 278456 URL: http://llvm.org/viewvc/llvm-project?rev=278456&view=rev Log: [VFS] Add 'ignore-non-existent-contents' field to YAML files Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path obtained via 'external-conten

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF marked an inline comment as done. Comment at: lib/Sema/SemaExprCXX.cpp:4775 @@ +4774,3 @@ + // duration. AObjects with automatic or dynamic lifetime never have + // a 'constant initializer'. + if ((VD->hasGlobalStorage() || I've added docs to

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF updated this revision to Diff 67790. EricWF marked an inline comment as done. EricWF added a comment. - Add documentation for `__has_constant_initializer` and expression traits in general. - Make expression traits detectable using `__has_extension`. https://reviews.llvm.org/D23385 Files

r278448 - Remove unused and undesirable reference from BindingDecl to DecompositionDecl.

Author: rsmith Date: Thu Aug 11 19:53:41 2016 New Revision: 278448 URL: http://llvm.org/viewvc/llvm-project?rev=278448&view=rev Log: Remove unused and undesirable reference from BindingDecl to DecompositionDecl. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/lib/AST/DeclCXX.cpp

r278447 - P0217R3: Constant expression evaluation for decomposition declarations.

Author: rsmith Date: Thu Aug 11 19:39:32 2016 New Revision: 278447 URL: http://llvm.org/viewvc/llvm-project?rev=278447&view=rev Log: P0217R3: Constant expression evaluation for decomposition declarations. Modified: cfe/trunk/include/clang/AST/DeclCXX.h cfe/trunk/lib/AST/DeclCXX.cpp cf

Re: [PATCH] D23433: [Basic] Add missing `const` qualifier (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL278444: [Basic] Add const qualifier to SM.isInSystemMacro (NFC) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D23433?vs=67737&id=67781#toc Repository: rL LLVM https://revi

r278444 - [Basic] Add const qualifier to SM.isInSystemMacro (NFC)

Author: vedantk Date: Thu Aug 11 19:20:39 2016 New Revision: 278444 URL: http://llvm.org/viewvc/llvm-project?rev=278444&view=rev Log: [Basic] Add const qualifier to SM.isInSystemMacro (NFC) The member function is a predicate, and doesn't apply any changes on the object. Patch by Visoiu Mistrih F

Re: [PATCH] D23434: Don't allow llvm-include-order to intermingle includes from different files.

zturner updated this revision to Diff 6. zturner added a comment. Seems like dropping all non-main-file include directives is wrong because then it won't be able to detect errors in "non user code". Seems like the real fix is to bucket the include directives by file in which they were decla

Re: [PATCH] D23397: [clang-rename] cleanup `auto` usages

alexfh added a comment. A couple of comments inline. Comment at: clang-rename/RenamingAction.cpp:73 @@ -72,3 +72,3 @@ // FIXME: better error handling. - auto Replace = tooling::Replacement(SourceMgr, Loc, PrevNameLen, NewName); - auto Err = FileToReplaces[Repla

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF updated this revision to Diff 67776. EricWF added a comment. - Apply @jroelof's suggestions - Add tests for static class members https://reviews.llvm.org/D23385 Files: include/clang/AST/Expr.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/ExpressionTraits.h inclu

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

jroelofs added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6807 @@ +6806,3 @@ + +def err_has_constant_init_expression_trait_invalid_arg : Error< + "expression does not reference a named variable">; EricWF wrote: > Help improving this w

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap added a comment. toy example: F2262237: toy_example.png https://reviews.llvm.org/D23387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23433: [Basic] Add missing `const` qualifier (NFC)

thegameg added a comment. Thanks @vsk. As I don't have commit access, is it possible to commit this for me, please? Thanks. https://reviews.llvm.org/D23433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4775 @@ +4774,3 @@ + // a 'constant initializer'. + else if ((VD->hasGlobalStorage() || + VD->getTLSKind() != VarDecl::TLS_None) && VD->hasInit()) { EricWF wrote: > jroelofs wrot

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap updated this revision to Diff 67773. alexshap added a comment. Use more stable sort (preserving the original order if possible). Change the format of the report. Update the tests. I have not turned it to "note:" or "remark:" because in this case it's not included into the description and

Re: [PATCH] D23434: Don't allow llvm-include-order to intermingle includes from different files.

zturner updated this revision to Diff 67772. zturner added a comment. Fixed the test for this. Confirmed that it fails before the patch and succeeds after the patch. https://reviews.llvm.org/D23434 Files: clang-tidy/llvm/IncludeOrderCheck.cpp test/clang-tidy/Inputs/Headers/cross-file-a.h

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF marked an inline comment as done. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6807 @@ +6806,3 @@ + +def err_has_constant_init_expression_trait_invalid_arg : Error< + "expression does not reference a named variable">; Help improving this wording

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz added a comment. I tried to find why exactly libgcc has to appear before and after but I couldn't get any information from commit history. On my system (aarch64/linux) I am also getting "-lc++" "-lm" "-lgcc_s" "-lgcc" "-lpthread" "-lc" "-lgcc_s" "-lgcc". I think we can got by the safe

[PATCH] D23434: Don't allow llvm-include-order to intermingle includes from different files.

zturner created this revision. zturner added reviewers: alexfh, djasper. zturner added a subscriber: cfe-commits. See llvm.org/pr28943 for some context. I'm not sure if this is the right fix, but it seems to pass the test suite for me. https://reviews.llvm.org/D23434 Files: clang-tidy/llvm/I

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

jroelofs added a comment. One more thing: need to add docs to `clang/docs/LanguageExtensions.rst`. https://reviews.llvm.org/D23385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

jroelofs added a subscriber: jroelofs. Comment at: lib/AST/Expr.cpp:2656 @@ +2655,3 @@ +AllowNonLiteral)) { +if (!CE->getNumArgs()) return true; +unsigned numArgs = CE->getNumArgs(); no need for this `if`. Also, I think the `for` shoul

Re: [PATCH] D23385: Implement __has_constant_initializer(obj) expression traits.

EricWF updated this revision to Diff 67768. EricWF added a comment. Re-flow comments because I suck at English. https://reviews.llvm.org/D23385 Files: include/clang/AST/Expr.h include/clang/Basic/DiagnosticSemaKinds.td include/clang/Basic/ExpressionTraits.h include/clang/Basic/TokenKind

[PATCH] D23433: [Basic] Add missing `const` qualifier (NFC)

thegameg created this revision. thegameg added reviewers: joker-eph, vsk, dblaikie. thegameg added a subscriber: cfe-commits. The member function is a predicate, and doesn't apply any changes on the object. https://reviews.llvm.org/D23433 Files: include/clang/Basic/SourceManager.h Index: incl

Re: [PATCH] D23429: [CUDA] Place GPU binary into .nv_fatbin section and align it by 8.

jlebar added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:62 @@ -60,2 +61,3 @@ llvm::ConstantInt::get(SizeTy, 0)}; -auto ConstStr = CGM.GetAddrOfConstantCString(Str, Name.c_str()); +auto ConstStr = CGM.GetAddrOfConstantCString(Str,

Re: [PATCH] D23433: [Basic] Add missing `const` qualifier (NFC)

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Makes sense. isMacroID and isInSystemHeader are both already marked const. https://reviews.llvm.org/D23433 ___ cfe-commits mailing list cfe-commits@lis

Re: [PATCH] D23341: [CUDA] Include CUDA headers before anything else.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. OK. This should help with PR26966. https://reviews.llvm.org/D23341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

r278435 - P0217R3: Perform semantic checks and initialization for the bindings in a

Author: rsmith Date: Thu Aug 11 17:25:46 2016 New Revision: 278435 URL: http://llvm.org/viewvc/llvm-project?rev=278435&view=rev Log: P0217R3: Perform semantic checks and initialization for the bindings in a decomposition declaration for arrays, aggregate-like structs, tuple-like types, and (as an

[PATCH] D23429: [CUDA] Place GPU binary into .nv_fatbin section and align it by 8.

tra created this revision. tra added a reviewer: jlebar. tra added a subscriber: cfe-commits. This matches the way nvcc encapsulates GPU binaries into host object file. Now cuobjdump can deal with clang-compiled object files. https://reviews.llvm.org/D23429 Files: lib/CodeGen/CGCUDANV.cpp

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

On Thu, Aug 11, 2016 at 1:38 PM, Faisal Vali wrote: > On Thu, Aug 11, 2016 at 1:07 PM, Richard Smith > wrote: > > Yes, this should be merged. It's not quite right, but it's certainly > better > > than what we had before. > > I would agree that the comment is broken - but, unless i'm missing > s

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

zturner updated this revision to Diff 67751. zturner added a comment. I added a test for the clang Driver changes. It seems I'm still having some trouble writing the clang-cl test for clang-tidy. It depends on having a different compilation database that uses clang-cl instead of clang. I foun

Re: [libcxx] r278282 - std:: quailfy the calls for cend/crend/cbegin/cend. Fixes bug 28927.

I've gone ahead and merged it in r278426. On Wed, Aug 10, 2016 at 5:19 PM, Eric Fiselier wrote: > I would support merging this change. > > /Eric > > On Wed, Aug 10, 2016 at 3:20 PM, Hans Wennborg via cfe-commits > wrote: >> >> Should we merge this to 3.9? Looks like a straight-forward fix for >>

[libcxx] r278426 - Merging r278282:

Author: hans Date: Thu Aug 11 16:48:37 2016 New Revision: 278426 URL: http://llvm.org/viewvc/llvm-project?rev=278426&view=rev Log: Merging r278282: r278282 | marshall | 2016-08-10 13:04:46 -0700 (Wed, 10 Aug 2016) | 1 line s

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

EricWF added a subscriber: EricWF. EricWF added a reviewer: EricWF. EricWF added a comment. Urg... Not this again. This link order is important. I can't remember *why*, but libgcc has to appear both before and after `pthread` and `libc` IIRC. Either way the intention here is to mimic the output

Re: [libcxx] r278387 - Remove test for the sign of a NaN - doesn't work on MIPS, not strictly legal. Fixes bug 28936

Merged to 3.9 in r278425, as the PR was marked as a release blocker. On Thu, Aug 11, 2016 at 11:46 AM, Marshall Clow via cfe-commits wrote: > Author: marshall > Date: Thu Aug 11 13:46:24 2016 > New Revision: 278387 > > URL: http://llvm.org/viewvc/llvm-project?rev=278387&view=rev > Log: > Remove t

[libcxx] r278425 - Merging r278387:

Author: hans Date: Thu Aug 11 16:47:28 2016 New Revision: 278425 URL: http://llvm.org/viewvc/llvm-project?rev=278425&view=rev Log: Merging r278387: r278387 | marshall | 2016-08-11 11:46:24 -0700 (Thu, 11 Aug 2016) | 1 line R

Re: [PATCH] D23422: [VFS] Add 'ignore-non-existent-contents' field to YAML

benlangmuir added a comment. This should have a test for the writer change. Otherwise LGTM. https://reviews.llvm.org/D23422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23423: [Clang-tidy] Comparison Function Address

Eugene.Zelenko added a comment. This check looks like specific case of https://reviews.llvm.org/D23427. May be they should be merged? Repository: rL LLVM https://reviews.llvm.org/D23423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

Re: [PATCH] D23427: [Clang-tidy] Comparison Misuse

Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/ComparisonMisuseCheck.cpp:21 @@ +20,3 @@ +void ComparisonMisuseCheck::registerMatchers(MatchFinder *Finder) { + + Finder->addMatcher( Please remove this line. Repository: rL LLVM https://revie

Re: [PATCH] D23427: [Clang-tidy] Comparison Misuse

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Please run Clang-format on newly added files. Test case is definitely needs it. Comment at: clang-tidy/misc/ComparisonM

Re: [PATCH] D23421: [Clang-tidy] CERT-MSC53-CPP (checker for std namespace modification)

aaron.ballman added a comment. Thank you for working on this check! There is a slight problem, however, in that the check as-written will flag false positives because there are times when it is permissible to modify the std namespace. The important bit of the CERT requirement is "Do not add dec

Re: [PATCH] D22346: [Clang-tidy] CERT-MSC50-CPP (std:rand() )

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: docs/clang-tidy/checks/cert-msc50-cpp.rst:4 @@ +3,3 @@ +cert-msc-50 +=== + Should be same length as section name above. =

Re: [PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

rmaprath added a subscriber: rmaprath. rmaprath added a comment. I too noticed this very recently (on our non-bare-metal builds), and wondered why these dependencies are not included by default. Thanks for looking into it. I'll let someone familiar with the details approve. https://reviews.llv

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

zturner added a comment. In https://reviews.llvm.org/D23409#513017, @alexfh wrote: > May I ask you to upload patches with full diff context next time? I know, > it's not directly supported by TortoiseGit, but there are at least two other > reasonable ways of generating full diffs for Phabricato

[PATCH] D23427: [Clang-tidy] Comparison Misuse

falho created this revision. falho added reviewers: xazax.hun, o.gyorgy, alexfh, aaron.ballman, etienneb, hokein, Prazek. falho added a subscriber: cfe-commits. falho set the repository for this revision to rL LLVM. This checker warns for the misuse of comparison operators - char* is compared to

Re: [PATCH] D23423: [Clang-tidy] Comparison Function Address

Eugene.Zelenko added a comment. Clang-tidy terminology use //checks//, not //checkers//. Repository: rL LLVM https://reviews.llvm.org/D23423 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D23423: [Clang-tidy] Comparison Function Address

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). If I'm not mistaken, GCC or Clang has warning that result of comparison is always true for such situations. Comment at: clang-tidy/misc/ComparisonFunctionAddressCheck.h:

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

alexfh added a comment. May I ask you to upload patches with full diff context next time? I know, it's not directly supported by TortoiseGit, but there are at least two other reasonable ways of generating full diffs for Phabricator: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-

Re: r278395 - Don't enable PIE on i686-unknown-cloudabi.

On Thu, Aug 11, 2016 at 08:03:22PM -, Ed Schouten via cfe-commits wrote: > Modified: cfe/trunk/lib/Driver/ToolChains.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains.cpp?rev=278395&r1=278394&r2=278395&view=diff > =

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

On Thu, Aug 11, 2016 at 1:07 PM, Richard Smith wrote: > Yes, this should be merged. It's not quite right, but it's certainly better > than what we had before. I would agree that the comment is broken - but, unless i'm missing something subtle, the subsequent logic and call to adjustCVQualifiersF

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

alexfh added a comment. In https://reviews.llvm.org/D23409#512819, @zturner wrote: > In https://reviews.llvm.org/D23409#512745, @zturner wrote: > > > In https://reviews.llvm.org/D23409#512720, @aaron.ballman wrote: > > > > > Patch generally LGTM, though I wonder if there's a way we can add test

[PATCH] D23422: [VFS] Add 'ignore-non-existent-contents' field to YAML

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added a subscriber: cfe-commits. Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path obtained via 'external-contents' should cause iteration on the VFS to stop. If 'true', the VFS should ignore the entr

r278395 - Don't enable PIE on i686-unknown-cloudabi.

Author: ed Date: Thu Aug 11 15:03:22 2016 New Revision: 278395 URL: http://llvm.org/viewvc/llvm-project?rev=278395&view=rev Log: Don't enable PIE on i686-unknown-cloudabi. We're only going to provide support for using PIE on architectures that provide PC-relative addressing. i686 is not one of th

[PATCH] D23420: libcxx: Fix libcxx test on aarch64 with libunwind

zatrazz created this revision. zatrazz added reviewers: jroelofs, danalbert. zatrazz added subscribers: rengolin, cfe-commits. Herald added a subscriber: aemerson. Some tests uses 'long double' to/from conversions and for some targets they are provided by compiler runtime (either compiler-rt or li

Re: [PATCH] D23418: [analyzer] Added a pass architecture to the CloneDetector

teemperor planned changes to this revision. teemperor added a comment. - Add description - Make sure functions in CloneDetection.cpp are in a more logical order. https://reviews.llvm.org/D23418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D23418: [analyzer] Added a pass architecture to the CloneDetector

teemperor created this revision. teemperor added reviewers: v.g.vassilev, NoQ, zaks.anna. teemperor added a subscriber: cfe-commits. https://reviews.llvm.org/D23418 Files: include/clang/Analysis/CloneDetection.h lib/Analysis/CloneDetection.cpp lib/StaticAnalyzer/Checkers/CloneChecker.cpp I

r278393 - Pass in frame pointer omitting compiler flags for CloudABI as well.

Author: ed Date: Thu Aug 11 14:23:30 2016 New Revision: 278393 URL: http://llvm.org/viewvc/llvm-project?rev=278393&view=rev Log: Pass in frame pointer omitting compiler flags for CloudABI as well. On Linux we pass in -fomit-frame-pointer flags (and similar) automatically if optimization is enable

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren updated this revision to Diff 67727. manmanren added a comment. Addressing Richard's comments. https://reviews.llvm.org/D23125 Files: docs/Modules.rst include/clang/Driver/Options.td include/clang/Lex/HeaderSearch.h include/clang/Lex/HeaderSearchOptions.h include/clang/Seria

Re: [libcxx] r278191 - test/hard_link_count(): Fix test on darwin

I'm just curious: Is libcxx generally supposed to merely pass through what the operating system is returning (as in this case) or is is supposed to provide a common abstraction that behaves the same on all platforms? -- adrian > On Aug 10, 2016, at 8:23 PM, Eric Fiselier via cfe-commits > wro

[libcxx] r278387 - Remove test for the sign of a NaN - doesn't work on MIPS, not strictly legal. Fixes bug 28936

Author: marshall Date: Thu Aug 11 13:46:24 2016 New Revision: 278387 URL: http://llvm.org/viewvc/llvm-project?rev=278387&view=rev Log: Remove test for the sign of a NaN - doesn't work on MIPS, not strictly legal. Fixes bug 28936 Modified: libcxx/trunk/test/std/numerics/complex.number/comple

Re: [PATCH] D23003: [ObjC Availability] Warn upon unguarded use of partially available declaration

erik.pilkington updated this revision to Diff 67713. erik.pilkington added a comment. This new patch adds some testcases for templates, and simplifies some control flow in `TraverseIfStmt`. This patch also removes diagnostics for instantiated templates, instead just using the pattern. This means

r278382 - [analyzer] Teach RetainCountChecker about CVFooRetain

Author: dcoughlin Date: Thu Aug 11 13:41:29 2016 New Revision: 278382 URL: http://llvm.org/viewvc/llvm-project?rev=278382&view=rev Log: [analyzer] Teach RetainCountChecker about CVFooRetain Change the retain count checker to treat CoreFoundation-style "CV"-prefixed reference types from CoreVideo

Re: r278264 - Reapply [Sema] Add sizeof diagnostics for bzero

On Thu, Aug 11, 2016 at 5:43 AM, Joerg Sonnenberger via cfe-commits wrote: > > On Wed, Aug 10, 2016 at 02:36:01PM -0700, Bruno Cardoso Lopes wrote: > > Hi Joerg, > > > > > Given that bzero is pretty much non-standard at this point, I strongly > > > dislike the approach of checking only the functio

Re: [PATCH] D23125: Modules: add command line option to support loading prebuilt modules on demand, without parsing any module map

manmanren added inline comments. Comment at: lib/Frontend/CompilerInstance.cpp:1438-1450 @@ -1437,3 +1437,15 @@ // Search for a module with the given name. Module = PP->getHeaderSearchInfo().lookupModule(ModuleName); -if (!Module) { +HeaderSearchOptions &HSOpts =

r278379 - [Sema] Add more strict check for sizeof diagnostics for bzero

Author: bruno Date: Thu Aug 11 13:33:15 2016 New Revision: 278379 URL: http://llvm.org/viewvc/llvm-project?rev=278379&view=rev Log: [Sema] Add more strict check for sizeof diagnostics for bzero Follow-up from r278264 after Joerg's feedback. Since bzero is not standard, be more strict: also check

Re: r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

Merged in r278376. Thanks, Hans On Thu, Aug 11, 2016 at 11:13 AM, Richard Smith wrote: > Well, the whole approach here is still wrong (per the FIXME in > CFGBuilder::addLocalScopeForVarDecl) but this at least makes it consistent. > Let's take this for 3.9 to at least stem the bleeding. > > > On

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

yaxunl marked an inline comment as done. yaxunl added a comment. In https://reviews.llvm.org/D23361#512729, @Anastasia wrote: > I think Clang is supposed to generate the IR specific to the target > architecture. It seems strange to ignore the pointer size. I am not sure if > it might lead to so

Re: [PATCH] D22515: [analyzer] Added custom hashing to the CloneDetector.

teemperor retitled this revision from "Added false-positive filter for unintended hash code collisions to the CloneDetector." to "[analyzer] Added custom hashing to the CloneDetector.". teemperor updated the summary for this revision. teemperor updated this revision to Diff 67715. teemperor added

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

Merged in r278374. Thanks, Hans On Thu, Aug 11, 2016 at 11:07 AM, Richard Smith wrote: > Yes, this should be merged. It's not quite right, but it's certainly better > than what we had before. > > On Mon, Aug 8, 2016 at 1:34 PM, Hans Wennborg wrote: >> >> Richard: ping? >> >> On Wed, Jul 27, 201

Re: [PATCH] D23322: [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and cl_amd_media_ops2

yaxunl added a comment. In https://reviews.llvm.org/D23322#512823, @Anastasia wrote: > Ok, sure. Is the plan to refactor this bit in case we implement the generic > support later then? > > It seems fine, although I can't check much without any documentation. Is > there any reference available o

Re: [PATCH] D23322: [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and cl_amd_media_ops2

Anastasia added a comment. Ok, sure. Is the plan to refactor this bit in case we implement the generic support later then? It seems fine, although I can't check much without any documentation. Is there any reference available online? https://reviews.llvm.org/D23322

Re: r277522 - [CFG] Fix crash finding destructor of lifetime-extended temporary.

Well, the whole approach here is still wrong (per the FIXME in CFGBuilder::addLocalScopeForVarDecl) but this at least makes it consistent. Let's take this for 3.9 to at least stem the bleeding. On Tue, Aug 9, 2016 at 11:57 AM, Hans Wennborg wrote: > For the record, this was for PR28666. > > Rich

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

zturner added a comment. In https://reviews.llvm.org/D23409#512745, @zturner wrote: > In https://reviews.llvm.org/D23409#512720, @aaron.ballman wrote: > > > Patch generally LGTM, though I wonder if there's a way we can add test > > coverage for this. > > > I'd imagine we can just enable the clan

Re: r276900 - [Sema] Teach getCurrentThisType to reconize lambda in in-class initializer

Yes, this should be merged. It's not quite right, but it's certainly better than what we had before. On Mon, Aug 8, 2016 at 1:34 PM, Hans Wennborg wrote: > Richard: ping? > > On Wed, Jul 27, 2016 at 4:46 PM, Hans Wennborg wrote: > > Should this be merged to 3.9? > > > > Thanks, > > Hans > > > >

Re: [PATCH] D23387: [Analyzer] Report found fields order in PaddingChecker.

alexshap added a comment. Thanks, your points regarding better formatting of the diagnostics / moving it into a note or fixit and using more stable sort are valid, i will update this diff today or tomorrow. Regarding the type name - i am not sure - for example for template specializations (for

Re: [PATCH] D23322: [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and cl_amd_media_ops2

yaxunl added a comment. In https://reviews.llvm.org/D23322#512732, @Anastasia wrote: > Is this related to our discussion on cfe-dev about the extensions and also > the earlier review you have created: https://reviews.llvm.org/D21698? Since that feature takes time to implement, we decide to add

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

zturner added inline comments. Comment at: lib/Driver/Driver.cpp:93 @@ +92,3 @@ + ArrayRef Args) { + auto Default = ToolChain::getTargetAndModeFromProgramName(ProgramName); + StringRef DefaultMode(Default.second); rnk wrote: > Why not

Re: [PATCH] D23167: emit_DW_AT_noreturn flag

aprantl added a comment. You are adding a new constant to the LLVM IR, so there should be a round-trip test that tests the LLVM IR parser, bitcode writer, bitcode reader, and LLVM IR printer to make sure we're handling the new constant correctly. One easy way to do this is by adding the new fla

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

zturner added inline comments. Comment at: lib/Tooling/JSONCompilationDatabase.cpp:119 @@ -115,1 +118,3 @@ StringRef EscapedCommandLine) { +#if defined(LLVM_ON_WIN32) + llvm::BumpPtrAllocator Alloc; rnk wrote: > It would be nice if the JSON file just told us

Re: [PATCH] D23168: emit_DW_AT_noreturn flag

aprantl added inline comments. Comment at: test/Frontend/dinoreturn.c:2 @@ +1,3 @@ +// RUN: %clang %s -c -std=c11 -emit-llvm -S -g -o - | FileCheck %s +// CHECK: DIFlagNoReturn +#include Please check for more context. For example: CHECK: !DISubprogram({{.*}}na

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

zturner added a comment. In https://reviews.llvm.org/D23409#512720, @aaron.ballman wrote: > Patch generally LGTM, though I wonder if there's a way we can add test > coverage for this. I'd imagine we can just enable the clang-tidy test suite on Windows (I'm assuming it's currently disabled).

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

rnk added inline comments. Comment at: lib/Driver/Driver.cpp:93 @@ +92,3 @@ + ArrayRef Args) { + auto Default = ToolChain::getTargetAndModeFromProgramName(ProgramName); + StringRef DefaultMode(Default.second); Why not change ToolInvoc

Re: [PATCH] D23322: [OpenCL] AMDGPU: Add extensions cl_amd_media_ops and cl_amd_media_ops2

Anastasia added a comment. Is this related to our discussion on cfe-dev about the extensions and also the earlier review you have created: https://reviews.llvm.org/D21698? https://reviews.llvm.org/D23322 ___ cfe-commits mailing list cfe-commits@lis

Re: [PATCH] D23361: [OpenCL] AMDGCN: Fix size_t type

Anastasia added a comment. I think Clang is supposed to generate the IR specific to the target architecture. It seems strange to ignore the pointer size. I am not sure if it might lead to some issues for the backends. Comment at: lib/CodeGen/CodeGenModule.cpp:107 @@ -106,2 +10

Re: [PATCH] D23409: Make clang-tidy work with clang-cl

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a comment. Patch generally LGTM, though I wonder if there's a way we can add test coverage for this. https://reviews.llvm.org/D23409 ___ cfe-commits mailing list cfe-commits@lists

  1   2   >