Author: abataev
Date: Tue Jul 19 00:06:39 2016
New Revision: 275947
URL: http://llvm.org/viewvc/llvm-project?rev=275947&view=rev
Log:
[OPENMP] Removed loop statement as its body executes at most once, NFC.
Removed not required loop statement, addressing comments from Richard
Smith.
Modified:
Author: abataev
Date: Mon Jul 18 23:21:09 2016
New Revision: 275945
URL: http://llvm.org/viewvc/llvm-project?rev=275945&view=rev
Log:
[OPENMP] Improved processing of 'priority' clause, NFC.
Removed some old comments + improved handling of 'priority' clause value
during codegen after comments from
> On Jul 18, 2016, at 8:23 PM, Tim Northover via cfe-commits
> wrote:
>
>>> Can't handle the update of the umbrella *because of GitHub*, this could be
>>> possible with our own hosting of git for instance.
>>>
>> Pre-commit hooks are not designed to update the umbrella. Webhooks will be
>> a
friss added inline comments.
Comment at: docs/Proposals/GitHub.rst:220
@@ +219,3 @@
+8. Tell people living downstream to pick up commits from the official git
+ repository.
+9. Give things time to settle. We could play some games like disabling the SVN
vsk wrote
>> Can't handle the update of the umbrella *because of GitHub*, this could be
>> possible with our own hosting of git for instance.
>>
> Pre-commit hooks are not designed to update the umbrella. Webhooks will be
> able to update the umbrella with a small external service, as proposed in the
> IR
vsk added subscribers: friss, vsk.
vsk added a comment.
@rengolin thanks for putting this together! I chimed in with some comments
in-line.
Comment at: docs/Proposals/GitHub.rst:68
@@ +67,3 @@
+ * Collaborate with peers directly, even without access to the Internet
+ * Have mul
dberris added a subscriber: dberris.
dberris added a comment.
Mostly wording comments, thank you for writing this up!
Comment at: docs/Proposals/GitHub.rst:78
@@ +77,3 @@
+
+GitHub, like GitLab and BitBucket, provide FREE code hosting for open source
+projects. Essentially, they
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22479
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D22487
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
Hey Hans,
I think that we should get this merged into 3.9. Its a trivial fix and
makes the script usable if you set g:clang_rename_path.
Thanks!
On Mon, Jul 18, 2016 at 7:13 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Mon Jul 18 21:13:
Author: compnerd
Date: Mon Jul 18 21:13:08 2016
New Revision: 275943
URL: http://llvm.org/viewvc/llvm-project?rev=275943&view=rev
Log:
clang-rename: fix referenced variable in vim-script
Modified:
clang-tools-extra/trunk/clang-rename/tool/clang-rename.py
Modified: clang-tools-extra/trunk/cla
ayartsev created this revision.
ayartsev added reviewers: zaks.anna, dcoughlin.
ayartsev added a subscriber: cfe-commits.
Hi all,
Currently if the path diagnostic consumer (e.g HTMLDiagnostics and
PlistDiagnostics) do not support cross file diagnostics then the path
diagnostic report is just si
jyknight added a subscriber: jyknight.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (hist
mehdi_amini added inline comments.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history,
pcc added a comment.
> An amendment to the Itanium ABI requiring that a conforming program may not
> adjust a virtual table pointer loaded from an object to another virtual table
> in the same virtual table group would seem to be all that would be required
> to guarantee that this scheme wil
rsmith added inline comments.
Comment at: include/clang/AST/Decl.h:1602
@@ -1601,2 +1601,3 @@
unsigned IsConstexpr : 1;
+ unsigned IsMarkedForPendingInstantiation : 1;
Drop the `MarkedFor` here. This flag *is* the mark from the point of view of a
user of th
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
@rnk, okay, that seems reasonable enough. Although, we should check to ensure
that the x64 toolchain is available and make a decision on that.
BTW, seems that I had missed the p
compnerd added inline comments.
Comment at: src/UnwindRegistersRestore.S:331
@@ +330,3 @@
+ ldr r4, [r0, #0x2c]
+ ldr r5, [r0, #0x30]
+ mov r8, r1
Is there a benefit to doing the explicit loading rather than a add + ldm?
Comment at: src/Unwind
On Mon, Jul 18, 2016 at 5:01 PM, Samuel Antao via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sfantao
> Date: Mon Jul 18 19:01:12 2016
> New Revision: 275931
>
> URL: http://llvm.org/viewvc/llvm-project?rev=275931&view=rev
> Log:
> Append clang system include path for offloading too
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Comment at: lib/Parse/ParseObjc.cpp:3489
@@ -3478,3 +3488,3 @@
-// Parse the ellipsis that designates this as a pack expansion.
-SourceLocati
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275931: Append clang system include path for offloading tool
chains. (authored by sfantao).
Changed prior to commit:
https://reviews.llvm.org/D22490?vs=64428&id=64432#toc
Repository:
rL LLVM
https:/
Fixed in r275931.
Thanks!
Samuel
- Original message -From: Artem Belevich To: Samuel F Antao/Watson/IBM@IBMUSCc: Richard Smith , Justin Lebar , cfe-commits Subject: Re: r275645 - [CUDA][OpenMP] Create generic offload actionDate: Mon, Jul 18, 2016 7:38 PM
On Mon, Jul 18, 2016 at 4:2
Author: sfantao
Date: Mon Jul 18 19:01:12 2016
New Revision: 275931
URL: http://llvm.org/viewvc/llvm-project?rev=275931&view=rev
Log:
Append clang system include path for offloading tool chains.
Summary:
This patch adds clang system include path when offloading tool chains, e.g.
CUDA, are used i
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
https://reviews.llvm.org/D22490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
sfantao updated this revision to Diff 64428.
sfantao added a comment.
- Add missing context for review.
https://reviews.llvm.org/D22490
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
===
--- lib/Driver/Tools.cpp
+++ lib
Art, Richard,
I posted https://reviews.llvm.org/D22490. Let me know if that is what you have in mind.
Thanks!
Samuel
- Original message -From: Artem Belevich To: Samuel F Antao/Watson/IBM@IBMUSCc: Richard Smith , Justin Lebar , cfe-commits Subject: Re: r275645 - [CUDA][OpenMP] Create
sfantao created this revision.
sfantao added reviewers: tra, rsmith.
sfantao added subscribers: cfe-commits, rsmith.
This patch adds clang system include path when offloading tool chains, e.g.
CUDA, are used in the current compilation.
This fixes an issue detected by @rsmith in response to r2756
davidsh created this revision.
davidsh added reviewers: carlo.bertolli, arpith-jacob, kkwli0, sfantao, ABataev.
davidsh added a subscriber: cfe-commits.
Clang misdiagnoses atomic captures cases that contains parens.
ie.
int v, int *p;
#pragma omp atomic capture
{ v = (*p); (*p)++; }
https://revie
rivanvx updated this revision to Diff 64417.
rivanvx added a comment.
Specifically handle only kernels.
https://reviews.llvm.org/D20168
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
Index: test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
===
delcypher added a subscriber: delcypher.
Comment at: docs/Proposals/GitHub.rst:102
@@ +101,3 @@
+
+How will the new workflow look like
+===
s/How will/What will/
Comment at: docs/Proposals/GitHub.rst:136
@@ +135,3
silvas updated this revision to Diff 64420.
silvas added a comment.
Rebase after r275507.
https://reviews.llvm.org/D21954
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/CodeGenOptions.h
lib/CodeGen/BackendUtil.cpp
lib/CodeGen/CMakeLists.txt
lib/Frontend/CompilerInvoc
Hi Richard,
Thanks for catching that! Fixed in r275930.
Thanks again,
Samuel
- Original message -From: Richard Smith Sent by: meta...@gmail.comTo: Samuel F Antao/Watson/IBM@IBMUSCc: cfe-commits Subject: Re: r263019 - [OpenMP] Add support for multidimensional array sections in map clau
Author: sfantao
Date: Mon Jul 18 18:22:11 2016
New Revision: 275930
URL: http://llvm.org/viewvc/llvm-project?rev=275930&view=rev
Log:
[OpenMP] Remove dead code in conditional of mappable expressions SEMA.
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/SemaOpenMP.cp
lattner added a subscriber: lattner.
lattner added a comment.
Please send this to llvm-dev for discussion when it converges, thanks!
https://reviews.llvm.org/D22463
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275926: [OpenMP] Fix incorrect diagnostics in map clause
(authored by kli).
Changed prior to commit:
https://reviews.llvm.org/D22075?vs=64353&id=64410#toc
Repository:
rL LLVM
https://reviews.llvm.or
Author: kli
Date: Mon Jul 18 17:49:16 2016
New Revision: 275926
URL: http://llvm.org/viewvc/llvm-project?rev=275926&view=rev
Log:
[OpenMP] Fix incorrect diagnostics in map clause
Having the following code pattern will result in incorrect diagnostic
int main() {
int arr[10];
#pragma omp target
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history, up
Author: rsmith
Date: Mon Jul 18 17:37:35 2016
New Revision: 275925
URL: http://llvm.org/viewvc/llvm-project?rev=275925&view=rev
Log:
Fix some minor issues found by Coverity.
Modified:
cfe/trunk/include/clang/AST/DeclCXX.h
cfe/trunk/lib/AST/ExprConstant.cpp
cfe/trunk/lib/AST/ItaniumMan
Author: vedantk
Date: Mon Jul 18 17:32:02 2016
New Revision: 275924
URL: http://llvm.org/viewvc/llvm-project?rev=275924&view=rev
Log:
[Coverage] Remove '..' from filenames *after* getting an absolute path
Failure to do this breaks relative paths which begin with '..'.
This issue was caught by th
davidsh created this revision.
davidsh added reviewers: carlo.bertolli, arpith-jacob, kkwli0, sfantao, ABataev.
davidsh added a subscriber: cfe-commits.
OpenMP 4.5 removed the restriction that array section lower bound must be non
negative.
This change is to allow negative values for array sectio
On Wed, Feb 26, 2014 at 4:25 PM, Ben Langmuir wrote:
> Author: benlangmuir
> Date: Wed Feb 26 18:25:12 2014
> New Revision: 202329
>
> URL: http://llvm.org/viewvc/llvm-project?rev=202329&view=rev
> Log:
> Add a 'use-external-names' option to VFS overlay files
>
> When true, sets the name of the f
rnk added a comment.
The approach makes sense to me, but the tests suggest it isn't doing what I'd
expect.
Comment at: test/CodeGenCXX/dllimport-rtti.cpp:7
@@ -6,3 +6,1 @@
} s;
-// MSVC: [[VF_S:.*]] = private unnamed_addr constant [2 x i8*]
-// MSVC-DAG: @"\01??_SS@@6B@" = unn
On Wed, Mar 9, 2016 at 7:46 AM, Samuel Antao via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sfantao
> Date: Wed Mar 9 09:46:05 2016
> New Revision: 263019
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263019&view=rev
> Log:
> [OpenMP] Add support for multidimensional array sect
majnemer added a comment.
Could you please attach a diff with additional context?
Comment at: lib/Driver/ToolChains.cpp:3717-3735
@@ -3678,1 +3716,21 @@
+ // We need a detected GCC installation on Linux to provide libstdc++'s
+ // headers. We handled the libc++ case above.
+
> On 2016-Jul-17, at 14:09, Eric Fiselier wrote:
>
> What I'm curious about if this performance regression was cause by (1) the
> removal of this 2 week old optimization or (2) the implementation of "fast
> mod". I suspect it's because of (1).
>
BTW, definitely from the 2 week old optimizati
mehdi_amini added inline comments.
Comment at: docs/Proposals/GitHub.rst:209
@@ +208,3 @@
+ well as a webhook to update the umbrella project (see below).
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history,
rsmith added a comment.
Interested reviewers, see also discussion here of whether we want this feature:
http://lists.llvm.org/pipermail/cfe-dev/2016-July/050040.html
https://reviews.llvm.org/D22474
___
cfe-commits mailing list
cfe-commits@lists.llv
rsmith added inline comments.
Comment at: lib/AST/Expr.cpp:1425
@@ +1424,3 @@
+
+ if (E->isTypeDependent() && isa(base)) {
+bool MemberOfCurrentInstantiation = true;
The language rule for this says nothing about the base being a `this`
expression; there are
rengolin updated this revision to Diff 64383.
rengolin added a comment.
Expand step 2 to make sure we don't forget about the safety hooks on each
project as well as the webhook to update the umbrella project. This could turn
out to be a buildbot, but makes no difference at this stage.
https://
bruno added a comment.
Ping!
https://reviews.llvm.org/D22183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Thanks, r275907.
https://reviews.llvm.org/D22248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vedantk
Date: Mon Jul 18 16:01:27 2016
New Revision: 275913
URL: http://llvm.org/viewvc/llvm-project?rev=275913&view=rev
Log:
[Coverage] Normalize '..' out of filename strings
This fixes the issue of having duplicate entries for the same file in a
coverage report s.t none of the entries a
mgehre created this revision.
mgehre added reviewers: klimek, aaron.ballman, rsmith.
mgehre added a subscriber: cfe-commits.
A MemberExpr is non-dependent if
1) it is a member of the current instantiation
2) the member is non-dependent
We check 1) by asserting that the base of the
MemberExpr is a
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:208
@@ +207,3 @@
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history, update, merges).
+4. Make sure bisecting with llvm-project works.
--
Hello everyone,
LLVM buildmaster will be updated and restarted after 7 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davide added a comment.
Richard, can you please take a look at this? The more I look at it the more it
seems weird that we can recurse in this case, but I may miss something
https://reviews.llvm.org/D20748
___
cfe-commits mailing list
cfe-commits@l
Author: bruno
Date: Mon Jul 18 15:37:06 2016
New Revision: 275907
URL: http://llvm.org/viewvc/llvm-project?rev=275907&view=rev
Log:
[Sema] Create a separate group for incompatible function pointer warning
Give incompatible function pointer warning its own diagnostic group
but still leave it as a
apaprocki updated this revision to Diff 64376.
https://reviews.llvm.org/D18360
Files:
lib/Basic/Targets.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
lib/Driver/Tools.cpp
lib/Driver/Tools.h
tools/libclang/CIndexer.cpp
Index: tools/libclang/CIndexer.cpp
Author: mehdi_amini
Date: Mon Jul 18 15:33:09 2016
New Revision: 275906
URL: http://llvm.org/viewvc/llvm-project?rev=275906&view=rev
Log:
Add missing header in ClangFuzzer (after r275882 cleanup)
Modified:
cfe/trunk/tools/clang-fuzzer/ClangFuzzer.cpp
Modified: cfe/trunk/tools/clang-fuzzer/Cl
bruno created this revision.
bruno added reviewers: rsmith, doug.gregor.
bruno added subscribers: cfe-commits, dexonsmith.
C++ static destructors can be problematic in multi-threaded environment. Some
of the issues users often complain about include:
1. Teardown ordering: crashes when one thread
apaprocki added inline comments.
Comment at: lib/Basic/Targets.cpp:718
@@ +717,3 @@
+Builder.defineMacro("_LONG_LONG");
+Builder.defineMacro("_ALL_SOURCE");
+Builder.defineMacro("_REENTRANT");
majnemer wrote:
> apaprocki wrote:
> > majnemer wrote:
> >
Author: bwilson
Date: Mon Jul 18 15:29:14 2016
New Revision: 275905
URL: http://llvm.org/viewvc/llvm-project?rev=275905&view=rev
Log:
Allow iOS and tvOS version numbers with 2-digit major version numbers.
rdar://problem/26921601
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/Dri
Author: marshall
Date: Mon Jul 18 15:27:19 2016
New Revision: 275904
URL: http://llvm.org/viewvc/llvm-project?rev=275904&view=rev
Log:
Bump version # to 4.0.0
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.org/viewvc/llvm-project/libcxx/trun
mgehre added a comment.
Friendly ping
https://reviews.llvm.org/D22069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added inline comments.
Comment at: docs/Proposals/GitHub.rst:208
@@ +207,3 @@
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account, with all necessary hooks (history, update, merges).
+4. Make sure bisecting with llvm-project works.
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:200
@@ +199,3 @@
+
+Here's a proposed plan:
+
You can click on the "<<" button and it will show where it was first inserted.
That's how I found out. :)
The hooks, AFAICS, will be added to the
omtcyfz added a comment.
Removed two `FIXME`s. Seems like types are now handled correctly. +1 test
passing.
https://reviews.llvm.org/D22465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
mehdi_amini added inline comments.
Comment at: docs/Proposals/GitHub.rst:199
@@ +198,3 @@
+
+Here's a proposed plan:
+
Annoyingly my comment does no longer show-up next to the point it was referring
to, it was about your third point:
> Make sure we have an llvm-
omtcyfz updated this revision to Diff 64374.
https://reviews.llvm.org/D22465
Files:
clang-rename/RenamingAction.cpp
clang-rename/USRFinder.cpp
clang-rename/USRLocFinder.cpp
test/clang-rename/ClassNameInFunctionDefenition.cpp
test/clang-rename/ComplicatedClassType.cpp
test/clang-rename
rengolin updated this revision to Diff 64373.
rengolin added a comment.
Removing "broken" to describe the history, just explaining it'll be local.
Expanding to mention that hooks will need to be implemented in step 3.
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: d
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:198
@@ +197,3 @@
+3. Make sure we have an llvm-project (with submodules) setup in the official
+ account.
+4. Make sure bisecting with llvm-project works.
mehdi_amini wrote:
> Uh, this point i
Thanks, I've merged the revert in r275902.
Cheers,
Hans
On Mon, Jul 18, 2016 at 12:06 PM, Devin Coughlin wrote:
> Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t
> get an email from the bot about the failure.
>
> Thanks
> Devin
>
> On Jul 18, 2016, at 11:59 AM, Hans
rengolin updated this revision to Diff 64371.
rengolin added a comment.
Second round of suggestions applied.
https://reviews.llvm.org/D22463
Files:
docs/Proposals/GitHub.rst
Index: docs/Proposals/GitHub.rst
===
--- /dev/null
+++
rengolin added inline comments.
Comment at: docs/Proposals/GitHub.rst:8-9
@@ +7,4 @@
+
+This is a proposal to move our current revision control system from Subversion
+to GitHub. Below are the financial and technical arguments as to why we need
+such a move and how will people (an
mehdi_amini added a subscriber: mehdi_amini.
Comment at: docs/Proposals/GitHub.rst:122
@@ +121,3 @@
+of understanding the *sequence* in which commits were added by using the
+``git rev-list --count hash`` or ``git describe hash`` commands.
+
filcab wrote:
> How ea
nandor updated this revision to Diff 64368.
nandor added a comment.
Fixed typo
https://reviews.llvm.org/D22419
Files:
lib/Analysis/CFG.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/warn-thread-safety-analysis.cpp
==
vsk added a comment.
Ping.
https://reviews.llvm.org/D7
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275895: [Driver] Compute effective target triples once per
job (NFCI) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D22290?vs=64023&id=64367#toc
Repository:
rL LLVM
https:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275894: [Driver] Make Driver::DefaultTargetTriple private
(NFCI) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D22289?vs=63756&id=64366#toc
Repository:
rL LLVM
https://rev
Author: vedantk
Date: Mon Jul 18 14:56:33 2016
New Revision: 275894
URL: http://llvm.org/viewvc/llvm-project?rev=275894&view=rev
Log:
[Driver] Make Driver::DefaultTargetTriple private (NFCI)
No in-tree targets access this `DefaultTargetTriple` directly, and usage
of default triples is generally d
Author: vedantk
Date: Mon Jul 18 14:56:38 2016
New Revision: 275895
URL: http://llvm.org/viewvc/llvm-project?rev=275895&view=rev
Log:
[Driver] Compute effective target triples once per job (NFCI)
Compute an effective target triple exactly once in ConstructJob(), and
then simply pass around refere
rsmith accepted this revision.
rsmith added a reviewer: rsmith.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
Thanks, I just checked out clang-tool-extras and was in the process of doing
that :)
—
Mehdi
> On Jul 18, 2016, at 12:21 PM, Benjamin Kramer via cfe-commits
> wrote:
>
> Author: d0k
> Date: Mon Jul 18 14:21:22 2016
> New Revision: 275886
>
> URL: http://llvm.org/viewvc/llvm-project?rev=2758
Author: d0k
Date: Mon Jul 18 14:21:22 2016
New Revision: 275886
URL: http://llvm.org/viewvc/llvm-project?rev=275886&view=rev
Log:
Unbreak extra tools build post r275882.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.cpp
clang-tools-extra/trunk/include-fixer/tool/ClangIncludeFixer
bcraig added a subscriber: bcraig.
Comment at: src/UnwindRegistersRestore.S:325
@@ -324,4 +324,3 @@
DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv)
-#if !defined(__ARM_ARCH_ISA_ARM)
- ldr r2, [r0, #52]
- ldr r3, [r0, #60]
+#if !defined(_
majnemer added inline comments.
Comment at: lib/Basic/Targets.cpp:718
@@ +717,3 @@
+Builder.defineMacro("_LONG_LONG");
+Builder.defineMacro("_ALL_SOURCE");
+Builder.defineMacro("_REENTRANT");
apaprocki wrote:
> majnemer wrote:
> > Are we really suppose
dcoughlin reopened this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Re-opening. Reverted in r275880. It was causing a failure on the bots:
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/51780
Repository:
rL LLVM
https://reviews.llvm.org/D1
Reverted in r275880. Sorry about that. I’ll have to investigate why I didn’t
get an email from the bot about the failure.
Thanks
Devin
> On Jul 18, 2016, at 11:59 AM, Hans Wennborg wrote:
>
> Oops, as you suspected I failed at copy/paste. This is the bot that's
> broken: http://bb.pgr.jp/build
weimingz added inline comments.
Comment at: src/UnwindRegistersRestore.S:326
@@ +325,3 @@
+#if !defined(__ARM_ARCH_ISA_ARM) && __ARM_ARCH_ISA_THUMB == 1
+ @ r8-r12: ldr into r1-r5, then mov to r8-r12
+ ldr r1, [r0, #0x20]
weimingz wrote:
> originally, r0-r7 get
Author: dcoughlin
Date: Mon Jul 18 13:57:50 2016
New Revision: 275880
URL: http://llvm.org/viewvc/llvm-project?rev=275880&view=rev
Log:
Revert "[analyzer] Add checker modeling potential C++ self-assignment"
This reverts commit r275820. It is failing on the bots.
Removed:
cfe/trunk/lib/Static
weimingz added inline comments.
Comment at: src/UnwindRegistersRestore.S:325
@@ -324,4 +324,3 @@
DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm20restoreCoreAndJumpToEv)
-#if !defined(__ARM_ARCH_ISA_ARM)
- ldr r2, [r0, #52]
- ldr r3, [r0, #60]
+#if !defined(__AR
Oops, as you suspected I failed at copy/paste. This is the bot that's
broken: http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/51780
On Mon, Jul 18, 2016 at 10:57 AM, Devin Coughlin wrote:
> Hans,
>
> I’m happy to revert — but I think r275820 is very unlikely to have been the
> root caus
apaprocki added inline comments.
Comment at: lib/Basic/Targets.cpp:718
@@ +717,3 @@
+Builder.defineMacro("_LONG_LONG");
+Builder.defineMacro("_ALL_SOURCE");
+Builder.defineMacro("_REENTRANT");
majnemer wrote:
> Are we really supposed to define this mac
ygao closed this revision.
ygao marked an inline comment as done.
ygao added a comment.
Closed by https://reviews.llvm.org/rL275877.
https://reviews.llvm.org/D22285
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
ygao marked an inline comment as done.
Comment at: lib/Driver/Tools.cpp:6379
@@ +6378,3 @@
+void ClangAs::AddX86TargetArgs(const ArgList &Args,
+ArgStringList &CmdArgs) const {
+ if (Arg *A = Args.getLastArg(options::OPT_masm_EQ)) {
---
Author: ygao
Date: Mon Jul 18 13:44:51 2016
New Revision: 275877
URL: http://llvm.org/viewvc/llvm-project?rev=275877&view=rev
Log:
Support -masm= flag for x86 assembly targets.
For assembly files without .intel_syntax or .att_syntax directives, allow the
-masm= flag to supply a default assembly d
Author: arsenm
Date: Mon Jul 18 13:42:17 2016
New Revision: 275874
URL: http://llvm.org/viewvc/llvm-project?rev=275874&view=rev
Log:
R600: Use new barrier intrinsic
Modified:
libclc/trunk/r600/lib/synchronization/barrier_impl.ll
Modified: libclc/trunk/r600/lib/synchronization/barrier_impl.ll
bruno added a subscriber: bruno.
Comment at: lib/Headers/cpuid.h:114
@@ -109,2 +113,3 @@
#define bit_AVX 0x1000
+#define bit_F16C0x2000
#define bit_RDRND 0x4000
Isn't this one also meant for gcc compat?
https://reviews.llvm.or
bruno added a subscriber: bruno.
bruno accepted this revision.
bruno added a reviewer: bruno.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM with one small fix, see below.
Comment at: lib/Driver/Tools.cpp:6379
@@ +6378,3 @@
+void ClangAs::AddX86Targ
1 - 100 of 179 matches
Mail list logo
