Author: dcoughlin
Date: Tue Jun 7 00:37:02 2016
New Revision: 271984
URL: http://llvm.org/viewvc/llvm-project?rev=271984&view=rev
Log:
Revert "[analyzer] Reapply r271907 (2nd try)."
Even with the fix in r271981, ASan is finding a stack use after return.
This reverts commits r271977 and r271981.
dcoughlin added a comment.
Fixed the compilation issues with gcc in r271977 r271981, but it is still
failing with Address Sanitizer diagnostics:
18751==ERROR: AddressSanitizer: stack-use-after-return on address
0x7f0c695ebc70 at pc 0x0867b44c bp 0x7ffe3b01d6f0 sp 0x7ffe3b01d6e8
Author: dcoughlin
Date: Mon Jun 6 23:44:52 2016
New Revision: 271981
URL: http://llvm.org/viewvc/llvm-project?rev=271981&view=rev
Log:
[analyzer] Speculative fix for r271907.
Fix a compilation error on the bots involving brace initialization.
Differential Revision: http://reviews.llvm.org/D1276
Author: pxl
Date: Mon Jun 6 23:34:00 2016
New Revision: 271978
URL: http://llvm.org/viewvc/llvm-project?rev=271978&view=rev
Log:
[OPENCL] Fix wrongly vla error for OpenCL array.
Summary:
OpenCL should support array with const value size length, those const
varibale in global and constant address
Author: dcoughlin
Date: Mon Jun 6 23:23:08 2016
New Revision: 271977
URL: http://llvm.org/viewvc/llvm-project?rev=271977&view=rev
Log:
[analyzer] Reapply r271907 (2nd try).
Second try at reapplying
"[analyzer] Add checker for correct usage of MPI API in C and C++."
Special thanks to Dan Liew fo
chapuni added a subscriber: chapuni.
chapuni added a comment.
FYI :)
--- a/clang/test/CoverageMapping/unused_function.cpp
+++ b/clang/test/CoverageMapping/unused_function.cpp
@@ -3,34 +3,34 @@
#define START_SCOPE {
#define END_SCOPE }
-// CHECK: _Z2f0v:
+// CHECK: {{_Z2f0v|\?f0
Author: ikudrin
Date: Mon Jun 6 23:11:51 2016
New Revision: 271976
URL: http://llvm.org/viewvc/llvm-project?rev=271976&view=rev
Log:
Revert [Coverage] Fix an assertion failure if the definition of an unused
function spans multiple files.
r271969 The test case fails on Windows.
Removed:
cfe
Author: pxl
Date: Mon Jun 6 22:41:07 2016
New Revision: 271975
URL: http://llvm.org/viewvc/llvm-project?rev=271975&view=rev
Log:
Revert "[OPENCL] Fix wrongly vla error for OpenCL array."
Test case break on system-z.
This reverts commit 9a7212e1e87f1396952d74f8c62314a775ccbb1c.
Removed:
cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271971: [OPENCL] Fix wrongly vla error for OpenCL array.
(authored by pxl).
Changed prior to commit:
http://reviews.llvm.org/D20090?vs=58932&id=59823#toc
Repository:
rL LLVM
http://reviews.llvm.org/
Author: pxl
Date: Mon Jun 6 22:13:39 2016
New Revision: 271971
URL: http://llvm.org/viewvc/llvm-project?rev=271971&view=rev
Log:
[OPENCL] Fix wrongly vla error for OpenCL array.
Summary:
OpenCL should support array with const value size length, those const varibale
in global and constant addres
pcc created this revision.
pcc added reviewers: mehdi_amini, kcc.
pcc added a subscriber: cfe-commits.
pcc added a dependency: D21053: IR: New representation for CFI and virtual call
optimization pass metadata..
Herald added a subscriber: mehdi_amini.
Depends on D21053
http://reviews.llvm.org/D2
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271969: [Coverage] Fix an assertion failure if the
definition of an unused function… (authored by ikudrin).
Changed prior to commit:
http://reviews.llvm.org/D20997?vs=59806&id=59818#toc
Repository:
r
Author: ikudrin
Date: Mon Jun 6 21:17:03 2016
New Revision: 271969
URL: http://llvm.org/viewvc/llvm-project?rev=271969&view=rev
Log:
[Coverage] Fix an assertion failure if the definition of an unused function
spans multiple files.
We have an assertion failure if, for example, the definition of
sugak added inline comments.
Comment at: clang-tidy/tool/clang-tidy-diff.py:42
@@ -41,3 +41,3 @@
help='path to clang-tidy binary')
parser.add_argument('-p', metavar='NUM', default=0,
help='strip the smallest prefix containing P slas
simon.f.whittaker added a reviewer: klimek.
simon.f.whittaker added a comment.
Added Manuel Klimek at Sean's suggestion.
http://reviews.llvm.org/D21047
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Comment at: clang-tidy/tool/clang-tidy-diff.py:42
@@ -41,3 +41,3 @@
help='path to clang-tidy binary')
parser.add_argument('-p', metavar='NUM', default=0,
help='strip the smallest pr
vsk abandoned this revision.
vsk added a comment.
I see your point that it isn't expensive to do a best-effort job here. I
updated docs/SourceBasedCodeCoverage.rst with a limitations section as per my
earlier comment.
http://reviews.llvm.org/D20878
__
sugak created this revision.
sugak added reviewers: klimek, alexfh.
sugak added a subscriber: cfe-commits.
Looks like the original code was copied from clang-format-diff.py.
Update help message to make it clang-tidy specific.
http://reviews.llvm.org/D21050
Files:
clang-tidy/tool/clang-tidy-dif
ikudrin added a comment.
I agree that it'd be expensive to put a new counter after each function call.
Even if there is no `throw` statement within a TU, called functions still may
raise exceptions.
Anyway, if we come across a `try` statement, we can guess that some exceptions
are expected and
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Overall this LGTM, but let Manuel or one of the other libTooling folks sign off.
Comment at: docs/LibASTMatchersTutorial.rst:46
@@ -45,3 +45,3 @@
cd ~/clang-llvm
Author: mps
Date: Mon Jun 6 19:27:37 2016
New Revision: 271966
URL: http://llvm.org/viewvc/llvm-project?rev=271966&view=rev
Log:
Improve Visual Studio visualization of DeclaratorDecl
With this change, you can now expand its name and type.
Modified:
cfe/trunk/utils/ClangVisualizers/clang.nat
simon.f.whittaker created this revision.
simon.f.whittaker added reviewers: silvas, bogner.
simon.f.whittaker added a subscriber: cfe-commits.
This patch fixes Bug 25583 as well as cleaning up some other problems in the
LibASTMatchersTutorial.
I've updated the tutorial to use:
'./configure.py —
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D20997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ikudrin updated the summary for this revision.
ikudrin removed rL LLVM as the repository for this revision.
ikudrin updated this revision to Diff 59806.
ikudrin added a comment.
- Use `StartFileID` and `EndFileID` variables to eliminate redundant calls to
`SM.getFileID()`.
- Add comment strings t
Hello everyone,
LLVM buildmaster will be updated and restarted after 6 PM Pacific time
today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hello everyone,
Below are some buildbot numbers for the last week of 5/29/2016 - 6/04/2016.
I added new statistics with a longest time each builder was red during the
last week.
Thanks
Galina
buildername| was_red
---
LGTM for branch. Please also merge r271893 to fix a test failure from this
change.
On Sun, Jun 5, 2016 at 12:29 PM, Joerg Sonnenberger via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi Tom,
> I'd like to merge this change for getting rid of the stupid '-pie is
> nont used' warnings and to
On 6/6/16, 3:58 PM, "meta...@gmail.com on behalf of Richard Smith"
wrote:
>On Mon, Jun 6, 2016 at 3:28 PM, Eric Niebler via cfe-commits
> wrote:
>>On 6/3/16, 4:13 PM, "tha...@google.com on behalf of Nico Weber"
>> wrote:
>>>On Fri, Jun 3, 2016 at 7:07 PM, Eric Niebler wrote:
On 6/3/16, 3:2
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271951: [CUDA] Add implicit conversion of __launch_bounds__
arguments to rvalue. (authored by tra).
Changed prior to commit:
http://reviews.llvm.org/D20985?vs=59778&id=59800#toc
Repository:
rL LLVM
Author: tra
Date: Mon Jun 6 17:54:57 2016
New Revision: 271951
URL: http://llvm.org/viewvc/llvm-project?rev=271951&view=rev
Log:
[CUDA] Add implicit conversion of __launch_bounds__ arguments to rvalue.
Fixes clang crash reported in PR27778.
Differential Revision: http://reviews.llvm.org/D20985
On Mon, Jun 6, 2016 at 3:28 PM, Eric Niebler via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 6/3/16, 4:13 PM, "tha...@google.com on behalf of Nico Weber" <
> tha...@google.com on behalf of tha...@chromium.org> wrote:
> >On Fri, Jun 3, 2016 at 7:07 PM, Eric Niebler wrote:
> >>On 6/3/16,
andreybokhanko added a comment.
In http://reviews.llvm.org/D18035#450247, @hfinkel wrote:
> The link was posted here:
> http://sourcerytools.com/pipermail/cxx-abi-dev/2016-June/002919.html - which
> is the mailing list where the C++ ABI specification is discussed.
Ah, I see... Dmitry told me
hintonda updated this revision to Diff 59794.
hintonda added a comment.
Update matcher to use functionProtoType instead of functionType.
http://reviews.llvm.org/D20693
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNoexceptC
On 6/3/16, 4:13 PM, "tha...@google.com on behalf of Nico Weber"
wrote:
>On Fri, Jun 3, 2016 at 7:07 PM, Eric Niebler wrote:
>>On 6/3/16, 3:24 PM, "tha...@google.com on behalf of Nico Weber"
>> wrote:
>>> On Fri, Jun 3, 2016 at 6:14 PM, Eric Niebler wrote:
I just checked, and warnings are
Author: mps
Date: Mon Jun 6 16:41:20 2016
New Revision: 271944
URL: http://llvm.org/viewvc/llvm-project?rev=271944&view=rev
Log:
Improved Visual Studio visualizations for template argument lists
Improved the visualizer for TemplateArgumentList to show type arguments in the
DisplayString.
E.g.,
vsk added a comment.
Thanks, this looks good overall. I just have a few minor comments.
Comment at: lib/CodeGen/CoverageMappingGen.cpp:329
@@ +328,3 @@
+ FileID ParentFile = SM.getFileID(Start);
+ while (ParentFile != SM.getFileID(End) && !isNestedIn(End, ParentFile))
rsmith added a comment.
Yes, I definitely want us to implement this for GCC compatibility. And now that
we have a specification for this feature, we can evaluate whether this is doing
the right thing. On that basis:
I still want this refactored so that the normally-mangled part of a function
n
hfinkel added a comment.
In http://reviews.llvm.org/D18035#450211, @andreybokhanko wrote:
> In http://reviews.llvm.org/D18035#448057, @hfinkel wrote:
>
> > We just received the first draft of that specification yesterday.
>
>
> Is this specification confidential?
The link was posted here:
http
andreybokhanko added a comment.
In http://reviews.llvm.org/D18035#448057, @hfinkel wrote:
> We just received the first draft of that specification yesterday.
Is this specification confidential? If not, why it hasn't been made available
in this code review? Most puzzlingly, why it hasn't been s
Hi Sam,
Thanks baring with me, and thanks a lot for your explanation! I indeed now
believe that this is correct; I got somewhat confused by all the macro magic
that is going on, and had missed that the enabled extensions are actually
stored in a class instance separate from the one with availab
zaks.anna added a comment.
> Specifically, I suspect that C (and maybe ObjC?) won't hit the analysis limit
> often, but that C++ will hit the
> limit frequently because of the large number of inline functions.
It might be valuable to know this. Maybe we should changer the default for C++?
>
On Wed, Jun 1, 2016 at 8:33 AM, pierre gousseau via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> pgousseau created this revision.
> pgousseau added reviewers: rsmith, thakis.
> pgousseau added subscribers: cfe-commits, wristow, probinson, gbedwell,
> bruno, cameron314.
>
> On Linux, if the t
bruno added inline comments.
Comment at: test/PCH/include-timestamp.cpp:8
@@ +7,3 @@
+// RUN: sleep 1
+// RUN: not %clang_cc1 -include-pch %t %s 2>&1 | FileCheck
-check-prefix=CHECK-TIMESTAMP %s
+
pgousseau wrote:
> Without the sleep the test fails for me, as it
arsenm added a comment.
ping
http://reviews.llvm.org/D17516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra marked an inline comment as done.
tra added a comment.
http://reviews.llvm.org/D20985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated this revision to Diff 59778.
tra added a comment.
Replaced if() with assert() to catch unexpected PerformCopyInitialization()
failures.
http://reviews.llvm.org/D20985
Files:
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCUDA/launch-bounds.cu
test/SemaCUDA/pr27778.cu
Index: test/Sema
Author: cbieneman
Date: Mon Jun 6 15:18:38 2016
New Revision: 271937
URL: http://llvm.org/viewvc/llvm-project?rev=271937&view=rev
Log:
[CMake] Fixing a typo in a CMake option
CMake defines are set with -D, forgetting the D doesn’t work.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified:
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Thank you for the quick turn-around!
Comment at: test/clang-tidy/misc-misplaced-const.c:20
@@ +19,3 @@
+ const volatile ip i4 = 0;
+ // CHECK-MESSAGES: :[[@LINE-1]]:21: warning: 'i4' declared with a
george.burgess.iv added a comment.
Ping :)
http://reviews.llvm.org/D17462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza added a comment.
I think this would be more interesting with macros.
Eg triggering in code like this:
#define FOO(type, op) const type& X = op()
FOO(int*, bar);
Comment at: clang-tidy/misc/MisplacedConstCheck.cpp:32
@@ +31,3 @@
+
+static QualType GuessAlternateQualif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271933: clang-rename: implement renaming of classes inside
static_cast (authored by vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D21012?vs=59695&id=59766#toc
Repository:
rL LLVM
http:/
Author: vmiklos
Date: Mon Jun 6 14:40:12 2016
New Revision: 271933
URL: http://llvm.org/viewvc/llvm-project?rev=271933&view=rev
Log:
clang-rename: implement renaming of classes inside static_cast
"Derived" in static_cast(...) wasn't renamed, nor in its
pointer equivalent.
Reviewers: klimek
Dif
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza, hokein.
aaron.ballman added a subscriber: cfe-commits.
Sometimes it's easy for developers to not notice that the type they are working
with is a typedef type to a pointer and add a const-qualifier that applies to
yaxunl marked 2 inline comments as done.
yaxunl added a comment.
In http://reviews.llvm.org/D20681#448443, @Anastasia wrote:
> Do you think we could add any test for this change?
We have prelinking passes in amdgpu backend but it requires the llvm change to
be committed first. We can add a tes
yaxunl marked 4 inline comments as done.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash %s |
Author: aaronballman
Date: Mon Jun 6 13:52:17 2016
New Revision: 271927
URL: http://llvm.org/viewvc/llvm-project?rev=271927&view=rev
Log:
Adding an AST matcher to ignore parenthesis in *types* (rather than
expressions). This is required for traversing certain types (like function
pointer types)
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
It'll be good idea to mention improvement in docs/ReleaseNotes.rst.
Please close PR23198 after commit.
http://reviews.llvm.org/D21020
___
cfe-commits mailing list
c
bcraig added a comment.
I'll try to get those stats. My suspicion is that it is highly language /
projects specific. Specifically, I suspect that C (and maybe ObjC?) won't hit
the analysis limit often, but that C++ will hit the limit frequently because of
the large number of inline functions.
Author: dcoughlin
Date: Mon Jun 6 13:29:43 2016
New Revision: 271920
URL: http://llvm.org/viewvc/llvm-project?rev=271920&view=rev
Log:
Revert "Reapply "[analyzer] Add checker for correct usage of MPI API in C and
C++.""
This reverts commit r271914. It is still breaking bots.
Removed:
cfe/t
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Landed as revision 271919
http://reviews.llvm.org/D20922
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: marshall
Date: Mon Jun 6 13:24:08 2016
New Revision: 271919
URL: http://llvm.org/viewvc/llvm-project?rev=271919&view=rev
Log:
Rename some test data (and make it const) to rid us of some shadowing warnings
in the test suite. No functional change. Thanks to STL@microsoft for the report
an
Author: rafael
Date: Mon Jun 6 13:23:11 2016
New Revision: 271918
URL: http://llvm.org/viewvc/llvm-project?rev=271918&view=rev
Log:
Add a release note about the --build-id change.
Modified:
cfe/trunk/docs/ReleaseNotes.rst
Modified: cfe/trunk/docs/ReleaseNotes.rst
URL:
http://llvm.org/viewv
Author: dcoughlin
Date: Mon Jun 6 13:08:35 2016
New Revision: 271914
URL: http://llvm.org/viewvc/llvm-project?rev=271914&view=rev
Log:
Reapply "[analyzer] Add checker for correct usage of MPI API in C and C++."
Reapply r271907 with a fix for the compiler error with gcc about specializing
clang::
timshen added a comment.
I'm looking at some internal test failures caused by this patch.
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin added a comment.
This doesn't compile under gcc so it broke the bots. The fix is to move the
specialization of clang::ento::ProgramStateTrait for RequestMapImpl out of the
global namespace and into clang::ento. I will apply and recommit.
Repository:
rL LLVM
http://reviews.llvm.org
Author: mps
Date: Mon Jun 6 12:23:37 2016
New Revision: 271911
URL: http://llvm.org/viewvc/llvm-project?rev=271911&view=rev
Log:
Fix typo in last submission to visualize proper template argument
Modified:
cfe/trunk/utils/ClangVisualizers/clang.natvis
Modified: cfe/trunk/utils/ClangVisualize
ashi1 created this revision.
ashi1 added a reviewer: Anastasia.
ashi1 added subscribers: yaxunl, cfe-commits, pxli168, bader, rsmith, nhaustov.
Allow -cl-std and other standard -cl- options from cc1 to driver.
Added a test for the options moved.
http://reviews.llvm.org/D21031
Files:
include/c
hintonda updated this revision to Diff 59747.
hintonda added a comment.
Use FunctionProtoType instead of auto for clarity.
http://reviews.llvm.org/D20687
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal.h
unit
Author: mps
Date: Mon Jun 6 12:08:32 2016
New Revision: 271910
URL: http://llvm.org/viewvc/llvm-project?rev=271910&view=rev
Log:
Better Visual Studio visualization of TemplateArgument and TemplateArgumentList
For pack TemplateArguments, visualize all of the items in the pack
Visualize a Template
Author: dcoughlin
Date: Mon Jun 6 12:01:08 2016
New Revision: 271909
URL: http://llvm.org/viewvc/llvm-project?rev=271909&view=rev
Log:
Revert "[analyzer] Add checker for correct usage of MPI API in C and C++."
This reverts commit r271907. It broke a bunch of bots with compile errors
about specia
vitalybuka added a comment.
Is anything blocking us on this review?
http://reviews.llvm.org/D20499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL271907: [analyzer] Add checker for correct usage of MPI API
in C and C++. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D12761?vs=54001&id=59742#toc
Repository:
rL LLVM
h
Author: dcoughlin
Date: Mon Jun 6 11:47:16 2016
New Revision: 271907
URL: http://llvm.org/viewvc/llvm-project?rev=271907&view=rev
Log:
[analyzer] Add checker for correct usage of MPI API in C and C++.
This commit adds a static analysis checker to check for the correct usage of the
MPI API in C a
erik.pilkington created this revision.
erik.pilkington added a reviewer: rsmith.
erik.pilkington added a subscriber: cfe-commits.
Clang rejects the following valid code:
```
template struct Foo {};
template using FooAlias = Foo;
template int bar(FooAlias);
int main() { bar(FooAlias<>()); }
```
Anastasia added inline comments.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash %s | FileChec
Anastasia added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7882
@@ -7881,1 +7881,3 @@
"multiple access qualifiers">;
+def warn_default_access_qualifier : Warning<
+ "missing access qualifier: assuming read_only">,
I am not sure why
aaron.ballman added a comment.
This is looking good, aside from a few small nits. The only question I have
remaining is whether this should be on FunctionProtoType or FunctionType? I
think being on FunctionProtoType (how you have it) is preferable. @sbenza or
@klimek, do you agree?
==
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
append newline after code when inserting new headers at the end of the
code which does not end with newline.
http://reviews.llvm.org/D21026
Files:
lib/Form
Author: vedantk
Date: Mon Jun 6 10:44:40 2016
New Revision: 271902
URL: http://llvm.org/viewvc/llvm-project?rev=271902&view=rev
Log:
[docs] Clarify limitations section of SourceBasedCodeCoverage.rst
Mention that the code coverage tool becomes less precise whenever
unpredictable changes in contro
> On Jun 4, 2016, at 6:28 PM, Sean Silva wrote:
>
>
>
> On Thu, Jun 2, 2016 at 10:19 AM, Vedant Kumar via cfe-commits
> wrote:
> Author: vedantk
> Date: Thu Jun 2 12:19:45 2016
> New Revision: 271544
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271544&view=rev
> Log:
> [docs] Add a lim
peter.smith added a comment.
That looks correct to me. Certainly armebelf_linux_eabi is not recognised on a
recent ld.
Comment at: lib/Driver/Tools.cpp:9098
@@ -9097,3 +9097,3 @@
case llvm::Triple::thumbeb:
-return "armebelf_linux_eabi"; /* TODO: check which NAME. */
+
yaxunl marked 5 inline comments as done.
yaxunl added a comment.
Ping
Xiuli, could you please take a look? Thanks.
http://reviews.llvm.org/D20133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 59733.
yaxunl marked 8 inline comments as done.
yaxunl added a comment.
Update the diagnositic msg for fblocks.
http://reviews.llvm.org/D20444
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/B
yaxunl added inline comments.
Comment at: test/Headers/opencl-c-header.cl:50
@@ +49,3 @@
+// RUN: %clang_cc1 -cc1 -triple spir-unknown-unknown -emit-llvm -o -
-finclude-default-header -fmodules -fimplicit-module-maps
-fmodules-cache-path=%t -fdisable-module-hash %s | FileCheck %
Anastasia accepted this revision.
Anastasia added a comment.
LGTM!
http://reviews.llvm.org/D20133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
Two more nits, looks good otherwise :)
Comment at: docs/include-fixer.rst:73
@@ +72,3 @@
+
+You can custonmize the number of headers being showed by setting
+``let g:clang_i
hokein updated this revision to Diff 59725.
hokein marked 3 inline comments as done.
hokein added a comment.
Add comments.
http://reviews.llvm.org/D20467
Files:
docs/ReleaseNotes.rst
docs/include-fixer.rst
Index: docs/include-fixer.rst
==
hintonda updated this revision to Diff 59726.
hintonda added a comment.
Update narrowing matchers, isNoThrow and hasDynamicExceptionSpec, to
work with both functionDecl and functionProtoType matchers. Update
tests and regenerate documentation.
Since FunctionDecl and FunctionProtoType are not pol
bkramer added inline comments.
Comment at: docs/ReleaseNotes.rst:47
@@ -46,2 +46,3 @@
-- Feature1...
+- :program:`clang-include-fixer`, a tool provides an automated way of adding
+ ``#include`` directives for missing symbols in one translation unit.
a tool **th
dsanders created this revision.
dsanders added a reviewer: atanasyan.
dsanders added a subscriber: cfe-commits.
Herald added a subscriber: sdardis.
The validity of ABI/CPU pairs is no longer checked on the fly but is
instead checked after initialization. As a result, invalid CPU/ABI pairs
can be r
ioeric updated this revision to Diff 59722.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Addressed reviewer's comments.
http://reviews.llvm.org/D21019
Files:
include-fixer/tool/clang-include-fixer.py
Index: include-fixer/tool/clang-include-fixer.py
=
hokein added a comment.
In http://reviews.llvm.org/D20467#435685, @Eugene.Zelenko wrote:
> Could you please mention include-fixer in docs/ReleaseNotes.rst? This is
> definitely major new feature in upcoming release.
Done.
http://reviews.llvm.org/D20467
___
hokein updated this revision to Diff 59721.
hokein marked an inline comment as done.
hokein added a comment.
Address review comments.
http://reviews.llvm.org/D20467
Files:
docs/ReleaseNotes.rst
docs/include-fixer.rst
Index: docs/include-fixer.rst
===
spetrovic created this revision.
spetrovic added reviewers: rafael, petarj.
spetrovic added subscribers: rankov, ivanbaev, cfe-commits.
Herald added subscribers: rengolin, aemerson.
This patch fixes target linker emulation for arm 32 big endian. As I saw in gcc
only supported linker emulation is
Author: sbenza
Date: Mon Jun 6 09:21:11 2016
New Revision: 271896
URL: http://llvm.org/viewvc/llvm-project?rev=271896&view=rev
Log:
[clang-tidy] Do not try to suggest a fix if the parameter is partially in a
macro.
It is not easy to tell where to do the suggestion and whether the
suggestion wil
Author: marshall
Date: Mon Jun 6 09:35:22 2016
New Revision: 271897
URL: http://llvm.org/viewvc/llvm-project?rev=271897&view=rev
Log:
Remove arithmetic +/-127 on chars; results in UB when dealing with signed
chars. Thanks to STL@microsoft for the report.
Modified:
libcxx/trunk/test/std/str
hokein added inline comments.
Comment at: include-fixer/tool/clang-include-fixer.py:53
@@ +52,3 @@
+ except Exception:
+if res == '':
+ # choose the top ranked header by default
We can handle the ` ` , `a`, `q` cases after `res=vim.eval(to_eval)` instead
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D21021
Files:
include/clang/Basic/BuiltinsX86.def
lib/Headers/avx512fintrin.h
test/CodeGen/avx512f-builtins.c
Index: test/CodeGen/
JamesReynolds created this revision.
JamesReynolds added a reviewer: alexfh.
JamesReynolds added a subscriber: cfe-commits.
Added support for macro definitions.
--
1. Added a pre-processor callback to catch macro definitions
2. Changed the type of the failure map so that macros and declarations c
Author: joerg
Date: Mon Jun 6 08:13:12 2016
New Revision: 271893
URL: http://llvm.org/viewvc/llvm-project?rev=271893&view=rev
Log:
Give FileCheck a hint on which ld to match. Under Windows, the preferred
match was the ld.elf_so that should be matched in a second step. Add one
of the ever-present-
1 - 100 of 127 matches
Mail list logo
