Author: ericwf
Date: Tue Apr 19 23:17:39 2016
New Revision: 266855
URL: http://llvm.org/viewvc/llvm-project?rev=266855&view=rev
Log:
Add cxx_runtime_root options for testing against a different libc++ at runtime
Modified:
libcxx/trunk/docs/TestingLibcxx.rst
libcxx/trunk/test/libcxx/test/c
Author: abataev
Date: Tue Apr 19 23:01:36 2016
New Revision: 266853
URL: http://llvm.org/viewvc/llvm-project?rev=266853&view=rev
Log:
[OPENMP] Codegen for untied tasks.
If the untied clause is present on a task construct, any thread in the
team can resume the task region after a suspension. Patch
EricWF added a comment.
It seems my changes to the IO headers removes a bunch of symbols from the
dylib. I'll look into it. I'm assuming it's because clang was already ignoring
the "_LIBCPP_INLINE_VISIBILITY" attribute when instantiating extern templates.
The symbols get removed even if we don'
EricWF added a comment.
I've updated the diff so it merges and also fixed , ,
and . It can be found here:
https://gist.github.com/EricWF/487e5b1de2bb320e93fbb3c9c758b013
Repository:
rL LLVM
http://reviews.llvm.org/D15404
___
cfe-commits mailin
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/libcxx/test/config.py:367
@@ -366,2 +366,3 @@
self.cxx.compile_flags.extend(sysroot_flags)
+ self.cxx.compile_flags.append("-ferror-limit
Author: tejohnson
Date: Tue Apr 19 21:23:52 2016
New Revision: 266852
URL: http://llvm.org/viewvc/llvm-project?rev=266852&view=rev
Log:
Enable ODR uniquing of DITypes for ThinLTO backends
Summary:
This is a follow-on to apply Duncan's new DIType ODR uniquing from
r266549 and r266713 in more place
EricWF resigned from this revision.
EricWF removed a reviewer: EricWF.
EricWF added a comment.
This revision now requires review to proceed.
This is done.
http://reviews.llvm.org/D16360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: ericwf
Date: Tue Apr 19 21:21:33 2016
New Revision: 266851
URL: http://llvm.org/viewvc/llvm-project?rev=266851&view=rev
Log:
[libcxx] Fix PR15638 - Only allocate in parent when starting a thread to
prevent calling terminate.
Summary:
Hi,
When creating a new thread libc++ performs at lea
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting.
http://reviews.llvm.org/D13748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
EricWF abandoned this revision.
EricWF added a comment.
Another solution has been committed.
http://reviews.llvm.org/D11329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mgrang
Date: Tue Apr 19 20:02:18 2016
New Revision: 266843
URL: http://llvm.org/viewvc/llvm-project?rev=266843&view=rev
Log:
[Clang] Remove unwanted --check-prefix=CHECK from unit tests. NFC.
Summary:
Removed unwanted --check-prefix=CHECK from the following unit tests:
test/CXX/
Author: srhines
Date: Tue Apr 19 19:33:06 2016
New Revision: 266840
URL: http://llvm.org/viewvc/llvm-project?rev=266840&view=rev
Log:
MarkEOLs should only be true for clang-cl.exe.
Summary:
https://llvm.org/bugs/show_bug.cgi?id=27396
This fixes an issue in response files where "\r\n" was being i
davidxl added a comment.
I like the direction this patch is going. Will look into details soon.
http://reviews.llvm.org/D19299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ericwf
Date: Tue Apr 19 19:14:32 2016
New Revision: 266836
URL: http://llvm.org/viewvc/llvm-project?rev=266836&view=rev
Log:
Add 'is_callable' and 'is_nothrow_callable' traits and cleanup INVOKE.
The primary purpose of this patch is to add the 'is_callable' traits.
Since 'is_nothrow_calla
Thanks!
On Tue, Apr 19, 2016 at 11:58 AM Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Committed a test in r266796.
>
> On Tue, Apr 19, 2016 at 11:42 AM, Justin Lebar wrote:
> >> I don't really understand why having to change the test when we change
> the code it test chang
spatel created this revision.
spatel added reviewers: hfinkel, davidxl, bkramer.
spatel added a subscriber: cfe-commits.
Herald added subscribers: mcrosier, aemerson.
__builtin_expect() is a GCC-derived builtin that's used as a hint for branch
prediction:
https://gcc.gnu.org/onlinedocs/gcc/Other-
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a nit.
In http://reviews.llvm.org/D19146#403234, @alexfh wrote:
> In http://reviews.llvm.org/D19146#402414, @alexfh wrote:
>
> > In http://reviews.llvm.org/D19146#402410, @alex
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good with a couple of nits. Thank you!
Comment at: clang-tidy/misc/SuspiciousStringCompareCheck.cpp:25
@@ +24,3 @@
+
+static const char *KnownStringCompareFunctions = "_
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good! Thank you for the cleanup!
http://reviews.llvm.org/D19200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
vsk created this revision.
vsk added a reviewer: davidxl.
vsk added a subscriber: cfe-commits.
**Summary**
Using memory-mapped profile counters makes it possible to take snapshots of a
running process's profiling information without changing the program. This is
useful if the process exits abno
Author: anemet
Date: Tue Apr 19 17:29:24 2016
New Revision: 266829
URL: http://llvm.org/viewvc/llvm-project?rev=266829&view=rev
Log:
[Parse] Reuse OptionUnroll rather than matching it again. NFC
Modified:
cfe/trunk/lib/Parse/ParsePragma.cpp
Modified: cfe/trunk/lib/Parse/ParsePragma.cpp
URL:
Author: anemet
Date: Tue Apr 19 17:17:45 2016
New Revision: 266827
URL: http://llvm.org/viewvc/llvm-project?rev=266827&view=rev
Log:
[Parse] Use StringSwitch to improve readability. NFC
A subsequent patch will propose a "distribute" loop hint. Similarly to
unroll, this does not have a "assume_sa
anemet added a comment.
Sure, I'll try.
Also sounds like you are missing a test in this patch that fails with the old
version but passes with the new?!
http://reviews.llvm.org/D18624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
xur updated this revision to Diff 54275.
xur added a comment.
Previous patch was bad (as David noticed) -- we might not annotate all the
functions that we interested.
This updated patch should work.
BTW, I got the following promotions for 453.provay:
LLVM gold plugin: csg.cpp:157:15: Promote i
michael_miller added a comment.
In http://reviews.llvm.org/D19270#405805, @alexfh wrote:
> LG. Do you need me to submit the patch?
Yeah, that's be awesome—thanks!
http://reviews.llvm.org/D19270
___
cfe-commits mailing list
cfe-commits@lists.llvm.
alexfh accepted this revision.
alexfh added a comment.
LG. Do you need me to submit the patch?
http://reviews.llvm.org/D19270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dschuff updated this revision to Diff 54274.
dschuff marked 2 inline comments as done.
dschuff added a comment.
- Clean up condition, add ARM to test
- Clarify condition, remove redundant check
- more cleanup
http://reviews.llvm.org/D19275
Files:
lib/CodeGen/CGDeclCXX.cpp
test/CodeGenCXX/ru
alexfh added inline comments.
Comment at: test/clang-tidy/boost-use-to-string.cpp:2
@@ +1,3 @@
+// RUN: %check_clang_tidy %s boost-use-to-string %t
+
+
nit: Remove one empty line.
http://reviews.llvm.org/D18136
___
alexfh added a comment.
FYI, an alternative fix has been submitted in http://reviews.llvm.org/D19231.
Please check whether it fixes the issue.
http://reviews.llvm.org/D18136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
alexfh abandoned this revision.
alexfh added a comment.
Ok, let's drop this on the floor.
http://reviews.llvm.org/D19144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apelete marked an inline comment as done.
apelete added a comment.
http://reviews.llvm.org/D19278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apelete updated this revision to Diff 54269.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Following changes were done since last revision:
- lib/Sema/SemaOverload.cpp: avoid interleaving (FromExpr) and
(!FromExpr->isLValue()) conditions in if() state
jfb added a comment.
lgtm besides two nits. Would be good to get a review from @t.p.northover or
someone from ARM.
Comment at: lib/CodeGen/CGDeclCXX.cpp:95
@@ +94,3 @@
+ Record->getDestructor(), Dtor_Complete));
+ // If __cxa_atexit is disable
dschuff added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:92
@@ +91,3 @@
+ // disabled via a flag, a different helper function is generated anyway.
+ const CXXRecordDecl *Record = type->getAsCXXRecordDecl();
+ bool CanRegisterDestructor = Record &&
j
dschuff updated this revision to Diff 54264.
dschuff added a comment.
- Clarify condition, remove redundant check
http://reviews.llvm.org/D19275
Files:
lib/CodeGen/CGDeclCXX.cpp
test/CodeGenCXX/runtimecc.cpp
test/CodeGenCXX/static-destructor.cpp
Index: test/CodeGenCXX/static-destructor.c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266817: [AArch64] Fix D19098 fallout. (authored by koriakin).
Changed prior to commit:
http://reviews.llvm.org/D19099?vs=53667&id=54254#toc
Repository:
rL LLVM
http://reviews.llvm.org/D19099
Files:
Author: koriakin
Date: Tue Apr 19 15:51:00 2016
New Revision: 266817
URL: http://llvm.org/viewvc/llvm-project?rev=266817&view=rev
Log:
[AArch64] Fix D19098 fallout.
The intrinsic is now called llvm.thread.pointer, not
llvm.aarch64.thread.pointer. Also, the code handling it in CGBuiltin.cpp
is de
jfb added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:92
@@ +91,3 @@
+ // disabled via a flag, a different helper function is generated anyway.
+ const CXXRecordDecl *Record = type->getAsCXXRecordDecl();
+ bool CanRegisterDestructor = Record &&
Can y
Author: bcraig
Date: Tue Apr 19 16:07:30 2016
New Revision: 266820
URL: http://llvm.org/viewvc/llvm-project?rev=266820&view=rev
Log:
XFAILing new test on C++03
initializer_list doesn't exist in C++03.
Modified:
libcxx/trunk/test/std/utilities/utility/synopsis.pass.cpp
Modified: libcxx/trunk
dschuff updated this revision to Diff 54260.
dschuff marked 3 inline comments as done.
dschuff added a comment.
- Clean up condition, add ARM to test
http://reviews.llvm.org/D19275
Files:
lib/CodeGen/CGDeclCXX.cpp
test/CodeGenCXX/runtimecc.cpp
test/CodeGenCXX/static-destructor.cpp
Index:
rjmccall added inline comments.
Comment at: lib/Sema/SemaOverload.cpp:9191
@@ -9189,1 +9190,3 @@
+ ToTy->isLValueReferenceType() &&
+ !FromExpr->isLValue() &&
ToTy.getNonReferenceType().getCanonicalType() ==
Interleaving
rsmith added a comment.
Generally-speaking, I think this is looking really good. I think we need to be
careful and precise in how we document this new visibility notion; most of my
comments are on that.
I wonder if we'd benefit from a diagram in the documentation showing the
nesting levels bet
Author: adrian
Date: Tue Apr 19 15:31:19 2016
New Revision: 266814
URL: http://llvm.org/viewvc/llvm-project?rev=266814&view=rev
Log:
cc1as: Don't crash when CIE is requested and no DWARF version is specified.
This patch changes the default DWARF version for cc1as from invalid 0 to 2,
which should
bcraig closed this revision.
bcraig added a comment.
Test added. r266808
http://reviews.llvm.org/D19280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: mprobst
Date: Tue Apr 19 13:19:06 2016
New Revision: 266790
URL: http://llvm.org/viewvc/llvm-project?rev=266790&view=rev
Log:
reuse mustBeJSIdent for interface detection
Modified:
cfe/trunk/lib/Format/UnwrappedLineParser.cpp
Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp
URL:
Author: bcraig
Date: Tue Apr 19 15:13:55 2016
New Revision: 266808
URL: http://llvm.org/viewvc/llvm-project?rev=266808&view=rev
Log:
Include initializer_list from utility
The C++11 and C++14 standards both say in the header synopsis that
shall include .
Added:
libcxx/trunk/test/std/utiliti
Author: mprobst
Date: Tue Apr 19 13:18:59 2016
New Revision: 266789
URL: http://llvm.org/viewvc/llvm-project?rev=266789&view=rev
Log:
clang-format: [JS] support `interface` as a free standing identifier.
Summary:
`interface` can be used as a fee standing identifier in JavaScript/TypeScript.
This
mgrang added a comment.
LGTM.
Could you please check who owns the files you modified and then add a couple of
reviewers. You can try "git blame " or check CODE_OWNERS.TXT file to
get the owners.
http://reviews.llvm.org/D19278
___
cfe-commits maili
apelete marked an inline comment as done.
apelete added a comment.
http://reviews.llvm.org/D19278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apelete updated this revision to Diff 54246.
apelete added a comment.
[scan-build] fix logic error warnings emitted on clang code base
Following changes were done since last revision:
- fix a typo in lib/Sema/SemaDeclCXX.cpp: decalration ==> declaration.
http://reviews.llvm.org/D19278
Files:
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
Could you commit this with a new test
`test/std/utilities/utility/synopsis.pass.cpp` which checks for the presence of
initializer list?
http://reviews.llvm.org/D19280
_
bcraig created this revision.
bcraig added reviewers: mclow.lists, EricWF, howard.hinnant.
bcraig added a subscriber: cfe-commits.
The C++11 and C++14 standards both say in the header synopsis that
shall include .
http://reviews.llvm.org/D19280
Files:
include/utility
Index: include/utility
Author: ab
Date: Tue Apr 19 14:44:45 2016
New Revision: 266807
URL: http://llvm.org/viewvc/llvm-project?rev=266807&view=rev
Log:
[ARM NEON] Define vfms_f32 on ARM, and all vfms using vfma.
r259537 added vfma/vfms to armv7, but the builtin was only lowered
on the AArch64 side. Instead of supportin
mgrang added a subscriber: mgrang.
Comment at: lib/Sema/SemaDeclCXX.cpp:438
@@ +437,3 @@
+ assert(New && "New function decalration is NULL, aborting merge.");
+ assert(Old && "Old function decalration is NULL, aborting merge.");
+
typo: decalration ==> declarati
yaxunl updated the summary for this revision.
yaxunl updated this revision to Diff 54243.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Added __OPENCL_C_VERSION__ and CL_VERSION_X_Y for all OpenCL versions.
Also fixed the test using -std=c99 for OpenCL and limit allowed languag
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266803: Fixed a bug in AnnotatedLine::startsWith when there
are comments in the line. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D19106?vs=54240&id=54242#toc
Repository:
r
apelete added a comment.
Ping :).
Can someone help this one find its way into he main repo ?
http://reviews.llvm.org/D19084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: ioeric
Date: Tue Apr 19 14:25:33 2016
New Revision: 266803
URL: http://llvm.org/viewvc/llvm-project?rev=266803&view=rev
Log:
Fixed a bug in AnnotatedLine::startsWith when there are comments in the line.
Summary: When there are comments in the line, one token may be checked multiple
times
ioeric updated this revision to Diff 54240.
ioeric marked an inline comment as done.
ioeric added a comment.
- nit fixed
http://reviews.llvm.org/D19106
Files:
lib/Format/TokenAnnotator.h
Index: lib/Format/TokenAnnotator.h
===
--
apelete created this revision.
apelete added a subscriber: cfe-commits.
This partch fixes a few "Logic error" warnings of the type "Called c++
object pointer is null" reported by Clang Static Analyzer on the
following files:
- lib/AST/ExprConstant.cpp,
- lib/CodeGen/CGDebugInfo.cpp,
- lib/CodeGen
Author: mren
Date: Tue Apr 19 14:05:03 2016
New Revision: 266800
URL: http://llvm.org/viewvc/llvm-project?rev=266800&view=rev
Log:
ObjC Class Property: don't emit class properties on old deployment targets.
For old deployment targets, emit nil for all class property lists.
rdar://25616128
Modif
Author: dougk
Date: Tue Apr 19 13:55:53 2016
New Revision: 266797
URL: http://llvm.org/viewvc/llvm-project?rev=266797&view=rev
Log:
Fix PR26999 better- RenderDebugEnablingArgs() once only
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/
Committed a test in r266796.
On Tue, Apr 19, 2016 at 11:42 AM, Justin Lebar wrote:
>> I don't really understand why having to change the test when we change the
>> code it test changes...
>
> My thought was, this code isn't really testing how we detect a CUDA
> installation. That's a separate m
Author: jlebar
Date: Tue Apr 19 13:52:28 2016
New Revision: 266796
URL: http://llvm.org/viewvc/llvm-project?rev=266796&view=rev
Log:
[CUDA] Add a test for r266496 (raise an error if a CUDA installation isn't
found)
Added:
cfe/trunk/test/Driver/cuda-not-found.cu
Added: cfe/trunk/test/Driver/
Author: eugenezelenko
Date: Tue Apr 19 13:49:21 2016
New Revision: 266795
URL: http://llvm.org/viewvc/llvm-project?rev=266795&view=rev
Log:
[Clang-tidy] Fix extra semicolon warning in
cppcoreguidelines/ProTypeMemberInitCheck.cpp.
Modified:
clang-tools-extra/trunk/clang-tidy/cppcoreguideline
> I don't really understand why having to change the test when we change the
> code it test changes...
My thought was, this code isn't really testing how we detect a CUDA
installation. That's a separate matter, involving --cuda-path,
various default locations we check, and so on.
Anyway I now s
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Format/TokenAnnotator.h:128
@@ +127,3 @@
+ bool startsWithInternal(const FormatToken *Tok, A K1) const {
+// Even though we skip comments in
PING.
On Thu, Apr 14, 2016 at 1:52 PM Eric Liu wrote:
> ioeric updated this revision to Diff 53691.
> ioeric added a comment.
>
> - Addressed reviewer comment.
>
>
> http://reviews.llvm.org/D19106
>
> Files:
> lib/Format/TokenAnnotator.h
>
> Index: lib/Format/TokenAnnotator.h
> ===
I don't really understand why having to change the test when we change the
code it test changes...
We have several fake install trees in the driver tests to check pretty much
exactly these kinds of things?
On Tue, Apr 19, 2016 at 11:31 AM Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org>
mprobst marked an inline comment as done.
Comment at: unittests/Format/FormatTestJS.cpp:339
@@ +338,3 @@
+TEST_F(FormatTestJS, AsyncFunctions) {
+ verifyFormat("async function f() {\n"
+ " let x = 1;\n"
djasper wrote:
> Fundamentally, I think there
Yes, in general our testing story around the CUDA installs needs work.
In particular, our wrapper headers are complicated and fragile, and
have zero coverage at the moment. That's why Art is working on
getting CUDA tests into the test-suite.
It's possible to test this particular change without ac
ioeric updated this revision to Diff 54233.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Rebased
- Make Formatter and Cleaner inherit from TokenAnalyzer (new name for
CodeProcessor).
http://reviews.llvm.org/D18551
Files:
include/clang/Format/Format.h
lib/Format/Affect
djasper added inline comments.
Comment at: unittests/Format/FormatTestJS.cpp:339
@@ +338,3 @@
+TEST_F(FormatTestJS, AsyncFunctions) {
+ verifyFormat("async function f() {\n"
+ " let x = 1;\n"
Fundamentally, I think there is two things we might need
jfb added inline comments.
Comment at: lib/CodeGen/CGDeclCXX.cpp:94
@@ -92,2 +93,3 @@
if (dtorKind == QualType::DK_cxx_destructor &&
- (record = type->getAsCXXRecordDecl())) {
+ (record = type->getAsCXXRecordDecl()) &&
+ (!CGM.getCXXABI().HasThisReturn(
-
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266789: clang-format: [JS] support `interface` as a free
standing identifier. (authored by mprobst).
Changed prior to commit:
http://reviews.llvm.org/D19240?vs=54218&id=54232#toc
Repository:
rL LLVM
Author: spatel
Date: Tue Apr 19 13:17:34 2016
New Revision: 266788
URL: http://llvm.org/viewvc/llvm-project?rev=266788&view=rev
Log:
[builtin_expect] tighten checks, add test, add comments
Modified:
cfe/trunk/test/CodeGen/builtin-expect.c
Modified: cfe/trunk/test/CodeGen/builtin-expect.c
URL
This commit is missing a test.
On Fri, Apr 15, 2016 at 5:16 PM Justin Lebar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jlebar
> Date: Fri Apr 15 19:11:11 2016
> New Revision: 266496
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266496&view=rev
> Log:
> [CUDA] Raise an error
dschuff added a reviewer: sunfish.
dschuff added a comment.
Will want a reviewer who's involved with ARM too, still looking.
http://reviews.llvm.org/D19275
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
dschuff created this revision.
dschuff added a subscriber: cfe-commits.
Herald added subscribers: dschuff, jfb, aemerson.
For a static object with a nontrivial destructor, clang generates an
initializer function (__cxx_global_var_init) which registers that
object's destructor using __cxa_atexit. H
Author: spatel
Date: Tue Apr 19 13:06:33 2016
New Revision: 266787
URL: http://llvm.org/viewvc/llvm-project?rev=266787&view=rev
Log:
reduce indentation; NFCI
Modified:
cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenFunction.cpp
URL:
http://llvm.org/viewvc/l
mgrang added a subscriber: mgrang.
Comment at: lib/Driver/Tools.cpp:580
@@ -573,1 +579,3 @@
+ if (IsIAMCU)
+getToolChain().AddIAMCUIncludeArgs(Args, CmdArgs);
}
Is it better to move this above in the else part of the condition "if
(!IsIAMCU)"?
This revision was automatically updated to reflect the committed changes.
Closed by commit rL266784: [CodeGen] Widen non-power-of-2 vector HFA base
types. (authored by ab).
Changed prior to commit:
http://reviews.llvm.org/D18998?vs=53336&id=54224#toc
Repository:
rL LLVM
http://reviews.llvm.
Author: ab
Date: Tue Apr 19 12:54:24 2016
New Revision: 266783
URL: http://llvm.org/viewvc/llvm-project?rev=266783&view=rev
Log:
[CodeGen] Fix whitespace. NFC.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/viewvc/llvm-proj
Author: ab
Date: Tue Apr 19 12:54:29 2016
New Revision: 266784
URL: http://llvm.org/viewvc/llvm-project?rev=266784&view=rev
Log:
[CodeGen] Widen non-power-of-2 vector HFA base types.
Currently, for the ppc64--gnu and aarch64 ABIs, we recognize:
typedef __attribute__((__ext_vector_type__(3))) fl
aturetsk created this revision.
aturetsk added reviewers: rsmith, bruno, bkramer.
aturetsk added subscribers: cfe-commits, DavidKreitzer, zinovy.nis.
This is the second patch required to support compilation for Intel MCU target
(e.g. Intel(R) Quark(TM) micro controller D 2000).
When IAMCU triple
Author: dougk
Date: Tue Apr 19 12:43:54 2016
New Revision: 266775
URL: http://llvm.org/viewvc/llvm-project?rev=266775&view=rev
Log:
Pass dwarf-version to cc1as.
Fix PR26999 - crashing in cc1as with any '*bsd' target.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/test/Driver/save-tem
Author: eugenezelenko
Date: Tue Apr 19 12:31:58 2016
New Revision: 266770
URL: http://llvm.org/viewvc/llvm-project?rev=266770&view=rev
Log:
[Release Notes] Mention Clang-tidy misc-unused-using-decls check.
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/tr
t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.
Sorry, I thought I'd already commented here. It looked good to me too.
Tim.
http://reviews.llvm.org/D18998
___
cfe-commits mailing
rsmith added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:6437-6445
@@ +6436,11 @@
+ // Warn immediately if -Wshadow-field-in-constructor is set.
+ Diag(R.getNameLoc(), diag::warn_ctor_parm_shadows_field)
+ << D << FD << FD->getParent();
+ Diag(FD->ge
Author: spatel
Date: Tue Apr 19 12:13:14 2016
New Revision: 266765
URL: http://llvm.org/viewvc/llvm-project?rev=266765&view=rev
Log:
reduce indentation; NFCI
Modified:
cfe/trunk/lib/CodeGen/CGStmt.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/tr
yaxunl marked 7 inline comments as done.
Comment at: lib/Frontend/InitPreprocessor.cpp:421
@@ +420,3 @@
+switch (LangOpts.OpenCLVersion) {
+case 0:
+case 100:
yaxunl wrote:
> pxli168 wrote:
> > What is 0 stand for as OpenCLVersion, it seems the default
Author: mzuckerm
Date: Tue Apr 19 12:10:29 2016
New Revision: 266763
URL: http://llvm.org/viewvc/llvm-project?rev=266763&view=rev
Log:
[Clang][Builtin][AVX512] Adding intrinsics for VGETMANT{PD|PS} and
VGETEXP{PD|PS} instruction set
Differential Revision: http://reviews.llvm.org/D19197
Modifie
ab added a comment.
Thanks Ulrich. Tim?
http://reviews.llvm.org/D18998
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sbenza added a comment.
> > We can proceed with this change if you want, but it is not required
> > anymore. I don't know whether we need the extra complexity of
> > `TemplateArgumentLess`.
>
>
> If this patch is not going to help with performance, I'm happy to abandon it.
It might help i
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D19240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
mprobst updated this revision to Diff 54218.
mprobst added a comment.
- reuse mustBeJSIdent for interface detection
http://reviews.llvm.org/D19240
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJS.cpp
Index: unittests/Format/FormatTestJS.cpp
==
mprobst marked an inline comment as done.
mprobst added a comment.
http://reviews.llvm.org/D19240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc added a comment.
@rsmith Ping.
http://reviews.llvm.org/D18635
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
http://reviews.llvm.org/D19270
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
anemet added a comment.
Thanks, the indirect call is via the All_Intersections macro in
All_CSG_Intersect_Intersections and the top targets are:
All_Sphere_Intersections and All_Plane_Intersections.
http://reviews.llvm.org/D18624
___
cfe-commits m
1 - 100 of 160 matches
Mail list logo
