Re: [PATCH] D18073: Add memory allocating functions

ariccio added a comment. In http://reviews.llvm.org/D18073#393613, @zaks.anna wrote: > You will have to add one test function to smoke test that the newly added API > is modeled correctly. Isn't that what I've already done? > We also have a lot of existing tests that verify that each of the o

r265640 - Basic: thread CodeGenOptions into TargetInfo

Author: compnerd Date: Thu Apr 7 00:41:11 2016 New Revision: 265640 URL: http://llvm.org/viewvc/llvm-project?rev=265640&view=rev Log: Basic: thread CodeGenOptions into TargetInfo This threads CodeGenOptions into the TargetInfo hierarchy. This is motivated by ARM which can change some target inf

Re: r263686 - Reapply [2]: [VFS] Add support for handling path traversals

Sure, I'll tackle this soon! On Wed, Apr 6, 2016 at 6:59 PM, Sean Silva wrote: > > > On Wed, Mar 16, 2016 at 7:20 PM, Bruno Cardoso Lopes via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: bruno >> Date: Wed Mar 16 21:20:43 2016 >> New Revision: 263686 >> >> URL: http://llvm.org

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Didn't notice that yield an error, thanks again Sean! On Wed, Apr 6, 2016 at 7:04 PM, Sean Silva wrote: > > > On Wed, Apr 6, 2016 at 6:56 PM, Sean Silva wrote: > >> >> >> On Wed, Apr 6, 2016 at 6:10 PM, Bruno Cardoso Lopes via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Attempt t

Re: [PATCH] D18852: [clang-tidy] fix a crash with -fdelayed-template-parsing in UnnecessaryValueParamCheck.

etienneb added a comment. There are probably other instances of this error. It's not an instance that got incorrectly fixed. I may review other checkers to see if I can find more of them. For now, I'm fixing them when they make clang-tidy crash over chromium code (with a clang-tidy windows buil

Re: [PATCH] D18852: [clang-tidy] fix a crash with -fdelayed-template-parsing in UnnecessaryValueParamCheck.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. That we've had to fix this twice now tells me that our collective memory is forgetful :). We need to collect the community wisdom for `clang-tidy` gotchas somewhere in the docs... http://reviews.llvm.o

r265634 - Don't use PATH_MAX.

Author: silvas Date: Wed Apr 6 20:58:14 2016 New Revision: 265634 URL: http://llvm.org/viewvc/llvm-project?rev=265634&view=rev Log: Don't use PATH_MAX. This is a SmallVector anyway, and so the exact size doesn't matter. clang\lib\Frontend\ModuleDependencyCollector.cpp(83) : error C2065: 'PATH_M

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

On Wed, Apr 6, 2016 at 6:56 PM, Sean Silva wrote: > > > On Wed, Apr 6, 2016 at 6:10 PM, Bruno Cardoso Lopes via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Attempt to fix in r265630. >> > > Did you ever fix PATH_MAX? > I've fixed it in r265634. -- Sean Silva > >> >> On Wed, Apr 6,

Re: r263686 - Reapply [2]: [VFS] Add support for handling path traversals

On Wed, Mar 16, 2016 at 7:20 PM, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bruno > Date: Wed Mar 16 21:20:43 2016 > New Revision: 263686 > > URL: http://llvm.org/viewvc/llvm-project?rev=263686&view=rev > Log: > Reapply [2]: [VFS] Add support for handling pa

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

On Wed, Apr 6, 2016 at 6:10 PM, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Attempt to fix in r265630. > Did you ever fix PATH_MAX? > > On Wed, Apr 6, 2016 at 5:51 PM, Bruno Cardoso Lopes < > bruno.card...@gmail.com> wrote: > >> Thanks Hans, taking a look! >> >> O

Re: [PATCH] D18172: [CUDA][OpenMP] Add a generic offload action builder

sfantao updated this revision to Diff 52881. sfantao updated the summary for this revision. sfantao added a comment. Rebase. http://reviews.llvm.org/D18172 Files: include/clang/Driver/Compilation.h lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp =

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

sfantao marked 8 inline comments as done. sfantao added a comment. Hi Eric, Thanks for the review! As you are probably a aware, I started partitioning this patch following your initial concern related with the size of this patch and the feedback I got from http://lists.llvm.org/pipermail/cfe-d

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

sfantao added a comment. Hi Art, Justin, Thanks for the review and feedback! Tried to address your concerns. Let me know other suggestion you may have. Thanks again, Samuel Comment at: include/clang/Driver/Action.h:95 @@ +94,3 @@ + /// same host. Therefore, the host offloadi

Re: [PATCH] D18171: [CUDA][OpenMP] Create generic offload action

sfantao updated this revision to Diff 52879. sfantao marked 15 inline comments as done. sfantao added a comment. Address Art, Justin and Eric comments. http://reviews.llvm.org/D18171 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Driver.h li

Re: [PATCH] D18170: [CUDA][OpenMP] Create generic offload toolchains

sfantao added a comment. Hi Art, Thanks for the the review! Comment at: include/clang/Driver/Action.h:79 @@ +78,3 @@ +OFFLOAD_None = 0x00, +OFFLOAD_CUDA = 0x01, + }; tra wrote: > Nit: All-caps CUDA looks weird here. _Cuda may be better choice. > If you

[PATCH] D18852: [clang-tidy] fix a crash with -fdelayed-template-parsing in UnnecessaryValueParamCheck.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. This is the same kind of bug that [[ http://reviews.llvm.org/D18238 | D18238 ]]. Fix crashes caused by deferencing null pointer when declarations parsing may be delayed. The body of the

Re: [PATCH] D18170: [CUDA][OpenMP] Create generic offload toolchains

sfantao updated this revision to Diff 52878. sfantao marked 6 inline comments as done. sfantao added a comment. Address Art and Eric comments. http://reviews.llvm.org/D18170 Files: include/clang/Driver/Action.h include/clang/Driver/Compilation.h include/clang/Driver/Driver.h lib/Driver/

Re: [PATCH] D18618: [ObjC] Pop all cleanups created in CodeGenFunction::EmitObjCForCollectionStmt

rjmccall added a comment. LGTM, thanks! http://reviews.llvm.org/D18618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r265630 - [CrashReproducer] Change std::toupper to ::toupper

Better yet. Committed r265632 Thanks Sean, On Wed, Apr 6, 2016 at 6:11 PM, Sean Silva wrote: > We also have toUppercase in include/clang/Basic/CharInfo.h > > -- Sean Silva > > On Wed, Apr 6, 2016 at 6:04 PM, Bruno Cardoso Lopes via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author:

r265632 - [CrashReproducer] Use toUppercase from include/clang/Basic/CharInfo.h

Author: bruno Date: Wed Apr 6 20:12:18 2016 New Revision: 265632 URL: http://llvm.org/viewvc/llvm-project?rev=265632&view=rev Log: [CrashReproducer] Use toUppercase from include/clang/Basic/CharInfo.h Use toUppercase instead of ::toupper() Modified: cfe/trunk/lib/Frontend/ModuleDependencyCo

Re: r265630 - [CrashReproducer] Change std::toupper to ::toupper

We also have toUppercase in include/clang/Basic/CharInfo.h -- Sean Silva On Wed, Apr 6, 2016 at 6:04 PM, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bruno > Date: Wed Apr 6 20:04:09 2016 > New Revision: 265630 > > URL: http://llvm.org/viewvc/llvm-project?r

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Attempt to fix in r265630. On Wed, Apr 6, 2016 at 5:51 PM, Bruno Cardoso Lopes wrote: > Thanks Hans, taking a look! > > On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg wrote: > >> On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits >> wrote: >> > Author: bruno >> > Date: Wed Apr

r265630 - [CrashReproducer] Change std::toupper to ::toupper

Author: bruno Date: Wed Apr 6 20:04:09 2016 New Revision: 265630 URL: http://llvm.org/viewvc/llvm-project?rev=265630&view=rev Log: [CrashReproducer] Change std::toupper to ::toupper Attempt to fix windows bots Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp Modified: cfe/tru

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Thanks Hans, taking a look! On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg wrote: > On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits > wrote: > > Author: bruno > > Date: Wed Apr 6 19:00:57 2016 > > New Revision: 265622 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=2656

Re: [PATCH] D18073: Add memory allocating functions

ariccio updated this revision to Diff 52876. ariccio added a comment. Fewer added test functions. http://reviews.llvm.org/D18073 Files: llvm/tools/clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp llvm/tools/clang/test/Analysis/malloc.c Index: llvm/tools/clang/test/Analysis/malloc.c

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits wrote: > Author: bruno > Date: Wed Apr 6 19:00:57 2016 > New Revision: 265622 > > URL: http://llvm.org/viewvc/llvm-project?rev=265622&view=rev > Log: > [CrashReproducer] Setup 'case-sensitive' in YAML files. This doesn't compile

[PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno created this revision. bruno added reviewers: rsmith, benlangmuir, klimek. bruno added subscribers: aprantl, dexonsmith, cfe-commits. The reproducer script (generated by the crash reproducer) invokes clang and tries to rebuild modules using the headers in the .cache/vfs directory. Depending

r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Author: bruno Date: Wed Apr 6 19:00:57 2016 New Revision: 265622 URL: http://llvm.org/viewvc/llvm-project?rev=265622&view=rev Log: [CrashReproducer] Setup 'case-sensitive' in YAML files. The crash reproducer was not setting up case sensitivity in the VFS yaml files, which defaults to true. Make

r265621 - [CrashReproducer] Move ModuleDependencyCollector method around. NFC

Author: bruno Date: Wed Apr 6 19:00:42 2016 New Revision: 265621 URL: http://llvm.org/viewvc/llvm-project?rev=265621&view=rev Log: [CrashReproducer] Move ModuleDependencyCollector method around. NFC Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp Modified: cfe/trunk/lib/Front

r265617 - NFC: use AtomicOrdering isStrongerThan

Author: jfb Date: Wed Apr 6 18:37:36 2016 New Revision: 265617 URL: http://llvm.org/viewvc/llvm-project?rev=265617&view=rev Log: NFC: use AtomicOrdering isStrongerThan Summary: As discussed in D18775. Reviewers: jyknight Differential Revision: http://reviews.llvm.org/D18840 Modified: cfe/

Re: [PATCH] D18843: Always have clang pass -pie-level and -pic-level values to the code generator

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm There are similar flags, like -O, which define preprocessor macros and get fed to the backend. In that case, we actually have duplicate LangOpts and CodeGenOpts. I don't think we need to do th

r265616 - Keep -fmodule-implementation-of as an alias of -fmodule-name.

Author: mren Date: Wed Apr 6 18:28:26 2016 New Revision: 265616 URL: http://llvm.org/viewvc/llvm-project?rev=265616&view=rev Log: Keep -fmodule-implementation-of as an alias of -fmodule-name. This helps us transitioning to -fmodule-name. Once the transitioning is done, we can remove this alias.

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

> On Apr 6, 2016, at 2:56 PM, David Blaikie wrote: > > > > On Wed, Apr 6, 2016 at 8:44 AM, Adrian Prantl > wrote: > >> On Apr 6, 2016, at 8:16 AM, David Blaikie > > wrote: >> >> >> >> On Tue, Apr 5, 2016 at 10:17 PM, Eric Christopher vi

[PATCH] D18843: Always have clang pass -pie-level and -pic-level values to the code generator

tmsriram created this revision. tmsriram added reviewers: rnk, davidxl. tmsriram added a subscriber: cfe-commits. clang does not pass pie-level and pic-level option values to the code generator with "-x ir" due to the following code in CompilerInvocation.cpp: if (DashX == IK_AST || DashX == I

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

etienneb updated this revision to Diff 52856. etienneb added a comment. rebased. http://reviews.llvm.org/D18783 Files: clang-tidy/misc/MisplacedWideningCastCheck.cpp Index: clang-tidy/misc/MisplacedWideningCastCheck.cpp === ---

Re: [PATCH] D18540: [Sema] Note when we've actually encountered a failure in ExprConstant, and take that into account when looking up objects.

george.burgess.iv added inline comments. Comment at: lib/AST/ExprConstant.cpp:853-854 @@ -825,5 +852,4 @@ Info.EvalStatus.Diag = NewDiag; // If we're speculatively evaluating, we may have skipped over some // evaluations and missed out a side effect. } --

Re: [PATCH] D15031: CFG: Add CFGElement for automatic variables that leave the scope

mgehre added inline comments. Comment at: include/clang/Analysis/CFG.h:170 @@ -168,1 +169,3 @@ +class CFGAutomaticObjLeavesScope : public CFGElement { +public: rsmith wrote: > What is this intended to model? There seem to be a few options here: > > 1) The poin

Re: [PATCH] D18540: [Sema] Note when we've actually encountered a failure in ExprConstant, and take that into account when looking up objects.

george.burgess.iv updated this revision to Diff 52834. george.burgess.iv marked 7 inline comments as done. george.burgess.iv added a comment. Addressed feedback http://reviews.llvm.org/D18540 Files: lib/AST/ExprConstant.cpp test/SemaCXX/builtin-object-size-cxx14.cpp test/SemaCXX/constant-

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

On Wed, Apr 6, 2016 at 8:44 AM, Adrian Prantl wrote: > > On Apr 6, 2016, at 8:16 AM, David Blaikie wrote: > > > > On Tue, Apr 5, 2016 at 10:17 PM, Eric Christopher via llvm-commits < > llvm-comm...@lists.llvm.org> wrote: > >> echristo added inline comments. >> >> >> Comment at:

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

Prazek updated this revision to Diff 52855. Prazek added a comment. Added new test cases http://reviews.llvm.org/D18821 Files: clang-tidy/modernize/BoolToIntegerConversionCheck.cpp clang-tidy/modernize/BoolToIntegerConversionCheck.h clang-tidy/modernize/CMakeLists.txt clang-tidy/moderni

Buildbot numbers for the week of 3/27/2016 - 4/02/2016

Hello everyone, Below are some buildbot numbers for the last week of 3/27/2016 - 4/02/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

Buildbot numbers for the week of 3/20/2016 - 3/26/2016

Hello everyone, Below are some buildbot numbers for the week of 3/20/2016 - 3/26/2016. Thanks Galina "Status change ratio" by active builder (percent of builds that changed the builder status from greed to red or from red to green): buildername

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

Prazek updated this revision to Diff 52851. Prazek marked an inline comment as done. http://reviews.llvm.org/D18821 Files: clang-tidy/modernize/BoolToIntegerConversionCheck.cpp clang-tidy/modernize/BoolToIntegerConversionCheck.h clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/Mod

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

Okay, weird. So the DICompileUnit wouldn't even get written out to bitcode, IIUC. LGTM then. > On 2016-Apr-06, at 14:31, Adrian Prantl wrote: > > aprantl added a comment. > > Duncan: There already exists a verifier check that ensures each DICompileUnit > is listed in llvm.dbg.cu. > This didn

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

aprantl added a comment. Duncan: There already exists a verifier check that ensures each DICompileUnit is listed in llvm.dbg.cu. This didn't break existing users of sample-based profiling, because the Verifier cannot *find* the orphaned DICompileUnits. After the DISubprogram / DICompileUnit poi

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

mnbvmar added a comment. This check throws a warning also on the conversion to floats (probably very rare ones): double number = true; Even though this behavior is correct, the code warns about the implicit conversion to **integers**. Comment at: docs/ReleaseNotes.rst:119

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

staronj updated this revision to Diff 52843. staronj added a comment. 1. Adds newline at the end of modernize-use-bool-literals.rst file. 2. Change names in check test for better readability. 3. Adds some new test cases. http://reviews.llvm.org/D18745 Files: clang-tidy/modernize/CMakeLists.tx

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

mnbvmar added a comment. You could also think whether char literals should be converted to true/false, too. Apart from this (and other people's doubts), everything's fine. http://reviews.llvm.org/D18745 ___ cfe-commits mailing list cfe-commits@list

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

krystyna added a comment. lgtm http://reviews.llvm.org/D18745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r265359 - Set the default C standard to C99 when targeting the PS4.

I've had to revert this in r265601 because it was breaking the PS4 bots. In the future, please keep an eye on them! It's a total bummer leaving them red for 2 days. http://lab.llvm.org:8011/waterfall?builder=llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast&builder=llvm-clang-lld-x86_64-scei-ps4-windows

r265601 - Revert "Set the default C standard to C99 when targeting the PS4."

Author: silvas Date: Wed Apr 6 16:06:52 2016 New Revision: 265601 URL: http://llvm.org/viewvc/llvm-project?rev=265601&view=rev Log: Revert "Set the default C standard to C99 when targeting the PS4." This reverts r265359. It breaks - llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast - llvm-clang-lld-x8

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

Prazek marked an inline comment as done. Prazek added a comment. In http://reviews.llvm.org/D18821#393556, @mnbvmar wrote: > This check throws a warning also on the conversion to floats (probably very > rare ones): > > double number = true; > > > Even though this behavior is correct, the code

r265599 - [modules] Add forgotten test case to r265597.

Author: vvassilev Date: Wed Apr 6 15:58:12 2016 New Revision: 265599 URL: http://llvm.org/viewvc/llvm-project?rev=265599&view=rev Log: [modules] Add forgotten test case to r265597. Added: cfe/trunk/test/Modules/Inputs/PR27186/ cfe/trunk/test/Modules/Inputs/PR27186/Rtypes.h cfe/trunk/

r265598 - Fix order-of-evaluation bug (causing GCC buildbots to fail).

Author: rsmith Date: Wed Apr 6 15:57:53 2016 New Revision: 265598 URL: http://llvm.org/viewvc/llvm-project?rev=265598&view=rev Log: Fix order-of-evaluation bug (causing GCC buildbots to fail). Modified: cfe/trunk/lib/Serialization/ASTWriterStmt.cpp Modified: cfe/trunk/lib/Serialization/ASTW

r265597 - [modules] Don't try to add lookup results to non-lookup contexts.

Author: vvassilev Date: Wed Apr 6 15:56:03 2016 New Revision: 265597 URL: http://llvm.org/viewvc/llvm-project?rev=265597&view=rev Log: [modules] Don't try to add lookup results to non-lookup contexts. Fixes https://llvm.org/bugs/show_bug.cgi?id=27186 Patch reviewed by Richard Smith. Modified:

r265594 - Minor simplifications.

Author: rsmith Date: Wed Apr 6 15:12:34 2016 New Revision: 265594 URL: http://llvm.org/viewvc/llvm-project?rev=265594&view=rev Log: Minor simplifications. Modified: cfe/trunk/include/clang/Serialization/ASTWriter.h cfe/trunk/lib/Serialization/ASTWriterDecl.cpp cfe/trunk/lib/Serializa

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

aprantl added a comment. Oh. And I also discovered a completely bit-rotted pass called BreakpointPrinter that can impossible function because it looks at llvm.dbg.sp. Looks like it could be easily updated, though. http://reviews.llvm.org/D18808 __

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

aprantl removed rL LLVM as the repository for this revision. aprantl updated this revision to Diff 52842. aprantl added a comment. This patch adds a DICompileUnit iterator to Module that skips over NoDebug CUs. http://reviews.llvm.org/D18808 Files: include/llvm/IR/DIBuilder.h include/llvm/I

Re: [PATCH] D18073: Add memory allocating functions

zaks.anna added a comment. You will have to add one test function to smoke test that the newly added API is modeled correctly. We also have a lot of existing tests that verify that each of the original APIs (malloc. free, new) function correctly in all possible settings. What is the contradicti

Re: r265038 - Diagnostics: remove dodgy handler for bitcode inlineasm diagnostics.

> Generally good. How about only report error when SM.getKind() == DK_Error? Good idea. I've committed it with more flexible diagnostic kinds as r265592. Tim. ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

r265592 - Restore slightly less dodgy diagnostic handler for inline asm

Author: tnorthover Date: Wed Apr 6 14:58:07 2016 New Revision: 265592 URL: http://llvm.org/viewvc/llvm-project?rev=265592&view=rev Log: Restore slightly less dodgy diagnostic handler for inline asm Turns out it was there mostly to prevent Clang asking people to report a bug. This time we report

Re: [PATCH] D18073: Add memory allocating functions

ariccio added a comment. In http://reviews.llvm.org/D18073#392972, @zaks.anna wrote: > > So for _wcsdup_dbg, I should leave only testWinWcsdupDbg? > > > Yes. Ok, that I can do. Will upload patch later this afternoon/tonight. In http://reviews.llvm.org/D18073#392972, @zaks.anna wrote: > Also,

Re: [PATCH] D18551: Added Fixer implementation and fix() interface in clang-format for removing redundant code.

ioeric updated this revision to Diff 52832. ioeric marked 4 inline comments as done. ioeric added a comment. - Change implementation of fixer to iterate by lines. TODO: refactor Formatter and Fixer to reduce duplication. http://reviews.llvm.org/D18551 Files: include/clang/Format/Format.h l

Re: [PATCH] D18821: Add modernize-bool-to-integer-conversion

krystyna added inline comments. Comment at: docs/clang-tidy/checks/modernize-bool-to-integer-conversion.rst:9 @@ +8,3 @@ +.. code-block:: C++ + int a = false + vector v(true); // Makes vector of one element int a = false; http://reviews.llvm.org/D18821

Re: [PATCH] D17821: [OpenCL] Complete image types support

bader added a comment. In http://reviews.llvm.org/D17821#393387, @Anastasia wrote: > Regarding, extending this approach for OpenCL pipe types too. I was thinking > we could change current implementation to have ReadPipeType and > WritePipeType. They can both be derived from PipeType that we alr

Re: [PATCH] D18509: clang-tidy: add_new_check.py stubs out release notes

etienneb added a subscriber: etienneb. etienneb added a comment. I like this :) http://reviews.llvm.org/D18509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18833: [clang-tidy] Fix infinite loop in MisplacedWideningCastCheck.

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. In Release mode, the check was infinite looping over chromium code base. It seems there is something strange with the creation of the Maps. I believe the compiler is making some assumption

Re: [PATCH] D18653: [Sema] Diagnose template alias declaration in local class

rsmith closed this revision. rsmith added a comment. Landed as r265571. http://reviews.llvm.org/D18653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r265571 - Diagnose template alias declarations in local classes.

Author: rsmith Date: Wed Apr 6 12:38:58 2016 New Revision: 265571 URL: http://llvm.org/viewvc/llvm-project?rev=265571&view=rev Log: Diagnose template alias declarations in local classes. Patch by Erik Pilkington! Modified: cfe/trunk/lib/Sema/SemaDeclCXX.cpp cfe/trunk/test/CXX/temp/temp.

Re: [PATCH] D18776: NFC: make AtomicOrdering an enum class

This revision was automatically updated to reflect the committed changes. Closed by commit rL265569: NFC: make AtomicOrdering an enum class (authored by jfb). Changed prior to commit: http://reviews.llvm.org/D18776?vs=52637&id=52820#toc Repository: rL LLVM http://reviews.llvm.org/D18776 Fi

r265569 - NFC: make AtomicOrdering an enum class

Author: jfb Date: Wed Apr 6 12:26:42 2016 New Revision: 265569 URL: http://llvm.org/viewvc/llvm-project?rev=265569&view=rev Log: NFC: make AtomicOrdering an enum class Summary: See LLVM change D18775 for details, this change depends on it. Reviewers: jyknight, reames Subscribers: cfe-commits

Re: [PATCH] D17821: [OpenCL] Complete image types support

Anastasia added a comment. Regarding, extending this approach for OpenCL pipe types too. I was thinking we could change current implementation to have ReadPipeType and WritePipeType. They can both be derived from PipeType that we already have now (we can make it an abstract class to avoid its i

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

etienneb added a comment. In http://reviews.llvm.org/D18783#393367, @LegalizeAdulthood wrote: > There are some APIs where a series of strings are passed as a single `char *` > with NUL separators between the strings and the last string is indicated by > two NUL characters in a row. For instanc

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. LegalizeAdulthood added a comment. There are some APIs where a series of strings are passed as a single `char *` with NUL separators between the strings and the last string is indicated by two NUL characters in a row. For instance, see th

r265557 - clang-format: Fix label-in-if statement in macros where it is actually used.

Author: djasper Date: Wed Apr 6 11:41:39 2016 New Revision: 265557 URL: http://llvm.org/viewvc/llvm-project?rev=265557&view=rev Log: clang-format: Fix label-in-if statement in macros where it is actually used. Before: #define A \ if (a) \ label: \ f() After: #define A \ if

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

Eugene.Zelenko added a comment. In http://reviews.llvm.org/D18745#391210, @Prazek wrote: > In http://reviews.llvm.org/D18745#390739, @Eugene.Zelenko wrote: > > > Isn't readability-implicit-bool-cast¶ should catch such issues? If not, I > > think will be good idea to improve that check instead of

Re: [PATCH] D18745: [clang-tidy] Adds modernize-use-bool-literals check.

LegalizeAdulthood added a subscriber: LegalizeAdulthood. Comment at: docs/clang-tidy/checks/modernize-use-bool-literals.rst:17 @@ +16,1 @@ + std::ios_base::sync_with_stdio(false); \ No newline at end of file Please ensure the file ends with a newline. =

Re: [PATCH] D18713: [OpenCL] Generate bitcast when target address space does not change.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! http://reviews.llvm.org/D18713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

Anastasia added a comment. In http://reviews.llvm.org/D18369#393323, @yaxunl wrote: > We need to discuss the layout of the header file. > > For the builtin functions, I plan to follow the order of the spec and > extension spec. If there are difference in 1.2 and 2.0, use condition macro. > > For

Re: [PATCH] D18369: [OpenCL] Upstreaming khronos OpenCL 1.2/2.0 header files.

yaxunl added a comment. We need to discuss the layout of the header file. For the builtin functions, I plan to follow the order of the spec and extension spec. If there are difference in 1.2 and 2.0, use condition macro. For functions with double or half arguments, we have two options: 1. keep

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

> On Apr 6, 2016, at 8:16 AM, David Blaikie wrote: > > > > On Tue, Apr 5, 2016 at 10:17 PM, Eric Christopher via llvm-commits > mailto:llvm-comm...@lists.llvm.org>> wrote: > echristo added inline comments. > > > Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:477-479 > @@

r265546 - Enable PIE for CloudABI.

Author: ed Date: Wed Apr 6 10:37:06 2016 New Revision: 265546 URL: http://llvm.org/viewvc/llvm-project?rev=265546&view=rev Log: Enable PIE for CloudABI. As we're currently working on making CloudABI executables easier to emulate in userspace (e.g., on OS X and Windows), it makes a whole lot of s

[PATCH] D18829: [clang-tidy] Fix FP with readability-redundant-string-init for default arguments

etienneb created this revision. etienneb added a reviewer: alexfh. etienneb added a subscriber: cfe-commits. Clang-tidy is reporting a warning of redundant string initialisation on a string parameter initialized with empty string. See bug: 27087 The reported example is: ``` #include void fn(std

Re: [PATCH] D18565: Implement an "I'm dtrace, please retain all debug types" option.

Okey dokey - I know one of the things we did (& I don't know when it happened compared to this change) is emit a hard list of variables onto any subprogram for an optimized (non -O0) function. So we never lose variables due to optimizations, or at least that's the intent. As for D18477, I'm not su

Re: [PATCH] D18808: Use the NoDebug emission kind to identify compile units that no debug info should be created from.

On Tue, Apr 5, 2016 at 10:17 PM, Eric Christopher via llvm-commits < llvm-comm...@lists.llvm.org> wrote: > echristo added inline comments. > > > Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:477-479 > @@ -476,2 +476,5 @@ > + unsigned DebugCUs = 0; >for (MDNode *N : CU_Nod

Re: [PATCH] D18713: [OpenCL] Generate bitcast when target address space does not change.

yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 52800. yaxunl added a comment. Add more checks for w/o -ffake-address-space-map to the test. http://reviews.llvm.org/D18713 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGenOpenCL/address-spaces-conversions.cl

r265545 - clang-format: Support labels in brace-less ifs.

Author: djasper Date: Wed Apr 6 10:02:46 2016 New Revision: 265545 URL: http://llvm.org/viewvc/llvm-project?rev=265545&view=rev Log: clang-format: Support labels in brace-less ifs. While I am not personally convinced about the usefulness of this construct, we should break it. Before: if (a) l

[clang-tools-extra] r265544 - [clang-tidy] Assertion fix in misc-misplaced-widening-cast check.

Author: xazax Date: Wed Apr 6 09:49:15 2016 New Revision: 265544 URL: http://llvm.org/viewvc/llvm-project?rev=265544&view=rev Log: [clang-tidy] Assertion fix in misc-misplaced-widening-cast check. Modified: clang-tools-extra/trunk/clang-tidy/misc/MisplacedWideningCastCheck.cpp Modified: cla

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein marked an inline comment as done. hokein added a comment. http://reviews.llvm.org/D18694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein updated this revision to Diff 52798. hokein added a comment. More comments. http://reviews.llvm.org/D18694 Files: clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOptions.h clang-tidy/tool/ClangTidyMain.cpp test/clang-tidy/Inputs/explain-config/.clang-tidy test/clang-tidy/ex

Re: [PATCH] D18694: [ClangTidy] Add an 'explain-checks' option to diagnose where each checks comes from.

hokein updated this revision to Diff 52797. hokein marked an inline comment as done. hokein added a comment. Correct the processing orders. http://reviews.llvm.org/D18694 Files: clang-tidy/ClangTidyOptions.cpp clang-tidy/ClangTidyOptions.h clang-tidy/tool/ClangTidyMain.cpp test/clang-ti

Re: [PATCH] D18776: NFC: make AtomicOrdering an enum class

jyknight accepted this revision. jyknight added a comment. BTW, this change doesn't actually depend on the LLVM change; it could be committed first, as a "normal" enum puts its members both inside the enum name's scope and outside. http://reviews.llvm.org/D18776

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

aturetsk added a comment. Hi Bruno, Thanks for the review. Comment at: include/clang/Driver/Options.td:1281 @@ -1280,1 +1280,3 @@ +def miamcu : Flag<["-"], "miamcu">, Group, Flags<[DriverOption, CoreOption]>, + HelpText<"Use Intel MCU ABI">; def malign_functions_EQ : Joined<

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

etienneb added a comment. I finally get rid of the GetCharAt function. Comment at: clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp:22 @@ +21,3 @@ +static unsigned int GetCharAt(const StringLiteral *SL, size_t offset) { + if (offset >= SL->getLength()) return 0; + return

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

etienneb updated this revision to Diff 52793. etienneb added a comment. nits. http://reviews.llvm.org/D18783 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.h

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

aturetsk updated this revision to Diff 52789. aturetsk added a comment. Fix remarks, http://reviews.llvm.org/D18398 Files: include/clang/Driver/Options.td lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Driver/miamcu-opt.c Index: test/Driver/miamcu-opt.c ===

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

etienneb updated this revision to Diff 52791. etienneb marked 2 inline comments as done. etienneb added a comment. alexfh comments. http://reviews.llvm.org/D18783 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp

Re: [PATCH] D18806: [clang-tidy] filter plugins and plugin arguments of the command-line

etienneb updated this revision to Diff 52788. etienneb marked 4 inline comments as done. etienneb added a comment. alexfh@ comments. http://reviews.llvm.org/D18806 Files: clang-tidy/ClangTidy.cpp Index: clang-tidy/ClangTidy.cpp

[clang-tools-extra] r265542 - [clang-tidy] filter plugins and plugin arguments of the command-line

Author: etienneb Date: Wed Apr 6 09:07:51 2016 New Revision: 265542 URL: http://llvm.org/viewvc/llvm-project?rev=265542&view=rev Log: [clang-tidy] filter plugins and plugin arguments of the command-line Summary: This patch remove the plugin argument from the command-line. Loading plugins was ma

Re: [PATCH] D18783: [clang-tidy] add new checker for string literal with NUL character.

alexfh added a comment. A couple of nits for now. Will take a closer look later. Comment at: clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp:22 @@ +21,3 @@ +static unsigned int GetCharAt(const StringLiteral *SL, size_t offset) { + if (offset >= SL->getLength()) return 0;

  1   2   >