etienneb added a comment.
I finally get rid of the GetCharAt function.
================
Comment at: clang-tidy/misc/StringLiteralWithEmbeddedNulCheck.cpp:22
@@ +21,3 @@
+static unsigned int GetCharAt(const StringLiteral *SL, size_t offset) {
+ if (offset >= SL->getLength()) return 0;
+ return SL->getCodeUnit(offset);
----------------
alexfh wrote:
> Should this be an assert instead?
No, because we are not doing bounds check later:
if (GetCharAt(SL, i) == 0 &&
GetCharAt(SL, i + 1) == 'x' &&
isDigit(GetCharAt(SL, i + 2)) &&
isDigit(GetCharAt(SL, i + 3))) {
We can move this as an assert, and in this case... we can modify the "if" to
check the length.
http://reviews.llvm.org/D18783
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
