Re: [PATCH] D17130: Debloat some headers

craig.topper added a subscriber: craig.topper. craig.topper added a comment. What's complex about the SVal constructors? Comment at: llvm/tools/clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:143 @@ -144,3 +142,3 @@ void addAbortedBlock(const ExplodedNode

[PATCH] D17130: Debloat some headers

ariccio created this revision. ariccio added a subscriber: cfe-commits. As discussed in "Code in headers" on llvm-dev, there are lots of headers with complex code in them. I've moved some complex constructors & destructors to implementation files, using [[ https://www.chromium.org/developers/co

r260497 - clang-format: Make it more expensive to break template parameters.

Author: djasper Date: Thu Feb 11 00:43:01 2016 New Revision: 260497 URL: http://llvm.org/viewvc/llvm-project?rev=260497&view=rev Log: clang-format: Make it more expensive to break template parameters. In particular, make it more expensive than breaking after the return type of a function definiti

r260496 - [Objective-c] Stop attaching section "datacoal_nt" to global variables.

Author: ahatanak Date: Thu Feb 11 00:36:35 2016 New Revision: 260496 URL: http://llvm.org/viewvc/llvm-project?rev=260496&view=rev Log: [Objective-c] Stop attaching section "datacoal_nt" to global variables. The current macho linker just copies symbols in section datacoal_nt to section data, so it

r260492 - [OPENMP] Rename OMPCapturedFieldDecl to OMPCapturedExprDecl, NFC.

Author: abataev Date: Wed Feb 10 23:35:55 2016 New Revision: 260492 URL: http://llvm.org/viewvc/llvm-project?rev=260492&view=rev Log: [OPENMP] Rename OMPCapturedFieldDecl to OMPCapturedExprDecl, NFC. OMPCapturedExprDecl allows caopturing not only of fielddecls, but also other expressions. It also

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx updated this revision to Diff 47594. flx added a comment. Added comment that we're returning early if this constructor simply delegates to another constructor. http://reviews.llvm.org/D16517 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelin

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx added inline comments. Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:205 @@ +204,3 @@ + Diag << FixItHint::CreateInsertion( + Field->getSourceRange().getEnd().getLocWithOffset( + Field->getName().size()), alexfh

Re: [PATCH] D16517: ClangTidy check to flag uninitialized builtin and pointer fields.

flx updated this revision to Diff 47590. flx marked 3 inline comments as done. http://reviews.llvm.org/D16517 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp clang-tidy/

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

On Wed, Feb 10, 2016 at 2:46 PM, Duncan P. N. Exon Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I'm hoping only a year or two (or three...)? > As I pointed out to Eric on IRC, those files have had a "deprecation warning" every time they are included ... since 2010. -- Marshall __

Re: [PATCH] D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual

silvas added a subscriber: silvas. silvas added a comment. Assuming the features are implemented this seems fine. LGTM. Comment at: docs/UsersManual.rst:1698 @@ -1697,3 @@ -- clang does not support #pragma weak (`bug - 3679 `_). Due

Re: [PATCH] D17043: Check that the result of a library call w/o side effects is used

> On Feb 10, 2016, at 8:05 PM, Joerg Sonnenberger > wrote: > > I'm not a big fan of this. Those calls are by the very definition > harmless, so they aggrevate the existing problem of stupid annotation. The issue is that the annotation's current diagnostic is pretty nonspecific and therefore no

r260478 - Remove unused ToolChain arg from Driver::ConstructPhaseAction and BuildAction.

Author: jlebar Date: Wed Feb 10 20:00:50 2016 New Revision: 260478 URL: http://llvm.org/viewvc/llvm-project?rev=260478&view=rev Log: Remove unused ToolChain arg from Driver::ConstructPhaseAction and BuildAction. Summary: Actions don't depend on the toolchain; they get bound to a particular toolch

r260479 - [CUDA] Don't crash when trying to printf a non-scalar object.

Author: jlebar Date: Wed Feb 10 20:00:52 2016 New Revision: 260479 URL: http://llvm.org/viewvc/llvm-project?rev=260479&view=rev Log: [CUDA] Don't crash when trying to printf a non-scalar object. Summary: We can't do the right thing, since there's no right thing to do, but at least we can not cras

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

This revision was automatically updated to reflect the committed changes. jlebar marked an inline comment as done. Closed by commit rL260479: [CUDA] Don't crash when trying to printf a non-scalar object. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D17103?vs=47569&id=4

Re: [PATCH] D17100: Remove unused ToolChain arg from Driver::ConstructPhaseAction and BuildAction.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260478: Remove unused ToolChain arg from Driver::ConstructPhaseAction and BuildAction. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D17100?vs=47526&id=47571#toc Repository:

Re: [PATCH] D17043: Check that the result of a library call w/o side effects is used

On Wed, Feb 10, 2016 at 5:05 PM, Joerg Sonnenberger via cfe-commits wrote: > On Wed, Feb 10, 2016 at 04:21:02PM +, Alexander Kornienko via cfe-commits > wrote: >> alexfh added a comment. >> >> Thank you for working on this check! >> >> I'd like to note that there is a library-side way to miti

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/CGCUDABuiltin.cpp:90 @@ +89,3 @@ +CGM.ErrorUnsupported(E, "non-scalar arg to printf"); +return RValue::getIgnored(); + } Doesn

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

jlebar updated this revision to Diff 47569. jlebar added a comment. Error out with CGM.ErrorUnsupported when we receive a non-scalar arg. http://reviews.llvm.org/D17103 Files: lib/CodeGen/CGCUDABuiltin.cpp test/CodeGenCUDA/printf-aggregate.cu Index: test/CodeGenCUDA/printf-aggregate.cu ===

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

echristo added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); tra wrote: >

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

jlebar added a comment. OK, talked to Reid irl. Since this is just printf, not general varargs handling, the Simplest Thing That Could Possibly Work is to error-unsupported. Once we fix sema as described above, we can move the check there. Will update the patch, thanks everyone. http://rev

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

tra added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); hfinkel wrote: > e

Re: r260411 - Silence some MSVC false positive warnings about integer zexts and falling off the end of a covered switch

On Wed, Feb 10, 2016 at 07:09:16PM -, Reid Kleckner via cfe-commits wrote: > Modified: cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp > URL: > http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/CodeCompleteConsumer.cpp?rev=260411&r1=260410&r2=260411&view=diff > ===

Re: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

On Wed, Feb 10, 2016 at 5:07 PM Joerg Sonnenberger wrote: > On Thu, Feb 11, 2016 at 12:18:49AM +, Eric Christopher via cfe-commits > wrote: > > Mostly that you didn't mention it in your commit message. > > > > I'd rather prefer the rest of the file be changed to match the __ rather > > than t

Re: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

On Thu, Feb 11, 2016 at 12:18:49AM +, Eric Christopher via cfe-commits wrote: > Mostly that you didn't mention it in your commit message. > > I'd rather prefer the rest of the file be changed to match the __ rather > than the other way around :) Depends. If it is a macro, not using __ is fin

Re: [PATCH] D17043: Check that the result of a library call w/o side effects is used

On Wed, Feb 10, 2016 at 04:21:02PM +, Alexander Kornienko via cfe-commits wrote: > alexfh added a comment. > > Thank you for working on this check! > > I'd like to note that there is a library-side way to mitigate this > issue using the `[[clang::warn_unused_result]]` attribute on > `vector:

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

hfinkel added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); echristo wrote

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

echristo added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); tra wrote: >

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

tra added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); tra wrote: > hfink

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

tra added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); hfinkel wrote: > e

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

hfinkel added a subscriber: hfinkel. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); echristo

Re: [PATCH] D16808: [MCU] PR26438: Fix assertion failure on function returning an empty struct or union

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D16808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

echristo added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); jlebar wrote:

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Wow really? That's ... wow. OK http://reviews.llvm.org/D17111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

Re: [PATCH] D17111: [CUDA] pass debug options to ptxas.

jlebar added inline comments. Comment at: lib/Driver/Tools.cpp:10707 @@ +10706,3 @@ +// ptxas does not accept -g option if optimization is enabled, so we ignore +// compiler's -O* options if we want debug info. +CmdArgs.push_back("-g"); I think this is

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

hfinkel added a comment. In http://reviews.llvm.org/D17103#349280, @jlebar wrote: > > > I guess this is the part I'm unsure of. If it's legal to pass a struct > > > to printf in regular C++ (seems to be?), I'd guess it should be legal in > > > CUDA, too? I'm just not sure what it's supposed t

[PATCH] D17111: [CUDA] pass debug options to ptxas.

tra created this revision. tra added reviewers: jlebar, echristo. tra added a subscriber: cfe-commits. ptxas optimizations are disabled if we need to generate debug info as ptxas does not accept '-g' otherwise. http://reviews.llvm.org/D17111 Files: lib/Driver/Tools.cpp test/Driver/cuda-exter

Re: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

Mostly that you didn't mention it in your commit message. I'd rather prefer the rest of the file be changed to match the __ rather than the other way around :) -eric On Wed, Feb 10, 2016 at 4:14 PM Romanova, Katya < katya_roman...@playstation.sony.com> wrote: > Hi Eric, > > Everywhere else in t

r260472 - Fix two tests relying on LLVM -O1 behavior

Author: rnk Date: Wed Feb 10 18:14:04 2016 New Revision: 260472 URL: http://llvm.org/viewvc/llvm-project?rev=260472&view=rev Log: Fix two tests relying on LLVM -O1 behavior Something changed the inference of nonnull. Modified: cfe/trunk/test/CodeGenCXX/init-invariant.cpp cfe/trunk/test/C

RE: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

Hi Eric, Everywhere else in this file formal parameter “a” is used. This one “__a” was inconsistent. However, if you don’t like it, I could change it back. Katya. From: Eric Christopher [mailto:echri...@gmail.com] Sent: Wednesday, February 10, 2016 3:16 PM To: Romanova, Katya; cfe-commits@lists

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

rnk added inline comments. Comment at: lib/CodeGen/CGCUDABuiltin.cpp:105 @@ -99,3 +104,3 @@ llvm::Value *P = Builder.CreateStructGEP(AllocaTy, Alloca, I - 1); llvm::Value *Arg = Args[I].RV.getScalarVal(); Builder.CreateAlignedStore(Arg, P, DL.getPrefTypeAlign

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

jlebar added a comment. > > I guess this is the part I'm unsure of. If it's legal to pass a struct to > > printf in regular C++ (seems to be?), I'd guess it should be legal in CUDA, > > too? I'm just not sure what it's supposed to do (in either case). > > > Is this because PTX does not ha

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

hfinkel added a comment. In http://reviews.llvm.org/D17103#349274, @jlebar wrote: > > Ultimately, Sema should be responsible for rejecting this, correct? > > > I guess this is the part I'm unsure of. If it's legal to pass a struct to > printf in regular C++ (seems to be?), I'd guess it should b

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

jlebar added a comment. > Ultimately, Sema should be responsible for rejecting this, correct? I guess this is the part I'm unsure of. If it's legal to pass a struct to printf in regular C++ (seems to be?), I'd guess it should be legal in CUDA, too? I'm just not sure what it's supposed to do

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

hfinkel added a comment. In http://reviews.llvm.org/D17103#349254, @jlebar wrote: > In http://reviews.llvm.org/D17103#349245, @hfinkel wrote: > > > In http://reviews.llvm.org/D17103#349182, @jlebar wrote: > > > > > Yeah, I have no idea what's the right thing to do here. We can always > > > pass

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

rnk added a comment. Ultimately, Sema should be responsible for rejecting this, correct? In the meantime we can have CodeGen reject this and emit a null value to avoid crashing. Comment at: lib/CodeGen/CGCUDABuiltin.cpp:105 @@ -99,3 +104,3 @@ llvm::Value *P = Builder.Cr

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

jlebar added a comment. In http://reviews.llvm.org/D17103#349245, @hfinkel wrote: > In http://reviews.llvm.org/D17103#349182, @jlebar wrote: > > > Yeah, I have no idea what's the right thing to do here. We can always pass > > a null pointer, that's easy. David, Reid, do you know what is the co

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

hfinkel added a subscriber: hfinkel. hfinkel added a comment. In http://reviews.llvm.org/D17103#349182, @jlebar wrote: > Yeah, I have no idea what's the right thing to do here. We can always pass a > null pointer, that's easy. David, Reid, do you know what is the correct > behavior? I think

Re: r260333 - This patch adds doxygen comments for all the intrinsincs in the header file f16cintrin.h. The doxygen comments are automatically generated based on Sony's intrinsics document.

On Tue, Feb 9, 2016 at 4:16 PM Ekaterina Romanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kromanova > Date: Tue Feb 9 18:12:24 2016 > New Revision: 260333 > > URL: http://llvm.org/viewvc/llvm-project?rev=260333&view=rev > Log: > This patch adds doxygen comments for all the

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

benlangmuir added a comment. I don't think this is the right approach. If we don't canonicalize the source path then: - looking up the path *without* the .. won't work, which means anything that looks up a realpath will fail - directory iteration won't combine entries from foo/bar/.. and foo/

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

jlebar added a comment. Yeah, I have no idea what's the right thing to do here. We can always pass a null pointer, that's easy. David, Reid, do you know what is the correct behavior? http://reviews.llvm.org/D17103 ___ cfe-commits mailing list cf

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

bruno added a comment. In http://reviews.llvm.org/D17104#349141, @benlangmuir wrote: > Please clarify what you mean here: > > > The rationale is that if source and destination paths in the YAML file > > contain ".." this is enough > > > for the file manager to retrieve the right file, meaning t

Re: [PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

tra added a comment. Erasing an argument would only complicate the problem. I guess for consistency we need to match clang's behavior for regular C++ code. For optimized builds it just seems to pass NULL pointer instead. http://reviews.llvm.org/D17103 _

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

benlangmuir added a comment. Please clarify what you mean here: > The rationale is that if source and destination paths in the YAML file > contain ".." this is enough > for the file manager to retrieve the right file, meaning that it doesn't > matter how we write it > since the FileManager

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

I'm hoping only a year or two (or three...)? > On 2016-Feb-10, at 14:29, Eric Fiselier wrote: > > > Can we hold off a little longer? > > Yes we can. The entire point of the AFAIK was to encourage migration to > libc++ so it makes some > sense to keep them while they still serve this purpose. >

[PATCH] D17104: [VFS] Drop path traversal assertion

bruno created this revision. bruno added reviewers: bogner, benlangmuir. bruno added subscribers: cfe-commits, dexonsmith. This patch removes the path traversals check/assertion related with the presence of ".." in paths. The rationale is that if source and destination paths in the YAML file con

[PATCH] D17103: [CUDA] Don't crash when trying to printf a non-scalar object.

jlebar created this revision. jlebar added reviewers: majnemer, rnk. jlebar added subscribers: tra, jhen, cfe-commits. We can't do the right thing, since there's no right thing to do, but at least we can not crash the compiler. http://reviews.llvm.org/D17103 Files: lib/CodeGen/CGCUDABuiltin.cp

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

> Can we hold off a little longer? Yes we can. The entire point of the AFAIK was to encourage migration to libc++ so it makes some sense to keep them while they still serve this purpose. When you say "a little longer" what sort of timeline do you have in mind? It would be nice to get rid of thes

Re: r260388 - [MS ABI] Never reference dllimport'd vtables

On Wed, Feb 10, 2016 at 9:40 AM, David Majnemer via cfe-commits wrote: > Author: majnemer > Date: Wed Feb 10 11:40:47 2016 > New Revision: 260388 > > URL: http://llvm.org/viewvc/llvm-project?rev=260388&view=rev > Log: > [MS ABI] Never reference dllimport'd vtables > > Referencing a dllimported vta

r260449 - Revert r260388 "[MS ABI] Never reference dllimport'd vtables"

Author: hans Date: Wed Feb 10 16:18:37 2016 New Revision: 260449 URL: http://llvm.org/viewvc/llvm-project?rev=260449&view=rev Log: Revert r260388 "[MS ABI] Never reference dllimport'd vtables" This caused the compiler to fail with "invalid linkage type for global declaration" (PR26569). Modified

[PATCH] D17100: Remove unused ToolChain arg from Driver::ConstructPhaseAction and BuildAction.

jlebar created this revision. jlebar added a reviewer: echristo. jlebar added a subscriber: cfe-commits. Actions don't depend on the toolchain; they get bound to a particular toolchain via BindArch. No functional changes. http://reviews.llvm.org/D17100 Files: include/clang/Driver/Driver.h l

r260448 - Bail on compilation as soon as a job fails.

Author: jlebar Date: Wed Feb 10 16:17:00 2016 New Revision: 260448 URL: http://llvm.org/viewvc/llvm-project?rev=260448&view=rev Log: Bail on compilation as soon as a job fails. Previously we attempted to be smart; if one job failed, we'd run all jobs that didn't depend on the failing job. Proble

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

This revision was automatically updated to reflect the committed changes. Closed by commit rL260448: Bail on compilation as soon as a job fails. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16514?vs=47520&id=47525#toc Repository: rL LLVM http://reviews.llvm.org/D1

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

echristo accepted this revision. echristo added a reviewer: echristo. echristo added a comment. This works for me and I can't think of anything it's going to break so LGTM. Thanks! -eric http://reviews.llvm.org/D16514 ___ cfe-commits mailing list

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

> On 2016-Feb-10, at 13:25, Bob Wilson wrote: > > >> On Feb 10, 2016, at 12:59 PM, Tim Northover wrote: >> >> On 10 February 2016 at 12:52, Eric Fiselier wrote: >>> @Tim Are these tests in the clang test suite? >> >> Yep, at http://llvm.org/git/test-suite.git. >> >>> Marshall and I were ju

Re: [PATCH] D16514: Add -stop-on-failure driver option, and enable it by default for CUDA compiles.

jlebar updated this revision to Diff 47520. jlebar added a comment. Per IRL discussion with echristo, updated so that we just bail as soon as one subjob fails. http://reviews.llvm.org/D16514 Files: lib/Driver/Compilation.cpp Index: lib/Driver/Compilation.cpp =

[libcxx] r260443 - Remove changes that snuck in within r260431

Author: ericwf Date: Wed Feb 10 15:58:36 2016 New Revision: 260443 URL: http://llvm.org/viewvc/llvm-project?rev=260443&view=rev Log: Remove changes that snuck in within r260431 Modified: libcxx/trunk/include/unordered_map Modified: libcxx/trunk/include/unordered_map URL: http://llvm.org/vie

Re: [PATCH] D16738: Fix invalid casts in .

eugenis closed this revision. eugenis added a comment. Thanks for the review! Committed as r260441. Repository: rL LLVM http://reviews.llvm.org/D16738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[libcxx] r260441 - Fix invalid casts in .

Author: eugenis Date: Wed Feb 10 15:53:28 2016 New Revision: 260441 URL: http://llvm.org/viewvc/llvm-project?rev=260441&view=rev Log: Fix invalid casts in . static_cast of a pointer to object before the start of the object's lifetime has undefined behavior. This code triggers CFI warnings. This

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

On 10 February 2016 at 12:06, Richard Smith wrote: > OK, got the build working. This should be fixed in r260425. Please let > me know if you're still seeing failures. Thanks Richard, that did it. Tim. ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D17043: Check that the result of a library call w/o side effects is used

sidney added a comment. In http://reviews.llvm.org/D17043#348982, @alexfh wrote: > The attribute can have arguments (e.g. `[[deprecated("use some other API")]] > void f();`), so if there is a good reason, an argument (e.g. a custom > message) can be added to the `warn_unused_result` attribute.

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

rsmith added a comment. There seem to be two principled approaches here: 1. `DiagnosticsEngine` has a `Group` named `"everything"` (all of its interface supports that group, and from the point of view of someone using `DiagnosticsEngine` it behaves like any other group), or 2. There is no such

Re: [PATCH] D5238: [analyzer] Detect duplicate [super dealloc] calls

dcoughlin added a comment. In http://reviews.llvm.org/D5238#348199, @zaks.anna wrote: > Looks good, below are some comments which are mostly nits. > > What's the plan for bringing this out of alpha? Is it pending evaluation on > real code? I will first extend this checker to check for uses of

r260435 - [clang-cl] /Z7 now generates normal debug info, not just line info

Author: rnk Date: Wed Feb 10 15:28:38 2016 New Revision: 260435 URL: http://llvm.org/viewvc/llvm-project?rev=260435&view=rev Log: [clang-cl] /Z7 now generates normal debug info, not just line info Previously LLVM could not process any debug info we produced, so it didn't make sense to spend time

Re: [PATCH] D5238: [analyzer] Detect duplicate [super dealloc] calls

dcoughlin updated this revision to Diff 47514. dcoughlin added a comment. Address more of Anna's comments. - Add a more explicit comment about checker in header comment - Changed the checker to always use the receiver symbol rather than the self symbol for clarity. - Rework SuperDeallocBRVisitor

Re: [PATCH] D17043: Check that the result of a library call w/o side effects is used

alexfh added a comment. In http://reviews.llvm.org/D17043#348569, @sidney wrote: > In http://reviews.llvm.org/D17043#348525, @alexfh wrote: > > > I'd like to note that there is a library-side way to mitigate this issue > > using the `[[clang::warn_unused_result]]` attribute on `vector::empty()`

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

> On Feb 10, 2016, at 12:59 PM, Tim Northover wrote: > > On 10 February 2016 at 12:52, Eric Fiselier wrote: >> @Tim Are these tests in the clang test suite? > > Yep, at http://llvm.org/git/test-suite.git. > >> Marshall and I were just talking about removing all together. >> Could you explai

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

Sunil_Srivastava added a comment. Richard, Your comment and my concern about the getDiagnosticsInGroup is still visible in the greyed out area. Given that do you still want to modify getDiagnosticsInGroup ? I have removed the separate test and added the new tests to existing files, as you sugg

Re: [PATCH] D15095: Accept "-Weverything" in pragma clang diagnostic ...

Sunil_Srivastava added a reviewer: rsmith. Sunil_Srivastava updated this revision to Diff 47509. Sunil_Srivastava added a comment. Changed the test, but the compiler code is still same, pending reply from Richard Smith http://reviews.llvm.org/D15095 Files: lib/Basic/Diagnostic.cpp test/Pre

r260433 - Test commit, fixed "clang" to "Clang" in docs

Author: mgrang Date: Wed Feb 10 15:06:10 2016 New Revision: 260433 URL: http://llvm.org/viewvc/llvm-project?rev=260433&view=rev Log: Test commit, fixed "clang" to "Clang" in docs Reviewers: weimingz Subscribers: cfe-commits Differential Revision: http://reviews.llvm.org/D17085 Modified: cf

Re: [PATCH] D17085: Test commit, fixed "clang" to "Clang" in docs

This revision was automatically updated to reflect the committed changes. Closed by commit rL260433: Test commit, fixed "clang" to "Clang" in docs (authored by mgrang). Changed prior to commit: http://reviews.llvm.org/D17085?vs=47493&id=47510#toc Repository: rL LLVM http://reviews.llvm.org/

Re: [PATCH] D16738: Fix invalid casts in .

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. Thanks for putting up with my pickyness. It looks like there are exception safety issues with the order of `__f_ = __as_base(&__buf_)` and `__f->__f_..__clone(__f)` in a bunch of places

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

On 10 February 2016 at 12:52, Eric Fiselier wrote: > @Tim Are these tests in the clang test suite? Yep, at http://llvm.org/git/test-suite.git. > Marshall and I were just talking about removing all together. > Could you explain who still uses it? In the test-suite, it looks like it's just thes

Re: [libcxx] r260012 - Cleanup node-type handling in the unordered containers

(Re-adding the list) Re-committed as r260431. Let me know if there is any more breakage. @Tim Are these tests in the clang test suite? Marshall and I were just talking about removing all together. Could you explain who still uses it? On Mon, Feb 8, 2016 at 4:52 PM, Eric Fiselier wrote: > Hey

[libcxx] r260431 - Recommit r260012 - Cleanup node-type handling in the unordered containers.

Author: ericwf Date: Wed Feb 10 14:46:23 2016 New Revision: 260431 URL: http://llvm.org/viewvc/llvm-project?rev=260431&view=rev Log: Recommit r260012 - Cleanup node-type handling in the unordered containers. This time I kept working! This patch is the first in a series of patches that's meant t

[PATCH] D17091: [analyzer][scan-build-py] Non-existing directory for scan-build output.

ayartsev created this revision. ayartsev added a reviewer: rizsotto.mailinglist. ayartsev added a subscriber: cfe-commits. Attached patch makes scan-build successfully accept non-existing output directories provided via "-o" option. The directory is created in this case. This behavior is conform

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

OK, got the build working. This should be fixed in r260425. Please let me know if you're still seeing failures. On Wed, Feb 10, 2016 at 11:59 AM, Richard Smith wrote: > On Wed, Feb 10, 2016 at 10:32 AM, Tim Northover > wrote: >> Hi Richard, >> >> On 9 February 2016 at 16:59, Richard Smith via c

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

On Wed, Feb 10, 2016 at 10:32 AM, Tim Northover wrote: > Hi Richard, > > On 9 February 2016 at 16:59, Richard Smith via cfe-commits > wrote: >> Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from >> and wcschr, wcspbrk, wcsrchr, wmemchr, and wcsstr from >> to >> provide a con

Re: [PATCH] D16971: Fixed crash when partial specialization is missing required parameters

hintonda added a comment. I don't have commit access, so if this patch is accepted, could someone please commit it for me? http://reviews.llvm.org/D16971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D17072: Return immediatedly if Method is null, otherwise you'll get a crash when dyn_cast is called with a nullptr

hintonda added a comment. I don't have commit access, so if this patch is accepted, could someone please commit it for me? http://reviews.llvm.org/D17072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D17072: Return immediatedly if Method is null, otherwise you'll get a crash when dyn_cast is called with a nullptr

hintonda updated this revision to Diff 47501. hintonda added a comment. - Added test for PR25181 http://reviews.llvm.org/D17072 Files: lib/Parse/ParseCXXInlineMethods.cpp test/SemaCXX/pr25181-crash-on-invalid.cpp Index: test/SemaCXX/pr25181-crash-on-invalid.cpp

Re: [PATCH] D16971: Fixed crash when partial specialization is missing required parameters

hintonda updated this revision to Diff 47499. hintonda added a comment. - Added test for PR26077 http://reviews.llvm.org/D16971 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/pr26077-crash-on-invalid.cpp Index: test/SemaCXX/pr26077-crash-on-invalid.cpp ==

r260420 - [analyzer] Windows: launch scan-build from an arbitrary location.

Author: ayartsev Date: Wed Feb 10 13:46:41 2016 New Revision: 260420 URL: http://llvm.org/viewvc/llvm-project?rev=260420&view=rev Log: [analyzer] Windows: launch scan-build from an arbitrary location. The following batch files allow to launch scan-build from an arbitrary location if path to clan

Re: [PATCH] D17085: Test commit, fixed "clang" to "Clang" in docs

weimingz added a comment. LGTM http://reviews.llvm.org/D17085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

This revision was automatically updated to reflect the committed changes. Closed by commit rL260414: Fix some Clang-tidy readability-redundant-control-flow warnings; other minor… (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D17060?vs=47415&id=47492#toc Reposit

r260414 - Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes.

Author: eugenezelenko Date: Wed Feb 10 13:11:58 2016 New Revision: 260414 URL: http://llvm.org/viewvc/llvm-project?rev=260414&view=rev Log: Fix some Clang-tidy readability-redundant-control-flow warnings; other minor fixes. Differential revision: http://reviews.llvm.org/D17060 Modified: cfe

Re: [PATCH] D15040: [ARM] Add command-line options for ARMv8.2-A

t.p.northover accepted this revision. t.p.northover added a comment. This revision is now accepted and ready to land. Looks reasonable to me now. Tim. http://reviews.llvm.org/D15040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

r260411 - Silence some MSVC false positive warnings about integer zexts and falling off the end of a covered switch

Author: rnk Date: Wed Feb 10 13:09:15 2016 New Revision: 260411 URL: http://llvm.org/viewvc/llvm-project?rev=260411&view=rev Log: Silence some MSVC false positive warnings about integer zexts and falling off the end of a covered switch Modified: cfe/trunk/lib/CodeGen/MicrosoftCXXABI.cpp

Re: [PATCH] D17060: [Clang] Fix Clang-tidy readability-redundant-control-flow warnings; other minor fixes

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Looks good to me. Repository: rL LLVM http://reviews.llvm.org/D17060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [libcxx] r260337 - Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from

Hi Richard, On 9 February 2016 at 16:59, Richard Smith via cfe-commits wrote: > Fix overload sets of strchr, strpbrk, strrchr, memchr and strstr from > and wcschr, wcspbrk, wcsrchr, wmemchr, and wcsstr from to > provide a const-correct overload set even when the underlying C library does > not.

Re: [PATCH] D16846: PR26449: Fixes for bugs in __builtin_classify_type implementation

andreybokhanko updated this revision to Diff 47475. andreybokhanko added a comment. John, thanks for the re-review! -- I did as you advised, and added *a lot* of switches. :-) Patch updated; please re-review again. http://reviews.llvm.org/D16846 Files: lib/AST/ExprConstant.cpp test/Sema/b

  1   2   >