Author: ctopper
Date: Sat Jan 30 22:20:03 2016
New Revision: 259316
URL: http://llvm.org/viewvc/llvm-project?rev=259316&view=rev
Log:
Replace usage of llvm::utostr_32 with just llvm::utostr. While this is less
efficient, its unclear that the one place using the _32 version was doing so
for effic
EricWF added a comment.
> This also could be fixed in a different way by replacing C-style
> casts with reinterpret_cast<>, which, from my reading of the
> standard, is allowed in this context.
I agree that using `void*` to represent raw memory is the better approach than
`reinterpret_cast<
bruno accepted this revision.
bruno added a reviewer: bruno.
bruno added a comment.
Thanks,
Committed r259311!
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: bruno
Date: Sat Jan 30 18:47:51 2016
New Revision: 259311
URL: http://llvm.org/viewvc/llvm-project?rev=259311&view=rev
Log:
[Parser] Update CachedTokens while parsing ObjectiveC template argument list
Consider the following ObjC++ snippet:
--
@protocol PA;
@protocol PB;
@class NSArray;
Author: ctopper
Date: Sat Jan 30 18:20:24 2016
New Revision: 259309
URL: http://llvm.org/viewvc/llvm-project?rev=259309&view=rev
Log:
Convert an unsigned to Twine instead of using utostr since we're already
building a Twine. NFC
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/IssueHash.cpp
Modi
Author: ctopper
Date: Sat Jan 30 18:20:26 2016
New Revision: 259310
URL: http://llvm.org/viewvc/llvm-project?rev=259310&view=rev
Log:
No need to use utostr when putting integers into a raw_ostream. NFC
Modified:
cfe/trunk/utils/TableGen/NeonEmitter.cpp
Modified: cfe/trunk/utils/TableGen/Neon
dcoughlin added a subscriber: cfe-commits.
dcoughlin added a comment.
Also adding cfe-commits as a subscriber. (See
http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).
http://reviews.llvm.org/D16748
___
cfe-commits mai
dim added a comment.
In http://reviews.llvm.org/D16264#340131, @compnerd wrote:
> `-p` or `-pg` also effects the math library. Please adjust the tests and the
> driver to reflect that.
This is already handled in `lib/Driver/Tools.cpp`, in
`freebsd::Linker::ConstructJob()`:
if (!Args.hasAr
compnerd added a comment.
`-p` or `-pg` also effects the math library. Please adjust the tests and the
driver to reflect that.
http://reviews.llvm.org/D16264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
On 30/01/16 18:36, David Blaikie wrote:
On Sat, Jan 30, 2016 at 9:00 AM, Vassil Vassilev
mailto:v.g.vassi...@gmail.com>> wrote:
AFAICT the making a test case independent on STL is the hard part.
I think it will be always failing due to the relocation of the
memory region of the u
Why isn't this logic buried in GetArgumentVector so that other tools may
take advantage of it?
On Saturday, January 30, 2016, Igor Chesnokov via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> ichesnokov added a comment.
>
> Please review and commit.
>
>
> Repository:
> rL LLVM
>
> http://re
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=15685
Repository:
rL LLVM
http://reviews.llvm.org/D16574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
On Sat, Jan 30, 2016 at 9:00 AM, Vassil Vassilev
wrote:
> AFAICT the making a test case independent on STL is the hard part. I think
> it will be always failing due to the relocation of the memory region of the
> underlying SmallVector.
>
Sorry, I think I didn't explain myself well. What I mean
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=15685
Repository:
rL LLVM
http://reviews.llvm.org/D16750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
AFAICT the making a test case independent on STL is the hard part. I
think it will be always failing due to the relocation of the memory
region of the underlying SmallVector.
On 30/01/16 17:37, David Blaikie wrote:
Yeah, it's good to have a reproduction, but I wouldn't actually commit
one - u
ichesnokov added a comment.
Please review and commit.
Repository:
rL LLVM
http://reviews.llvm.org/D16750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov created this revision.
ichesnokov added reviewers: asl, kraiskil.
ichesnokov added a subscriber: cfe-commits.
ichesnokov set the repository for this revision to rL LLVM.
A simple patch to ensure that char is signed. Check assumed for OpenCL only.
Repository:
rL LLVM
http://reviews.l
Yeah, it's good to have a reproduction, but I wouldn't actually commit one
- unless you have a checked stl to test against that always fails on
possibly-invalidating sequences of operations, then you'd have a fairly
simple reproduction
On Jan 30, 2016 8:23 AM, "Vassil Vassilev" wrote:
> Sorry.
>
Sorry.
Our module builds choke on merging several modules, containing
declarations from STL (we are using libc++, no modulemaps).
When writing a new module containing the definition of a STL
reverse_iterator, it collects all its template specializations. Some of
the specializations need to b
It might be handy to give an overview of the issue in the review (&
certainly in the commit) message rather than only citing the bug number
On Jan 30, 2016 6:49 AM, "Vassil Vassilev via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> Attaching a fix to https://llvm.org/bugs/show_bug.cgi?id=262
Attaching a fix to https://llvm.org/bugs/show_bug.cgi?id=26237
Please review.
Many thanks!
--Vassil
From da6b27875042ee23afaf898f189e410f177311ad Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Sat, 30 Jan 2016 14:50:06 +0100
Subject: [PATCH] [modules] Writing out template specializations
Shouldn't the new case be in -Wc++11-narrowing instead? This is warning in
similar places where that warning used to warn.
In practice, char arrays seem to be often used for storing binary blobs in
header files, and those are usually initialized with numbers 0...255
instead of -128...127 (why not
ichesnokov set the repository for this revision to rL LLVM.
ichesnokov updated this revision to Diff 46470.
ichesnokov added a comment.
Removed unuseful patch code.
Repository:
rL LLVM
http://reviews.llvm.org/D16351
Files:
lib/Sema/SemaDecl.cpp
test/SemaOpenCL/implicit-typedef.cl
Index:
ichesnokov added a comment.
BugZilla page: https://llvm.org/bugs/show_bug.cgi?id=25404
Please review and submit this bug.
Comment at: test/SemaOpenCL/implicit-typedef.cl:2
@@ +1,2 @@
+// RUN: %clang_cc1 "-cc1" "-emit-llvm" "-D" "cl_khr_fp64" "-D"
"cl_khr_int64_base_atomics" "-
ichesnokov added a comment.
Please review and commit.
Repository:
rL LLVM
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ichesnokov added a comment.
BugZilla page:
https://llvm.org/bugs/show_bug.cgi?id=25404
Repository:
rL LLVM
http://reviews.llvm.org/D16351
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
ichesnokov added inline comments.
Comment at: test/SemaOpenCL/implicit-typedef.cl:2
@@ +1,2 @@
+// RUN: %clang_cc1 "-cc1" "-emit-llvm" "-D" "cl_khr_fp64" "-D"
"cl_khr_int64_base_atomics" "-fno-dwarf-directory-asm" "-fmessage-length" "205"
"-fdiagnostics-show-option" "-cl-std=CL2
dim added a comment.
Ping.
http://reviews.llvm.org/D16264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Sat Jan 30 06:16:23 2016
New Revision: 259304
URL: http://llvm.org/viewvc/llvm-project?rev=259304&view=rev
Log:
[AST] Pull simple method inline.
Modified:
cfe/trunk/include/clang/AST/ASTTypeTraits.h
cfe/trunk/lib/AST/ASTTypeTraits.cpp
Modified: cfe/trunk/include/clang/A
Author: davide
Date: Sat Jan 30 02:03:54 2016
New Revision: 259302
URL: http://llvm.org/viewvc/llvm-project?rev=259302&view=rev
Log:
assert(false) -> llvm_unreachable().
Modified:
cfe/trunk/lib/AST/Expr.cpp
cfe/trunk/lib/AST/StmtPrinter.cpp
cfe/trunk/lib/Serialization/ASTWriterStmt.cp
30 matches
Mail list logo
