Hi,
On 01/28/2016 09:25 PM, Hans Wennborg via cfe-commits wrote:
> I don't think we have a specific code owner for OpenCL in Clang, which
> means Richard is the owner.
FYI, in a separate thread, there's an attempt to elect Anastasia as one.
--
Pekka
_
congliu updated this revision to Diff 46360.
congliu added a comment.
- Fixed a nit in test file.
http://reviews.llvm.org/D16587
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
clang-tidy/misc/VirtualNearMissCheck.h
docs/clang-tidy/checks/misc-virtual-near-miss.rst
test/clang-tidy/misc-
congliu updated this revision to Diff 46359.
congliu added a comment.
- Fixed bugs introduced by getCanonicalDecl. Has errs log.
- Cleared up logs.
- Added mathcers for static method and overloaded operator.
- Change key type of map from string to pointer to imporve performance.
- Change implement
gottesmm updated this revision to Diff 46354.
gottesmm added a comment.
Added documentation.
http://reviews.llvm.org/D16708
Files:
include/clang/Basic/Attr.td
lib/Sema/SemaDeclAttr.cpp
test/SemaObjC/attr-cf_no_release.m
Index: test/SemaObjC/attr-cf_no_release.m
==
Committed revision 259160
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
29.01.2016 7:57, Bataev, Alexey пишет:
> I will merge this fix
>
> Best regards,
> Alexey Bataev
> =
> Software Engineer
> Intel Compiler Team
>
> 28.01.2016 22:18, Hans Wennborg
rjmccall added a comment.
In http://reviews.llvm.org/D15120#337975, @hubert.reinterpretcast wrote:
> In http://reviews.llvm.org/D15120#337654, @rjmccall wrote:
>
> > In http://reviews.llvm.org/D15120#337552, @hubert.reinterpretcast wrote:
> >
> > > It remains that the present standardization effo
I will merge this fix
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
28.01.2016 22:18, Hans Wennborg пишет:
> Alexey: you're the owner of openmp in Clang.
>
> Can you comment on what should be merged here?
>
> On Tue, Jan 26, 2016 at 3:43 PM, Jack Howarth
> wrote
This revision was automatically updated to reflect the committed changes.
nwilson marked an inline comment as done.
Closed by commit rL259159: [Concepts] Implement a portion of Concepts
TS[dcl.spec.concept]p5 and p6: (authored by nwilson).
Changed prior to commit:
http://reviews.llvm.org/D16163
Author: nwilson
Date: Thu Jan 28 22:43:59 2016
New Revision: 259159
URL: http://llvm.org/viewvc/llvm-project?rev=259159&view=rev
Log:
[Concepts] Implement a portion of Concepts TS[dcl.spec.concept]p5 and p6:
Diagnose if the return type of a function concept or declaration type of a
variable concep
Author: ctopper
Date: Thu Jan 28 22:01:09 2016
New Revision: 259156
URL: http://llvm.org/viewvc/llvm-project?rev=259156&view=rev
Log:
Remove unnecessary forward declaration. NFC
Modified:
cfe/trunk/include/clang/Basic/SourceManager.h
Modified: cfe/trunk/include/clang/Basic/SourceManager.h
UR
LegalizeAdulthood updated this revision to Diff 46341.
LegalizeAdulthood added a comment.
Update from review comments, add test case
http://reviews.llvm.org/D8149
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
include/clang/ASTMatchers/ASTMatchersInternal
doug.gregor accepted this revision.
doug.gregor added a comment.
This approach looks great to me.
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MatzeB created this revision.
MatzeB added reviewers: chandlerc, reames, echristo.
MatzeB added a subscriber: cfe-commits.
MatzeB set the repository for this revision to rL LLVM.
Herald added a subscriber: mcrosier.
These sets perform linear searching in small mode so it is never a good
idea to us
LegalizeAdulthood marked 4 inline comments as done.
Comment at: clang-tidy/readability/RedundantControlFlowCheck.cpp:59
@@ +58,3 @@
+ CompoundStmt::const_reverse_body_iterator last = Block->body_rbegin();
+ if (const auto *Return = dyn_cast(*last)) {
+issueDiagnostic(Result,
LegalizeAdulthood updated this revision to Diff 46334.
LegalizeAdulthood marked an inline comment as done.
LegalizeAdulthood added a comment.
Update from review comments
http://reviews.llvm.org/D16259
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/ReadabilityTidyModule.
probinson added a comment.
Ping. FWIW in today's DWARF meeting, we agreed that the Appendix D example of
an anonymous namespace should have an explicit import from the containing scope
(see DWARF v4, Figure 57 on p.233; it was essentially unchanged in the v5
draft).
http://reviews.llvm.org/D
bruno updated this revision to Diff 46332.
bruno added a comment.
Update the patch to use ArrayRef and remove a misleading assertion.
Richard, any more comments regarding this approach?
Thanks,
http://reviews.llvm.org/D15173
Files:
include/clang/Lex/Preprocessor.h
lib/Lex/PPCaching.cpp
l
LegalizeAdulthood updated this revision to Diff 46333.
LegalizeAdulthood marked 3 inline comments as done.
LegalizeAdulthood added a comment.
Herald added a subscriber: klimek.
Update from review comments.
Extend analysis of newlines to prevent pathological raw strings from being
introduced.
Exte
pxli168 added inline comments.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:906
@@ +905,3 @@
+def err_opencl_unroll_hint_on_non_loop : Error<
+ "OpenCL only supports opencl_unroll_hint on for, while, and do statements">;
+
you can change it to opencl_u
pxli168 added inline comments.
Comment at: lib/Sema/SemaLookup.cpp:698
@@ +697,3 @@
+// tgmath.h, time.h, wchar.h and wctype.h are not available and cannot
+// be included by a program.
+if (S.getLangOpts().OpenCL &&
I think the
> C99 sta
Author: echristo
Date: Thu Jan 28 19:35:53 2016
New Revision: 259137
URL: http://llvm.org/viewvc/llvm-project?rev=259137&view=rev
Log:
Use a consistent spelling for vtables.
Modified:
cfe/trunk/include/clang/Basic/TargetCXXABI.h
cfe/trunk/lib/CodeGen/CGClass.cpp
cfe/trunk/lib/CodeGen/
Author: echristo
Date: Thu Jan 28 19:35:55 2016
New Revision: 259138
URL: http://llvm.org/viewvc/llvm-project?rev=259138&view=rev
Log:
Add the clang debug info test directory to .gitignore as it's managed
separately.
Modified:
cfe/trunk/.gitignore
Modified: cfe/trunk/.gitignore
URL:
http:/
> On Jan 28, 2016, at 4:57 PM, David Blaikie wrote:
>
> +Adrian for Apple/LLDB perspective
>
> One way to merge the tests would be to add another command line argument into
> DwarfDebug (see the way the split-dwarf command line argument is used), just
> for testing purposes. The command line
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: alexfh, LegalizeAdulthood, piotrdz,
aaron.ballman.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
This is fix for PR26295. I added configuration option to
readab
Richard Smith: Is there a reasonable way to get the ')' of an "if ()"
expression in the AST? Is it just a matter of going down and playing games
with source locations/lexing to get the token after the end location of the
condition expression?
On Thu, Jan 28, 2016 at 4:57 PM, Wolfgang Pieb via cfe-
wolfgangp added a comment.
> Clang (with patch)
> 3, 5, 4, 5, 7
> 9, 11, 10, 11, 14
>
> So that's somewhat problematic - we shouldn't visit 11 at all. (but we are
> today, as is GCC... so maybe NBD?)
Well, if op&& is overloaded, wouldn't we lose the short-circuit property? If so
it ma
+Adrian for Apple/LLDB perspective
One way to merge the tests would be to add another command line argument
into DwarfDebug (see the way the split-dwarf command line argument is
used), just for testing purposes. The command line argument can override
the value specified in the metadata - so you ca
kromanova created this revision.
kromanova added reviewers: dblaikie, echristo, probinson.
kromanova added a subscriber: cfe-commits.
kromanova set the repository for this revision to rL LLVM.
Hello,
The compiler always emits .debug_line version 2, though some opcodes from DWARF
3 (e.g. DW_LNS_se
Hm, well,
https://llvm.org/svn/llvm-project/cfe/trunk/tools/clang-format/git-clang-format
is close... Not sure if that triggers the bff clause, will consult my
attorney.
On Thu, Jan 28, 2016 at 4:09 PM, Justin Lebar wrote:
> Do you have a script that will take as input a commit range and git
>
Do you have a script that will take as input a commit range and git
commit --amend clang-tidy fixes for lines modified in that range?
Because if so,
a) I would be your best friend forever, and
b) It should be simple to convert that into a linter for arc to catch
the case when I forget to run said
echristo added inline comments.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87
@@ +86,3 @@
+ // Construct and fill the args buffer that we'll pass to vprintf.
+ llvm::Value* BufferPtr;
+ if (Args.size() <= 1) {
jlebar wrote:
> echristo wrote:
> > * on the wrong s
jlebar marked an inline comment as done.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87
@@ +86,3 @@
+ // Construct and fill the args buffer that we'll pass to vprintf.
+ llvm::Value* BufferPtr;
+ if (Args.size() <= 1) {
echristo wrote:
> * on the wrong side ;)
Ar
This revision was automatically updated to reflect the committed changes.
jlebar marked an inline comment as done.
Closed by commit rL259122: [CUDA] Generate CUDA's printf alloca in its
function's entry block. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16664?vs=4631
Author: jlebar
Date: Thu Jan 28 17:58:28 2016
New Revision: 259122
URL: http://llvm.org/viewvc/llvm-project?rev=259122&view=rev
Log:
[CUDA] Generate CUDA's printf alloca in its function's entry block.
Summary:
This is necessary to prevent llvm from generating stacksave intrinsics
around this allo
Author: mren
Date: Thu Jan 28 17:36:05 2016
New Revision: 259119
URL: http://llvm.org/viewvc/llvm-project?rev=259119&view=rev
Log:
Class Property: change PropertyMap to include isClassProperty.
PropertyMap used to map IdentifierInfo (name of the property) to
ObjcPropertyDecl *. Now that a class p
Author: dcoughlin
Date: Thu Jan 28 17:34:13 2016
New Revision: 259118
URL: http://llvm.org/viewvc/llvm-project?rev=259118&view=rev
Log:
[analyzer] NullabilityChecker: Remove unused isReturnSelf() function.
Remove the now-unused isReturnSelf() function so we don't get a compiler
warning. Apologies
Author: mren
Date: Thu Jan 28 17:29:02 2016
New Revision: 259116
URL: http://llvm.org/viewvc/llvm-project?rev=259116&view=rev
Log:
Check for frontend errors after releasing the Builder.
Frontend can emit errors when releaseing the Builder. If there are errors before
or when releasing the Builder,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259116: Check for frontend errors after releasing the
Builder. (authored by mren).
Changed prior to commit:
http://reviews.llvm.org/D16564?vs=46301&id=46320#toc
Repository:
rL LLVM
http://reviews.ll
davidxl added inline comments.
Comment at: lib/Driver/Tools.cpp:3232
@@ -3231,2 +3231,3 @@
CmdArgs.push_back(
Args.MakeArgString(Twine("-fprofile-instr-generate=") + Path));
+}
I also suggest changing CC1 option -fprofile-instr-generate= to b
On Thu, Jan 28, 2016 at 2:34 PM, Rong Xu wrote:
> The previous patch was not good as it failed 58 tests that use
> -fprofile-instr-generate as a cc1 option.
>
> I can see two methods to solve this:
> (1) we change all the 58 tests to use -fprofile-instrument=Clang option.
My vote is on (1) -- get
Author: rafael
Date: Thu Jan 28 16:56:41 2016
New Revision: 259108
URL: http://llvm.org/viewvc/llvm-project?rev=259108&view=rev
Log:
Update for llvm change.
Modified:
cfe/trunk/test/CodeGen/pr18235.c
Modified: cfe/trunk/test/CodeGen/pr18235.c
URL:
http://llvm.org/viewvc/llvm-project/cfe/tru
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
One inline nit then LGTM.
-eric
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:87
@@ +86,3 @@
+ // Construct and fill the args buffer tha
echristo added a comment.
> The other reason, which is less important, is that when you have one arch and
> ptxas fails -- which, it shouldn't, but we're not good enough to catch
> everything yet, and likely won't be for some time -- the error you get is
>
> ptxas: foo is not defined
>
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
Seems like a weird place to handle this, but it's been there for a long time.
That said, I see how we can get there now, thanks!
-eric
http://reviews.llvm.org/D16564
_
jlebar added inline comments.
Comment at: lib/Driver/Driver.cpp:652
@@ -640,3 +651,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
tra wrote:
>
jlebar updated this revision to Diff 46315.
jlebar marked 3 inline comments as done.
jlebar added a comment.
Pass StopOnFailure = true when running the preprocessor after an ICE.
http://reviews.llvm.org/D16514
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include
xur added a comment.
The previous patch was not good as it failed 58 tests that use
-fprofile-instr-generate as a cc1 option.
I can see two methods to solve this:
(1) we change all the 58 tests to use -fprofile-instrument=Clang option.
(2) Fall back to my previous patch: keep -fprofile-instr-gene
The previous patch was not good as it failed 58 tests that use
-fprofile-instr-generate as a cc1 option.
I can see two methods to solve this:
(1) we change all the 58 tests to use -fprofile-instrument=Clang option.
(2) Fall back to my previous patch: keep -fprofile-instr-generate as
the CC1 option
jlebar marked 3 inline comments as done.
jlebar added a comment.
Thank you for the reviews.
Please have another look; I switched to using a struct proper. It's a lot
cleaner! We're now assuming that the struct is aligned in the same way as
vprintf wants, but if anything I expect this new code
jlebar updated this revision to Diff 46314.
jlebar marked an inline comment as done.
jlebar added a comment.
Use a struct rather than an i8 buffer.
http://reviews.llvm.org/D16664
Files:
lib/CodeGen/CGCUDABuiltin.cpp
test/CodeGenCUDA/printf.cu
Index: test/CodeGenCUDA/printf.cu
=
Author: dcoughlin
Date: Thu Jan 28 16:23:34 2016
New Revision: 259099
URL: http://llvm.org/viewvc/llvm-project?rev=259099&view=rev
Log:
[analyzer] Suppress nullability warnings in copy, mutableCopy, and init
families.
There are multiple, common idioms of defensive nil-checks in copy,
mutableCopy
ygao created this revision.
ygao added subscribers: gkistanova, sqlbyme, cfe-commits, llvm-commits.
Hi,
So this patch tries to enable tests that will output to the console. These
tests are otherwise not exercised.
Note that the outputs will stay on the console and will not be saved into the
test
Exactly :-)
On Thu, Jan 28, 2016 at 5:07 PM, Yaron Keren wrote:
> The instantiated does get a new collection of ParmVarDecls while getting
> the pattern Type which points to the pattern ParmVarDecls. So the
> ParmVarDecls pointed in the instantiated are not the same as those pointed
> by its Typ
The instantiated does get a new collection of ParmVarDecls while getting
the pattern Type which points to the pattern ParmVarDecls. So the
ParmVarDecls pointed in the instantiated are not the same as those pointed
by its Type.
Traversing by Type or by the Decl finds a different set of ParmVarDecls
thakis added a comment.
Did this ever land? Looks like it's lgtm'd and ready to go, and it looks like a
useful warning.
http://reviews.llvm.org/D3976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
tra added inline comments.
Comment at: lib/Driver/Driver.cpp:652
@@ -640,3 +651,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
jlebar wrote:
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259095: Implementation of PS4 ABI, Round 1 (authored by
ssrivastava).
Changed prior to commit:
http://reviews.llvm.org/D16607?vs=46060&id=46310#toc
Repository:
rL LLVM
http://reviews.llvm.org/D16607
Author: ssrivastava
Date: Thu Jan 28 15:36:31 2016
New Revision: 259095
URL: http://llvm.org/viewvc/llvm-project?rev=259095&view=rev
Log:
Implementation of PS4 ABI, Round 1
Added a test to safeguard linux ABI.
Differential Revision: http://reviews.llvm.org/D16607
Modified:
cfe/trunk/test/Sem
jlebar added a comment.
In http://reviews.llvm.org/D16514#338631, @echristo wrote:
> In general it feels like keeping 2 errors might make the most sense:
>
> #if _NOT_ARCH4_
> #error "aiee!"
> #endif
>
> clang -arch arch1 -arch arch2 -arch arch3 -arch arch4 t.c
>
> seems like it might be nice t
Author: dsanders
Date: Thu Jan 28 15:03:16 2016
New Revision: 259092
URL: http://llvm.org/viewvc/llvm-project?rev=259092&view=rev
Log:
Merging r259046:
r259046 | dsanders | 2016-01-28 13:49:33 + (Thu, 28 Jan 2016) | 18 li
Thanks. Merged in r259092.
From: hwennb...@google.com [hwennb...@google.com] on behalf of Hans Wennborg
[h...@chromium.org]
Sent: 28 January 2016 17:56
To: Daniel Sanders
Cc: cfe-commits@lists.llvm.org; e...@efcs.ca
Subject: Re: [libcxx] r259046 - [libcxx]
Author: eugenezelenko
Date: Thu Jan 28 15:00:21 2016
New Revision: 259091
URL: http://llvm.org/viewvc/llvm-project?rev=259091&view=rev
Log:
Remove autoconf support.
Differential revision: http://reviews.llvm.org/D16651
Removed:
libcxx/trunk/Makefile
Removed: libcxx/trunk/Makefile
URL:
http
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D13420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
thakis added a comment.
In http://reviews.llvm.org/D16478#338653, @rnk wrote:
> The fact that an instantiated type might point to decls from the template
> pattern seems like expected behavior. The parts of the template that are the
> same are supposed to be shared.
>
> Can we dig in to what is
rnk added a comment.
The fact that an instantiated type might point to decls from the template
pattern seems like expected behavior. The parts of the template that are the
same are supposed to be shared.
Can we dig in to what is going wrong in parent map construction?
http://reviews.llvm.org/
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/Driver/Driver.cpp:652
@@ -640,3 +651,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /*
echristo added a comment.
In general it feels like keeping 2 errors might make the most sense:
(Using a multiarch build rather than a cuda command line, but it should still
be the same behavior for consistency)
t.c:
#if _NOT_ARCH4_
#error "aiee!"
#endif
clang -arch arch1 -arch arch2 -arch arc
FYI :)
Here is the back trace when emitting the error:
* frame #0: 0x00010271ea30
clang`clang::CodeGen::CodeGenFunction::EmitBuiltinExpr(this=0x7fff5fbf8c58,
FD=0x00010f214260, BuiltinID=1483, E=0x00010f214500,
ReturnValue=ReturnValueSlot at 0x7fff5fbf5fe0) + 49360 at
CGBuil
xur updated this revision to Diff 46303.
xur added a comment.
Integrated most recently comments/suggestions from David and Sean.
Thanks,
-Rong
http://reviews.llvm.org/D15829
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/CC1Options.td
include/clang/Driver/Optio
echristo accepted this revision.
echristo added a reviewer: echristo.
echristo added a comment.
This revision is now accepted and ready to land.
Yep. As I said, I expect to be on the losing side of that argument - just too
much prior art :)
-eric
http://reviews.llvm.org/D15999
_
echristo added inline comments.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:109
@@ -106,1 +108,3 @@
+// stacksave/stackrestore intrinsics, which cause our nvvm backend to
choke.
+auto *Alloca = new llvm::AllocaInst(
llvm::Type::getInt8Ty(Ctx), llvm::ConstantInt::ge
thakis added a comment.
rnk, I added you because you hacked in this general area a while ago in
r187528. Since Richard is out, do you think you can take a look?
http://reviews.llvm.org/D16478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk added inline comments.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:105-108
@@ -104,2 +104,6 @@
} else {
-BufferPtr = Builder.Insert(new llvm::AllocaInst(
+// Insert our alloca not into the current BB, but into the function's entry
+// block. This is important bec
Anastasia added a comment.
Btw, just to be clear in my previous comment I was referring to the 2nd switch
statement in CodeGenTypes::GetFunctionType that contains the line:
ArgTypes[FirstIRArg] = LTy->getPointerTo();
http://reviews.llvm.org/D15603
_
Hello everyone,
LLVM buildmaster will be taken off-line today after 5 PM Pacific for short
time for maintenance and also will be updated.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
Anastasia added a comment.
Yes, I see that it happens only for some vector types. The CodeGen follows
quite different paths for both targets. And in the case of s390x-linux-gnu it
ends up in ABIArgInfo::Indirect case of the second switch statement where an
additional pointer will be added here:
I'm also just curious how we got all the way to here without having the
error emitted and compilation stopped?
-eric
On Thu, Jan 28, 2016 at 9:53 AM Justin Bogner wrote:
> Manman Ren via cfe-commits writes:
> > manmanren created this revision.
> > manmanren added reviewers: echristo, rafael, a
manmanren updated this revision to Diff 46301.
manmanren added a comment.
Addressing comments from Akira and Justin.
http://reviews.llvm.org/D16564
Files:
lib/CodeGen/ModuleBuilder.cpp
test/CodeGen/target-builtin-error-3.c
Index: test/CodeGen/target-builtin-error-3.c
==
jlebar added inline comments.
Comment at: lib/Driver/Driver.cpp:650
@@ -638,3 +649,3 @@
SmallVector, 4> FailingCommands;
- C.ExecuteJobs(C.getJobs(), FailingCommands);
+ C.ExecuteJobs(C.getJobs(), /* StopOnFailure = */ false, FailingCommands);
tra wrote:
>
jlebar updated this revision to Diff 46300.
jlebar marked an inline comment as done.
jlebar added a comment.
Address tra's review comment (rename flag).
http://reviews.llvm.org/D16514
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
include/clang/Driver/Options.td
Author: nico
Date: Thu Jan 28 13:25:00 2016
New Revision: 259079
URL: http://llvm.org/viewvc/llvm-project?rev=259079&view=rev
Log:
Include RecordDecls from anonymous unions in the AST.
For
void f() {
union { int i; };
}
clang used to omit the RecordDecl from the anonymous union from the
Sorry for the slow reply.
I've replied on the r258782 thread.
On Tue, Jan 26, 2016 at 10:29 AM, Anastasia Stulova
wrote:
> Could you please merge Clang commit r258782 into release 3.8.
>
>
>
> It adds Pipe BIFs to be used along with Pipe type committed earlier (in
> r257254).
>
>
>
> Thanks,
>
>
I don't think we have a specific code owner for OpenCL in Clang, which
means Richard is the owner.
Richard, what do you think?
On Wed, Jan 27, 2016 at 10:08 PM, xiuli pan wrote:
> Hi hans,
>
> Request to merge it to release 38
>
> It adds Pipe BIFs to be used along with Pipe type committed earli
Alexey: you're the owner of openmp in Clang.
Can you comment on what should be merged here?
On Tue, Jan 26, 2016 at 3:43 PM, Jack Howarth
wrote:
> Tested the attached patch which contains a back port of the net
> changes from both r258307 and
>
> Author: abataev
> Date: Fri Jan 22 02:56:50 2016
Author: nico
Date: Thu Jan 28 13:12:32 2016
New Revision: 259077
URL: http://llvm.org/viewvc/llvm-project?rev=259077&view=rev
Log:
Remove unused parameter.
Modified:
cfe/trunk/lib/Sema/SemaDecl.cpp
Modified: cfe/trunk/lib/Sema/SemaDecl.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/
tra added inline comments.
Comment at: include/clang/Driver/Options.td:1807
@@ +1806,3 @@
+"CUDA compilation without --save-temps.">;
+def nostop_on_failure : Flag<["-"], "nostop-on-failure">,
Flags<[DriverOption]>;
+
I'd use 'no-' prefix.
C
Author: mren
Date: Thu Jan 28 12:49:28 2016
New Revision: 259070
URL: http://llvm.org/viewvc/llvm-project?rev=259070&view=rev
Log:
Class Property: class property and instance property can have the same name.
Add "enum ObjCPropertyQueryKind" to a few APIs that used to only take the name
of the pro
uweigand added a comment.
In http://reviews.llvm.org/D15603#338488, @Anastasia wrote:
> No, this shouldn't happen! There shouldn't be any difference in emitted IR
> depending on a platform. I also don't see any code in CodeGen that could
> specialize.
>
> Is there a way to reproduce your compil
Author: davidxl
Date: Thu Jan 28 12:25:53 2016
New Revision: 259067
URL: http://llvm.org/viewvc/llvm-project?rev=259067&view=rev
Log:
[PGO] test case cleanups
1. Make test case more focused and robust by focusing on what to be tested
(linkage, icall) -- make it easier to validate
2. Testing link
jlebar marked an inline comment as done.
jlebar added a comment.
http://reviews.llvm.org/D16664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar marked an inline comment as done.
Comment at: lib/CodeGen/CGCUDABuiltin.cpp:109
@@ -106,1 +108,3 @@
+// stacksave/stackrestore intrinsics, which cause ptxas to choke.
+auto *Alloca = new llvm::AllocaInst(
llvm::Type::getInt8Ty(Ctx), llvm::ConstantInt::get(I
jlebar updated this revision to Diff 46293.
jlebar added a comment.
Address echristo's review comments.
http://reviews.llvm.org/D16664
Files:
lib/CodeGen/CGCUDABuiltin.cpp
test/CodeGenCUDA/printf.cu
Index: test/CodeGenCUDA/printf.cu
=
bcraig added a comment.
I plan on submitting this tomorrow morning (my time) so that I have lots of
time to monitor build failures.
http://reviews.llvm.org/D16634
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
bcraig updated this revision to Diff 46292.
bcraig added a comment.
CloudABI doesn't define unix, so stop blacklisting it explicitly and let the
whitelist filter it out.
http://reviews.llvm.org/D16634
Files:
src/thread.cpp
Index: src/thread.cpp
==
bcraig updated this revision to Diff 46291.
bcraig added a comment.
CloudABI doesn't define __unix__, so stop blacklisting it explicitly and let
the whitelist filter it out.
http://reviews.llvm.org/D16639
Files:
include/__config
include/locale
Index: include/locale
===
Author: nico
Date: Thu Jan 28 12:06:31 2016
New Revision: 259063
URL: http://llvm.org/viewvc/llvm-project?rev=259063&view=rev
Log:
Fix strange indent.
Modified:
cfe/trunk/lib/CodeGen/CGStmt.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmt.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib
Anastasia added a comment.
No, this shouldn't happen! There shouldn't be any difference in emitted IR
depending on a platform. I also don't see any code in CodeGen that could
specialize.
Is there a way to reproduce your compilation? Passing any triple?
http://reviews.llvm.org/D15603
__
xur added a comment.
I'll send an updated patch shortly.
Comment at: include/clang/Frontend/CodeGenOptions.def:106
@@ -105,3 +105,3 @@
-CODEGENOPT(ProfileInstrGenerate , 1, 0) ///< Instrument code to generate
-///< execution counts to us
Yes, go ahead.
Thanks,
Hans
On Thu, Jan 28, 2016 at 5:57 AM, Daniel Sanders
wrote:
> Hi Hans,
>
> Is it ok to merge this into 3.8? Eric Fiselier has already approved on the
> review.
>
> From: cfe-commits [cfe-commits-boun...@lists.llvm.org] on behalf of
Author: vedantk
Date: Thu Jan 28 11:52:18 2016
New Revision: 259061
URL: http://llvm.org/viewvc/llvm-project?rev=259061&view=rev
Log:
[Coverage] Use a set to track visited FileIDs (NFC)
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.
1 - 100 of 126 matches
Mail list logo
