EricWF added inline comments.
Comment at: test/libcxx/test/config.py:364
@@ +363,3 @@
+deduced_use_stdlib_eq_libcxx = (self.cxx.isClang() and
+cxx_abi == 'none' and
+not use_llvm_unwinder)
Thank you for the review. I added a test to check the "redeclaration of
type parameter" error message and committed it as r255754.
On Tue, Dec 15, 2015 at 4:55 PM, Justin Bogner
wrote:
> Akira Hatanaka writes:
> > On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner
> > wrote:
> >
> >> Akira Hatana
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255754: [Objective-c] Fix a crash that occurs when
ObjCTypeParamList::back() is (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D15463?vs=42560&id=42962#toc
Repository:
rL LL
Author: ahatanak
Date: Wed Dec 16 00:25:38 2015
New Revision: 255754
URL: http://llvm.org/viewvc/llvm-project?rev=255754&view=rev
Log:
[Objective-c] Fix a crash that occurs when ObjCTypeParamList::back() is
called on an empty list.
This commit makes Parser::parseObjCTypeParamListOrProtocolRefs re
Author: ctopper
Date: Wed Dec 16 00:24:28 2015
New Revision: 255753
URL: http://llvm.org/viewvc/llvm-project?rev=255753&view=rev
Log:
[CodeGen] Use llvm::CmpInst::Predicate instead of unsigned for parameter types
in EmitCompare to eliminate some later explicit casts. NFC.
Modified:
cfe/trunk
zaks.anna added a comment.
Looks good overall; comments below.
Please, provide more information on real world code evaluation. Which codebases
this has been tested on? What was the false positive rate? How many real bugs
were found/fixed?
What is the criteria for taking it out of alpha?
Pleas
Author: rnk
Date: Tue Dec 15 20:04:40 2015
New Revision: 255744
URL: http://llvm.org/viewvc/llvm-project?rev=255744&view=rev
Log:
Print qualified display names when emitting CodeView
This is what debuggers expect. Words towards fixing PR21528.
Added:
cfe/trunk/test/CodeGenCXX/debug-info-cod
zaks.anna added a comment.
Sorry, I forgot to read the description before commenting; I see it is intended
to be used not only for debugging purposes:)
http://reviews.llvm.org/D15448
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
jhen added a subscriber: jhen.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:95
@@ -78,3 +94,3 @@
#define __CUDACC__
#include_next "cuda_runtime.h"
Now that the name of this header has been changed, would it be appropriate to
change this #include_nex
zaks.anna added a comment.
Can/Should something like this be used when dumping SVals (during debugging)?
(Possibly in addition to the debug checker.)
What are the advantages of implementing this using visitors? Can this be
implemented similarly to SVal::dumpToStream? Do you envision other use ca
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255740: [CMake] Add support for generating profdata for
clang from training files (authored by cbieneman).
Changed prior to commit:
http://reviews.llvm.org/D15462?vs=42891&id=42943#toc
Repository:
rL
Author: cbieneman
Date: Tue Dec 15 19:02:44 2015
New Revision: 255740
URL: http://llvm.org/viewvc/llvm-project?rev=255740&view=rev
Log:
[CMake] Add support for generating profdata for clang from training files
Summary:
This patch adds support for using LIT to drive generating PGO profile data for
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
The substance of the patch LGTM. My nit picking is just on the wording of the
comment. =] Submit whenever.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:25-26
Akira Hatanaka writes:
> On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner
> wrote:
>
>> Akira Hatanaka writes:
>> > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner
>> > wrote:
>> >
>> >> Akira Hatanaka via cfe-commits writes:
>> >> > ahatanak created this revision.
>> >> > ahatanak added a subs
Author: ericwf
Date: Tue Dec 15 18:53:04 2015
New Revision: 255738
URL: http://llvm.org/viewvc/llvm-project?rev=255738&view=rev
Log:
Make noexcept specifications on __hash_table definitions match their
declarations.
Modified:
libcxx/trunk/include/__hash_table
Modified: libcxx/trunk/include/
Sean Silva writes:
> silvas added a comment.
>
> Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it;
> they're likely to have more higher-level thoughts.
I'm fine with the concept and Sean's LGTM should cover the details :)
>
>
> Comment at: utils/perf-trainin
Author: eugenis
Date: Tue Dec 15 18:38:42 2015
New Revision: 255736
URL: http://llvm.org/viewvc/llvm-project?rev=255736&view=rev
Log:
[cfi] Exclude ubsan runtime library from non-diag CFI builds (driver changes).
Split the CFI runtime in two: cfi and cfi_diag. The latter includes
UBSan runtime to
Author: ericwf
Date: Tue Dec 15 18:35:45 2015
New Revision: 255734
URL: http://llvm.org/viewvc/llvm-project?rev=255734&view=rev
Log:
Workaround nasty GCC bug that caused testsuite to hang
Modified:
libcxx/trunk/include/utility
Modified: libcxx/trunk/include/utility
URL:
http://llvm.org/view
Author: rnk
Date: Tue Dec 15 18:26:37 2015
New Revision: 255731
URL: http://llvm.org/viewvc/llvm-project?rev=255731&view=rev
Log:
Reland "[SEH] Use llvm.x86.seh.recoverfp for SEH filters on x64 as well as
32bit"
I forgot to initialize RecoverFP.
Modified:
cfe/trunk/lib/CodeGen/CGException.c
Author: rnk
Date: Tue Dec 15 18:20:21 2015
New Revision: 255728
URL: http://llvm.org/viewvc/llvm-project?rev=255728&view=rev
Log:
Revert "[SEH] Use llvm.x86.seh.recoverfp for SEH filters on x64 as well as
32bit"
This reverts commit r255710.
Modified:
cfe/trunk/lib/CodeGen/CGException.cpp
Author: rsmith
Date: Tue Dec 15 18:19:23 2015
New Revision: 255727
URL: http://llvm.org/viewvc/llvm-project?rev=255727&view=rev
Log:
Fix grammar.
Modified:
cfe/trunk/www/comparison.html
Modified: cfe/trunk/www/comparison.html
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/www/comparison
Author: rsmith
Date: Tue Dec 15 18:18:47 2015
New Revision: 255726
URL: http://llvm.org/viewvc/llvm-project?rev=255726&view=rev
Log:
Update our claims about GCC's diagnostics quality to reflect recent
improvements to GCC.
Modified:
cfe/trunk/www/comparison.html
Modified: cfe/trunk/www/compa
akyrtzi added a comment.
LGTM.
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
LGTM.
> On Dec 12, 2015, at 5:25 PM, Bruno Cardoso Lopes
> wrote:
>
> bruno updated this revision to Diff 42649.
> bruno added a comment.
>
> Thanks Duncan and Argyrios, updated a patch with the suggestions!
>
>
> http://reviews.llvm.org/D15173
>
> Files:
> lib/Lex/PPCaching.cpp
> test/Pa
Author: rsmith
Date: Tue Dec 15 18:09:57 2015
New Revision: 255723
URL: http://llvm.org/viewvc/llvm-project?rev=255723&view=rev
Log:
These days, GCC has at least minimal documentation for its VLAIS extension.
Modified:
cfe/trunk/www/comparison.html
Modified: cfe/trunk/www/comparison.html
URL
martell updated this revision to Diff 42933.
martell added a comment.
Sorry I was a bit slow getting around to this.
Will do testcases if Yaron thinks this is okay
http://reviews.llvm.org/D15006
Files:
lib/Driver/MinGWToolChain.cpp
lib/Driver/ToolChains.h
Index: lib/Driver/ToolChains.h
==
Author: eugenis
Date: Tue Dec 15 17:49:51 2015
New Revision: 255712
URL: http://llvm.org/viewvc/llvm-project?rev=255712&view=rev
Log:
Relax checks in cfi-cross-dso test.
The test is failing with unnamed labels.
Modified:
cfe/trunk/test/CodeGenCXX/cfi-cross-dso.cpp
Modified: cfe/trunk/test/C
silvas added a comment.
Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it; they're
likely to have more higher-level thoughts.
Comment at: utils/perf-training/perf-helper.py:36
@@ +35,3 @@
+ cmd.extend(findProfrawFiles(args[2]))
+ subprocess.check_call(cmd,
Author: rnk
Date: Tue Dec 15 17:47:40 2015
New Revision: 255710
URL: http://llvm.org/viewvc/llvm-project?rev=255710&view=rev
Log:
[SEH] Use llvm.x86.seh.recoverfp for SEH filters on x64 as well as 32bit
Modified:
cfe/trunk/lib/CodeGen/CGException.cpp
cfe/trunk/test/CodeGen/exceptions-seh.
bruno added a comment.
Ping!
http://reviews.llvm.org/D15173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Tue, Dec 15, 2015 at 12:55 PM, Justin Bogner
wrote:
> Akira Hatanaka writes:
> > On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner
> > wrote:
> >
> >> Akira Hatanaka via cfe-commits writes:
> >> > ahatanak created this revision.
> >> > ahatanak added a subscriber: cfe-commits.
> >> >
> >> > T
On Dec 15, 2015, at 5:30 PM, Jonathan Roelofs wrote:
>
>
> Could these large padding things be related to the fact that the test is used
> as a performance check for the implementation? That being said, I have no
> idea who is paying attention to the numbers that come out of this test (if
> a
eugenis closed this revision.
eugenis added a comment.
r255694
Repository:
rL LLVM
http://reviews.llvm.org/D15367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: eugenis
Date: Tue Dec 15 17:00:20 2015
New Revision: 255694
URL: http://llvm.org/viewvc/llvm-project?rev=255694&view=rev
Log:
Cross-DSO control flow integrity (Clang part).
Clang-side cross-DSO CFI.
* Adds a command line flag -f[no-]sanitize-cfi-cross-dso.
* Links a runtime library when
eugenis updated this revision to Diff 42918.
Repository:
rL LLVM
http://reviews.llvm.org/D15367
Files:
docs/ControlFlowIntegrity.rst
docs/ControlFlowIntegrityDesign.rst
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/
eugenis marked an inline comment as done.
eugenis added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D15367
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc added a comment.
LGTM
Comment at: docs/ControlFlowIntegrityDesign.rst:389
@@ +388,3 @@
+ - Calls between different instrumented DSOs are also protected, with
+ performance penalty (in addition to the monolithic CFI overhead).
+ - Calls from an instrumented DSO to an un
Author: chapuni
Date: Tue Dec 15 16:42:28 2015
New Revision: 255690
URL: http://llvm.org/viewvc/llvm-project?rev=255690&view=rev
Log:
clang/test/CodeGen/ms_this.cpp: Fix for -Asserts.
Modified:
cfe/trunk/test/CodeGen/ms_this.cpp
Modified: cfe/trunk/test/CodeGen/ms_this.cpp
URL:
http://llvm.
bcraig added a comment.
In http://reviews.llvm.org/D15539#311343, @jroelofs wrote:
> Could these large padding things be related to the fact that the test is used
> as a performance check for the implementation? That being said, I have no
> idea who is paying attention to the numbers that come
eugenis added inline comments.
Comment at: docs/ControlFlowIntegrityDesign.rst:389
@@ +388,3 @@
+ - Calls between different instrumented DSOs are also protected with
+ performance penalty compared to the monolithic CFI.
+ - Calls from instrumented DSO to an uninstrumented
eugenis updated this revision to Diff 42914.
eugenis marked 10 inline comments as done.
Repository:
rL LLVM
http://reviews.llvm.org/D15367
Files:
docs/ControlFlowIntegrity.rst
docs/ControlFlowIntegrityDesign.rst
docs/UsersManual.rst
include/clang/Driver/Options.td
include/clang/Drive
jroelofs added subscribers: howard.hinnant, jroelofs.
jroelofs added a comment.
Could these large padding things be related to the fact that the test is used
as a performance check for the implementation? That being said, I have no idea
who is paying attention to the numbers that come out of thi
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM modulo some wordsmithing in the documentation.
Comment at: docs/ControlFlowIntegrity.rst:31
@@ +30,3 @@
+enabled, and are statically linked into the program. This may preclude
Author: chapuni
Date: Tue Dec 15 16:19:00 2015
New Revision: 255685
URL: http://llvm.org/viewvc/llvm-project?rev=255685&view=rev
Log:
Fix clang/test/CodeGen/ms_this.cpp.
Modified:
cfe/trunk/test/CodeGen/ms_this.cpp
Modified: cfe/trunk/test/CodeGen/ms_this.cpp
URL:
http://llvm.org/viewvc/llv
Author: ericwf
Date: Tue Dec 15 16:19:03 2015
New Revision: 255686
URL: http://llvm.org/viewvc/llvm-project?rev=255686&view=rev
Log:
Remove unused _LIBCPP_HAS_NO_ALWAYS_INLINE_VARIADICS macro
Modified:
libcxx/trunk/include/__config
Modified: libcxx/trunk/include/__config
URL:
http://llvm.or
Author: ericwf
Date: Tue Dec 15 16:16:47 2015
New Revision: 255683
URL: http://llvm.org/viewvc/llvm-project?rev=255683&view=rev
Log:
[libcxx] Enable noexcept for GCC 4.6 and greater
Summary:
This patch allows GCC 4.6 and above to use `noexcept` as opposed to `throw()`.
Is it an ABI safe change
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Other than the `_NOEXCEPT_OR_FALSE` thing, this LGTM.
http://reviews.llvm.org/D15516
___
cfe-commits mailing list
cfe-commits@lists.llv
EricWF added a comment.
In http://reviews.llvm.org/D15516#311280, @mclow.lists wrote:
> do we even use `_NOEXCEPT_OR_FALSE` any more?
Doesn't look like it.
http://reviews.llvm.org/D15516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
mclow.lists added a comment.
do we even use `_NOEXCEPT_OR_FALSE` any more?
http://reviews.llvm.org/D15516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsk accepted this revision.
vsk added a reviewer: vsk.
vsk added a comment.
This revision is now accepted and ready to land.
Lgtm
http://reviews.llvm.org/D15222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
bcraig created this revision.
bcraig added a reviewer: mclow.lists.
bcraig added a subscriber: cfe-commits.
This test has a lot of classes with large amounts of manually inserted padding
in them, presumable to prevent various optimizations. The test then creates
lots of these objects on the sta
eugenis updated this revision to Diff 42902.
eugenis added a comment.
added the new flag to UserManual
Repository:
rL LLVM
http://reviews.llvm.org/D15367
Files:
docs/ControlFlowIntegrity.rst
docs/ControlFlowIntegrityDesign.rst
docs/UsersManual.rst
include/clang/Driver/Options.td
in
EricWF abandoned this revision.
EricWF added a comment.
There hasn't been much interest in this approach and it won't work with the new
linkage attributes.
http://reviews.llvm.org/D8652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255675: [WinEH] Update clang to use operand bundles on call
sites (authored by majnemer).
Changed prior to commit:
http://reviews.llvm.org/D15518?vs=42886&id=42901#toc
Repository:
rL LLVM
http://rev
Author: majnemer
Date: Tue Dec 15 15:27:59 2015
New Revision: 255675
URL: http://llvm.org/viewvc/llvm-project?rev=255675&view=rev
Log:
[WinEH] Update clang to use operand bundles on call sites
This updates clang to use bundle operands to associate an invoke with
the funclet which it is contained
jroelofs added a comment.
In http://reviews.llvm.org/D15528#311135, @alexfh wrote:
> In http://reviews.llvm.org/D15528#311053, @jroelofs wrote:
>
> > In http://reviews.llvm.org/D15528#311019, @alexfh wrote:
> >
> > > Jonathan, can you explain what specific use case does this patch address?
> > >
jroelofs added inline comments.
Comment at: tools/llvm-project/extra/test/clang-tidy/werrors-plural.cpp:7
@@ +6,3 @@
+// CHECK-WARN: warning: namespace 'j' not terminated with a closing comment
[llvm-namespace-comment]
+// CHECK-WERR: error: namespace 'j' not terminated with a cl
beanz updated this revision to Diff 42891.
beanz added a comment.
Cleaning up the python helper as per Sean's suggestions.
http://reviews.llvm.org/D15462
Files:
CMakeLists.txt
utils/perf-training/CMakeLists.txt
utils/perf-training/README.txt
utils/perf-training/cxx/hello_world.cpp
uti
Akira Hatanaka writes:
> On Mon, Dec 14, 2015 at 10:39 AM, Justin Bogner
> wrote:
>
>> Akira Hatanaka via cfe-commits writes:
>> > ahatanak created this revision.
>> > ahatanak added a subscriber: cfe-commits.
>> >
>> > This patch fixes a crash that occurs when __kindof is incorrectly used
>> >
zturner updated this revision to Diff 42895.
zturner added a comment.
Attempt to address remaining issues in patch.
This is my first time touching anything having to do with clang, so there's a
good chance I don't know what i'm doing and this needs more work. Let me know.
`AlwaysBreakAfterDefi
davidxl added a comment.
I prefer using the profile from the original test case where Max count is not 1.
Repository:
rL LLVM
http://reviews.llvm.org/D15163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
K-ballo updated this revision to Diff 42892.
K-ballo marked 15 inline comments as done.
K-ballo added a comment.
Addressed review comments. Use `UNSUPPORTED` in `pairs.by.type.pass`.
http://reviews.llvm.org/D14839
Files:
include/__tuple
include/array
include/tuple
include/utility
test
(...but it looks like these are all just warnings. The reason the builder
is red is
In file included from
C:\buildbot\slave-config\clang-x86-win2008-selfhost\llvm\unittests\Support\ThreadPool.cpp:10:
C:\buildbot\slave-config\clang-x86-win2008-selfhost\llvm\include\llvm/Support/ThreadPool.h(73,50)
Hello everyone,
Below are some buildbot numbers for the last week of 12/06/2015 -
12/12/2015.
Thanks
Galina
Top 10 fastest builders(not docs):
lldb-amd64-ninja-freebsd11
clang-bpf-build
llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
libomp-gcc-x86_64-linux-debian
sanitizer-windows
llvm-hexagon-e
Looks like the warning is still emitted frequently. It looks like cl.exe
processes /W4 before /wd4100 even though if it's passed as "/wd4100 /W4".
clang-cl probably interprets this as "first, disable Wunused-parameter,
then turn on everything in Wall and Wextra".
I suppose we could process W1-4 be
majnemer updated this revision to Diff 42886.
majnemer added a comment.
- Address review comments
http://reviews.llvm.org/D15518
Files:
lib/CodeGen/CGCall.cpp
lib/CodeGen/CodeGenModule.cpp
Index: lib/CodeGen/CodeGenModule.cpp
sbenza added inline comments.
Comment at: lib/ASTMatchers/ASTMatchersInternal.cpp:322
@@ +321,3 @@
+ for (bool SkipUnwritten : SkipUnwrittenCases) {
+llvm::SmallString<128> NodeName = StringRef("::");
+llvm::raw_svector_ostream OS(NodeName);
yaron.keren w
sbenza updated this revision to Diff 42884.
sbenza added a comment.
Add a faster version of the qualified name matcher.
It falls back to the previous version if it can't handle the name.
http://reviews.llvm.org/D15506
Files:
include/clang/ASTMatchers/ASTMatchersInternal.h
lib/ASTMatchers/AS
alexfh added a comment.
In http://reviews.llvm.org/D15528#311053, @jroelofs wrote:
> In http://reviews.llvm.org/D15528#311019, @alexfh wrote:
>
> > Jonathan, can you explain what specific use case does this patch address?
> > Why one severity level of native clang-tidy warnings (the current
> >
tra retitled this revision from "[CUDA] renamed cuda_runtime.h wrapper to
__cuda_runtime.h" to "[CUDA] renamed cuda_runtime.h wrapper to
__clang_cuda_runtime_wrapper.h".
tra updated the summary for this revision.
tra added a reviewer: chandlerc.
tra updated this revision to Diff 42882.
tra added
Author: kparzysz
Date: Tue Dec 15 13:14:24 2015
New Revision: 255667
URL: http://llvm.org/viewvc/llvm-project?rev=255667&view=rev
Log:
Unsupport test that should not be run on Hexagon
Modified:
cfe/trunk/test/CodeGen/ms_this.cpp
Modified: cfe/trunk/test/CodeGen/ms_this.cpp
URL:
http://llvm.
aaron.ballman added inline comments.
Comment at: tools/llvm-project/extra/test/clang-tidy/werrors-plural.cpp:7
@@ +6,3 @@
+// CHECK-WARN: warning: namespace 'j' not terminated with a closing comment
[llvm-namespace-comment]
+// CHECK-WERR: error: namespace 'j' not terminated with
Author: tstellar
Date: Tue Dec 15 12:37:02 2015
New Revision: 255662
URL: http://llvm.org/viewvc/llvm-project?rev=255662&view=rev
Log:
AMDGPU: Add alias for tonga
Patch by: Vedran Mileti
Modified:
libclc/trunk/configure.py
Modified: libclc/trunk/configure.py
URL:
http://llvm.org/viewvc/llv
nemanjai added a comment.
I think the correct course of action would be to allow/disallow promotion based
on a condition that the two types are the same/different (respectively). I
think a comparison of the float semantics is a valid way to check this. Also,
should operations between long doubl
Author: tstellar
Date: Tue Dec 15 12:37:04 2015
New Revision: 255663
URL: http://llvm.org/viewvc/llvm-project?rev=255663&view=rev
Log:
AMDGPU: Add aliases for all VI targets
Modified:
libclc/trunk/configure.py
Modified: libclc/trunk/configure.py
URL:
http://llvm.org/viewvc/llvm-project/libc
tra created this revision.
tra added a reviewer: echristo.
tra added a subscriber: cfe-commits.
Currently it's easy to break CUDA compilation by passing
"-isystem /path/to/cuda/include" to compiler which leads to
compiler including real cuda_runtime.h from there instead
of the wrapper we need.
Re
MaggieYi updated this revision to Diff 42874.
MaggieYi added a comment.
Thanks, I have updated the test following your comments.
http://reviews.llvm.org/D15222
Files:
lib/Driver/Tools.cpp
test/Driver/ps4-runtime-flags.c
Index: test/Driver/ps4-runtime-flags.c
===
hubert.reinterpretcast added a comment.
In http://reviews.llvm.org/D15120#310992, @nemanjai wrote:
> I think the correct course of action would be to allow/disallow promotion
> based on a condition that the two types are the same/different
> (respectively). I think a comparison of the float sem
jroelofs added a comment.
In http://reviews.llvm.org/D15528#311019, @alexfh wrote:
> Jonathan, can you explain what specific use case does this patch address? Why
> one severity level of native clang-tidy warnings (the current situation) is
> not enough, and two levels are enough?
I have out-
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Jonathan, can you explain what specific use case does this patch address? Why
one severity level of native clang-tidy warnings (the current situation) is not
enough, and two levels a
Author: nico
Date: Tue Dec 15 11:07:16 2015
New Revision: 255655
URL: http://llvm.org/viewvc/llvm-project?rev=255655&view=rev
Log:
clang-cl: Add an alias for /wd4100
Modified:
cfe/trunk/include/clang/Driver/CLCompatOptions.td
cfe/trunk/test/Driver/cl-options.c
Modified: cfe/trunk/include
Feedback on PR25563 pretty strongly suggests that users do want most of
this. It looks like llvm passes /wd4100 to suppress the corresponding cl
warning. r255655 maps that to -Wno-unused-parameter – does this fix the
problem of these bots?
On Mon, Dec 14, 2015 at 10:01 PM, Reid Kleckner via cfe-co
aaron.ballman added a comment.
Attribute implementation LGTM, but I do not know the semantics of ifunc well
enough to comment on whether this implementation is correct or not. From what I
can tell of GCC's documentation, it looks reasonable, but it would be good for
Eric or John to take a look
aaron.ballman added inline comments.
Comment at: tools/llvm-project/extra/test/clang-tidy/werrors-plural.cpp:7
@@ +6,3 @@
+// CHECK-WARN: warning: namespace 'j' not terminated with a closing comment
[llvm-namespace-comment]
+// CHECK-WERR: error: namespace 'j' not terminated with
hubert.reinterpretcast added a comment.
I would also like to see a test case based on the following from ISO/IEC TS
18661-3:2015:
> If both operands have floating types and neither of the sets of values of
> their corresponding real types is a subset of (or equivalent to) the other,
> the beha
jroelofs added inline comments.
Comment at: tools/llvm-project/extra/clang-tidy/ClangTidy.cpp:119
@@ +118,3 @@
+ if (Error.IsWError) {
+Name += ", -Werrors=";
+Level = DiagnosticsEngine::Error;
hardcoding happens here ^
Comme
aaron.ballman accepted this revision.
aaron.ballman added a reviewer: alexfh.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from two tiny nits, LGTM. Thank you for working on this, it's a great
feature! I think we should add something to the release notes t
aaron.ballman added a comment.
In http://reviews.llvm.org/D15486#310572, @adek05 wrote:
> @aaron.ballman I think this could be hard to achieve without an extra note if
> you have something like:
>
> cat test2.c
> int main() {
> char *c = 'a';
>
> char volatile** cc = &c
jroelofs created this revision.
jroelofs added a reviewer: aaron.ballman.
jroelofs added a subscriber: cfe-commits.
http://reviews.llvm.org/D15528
Files:
tools/llvm-project/extra/clang-tidy/ClangTidy.cpp
tools/llvm-project/extra/clang-tidy/ClangTidy.h
tools/llvm-project/extra/clang-tidy/Cla
vsk added a comment.
Sure! Thanks.
http://reviews.llvm.org/D15222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mcrosier updated this revision to Diff 42854.
mcrosier added a comment.
Remove the FIXME, per Hal and Bob's request. I confirmed that gcc does not
warn for invalid -fno-builtin-foo options.
Also, pass the vector by reference and insert, rather than making an
unnecessary copy on the return in Co
MaggieYi added a comment.
My patch changes 6 compiler flags, which are –coverage, -fprofile-arcs,
-fprofile-generate, -fprofile-generate=, -fprofile-instr-generate,
-fprofile-instr-generate=. I would like to keep line 7-10 in order to verify
the change to using “hasFlag” instead of “hasArg”. Fo
pekka.jaaskelainen added a comment.
Nice! I will keep on trying to help by reviewing patches whenever time allows.
http://reviews.llvm.org/D14441
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
Author: mzuckerm
Date: Tue Dec 15 08:35:51 2015
New Revision: 255647
URL: http://llvm.org/viewvc/llvm-project?rev=255647&view=rev
Log:
[Microsoft][C++] Clang doesn't support a use of "this" pointer inside inline
asm
add triple to test
Differential Revision: http://reviews.llvm.org/D15115
Mod
DmitryPolukhin created this revision.
DmitryPolukhin added reviewers: aaron.ballman, rjmccall.
DmitryPolukhin added a subscriber: cfe-commits.
This patch add support for GCC __attribute__((ifunc("resolver"))) for targets
that use ELF as object file format. In general ifunc is a special kind of
f
Author: mzuckerm
Date: Tue Dec 15 08:04:18 2015
New Revision: 255645
URL: http://llvm.org/viewvc/llvm-project?rev=255645&view=rev
Log:
[Microsoft][C++] Clang doesn't support a use of "this" pointer inside inline asm
Clang doesn’t support a use of “this” pointer inside inline asm.
When I tried to
pxli168 added a comment.
Hi all,
Bader had asked me to help him finished the patch set supporting the OpenCL2.0.
His original work is based on llvm 3.6.2, and include almost everything needed
for 2.0. Now I am working on the rest of the pipe support, include the full
support to complex types a
Author: abataev
Date: Tue Dec 15 05:38:29 2015
New Revision: 255640
URL: http://llvm.org/viewvc/llvm-project?rev=255640&view=rev
Log:
[OPENMP 4.5] Fix test compatibility with 32 bit mode.
Modified:
cfe/trunk/test/OpenMP/critical_codegen.cpp
Modified: cfe/trunk/test/OpenMP/critical_codegen.cp
bader added a comment.
Hi guys,
Sorry for long silence.
Unfortunately, I just can't find time to finish with this patch.
Xiuli provided a valid test case that exposed issue with type caching, so I
decided to not commit at as is (although I applied other minor style comments
locally).
I'm curre
Author: abataev
Date: Tue Dec 15 04:55:09 2015
New Revision: 255639
URL: http://llvm.org/viewvc/llvm-project?rev=255639&view=rev
Log:
[OPENMP 4.5] Codegen for 'hint' clause of 'critical' directive
OpenMP 4.5 defines 'hint' clause for 'critical' directive. Patch adds codegen
for this clause.
Modi
1 - 100 of 109 matches
Mail list logo
