silvas added a comment.

Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it; they're 
likely to have more higher-level thoughts.


================
Comment at: utils/perf-training/perf-helper.py:36
@@ +35,3 @@
+  cmd.extend(findProfrawFiles(args[2]))
+  subprocess.check_call(cmd, stdin=subprocess.PIPE, stdout=subprocess.PIPE)
+  return 0
----------------
I don't think you need the PIPE arguments (or maybe look into check_output if 
you want the output)


http://reviews.llvm.org/D15462



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to