Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a comment. In http://reviews.llvm.org/D14411#306722, @EricWF wrote: > In http://reviews.llvm.org/D14411#306716, @EricWF wrote: > > > Why does this depend on http://reviews.llvm.org/D15404? > > > Woops, I meant the tuple patch but I see the other comment now. I'm curious > as to ho

Re: [PATCH] D15332: new clang-tidy checker readability-non-const-parameter

danielmarjamaki added a comment. In http://reviews.llvm.org/D15332#306097, @Eugene.Zelenko wrote: > This check partially implements PR19419. Could it be extended to variables? Yes, I don't see any technical reasons why that would not work. However politically, some people like const variables

[PATCH] D15406: Add warning for attribute-cleanup on function parameter.

comex created this revision. comex added a subscriber: cfe-commits. When a function parameter is declared `__attribute__((cleanup))`, neither Clang nor GCC actually executes the cleanup function, but Clang didn't warn about it. For the sake of compatibility, add a warning rather than making the

r255225 - libclang: correct inverted logic

Author: compnerd Date: Thu Dec 10 00:30:23 2015 New Revision: 255225 URL: http://llvm.org/viewvc/llvm-project?rev=255225&view=rev Log: libclang: correct inverted logic The complete dtor is only emitted when there is a virtual destructor. The test itself was incorrect, so the issue in the code wa

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

RedX2501 updated this revision to Diff 42386. RedX2501 added a comment. Added functions to libclang.exports. http://reviews.llvm.org/D10833 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_cursor.py include/clang-c/Index.h include/clang/AST/OperationKinds.h tes

Re: [PATCH] D13803: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part

This revision was automatically updated to reflect the committed changes. Closed by commit rL255223: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13803?vs=37574&id=42384#toc Repository: rL LLV

r255223 - [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part

Author: abataev Date: Wed Dec 9 23:47:10 2015 New Revision: 255223 URL: http://llvm.org/viewvc/llvm-project?rev=255223&view=rev Log: [OPENMP] Make -fopenmp to turn on OpenMP support by default, clang part Patch turns on OpenMP support in clang by default after fixing OpenMP buildbots. Differentia

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

This revision was automatically updated to reflect the committed changes. ABataev marked an inline comment as done. Closed by commit rL255222: [OPENMP] Make -fopenmp to turn on OpenMP support by default. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D13802?vs=38374&id=

r255221 - Fix PR24694 (CWG1591): Deducing array bound and element type from initializer list

Author: faisalv Date: Wed Dec 9 23:36:39 2015 New Revision: 255221 URL: http://llvm.org/viewvc/llvm-project?rev=255221&view=rev Log: Fix PR24694 (CWG1591): Deducing array bound and element type from initializer list https://llvm.org/bugs/show_bug.cgi?id=24694 http://wg21.link/cwg1591 Teach Dedu

Re: [PATCH] D13802: [OPENMP] Make -fopenmp to turn on OpenMP support by default.

ABataev marked an inline comment as done. ABataev added a comment. Chandler, thank you very much for review! Comment at: docs/GettingStarted.rst:58-62 @@ -57,1 +57,7 @@ +#. Checkout Libomp (required for OpenMP support) **[Optional]**: + + * ``cd where-you-want-llvm-to-live``

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

RedX2501 added a comment. In http://reviews.llvm.org/D10833#306281, @akyrtzi wrote: > The patch causes tests to fail, please look into it. Where can i see the test reports? I'm having trouble running the test on my side on windows (VS2013). http://reviews.llvm.org/D10833 _

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

This revision was automatically updated to reflect the committed changes. ABataev marked an inline comment as done. Closed by commit rL255218: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not… (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D15174?vs

r255218 - [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

Author: abataev Date: Wed Dec 9 22:38:18 2015 New Revision: 255218 URL: http://llvm.org/viewvc/llvm-project?rev=255218&view=rev Log: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly. All problems described in http://llvm.org/PR25636 are implemented except

Re: [PATCH] D15174: [MSVC] Fix for http://llvm.org/PR25636: indexed accessor property not supported correctly.

ABataev marked an inline comment as done. Comment at: lib/Sema/SemaPseudoObject.cpp:259 @@ +258,3 @@ +/// +/// If this method returns false, and the set value isn't capturable for +/// some reason, the result of the expression will be void. rjmccall wr

[libcxxabi] r255211 - Creating release candidate final from release_371 branch

Author: tstellar Date: Wed Dec 9 21:53:28 2015 New Revision: 255211 URL: http://llvm.org/viewvc/llvm-project?rev=255211&view=rev Log: Creating release candidate final from release_371 branch Added: libcxxabi/tags/RELEASE_371/final/ (props changed) - copied from r255210, libcxxabi/bra

[libunwind] r255217 - Creating release candidate final from release_371 branch

Author: tstellar Date: Wed Dec 9 21:53:42 2015 New Revision: 255217 URL: http://llvm.org/viewvc/llvm-project?rev=255217&view=rev Log: Creating release candidate final from release_371 branch Added: libunwind/tags/RELEASE_371/final/ (props changed) - copied from r255216, libunwind/bra

[libcxx] r255210 - Creating release candidate final from release_371 branch

Author: tstellar Date: Wed Dec 9 21:53:26 2015 New Revision: 255210 URL: http://llvm.org/viewvc/llvm-project?rev=255210&view=rev Log: Creating release candidate final from release_371 branch Added: libcxx/tags/RELEASE_371/final/ (props changed) - copied from r255209, libcxx/branches/

Re: [PATCH] D8762: Adding doxygen comments to the LLVM intrinsics (part 1, ammintrin.h)

kromanova accepted this revision. kromanova added a reviewer: kromanova. kromanova added a comment. This revision is now accepted and ready to land. This was committed in r238386 but I forgot to close the review. http://reviews.llvm.org/D8762 ___ cf

Re: [PATCH] Add a builtin for indexing into parameter packs

Would you mind uploading the clang-side of this patch to phabricator? It will make it a little easier for me to perform a review. See http://llvm.org/docs/Phabricator.html for more details. On Mon, Nov 30, 2015 at 9:13 AM, Louis Dionne via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi, >

Re: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

kromanova added a comment. > > Once we have this in place we can think about factoring the debug-specific > > flags out of CodeGenOpts into some kind of DebugInfoOpts, to be configured > > by whatever debugger tuning mechanism we end up with. > Good idea! Thank you for such prompt review. Ka

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. In http://reviews.llvm.org/D14411#306716, @EricWF wrote: > Why does this depend on http://reviews.llvm.org/D15404? Woops, I meant the tuple patch but I see the other comment now. I'm curious as to how inlininging ends up affecting which overload's SFINAE are evaluated.

Re: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This looks good to me. Once we have this in place we can think about factoring the debug-specific flags out of `CodeGenOpts` into some kind of `DebugInfoOpts`, to be configured by whatever de

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

EricWF added a comment. Why does this depend on http://reviews.llvm.org/D15404? Repository: rL LLVM http://reviews.llvm.org/D14411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

rsmith added a subscriber: rsmith. Comment at: include/__config:237 @@ +236,3 @@ +#if __has_attribute(internal_linkage) +#define _LIBCPP_INLINE_VISIBILITY __attribute__ ((internal_linkage)) +#else Use `__internal_linkage__` here. Users are allowed to #define `int

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a dependency: D15404: Cleanup: move visibility/linkage attributes to the first declaration (part 2).. eugenis added a comment. This change depends on http://reviews.llvm.org/D15404. Repository: rL LLVM http://reviews.llvm.org/D14411 __

[PATCH] D15404: Cleanup: move visibility/linkage attributes to the first declaration (part 2).

eugenis created this revision. eugenis added reviewers: EricWF, mclow.lists. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. This is a follow-up to r252385. For some reason, I missed a lot of cases when the visibility attribute was applied to the

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a dependency: D12502: [libcxx] Better constain tuples constructors -- Fix PR23256 and PR22806. eugenis added a comment. Note, this breaks tuple_cat.pass.cpp test. With -O0, replacing always_inline with internal_linkage results in less optimization being done (namely, no inlining h

Re: [PATCH] D15006: Driver: Better detection of mingw-gcc

martell added a comment. hi ismail, I will tidy up for review closer towards the weekend where i can work on out of work stuff http://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

EricWF added a reviewer: EricWF. EricWF added a comment. Sorry I'm late to this party. Please let me know if my concerns have already been discussed. First, thanks for taking on all this work. Getting the test suite passing without exceptions is a tall order. My two cents: - I like the approa

Re: [PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

This revision was automatically updated to reflect the committed changes. Closed by commit rL255201: Mark MS inline ASM 'nodplicate' it it has labels (PR23715) (authored by hans). Changed prior to commit: http://reviews.llvm.org/D15399?vs=42353&id=42365#toc Repository: rL LLVM http://review

r255200 - Fix a typo in the clang user manual.

Author: ygao Date: Wed Dec 9 19:37:18 2015 New Revision: 255200 URL: http://llvm.org/viewvc/llvm-project?rev=255200&view=rev Log: Fix a typo in the clang user manual. -fmax-unknown-pointer-align => -fmax-type-align Modified: cfe/trunk/docs/UsersManual.rst Modified: cfe/trunk/docs/UsersManua

Re: [PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

hans added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:2005 @@ -1998,3 +2004,3 @@ /* IsAlignStack */ false, AsmDialect); llvm::CallInst *Result = Builder.CreateCall(IA, Args); Result->addAttribute(llvm::AttributeSet::FunctionIndex, -

r255201 - Mark MS inline ASM 'nodplicate' it it has labels (PR23715)

Author: hans Date: Wed Dec 9 19:38:04 2015 New Revision: 255201 URL: http://llvm.org/viewvc/llvm-project?rev=255201&view=rev Log: Mark MS inline ASM 'nodplicate' it it has labels (PR23715) Duplicating it can lead to labels being defined twice. Differential revision: http://reviews.llvm.org/D153

Re: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

kromanova updated the summary for this revision. kromanova set the repository for this revision to rL LLVM. kromanova updated this revision to Diff 42364. kromanova added a comment. I have made all the changes that Richard suggested. Sorry for the delay, got distracted by other tasks. Anything el

[clang-tools-extra] r255199 - There were problems if a relative path is used for an include path, the path will be normalized to ./xxx. I don't know how to test this in a way that will work in a separ

Author: jtsoftware Date: Wed Dec 9 19:33:09 2015 New Revision: 255199 URL: http://llvm.org/viewvc/llvm-project?rev=255199&view=rev Log: There were problems if a relative path is used for an include path, the path will be normalized to ./xxx. I don't know how to test this in a way that will wor

Re: [PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

rsmith added a subscriber: rsmith. Comment at: test/CodeGen/ms-inline-asm.c:536 @@ -535,3 +535,3 @@ } - // CHECK-LABEL: define void @label1 + // CHECK: define void @label1() [[ATTR1:#[0-9]+]] { // CHECK: call void asm sideeffect inteldialect "{{.*}}__MSASMLABEL_.1__label:

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna added a comment. Hi Laszlo, Comment at: tools/scan-build-py/libear/ear.c:281 @@ +280,3 @@ + +DLSYM(func, fp, "execve"); + This is not the recommended way of interposing on Darwin. All you need to do is provide your function, which can call the fun

Re: [PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

majnemer added a subscriber: majnemer. Comment at: lib/CodeGen/CGStmt.cpp:2005 @@ -1998,3 +2004,3 @@ /* IsAlignStack */ false, AsmDialect); llvm::CallInst *Result = Builder.CreateCall(IA, Args); Result->addAttribute(llvm::AttributeSet::FunctionIndex

r255198 - PR25416: Improve performance of processing inline assembly consisting of many

Author: rsmith Date: Wed Dec 9 19:11:47 2015 New Revision: 255198 URL: http://llvm.org/viewvc/llvm-project?rev=255198&view=rev Log: PR25416: Improve performance of processing inline assembly consisting of many implicitly-concatenated string literals. When looking for the start of a token in the i

Re: [PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks terrible, please commit. Comment at: lib/CodeGen/CGStmt.cpp:2005 @@ -1998,3 +2004,3 @@ /* IsAlignStack */ false, AsmDialect); llvm::CallInst *Resu

[PATCH] D15400: [Clang] Use autos in lib/AST/Type.cpp

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Autos are also used for pointer variables assigned via casts or memory allocation. Patch inclu

r255196 - [Lit Test] Updated 20 Lit tests to be C++11 compatible.

Author: lcharles Date: Wed Dec 9 19:07:17 2015 New Revision: 255196 URL: http://llvm.org/viewvc/llvm-project?rev=255196&view=rev Log: [Lit Test] Updated 20 Lit tests to be C++11 compatible. This is the 5th Lit test patch. Expanded expected diagnostics to vary by C++ dialect. Expanded RUN line to

Re: [clang-tools-extra] r254785 - Added coverage check for extensionless headers, and exclude hidden dot directoryies.

Hi John, > +if (file.startswith(".") || (file.find("\\.") != StringRef::npos) > + || (file.find("/.") != StringRef::npos)) This will also filter out things like ./foo.h, which probably isn't what we want and breaks on relative/non-absolute paths. For example, given a trivial test: //---

[libunwind] r255188 - Replace cmake check for printf with a check for fopen.

Author: eugenis Date: Wed Dec 9 18:47:08 2015 New Revision: 255188 URL: http://llvm.org/viewvc/llvm-project?rev=255188&view=rev Log: Replace cmake check for printf with a check for fopen. Printf is a builtin, and the check fails with -Werror because of a clang warning about an incompatible redec

[libcxx] r255187 - Replace cmake check for printf with a check for fopen.

Author: eugenis Date: Wed Dec 9 18:45:18 2015 New Revision: 255187 URL: http://llvm.org/viewvc/llvm-project?rev=255187&view=rev Log: Replace cmake check for printf with a check for fopen. Printf is a builtin, and the check fails with -Werror because of a clang warning about an incompatible redec

[libcxxabi] r255186 - Replace cmake check for printf with a check for fopen.

Author: eugenis Date: Wed Dec 9 18:44:42 2015 New Revision: 255186 URL: http://llvm.org/viewvc/llvm-project?rev=255186&view=rev Log: Replace cmake check for printf with a check for fopen. Printf is a builtin, and the check fails with -Werror because of a clang warning about an incompatible redec

[libcxx] r255185 - Remove redundant _LIBCPP_ALWAYS_INLINE attribute from __convert_to_integral overloads

Author: ericwf Date: Wed Dec 9 18:43:37 2015 New Revision: 255185 URL: http://llvm.org/viewvc/llvm-project?rev=255185&view=rev Log: Remove redundant _LIBCPP_ALWAYS_INLINE attribute from __convert_to_integral overloads Modified: libcxx/trunk/include/type_traits Modified: libcxx/trunk/includ

[PATCH] D15399: MS inline ASM: mark the function noinline if the asm has labels (PR23715)

hans created this revision. hans added a reviewer: rnk. hans added a subscriber: cfe-commits. This avoids defining the same label twice if the function gets inlined. It's pretty hacky, but also very non-intrusive. (I also played with adding a flag on the MSAsmStmt and set that in ParseMicrosoftA

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis closed this revision. eugenis added a comment. r255177 Thanks for the review! Repository: rL LLVM http://reviews.llvm.org/D14409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[libcxx] r255177 - Remove visibility attributes from out-of-class method definitions in iostreams.

Author: eugenis Date: Wed Dec 9 17:42:30 2015 New Revision: 255177 URL: http://llvm.org/viewvc/llvm-project?rev=255177&view=rev Log: Remove visibility attributes from out-of-class method definitions in iostreams. No point in pretending that these methods are hidden - they are actually exported f

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

EricWF added a comment. In http://reviews.llvm.org/D14409#306531, @eugenis wrote: > In http://reviews.llvm.org/D14409#306379, @eugenis wrote: > > > In http://reviews.llvm.org/D14409#306272, @EricWF wrote: > > > > > Does the `inline` keyword have any effect when it's on function > > > definitions

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis added a comment. In http://reviews.llvm.org/D14409#306531, @eugenis wrote: > In http://reviews.llvm.org/D14409#306379, @eugenis wrote: > > > In http://reviews.llvm.org/D14409#306272, @EricWF wrote: > > > > > Does the `inline` keyword have any effect when it's on function > > > definition

r255176 - Fix crash on invalid initialization with std::initializer_list

Author: rnk Date: Wed Dec 9 17:18:38 2015 New Revision: 255176 URL: http://llvm.org/viewvc/llvm-project?rev=255176&view=rev Log: Fix crash on invalid initialization with std::initializer_list It is possible for CheckListElementTypes to fail without filling in any initializer list elements. Modi

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv added a comment. Also, due to allowing the evaluation of const expressions as constexpr expressions, this patch needs http://reviews.llvm.org/D14877 to go in so we don't break tests. :) http://reviews.llvm.org/D14274 ___ cfe-comm

Re: [PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv updated the summary for this revision. george.burgess.iv updated this revision to Diff 42348. george.burgess.iv added a comment. As discussed offline: - Added support for treating `const` variables as `constexpr` - Added requirement for `LValue`s with an invalid `alloc_size` bas

Re: [PATCH] D15161: [CMake] On Darwin the LIBCXX_INSTALL_HEADERS and LIBCXX_INSTALL_LIBRARY options should default off

beanz abandoned this revision. beanz added a comment. Short answer. I was doing something terrible and wrong in out-of-tree code, and this was getting tripped up. I was reading the LIBCXX_INSTALL_* variables from a higher-level CMake file. I've stopped doing that (because it was stupid), so I'l

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis added a comment. In http://reviews.llvm.org/D14409#306379, @eugenis wrote: > In http://reviews.llvm.org/D14409#306272, @EricWF wrote: > > > Does the `inline` keyword have any effect when it's on function definitions > > that are externally instantiated? > > > I could not detect any diffe

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. I built the library before this patch and then diffed the symbols after this change. No symbols have been removed or added. LGTM. Repository: rL LLVM http://reviews.llvm.org/D14409

r255174 - Objective-C properties: loosen 'atomic' checking for readonly properties.

Author: dgregor Date: Wed Dec 9 16:57:32 2015 New Revision: 255174 URL: http://llvm.org/viewvc/llvm-project?rev=255174&view=rev Log: Objective-C properties: loosen 'atomic' checking for readonly properties. r251874 reworked the way we handle properties declared within Objective-C class extension

Re: [PATCH] D15161: [CMake] On Darwin the LIBCXX_INSTALL_HEADERS and LIBCXX_INSTALL_LIBRARY options should default off

EricWF added a comment. > The current implementation doesn't work as intended because of CMake's > caching behavior. The CMake set command doesn't globally override cached > options. Sort of. It doesn't override the value in the cache but it should mean that the cache value is overridden by t

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

On Wed, Dec 9, 2015 at 2:00 PM, Ben Langmuir wrote: > > On Dec 9, 2015, at 1:36 PM, Richard Smith wrote: > > On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> > On Dec 9, 2015, at 11:07 AM, Ben Langmuir wrote: >> > >> > Hey Richard, >> > >

r255172 - [CMake] Pass CMAKE_MAKE_PROGRAM through to compiler-rt build.

Author: cbieneman Date: Wed Dec 9 16:46:25 2015 New Revision: 255172 URL: http://llvm.org/viewvc/llvm-project?rev=255172&view=rev Log: [CMake] Pass CMAKE_MAKE_PROGRAM through to compiler-rt build. This is needed if your make tool is overridden. Modified: cfe/trunk/runtime/CMakeLists.txt Mo

Re: [PATCH] D15367: Cross-DSO control flow integrity (Clang part)

pcc added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2558 @@ +2557,3 @@ + false)); + llvm::MDString *MDS = dyn_cast(MD); + llvm::Constant *TypeId = What happens if `MD` is not an `MDString`? Comment at: lib/CodeGen/CodeGenModu

Re: [PATCH] D15309: [CUDA] emit vtables only for classes with methods usable on this side of compilation.

tra updated the summary for this revision. tra updated this revision to Diff 42341. tra added a comment. Changed key method algorithm to ignore methods that we will not emit during this compilation (previous version didn't allow mixed host/device virtual methods). For vtables with mixed host/de

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

eugenis closed this revision. eugenis added a comment. r255166 Repository: rL LLVM http://reviews.llvm.org/D15395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r255166 - Add 3 more missing inline/visibility attributes.

Author: eugenis Date: Wed Dec 9 16:32:36 2015 New Revision: 255166 URL: http://llvm.org/viewvc/llvm-project?rev=255166&view=rev Log: Add 3 more missing inline/visibility attributes. These are the cases when an out-of-class definition of a method is marked _LIBCPP_INLINE_VISIBILITY, but the in-cl

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

eugenis added a comment. Should be fine. Repository: rL LLVM http://reviews.llvm.org/D15395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15395: Add 3 more missing inline/visibility attributes

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM. For clang this patch should have no functionality change because clang allows attributes to appear only in the declaration. GCC however was previously ignoring the attributes and only n

r255163 - fix typos; NFC

Author: spatel Date: Wed Dec 9 16:16:07 2015 New Revision: 255163 URL: http://llvm.org/viewvc/llvm-project?rev=255163&view=rev Log: fix typos; NFC Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/Che

Re: [PATCH] D15030: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

mgehre updated this revision to Diff 42338. mgehre added a comment. Thanks for the comments! http://reviews.llvm.org/D15030 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIn

Re: [PATCH] D15208: Patch for inline abort code generation

samsonov added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:2543 @@ +2542,3 @@ + // RE: Bug: 25682 + if(!getLangOpts().mergeTraps) { + llvm::InlineAsm *EmptyAsm = llvm::InlineAsm::get(llvm::FunctionType::get(CGM.VoidTy, false), danielaustin wrote:

Re: [PATCH] D14814: [libcxx] Use __make_integer_seq builtin when available

EricWF closed this revision. EricWF added a comment. Committted in r255162. Thanks. http://reviews.llvm.org/D14814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r255162 - Use __make_integer_seq builtin for std::make_integer_sequence. Patch by K-ballo.

Author: ericwf Date: Wed Dec 9 16:03:06 2015 New Revision: 255162 URL: http://llvm.org/viewvc/llvm-project?rev=255162&view=rev Log: Use __make_integer_seq builtin for std::make_integer_sequence. Patch by K-ballo. Added: libcxx/trunk/test/std/utilities/intseq/intseq.make/make_integer_seq_fal

Re: [PATCH] D15208: Patch for inline abort code generation

danielaustin added a comment. Test makes sense, will add it with the revisions. Comment at: include/clang/Basic/LangOptions.h:95 @@ -94,1 +94,3 @@ + /// \brief Flag controlling whether or not trap calls are merged + /// at the end of each function. samsonov

[PATCH] D15395: Add 3 more missing inline/visibility attributes

eugenis created this revision. eugenis added reviewers: EricWF, mclow.lists. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. These are the cases when an out-of-class definition of a method is marked _LIBCPP_INLINE_VISIBILITY, but the in-class decl

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Dec 9, 2015, at 1:36 PM, Richard Smith wrote: > > On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > > On Dec 9, 2015, at 11:07 AM, Ben Langmuir > > wrote: > > > > Hey Richard, > > > > This caused a new

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna added a comment. Hi Laszlo, Here are some comments from me. Should we be worried about the name conflicts (between old scan-build and this tool) during rollout? I think it would be beneficial to rename the tools, but let's discuss the names later. (If we integrate Codecheck, that wil

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

eugenis added a comment. In http://reviews.llvm.org/D14409#306272, @EricWF wrote: > Does the `inline` keyword have any effect when it's on function definitions > that are externally instantiated? I could not detect any difference in behavior with or without inline keyword. Remove it? Reposit

Re: [PATCH] D15373: Fix for bug 25786 - Assertion "Chunk.Kind == DeclaratorChunk::Function" failed with regparm attribute.

rnk added a subscriber: rnk. Comment at: include/clang/Sema/Sema.h:2938 @@ -2937,2 +2937,3 @@ bool CheckRegparmAttr(const AttributeList &attr, unsigned &value); + bool getCCFromAttr(const AttributeList &attr, CallingConv &CC); bool CheckCallingConvAttr(const AttributeList &

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

On Wed, Dec 9, 2015 at 11:55 AM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Dec 9, 2015, at 11:07 AM, Ben Langmuir wrote: > > > > Hey Richard, > > > > This caused a new error for the following code: > > > >@import Foo.X; // declaration of ‘struct foo’ from Foo.Y

Re: Lit Test C++11 compatibility patch #5

Essentially LGTM. A few comments below, feel free to commit once you've addressed them. On Tue, Nov 24, 2015 at 9:53 AM, Li, Charles < charles...@playstation.sony.com> wrote: > Hi Everyone, > > > > > > I am continuing with updating Lit tests to be C++11 compatible. > > Here is the fifth patch. Th

Re: [PATCH] D15208: Patch for inline abort code generation

samsonov added a comment. Please consider adding a test case. Comment at: include/clang/Basic/LangOptions.h:95 @@ -94,1 +94,3 @@ + /// \brief Flag controlling whether or not trap calls are merged + /// at the end of each function. Why is it a language, not c

cfe-commits@lists.llvm.org

EricWF added a comment. To expand on my concerns about lvalue elements, I would like to see tests something like this: int x = 42; int const y = 43; std::pair const p(x, y); static_assert(std::is_same(std::move(p)))>::value, ""); static_assert(std::is_same(std::move(p)))>::value, "");

RE: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

| Oh right, sorry, off-by-one error when evaluating that by hand; I got 0x7fff (which is also a NaN, 0x7fc0 is not the only NaN). No worries. | http://llvm.org/docs/LangRef.html#uitofp-to-instruction is clear that you get an undefined result for overflow currently. Other parts of the Lan

cfe-commits@lists.llvm.org

EricWF added a comment. Added initial review comments. I need to look a little more into how we form the rvalue reference to the returned element in the case where the element is an lvalue reference. I think it's currently correct but I just want to double check. I think the new language is a

Re: [PATCH] D15208: Patch for inline abort code generation

danielaustin updated this revision to Diff 42328. danielaustin added a comment. Patch that removes the debug-mode sanitizer setting and makes the -fsanitize-merge-traps/-fno-sanitize-merge-traps flags, with the default setting being to merge traps. Flags tested within the Android build system,

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

On Wed, Dec 9, 2015 at 12:46 PM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > | Types are a bit more vague (as to whether omitting unreferenced types is > supported by the standard) DWARF 4 just says "Structure, union, and class > types are represented by debugging information ent

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

akyrtzi added a comment. Also you need to add the functions in libclang.exports. http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

Also you need to add the functions in libclang.exports. > On Dec 9, 2015, at 12:47 PM, Argyrios Kyrtzidis wrote: > > akyrtzi added a comment. > > The patch causes tests to fail, please look into it. > > > http://reviews.llvm.org/D10833 > > > ___

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

The patch causes tests to fail, please look into it. > On Dec 8, 2015, at 10:20 PM, guibufolo+l...@gmail.com wrote: > > RedX2501 updated this revision to Diff 42267. > RedX2501 added a comment. > > Added explicit integer assignment to enum to emphasize api contract behaviour. > > > http://revi

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

akyrtzi added a comment. The patch causes tests to fail, please look into it. http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

| Types are a bit more vague (as to whether omitting unreferenced types is supported by the standard) DWARF 4 just says "Structure, union, and class types are represented by debugging information entries ...". There's some expansion of the "permissive" discussion in the works for DWARF 5. In e

Re: [PATCH] D14814: [libcxx] Use __make_integer_seq builtin when available

K-ballo added a comment. > After that these changes LGTM. @K-ballo I'm happy to make the changes as I > commit this if your OK with that? @EricWF Go ahead, thank you! http://reviews.llvm.org/D14814 ___ cfe-commits mailing list cfe-commits@lists.l

Re: r254574 - PR17381: Treat undefined behavior during expression evaluation as an unmodeled

On Wed, Dec 9, 2015 at 10:17 AM, Robinson, Paul via cfe-commits < cfe-commits@lists.llvm.org> wrote: > | And at runtime, on some targets, we use this: > > | > > | > https://llvm.org/svn/llvm-project/compiler-rt/trunk/lib/builtins/floatuntisf.c > > | > > | ... which gives a NaN in this case. > > >

Re: [PATCH] D14409: Remove visibility attributes from out-of-class method definitions in iostreams.

EricWF added a comment. Does the `inline` keyword have any effect when it's on function definitions that are externally instantiated? Repository: rL LLVM http://reviews.llvm.org/D14409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

Re: [PATCH] D14814: [libcxx] Use __make_integer_seq builtin when available

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. The only issue I have with this is that we should still test both code patchs with clang so we can ensure the fallback implementation remains correct. I would change #if __has_builtin(__mak

Re: [PATCH] D14358: DWARF's forward decl of a template should have template parameters.

On Wed, Dec 9, 2015 at 11:59 AM, Robinson, Paul < paul_robin...@playstation.sony.com> wrote: > Maybe we are being too pedantic about the names. I'll have to go back and > look in detail at why we decided to do that. > > > > In any case, arguably 5.5.8 (Class Template Instantiations) 1 only applie

Re: [PATCH] D10834: Added functions to retrieve information about whether a vardecl is local in libclang and its python bindings.

The patch does not apply cleanly, could you provide a more up-to-date one ? > On Dec 6, 2015, at 11:46 PM, guibufolo+l...@gmail.com wrote: > > RedX2501 added a comment. > > Ping > > > http://reviews.llvm.org/D10834 > > > ___ cfe-commits mailing l

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added a comment. In http://reviews.llvm.org/D9600#305980, @rizsotto.mailinglist wrote: > > Also, what do you think about renaming intercept-build to "log-build" or > > some of the other alternatives I proposed above? I think it is important > > for the name of the executable to commun

Re: [PATCH] D10834: Added functions to retrieve information about whether a vardecl is local in libclang and its python bindings.

akyrtzi added a subscriber: akyrtzi. akyrtzi added a comment. The patch does not apply cleanly, could you provide a more up-to-date one ? http://reviews.llvm.org/D10834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

  1   2   >