EricWF added a comment.

> The current implementation doesn't work as intended because of CMake's 
> caching behavior. The CMake set command doesn't globally override cached 
> options.


Sort of. It doesn't override the value in the cache but it should mean that the 
cache value is overridden by the newly set non-cache value. If I am correct the 
following code will print "VAR = OFF".

  option(VAR "description" ON)
  set(VAR OFF)
  message(STATUS "VAR = ${VAR}")

Could you give me an example of where this breaks? It won't override the values 
in the cache but it should work correctly.


http://reviews.llvm.org/D15161



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to