vadimcn added a subscriber: vadimcn.
vadimcn added a comment.
Hi!
So apparently LLVM lowers `alloca`'s of large buffers into a call to `_alloca`
(makes sense I guess - if the buffer is larger than a page).
Why wasn't it added along with `_chkstk`? Is `_alloca` available from some
other mingw l
Hi,
thanks for the attempt to fix this, but this isn't working for in-tree builds
of libcxx:
CMake Error at projects/libcxx/lib/cmake_install.cmake:56 (FILE):
file INSTALL cannot find
"<<>>/projects/libcxx/lib/libc++.so"
It is located at <<>>/lib/libc++.so. CMake version is 2.8.12.2 which
s
nwilson added inline comments.
Comment at: include/clang/AST/Decl.h:1577
@@ -1576,2 +1576,3 @@
bool IsConstexpr : 1;
+ bool IsConcept : 1;
faisalv wrote:
> My inclination would have been to add this bit to FunctionTemplateDecl,
> instead of to every Functio
tra created this revision.
tra added reviewers: eliben, jingyue, jpienaar, echristo.
tra added a subscriber: cfe-commits.
Currently -fcuda-disable-target-call-checks option enables parsing of code that
calls across host/device boundary.
However, we don't emit any IR for functions that don't have
Author: davidxl
Date: Thu Oct 22 17:25:11 2015
New Revision: 251072
URL: http://llvm.org/viewvc/llvm-project?rev=251072&view=rev
Log:
Use newly introduced interfaces in LLVM (NFC)
Replaced references to raw strings in instrumentation
and coverage code.
Modified:
cfe/trunk/lib/CodeGen/CodeGen
Seems to work now, thanks for the quick fix!
On Thu, Oct 22, 2015 at 1:57 PM, Eric Fiselier wrote:
> Hi Alexey,
>
> Please confirm that this works for you now after r251063. Sorry for the
> breakage.
>
> /Eric
>
> On Thu, Oct 22, 2015 at 9:23 AM, Alexey Samsonov
> wrote:
>
>> After this change
Author: ericwf
Date: Thu Oct 22 16:24:01 2015
New Revision: 251065
URL: http://llvm.org/viewvc/llvm-project?rev=251065&view=rev
Log:
Dont required CMake 3 to install a linker script
Modified:
libcxx/trunk/lib/CMakeLists.txt
Modified: libcxx/trunk/lib/CMakeLists.txt
URL:
http://llvm.org/view
On 10/22/15 2:59 PM, Eric Fiselier wrote:
Yeah, that review hasn't landed yet. It should be called auto, but we
need to make it actually "automatic". Currently "none" really means
don't help me, not that we will automatically figure it out for you. I
agree with your requested change, it's just
Yeah, that review hasn't landed yet. It should be called auto, but we need
to make it actually "automatic". Currently "none" really means don't help
me, not that we will automatically figure it out for you. I agree with your
requested change, it's just a bunch of work that should probably be done o
Hi Alexey,
Please confirm that this works for you now after r251063. Sorry for the
breakage.
/Eric
On Thu, Oct 22, 2015 at 9:23 AM, Alexey Samsonov wrote:
> After this change I am unable to configure libcxx as external project from
> compiler-rt with extra build flags.
> The problem is gen_lin
On 10/22/15 2:50 PM, Eric Fiselier via cfe-commits wrote:
Author: ericwf
Date: Thu Oct 22 15:50:07 2015
New Revision: 251062
URL: http://llvm.org/viewvc/llvm-project?rev=251062&view=rev
Log:
Disable linker scripts when the ABI library is not specified or is none.
Modified:
libcxx/trunk/C
Author: ericwf
Date: Thu Oct 22 15:54:27 2015
New Revision: 251063
URL: http://llvm.org/viewvc/llvm-project?rev=251063&view=rev
Log:
Only disable linker script when LIBCXX_CXX_ABI_LIBNAME is none
Modified:
libcxx/trunk/CMakeLists.txt
libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmake
Modif
Author: ericwf
Date: Thu Oct 22 15:50:07 2015
New Revision: 251062
URL: http://llvm.org/viewvc/llvm-project?rev=251062&view=rev
Log:
Disable linker scripts when the ABI library is not specified or is none.
Modified:
libcxx/trunk/CMakeLists.txt
Modified: libcxx/trunk/CMakeLists.txt
URL:
http
loladiro added a comment.
Can you provide insight as to why this is looking at MangledDeclNames rather
than the StaticLocalDeclMap? I'd like to extend the comment with an explanation.
Repository:
rL LLVM
http://reviews.llvm.org/D13959
___
cfe-co
mgehre updated this revision to Diff 38157.
mgehre added a comment.
Add test case
http://reviews.llvm.org/D13973
Files:
lib/Analysis/CFG.cpp
test/Analysis/no-unreachable-dtors.cpp
Index: test/Analysis/no-unreachable-dtors.cpp
After this change I am unable to configure libcxx as external project from
compiler-rt with extra build flags.
The problem is gen_link_script.py is invoked with incorrect number of
arguments: LIBCXX_CXX_ABI_LIBNAME is automatically deduced to be "none",
and LIBCXX_CXX_ABI_LIBRARY which is passed to
Author: rjmccall
Date: Thu Oct 22 13:38:17 2015
New Revision: 251041
URL: http://llvm.org/viewvc/llvm-project?rev=251041&view=rev
Log:
Define weak and __weak to mean ARC-style weak references, even in MRC.
Previously, __weak was silently accepted and ignored in MRC mode.
That makes this a potenti
Author: majnemer
Date: Thu Oct 22 13:04:22 2015
New Revision: 251036
URL: http://llvm.org/viewvc/llvm-project?rev=251036&view=rev
Log:
[MS ABI] Don't crash when inheriting from base with trailing empty array member
We got this right for Itanium but not MSVC because CGRecordLayoutBuilder
was check
DavidKreitzer added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:1239
@@ +1238,3 @@
+// The MCU psABI allows passing parameters in-reg even if there are
+// earlier, parameters that are passed on the stack. Also,
+// it does not allow passing >8-byte structs
aturetsk created this revision.
aturetsk added a reviewer: rsmith.
aturetsk added a subscriber: cfe-commits.
Add 'x87' in x86 target feature map
http://reviews.llvm.org/D13980
Files:
lib/Basic/Targets.cpp
test/CodeGen/attr-target-x86-mmx.c
test/CodeGen/attr-target-x86.c
Index: test/CodeGe
sepavloff created this revision.
sepavloff added a subscriber: cfe-commits.
This change fixes performance degradation reported in PR24667. The reason
of the problem is leaving module after each header, even if the next header
is of the same module. With this fix module state record counts the numb
rjmccall added a comment.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D13959
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: d0k
Date: Thu Oct 22 10:45:54 2015
New Revision: 251026
URL: http://llvm.org/viewvc/llvm-project?rev=251026&view=rev
Log:
Unbreak the shared cmake build. libToolingCore now depends on libAST.
Modified:
cfe/trunk/lib/Tooling/Core/CMakeLists.txt
Modified: cfe/trunk/lib/Tooling/Core/CMa
Author: ctopper
Date: Thu Oct 22 10:35:21 2015
New Revision: 251025
URL: http://llvm.org/viewvc/llvm-project?rev=251025&view=rev
Log:
Disable trigraph and escaped newline expansion on all types of raw string
literals not just ASCII type.
Modified:
cfe/trunk/lib/Lex/Lexer.cpp
cfe/trunk/te
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251022: [Tooling] Add a utility function to replace one
nested name with another. (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D13931?vs=38130&id=38131#toc
Repository:
rL LLVM
Author: d0k
Date: Thu Oct 22 10:04:10 2015
New Revision: 251022
URL: http://llvm.org/viewvc/llvm-project?rev=251022&view=rev
Log:
[Tooling] Add a utility function to replace one nested name with another.
One problem in clang-tidy and other clang tools face is that there is no
way to lookup an arb
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
bkramer updated this revision to Diff 38130.
bkramer added a comment.
Enforce :: at the beginning of the new name.
http://reviews.llvm.org/D13931
Files:
include/clang/Tooling/Core/Lookup.h
lib/Tooling/Core/CMakeLists.txt
lib/Tooling/Core/Lookup.cpp
unittests/Tooling/CMakeLists.txt
uni
Author: klimek
Date: Thu Oct 22 09:54:50 2015
New Revision: 251021
URL: http://llvm.org/viewvc/llvm-project?rev=251021&view=rev
Log:
Switch check_clang_tidy to argparse and add a -resource-dir argument.
-resource-dir can be used to inject non-standard resource dirs via the
lit site config.
Modif
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Lookup.h:37-38
@@ +36,4 @@
+/// \param FromDecl The declaration to which the nested name points.
+/// \param ReplacementString The replacement nested name. Should be qualified,
+/// leadi
bkramer updated this revision to Diff 38122.
bkramer added a comment.
Add more comments and polish test cases.
http://reviews.llvm.org/D13931
Files:
include/clang/Tooling/Core/Lookup.h
lib/Tooling/Core/CMakeLists.txt
lib/Tooling/Core/Lookup.cpp
unittests/Tooling/CMakeLists.txt
unittes
Author: angelgarcia
Date: Thu Oct 22 08:23:46 2015
New Revision: 251015
URL: http://llvm.org/viewvc/llvm-project?rev=251015&view=rev
Log:
Don't use "auto" on loops over fundamental types in modernize-loop-convert.
Summary: using "auto" on a loop that iterates over ints is kind of an overkill.
Us
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: xazax
Date: Thu Oct 22 08:23:18 2015
New Revision: 251014
URL: http://llvm.org/viewvc/llvm-project?rev=251014&view=rev
Log:
Attempt to fix build bot test failures.
Modified:
cfe/trunk/lib/StaticAnalyzer/Core/IssueHash.cpp
cfe/trunk/test/Analysis/inlining/path-notes.m
Modified: cf
Author: angelgarcia
Date: Thu Oct 22 08:20:49 2015
New Revision: 251013
URL: http://llvm.org/viewvc/llvm-project?rev=251013&view=rev
Log:
Correctly print the type in modernize-make-unique.
Summary: Take into account the current LangOptions the check has to add back
the template argument.
Review
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
dkrupp added a comment.
Hi,
its a good idea to include in LLVM/Clang i will propose it
In http://reviews.llvm.org/D12906#272265, @zaks.anna wrote:
> Hi Daniel,
>
> Have you considered contributing this work to clang/llvm?
It's a good idea I will propose this at cfe-dev.
Daniel
http://revie
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
Take into account the current LangOptions the check has to add back the
template argument.
http://reviews.llvm.org/D13983
Files:
clang-tidy/modernize/MakeUniqueCheck.cp
xazax.hun added a comment.
In http://reviews.llvm.org/D12906#273088, @honggyu.kim wrote:
> In http://reviews.llvm.org/D12906#272257, @dkrupp wrote:
>
> > Hi Anna & Kim,
>
>
> Hi Daniel,
>
> > we recognized these scalability issues you just described and that's why we
> > created CodeChecker http
honggyu.kim added a comment.
In http://reviews.llvm.org/D12906#272257, @dkrupp wrote:
> Hi Anna & Kim,
Hi Daniel,
> we recognized these scalability issues you just described and that's why we
> created CodeChecker https://github.com/Ericsson/codechecker/
> tool. A HTML report viewer for Cla
honggyu.kim added a comment.
Hi Anna,
In http://reviews.llvm.org/D12906#272243, @zaks.anna wrote:
> I think you misunderstood my comment. I am not talking about using the
> existing HTML files here but rather having an HTML viewer, which you could
> use to browse source code. This viewer would
angelgarcia updated this revision to Diff 38119.
angelgarcia added a comment.
Add a guard to check that ElemType is not null.
http://reviews.llvm.org/D13982
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/modernize/LoopConvertCheck.h
test/clang-tidy/modernize-loop-convert-basi
bkramer updated this revision to Diff 38117.
bkramer added a comment.
- Removed "fully qualified" in favor of just "qualified" to clarify that the
name should be qualified but the leading "::" is not necessary.
- Renamed isNameSpecifierGlobal
- Removed always true conditional from test
http://r
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
using "auto" on a loop that iterates over ints is kind of an overkill. Use the
real type name instead.
http://reviews.llvm.org/D13982
Files:
clang-tidy/modernize/LoopCo
xazax.hun added a comment.
In http://reviews.llvm.org/D10305#272013, @honggyu.kim wrote:
> Hi Gabor,
>
> I was away from the office for 3 weeks so I couldn't catch up the issues but
> you almost completed the patch now.
> Thanks for this work!
>
> I just found a tiny problem and described it in
xazax.hun closed this revision.
xazax.hun added a comment.
Committed in r251011.
http://reviews.llvm.org/D10305
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: klimek
Date: Thu Oct 22 06:31:44 2015
New Revision: 251010
URL: http://llvm.org/viewvc/llvm-project?rev=251010&view=rev
Log:
Add %check_clang_tidy and %clang_tidy_diff.
With this, site specific lit configs can inject parameters into the
test scripts if they need site specific parameters.
Author: d0k
Date: Thu Oct 22 06:26:35 2015
New Revision: 251009
URL: http://llvm.org/viewvc/llvm-project?rev=251009&view=rev
Log:
[AST] Remove redundant template keywords.
GCC complains about them, clang does not.
Modified:
cfe/trunk/lib/AST/ASTContext.cpp
Modified: cfe/trunk/lib/AST/ASTCon
This revision was automatically updated to reflect the committed changes.
Closed by commit rL251008: [AST] Store Decl* and Stmt* directly into the
ParentMap. (authored by d0k).
Changed prior to commit:
http://reviews.llvm.org/D13976?vs=38105&id=38110#toc
Repository:
rL LLVM
http://reviews.l
Author: d0k
Date: Thu Oct 22 06:21:40 2015
New Revision: 251008
URL: http://llvm.org/viewvc/llvm-project?rev=251008&view=rev
Log:
[AST] Store Decl* and Stmt* directly into the ParentMap.
These are by far the most common types to be parents in the AST so it makes
sense to optimize for them. Put th
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Comment at: include/clang/AST/ASTContext.h:463
@@ +462,3 @@
+ class DynTypedNodeList {
+typedef ast_type_traits::DynTypedNode DynTypedNode;
+typedef ArrayRef ARef;
mkuper created this revision.
mkuper added reviewers: rnk, rafael.
mkuper added a subscriber: cfe-commits.
mkuper added a dependency: D13977: [X86] Add elfiamcu triple support, and a
workaround for PR3997.
Herald added a subscriber: aemerson.
The MCU psABI has a calling convention that is somewh
bkramer created this revision.
bkramer added reviewers: klimek, djasper.
bkramer added a subscriber: cfe-commits.
These are by far the most common types to be parents in the AST so it makes
sense to optimize for them. Put them directly into the value of the map.
This currently saves 32 bytes per p
klimek added a subscriber: klimek.
klimek added a comment.
A test that fails before this patch and passes afterwards is needed :) If you
need help writing that test, let me know.
http://reviews.llvm.org/D13973
___
cfe-commits mailing list
cfe-commi
Author: angelgarcia
Date: Thu Oct 22 04:48:23 2015
New Revision: 251005
URL: http://llvm.org/viewvc/llvm-project?rev=251005&view=rev
Log:
Make string constants in the modernize module static.
Summary: Add static to global variables, if they are not in an anonymous
namespace.
Reviewers: klimek
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
http://reviews.llvm.org/D13975
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added a subscriber: cfe-commits.
Add static to global variables, if they are not in an anonymous namespace.
http://reviews.llvm.org/D13975
Files:
clang-tidy/modernize/LoopConvertCheck.cpp
clang-tidy/moderniz
sdardis updated the summary for this revision.
sdardis updated this revision to Diff 38102.
sdardis marked 3 inline comments as done.
sdardis added a comment.
Nits addressed and XFAIL tests added for functions having arguments and the
interrupt attribute.
Test added to cover semantic warnings.
labath resigned from this revision.
labath removed a reviewer: labath.
labath added a comment.
I'll just observe this one. Someone with more knowledge of clang needs to
review this.
Repository:
rL LLVM
http://reviews.llvm.org/D13959
___
cfe-comm
Author: majnemer
Date: Thu Oct 22 02:15:56 2015
New Revision: 250997
URL: http://llvm.org/viewvc/llvm-project?rev=250997&view=rev
Log:
[MS ABI] Mangle static anonymous unions
We believed that internal linkage variables at global scope which are
not variable template specializations did not have t
60 matches
Mail list logo
