DavidKreitzer added inline comments. ================ Comment at: lib/CodeGen/TargetInfo.cpp:1239 @@ +1238,3 @@ + // The MCU psABI allows passing parameters in-reg even if there are + // earlier, parameters that are passed on the stack. Also, + // it does not allow passing >8-byte structs in-register, ---------------- Minor nit - you don't need the comma after "earlier".
================ Comment at: test/CodeGen/x86_32-arguments-iamcu.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -w -triple i386-pc-elfiamcu -mfloat-abi soft -emit-llvm -o - %s | FileCheck %s + ---------------- Good test! I think it would be a good idea to add a varargs function & verify that the args do not get marked inreg. http://reviews.llvm.org/D13978 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
