danielmarjamaki added a subscriber: danielmarjamaki.
danielmarjamaki added a comment.
Interesting checker.
I'll test it on some debian projects.
If you're interested.. it does not currently warn about "1.0 < 2.0 < 3.0" as
far as I see.
http://reviews.llvm.org/D13643
___
delena added a comment.
LGTM
http://reviews.llvm.org/D13861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added a comment.
I agree with Reid that you should not be adding a DenseMap to Sema for this.
Just build a SubscriptExpr for the syntactic form and have it yield an
expression of pseudo-object type; or you can make your own AST node for it if
that makes things easier.
http://reviews
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250795: [DEBUG INFO] Emit debug info for type used in
explicit cast only. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D13582?vs=37476&id=37825#toc
Repository:
rL LLVM
htt
Author: abataev
Date: Mon Oct 19 23:24:12 2015
New Revision: 250795
URL: http://llvm.org/viewvc/llvm-project?rev=250795&view=rev
Log:
[DEBUG INFO] Emit debug info for type used in explicit cast only.
Currently debug info for types used in explicit cast only is not emitted. It
happened after a pat
Hello everyone,
LLVM buildmaster will restarted in few minutes.
Thank you for understanding.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote:
> On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva
>> wrote:
>>
>>> On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith
>>> wrote:
>>>
On Fr
On Fri, Oct 16, 2015 at 6:41 PM, Richard Smith
wrote:
> On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva wrote:
>
>> On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith
>> wrote:
>>
>>> On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva
>>> wrote:
>>>
On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith
w
george.burgess.iv added a subscriber: george.burgess.iv.
george.burgess.iv added a comment.
This looks like a good check -- thanks for adding it! Just one small nit for
you.
Comment at: clang-tidy/modernize/UseDefaultCheck.cpp:19
@@ +18,3 @@
+
+const char CtorDtor[] = "CtorDtor
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Will be good idea to add handling of cases where default constructor is empty
and only call base class(es) default constructor/members default constructors
(see http://en.cppreference.com/w/cpp/language/default_co
ahatanak updated this revision to Diff 37816.
ahatanak added a comment.
Address review comments:
1. Renamed the attribute to "not_tail_called".
I chose "not_tail_called" over "notailcall" or "notail" to better distinguish
it from the attribute that is proposed in http://reviews.llvm.org/D12547
Author: rnk
Date: Mon Oct 19 19:31:42 2015
New Revision: 250774
URL: http://llvm.org/viewvc/llvm-project?rev=250774&view=rev
Log:
Revert "Diagnose UnresolvedLookupExprs that resolve to instance members in
static methods"
This reverts commit r250592.
It has issues around unevaluated contexts, li
rnk added a subscriber: rnk.
rnk added a comment.
I spent some time reading through the pseudo-object implementation in clang,
but I still don't understand it. We should ask John if he can review this.
My gut feeling is that we shouldn't have a global DenseMap in Sema just for
this. Should we h
Author: ctopper
Date: Mon Oct 19 19:00:17 2015
New Revision: 250764
URL: http://llvm.org/viewvc/llvm-project?rev=250764&view=rev
Log:
[X86] Remove a few 'else' after 'return'
Modified:
cfe/trunk/lib/Basic/Targets.cpp
Modified: cfe/trunk/lib/Basic/Targets.cpp
URL:
http://llvm.org/viewvc/llvm
> On Oct 15, 2015, at 8:29 AM, Benjamin Kramer via cfe-commits
> wrote:
>
> Author: d0k
> Date: Thu Oct 15 10:29:40 2015
> New Revision: 250418
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250418&view=rev
> Log:
> [CodeGen] Remove dead code. NFC.
>
> Modified:
>cfe/trunk/lib/CodeGen/C
Author: majnemer
Date: Mon Oct 19 18:22:49 2015
New Revision: 250757
URL: http://llvm.org/viewvc/llvm-project?rev=250757&view=rev
Log:
[MS ABI] Give linkonce_odr, instead of external_linkage, to certain kinds of
static data members
Out-of-line definitions of static data members which have an inl
mgehre updated this revision to Diff 37814.
mgehre added a comment.
Only flag va_arg and variadic call. Suppress warning if the only vararg
argument is literal 0.
http://reviews.llvm.org/D13787
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
clang-tidy/cppcoreguidelines/CppCoreGuideline
Ugh, looks like I missed a submodule for stdio.h :(
On Oct 19, 2015 11:34 AM, "Adrian Prantl" wrote:
> While building module 'std' imported from
> /Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/cassert:20:
> While building module 'Darwin' imported from
> /Volumes/Data/llvm/_build.n
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1962
@@ +1961,3 @@
+[LineNum][ColNum];
+assert(Entry.Order != -1u && "Entry not initialized!");
+assert(!Entry.Addr && !Entry.ID && "Entry registered alre
sfantao updated this revision to Diff 37802.
sfantao added a comment.
Use `GlobalDecl` to forward information about the name of OpenMP region's
enclosing function to the OpenMP outlined functions. This replaces the initial
implementation that was using a stack to keep this information.
Add regr
On Mon, Oct 19, 2015 at 2:49 PM, Samuel Benzaquen via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: sbenza
> Date: Mon Oct 19 16:49:51 2015
> New Revision: 250742
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250742&view=rev
> Log:
> Added check uniqueptr-delete-release to replace
Author: sbenza
Date: Mon Oct 19 16:49:51 2015
New Revision: 250742
URL: http://llvm.org/viewvc/llvm-project?rev=250742&view=rev
Log:
Added check uniqueptr-delete-release to replace "delete x.release()" with "x =
nullptr"
Reviewers: alexfh
Differential Revision: http://reviews.llvm.org/D13179
A
sbenza added inline comments.
Comment at: test/clang-tidy/cppcoreguidelines-pro-type-vararg.cpp:27
@@ +26,3 @@
+template
+void CallFooIfAvailableImpl(T& t, ...) {
+}
You would still warn on the callers of this.
Maybe we should ignore any call if the variadic part
sbenza added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:26
@@ +25,3 @@
+ Finder->addMatcher(
+ varDecl(hasType(pointsTo(cxxRecordDecl(hasName("__va_list_tag")
+ .bind("va_list"),
Is there a way to look for t
While building module 'std' imported from
/Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/cassert:20:
While building module 'Darwin' imported from
/Volumes/Data/llvm/_build.ninja.release/bin/../include/c++/v1/ctype.h:39:
In file included from :95:
In file included from
/Xcode.app/C
eugenis added a comment.
In http://reviews.llvm.org/D10677#266595, @EricWF wrote:
> For the most part this looks good. I'm a touch concerned though about the
> changes to the static initialization. The initializer is moved from within
> the function body to outside it. Could you have somebody c
eugenis updated this revision to Diff 37795.
eugenis marked 3 inline comments as done.
Repository:
rL LLVM
http://reviews.llvm.org/D10677
Files:
include/__config
include/deque
test/libcxx/containers/sequences/deque/incomplete.pass.cpp
Index: test/libcxx/containers/sequences/deque/incomp
t.p.northover created this revision.
t.p.northover added a subscriber: cfe-commits.
t.p.northover set the repository for this revision to rL LLVM.
When a struct's size is not a power of 2, the corresponding _Atomic() type is
promoted to the nearest. We already correctly handled normal C++ express
mgehre updated this revision to Diff 37790.
mgehre added a comment.
Revert "[clang-tidy] add cert's VariadicFunctionDefCheck as
cppcoreguidelines-pro-type-vararg-def"; warn about va_* in this check (to allow
SFINAE)
http://reviews.llvm.org/D13787
Files:
clang-tidy/cppcoreguidelines/CMakeLis
On Mon, Oct 19, 2015 at 1:28 PM, Adrian Prantl via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
>
> On Oct 16, 2015, at 5:47 PM, Richard Smith wrote:
>
> Great, looks like progress. Next you need a correct module map for libc++
> that actually covers all of its headers :) Try the attached one
> On Oct 16, 2015, at 5:47 PM, Richard Smith wrote:
>
> Great, looks like progress. Next you need a correct module map for libc++
> that actually covers all of its headers :) Try the attached one.
>
Sorry for the delay.
With the updated module map I get
/Volumes/Data/llvm/_build.ninja.releas
False alarm. My bisect script was not robust enough and git bisect ended up
pointing to the wrong change.
Sorry for the noise.
--Artem
On Mon, Oct 19, 2015 at 2:05 AM, Filipe Cabecinhas wrote:
> I don't see this. Do you have a log for them?
>
> Thank you,
>
> Filipe
>
> On Fri, Oct 16, 2015 a
mgrabovsky updated this revision to Diff 37720.
mgrabovsky added a comment.
Change message wording
http://reviews.llvm.org/D13643
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/bool-compare.c
Index: test/Sema/bool-compare.c
=
milianw added a comment.
Looks good to me!
http://reviews.llvm.org/D13000
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
milianw added a comment.
Adding tests wouldn't hurt though, quite the contrary. Especially if it wasn't
tested before. Otherwise, this looks good to me.
http://reviews.llvm.org/D13001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
sbenza added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeVarargUseCheck.cpp:20
@@ +19,3 @@
+void ProTypeVarargUseCheck::registerMatchers(MatchFinder *Finder) {
+
Finder->addMatcher(callExpr(callee(functionDecl(isVariadic(.bind("expr"),
this);
+}
---
On Mon, Oct 19, 2015 at 7:45 PM, Hans Wennborg via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> hans added a comment.
>
> This is now part of the latest snapshot at http://llvm.org/builds/
> Seems to work :-)
>
> I had to dig around a bit to figure out where these settings are actually
> exp
rjmccall added a comment.
That looks great, thank you.
http://reviews.llvm.org/D13582
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hans added a comment.
This is now part of the latest snapshot at http://llvm.org/builds/
Seems to work :-)
I had to dig around a bit to figure out where these settings are actually
exposed. Should we mention that in the documentation somewhere? Actually, do we
even have any documentation for th
pgousseau updated this revision to Diff 37765.
pgousseau added a comment.
Following Gabor's review:
Remove changes to UncheckedReturn checker.
Add a test using the NonNullParamChecker checker.
Abstract the origin of the attributes.
An analyzer option "faux-attributes" is added. This is 'false' b
On Mon, Oct 19, 2015 at 4:24 AM, Daniel Jasper wrote:
> Hm, seems to me that this is broken either way. If config.h remains first,
> that is good, but the main #include is unlikely to remain second.
>
In practice, the first two lines are a block with two includes: config.h
first and the main hea
Author: nico
Date: Mon Oct 19 11:21:29 2015
New Revision: 250706
URL: http://llvm.org/viewvc/llvm-project?rev=250706&view=rev
Log:
clang-format: Use pipes instead of temporary files for most lit tests.
This makes the format tests look more like most other FileCheck tests in clang.
The multiple-i
thakis closed this revision.
thakis added a comment.
Landed in r250706 (with rewrapped lines). Thanks!
http://reviews.llvm.org/D13852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dnovillo
Date: Mon Oct 19 10:53:17 2015
New Revision: 250705
URL: http://llvm.org/viewvc/llvm-project?rev=250705&view=rev
Log:
Sample Profiles - Fix location of binary encoding documentation. NFC.
Modified:
cfe/trunk/docs/UsersManual.rst
Modified: cfe/trunk/docs/UsersManual.rst
URL:
angelgarcia created this revision.
angelgarcia added a reviewer: klimek.
angelgarcia added subscribers: cfe-commits, alexfh.
Add a check that replaces empty bodies of special member functions with '=
default;'.
For now, it is only implemented for the default constructor and the destructor,
which
danielmarjamaki added a comment.
In http://reviews.llvm.org/D13126#270193, @danielmarjamaki wrote:
> > It might be more useful if you could print the paths on which the errors
> > occurred (this could be done for text output with -analyzer-output=text)
>
>
> Sounds good. Is it possible to use it
emaste added a subscriber: emaste.
Users:
joerg (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
http://reviews.llvm.org/rL248379
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
danielmarjamaki added a comment.
> It might be more useful if you could print the paths on which the errors
> occurred (this could be done for text output with -analyzer-output=text)
Sounds good. Is it possible to use it with scan-build?
Comment at: lib/StaticAnalyzer/Checker
andreadb created this revision.
andreadb added reviewers: bruno, mkuper, delena, qcolombet.
andreadb added a subscriber: cfe-commits.
Hi,
This patch is a follow up of D13776.
According to the Intel documentation, the mask operand of a maskload and
maskstore intrinsics is always a vector of packe
klimek added a comment.
+1 to "not tested before" not implying "doesn't need tests" :)
http://reviews.llvm.org/D13001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
Thx Milinan; this also looks fine from a binary compatibility perspective ...
http://reviews.llvm.org/D13000
___
cfe-commits mailing list
cfe-com
Hm, seems to me that this is broken either way. If config.h remains first,
that is good, but the main #include is unlikely to remain second. I think
we should give the main #include a non-zero #include category and then
properly configure config.h to be before that. I'll try to get to that this
wee
klimek accepted this revision.
klimek added a reviewer: klimek.
klimek added a comment.
This revision is now accepted and ready to land.
I'd slightly prefer if the commands were still on their own line (via escaped
newlines if that's possible), but lg.
http://reviews.llvm.org/D13852
Author: mkurdej
Date: Mon Oct 19 05:08:35 2015
New Revision: 250694
URL: http://llvm.org/viewvc/llvm-project?rev=250694&view=rev
Log:
Added new options to ClangFormat VSIX package.
Summary:
Added new options to ClangFormat VSIX package:
* fallback-style
* assume-filename
* sort-includes.
Changed
danielmarjamaki added a comment.
In http://reviews.llvm.org/D12359#233152, @sberg wrote:
> causes false positive for
>
> char * f(char *);
> char * g(char * p) { return f(p); }
>
Sorry for replying this late. This should work in latest patch.
Comment at: include/clang/Bas
danielmarjamaki updated this revision to Diff 37728.
danielmarjamaki marked an inline comment as done.
danielmarjamaki added a comment.
Fix FN for code:
const char *ret(char *p) {
return p ? p : "";
}
http://reviews.llvm.org/D12359
Files:
include/clang/AST/Decl.h
include/clang/Basic/Di
Using these as the default comparison operators might not make much sense,
as they don't take into account all the fields (they only look at
ClangTidyError::Message). But here I just wanted to mimic existing
behavior, so honestly I don't know.
I implemented equality with !<&&!< to improve maintain
On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva wrote:
>
>> On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith
>> wrote:
>>
>>> On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva
>>> wrote:
>>>
On Fri, Oc
I don't see this. Do you have a log for them?
Thank you,
Filipe
On Fri, Oct 16, 2015 at 11:52 PM, Artem Belevich via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Filipe,
>
> FYI, this change appears to introduce a somewhat subtle problem. clang
> compiled with itself starts producing (f
Author: klimek
Date: Mon Oct 19 03:43:46 2015
New Revision: 250691
URL: http://llvm.org/viewvc/llvm-project?rev=250691&view=rev
Log:
Fix 'will be initialized after' warning.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/vi
Author: klimek
Date: Mon Oct 19 03:27:51 2015
New Revision: 250690
URL: http://llvm.org/viewvc/llvm-project?rev=250690&view=rev
Log:
Make test not rely on %T ending on /Output.
Modified:
cfe/trunk/test/Driver/ps4-linker-non-win.c
Modified: cfe/trunk/test/Driver/ps4-linker-non-win.c
URL:
htt
This revision was automatically updated to reflect the committed changes.
Closed by commit rL250689: [X86] Enable soft float ABI for x86 (authored by
mkuper).
Changed prior to commit:
http://reviews.llvm.org/D13554?vs=36853&id=37723#toc
Repository:
rL LLVM
http://reviews.llvm.org/D13554
Fi
Author: mkuper
Date: Mon Oct 19 03:09:43 2015
New Revision: 250689
URL: http://llvm.org/viewvc/llvm-project?rev=250689&view=rev
Log:
[X86] Enable soft float ABI for x86
The Intel MCU psABI requires floating-point values to be passed in-reg.
This makes the x86-32 ABI code respect "-mfloat-abi soft
Author: mkuper
Date: Mon Oct 19 02:52:25 2015
New Revision: 250687
URL: http://llvm.org/viewvc/llvm-project?rev=250687&view=rev
Log:
Use saner variable names. NFC.
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/viewvc/llvm-
64 matches
Mail list logo
