False alarm. My bisect script was not robust enough and git bisect ended up pointing to the wrong change. Sorry for the noise.
--Artem On Mon, Oct 19, 2015 at 2:05 AM, Filipe Cabecinhas <m...@filcab.net> wrote: > I don't see this. Do you have a log for them? > > Thank you, > > Filipe > > On Fri, Oct 16, 2015 at 11:52 PM, Artem Belevich via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Filipe, >> >> FYI, this change appears to introduce a somewhat subtle problem. clang >> compiled with itself starts producing (false positive?) warnings about >> uninitialized variables. I didn't get a chance to dig deeper yet. >> >> --Artem >> >> On Fri, Oct 16, 2015 at 8:07 AM, Filipe Cabecinhas via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: filcab >>> Date: Fri Oct 16 10:07:48 2015 >>> New Revision: 250514 >>> >>> URL: http://llvm.org/viewvc/llvm-project?rev=250514&view=rev >>> Log: >>> PS4: Make sure to add the sanitizer runtime before any linker input >>> >>> Modified: >>> cfe/trunk/lib/Driver/Tools.cpp >>> >>> Modified: cfe/trunk/lib/Driver/Tools.cpp >>> URL: >>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=250514&r1=250513&r2=250514&view=diff >>> >>> ============================================================================== >>> --- cfe/trunk/lib/Driver/Tools.cpp (original) >>> +++ cfe/trunk/lib/Driver/Tools.cpp Fri Oct 16 10:07:48 2015 >>> @@ -10017,6 +10017,8 @@ static void ConstructPS4LinkJob(const To >>> assert(Output.isNothing() && "Invalid output."); >>> } >>> >>> + AddPS4SanitizerArgs(ToolChain, CmdArgs); >>> + >>> Args.AddAllArgs(CmdArgs, options::OPT_L); >>> Args.AddAllArgs(CmdArgs, options::OPT_T_Group); >>> Args.AddAllArgs(CmdArgs, options::OPT_e); >>> @@ -10034,7 +10036,6 @@ static void ConstructPS4LinkJob(const To >>> } >>> >>> AddPS4ProfileRT(ToolChain, Args, CmdArgs); >>> - AddPS4SanitizerArgs(ToolChain, CmdArgs); >>> >>> const char *Exec = >>> Args.MakeArgString(ToolChain.GetProgramPath("ps4-ld")); >>> >>> @@ -10087,6 +10088,8 @@ static void ConstructGoldLinkJob(const T >>> assert(Output.isNothing() && "Invalid output."); >>> } >>> >>> + AddPS4SanitizerArgs(ToolChain, CmdArgs); >>> + >>> if (!Args.hasArg(options::OPT_nostdlib) && >>> !Args.hasArg(options::OPT_nostartfiles)) { >>> const char *crt1 = NULL; >>> @@ -10214,7 +10217,6 @@ static void ConstructGoldLinkJob(const T >>> } >>> >>> AddPS4ProfileRT(ToolChain, Args, CmdArgs); >>> - AddPS4SanitizerArgs(ToolChain, CmdArgs); >>> >>> const char *Exec = >>> #ifdef LLVM_ON_WIN32 >>> >>> >>> _______________________________________________ >>> cfe-commits mailing list >>> cfe-commits@lists.llvm.org >>> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >>> >> >> >> >> -- >> --Artem Belevich >> >> _______________________________________________ >> cfe-commits mailing list >> cfe-commits@lists.llvm.org >> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits >> >> > -- --Artem Belevich
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
