Re: [PATCH] Fix typo

Thanks! LGTM. Do you need someone to commit this for you? vedant On Aug 18, 2015, at 7:56 PM, Kai Zhao via cfe-commits wrote: > Hi, > > This is my first patch for clang. It fixes 4 typos: > > "targetted" -> "targeted" > "becuase" -> "because" > "staically" -> "statically" > "vitual" -> "virt

Re: [PATCH] D12155: ARM: Error out on apple darwin platforms if float-abi is "hard"

vsk added a subscriber: vsk. vsk added a comment. LGTM. http://reviews.llvm.org/D12155 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11976: [libclang] Return deduced type for auto type, not the one written in the source.

puremourning added a comment. I can confirm that this patch fixes a number test cases found in ycmd (a code-completion server). Specifically these ones marked as 'sic' So I

[libcxx] r245806 - Recommit rL245802: Cleanup fancy pointer rebinding in list using __rebind_pointer.

Author: ericwf Date: Sat Aug 22 21:56:05 2015 New Revision: 245806 URL: http://llvm.org/viewvc/llvm-project?rev=245806&view=rev Log: Recommit rL245802: Cleanup fancy pointer rebinding in list using __rebind_pointer. Currently we need an #ifdef branch every time we use pointer traits to rebind a

[libcxx] r245805 - Revert r245802. It violates the incomplete type requirements.

Author: ericwf Date: Sat Aug 22 21:39:20 2015 New Revision: 245805 URL: http://llvm.org/viewvc/llvm-project?rev=245805&view=rev Log: Revert r245802. It violates the incomplete type requirements. Modified: libcxx/trunk/include/list libcxx/trunk/include/memory Modified: libcxx/trunk/inc

[libcxx] r245802 - Cleanup fancy pointer rebinding in list using __rebind_pointer.

Author: ericwf Date: Sat Aug 22 21:34:18 2015 New Revision: 245802 URL: http://llvm.org/viewvc/llvm-project?rev=245802&view=rev Log: Cleanup fancy pointer rebinding in list using __rebind_pointer. Currently we need an #ifdef branch every time we use pointer traits to rebind a pointer because it

r245798 - [WinEH] Update to new EH pad/ret signatures (with tokens required)

Author: josepht Date: Sat Aug 22 19:26:48 2015 New Revision: 245798 URL: http://llvm.org/viewvc/llvm-project?rev=245798&view=rev Log: [WinEH] Update to new EH pad/ret signatures (with tokens required) Summary: The signatures of the methods in LLVM for creating EH pads/rets are changing to require

Re: [PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

delcypher added a comment. The rest LGTM Comment at: buildbot/osuosl/master/config/builders.py:1166 @@ +1165,3 @@ + 'name':"libcxx-sphinx-docs", + 'slavenames':["ericwf-buildslave2], + 'builddir':"libcxx-sphinx-docs", Is

r245794 - Improve the performance of resolving a lookup result. We usually don't need to

Author: rsmith Date: Sat Aug 22 16:37:34 2015 New Revision: 245794 URL: http://llvm.org/viewvc/llvm-project?rev=245794&view=rev Log: Improve the performance of resolving a lookup result. We usually don't need to pick the most recent declaration, and we can often tell which declaration is more rece

[libcxx] r245793 - Refactor shared_timed_mutex tests.

Author: ericwf Date: Sat Aug 22 16:24:01 2015 New Revision: 245793 URL: http://llvm.org/viewvc/llvm-project?rev=245793&view=rev Log: Refactor shared_timed_mutex tests. First I removed all of the uses of _LIBCPP_STD_VER and added LIT UNSUPPORTED tags to prevent the tests from being run in older s

[libcxx] r245790 - Fix default value for LLVM_INCLUDE_DOCS in out of tree build.

Author: ericwf Date: Sat Aug 22 15:26:42 2015 New Revision: 245790 URL: http://llvm.org/viewvc/llvm-project?rev=245790&view=rev Log: Fix default value for LLVM_INCLUDE_DOCS in out of tree build. Modified: libcxx/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake Modified: libcxx/trunk/cmake/Modul

[PATCH] D12265: [ZORG] Add support for libc++ to SphinxDocBuilder.py

EricWF created this revision. EricWF added reviewers: delcypher, silvas. EricWF added subscribers: llvm-commits, cfe-commits. http://reviews.llvm.org/D12265 Files: buildbot/osuosl/master/config/builders.py zorg/buildbot/builders/SphinxDocsBuilder.py Index: zorg/buildbot/builders/SphinxDocsBu

r245789 - [modules] Further simplification and speedup of redeclaration chain loading.

Author: rsmith Date: Sat Aug 22 15:13:39 2015 New Revision: 245789 URL: http://llvm.org/viewvc/llvm-project?rev=245789&view=rev Log: [modules] Further simplification and speedup of redeclaration chain loading. Instead of eagerly deserializing a list of DeclIDs when we load a module file and doing

[libcxx] r245788 - [libcxx] Add new Sphinx documentation

Author: ericwf Date: Sat Aug 22 14:40:49 2015 New Revision: 245788 URL: http://llvm.org/viewvc/llvm-project?rev=245788&view=rev Log: [libcxx] Add new Sphinx documentation Summary: This patch adds Sphinx based documentation to libc++. The goal is to make it easier to write documentation for libc+

Re: [PATCH] D12247: [libc++] remove possible trailing padding from aligned_storage

EricWF added a comment. I'm not sure I understand the problem. Is it possible to provide a minimal reproducer of the bug/behavior you are describing? http://reviews.llvm.org/D12247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

sfantao added a comment. Two more inlined comments that I forgot to integrate in my previous response. Thanks! Samuel Comment at: lib/CodeGen/CGOpenMPRuntime.h:190-204 @@ -180,2 +189,17 @@ + /// \brief Values for bit flags used to specify the mapping type for + /// offloading

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

rengolin added a comment. I'm surprised you decided to rearrange the output of the macros. It makes reviewing a lot harder. Is there some special reason to have that in any specific order? Comment at: lib/Basic/Targets.cpp:4621 @@ -4586,1 +4620,3 @@ +Builder.defineMacro("_

Re: [PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with a suitable FIXME comment. Email me if you want to split the work on adding this to the other SSE/AVX builtin tests. http://reviews.llvm.org/D12212 _

Re: r245779 - [modules] Rearrange how redeclaration chains are loaded, to remove a walk over

On 22/08/15 03:47, Richard Smith via cfe-commits wrote: Author: rsmith Date: Fri Aug 21 20:47:18 2015 New Revision: 245779 URL: http://llvm.org/viewvc/llvm-project?rev=245779&view=rev Log: [modules] Rearrange how redeclaration chains are loaded, to remove a walk over all modules and reduce the n

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

ismailp added inline comments. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749 @@ -748,3 @@ - - assert (Src != Dst && "Self-edges are not allowed."); - krememek wrote: > Did you look at the test case that causes this assertion to fail? I think i

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

ismailp updated this revision to Diff 32903. ismailp added a comment. - Change parameter name to `OutStream`. http://reviews.llvm.org/D12119 Files: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp test/Analysis/cfg.cpp Index: test/Analysis/cfg.cpp ==

Re: [PATCH] D11976: [libclang] Return deduced type for auto type, not the one written in the source.

skalinichev added a comment. This is actually an unrelated issue (clang_getTypeDeclaration doesn't handle the auto type) Using "c-index-test -test-print-type --std=c++14" on your example I get: VarDecl=z ... [type=std::basic_string] ... So, as you can see, "z" has correct type. Anyway here is